Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-10-30 Thread Dmitry Fleytman
Hello Jason, Thanks for reviewing. See my answers inline. > On 30 Oct 2015, at 07:28 AM, Jason Wang wrote: > > > > On 10/28/2015 01:44 PM, Jason Wang wrote: >> >> On 10/26/2015 01:00 AM, Leonid Bloch wrote: >>> Hello qemu-devel, >>> >>> This patch series is an RFC for the new networking de

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell wrote: > On 30 October 2015 at 20:59, Peter Crosthwaite > wrote: >> On Fri, Oct 30, 2015 at 1:49 PM, Peter Maydell >> wrote: >>> I thought you were planning to have the generic code do the >>> S->NS transition; but I guess it works better in the bo

Re: [Qemu-devel] [PATCH 01/34] linux-user: Fix array bounds in errno conversion

2015-10-30 Thread Laurent Vivier
Le 12/10/2015 15:42, Riku Voipio a écrit : > On perjantaina 11. syyskuuta 2015 13.59.29 EEST, Peter Maydell wrote: >> On 6 September 2015 at 00:56, Timothy E Baldwin >> wrote: >>> Check array bounds in host_to_target_errno() and target_to_host_errno(). >>> >>> Signed-off-by: Timothy Edward Baldw

Re: [Qemu-devel] [PATCH v2 0/2] Add an i.MX25 specific CCM driver

2015-10-30 Thread Jean-Christophe DUBOIS
Le 30/10/2015 21:50, Peter Crosthwaite a écrit : On Fri, Oct 30, 2015 at 1:24 PM, Peter Maydell wrote: On 28 October 2015 at 23:02, Jean-Christophe Dubois wrote: i.MX25 SOC has a different CCM device than i.MX31. Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows Linux to w

Re: [Qemu-devel] [PATCH v7 0/2] PTimer fix and ARM MPTimer conversion

2015-10-30 Thread Dmitry Osipenko
31.10.2015 00:52, Peter Maydell пишет: On 24 October 2015 at 13:21, Dmitry Osipenko wrote: Changelog for ARM MPTimer QEMUTimer to ptimer conversion: V2: Fixed changing periodic timer counter value "on the fly". I added a test to the gist to cover that issue. V3: Fixed start

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread John Snow
On 10/27/2015 12:02 AM, Peter Crosthwaite wrote: > This patch series adds bare-minimum Allwinner SATA support. > > P1 is a trivial to help debug AHCI. > > Changed since RFC: > Addressed Beniamino review. > Rebased to avoid bad deps (John Snow review) > > Regards, > Peter > > > Peter Crosthwa

Re: [Qemu-devel] [PATCH v2 5/5] arm: highbank: Implement PSCI and dummy monitor

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 21:32, Peter Crosthwaite wrote: > On Fri, Oct 30, 2015 at 2:10 PM, Peter Maydell > wrote: >> This still confuses me. What I was expecting to see was something like: >> >> /* Monitor mode vector table; entry points which will only be reached >> * if the guest kernel

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 3:04 PM, Peter Maydell wrote: > On 30 October 2015 at 21:24, Peter Crosthwaite > wrote: >> On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell >> wrote: >>> The other question is what happens on a board like this if >>> the user says -enable-kvm -cpu cortex-a15 ? Does that ge

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 21:24, Peter Crosthwaite wrote: > On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell > wrote: >> The other question is what happens on a board like this if >> the user says -enable-kvm -cpu cortex-a15 ? Does that get us >> a CPU without the EL3 property? (I forget...) In any ca

Re: [Qemu-devel] [PULL 00/12] Block patches

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 17:37, Peter Maydell wrote: > On 30 October 2015 at 14:19, Markus Armbruster wrote: >> Peter Maydell writes: >>> I get an error on 64-bit ARM running the ivshmem tests: >>> >>> TEST: tests/ivshmem-test... (pid=22948) >>> /i386/ivshmem/single:

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 21:40, John Snow wrote: > On 10/30/2015 05:37 PM, Peter Maydell wrote: >> Given the diffstat, are you planning to take this through >> the IDE tree? I'm happy for you to do that, I can just take >> this off my to-review list then :-) > If nobody has objections, I assumed tha

Re: [Qemu-devel] [PATCH v7 0/2] PTimer fix and ARM MPTimer conversion

2015-10-30 Thread Peter Maydell
On 24 October 2015 at 13:21, Dmitry Osipenko wrote: > Changelog for ARM MPTimer QEMUTimer to ptimer conversion: > > V2: Fixed changing periodic timer counter value "on the fly". I added a > test to the gist to cover that issue. > > V3: Fixed starting the timer with load = 0 and cou

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread John Snow
On 10/30/2015 05:37 PM, Peter Maydell wrote: > On 30 October 2015 at 21:34, John Snow wrote: >> >> >> On 10/30/2015 05:33 PM, Peter Crosthwaite wrote: >>> On Fri, Oct 30, 2015 at 2:28 PM, Peter Maydell >>> wrote: On 27 October 2015 at 04:02, Peter Crosthwaite wrote: > Peter Cros

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 21:34, John Snow wrote: > > > On 10/30/2015 05:33 PM, Peter Crosthwaite wrote: >> On Fri, Oct 30, 2015 at 2:28 PM, Peter Maydell >> wrote: >>> On 27 October 2015 at 04:02, Peter Crosthwaite >>> wrote: Peter Crosthwaite (4): ahci: Add some MMIO debug printfs >>>

Re: [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init()

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 21:20, Peter Crosthwaite wrote: > This series looks good, up to Peter if is qualifies for 2.5. It was > clearly on list well before soft freeze and really my tardiness as to > why it is late with review. So I'll make a case for inclusion. > > It does seem to be missing a cove

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread John Snow
On 10/30/2015 05:33 PM, Peter Crosthwaite wrote: > On Fri, Oct 30, 2015 at 2:28 PM, Peter Maydell > wrote: >> On 27 October 2015 at 04:02, Peter Crosthwaite >> wrote: >>> This patch series adds bare-minimum Allwinner SATA support. >>> >>> P1 is a trivial to help debug AHCI. >>> >>> Changed sin

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 2:28 PM, Peter Maydell wrote: > On 27 October 2015 at 04:02, Peter Crosthwaite > wrote: >> This patch series adds bare-minimum Allwinner SATA support. >> >> P1 is a trivial to help debug AHCI. >> >> Changed since RFC: >> Addressed Beniamino review. >> Rebased to avoid bad

Re: [Qemu-devel] [PATCH v2 5/5] arm: highbank: Implement PSCI and dummy monitor

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 2:10 PM, Peter Maydell wrote: > On 30 October 2015 at 05:35, Peter Crosthwaite > wrote: >> Firstly, enable monitor mode and PSCI, both are which are features of >> this board. >> >> In addition to PSCI, this board also uses SMC for cache maintainence >> ops. This means we

Re: [Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-30 Thread Peter Maydell
On 27 October 2015 at 04:02, Peter Crosthwaite wrote: > This patch series adds bare-minimum Allwinner SATA support. > > P1 is a trivial to help debug AHCI. > > Changed since RFC: > Addressed Beniamino review. > Rebased to avoid bad deps (John Snow review) > > Regards, > Peter > > > Peter Crosthwai

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell wrote: > On 30 October 2015 at 20:59, Peter Crosthwaite > wrote: >> On Fri, Oct 30, 2015 at 1:49 PM, Peter Maydell >> wrote: >>> I thought you were planning to have the generic code do the >>> S->NS transition; but I guess it works better in the bo

Re: [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init()

2015-10-30 Thread Peter Crosthwaite
This series looks good, up to Peter if is qualifies for 2.5. It was clearly on list well before soft freeze and really my tardiness as to why it is late with review. So I'll make a case for inclusion. It does seem to be missing a cover, and/or the in-reply-to looks a bit strange. Maybe patches mis

Re: [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init()

2015-10-30 Thread Peter Crosthwaite
Missing CC of Alistair for STM32F205. On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver wrote: > Change armv7m_init to return the DeviceState* for the NVIC. > This allows access to all GPIO blocks, not just the IRQ inputs. > Move qdev_get_gpio_in() calls out of armv7m_init() into > board code f

Re: [Qemu-devel] [PATCH v3 2/3] armv7-m: Implement SYSRESETREQ

2015-10-30 Thread Peter Crosthwaite
On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver wrote: > Implement the SYSRESETREQ bit of the AIRCR register > for armv7-m (ie. cortex-m3) to trigger a GPIO out. > > Signed-off-by: Michael Davidsaver Reviewed-by: Peter Crosthwaite > --- > hw/intc/armv7m_nvic.c | 9 - > 1 file chan

Re: [Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Max Reitz
On 30.10.2015 20:25, Jeff Cody wrote: > Commit 934659c switched the iotests to run qemu-io from a bash subshell, > in order to catch segfaults. This method is incompatible with the > current valgrind_qemu_io() bash function. > > Move the valgrind usage into the exec subshell in _qemu_io_wrapper()

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 20:59, Peter Crosthwaite wrote: > On Fri, Oct 30, 2015 at 1:49 PM, Peter Maydell > wrote: >> I thought you were planning to have the generic code do the >> S->NS transition; but I guess it works better in the board >> code (we have to go up into Monitor and back down again,

Re: [Qemu-devel] [PATCH v3 1/2] qemu-iotests: fix cleanup of background processes

2015-10-30 Thread Max Reitz
On 30.10.2015 20:25, Jeff Cody wrote: > Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash > subshell, in order to catch segfaults. Unfortunately, this means the > process PID cannot be captured via '$!'. We stopped killing qemu and > qemu-nbd processes, leaving a lot of orph

Re: [Qemu-devel] [PATCH v3 3/3] stellaris: exit on external reset request

2015-10-30 Thread Peter Crosthwaite
"arm: stellaris: " prefix in subject line. On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver wrote: > Add GPIO in for the stellaris board which calls > qemu_system_reset_request() on reset request. > > Signed-off-by: Michael Davidsaver Otherwise, Reviewed-by: Peter Crosthwaite Regards, Pet

Re: [Qemu-devel] [PATCH v2 5/5] arm: highbank: Implement PSCI and dummy monitor

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 05:35, Peter Crosthwaite wrote: > Firstly, enable monitor mode and PSCI, both are which are features of > this board. > > In addition to PSCI, this board also uses SMC for cache maintainence > ops. This means we need a secure monitor to catch these and nop them. > Use the ARM

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 1:49 PM, Peter Maydell wrote: > On 30 October 2015 at 05:34, Peter Crosthwaite > wrote: >> Add a flag that when set, will cause the primary CPU to start in secure >> mode, even if the overall boot in non-secure. This is useful for when > > "is non-secure". > >> there is a

Re: [Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions

2015-10-30 Thread Richard Henderson
On 10/29/2015 12:31 AM, Xiao Guangrong wrote: > These instructions are used by NVDIMM drivers and the specification > locates at: > https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf > > There instructions are available on Skylake Server > > Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH v2 0/2] Add an i.MX25 specific CCM driver

2015-10-30 Thread Peter Crosthwaite
On Fri, Oct 30, 2015 at 1:24 PM, Peter Maydell wrote: > On 28 October 2015 at 23:02, Jean-Christophe Dubois > wrote: >> i.MX25 SOC has a different CCM device than i.MX31. >> >> Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows >> Linux to work on top of the i.MX25 emultion but

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 05:34, Peter Crosthwaite wrote: > Add a flag that when set, will cause the primary CPU to start in secure > mode, even if the overall boot in non-secure. This is useful for when "is non-secure". > there is a board-setup blob that needs to run from secure mode, but > device

Re: [Qemu-devel] [PATCH v2 0/5] ARM: Machine specific boot blobs

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 05:34, Peter Crosthwaite wrote: > Hi, > > This adds support for machine-specific primary boot blobs. This can be > used to install little bits of firmware or boot code without having > to throw the whole QEMU bootloader out and BYO (with device drivers > and all). > > It is t

[Qemu-devel] [PULL] tilegx queued patch

2015-10-30 Thread Richard Henderson
0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tile-20151030 for you to fetch changes up to 2a080ce26682f35517b0e20f4ad10559e9270b5d: target-tilegx: Implement prefetch instructions in pipe y2 (2015-10-22 07:5

[Qemu-devel] [PULL] target-tilegx: Implement prefetch instructions in pipe y2

2015-10-30 Thread Richard Henderson
From: Chen Gang Originally, tilegx qemu only implement prefetch instructions in pipe x1, did not implement them in pipe y2. Signed-off-by: Chen Gang Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) di

Re: [Qemu-devel] [RFC v2] target-arm: Add and use symbolic names for register banks

2015-10-30 Thread Peter Maydell
On 29 October 2015 at 20:16, Soren Brinkmann wrote: > Add BANK_ #defines to index banked registers. > > Suggested-by: Peter Maydell > Signed-off-by: Soren Brinkmann > --- > v2: > - move #defines from cpu.h to internals.h > - drop ARM_ prefix in #defines > --- > target-arm/helper.c| 37 +++

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-10-30 Thread Denis V. Lunev
On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: +int rfifolock_is_locked(RFifoLock *r); Please use bool instead of int. diff --git a/util/rfifolock.c b/util/rfifolock.c index afbf748..8ac58cb 100644 --- a/util/rfifolock.c +++ b/u

Re: [Qemu-devel] [PATCH v2 0/2] Add an i.MX25 specific CCM driver

2015-10-30 Thread Peter Maydell
On 28 October 2015 at 23:02, Jean-Christophe Dubois wrote: > i.MX25 SOC has a different CCM device than i.MX31. > > Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows > Linux to work on top of the i.MX25 emultion but this is not correct. > > Furthermore, other SOC we could emulat

Re: [Qemu-devel] [PULL 00/25] QAPI patches

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 20:03, Eric Blake wrote: > On 10/30/2015 01:47 PM, Peter Maydell wrote: >> On 30 October 2015 at 15:42, Markus Armbruster wrote: > >>> char: Convert to new qapi union layout > >> Hi; I'm afraid this doesn't build on w32: >> >> /home/petmay01/linaro/qemu-for-merges/qemu

Re: [Qemu-devel] RFC: libyajl for JSON

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 19:45, Eric Blake wrote: > Loaded question in response to > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06988.html, but > posting as a new thread to call attention to it: > > Libvirt uses libyajl to parse and format JSON. Would it be worth > dragging in yet anoth

Re: [Qemu-devel] 4k seq read splitting for virtio-blk - possible workarounds?

2015-10-30 Thread Andrey Korolyov
> BTW it seems that I made a little stronger claim than it is actually - > at least 3.18 works fine in all cases, so the issue was fixed a bit > earlier than in 4.2. Ok, it turns out that the fix was brought by commit 447f05bb488bff4282088259b04f47f0f9f76760 Author: Akinobu Mita Date: Thu Oct

Re: [Qemu-devel] [PULL 00/25] QAPI patches

2015-10-30 Thread Eric Blake
On 10/30/2015 01:47 PM, Peter Maydell wrote: > On 30 October 2015 at 15:42, Markus Armbruster wrote: >> char: Convert to new qapi union layout > Hi; I'm afraid this doesn't build on w32: > > /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function > ‘qmp_chardev_open_file’: > /home/

[Qemu-devel] [PATCH] fixup! char: Convert to new qapi union layout

2015-10-30 Thread Eric Blake
Fix build failure on w32 Signed-off-by: Eric Blake --- Hopefully, this is the only use of qapi union types hiding behind #ifdefs (I relied on the compiler to tell me which spots need conversion, but that doesn't work for spots that aren't compiled in my setup) qemu-char.c | 4 ++-- 1 file chan

Re: [Qemu-devel] [PULL 00/25] QAPI patches

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 15:42, Markus Armbruster wrote: > The following changes since commit fdf927621a99711bf1a81712bce054794f2d44c3: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-10-30' > into staging (2015-10-30 09:41:15 +) > > are available in the git repository

[Qemu-devel] RFC: libyajl for JSON

2015-10-30 Thread Eric Blake
Loaded question in response to https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06988.html, but posting as a new thread to call attention to it: Libvirt uses libyajl to parse and format JSON. Would it be worth dragging in yet another prerequisite library into qemu and reuse libyajl's parse

Re: [Qemu-devel] RFC: Add support for KVM_CAP_SPLIT_IRQCHIP

2015-10-30 Thread Matt Gingell
Hi Eric, Thanks for your feedback, I’ve made the updates you suggested. > Your diff doesn't include the usual '---' separator and diffstat > provided by 'git send-email'; making it a bit harder to see at a glance > what your patch touches. OK, understood. I’ll will use git send-email going forwa

[Qemu-devel] [PATCH RESEND v2 3/3] megasas: Use qemu_hw_version() instead of QEMU_VERSION

2015-10-30 Thread Eduardo Habkost
Guest visible data shouldn't change with a simple QEMU upgrade, so use qemu_hw_version() to ensure it won't change (as long as the machine class being used has hw_version set). Cc: Hannes Reinecke Cc: Paolo Bonzini Cc: qemu-bl...@nongnu.org Reviewed-by: Hannes Reinecke Acked-by: Laszlo Ersek S

[Qemu-devel] [PATCH RESEND v2 1/3] pc: Set hw_version on all machine classes

2015-10-30 Thread Eduardo Habkost
In 2012, QEMU had a bug where it exposed QEMU version information to the guest, meaning a QEMU upgrade would expose different hardware to the guest OS even if the same machine-type is being used. The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, on all machines up to pc-1.0. Bu

[Qemu-devel] [PATCH RESEND v2 0/3] pc: Set hw_version on all machine classes

2015-10-30 Thread Eduardo Habkost
In 2012, QEMU had a bug where it exposed QEMU version information to the guest, meaning a QEMU upgrade would expose different hardware to the guest OS even if the same machine-type is being used. The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, on all machines up to pc-1.0. Bu

[Qemu-devel] [PATCH RESEND v2 2/3] osdep: Rename qemu_{get, set}_version() to qemu_{, set_}hw_version()

2015-10-30 Thread Eduardo Habkost
This makes the purpose of the function clearer: it is not about the version of QEMU that's running, but the version string exposed in the emulated hardware. Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: John Snow Cc: Paolo Bonzini Reviewed-by: John Snow Signed-off-by: Eduardo Habkost --- hw/

Re: [Qemu-devel] [kvm-unit-tests PATCHv5 3/3] arm: pmu: Add CPI checking

2015-10-30 Thread Christopher Covington
Hi Drew, On 10/30/2015 09:00 AM, Andrew Jones wrote: > On Wed, Oct 28, 2015 at 03:12:55PM -0400, Christopher Covington wrote: >> Calculate the numbers of cycles per instruction (CPI) implied by ARM >> PMU cycle counter values. The code includes a strict checking facility >> intended for the -icoun

Re: [Qemu-devel] [PATCH v2 0/2] trace: fix Makefile dependencies

2015-10-30 Thread Lluís Vilanova
Stefan Hajnoczi writes: > v2: > * Use find(1) to catch all tracetool *.py files [Lluís] >Note: I used find -name instead of find -path for better POSIX compliance Looks great to me. Thanks, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the

[Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Jeff Cody
Commit 934659c switched the iotests to run qemu-io from a bash subshell, in order to catch segfaults. This method is incompatible with the current valgrind_qemu_io() bash function. Move the valgrind usage into the exec subshell in _qemu_io_wrapper(), while making sure the original return value is

[Qemu-devel] [PATCH v3 1/2] qemu-iotests: fix cleanup of background processes

2015-10-30 Thread Jeff Cody
Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash subshell, in order to catch segfaults. Unfortunately, this means the process PID cannot be captured via '$!'. We stopped killing qemu and qemu-nbd processes, leaving a lot of orphaned, running qemu processes after executing i

[Qemu-devel] [PATCH v3 0/2] qemu-iotests: fix cleanup of background processes

2015-10-30 Thread Jeff Cody
Changes from v2: * Pulled patch 2 into this series * Patch 1: Moved non-empty test conditionals inside pid file existance check (thanks Max) Added a fix in for patch 058, for its self-launched qemu-nbd instance (thanks Max) * Patch 2: Only print the valgrind log

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test the reopening of overlay_bs in 'block-commit'

2015-10-30 Thread Max Reitz
On 28.10.2015 14:43, Alberto Garcia wrote: > The 'block-commit' command needs the overlay image of 'top' to > be opened in read-write mode in order to update the backing file > string. If 'top' is not the active layer or its backing file then its > overlay needs to be reopened during the block job.

Re: [Qemu-devel] [PATCH 1/2] commit: reopen overlay_bs before base

2015-10-30 Thread Max Reitz
On 28.10.2015 14:43, Alberto Garcia wrote: > 'block-commit' needs write access to two different nodes of the chain: > > - 'base', because that's where the data is written to. > - the overlay of 'top', because it needs to update the backing file > string to point to 'base' after the operation. >

Re: [Qemu-devel] [PATCH 0/3] target-i386: Don't trigger "check" warnings by default in KVM mode

2015-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2015 at 05:00:57PM -0200, Eduardo Habkost wrote: > The x86 change to make "check" mode be enabled by default made QEMU print a > warning in the default case if running in an Intel host: > > $ qemu-system-x86_64 -machine pc,accel=kvm > warning: host doesn't support requested fea

[Qemu-devel] [PATCH 3/3] target-i386: Don't enable SSE4A by default with KVM

2015-10-30 Thread Eduardo Habkost
The x86 change to make "check" mode be enabled by default made QEMU print a warning in the default case if running in an Intel host: $ qemu-system-x86_64 -machine pc,accel=kvm warning: host doesn't support requested feature: CPUID.8001H:ECX.sse4a [bit 6] Fix this by not enabling sse4a in

[Qemu-devel] [PATCH 1/3] target-i386: Add optional class name to kvm_default_props

2015-10-30 Thread Eduardo Habkost
This will allow us to define class-specific KVM defaults, instead of defaults that apply to all CPU models. If this table is starting to look like the global properties tables, that's not a coincidence: in the future, we might convert this to accelerator-specific code that simply register global p

[Qemu-devel] [PATCH 2/3] pc: Create pc_compat_2_4() function

2015-10-30 Thread Eduardo Habkost
We will need to call x86_cpu_change_kvm_default() for pc-2.4 too, so we will need a pc_compat_2_4() function. I plan to fix this by adding a kvm_defaults list to PCMachineClass later, but while we don't have that, let's do it the easy way and add the new function. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH 0/3] target-i386: Don't trigger "check" warnings by default in KVM mode

2015-10-30 Thread Eduardo Habkost
The x86 change to make "check" mode be enabled by default made QEMU print a warning in the default case if running in an Intel host: $ qemu-system-x86_64 -machine pc,accel=kvm warning: host doesn't support requested feature: CPUID.8001H:ECX.sse4a [bit 6] Fix this by not enabling sse4a in

Re: [Qemu-devel] [PATCH v8 32/54] Postcopy: Maintain sentmap and calculate discard

2015-10-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Where postcopy is preceeded by a period of precopy, the destination will > > have received pages that may have been dirtied on the source after the > > page was sent. T

Re: [Qemu-devel] [PULL 00/05] seccomp branch queue

2015-10-30 Thread Andrew Jones
2015-10-12' > > into staging (2015-10-13 10:42:06 +0100) > > > > are available in the git repository at: > > > > git://github.com/otubo/qemu.git tags/pull-seccomp-20151030 > > > > for you to fetch changes up to b1e1f0bbe7268d0bb8f63da220b41803b2e5408

Re: [Qemu-devel] [PATCH 0/2] Don't allow snapshots if the overlay has parent nodes

2015-10-30 Thread Max Reitz
On 29.10.2015 14:00, Alberto Garcia wrote: > There are several sanity checks for the 'blockdev-snapshot' command, > but none covers the use of a file BDS as the overlay node. > > { 'execute': 'blockdev-add', 'arguments': > { 'options': { 'driver': 'qcow2', >'n

Re: [Qemu-devel] [PATCH v8 29/54] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-10-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > 'MIGRATION_STATUS_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy > > > > 'migration_in_postcopy' is provided for other sections to know if > > they're in postc

Re: [Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Max Reitz
On 30.10.2015 19:04, Jeff Cody wrote: > On Fri, Oct 30, 2015 at 06:16:29PM +0100, Max Reitz wrote: >> On 29.10.2015 19:04, Jeff Cody wrote: >>> Commit 934659c switched the iotests to run qemu-io from a bash subshell, >>> in order to catch segfaults. This method is incompatible with the >>> current

Re: [Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Jeff Cody
On Fri, Oct 30, 2015 at 06:16:29PM +0100, Max Reitz wrote: > On 29.10.2015 19:04, Jeff Cody wrote: > > Commit 934659c switched the iotests to run qemu-io from a bash subshell, > > in order to catch segfaults. This method is incompatible with the > > current valgrind_qemu_io() bash function. > > >

Re: [Qemu-devel] [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-30 Thread Alexander Duyck
On 10/29/2015 07:41 PM, Lan Tianyu wrote: On 2015年10月30日 00:17, Alexander Duyck wrote: On 10/29/2015 01:33 AM, Lan Tianyu wrote: On 2015年10月29日 14:58, Alexander Duyck wrote: Your code was having to do a bunch of shuffling in order to get things set up so that you could bring the interface back

Re: [Qemu-devel] [PATCH v2 1/1] qemu-iotests: fix cleanup of background processes

2015-10-30 Thread Jeff Cody
On Fri, Oct 30, 2015 at 06:37:34PM +0100, Max Reitz wrote: > On 29.10.2015 12:56, Jeff Cody wrote: > > Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash > > subshell, in order to catch segfaults. Unfortunately, this means the > > process PID cannot be captured via '$!'. We s

Re: [Qemu-devel] [PATCH v2 1/1] qemu-iotests: fix cleanup of background processes

2015-10-30 Thread Max Reitz
On 29.10.2015 12:56, Jeff Cody wrote: > Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash > subshell, in order to catch segfaults. Unfortunately, this means the > process PID cannot be captured via '$!'. We stopped killing qemu and > qemu-nbd processes, leaving a lot of orph

Re: [Qemu-devel] [PATCH v6 11/33] hostmem-file: use whole file size if possible

2015-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2015 at 01:56:05PM +0800, Xiao Guangrong wrote: > Use the whole file size if @size is not specified which is useful > if we want to directly pass a file to guest > > Signed-off-by: Xiao Guangrong > --- > backends/hostmem-file.c | 48 ---

Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

2015-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2015 at 05:23:27PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Changes v2 -> v3: > > * Removed patch: "vl.c: Convert error sentences to simpler phrases" > > * Removed patch: "vl.c: Reword -machine help error messages" > > * Removed patch: "vl.c: Reword fw_cfg n

Re: [Qemu-devel] [PULL 00/12] Block patches

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 14:19, Markus Armbruster wrote: > Peter Maydell writes: >> I get an error on 64-bit ARM running the ivshmem tests: >> >> TEST: tests/ivshmem-test... (pid=22948) >> /i386/ivshmem/single:OK >> /i386/ivshmem/pair:

Re: [Qemu-devel] [PATCH v1 1/4] qemu-iotests: refine common.config

2015-10-30 Thread Eric Blake
On 10/30/2015 01:13 AM, Bo Tu wrote: > Be easier to read, and be slightly shorter. You mentioned a very short "what" in the subject line (good), but the "why" in the commit body ("easier to read, shorter") is rather terse and subjective. It would be nicer to go into details (change the definition

Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

2015-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2015 at 01:07:51PM -0200, Eduardo Habkost wrote: > Changes v2 -> v3: > * Removed patch: "vl.c: Convert error sentences to simpler phrases" > * Removed patch: "vl.c: Reword -machine help error messages" > * Removed patch: "vl.c: Reword fw_cfg name prefix warning" > * Removed patch: "

Re: [Qemu-devel] [PULL 0/9] target-mips queue

2015-10-30 Thread Peter Maydell
7bc8e0c967a4ef77657174d28af775691e18b4ce: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-29 09:49:52 +) > > are available in the git repository at: > > git://github.com/lalrae/qemu.git tags/mips-20151030 > > for you to f

Re: [Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Max Reitz
On 29.10.2015 19:04, Jeff Cody wrote: > Commit 934659c switched the iotests to run qemu-io from a bash subshell, > in order to catch segfaults. This method is incompatible with the > current valgrind_qemu_io() bash function. > > Move the valgrind usage into the exec subshell in _qemu_io_wrapper()

Re: [Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm

2015-10-30 Thread Eric Blake
On 10/29/2015 11:56 PM, Xiao Guangrong wrote: > This patch is generated by this script: > > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ > | xargs sed -i "s/PC_DIMM/DIMM/g" > > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ > | xargs sed -

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] dataplane: simplify indirect descriptor read

2015-10-30 Thread Stefan Hajnoczi
On Thu, Oct 29, 2015 at 11:28:05AM +0100, Igor Mammedov wrote: > On Wed, 28 Oct 2015 17:48:02 +0200 > "Michael S. Tsirkin" wrote: > > -struct vring_desc *desc_ptr; > > -MemoryRegion *mr; > > - > > /* Translate indirect descriptor */ > > -desc_ptr = vring_map(&mr, >

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] dataplane: simplify indirect descriptor read

2015-10-30 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 05:48:02PM +0200, Michael S. Tsirkin wrote: > Use address_space_read to make sure we handle the case of an indirect > descriptor crossing DIMM boundary correctly. > > Signed-off-by: Michael S. Tsirkin > --- > > Warning: compile-tested only. > > hw/virtio/dataplane/vring

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-10-30 Thread Mark Cave-Ayland
On 26/10/15 09:48, Mark Cave-Ayland wrote: > On 06/09/15 12:54, Mark Cave-Ayland wrote: > >> On 06/09/15 09:36, Alexander Graf wrote: >> >>> On 05.09.15 21:51, Mark Cave-Ayland wrote: Commit 61964 "Add configuration section" broke the analyze-migration.py script which terminates d

Re: [Qemu-devel] [PATCH 00/13] Mac OS 9 compatibility improvements (upstream rework)

2015-10-30 Thread Mark Cave-Ayland
On 23/10/15 14:56, Mark Cave-Ayland wrote: > This is a rework of Cormac O'Brien's GSoC project to try and boot MacOS 9 > under > QEMU, the original version of which was posted to the qemu-devel list at the > end of August > (https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02521.html). >

Re: [Qemu-devel] [PATCH for-2.5 v2 3/4] mips: add Global Interrupt Controller

2015-10-30 Thread James Hogan
Hi Yongbok, On Tue, Oct 27, 2015 at 05:12:36PM +, Yongbok Kim wrote: > The Global Interrupt Controller (GIC) is responsible for mapping each > internal and external interrupt to the correct location for servicing. > > The internal representation of registers is different from the specificatio

Re: [Qemu-devel] [PATCH v8 06/17] qapi-types: Consolidate gen_struct() and gen_union()

2015-10-30 Thread Eric Blake
On 10/30/2015 07:01 AM, Markus Armbruster wrote: > Eric Blake writes: > >> These two methods are now close enough that we can finally merge >> them, relying on the fact that simple unions now provide a >> reasonable local_members. Change gen_struct() to gen_object() >> that handles all forms of

Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

2015-10-30 Thread Markus Armbruster
Eduardo Habkost writes: > Changes v2 -> v3: > * Removed patch: "vl.c: Convert error sentences to simpler phrases" > * Removed patch: "vl.c: Reword -machine help error messages" > * Removed patch: "vl.c: Reword fw_cfg name prefix warning" > * Removed patch: "vl.c: Use US spelling for 'unrecognized

Re: [Qemu-devel] [PATCH v8 42/54] Postcopy: Use helpers to map pages during migration

2015-10-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > In postcopy, the destination guest is running at the same time > > as it's receiving pages; as we receive new pages we must put > > them into the guests address space at

Re: [Qemu-devel] [PATCH v8 05/17] qapi: Track simple union tag in object.local_members

2015-10-30 Thread Eric Blake
On 10/30/2015 06:54 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We were previously creating all unions with an empty list for >> local_members. However, it will make it easier to unify struct >> and union generation if we include the generated tag member in >> local_members. That way

Re: [Qemu-devel] [PULL 00/05] seccomp branch queue

2015-10-30 Thread Peter Maydell
ble in the git repository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp-20151030 > > for you to fetch changes up to b1e1f0bbe7268d0bb8f63da220b41803b2e54081: > > seccomp: loosen library version dependency (2015-10-30 14:33:00 +0100) > > --

Re: [Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

2015-10-30 Thread Dmitry Osipenko
29.10.2015 17:28, Dmitry Osipenko пишет: - Disable limiting for that host machine? - Tune timer limit? These tho variants seem too farfetched, since we don't distinguish the guest software timer poll and some device internal ptimer_get_count() call. Just a note. -- Dmitry

Re: [Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm

2015-10-30 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: This patch is generated by this script: find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PC_DIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PCDIMM/DIM

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev: acquire AioContext in hmp_commit()

2015-10-30 Thread Jeff Cody
On Fri, Oct 30, 2015 at 03:57:41PM +, Stefan Hajnoczi wrote: > This one slipped through. Although we acquire AioContext when > committing all devices we don't for just a single device. > > AioContext must be acquired before calling bdrv_*() functions to > synchronize access with other threads

[Qemu-devel] [PATCH] blockdev: acquire AioContext in hmp_commit()

2015-10-30 Thread Stefan Hajnoczi
This one slipped through. Although we acquire AioContext when committing all devices we don't for just a single device. AioContext must be acquired before calling bdrv_*() functions to synchronize access with other threads that may be using the AioContext. Signed-off-by: Stefan Hajnoczi --- bl

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote: > There are three places use the some logic to get the page size on > the file path or file fd > > This patch introduces qemu_file_get_page_size() to unify the code > > Signed-off-by: Xiao Guangrong [...] > diff --git a/util/oslib-p

[Qemu-devel] [PULL 11/25] qapi-visit: Remove redundant functions for flat union base

2015-10-30 Thread Markus Armbruster
From: Eric Blake The code for visiting the base class of a child struct created visit_type_Base_fields() which covers all fields of Base; while the code for visiting the base class of a flat union created visit_type_Union_fields() covering all fields of the base except the discriminator. But sin

Re: [Qemu-devel] [PATCH 4/4] migration: add missed aio_context_acquire into HMP snapshot code

2015-10-30 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 06:01:05PM +0300, Denis V. Lunev wrote: > diff --git a/block/snapshot.c b/block/snapshot.c > index 89500f2..f6fa17a 100644 > --- a/block/snapshot.c > +++ b/block/snapshot.c > @@ -259,6 +259,9 @@ void bdrv_snapshot_delete_by_id_or_name(BlockDriverState > *bs, > { > int

[Qemu-devel] [PULL 22/25] qapi: Finish converting to new qapi union layout

2015-10-30 Thread Markus Armbruster
From: Eric Blake We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-varia

[Qemu-devel] [PULL 15/25] block: Convert to new qapi union layout

2015-10-30 Thread Markus Armbruster
From: Eric Blake We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-varia

Re: [Qemu-devel] [PATCH 3/4] io: add locking constraints check into bdrv_drain to ensure locking

2015-10-30 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 06:01:04PM +0300, Denis V. Lunev wrote: > as described in the comment of the function > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > --- > block/io.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/block/io.c

[Qemu-devel] [PULL 25/25] qapi-schema: mark InetSocketAddress as mandatory again

2015-10-30 Thread Markus Armbruster
From: "Daniel P. Berrange" Revert the qapi-schema.json change done in: commit 0983f5e6af76d5df8c6346cbdfff9d8305fb6da0 Author: Daniel P. Berrange Date: Tue Sep 1 14:46:50 2015 +0100 sockets: allow port to be NULL when listening on IP address Switching "port" from mandatory to opti

  1   2   3   >