Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-10-29 Thread Peter Crosthwaite
Ping^3 This has been on list for a very long time without 3rd party review. Can I send a PULL? Regards, Peter On Wed, Oct 14, 2015 at 11:42 AM, Alistair Francis wrote: > Ping^2 > > On Thu, Aug 27, 2015 at 2:47 PM, Alistair Francis > wrote: >> Ping! >> >> On Wed, Jul 29, 2015 at 1:24 PM, Alista

Re: [Qemu-devel] [PATCH v6 0/4] qapi: child add/delete support

2015-10-29 Thread Wen Congyang
Ping... On 10/16/2015 04:57 PM, Wen Congyang wrote: > If quorum's child is broken, we can use mirror job to replace it. > But sometimes, the user only need to remove the broken child, and > add it later when the problem is fixed. > > It is based on the Kevin's bdrv_swap() related patch: > http://

[Qemu-devel] [PATCH v6 33/33] nvdimm: add maintain info

2015-10-29 Thread Xiao Guangrong
Add NVDIMM maintainer Signed-off-by: Xiao Guangrong --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3144113..865c0cf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -907,6 +907,13 @@ M: Jiri Pirko S: Maintained F: hw/net/rocker/ +NVDI

[Qemu-devel] [PATCH v6 30/33] nvdimm acpi: support Set Namespace Label Data function

2015-10-29 Thread Xiao Guangrong
Function 6 is used to set Namespace Label Data Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 8c27b25..5c8be41 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @

[Qemu-devel] [PATCH v6 29/33] nvdimm acpi: support Get Namespace Label Data function

2015-10-29 Thread Xiao Guangrong
Function 5 is used to get Namespace Label Data Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 63 1 file changed, 63 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 67c4699..8c27b25 100644 --- a/hw/acpi/nvdimm.c

[Qemu-devel] [PATCH v6 28/33] nvdimm acpi: support Get Namespace Label Size function

2015-10-29 Thread Xiao Guangrong
Function 4 is used to get Namespace label size Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 87 +++- 1 file changed, 86 insertions(+), 1 deletion(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 300a3aa..67c4699 100644 --- a/h

[Qemu-devel] [PATCH v6 27/33] nvdimm acpi: support function 0

2015-10-29 Thread Xiao Guangrong
__DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Method) Function 0 is a query function. We do not support any function on root device and only 3 functions are support for NVDIMM device, Get Namespace Label Size, Get Namespace Label Data and Set Namespace Label Data, that means we curren

[Qemu-devel] [PATCH v6 32/33] nvdimm acpi: support _FIT method

2015-10-29 Thread Xiao Guangrong
FIT buffer is not completely mapped into guest address space, so a new function, Read FIT, function index 0x, is reserved by QEMU to read the piece of FIT buffer. The buffer is concatenated before _FIT return Refer to docs/specs/acpi-nvdimm.txt for detailed design Signed-off-by: Xiao Guan

[Qemu-devel] [PATCH v6 25/33] nvdimm acpi: build ACPI nvdimm devices

2015-10-29 Thread Xiao Guangrong
NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices There is a root device under \_SB and specified NVDIMM devices are under the root device. Each NVDIMM device has _ADR which returns its handle used to associate MEMDEV structure in NFIT We reserve handle 0 for root device. In this patch, w

[Qemu-devel] [PATCH v6 24/33] nvdimm acpi: build ACPI NFIT table

2015-10-29 Thread Xiao Guangrong
NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 structures: - SPA structure, defines the PMEM region info - MEM DEV structure, it has the @handle which is used to associate specified ACPI NVDIMM device we will i

[Qemu-devel] [PATCH v6 23/33] nvdimm acpi: init the resource used by NVDIMM ACPI

2015-10-29 Thread Xiao Guangrong
A page staring from 0xFF0 and IO port 0x0a18 - 0xa1b in guest are reserved for NVDIMM ACPI emulation, refer to docs/specs/acpi_nvdimm.txt for detailed design A parameter, 'nvdimm-support', is introduced for PIIX4_PM and ICH9-LPC that controls if nvdimm support is enabled, it is true on default

[Qemu-devel] [PATCH v6 26/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method

2015-10-29 Thread Xiao Guangrong
Check if the input Arg3 is valid then store it into dsm_in if needed Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 53ed675..e179a72 100644 --- a/hw/acpi/

[Qemu-devel] [PATCH v6 31/33] nvdimm: allow using whole backend memory as pmem

2015-10-29 Thread Xiao Guangrong
Introduce a parameter, named "reserve-label-data", if it is false which indicates that QEMU does not reserve any region on the backend memory to support label data. It is a 'label-less' NVDIMM device mode that linux will use whole memory on the device as a single namesapce This is useful for the u

[Qemu-devel] [PATCH v6 22/33] docs: add NVDIMM ACPI documentation

2015-10-29 Thread Xiao Guangrong
It describes the basic concepts of NVDIMM ACPI and the interface between QEMU and the ACPI BIOS Signed-off-by: Xiao Guangrong --- docs/specs/acpi_nvdimm.txt | 179 + 1 file changed, 179 insertions(+) create mode 100644 docs/specs/acpi_nvdimm.txt diff

[Qemu-devel] [PATCH v6 21/33] nvdimm: implement NVDIMM device abstract

2015-10-29 Thread Xiao Guangrong
Introduce "nvdimm" device which is based on dimm device type 128K memory region which is the minimum namespace label size required by NVDIMM Namespace Spec locates at the end of backend memory device is reserved for label data We can use "-m 1G,maxmem=100G,slots=10 -object memory-backend-file, id

[Qemu-devel] [PATCH v6 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region

2015-10-29 Thread Xiao Guangrong
Curretly, the memory region of backed memory is directly mapped to guest's address space, however, it is not true for nvdimm device This patch let dimm device realize this fact and use DIMMDeviceClass->get_memory_region method to get the mapped memory region Signed-off-by: Xiao Guangrong --- hw

[Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm

2015-10-29 Thread Xiao Guangrong
This patch is generated by this script: find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PC_DIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PCDIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json

[Qemu-devel] [PATCH v6 19/33] dimm: keep the state of the whole backend memory

2015-10-29 Thread Xiao Guangrong
QEMU keeps the state of memory of dimm device during live migration, however, it is not enough for nvdimm device as its memory does not contain its label data, so that we should protect the whole backend memory instead Signed-off-by: Xiao Guangrong --- hw/mem/dimm.c | 14 -- 1 file c

[Qemu-devel] [PATCH v6 20/33] dimm: introduce realize callback

2015-10-29 Thread Xiao Guangrong
nvdimm need check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Signed-off-by: Xiao Guangrong --- hw/mem/dimm.c | 5 + include/hw/mem

[Qemu-devel] [PATCH v6 15/33] stubs: rename qmp_pc_dimm_device_list.c

2015-10-29 Thread Xiao Guangrong
Rename qmp_pc_dimm_device_list.c to qmp_dimm_device_list.c Signed-off-by: Xiao Guangrong --- stubs/Makefile.objs | 2 +- stubs/{qmp_pc_dimm_device_list.c => qmp_dimm_device_list.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename stubs/{qmp_pc_d

[Qemu-devel] [PATCH v6 13/33] pc-dimm: make pc_existing_dimms_capacity static and rename it

2015-10-29 Thread Xiao Guangrong
pc_existing_dimms_capacity() can be static since it is not used out of pc-dimm.c and drop the pc_ prefix to prepare the work which abstracts dimm device type from pc-dimm Signed-off-by: Xiao Guangrong --- hw/mem/pc-dimm.c | 73 include/hw/

[Qemu-devel] [PATCH v6 17/33] dimm: abstract dimm device from pc-dimm

2015-10-29 Thread Xiao Guangrong
A base device, dimm, is abstracted from pc-dimm, so that we can build nvdimm device based on dimm in the later patch Signed-off-by: Xiao Guangrong --- default-configs/i386-softmmu.mak | 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/mem/Makefile.

[Qemu-devel] [PATCH v6 12/33] pc-dimm: remove DEFAULT_PC_DIMMSIZE

2015-10-29 Thread Xiao Guangrong
It's not used any more Signed-off-by: Xiao Guangrong --- include/hw/mem/pc-dimm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h index d83bf30..11a8937 100644 --- a/include/hw/mem/pc-dimm.h +++ b/include/hw/mem/pc-dimm.h @@ -20,8 +20,6 @@

[Qemu-devel] [PATCH v6 10/33] hostmem-file: clean up memory allocation

2015-10-29 Thread Xiao Guangrong
- hostmem-file.c is compiled only if CONFIG_LINUX is enabled so that is unnecessary to do the same check in the source file - the interface, HostMemoryBackendClass->alloc(), is not called many times, do not need to check if the memory-region is initialized Signed-off-by: Xiao Guangrong ---

[Qemu-devel] [PATCH v6 09/33] exec: allow file_ram_alloc to work on file

2015-10-29 Thread Xiao Guangrong
Currently, file_ram_alloc() only works on directory - it creates a file under @path and do mmap on it This patch tries to allow it to work on file directly, if @path is a directory it works as before, otherwise it treats @path as the target file then directly allocate memory from it Signed-off-by

[Qemu-devel] [PATCH v6 16/33] pc-dimm: rename pc-dimm.c and pc-dimm.h

2015-10-29 Thread Xiao Guangrong
Rename: pc-dimm.c => dimm.c pc-dimm.h => dimm.h It prepares the work which abstracts dimm device type for both pc-dimm and nvdimm Signed-off-by: Xiao Guangrong --- hw/Makefile.objs | 2 +- hw/acpi/ich9.c | 2 +- hw/acpi/memory_hotplug.c

[Qemu-devel] [PATCH v6 06/33] acpi: add aml_method_serialized

2015-10-29 Thread Xiao Guangrong
It avoid explicit Mutex and will be used by NVDIMM ACPI Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 26 -- include/hw/acpi/aml-build.h | 1 + 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c ind

[Qemu-devel] [PATCH v6 08/33] exec: allow memory to be allocated from any kind of path

2015-10-29 Thread Xiao Guangrong
Currently file_ram_alloc() is designed for hugetlbfs, however, the memory of nvdimm can come from either raw pmem device eg, /dev/pmem, or the file locates at DAX enabled filesystem So this patch let it work on any kind of path Signed-off-by: Xiao Guangrong --- exec.c | 56 +

[Qemu-devel] [PATCH v6 05/33] acpi: add aml_object_type

2015-10-29 Thread Xiao Guangrong
Implement ObjectType which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index efc06ab..9f792ab 1

[Qemu-devel] [PATCH v6 04/33] acpi: add aml_concatenate

2015-10-29 Thread Xiao Guangrong
Implement Concatenate term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 15 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 9fe

[Qemu-devel] [PATCH v6 11/33] hostmem-file: use whole file size if possible

2015-10-29 Thread Xiao Guangrong
Use the whole file size if @size is not specified which is useful if we want to directly pass a file to guest Signed-off-by: Xiao Guangrong --- backends/hostmem-file.c | 48 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/backends/h

[Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-29 Thread Xiao Guangrong
There are three places use the some logic to get the page size on the file path or file fd This patch introduces qemu_file_get_page_size() to unify the code Signed-off-by: Xiao Guangrong --- include/qemu/osdep.h | 1 + target-ppc/kvm.c | 21 +++-- util/oslib-posix.c | 16

[Qemu-devel] [PATCH v6 01/33] acpi: add aml_derefof

2015-10-29 Thread Xiao Guangrong
Implement DeRefOf term which is used by NVDIMM _DSM method in later patch Reviewed-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-bu

[Qemu-devel] [PATCH v6 00/33] implement vNVDIMM

2015-10-29 Thread Xiao Guangrong
This patchset can be found at: https://github.com/xiaogr/qemu.git nvdimm-v6 It is based on pci branch on Michael's tree and the top commit is: commit 6f96a31a06c2a1 (tests: re-enable vhost-user-test). Changelog in v6: - changes from Stefan's comments: 1) fix code style of struct naming by

[Qemu-devel] [PATCH v6 02/33] acpi: add aml_sizeof

2015-10-29 Thread Xiao Guangrong
Implement SizeOf term which is used by NVDIMM _DSM method in later patch Reviewed-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-bui

[Qemu-devel] [PATCH v6 03/33] acpi: add aml_create_field

2015-10-29 Thread Xiao Guangrong
Implement CreateField term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index a722

Re: [Qemu-devel] [PATCH v10 01/10] allow writing to the backing file

2015-10-29 Thread Wen Congyang
On 10/10/2015 03:07 AM, Eric Blake wrote: > On 09/25/2015 12:17 AM, Wen Congyang wrote: >> For block replication, we have such backing chain: >> secondary disk <-- hidden disk <-- active disk >> secondary disk is top BDS(use bacing reference), so it can be opened in > > s/BDS(use bacing/BDS (u

[Qemu-devel] [PATCH v2 1/5] arm: boot: Adjust indentation of FIXUP comments

2015-10-29 Thread Peter Crosthwaite
These comments start immediately after the current longest name in the list. Tab them out to the next tab stop to give a little breathing room and prepare for FIXUP_BOARD_SETUP which will require more indent. Reviewed-by: Peter Maydell Signed-off-by: Peter Crosthwaite --- Changed since v1: s/com

[Qemu-devel] [PATCH v2 3/5] arm: xilinx_zynq: Add linux pre-boot

2015-10-29 Thread Peter Crosthwaite
Add a Linux-specific pre-boot routine that matches the device- specific bootloaders behaviour. This is needed for modern Linux that expects the ARM PLL in SLCR to be a more even value (not 26). Cc: Alistair Francis Signed-off-by: Peter Crosthwaite --- Changed since v1: Left main loader address u

[Qemu-devel] [PATCH v2 2/5] arm: boot: Add board specific setup code API

2015-10-29 Thread Peter Crosthwaite
Add an API for boards to inject their own preboot software (or firmware) sequence. The software then returns to the bootloader via the link register. This allows boards to do their own little bits of firmware setup without needed to replace the bootloader completely (which is the requirement for e

[Qemu-devel] [PATCH v2 5/5] arm: highbank: Implement PSCI and dummy monitor

2015-10-29 Thread Peter Crosthwaite
Firstly, enable monitor mode and PSCI, both are which are features of this board. In addition to PSCI, this board also uses SMC for cache maintainence ops. This means we need a secure monitor to catch these and nop them. Use the ARM boot board-setup feature to implement this. All traps to monitor

[Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-29 Thread Peter Crosthwaite
Add a flag that when set, will cause the primary CPU to start in secure mode, even if the overall boot in non-secure. This is useful for when there is a board-setup blob that needs to run from secure mode, but device and secondary CPU init should still be done as-normal for a non- secure boot. Sig

[Qemu-devel] [PATCH v2 0/5] ARM: Machine specific boot blobs

2015-10-29 Thread Peter Crosthwaite
Hi, This adds support for machine-specific primary boot blobs. This can be used to install little bits of firmware or boot code without having to throw the whole QEMU bootloader out and BYO (with device drivers and all). It is then used to fix two boards, Zynq and Highbank, both which have small

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-10-29 Thread Jason Wang
On 10/28/2015 01:44 PM, Jason Wang wrote: > > On 10/26/2015 01:00 AM, Leonid Bloch wrote: >> Hello qemu-devel, >> >> This patch series is an RFC for the new networking device emulation >> we're developing for QEMU. >> >> This new device emulates the Intel 82574 GbE Controller and works >> with un

[Qemu-devel] [PATCH v4 2/3] aio: Introduce aio_context_setup

2015-10-29 Thread Fam Zheng
This is the place to initialize platform specific bits of AioContext. Signed-off-by: Fam Zheng --- aio-posix.c | 4 aio-win32.c | 4 async.c | 13 +++-- include/block/aio.h | 8 4 files changed, 27 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH v4 3/3] aio: Introduce aio-epoll.c

2015-10-29 Thread Fam Zheng
To minimize code duplication, epoll is hooked into aio-posix's aio_poll() instead of rolling its own. This approach also has both compile-time and run-time switchability. 1) When QEMU starts with a small number of fds in the event loop, ppoll is used. 2) When QEMU starts with a big number of fds,

[Qemu-devel] [PATCH v4 1/3] aio: Introduce aio_external_disabled

2015-10-29 Thread Fam Zheng
This allows AioContext users to check the enable/disable state of external clients. Signed-off-by: Fam Zheng --- include/block/aio.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/block/aio.h b/include/block/aio.h index bcc7d43..dcf74be 100644 --- a/include/block/aio.h

[Qemu-devel] [PATCH v4 0/3] aio: Use epoll in aio_poll()

2015-10-29 Thread Fam Zheng
v4: Rebase onto master (with aio_disable_external): Don't use epoll if aio_external_disabled(ctx); Change assert on epoll_ctl return code to disable epoll; Rerun benchmark; v3: Remove the redundant check in aio_epoll_try_enable. [Stefan] v2: Merge aio-epoll.c into aio-posix.c. [Paolo]

Re: [Qemu-devel] [PATCH v3 2/6] e1000: Trivial implementation of various MAC registers

2015-10-29 Thread Jason Wang
On 10/29/2015 06:27 PM, Leonid Bloch wrote: > On Thu, Oct 29, 2015 at 12:01 PM, Jason Wang wrote: >> >> On 10/29/2015 05:33 PM, Leonid Bloch wrote: >>> On Thu, Oct 29, 2015 at 5:04 AM, Jason Wang wrote: On 10/28/2015 11:31 PM, Leonid Bloch wrote: > These registers appear in Intel's spe

Re: [Qemu-devel] [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-29 Thread Lan Tianyu
On 2015年10月30日 00:17, Alexander Duyck wrote: > On 10/29/2015 01:33 AM, Lan Tianyu wrote: >> On 2015年10月29日 14:58, Alexander Duyck wrote: >>> Your code was having to do a bunch of shuffling in order to get things >>> set up so that you could bring the interface back up. I would argue >>> that it ma

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-10-29 Thread Eric Harney
Closing based on the assumption that a working qemu-img is available now. ** Changed in: cinder Status: Triaged => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qem

Re: [Qemu-devel] [PATCH v2 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-10-29 Thread Shannon Zhao
On 2015/10/30 2:17, Wei Huang wrote: > On 10/29/2015 09:27 AM, Shannon Zhao wrote: >> ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced >> platforms(like ARM). It uses GPIO pin to trigger an event to the guest. >> For QEMU, here we add PL061 GPIO controller and use PIN 3 for >>

Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-29 Thread James Hogan
Hi Yongbok, On Tue, Oct 27, 2015 at 05:12:35PM +, Yongbok Kim wrote: > Add part of GCR Block which Linux Kernel utilises and it is enough > to bring the GIC up. > It defines full 32 Kbytes address space allocated for GCR but only few > registers are implemented such as config, revision, status

Re: [Qemu-devel] [PATCH for-2.5] MAINTAINERS: Add new qemu-arm mailing list to ARM related entries

2015-10-29 Thread Alistair Francis
On Thu, Oct 29, 2015 at 7:41 AM, Peter Maydell wrote: > We now have a qemu-arm mailing list for ARM patches and discussion, > so add an L: entry for it to the various ARM related entries in > MAINTAINERS. > > Signed-off-by: Peter Maydell Looks fine to me Reviewed-by: Alistair Francis Thanks,

Re: [Qemu-devel] [PATCH for-2.5 v2 1/4] target-mips: add CMGCRBase register

2015-10-29 Thread James Hogan
On Tue, Oct 27, 2015 at 05:12:34PM +, Yongbok Kim wrote: > Physical base address for the memory-mapped Coherency Manager Global > Configuration Register space. > The MIPS default location for the GCR_BASE address is 0x1FBF_8. > This register only exists if Config3 CMGCR is set to one. > > Sign

Re: [Qemu-devel] [PATCH v4] target-mips: fix updating XContext on mmu exception

2015-10-29 Thread James Hogan
On Thu, Oct 29, 2015 at 05:17:52PM +, Yongbok Kim wrote: > Correct updating XContext.Region field on mmu exceptions. > If Config3.CTXTC = 0 then the R field of XContext has to be updated > with the value of bits 63..62 of the virtual address upon a TLB > exception. It wouldn't hurt to mention

Re: [Qemu-devel] [PATCH 4/4] json-streamer: Limit number of tokens in addition to total size

2015-10-29 Thread Eric Blake
On 10/29/2015 12:27 PM, Markus Armbruster wrote: >> Sounds like we have some quadratic (or worse) scaling in the parser. >> Worth fixing some day, but I also agree that we don't have to tackle it >> in this series. > > I believe it's linear with a criminally negligent constant (several KiB > per t

Re: [Qemu-devel] [PATCH 1/1] monitor: correct socket listen port

2015-10-29 Thread Sam Bobroff
On Thu, Oct 29, 2015 at 07:26:14AM +0100, Markus Armbruster wrote: > Sam Bobroff writes: > > > Currently when constructing an inet socket monitor (e.g. via "-monitor > > telent:localhost:12345,server,nowait") the port is ignored and a > > random one is used instead. It appears this behaviour was

Re: [Qemu-devel] [PATCH v3 4/5] xlnx-zynqmp: Connect the SPI devices

2015-10-29 Thread Alistair Francis
On Thu, Oct 29, 2015 at 12:04 PM, Peter Crosthwaite wrote: > On Thu, Oct 29, 2015 at 10:45 AM, Alistair Francis > wrote: >> On Thu, Oct 29, 2015 at 1:27 AM, Frederic Konrad >> wrote: >>> On 29/10/2015 03:00, Peter Crosthwaite wrote: On Wed, Oct 28, 2015 at 10:32 AM, Alistair Francis <

Re: [Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0

2015-10-29 Thread John Snow
On 10/29/2015 05:25 PM, Peter Maydell wrote: > On 29 October 2015 at 21:20, Laszlo Ersek wrote: >> On 10/29/15 21:29, John Snow wrote: >>> Here's a good takeaway quote: >>> >>> 'Also, _FORTIFY_SOURCE + glibc + clang is not supported and does not >>> work (for instance, it relies on __builtin_va_

Re: [Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0

2015-10-29 Thread Peter Maydell
On 29 October 2015 at 21:20, Laszlo Ersek wrote: > On 10/29/15 21:29, John Snow wrote: >> Here's a good takeaway quote: >> >> 'Also, _FORTIFY_SOURCE + glibc + clang is not supported and does not >> work (for instance, it relies on __builtin_va_pack_len and friends, >> which we have no intention of

Re: [Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0

2015-10-29 Thread Laszlo Ersek
Aargh, clicked "Reply" instead of "Reply All". Resending. On 10/29/15 21:29, John Snow wrote: > > > On 10/29/2015 04:22 PM, John Snow wrote: >> Clang++ 3.5 on Fedora 22 appears to have difficulty tolerating >> D_FORTIFY_SOURCE for certain glibc headers, such as stdio. >> >> This interferes, curr

Re: [Qemu-devel] [PATCH 00/40] Patch Round-up for stable 2.4.1, freeze on 2015-10-29

2015-10-29 Thread Denis V. Lunev
On 10/21/2015 08:51 PM, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v2.4.1: https://github.com/mdroth/qemu/commits/stable-2.4-staging The release is planned for 2015-11-03: http://wiki.qemu.org/Planning/2.4 Please respond here or CC qemu-sta...

[Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN"

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini This is a bit easier to use than "-trace" if you are also enabling other kinds of logging. It is also more discoverable for experienced QEMU users, and accessible from user-mode emulators. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Bornt

[Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging

2015-10-29 Thread Denis V. Lunev
This series does three things: 1) add a "-trace [enable=]foo" option to enable one or more trace events, and a "-trace help" option to show the list of tracepoints (patches 4-5) 2) change the stderr tracing backend so that it prints to the -D log file, and enable it by default. "-trace file=..."

[Qemu-devel] [PATCH 01/11] trace: fix documentation

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini Mention the ftrace backend too. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-options.hx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 949db7f..5

[Qemu-devel] [PATCH 08/11] log: move qemu-log.c into util/ directory

2015-10-29 Thread Denis V. Lunev
log will become common facility with tracepoints support in next step. Signed-off-by: Denis V. Lunev Reviewed-by: Paolo Bonzini --- Makefile.objs| 1 - util/Makefile.objs | 1 + qemu-log.c => util/log.c | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename qemu-log.c =>

[Qemu-devel] [PATCH 07/11] log: do not unnecessarily include qom/cpu.h

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini Split the bits that require it to exec/log.h. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- bsd-user/main.c | 1 + cpu-exec.c| 1 + exec.c| 1 + hw/acpi/cpu_hotpl

[Qemu-devel] [PATCH 10/11] trace: switch default backend to "log"

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini This enables integration with other QEMU logging facilities. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 5e65dd5..2

[Qemu-devel] [PATCH 02/11] trace: split trace_init_events out of trace_init_backends

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini This is cleaner and has two advantages. First, it improves error reporting with -daemonize. Second, multiple "-trace events" options now cumulate. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-io.c | 2 +- tra

[Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini This is cleaner, and improves error reporting with -daemonize. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-io.c | 2 +- trace/control.c | 17 - trace/control.h | 13 - trace/simple.

[Qemu-devel] [PATCH 09/11] trace: convert stderr backend to log

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- configure | 4 ++-- include/qemu/log.h | 1 + scripts/tracetool/backend/{stderr.py => log.py} | 9 +

[Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now

2015-10-29 Thread Denis V. Lunev
original idea to split calling locations was to spawn tracing thread in the final child process according to commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad Author: Michael Mueller Date: Mon Sep 23 16:36:54 2013 +0200 os_daemonize is now on top of both locations. Drop unneeded ifs.

[Qemu-devel] [PATCH 05/11] trace: add "-trace enable=..."

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini Allow enabling events without going through a file, for example: qemu-system-x86_64 -trace bdrv_aio_writev -trace bdrv_aio_readv or with globbing too: qemu-system-x86_64 -trace 'bdrv_aio_*' if an appropriate backend is enabled (simple, stderr, ftrace). Signed-off-by

[Qemu-devel] [PATCH 06/11] trace: add "-trace help"

2015-10-29 Thread Denis V. Lunev
From: Paolo Bonzini Print a list of trace points Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-options.hx | 2 ++ trace/control.c | 21 - trace/control.h | 7 +++ 3 files changed, 29 insertions(+), 1 deletion(-)

Re: [Qemu-devel] RFC: Add support for KVM_CAP_SPLIT_IRQCHIP

2015-10-29 Thread Eric Blake
On 10/29/2015 02:25 PM, Matt Gingell wrote: > Hi, > > The following patch adds support for the new KVM split irqchip > interface discussed recently on the KVM mailing list. > > [kvm] KVM: x86: Split the APIC from the rest of IRQCHIP. > http://www.mailbrowse.com/kvm/138252.html > > Our testing fo

[Qemu-devel] RFC: Add support for KVM_CAP_SPLIT_IRQCHIP

2015-10-29 Thread Matt Gingell
Hi, The following patch adds support for the new KVM split irqchip interface discussed recently on the KVM mailing list. [kvm] KVM: x86: Split the APIC from the rest of IRQCHIP. http://www.mailbrowse.com/kvm/138252.html Our testing found some issues with the implementation of split IRQ chip in t

[Qemu-devel] [PATCH v9 4/5] qapi: Move duplicate enum value checks to schema check()

2015-10-29 Thread Eric Blake
Similar to the previous commit, move the detection of a collision in enum values from parse time to QAPISchemaEnumType.check(). This happens to also detect collisions in union branch names mapping to the same enum value, even when the names do not collide case-wise. So for a decent error message,

[Qemu-devel] [PATCH v9 2/5] qapi: Detect collisions in C member names

2015-10-29 Thread Eric Blake
Detect attempts to declare two object members that would result in the same C member name, by keying the 'seen' dictionary off of the C name rather than the qapi name. It also requires passing info through some of the check() methods. This fixes a previously-broken test, and the resulting error m

[Qemu-devel] [PATCH v9 5/5] qapi: Detect base class loops

2015-10-29 Thread Eric Blake
It should be fairly obvious that qapi base classes need to form an acyclic graph, since QMP cannot specify the same key more than once, while base classes are included as flat members alongside other members added by the child. But the old check_member_clash() parser function was not prepared to c

[Qemu-devel] [PATCH v9 3/5] qapi: Move duplicate member checks to schema check()

2015-10-29 Thread Eric Blake
With the previous commit, we have two different locations for detecting member name clashes - one at parse time, and another at QAPISchema*.check() time. Consolidate some of the checks into a single place, which is also in line with our TODO to eventually move all of the parse time semantic checki

[Qemu-devel] [PATCH v9 0/5] qapi collision checking (post-introspection cleanups, subset D)

2015-10-29 Thread Eric Blake
Pending prerequisite: Markus' qapi-next branch (subset B) git://repo.or.cz/qemu/armbru.git qapi-next https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06417.html Pending prerequisite: Subset C https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06674.html Also available as a tag at th

[Qemu-devel] [PATCH v9 1/5] qapi: Track owner of each object member

2015-10-29 Thread Eric Blake
Future commits will migrate semantic checking away from parsing and over to the various QAPISchema*.check() methods. But to report an error message about an incorrect semantic use of a member of an object type, it helps to know which type, command, or event owns the member. In particular, when a

Re: [Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0

2015-10-29 Thread John Snow
On 10/29/2015 04:22 PM, John Snow wrote: > Clang++ 3.5 on Fedora 22 appears to have difficulty tolerating > D_FORTIFY_SOURCE for certain glibc headers, such as stdio. > > This interferes, currently, with any arm target build. > > Work around this by disabling FORTIFY_SOURCE for clang builds > i

[Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0

2015-10-29 Thread John Snow
Clang++ 3.5 on Fedora 22 appears to have difficulty tolerating D_FORTIFY_SOURCE for certain glibc headers, such as stdio. This interferes, currently, with any arm target build. Work around this by disabling FORTIFY_SOURCE for clang builds if a problem is observed. Newer versions of clang such as

[Qemu-devel] [RFC v2] target-arm: Add and use symbolic names for register banks

2015-10-29 Thread Soren Brinkmann
Add BANK_ #defines to index banked registers. Suggested-by: Peter Maydell Signed-off-by: Soren Brinkmann --- v2: - move #defines from cpu.h to internals.h - drop ARM_ prefix in #defines --- target-arm/helper.c| 37 ++--- target-arm/internals.h | 16

Re: [Qemu-devel] [PATCH v4 for 2.5 0/3] qga: non-blocking fd cleanups

2015-10-29 Thread Michael Roth
Quoting Denis V. Lunev (2015-10-28 10:13:54) > This patchset is reincarnation of one patch discussed in the scope of > QEMU 2.4 and rejected for that time. Actually we should use > non-blocking descriptors in QGA on Windows in guest-file-open exactly > like was done for Posix. > > Changes from v3:

Re: [Qemu-devel] [PATCH 00/40] Patch Round-up for stable 2.4.1, freeze on 2015-10-29

2015-10-29 Thread Michael Roth
Quoting Markus Armbruster (2015-10-22 03:01:32) > I'm afraid > > 2d0583f qmp: Fix device-list-properties not to crash for abstract device > 2874c65 qdev: Protect device-list-properties against broken devices > 55b4efb Revert "qdev: Use qdev_get_device_class() for -device ,help" > > un

Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches

2015-10-29 Thread Eric Blake
On 10/29/2015 12:33 PM, Markus Armbruster wrote: >> Still doesn't build with old glib: >> >> In file included from /Users/pm215/src/qemu-for-merges/qga/commands.c:14: >> In file included from >> /Users/pm215/src/qemu-for-merges/qga/guest-agent-core.h:14: >> In file included from >> /Users/pm215/s

Re: [Qemu-devel] [PATCH v3 4/5] xlnx-zynqmp: Connect the SPI devices

2015-10-29 Thread Peter Crosthwaite
On Thu, Oct 29, 2015 at 10:45 AM, Alistair Francis wrote: > On Thu, Oct 29, 2015 at 1:27 AM, Frederic Konrad > wrote: >> On 29/10/2015 03:00, Peter Crosthwaite wrote: >>> On Wed, Oct 28, 2015 at 10:32 AM, Alistair Francis < >>> alistair.fran...@xilinx.com> wrote: >>> Connect the Xilinx SPI d

Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error

2015-10-29 Thread Luiz Capitulino
On Thu, 29 Oct 2015 17:23:43 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 29 Oct 2015 12:15:09 +0100 > > Markus Armbruster wrote: > > > >> Leak introduced in commit 8a4f501..710aec9, v2.4.0. > >> > >> Signed-off-by: Markus Armbruster > > > > Reviewed-by: Luiz Capitu

Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches

2015-10-29 Thread Markus Armbruster
Peter Maydell writes: > On 29 October 2015 at 14:32, Markus Armbruster wrote: >> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into >> staging (2015-10-29 09:49:52 +) >> >> are available in th

Re: [Qemu-devel] [PATCH 3/4] check-qjson: Add test for JSON nesting depth limit

2015-10-29 Thread Markus Armbruster
Eric Blake writes: > On 10/29/2015 06:44 AM, Markus Armbruster wrote: >> This would have prevented the regression mentioned in the previous >> commit. >> >> Signed-off-by: Markus Armbruster >> --- >> tests/check-qjson.c | 29 + >> 1 file changed, 29 insertions(+) >

Re: [Qemu-devel] [PATCH 4/4] json-streamer: Limit number of tokens in addition to total size

2015-10-29 Thread Markus Armbruster
Eric Blake writes: > On 10/29/2015 06:44 AM, Markus Armbruster wrote: >> Commit 29c75dd "json-streamer: limit the maximum recursion depth and >> maximum token count" attempts to guard against excessive heap usage by >> limiting total token size (it says "token count", but that's a lie). >> >> To

[Qemu-devel] [PULL 06/12] virtio-blk: switch off scsi-passthrough by default

2015-10-29 Thread Stefan Hajnoczi
From: Cornelia Huck Devices that are compliant with virtio-1 do not support scsi passthrough any more (and it has not been a recommended setup anyway for quite some time). To avoid having to switch it off explicitly in newer qemus that turn on virtio-1 by default, let's switch the default to scsi

Re: [Qemu-devel] [PATCH v2 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-10-29 Thread Wei Huang
On 10/29/2015 09:27 AM, Shannon Zhao wrote: > ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced > platforms(like ARM). It uses GPIO pin to trigger an event to the guest. > For QEMU, here we add PL061 GPIO controller and use PIN 3 for > system_powerdown, reserving PIN 0, 1, 2 for

[Qemu-devel] RAM backend and guest ABI (was Re: [PATCH v2] pc: memhp: enforce minimal 128Mb) alignment for pc-dimm

2015-10-29 Thread Eduardo Habkost
(CCing Michal and libvir-list, so libvirt team is aware of this restriction) On Thu, Oct 29, 2015 at 02:36:37PM +0100, Igor Mammedov wrote: > On Tue, 27 Oct 2015 14:36:35 -0200 > Eduardo Habkost wrote: > > > On Tue, Oct 27, 2015 at 10:14:56AM +0100, Igor Mammedov wrote: > > > On Tue, 27 Oct 2015

Re: [Qemu-devel] [PATCH v3 4/5] xlnx-zynqmp: Connect the SPI devices

2015-10-29 Thread Alistair Francis
On Thu, Oct 29, 2015 at 10:45 AM, Alistair Francis wrote: > On Thu, Oct 29, 2015 at 1:27 AM, Frederic Konrad > wrote: >> On 29/10/2015 03:00, Peter Crosthwaite wrote: >>> On Wed, Oct 28, 2015 at 10:32 AM, Alistair Francis < >>> alistair.fran...@xilinx.com> wrote: >>> Connect the Xilinx SPI d

[Qemu-devel] [PULL 11/12] target-arm: xlnx-zynqmp: Add sdhci support.

2015-10-29 Thread Stefan Hajnoczi
From: Sai Pavan Boddu Add two SYSBUS_SDHCI devices for xlnx-zynqmp Signed-off-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite Signed-off-by: Stefan Hajnoczi --- hw/arm/xlnx-zynqmp.c | 28 include/hw/arm/xlnx-zynqmp.h | 3 +++ 2 files changed, 31 inser

[Qemu-devel] [PULL 12/12] block: Consider all child nodes in bdrv_requests_pending()

2015-10-29 Thread Stefan Hajnoczi
From: Kevin Wolf The function manually recursed into bs->file and bs->backing to check whether there were any requests pending, but it ignored other children. There's no need to special case file and backing here, so just replace these two explicit recursions by a loop recursing for all child no

  1   2   3   >