Our testsuite had no coverage of empty arrays, nor of what
happens when the input does not match the expected type.
Useful to have, especially if we start changing the visitor
contracts.
Signed-off-by: Eric Blake
---
v7: no change
v6: new patch
---
tests/test-qmp-input-visitor.c | 51 ++
Make valgrind happy with the current state of the tests, so that
it is easier to see if future patches introduce new memory problems
without being drowned in noise. Many of the leaks were due to
calling a second init without tearing down the data from an earlier
visit. But since teardown is alrea
Commit cbc95538 removed unused start_handle() and end_handle(),
but forgot got remove their declarations.
Commit 4e27e819 introduced optional visitor callbacks for all
sorts of int types, but except for type_uint64 and type_size,
none of them have ever been supplied (the generic implementation
bas
Our generated list visitors have the same problem as has been
mentioned elsewhere (see commit 2f52e20): they allocate data
even on failure. An upcoming patch will correct things to
provide saner guarantees, but first we need to expose the
behavior in the testsuite to ensure we aren't introducing an
Pending prerequisite: subset B' v9:
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg03730.html
Pending prerequisite: Paolo's misc patches pull request which includes
a rewrite of qemu-char:
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg03808.html
Also available as a tag at thi
By using &error_abort, we can avoid a local err variable in
situations where we expect success.
By moving err into data, we can let test teardown take care
of cleaning up any collected error (and allowing for fewer
lines of code between repeated tests where init runs teardown
on our behalf).
Sign
Commit d88f5fd and friends first introduced the various test-qmp-*
tests in 2011, with duplicated hand-rolled TestStruct machinery,
to make sure the qapi visitor interface was tested. Later, commit
4f193e3 in 2013 added a .json file for further testing use by the
files, but without consolidating a
Now that branches are in a separate C namespace, we can remove
the restrictions in the parser that claim a branch name would
collide with QMP, delete the negative tests that are no longer
problematic, and add positive tests to qapi-schema-test to
ensure things compile correctly.
Signed-off-by: Eri
Now that we have separate namespaces for QMP vs. tag values,
we can simplify how the QAPISchema*.check() methods check for
collisions. Each QAPISchemaObjectTypeMember check() call is
given a single set of names it must not collide with; this set
is either the QMP names (when this member is used by
Previously, working with alternates required two enums, and
some indirection: for type Foo, we created Foo_qtypes[] which
maps each qtype to a member of FooKind_lookup[], then use
FooKind_lookup[] like we do for other union types.
This has a subtle bug: since the values of FooKind_lookup
start at
Sorting the values of an enum makes it easier to look up whether
a particular value is present, via binary rather than linear search
(probably most visible with QKeyCode, which has grown over
several releases). Additionally, QMP clients need not know which
C value is associated with an enum name,
Make each list element different, to ensure that order is
preserved, and use the generated free function instead of
hand-rolling our own to ensure (under valgrind) that the
list is properly cleaned.
Suggested-by: Markus Armbruster
Signed-off-by: Eric Blake
---
v7: new patch
---
tests/test-qmp-
None of the visitor callbacks would set an error when testing
if an optional field was present; make this part of the interface
contract by eliminating the errp argument. Then, for less code,
reflect the determined boolean value back to the caller instead
of making the caller read the boolean afte
The QMP input visitor allows integral values to be assigned by
promotion to a QTYPE_QFLOAT. However, when parsing an alternate,
we did not take this into account, such that an alternate that
accepts 'number' but not 'int' would reject integral values.
With this patch, we now have the following de
For the sake of humans reading introspection output, it is nice
to have the name of implicit array types be recognizable as
arrays of the underlying type. However, while this patch allows
humans to skip from a command with return type "[123]" straight
to the definition of type "123" without having
On Tue, Sep 22, 2015 at 11:40 PM, //-//ani Nemati
wrote:
>
network related cli:
> -netdev tap,fd=19,id=hostnet0,vhost=on,vhostfd=21
> -device
> virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:16:fa:57,bus=pci.0,addr=0x3
> It shows me that it uses virtio-net-pci as device for network. I do
On Sat, Oct 17, 2015 at 2:53 AM, Alex Williamson
wrote:
> v3: Incorporate suggestion from Igor to move the string length test
> out to the property parsing. A string that's too long will now
> get an error like:
>
> $ qemu-system-x86_64 -cpu qemu64,hv_vendor_id=123456789abcd
> qem
On Fri, Oct 16, 2015 at 6:41 AM, wrote:
> From: KONRAD Frederic
>
> This is the fifth version of this patch-set of the implementation of the
> Xilinx
> DisplayPort and DPDMA.
>
> This fifth version moves some headers files to the right directory.
>
> Second patch introduces an AUX bus needed by
Am 16.10.2015 um 19:19 schrieb P J P:
> +-- On Fri, 16 Oct 2015, Paolo Bonzini wrote --+
> | > +if (s->tx.link == s->cu_offset)
> | > +break;
> |
> | Please update the patch to conform to QEMU's coding standards; braces
> | are required even around single-statement blocks.
>
>
On 10/13/2015 01:10 PM, Stefano Stabellini wrote:
> On Tue, 13 Oct 2015, John Snow wrote:
>> On 10/13/2015 11:55 AM, Fabio Fantoni wrote:
>>> I added ahci disk support in libxl and using it for week seems that was
>>> ok, after a reply of Stefano Stabellini seems that xen disk unplug
>>> support
On 16 October 2015 at 21:35, Ilya Lipnitskiy wrote:
> On Fri, Oct 16, 2015 at 11:09 AM, Peter Maydell
> wrote:
>
>> You might find it helpful to turn on QEMU's debug logging
>> (see the -d and -D options). Chances are that some insn
>> in your new code is faulting (probably UNDEFing).
> I think h
On 10/16/2015 01:48 PM, Peter Maydell wrote:
> Avoid undefined behaviour from shifting left into the sign bit:
>
> hw/ide/ahci.c:551:36: runtime error: left shift of 255 by 24 places cannot be
> represented in type 'int'
>
> (Unfortunately C's promotion rules mean that in the expression
> "som
On Fri, Oct 16, 2015 at 11:09 AM, Peter Maydell
wrote:
> You might find it helpful to turn on QEMU's debug logging
> (see the -d and -D options). Chances are that some insn
> in your new code is faulting (probably UNDEFing).
I think have figured it out, looks like my code was doing two bad things
On Wed, Sep 02, 2015 at 11:19:11AM -0300, Eduardo Habkost wrote:
> The host cache information may not make sense for the guest if the VM
> CPU topology doesn't match the host CPU topology. To make sure we won't
> expose broken cache information to the guest, disable cache info
> passthrough by defa
valgrind reports that our testsuite is making a branch based on
uninitialized memory; and depending on compile options, the state
of the stack could result in the test segfaulting. I missed the
fact that we were previously relying on 'u' being fully
initialized.
Signed-off-by: Eric Blake
---
In
On 10/16/15 13:34, Fabio Fantoni wrote:
> Il 16/10/2015 12:47, Stefano Stabellini ha scritto:
>> On Fri, 16 Oct 2015, Fabio Fantoni wrote:
>>> Il 16/10/2015 12:13, Anthony PERARD ha scritto:
On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote:
> Il 15/10/2015 20:02, Anthony PERAR
A slight addition to set_string(), which optionally tests that the
string length is within the bounds specified.
Signed-off-by: Alex Williamson
---
hw/core/qdev-properties.c|7 +++
include/hw/qdev-core.h |1 +
include/hw/qdev-properties.h | 16 ++--
3 files ch
According to Microsoft documentation, the signature in the standard
hypervisor CPUID leaf at 0x4000 identifies the Vendor ID and is
for reporting and diagnostic purposes only. We can therefore allow
the user to change it to whatever they want, within the 12 character
limit. Add a new hyperv-v
v3: Incorporate suggestion from Igor to move the string length test
out to the property parsing. A string that's too long will now
get an error like:
$ qemu-system-x86_64 -cpu qemu64,hv_vendor_id=123456789abcd
qemu-system-x86_64: Property 'host-x86_64-cpu.hv-vendor-id' doesn't tak
On Fri, Oct 16, 2015 at 11:09 AM, Peter Maydell
wrote:
> You might find it helpful to turn on QEMU's debug logging
> (see the -d and -D options). Chances are that some insn
> in your new code is faulting (probably UNDEFing).
Thanks for the suggestion! Here is what I got:
IN:
0x60
On Fri, Oct 16, 2015 at 10:37 AM, Peter Maydell
wrote:
> It would be helpful if you said what the abort actually was
> (ie what instruction do we abort on, what are the fault status/
> fault address registers if applicable, etc).
I should have been more specific. Running trunk qemu on the patched
Hi All,
I am running into a curious issue with QEMU ARM, maybe a Linux/QEMU
ARM expert could help before I filed a bug report. Is this a QEMU
problem or is there a fundamental problem with my kernel change? QEMU
builds before SHA 6ec1588e handle this kernel change just fine...
I'm seeing a very e
On 16 October 2015 at 09:49, Michael S. Tsirkin wrote:
> The following changes since commit b37686f7e84b22cfaf7fd01ac5133f2617cc3027:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request'
> into staging (2015-10-09 12:18:14 +0100)
>
> are available in the git repository
On Fri, Oct 16, 2015 at 10:04 AM, John Snow wrote:
>
>
> On 10/14/2015 04:36 AM, Kevin Wolf wrote:
>> Am 13.10.2015 um 17:51 hat John Snow geschrieben:
>>>
>>>
>>> On 10/13/2015 11:30 AM, Peter Crosthwaite wrote:
On Tue, Oct 13, 2015 at 2:14 AM, Kevin Wolf wrote:
> Am 12.10.2015 um 20:26
On 16 October 2015 at 18:57, Ilya Lipnitskiy wrote:
> On Fri, Oct 16, 2015 at 10:37 AM, Peter Maydell
> wrote:
>> It would be helpful if you said what the abort actually was
>> (ie what instruction do we abort on, what are the fault status/
>> fault address registers if applicable, etc).
> I shou
On 15 October 2015 at 17:05, Michael Roth wrote:
> Hi Peter,
>
> Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in
> Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical,
> but let me know if you'd prefer a re-send/re-base later.
>
> The following chang
On 16.10.2015 19:36, Sergey Fedorov wrote:
> On 16.10.2015 17:08, Sergey Fedorov wrote:
>> On 16.10.2015 04:14, Richard Henderson wrote:
>>> On 10/16/2015 03:36 AM, Peter Maydell wrote:
On 14 October 2015 at 22:02, Richard Henderson wrote:
> On 10/15/2015 06:34 AM, Peter Maydell wrote:
>>
Avoid undefined behaviour from shifting left into the sign bit:
hw/ide/ahci.c:551:36: runtime error: left shift of 255 by 24 places cannot be
represented in type 'int'
(Unfortunately C's promotion rules mean that in the expression
"some_uint8_t_variable << 24" the LHS gets promoted to signed
int
On 15 October 2015 at 08:51, Markus Armbruster wrote:
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12'
> into staging (2015-10-13 10:42:06 +0100)
>
> are available in the git repository at:
On 16 October 2015 at 18:21, Ilya Lipnitskiy wrote:
> Hi All,
>
> I am running into a curious issue with QEMU ARM, maybe a Linux/QEMU
> ARM expert could help before I filed a bug report. Is this a QEMU
> problem or is there a fundamental problem with my kernel change? QEMU
> builds before SHA 6ec1
Fixed in:
commit 3d937150dce20cb95cbaae99b6fd48dca4261f32
Author: John Snow
Date: Mon Oct 5 12:00:55 2015 -0400
qtest/ahci: fix redundant assertion
Fixes https://bugs.launchpad.net/qemu/+bug/1497711
(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).
The
+-- On Fri, 16 Oct 2015, Paolo Bonzini wrote --+
| > +if (s->tx.link == s->cu_offset)
| > +break;
|
| Please update the patch to conform to QEMU's coding standards; braces
| are required even around single-statement blocks.
Done. Please see an updated patch below.
===
>From
* Pavel Fedin (p.fe...@samsung.com) wrote:
> Hello!
>
> > Some thoughts:
> > a) There is a migration state notifier list - see
> > add_migration_state_change_notifier (spice
> > calls it)
> > - but I don't think it's called in the right places for your needs; we
> > could add some m
On 10/14/2015 04:36 AM, Kevin Wolf wrote:
> Am 13.10.2015 um 17:51 hat John Snow geschrieben:
>>
>>
>> On 10/13/2015 11:30 AM, Peter Crosthwaite wrote:
>>> On Tue, Oct 13, 2015 at 2:14 AM, Kevin Wolf wrote:
Am 12.10.2015 um 20:26 hat John Snow geschrieben:
>
>
> On 10/12/2015 02
Am 16.10.2015 um 18:53 hat Paul Durrant geschrieben:
> > > > > > Just tell your admin what virtual hardware you really need. (Or tell
> > > > > > them to give you a proper interface to configure your VMs yourself.)
> > > > > >
> > > > >
> > > > > My point is that the virtual hardware that the OS us
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 16 October 2015 17:43
> To: Paul Durrant
> Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu-
> de...@nongnu.org; xen-de...@lists.xen.org; qemu-bl...@nongnu.org
> Subject: Re: [Qemu-devel] Questio
On 10/16/2015 10:20 AM, Paul Durrant wrote:
>> -Original Message-
>>> On 10/13/2015 11:55 AM, Fabio Fantoni wrote:
I added ahci disk support in libxl and using it for week seems
Do we really need this many levels of quoting...
that
>> was
ok, af
On 10/16/2015 10:37 AM, Julio Faracco wrote:
> When the user setup a vnc server to QEMU using the argument "-vnc
> 0.0.0.0:0,websocket=5701" for example, he cannot get information about which
> websocket port VNC is running. The command "info vnc" shows only details about
> the main VNC server and
Am 16.10.2015 um 18:20 hat Paul Durrant geschrieben:
> > -Original Message-
> > From: Kevin Wolf [mailto:kw...@redhat.com]
> > Sent: 16 October 2015 17:12
> > To: Paul Durrant
> > Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu-
> > de...@nongnu.org; xen-de...@lists.x
When the user setup a vnc server to QEMU using the argument "-vnc
0.0.0.0:0,websocket=5701" for example, he cannot get information about which
websocket port VNC is running. The command "info vnc" shows only details about
the main VNC server and the clients. You can confirm that a websocket service
On 16.10.2015 17:08, Sergey Fedorov wrote:
> On 16.10.2015 04:14, Richard Henderson wrote:
>> On 10/16/2015 03:36 AM, Peter Maydell wrote:
>>> On 14 October 2015 at 22:02, Richard Henderson wrote:
On 10/15/2015 06:34 AM, Peter Maydell wrote:
> This is still the same cryptic comment we hav
On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote:
> On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote:
>> Ping -- any consensus on how we should implement the "do-or-die"
>> argument for transactions that start block jobs? :)
>>
>> This patch may look a little hokey in how it boxes arguments
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 16 October 2015 17:12
> To: Paul Durrant
> Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu-
> de...@nongnu.org; xen-de...@lists.xen.org; qemu-bl...@nongnu.org
> Subject: Re: [Qemu-devel] Questio
Now DE is supported by TCG so it can be enabled in CPUID bits.
Signed-off-by: Eduardo Habkost
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 05d7f26..5fe49b5 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cp
Bits 4-11 and 16-31 on DR6 are documented as always 1, so ensure they
can't be cleared by software.
Signed-off-by: Eduardo Habkost
---
target-i386/bpt_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c
index 3cb4a09..0
From: Richard Henderson
If the debug register is not enabled, we need
do nothing besides update the register.
Signed-off-by: Richard Henderson
Signed-off-by: Eduardo Habkost
---
target-i386/bpt_helper.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/target-i38
Bit 10 of DR7 is documented as always set to 1, so ensure that's
always the case.
Signed-off-by: Eduardo Habkost
---
target-i386/bpt_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c
index 23ce828..493deba 100644
--- a/target-i386/
From: Richard Henderson
Signed-off-by: Richard Henderson
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Rebase on top of new version of "Re-introduce optimal breakpoint
removal"
---
target-i386/bpt_helper.c | 98 +++-
target-i386/cpu.h
From: Richard Henderson
They're only used from bpt_helper.c now.
Signed-off-by: Richard Henderson
Signed-off-by: Eduardo Habkost
---
target-i386/bpt_helper.c | 29 -
target-i386/cpu.h| 27 ---
2 files changed, 28 insertions(+), 28 de
From: Richard Henderson
Introduce helper_get_dr so that we don't have to put CR4[DE]
into the scarce HFLAGS resource. At the same time, rename
helper_movl_drN_T0 to helper_set_dr and set the helper flags.
Signed-off-by: Richard Henderson
Signed-off-by: Eduardo Habkost
---
target-i386/bpt_hel
From: Richard Henderson
Before the last patch, we had an efficient loop that disabled
local breakpoints on task switch. Re-add that, but in a more
general way that handles changes to the global enable bits too.
Signed-off-by: Richard Henderson
Signed-off-by: Paolo Bonzini
Signed-off-by: Eduar
From: Richard Henderson
This moves the last of the iteration over breakpoints into
the bpt_helper.c file. This also allows us to make several
breakpoint functions static.
Signed-off-by: Richard Henderson
Signed-off-by: Eduardo Habkost
---
target-i386/bpt_helper.c | 29 ++-
Updated version of the series submitted by Richard Henderson.
With the additional changes, the kvm-unit-tests debug extensions test case
written by Paolo passes all tests except ICEBP.
Changes v1 -> v2:
* Patch 2/9: Included fix from Paolo to make sure dr7 is updated
after hw_breakpoint_remove(
On 15 October 2015 at 08:57, Eduardo Otubo
wrote:
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12'
> into staging (2015-10-13 10:42:06 +0100)
>
> are available in the git repository at:
>
>
Am 16.10.2015 um 17:10 hat Paul Durrant geschrieben:
> > -Original Message-
> > From: Kevin Wolf [mailto:kw...@redhat.com]
> > Sent: 16 October 2015 16:02
> > To: Paul Durrant
> > Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu-
> > de...@nongnu.org; xen-de...@lists.x
Eduardo Habkost writes:
> On Fri, Oct 16, 2015 at 11:13:21AM +0200, Stefan Hajnoczi wrote:
>> On Tue, Oct 13, 2015 at 07:10:27PM +0200, Lluís Vilanova wrote:
>> > diff --git a/trace/control.h b/trace/control.h
>> > index da9bb6b..1a78a7b 100644
>> > --- a/trace/control.h
>> > +++ b/trace/control.h
Stefan Hajnoczi writes:
> On Tue, Oct 13, 2015 at 07:10:33PM +0200, Lluís Vilanova wrote:
>> diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py
>> index 9b39430..4bdb48f 100644
>> --- a/scripts/tracetool/format/h.py
>> +++ b/scripts/tracetool/format/h.py
>> @@ -6,7 +6,7 @@
On 16/10/2015 16:31, Peter Maydell wrote:
> > I hadn't thought about levels, but honestly when I use KVM tracing (which
> > is often measured in tens of megabytes per run) I don't care.
>
> In a lot of cases, especially with the TCG logging, not enabling
> voluminous tracing is really important b
Stefan Hajnoczi writes:
> On Tue, Oct 13, 2015 at 07:11:07PM +0200, Lluís Vilanova wrote:
>> diff --git a/trace/control-internal.h b/trace/control-internal.h
>> index 70e55df..b4069e3 100644
>> --- a/trace/control-internal.h
>> +++ b/trace/control-internal.h
>> @@ -12,6 +12,12 @@
>>
>> #include
According to Microsoft documentation, the signature in the standard
hypervisor CPUID leaf at 0x4000 identifies the Vendor ID and is
for reporting and diagnostic purposes only. We can therefore allow
the user to change it to whatever they want, within the 12 character
limit. Add a new hyperv-v
On 15 October 2015 at 07:27, Juan Quintela wrote:
>
> Hi Peter
>
> This is a pull request with the small fixes from the list, please apply.
>
> Later, Juan
>
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-
On Fri, Oct 16, 2015 at 5:24 AM, sai pavan wrote:
> Hi Jason,
>
> On Fri, Oct 16, 2015 at 1:07 PM, Jason Wang wrote:
>>
>>
>> On 10/16/2015 01:15 PM, sai pavan wrote:
>>> +Peter
>>>
>>> Hi Jason,
>>>
>>> On Thu, Oct 15, 2015 at 2:44 PM, Jason Wang wrote:
On 10/15/2015 02:36 PM, sai pav
On 16/10/2015 16:46, Daniel Fahlgren wrote:
> The spec can be found at
> http://www.alldatasheet.com/datasheet-pdf/pdf/206865/WINBOND/W83627THF.html
>
> To quote the datasheet about the other features:
>
> "83627THF is a Winbond LPC I/O product. It integrates the following
> major peripheral fu
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 16 October 2015 16:02
> To: Paul Durrant
> Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu-
> de...@nongnu.org; xen-de...@lists.xen.org; qemu-bl...@nongnu.org
> Subject: Re: [Qemu-devel] Questio
From: Jeff Cody
If a node-name is not specified, automatically generate the node-name.
Generated node-names will use the "block" sub-system identifier.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
---
block.c | 19 ---
tests/qemu-iotests/041
On 16/10/2015 10:49, Paolo Bonzini wrote:
> The following changes since commit 5451316ed07b758a187dedf21047bed8f843f7f1:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2015-10-12 15:52:54 +0100)
>
> are available in the git repository at:
>
> g
On 10/07/2015 08:00 PM, Eric Blake wrote:
> Pending prerequisite: Markus' qapi-next branch (which has my
> subset A patches):
> git://repo.or.cz/qemu/armbru.git qapi-next
> http://thread.gmane.org/gmane.comp.emulators.qemu/365827/focus=366351
> as well as my subset B patches (currently at v7):
> ht
From: Stefan Hajnoczi
CONFIG_LINUX_AIO is an implementation detail of raw-posix.c. Don't
mention CONFIG_LINUX_AIO in blockdev.c. Let block drivers decide what
to do with BDRV_O_NATIVE_AIO. They may print an error if it is
unsupported.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
Signed-off-by: Kevin Wolf
Reviewed-by: Jeff Cody
---
block/blkverify.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/blkverify.c b/block/blkverify.c
index f8655ad..c5f8e8d 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -143,6 +143,9 @@ static int blkverify_open(BlockDri
On Fri, 16 Oct 2015 08:26:14 -0600
Alex Williamson wrote:
> On Fri, 2015-10-16 at 09:30 +0200, Paolo Bonzini wrote:
> >
> > On 16/10/2015 00:16, Alex Williamson wrote:
> > > According to Microsoft documentation, the signature in the standard
> > > hypervisor CPUID leaf at 0x4000 identifies t
bdrv_unref() can be called with a NULL argument and doesn't do anything
then. Make bdrv_unref_child() consistent with it.
Signed-off-by: Kevin Wolf
Reviewed-by: Jeff Cody
---
block.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index f38146e..64900
On Fri, Oct 16, 2015 at 11:13:21AM +0200, Stefan Hajnoczi wrote:
> On Tue, Oct 13, 2015 at 07:10:27PM +0200, Lluís Vilanova wrote:
> > diff --git a/trace/control.h b/trace/control.h
> > index da9bb6b..1a78a7b 100644
> > --- a/trace/control.h
> > +++ b/trace/control.h
> > @@ -1,7 +1,7 @@
> > /*
> >
This simplifies the code somewhat, especially when dropping whole
backing file subchains.
The exception is the mirroring code that does adventurous things with
bdrv_swap() and in order to keep it working, I had to duplicate most of
bdrv_set_backing_hd() locally. We'll get rid again of this uglines
This struct doesn't exist any more since commit 3fc48d09 in August 2011,
it's about time to remove its forward declaration.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block/qcow2.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index d700bf1..35122
This patch removes the temporary duplication between bs->file and
bs->file_child by converting everything to BdrvChild.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block.c | 63
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block.c | 3 +++
include/block/block_int.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/block.c b/block.c
index a2d6238..980437f 100644
--- a/block.c
+++ b/block
From: Stefan Hajnoczi
raw-posix.c silently ignores BDRV_O_NATIVE_AIO if libaio is unavailable.
It is confusing when aio=native performance is identical to aio=threads
because the binary was accidentally built without libaio.
Print a deprecation warning if -drive aio=native is used with a binary
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Jeff Cody
Reviewed-by: Stefan Hajnoczi
---
block/quorum.c | 65 ++
1 file changed, 34 insertions(+), 31 deletions(-)
diff
From: Fam Zheng
The word "backing file" nowadays refers to the backing_hd in the
external snapshot sense (i.e. bs->backing_hd), instead of the file sense
(bs->file). Correct the comment to use the right term.
Signed-off-by: Fam Zheng
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
Signed-
From: Jeff Cody
Multiple sub-systems in QEMU may find it useful to generate IDs
for objects that a user may reference via QMP or HMP. This patch
presents a standardized way to do it, so that automatic ID generation
follows the same rules.
This patch enforces the following rules when generating
This cleans up the mess we left behind in the mirror code after the
previous patch. Instead of using bdrv_swap(), just change pointers.
The interface change of the mirror job that callers must consider is
that after job completion, their local BDS pointers still point to the
same node now. qemu-im
From: Stefan Hajnoczi
The --aio=MODE option enables Linux AIO or Windows overlapped I/O.
The #ifdef CONFIG_LINUX_AIO was a layering violation that also prevented
Windows overlapped I/O from being used.
Now that raw-posix.c prints an error when Linux AIO has not been
compiled in, we can uncondit
It is unused now.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Jeff Cody
Reviewed-by: Stefan Hajnoczi
---
block.c | 34 --
include/block/block.h | 4
2 files changed, 38 d
bdrv_swap() is unused now. Remove it and all functions that have
no other users than bdrv_swap(). In particular, this removes the
.bdrv_rebind callbacks from block drivers.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Stefan H
Remember all parent nodes and just change the pointers there instead of
swapping the contents of the BlockDriverState.
Handling of snapshot=on must be moved further down in bdrv_open()
because *pbs (which is the bs pointer in the BlockBackend) must already
be set before bdrv_append() is called. Ot
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/io.c| 2 +-
include/block/block_int.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index e
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Jeff Cody
Reviewed-by: Stefan Hajnoczi
---
block/vmdk.c | 99 +++-
1 file changed, 51 insertions(+), 48 deletions(-)
diff
It allows changing the BlockDriverState that a BlockBackend points to.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/block-backend.c | 17 +
include/block/block_int.h | 2 ++
2 f
From: Kashyap Chamarthy
Although the canonical source of reference for QMP commands is
qapi-schema.json, for consistency's sake, update qmp-commands.hx to
state the list of supported transactionable operations, namely:
drive-backup
blockdev-backup
blockdev-snapshot-internal-sync
Some block jobs change the block device graph on completion. This means
that the device that owns the job and originally was addressed with its
device name may no longer be what the corresponding BlockBackend points
to.
Previously, the effects of bdrv_swap() ensured that the job was (at
least part
1 - 100 of 370 matches
Mail list logo
