Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 October 2015 at 20:27, Paolo Bonzini wrote: >> >> >> On 05/10/2015 20:46, Peter Maydell wrote: >>> The easy fix is to have some suitable ifdeffery in virtio-pci.c, >>> similar to how we only register the virtio_9p_pci and virtio_scsi_pci >> >> (vhost_scsi_pci) >> >>>

Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot tothe seccomp sandbox

2015-10-05 Thread Markus Armbruster
"Namsun Ch'o" writes: >> Drawback: complexity. If we decide to limit ourselves to the original >> threat model (rogue guest), and enter the sandbox only after setup, we >> can keep things simpler. > > We could do both without much complexity. This looks simple enough to me: > > rc = seccomp_ru

Re: [Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured

2015-10-05 Thread David Gibson
On Tue, Oct 06, 2015 at 02:25:07PM +1100, David Gibson wrote: > On Mon, Oct 05, 2015 at 04:13:30PM +0200, Paolo Bonzini wrote: > > > > > > On 03/10/2015 02:25, Alexey Kardashevskiy wrote: > > >> I think this is the aim of VMSTATE_UINT64_EQUAL() ? > > > > > > We use it only for things which canno

[Qemu-devel] [PATCH qemu] kvm-all: Align to qemu_real_host_page_size in kvm_set_phys_mem

2015-10-05 Thread Alexey Kardashevskiy
As the comment in kvm_set_phys_mem() says, KVM works in page size chunks. However it uses hardcoded TARGET_PAGE_SIZE which is 4K on most platforms while actual host may use different page size, for example, PPC64 hosts use 64K system pages. This replaces static TARGET_PAGE_SIZE with run-time calcu

Re: [Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured

2015-10-05 Thread David Gibson
On Mon, Oct 05, 2015 at 04:13:30PM +0200, Paolo Bonzini wrote: > > > On 03/10/2015 02:25, Alexey Kardashevskiy wrote: > >> I think this is the aim of VMSTATE_UINT64_EQUAL() ? > > > > We use it only for things which cannot be set via the command line > > and ideally there should be no VMSTATE_*_E

Re: [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-05 Thread David Gibson
On Mon, Oct 05, 2015 at 11:05:07AM +0200, Igor Mammedov wrote: > On Mon, 5 Oct 2015 14:05:23 +0530 > Bharata B Rao wrote: > > > Size hotplug memory region assuming a 256MB max alignment every slot. > > > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/spapr.c | 3 +++ > > 1 file changed, 3

Re: [Qemu-devel] [PATCH 1/3] target-i386: add a subsection of vcpu's TSC rate in vmstate_x86_cpu

2015-10-05 Thread Haozhong Zhang
On Wed, Sep 30, 2015 at 09:07:08AM +0100, Dr. David Alan Gilbert wrote: > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: > > On Tue, Sep 29, 2015 at 08:00:13PM +0100, Dr. David Alan Gilbert wrote: > > > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: > > > > The newly added subsection 'vmsta

Re: [Qemu-devel] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

2015-10-05 Thread Haozhong Zhang
On Wed, Sep 30, 2015 at 05:36:11PM -0300, Eduardo Habkost wrote: > On Wed, Sep 30, 2015 at 08:32:26AM +0800, Haozhong Zhang wrote: > > > [...] > > > > > Or maybe we shouldn't treat this as VM state, but as configuration, > > > > > and > > > > > let management configure the TSC frequency explicitly

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-10-05 Thread John Snow
On 09/15/2015 12:24 PM, Eric Blake wrote: > On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: >> Persistent dirty bitmaps will be saved into qcow2 files. It may be used >> as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for >> other drives (there may be qcow2 file with

[Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads

2015-10-05 Thread Kevin O'Connor
Return a static signature ("QEMU CFG") if the guest does a read to the DMA address io register. Signed-off-by: Kevin O'Connor --- Marc, if you decide to respin your fw_cfg series, I've updated the dma signature patch. This addresses the comments from Stefan, and I hope it addresses the comments

[Qemu-devel] [PATCH resent] linux-user: in poll(), if nfds is 0, pfd can be NULL

2015-10-05 Thread Laurent Vivier
This problem appears with yum in Fedora 20 / PPC64 container. test case: #include #include int main(void) { int ret; ret = poll(NULL, 0, 1000); printf("%d\n", ret); } target test environment: Fedora 20 / PPC64 host test environment: Ubuntu 14.0.2 /

Re: [Qemu-devel] [PULL 14/15] vhost-user-test: use tmpfs by default

2015-10-05 Thread Michael S. Tsirkin
On Mon, Oct 05, 2015 at 11:39:39PM +0100, Peter Maydell wrote: > On 2 October 2015 at 14:45, Michael S. Tsirkin wrote: > > Most people don't run make check by default, so they skip vhost-user > > unit tests. Solve this by using tmpfs instead, unless hugetlbfs is > > specified (using an environmen

Re: [Qemu-devel] [PULL 14/15] vhost-user-test: use tmpfs by default

2015-10-05 Thread Michael S. Tsirkin
On Mon, Oct 05, 2015 at 11:39:39PM +0100, Peter Maydell wrote: > On 2 October 2015 at 14:45, Michael S. Tsirkin wrote: > > Most people don't run make check by default, so they skip vhost-user > > unit tests. Solve this by using tmpfs instead, unless hugetlbfs is > > specified (using an environmen

Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot tothe seccomp sandbox

2015-10-05 Thread Namsun Ch'o
> Drawback: complexity. If we decide to limit ourselves to the original > threat model (rogue guest), and enter the sandbox only after setup, we > can keep things simpler. We could do both without much complexity. This looks simple enough to me: rc = seccomp_rule_add(ctx, SCMP_ACT_ALLOW, SCMP_

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Michael S. Tsirkin
On Tue, Oct 06, 2015 at 12:04:40AM +0200, Laurent Vivier wrote: > > > On 05/10/2015 23:08, Michael S. Tsirkin wrote: > > On Mon, Oct 05, 2015 at 03:20:19PM +0200, Laurent Vivier wrote: > >> no more comments, it should mean it's ok ? > >> > >> Can someone merge this or just say "stop this, I don't

Re: [Qemu-devel] [PATCH v6 08/16] qapi: Test use of 'number' within alternates

2015-10-05 Thread Eric Blake
On 09/29/2015 07:38 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Add some testsuite exposure for use of a 'number' as part of >> an alternate. The current state of the tree has a few bugs >> exposed by this: our input parser depends on the ordering of >> how the qapi schema declared th

Re: [Qemu-devel] [PATCH 02/17] block: add bdrv_dirty_bitmap_size()

2015-10-05 Thread John Snow
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 5 + > include/block/block.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/block.c b/block.c > index 6d14f5b..8c39d0a 100644 > --- a/block.

Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

2015-10-05 Thread John Snow
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 2 +- > include/block/block.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 4f7fc0d..6d14f5b 100644

Re: [Qemu-devel] [PATCH v7 08/18] qapi: Test use of 'number' within alternates

2015-10-05 Thread Eric Blake
On 09/29/2015 04:21 PM, Eric Blake wrote: > Add some testsuite exposure for use of a 'number' as part of > an alternate. The current state of the tree has a few bugs > exposed by this: our input parser depends on the ordering of > how the qapi schema declared the alternate, and the parser > does n

Re: [Qemu-devel] [PULL 14/15] vhost-user-test: use tmpfs by default

2015-10-05 Thread Peter Maydell
On 2 October 2015 at 14:45, Michael S. Tsirkin wrote: > Most people don't run make check by default, so they skip vhost-user > unit tests. Solve this by using tmpfs instead, unless hugetlbfs is > specified (using an environment variable). > > Signed-off-by: Michael S. Tsirkin > Reviewed-by: Marc

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Laurent Vivier
On 05/10/2015 23:08, Michael S. Tsirkin wrote: > On Mon, Oct 05, 2015 at 03:20:19PM +0200, Laurent Vivier wrote: >> no more comments, it should mean it's ok ? >> >> Can someone merge this or just say "stop this, I don't want that"... >> >> Laurent > > I'm afraid as a first step, we need to bring

Re: [Qemu-devel] [PATCHv3] target-arm: Implement AArch64 OSLAR/OSLSR_EL1 sysregs

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 22:36, Davorin Mista wrote: > Added oslar_write function to OSLAR_EL1 sysreg, using a status variable > in ARMCPUState.cp15 struct (oslsr_el1). This variable is also linked > to the newly added read-only OSLSR_EL1 register. > > Linux reads from this register during its suspend

Re: [Qemu-devel] [PATCH] target-arm: Avoid calling arm_el_is_aa64() function for unimplemented EL

2015-10-05 Thread Peter Maydell
On 2 October 2015 at 14:21, Sergey Sorokin wrote: > It is incorrect to call arm_el_is_aa64() function for unimplemented EL. > This patch fixes several attempts to do so. > > Signed-off-by: Sergey Sorokin > --- > target-arm/cpu.h| 8 +--- > target-arm/helper.c | 15 +-- > 2 f

Re: [Qemu-devel] [kvm-unit-tests PATCHv2] arm: Add PMU test

2015-10-05 Thread Wei Huang
On 10/02/2015 10:48 AM, Christopher Covington wrote: > Add test the ARM Performance Monitors Unit (PMU). The informational > fields from the control register are printed, but not checked, and > the number of cycles it takes to run a known-instruction-count loop > is printed, but not checked. Once

Re: [Qemu-devel] [PATCHv2] target-arm: Implement AArch64 OSLSR_EL1 sysreg

2015-10-05 Thread Alistair Francis
On Mon, Oct 5, 2015 at 2:25 PM, Davorin Mista wrote: > Thanks Peter, I've made all changes as you suggested, but there is no > property "ARM_CP_NO_RAW", there's also nothing similar to it defined in > cpu.h, here's all the options: > > #define ARM_CP_SPECIAL 1 > #define ARM_CP_CONST 2 > #define AR

[Qemu-devel] [PATCHv3] target-arm: Implement AArch64 OSLAR/OSLSR_EL1 sysregs

2015-10-05 Thread Davorin Mista
Added oslar_write function to OSLAR_EL1 sysreg, using a status variable in ARMCPUState.cp15 struct (oslsr_el1). This variable is also linked to the newly added read-only OSLSR_EL1 register. Linux reads from this register during its suspend/resume procedure. Signed-off-by: Davorin Mista --- Chan

Re: [Qemu-devel] QEMU+Linux ARMv7A current state

2015-10-05 Thread John Snow
On 10/05/2015 04:44 PM, Beniamino Galvani wrote: > On Mon, Oct 05, 2015 at 11:13:33AM -0400, John Snow wrote: >> I'm looking into the cubieboard now. Is our emulation based on any >> particular model? (1-4?) > > The first model, the one with Allwinner A10. > >> I'm trying to see if I can find a

Re: [Qemu-devel] [PATCHv2] target-arm: Implement AArch64 OSLSR_EL1 sysreg

2015-10-05 Thread Davorin Mista
Thanks Peter, I've made all changes as you suggested, but there is no property "ARM_CP_NO_RAW", there's also nothing similar to it defined in cpu.h, here's all the options: #define ARM_CP_SPECIAL 1 #define ARM_CP_CONST 2 #define ARM_CP_64BIT 4 #define ARM_CP_SUPPRESS_TB_END 8 #define ARM_CP_OVE

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-05 Thread John Snow
On 09/21/2015 08:25 AM, Peter Lieven wrote: > PIO read requests on the ATAPI interface used to be sync blk requests. > This has to siginificant drawbacks. First the main loop hangs util an > I/O request is completed and secondly if the I/O request does not > complete (e.g. due to an unresponsive

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Michael S. Tsirkin
On Mon, Oct 05, 2015 at 03:20:19PM +0200, Laurent Vivier wrote: > no more comments, it should mean it's ok ? > > Can someone merge this or just say "stop this, I don't want that"... > > Laurent I'm afraid as a first step, we need to bring some order into -help. I also suspect that a good place

Re: [Qemu-devel] [PATCH v5 2/2] Use help sub-sections to create sub-help options

2015-10-05 Thread Michael S. Tsirkin
On Mon, Sep 14, 2015 at 08:01:20PM +0200, Laurent Vivier wrote: > As '-help' output is 400 lines long it is not easy > to find information, but generally we know from > which area we want the information. I agree - a bit more order is IMHO needed in the general -help - I'm not sure this is the pla

Re: [Qemu-devel] [PATCH] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 20:06, nutanshinde1992 wrote: > --- > hw/audio/adlib.c | 9 ++--- > hw/audio/es1370.c | 17 ++--- > hw/audio/gus.c| 9 ++--- > hw/audio/sb16.c | 15 +-- > 4 files changed, 15 insertions(+), 35 deletions(-) Hi; thanks for sending us th

Re: [Qemu-devel] QEMU+Linux ARMv7A current state

2015-10-05 Thread Beniamino Galvani
On Mon, Oct 05, 2015 at 11:13:33AM -0400, John Snow wrote: > I'm looking into the cubieboard now. Is our emulation based on any > particular model? (1-4?) The first model, the one with Allwinner A10. > I'm trying to see if I can find anything that resembles a spec to see > what kind of registers

[Qemu-devel] [PULL 10/10] vfio: Expose a VFIO PCI device's group for EEH

2015-10-05 Thread Alex Williamson
From: David Gibson The Enhanced Error Handling (EEH) interface in PAPR operates on units of a Partitionable Endpoint (PE). For VFIO devices, the PE boundaries the guest sees must match the PE (i.e. IOMMU group) boundaries on the host. To implement this it will need to discover from VFIO which g

[Qemu-devel] [PULL 09/10] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

2015-10-05 Thread Alex Williamson
From: David Gibson At present the memory listener used by vfio to keep host IOMMU mappings in sync with the guest memory image assumes that if a guest IOMMU appears, then it has no existing mappings. This may not be true if a VFIO device is hotplugged onto a guest bus which didn't previously inc

[Qemu-devel] [PULL 07/10] vfio: Record host IOMMU's available IO page sizes

2015-10-05 Thread Alex Williamson
From: David Gibson Depending on the host IOMMU type we determine and record the available page sizes for IOMMU translation. We'll need this for other validation in future patches. Signed-off-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Alex Williamson

[Qemu-devel] [PULL 02/10] hw/vfio/platform: change interrupt/unmask fields into pointer

2015-10-05 Thread Alex Williamson
From: Eric Auger unmask EventNotifier might not be initialized in case of edge sensitive irq. Using EventNotifier pointers make life simpler to handle the edge-sensitive irqfd setup. Signed-off-by: Eric Auger Signed-off-by: Alex Williamson --- hw/vfio/platform.c | 35 ++

[Qemu-devel] [PULL 08/10] memory: Allow replay of IOMMU mapping notifications

2015-10-05 Thread Alex Williamson
From: David Gibson When we have guest visible IOMMUs, we allow notifiers to be registered which will be informed of all changes to IOMMU mappings. This is used by vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. However, unlike with a memory region listener, an iommu noti

[Qemu-devel] [PULL 04/10] vfio: Remove unneeded union from VFIOContainer

2015-10-05 Thread Alex Williamson
From: David Gibson Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the Type1 fields are actually used

[Qemu-devel] [PULL 06/10] vfio: Check guest IOVA ranges against host IOMMU capabilities

2015-10-05 Thread Alex Williamson
From: David Gibson The current vfio core code assumes that the host IOMMU is capable of mapping any IOVA the guest wants to use to where we need. However, real IOMMUs generally only support translating a certain range of IOVAs (the "DMA window") not a full 64-bit address space. The common x86 I

[Qemu-devel] [PULL 01/10] hw/vfio/platform: irqfd setup sequence update

2015-10-05 Thread Alex Williamson
From: Eric Auger With current implementation, eventfd VFIO signaling is first set up and then irqfd is setup, if supported and allowed. This start sequence causes several issues with IRQ forwarding setup which, if supported, is transparently attempted on irqfd setup: IRQ forwarding setup is like

[Qemu-devel] [PULL 05/10] vfio: Generalize vfio_listener_region_add failure path

2015-10-05 Thread Alex Williamson
From: David Gibson If a DMA mapping operation fails in vfio_listener_region_add() it checks to see if we've already completed initial setup of the container. If so it reports an error so the setup code can fail gracefully, otherwise throws a hw_error(). There are other potential failure cases i

[Qemu-devel] [PULL 03/10] hw/vfio/platform: do not set resamplefd for edge-sensitive IRQS

2015-10-05 Thread Alex Williamson
From: Eric Auger In irqfd mode, current code attempts to set a resamplefd whatever the type of the IRQ. For an edge-sensitive IRQ this attempt fails and as a consequence, the whole irqfd setup fails and we fall back to the slow mode. This patch bypasses the resamplefd setting for non level-sentiv

[Qemu-devel] [PULL 00/10] VFIO updates for 2015-10-05

2015-10-05 Thread Alex Williamson
The following changes since commit c0b520dfb8890294a9f8879f4759172900585995: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0 fo

Re: [Qemu-devel] [PATCH 3/5] qga: guest exec functionality

2015-10-05 Thread Yuri Pudgorodskiy
On 10/2/2015 1:59 AM, Michael Roth wrote: +# +# Since: 2.5 +## +{ 'command': 'guest-exec', + 'data':{ 'path': 'str', '*arg': ['str'], '*env': ['str'], + '*inp-data': 'str', '*capture-output': 'bool' }, + 'returns': 'GuestExec' } Would it make sense to just add handle (pid) to

[Qemu-devel] [PATCH] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-05 Thread nutanshinde1992
--- hw/audio/adlib.c | 9 ++--- hw/audio/es1370.c | 17 ++--- hw/audio/gus.c| 9 ++--- hw/audio/sb16.c | 15 +-- 4 files changed, 15 insertions(+), 35 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 656eb37..af39920 100644 --- a/hw/audi

[Qemu-devel] [Bug 1502884] [NEW] Super important feature req: QEMU VNC server: Introduce a keyboard "norepeat" option!

2015-10-05 Thread Mikael
Public bug reported: Hi, A big issue when using QEMU's VNC server (VNC KVM) is that, when there's a network lag, unintended keypresses go through to the QEMU guest VM. This is frequently "enter" keypresses, causing all kinds of unintended consequences in the VM. So basically it's extremely dange

[Qemu-devel] [Bug 1502884] Re: Super important feature req: QEMU VNC server: Introduce a keyboard "norepeat" option!

2015-10-05 Thread Mikael
What I request seems to be the same option as x11vnc's "-norepeat", http://linux.die.net/man/1/x11vnc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1502884 Title: Super important feature req: QEMU

Re: [Qemu-devel] [PATCHv2] target-arm: Implement AArch64 OSLSR_EL1 sysreg

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 20:56, Davorin Mista wrote: > Added oslsr_write function to OSLAR_EL1 sysreg, using a status variable > in ARMCPUState struct (os_lock_status). > > Linux reads from this register during its suspend/resume procedure. > > Signed-off-by: Davorin Mista Thanks for this patch. I'm

Re: [Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs

2015-10-05 Thread Michael S. Tsirkin
On Mon, Oct 05, 2015 at 02:05:22PM +0530, Bharata B Rao wrote: > The suggested way to work around the virtio bug reported here > > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html > > is to introduce gaps between DIMMs. Igor's patchset changes the pc-dimm > auto-address assig

[Qemu-devel] [PATCHv2] target-arm: Implement AArch64 OSLSR_EL1 sysreg

2015-10-05 Thread Davorin Mista
Added oslsr_write function to OSLAR_EL1 sysreg, using a status variable in ARMCPUState struct (os_lock_status). Linux reads from this register during its suspend/resume procedure. Signed-off-by: Davorin Mista --- Changed in v2: -switched from using dummy registers to an actual register impleme

[Qemu-devel] QEMU Technical Talk: NVDIMM and persistent memory in QEMU

2015-10-05 Thread Stefan Hajnoczi
Marc Mari has volunteered to give the following online technical talk on Monday, 12 October at 14:00 UTC: "Marc Mari will present the new NVDIMM persistent memory device class and how they integrate into QEMU and SeaBIOS. The main concepts of the hardware specification are covered, as well as how

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 20:27, Paolo Bonzini wrote: > > > On 05/10/2015 20:46, Peter Maydell wrote: >> The easy fix is to have some suitable ifdeffery in virtio-pci.c, >> similar to how we only register the virtio_9p_pci and virtio_scsi_pci > > (vhost_scsi_pci) > >> types if they've been configured i

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 20:47, Peter Maydell wrote: > On 5 October 2015 at 19:11, Eduardo Habkost wrote: >> On Sun, Oct 04, 2015 at 07:44:29PM +0100, Peter Maydell wrote: >>> On 17 September 2015 at 17:32, Paolo Bonzini wrote: On 17/09/2015 18:16, Peter Maydell wrote: > On 17 September

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 20:46, Peter Maydell wrote: > The easy fix is to have some suitable ifdeffery in virtio-pci.c, > similar to how we only register the virtio_9p_pci and virtio_scsi_pci (vhost_scsi_pci) > types if they've been configured into this build. Hmm, actually there's no reason to limit co

Re: [Qemu-devel] [Qemu-discuss] TCP options ipv4 and ipv6 have no effect

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 20:03, Sair, Umair wrote: >> The first if handles the "default to N" case, the second handles "default to >> Y", the (absent) else case handles "default to PF_UNSPEC". > > Can you please elaborate it. Also I am not understanding the reason for > inverting the values of addr->has_

Re: [Qemu-devel] [Qemu-discuss] TCP options ipv4 and ipv6 have no effect

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 20:03, Sair, Umair wrote: >> The first if handles the "default to N" case, the second handles "default to >> Y", the (absent) else case handles "default to PF_UNSPEC". > > Can you please elaborate it. Also I am not understanding the reason for > inverting the values of addr->has_

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 18:11, Markus Armbruster wrote: > Sigh. I'll stare at the original backtrace some more. Here's one from a debug build (with some reasoning about the cause underneath it). As an aside, thanks to your valgrind example I figured out how to get the test makefile to run tests un

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 19:11, Eduardo Habkost wrote: > On Sun, Oct 04, 2015 at 07:44:29PM +0100, Peter Maydell wrote: >> On 17 September 2015 at 17:32, Paolo Bonzini wrote: >> > >> > >> > On 17/09/2015 18:16, Peter Maydell wrote: >> >> On 17 September 2015 at 17:00, Paolo Bonzini wrote: >> >>> >>

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-10-05 Thread Eduardo Habkost
On Sun, Oct 04, 2015 at 07:44:29PM +0100, Peter Maydell wrote: > On 17 September 2015 at 17:32, Paolo Bonzini wrote: > > > > > > On 17/09/2015 18:16, Peter Maydell wrote: > >> On 17 September 2015 at 17:00, Paolo Bonzini wrote: > >>> > >>> > >>> On 17/09/2015 16:24, Peter Maydell wrote: > Ca

Re: [Qemu-devel] [Qemu-discuss] TCP options ipv4 and ipv6 have no effect

2015-10-05 Thread Sair, Umair
> The first if handles the "default to N" case, the second handles "default to > Y", the (absent) else case handles "default to PF_UNSPEC". Can you please elaborate it. Also I am not understanding the reason for inverting the values of addr->has_ipv* in second if condition. I believe that the f

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 October 2015 at 07:49, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 2 October 2015 at 18:20, Markus Armbruster wrote: QMP command device-list-properties regressed in 2.1: it can crash or leave dangling pointers behind. -device FOO

Re: [Qemu-devel] [PATCH 21/36] misc: spelling

2015-10-05 Thread Markus Armbruster
Michael Tokarev writes: > 05.10.2015 08:09, Markus Armbruster пишет: >> Michael Tokarev writes: >> >>> 25.09.2015 19:08, Eric Blake wrote: On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > [] Reviewed-by: Eric Blake >>> >>> Note there's no S-

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-05 Thread Stefano Stabellini
Hi Lan, thanks for the patch. On Wed, 30 Sep 2015, Lan Tianyu wrote: > MSIX MMIO memory region is added to pt device's obj as property. msix->mmio is added to XenPCIPassthroughState's object as property > When pt device is unplugged, all properties will be deleted and > memory region's obj is n

[Qemu-devel] [PULL 10/12] x86: use new method to correct reset sequence

2015-10-05 Thread Eduardo Habkost
From: Zhu Guihua During reset some devices (such as hpet, rtc) might send IRQ to APIC which changes APIC's state from default one it's supposed to have at machine startup time. Fix this by resetting APIC after devices have been reset to cancel any changes that qemu_devices_reset() might have done

Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring

2015-10-05 Thread Dmitry Osipenko
05.10.2015 19:27, Peter Crosthwaite пишет: On Mon, Oct 5, 2015 at 9:07 AM, Dmitry Osipenko wrote: 03.10.2015 16:11, Dmitry Osipenko пишет: 20.09.2015 20:48, Peter Crosthwaite пишет: On Sun, Jul 5, 2015 at 1:58 PM, Peter Crosthwaite wrote: On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko

[Qemu-devel] [PULL 01/12] cpu: Introduce X86CPUTopoInfo structure for argument simplification

2015-10-05 Thread Eduardo Habkost
From: Chen Fan In order to simplify arguments of function, introduce a new struct named X86CPUTopoInfo. Signed-off-by: Chen Fan Signed-off-by: Zhu Guihua Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 6 +++--- include/hw/i386/topology.h | 33 +--

[Qemu-devel] [PULL 00/12] X86 queue, 2015-10-05

2015-10-05 Thread Eduardo Habkost
Changes since the last pull request: * Removed the "enable check mode by default" patch that caused unnecessary warnings * Added the icc-bus-removal series from Zhu Guihua and Chen Fan The following changes since commit c0b520dfb8890294a9f8879f4759172900585995: Merge remote-tracking branch 'r

Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring

2015-10-05 Thread Peter Crosthwaite
On Mon, Oct 5, 2015 at 9:07 AM, Dmitry Osipenko wrote: > 03.10.2015 16:11, Dmitry Osipenko пишет: > >> 20.09.2015 20:48, Peter Crosthwaite пишет: >>> >>> On Sun, Jul 5, 2015 at 1:58 PM, Peter Crosthwaite >>> wrote: On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko wrote: > >

Re: [Qemu-devel] CharUDP - Connection refused

2015-10-05 Thread poma
On Mon, Oct 5, 2015 at 5:18 PM, Paolo Bonzini wrote: > > > On 04/10/2015 17:01, poma wrote: > > > > qemu-system-x86_64 ... \ > > -chardev > udp,id=charserial0,host=127.0.0.1,port=4555,localaddr=127.0.0.1,localport=4556 > \ > > -device isa-serial,chardev=charserial0,id=serial0 > > > > > > # netsta

[Qemu-devel] [PULL 02/12] vl: Add another sanity check to smp_parse() function

2015-10-05 Thread Eduardo Habkost
From: Thomas Huth The code in smp_parse already checks the topology information for sockets * cores * threads < cpus and bails out with an error in that case. However, it is still possible to supply a bad configuration the other way round, e.g. with: qemu-system-xxx -smp 4,sockets=1,cores=4,thr

[Qemu-devel] [PULL 04/12] target-i386: Move breakpoint related functions to new file

2015-10-05 Thread Eduardo Habkost
From: Richard Henderson Reviewed-by: Eduardo Habkost Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/Makefile.objs | 2 +- target-i386/bpt_helper.c | 182 ++ target-i386/helper.c | 128

[Qemu-devel] [PULL 05/12] target-i386: Make check_hw_breakpoints static

2015-10-05 Thread Eduardo Habkost
From: Richard Henderson The function is now only used from within a single file. Reviewed-by: Eduardo Habkost Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 2 +- target-i386/cpu.h| 1 - 2 files changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PULL 12/12] icc_bus: drop the unused files

2015-10-05 Thread Eduardo Habkost
From: Zhu Guihua ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu

Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring

2015-10-05 Thread Dmitry Osipenko
03.10.2015 16:11, Dmitry Osipenko пишет: 20.09.2015 20:48, Peter Crosthwaite пишет: On Sun, Jul 5, 2015 at 1:58 PM, Peter Crosthwaite wrote: On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko wrote: 05.07.2015 23:26, Peter Crosthwaite пишет: Hi Dmitry, Based on my comment earlier, this is wh

[Qemu-devel] [PULL 09/12] apic: move APIC's MMIO region mapping into APIC

2015-10-05 Thread Eduardo Habkost
From: Chen Fan When ICC bus/bridge is removed, APIC MMIO will be left unmapped since it was mapped into system's address space indirectly by ICC bridge. Fix it by moving mapping into APIC code, so it would be possible to remove ICC bus/bridge code later. Signed-off-by: Chen Fan Signed-off-by: Z

[Qemu-devel] [PULL 11/12] cpu/apic: drop icc bus/bridge

2015-10-05 Thread Eduardo Habkost
From: Chen Fan After CPU hotplug has been converted to BUS-less hot-plug infrastructure, the only function ICC bus performs is to propagate reset to LAPICs. However LAPIC could be reset by registering its reset handler after all device are initialized. Do so and drop ~30LOC of not needed anymore

[Qemu-devel] [PULL 07/12] target-i386: add ABM to Haswell* and Broadwell* CPU models

2015-10-05 Thread Eduardo Habkost
From: Paolo Bonzini ABM is only implemented as a single instruction set by AMD; all AMD processors support both instructions or neither. Intel considers POPCNT as part of SSE4.2, and LZCNT as part of BMI1, but Intel also uses AMD's ABM flag to indicate support for both POPCNT and LZCNT. It has t

[Qemu-devel] [PULL 06/12] target-i386: get/put MSR_TSC_AUX across reset and migration

2015-10-05 Thread Eduardo Habkost
From: Amit Shah There's one report of migration breaking due to missing MSR_TSC_AUX save/restore. Fix this by adding a new subsection that saves the state of this MSR. https://bugzilla.redhat.com/show_bug.cgi?id=1261797 Reported-by: Xiaoqing Wei Signed-off-by: Amit Shah CC: Paolo Bonzini CC

[Qemu-devel] [PULL 08/12] Correctly re-init EFER state during INIT IPI

2015-10-05 Thread Eduardo Habkost
From: Bill Paul When doing a re-initialization of a CPU core, the default state is to _not_ have 64-bit long mode enabled. This means the LME (long mode enable) and LMA (long mode active) bits in the EFER model-specific register should be cleared. However, the EFER state is part of the CPU envir

[Qemu-devel] [PULL 03/12] target-i386: Convert kvm_default_*features to property/value pairs

2015-10-05 Thread Eduardo Habkost
Convert the kvm_default_features and kvm_default_unset_features arrays into a simple list of property/value pairs that will be applied to X86CPU objects when using KVM. Acked-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 8 ++--- hw/i386/pc_q35.c | 4 +-- target-i3

[Qemu-devel] [PULL 3/3] qtest/ide-test: ppc64be correction for ATAPI tests

2015-10-05 Thread John Snow
the 16bit ide data register is LE by definition. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1443461938-30039-1-git-send-email-js...@redhat.com --- tests/ide-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index

[Qemu-devel] [PULL 2/3] MAINTAINERS: Small IDE/FDC touchup

2015-10-05 Thread John Snow
libqos/ahci and tests/fdc-test are under my purview also, include them in the appropriate stanzas. Signed-off-by: John Snow Message-id: 1443117055-29240-1-git-send-email-js...@redhat.com --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e3e34fb

[Qemu-devel] [PULL 0/3] Ide patches

2015-10-05 Thread John Snow
The following changes since commit c0b520dfb8890294a9f8879f4759172900585995: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fet

[Qemu-devel] [PULL 1/3] qtest/ahci: fix redundant assertion

2015-10-05 Thread John Snow
Fixes https://bugs.launchpad.net/qemu/+bug/1497711 (!ncq || (ncq && lba48)) is the same as (!ncq || lba48). The intention is simply: "If a command is NCQ, it must also be LBA48." Signed-off-by: John Snow Message-id: 1442868929-1-1-git-send-email-js...@redhat.com --- tests/libqos/ahci.c | 2

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

2015-10-05 Thread Christian Pinto
Hello Peter, thanks for your comments On 01/10/2015 18:26, Peter Crosthwaite wrote: On Tue, Sep 29, 2015 at 6:57 AM, Christian Pinto wrote: Hi all, This RFC patch-series introduces the set of changes enabling the architectural elements to model the architecture presented in a previous RFC l

[Qemu-devel] [PATCH 5/5] qga: guest-exec simple stdin/stdout/stderr redirection

2015-10-05 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Implemented with base64-encoded strings in qga json protocol. Glib portable GIOChannel is used for data I/O. Optinal stdin parameter of guest-exec command is now used as stdin content for spawned subprocess. If capture-output bool flag is specified, guest-exec redirects

Re: [Qemu-devel] [PATCH] tests: Unique test path for /string-visitor/output

2015-10-05 Thread Eric Blake
On 10/05/2015 05:04 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Newer GLib's want unique test paths, and thus moan at dupes. > (Seen on Fedora 23 which has glib 2.46) > > Uniqueify the paths. Not sure if "Uniquify" is any better spelling for a made-up word? >

Re: [Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-10-05 Thread Eric Blake
On 10/03/2015 10:59 AM, Michael Tokarev wrote: > 25.09.2015 17:36, Shraddha Barke wrote: >> Compress lines and remove the variable. > > Applied to -trivial, removing the Coccinelle script > from the commit message. Why cripple the commit message? The coccinelle recipe is useful for someone trying

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Paolo Bonzini
On 14/09/2015 20:01, Laurent Vivier wrote: > This series allows to only display a given list of help sections. > > v5: introduce "-help[=LIST]", move help of help to the end "all" section. > Remove typo fix (already included). > v4: as proposed by Eric, provide a list of sections, restore de

[Qemu-devel] [Bug 1502934] Re: QEMU does not start when kvm enabled (SMM issue?)

2015-10-05 Thread Paolo Bonzini
This is a KVM bug, not a QEMU bug. It only happens with ept=1 and unrestricted_guest=0. A workaround is to disable SMM in QEMU (-machine smm=off) or to set kvm_intel's ept parameter to 0. I'm closing the bug here because it is the wrong tracker (also I know about it, can reproduce, and hope to pro

Re: [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-05 Thread Thomas Huth
On 05/10/15 10:35, Bharata B Rao wrote: > Size hotplug memory region assuming a 256MB max alignment every slot. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index fc5e7d6..2ec509b 100644 > -

Re: [Qemu-devel] CharUDP - Connection refused

2015-10-05 Thread Paolo Bonzini
On 04/10/2015 17:01, poma wrote: > > qemu-system-x86_64 ... \ > -chardev > udp,id=charserial0,host=127.0.0.1,port=4555,localaddr=127.0.0.1,localport=4556 > \ > -device isa-serial,chardev=charserial0,id=serial0 > > > # netstat -an | grep 4555 > udp0 0 127.0.0.1:4556 127.

Re: [Qemu-devel] QEMU+Linux ARMv7A current state

2015-10-05 Thread John Snow
On 10/03/2015 05:31 PM, Peter Crosthwaite wrote: > Hi, > > I have done an audit of the ARMv7 boards to see what can boot a > vanilla linux kernel. The basic approach is to build ARM > multi_v7_defconfig kernel and boot QEMU using the DTBs built out by > the kernel. The intersection of what mainl

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Daniel P. Berrange
On Mon, Oct 05, 2015 at 05:08:50PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Oct 5, 2015 at 3:20 PM, Laurent Vivier wrote: > > no more comments, it should mean it's ok ? > > > > Looks good to me, and works fine. However, libvirt will need to be > updated to use -help=all differently. I gu

[Qemu-devel] [PATCH 1/5] qga: drop guest_file_init helper and replace it with static initializers

2015-10-05 Thread Denis V. Lunev
This just makes code shorter and better. Signed-off-by: Denis V. Lunev Signed-off-by: Yuri Pudgorodskiy Reviewed-by: Michael Roth --- qga/commands-posix.c | 10 +++--- qga/commands-win32.c | 10 +++--- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c

[Qemu-devel] [Bug 1502934] [NEW] QEMU does not start when kvm enabled (SMM issue?)

2015-10-05 Thread Alexandre Kandalintsev
Public bug reported: Hi! QEMU stopped working after "[355023f2010c4df619d88a0dd7012b4b9c74c12c] pc: add SMM property" on my server. It says "Guest has not initialized the display (yet)." and nothing happens. But only if I use -enable-kvm. However, the problem gone after I hardcoded pc_machine_is

Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-10-05 Thread Peter Lieven
Am 02.10.2015 um 09:36 schrieb Gerd Hoffmann: Hi, Please have a look at: https://github.com/plieven/qemu/tree/vnc-next-2.0 Moving code to buf_adj_size and buf_req_size should go to a separate patch. The avg_size logic needs some description. Please have a look at: https://github.com/pl

[Qemu-devel] [PATCH 2/5] qga: guest exec functionality

2015-10-05 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Guest-exec rewriten in platform-independant style with glib spawn. Child process is spawn asynchroneously and exit status can later be picked up by guest-exec-status command. stdin/stdout/stderr of the child now is redirected to /dev/null Later we will add ability to spe

[Qemu-devel] [PATCH 4/5] qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all()

2015-10-05 Thread Denis V. Lunev
From: Yuri Pudgorodskiy glib may return G_IO_STATUS_AGAIN which is actually not an error. Also fixed a bug when on incomplete write buf pointer was not adjusted. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev Reviewed-by: Michael Roth --- qga/channel-posix.c | 23 +++-

  1   2   >