Re: [Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

2015-09-05 Thread Gonglei
On 2015/9/4 20:24, Peter Maydell wrote: > * Security process > * We've improved and documented our security process over the last >year or so, but it could still be improved. > * Big problem -- we fix CVEs on master, but we don't provide a stable >release with security fixes until the nex

Re: [Qemu-devel] [PATCH qemu] spapr: Enable in-kernel H_SET_MODE handling

2015-09-05 Thread Alexey Kardashevskiy
On 09/04/2015 02:48 PM, David Gibson wrote: On Wed, Sep 02, 2015 at 07:29:58PM +1000, Alexey Kardashevskiy wrote: For setting debug watchpoints, sPAPR guests use H_SET_MODE hypercall. The existing QEMU H_SET_MODE handler does not support this but the KVM handler in HV KVM does. However it is not

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

2015-09-05 Thread Xiao Guangrong
On 09/02/2015 07:31 PM, Igor Mammedov wrote: On Wed, 2 Sep 2015 18:36:43 +0800 Xiao Guangrong wrote: On 09/02/2015 05:58 PM, Igor Mammedov wrote: On Fri, 14 Aug 2015 22:51:59 +0800 Xiao Guangrong wrote: Introduce "pc-nvdimm" device and it has two parameters: Why do you use prefix "pc-

Re: [Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

2015-09-05 Thread Stefan Weil
Am 04.09.2015 um 14:24 schrieb Peter Maydell: > This is a brief writeup of what we discussed at the QEMU Summit 2015 > at KVM Forum last month. Thanks a lot for this summary. It is very helpful for those who could not attend the QEMU Summit. [...] > * Infrastructure Issues > * Wiki & git & ...

Re: [Qemu-devel] [PATCH v2 05/18] acpi: add aml_create_field

2015-09-05 Thread Xiao Guangrong
On 09/02/2015 07:10 PM, Igor Mammedov wrote: On Fri, 14 Aug 2015 22:51:58 +0800 Xiao Guangrong wrote: Implement CreateField term which are used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-bui

Re: [Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

2015-09-05 Thread Fam Zheng
On Fri, 09/04 13:41, Daniel P. Berrange wrote: > FYI, earlier this year the CentOS project started a new effort to > provide CI services to open source infrastructure projects. We have > started using them to CI of all libvirt pieces, virt-manager, and > libguestfs. In our initial discussions they

[Qemu-devel] [PATCH 02/34] linux-user: Reindent signal handling

2015-09-05 Thread Timothy E Baldwin
Some of the signal handling was a mess with a mixture of tabs and 8 space indents. Signed-off-by: Timothy Edward Baldwin --- linux-user/signal.c | 1691 ++- 1 file changed, 867 insertions(+), 824 deletions(-) diff --git a/linux-user/signal.c b/lin

[Qemu-devel] [PATCH 34/34] linux-user: Remove TARGET_USE_ERESTARTSYS

2015-09-05 Thread Timothy E Baldwin
Now with system call restarting support by all targets remove uneeded conditionals. Signed-off-by: Timothy Edward Baldwin --- linux-user/aarch64/syscall.h| 2 -- linux-user/alpha/syscall.h | 2 -- linux-user/arm/syscall.h| 2 -- linux-user/cris/syscall.h | 2 -- linux-user

[Qemu-devel] [PATCH 31/34] linux-user: Support for restarting system calls for M68K targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/m68k/syscall.h | 2 ++ linux-user/main.c | 24 +++- linux-user/signal.c | 20 3 files changed, 25 insertions(+), 21 deletions(-) diff --git a/linux-user/m68k/syscall.h b/linux-user/m68k/s

[Qemu-devel] [PATCH 23/34] linux-user: Queue synchronous signals separately

2015-09-05 Thread Timothy E Baldwin
If a synchronous signal and an asynchronous signal arrive near simultaneously, and the signal number of the asynchronous signal is lower than that of the synchronous signal the the handler for the asynchronous would be called first, and then the handler for the synchronous signal would be called wi

[Qemu-devel] [PATCH 24/34] linux-user: Restart execve() if signal pending

2015-09-05 Thread Timothy E Baldwin
Without this SIGTERM could fail to terminate the process, as the signal lost in QEMU's queue. Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1ce381e..4839154 10

[Qemu-devel] [PATCH 12/34] linux-user: Support for restarting system calls for APLHA targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- Signal handling NOT TESTED linux-user/alpha/syscall.h | 2 ++ linux-user/main.c | 7 +-- linux-user/signal.c| 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/linux-user/alpha/syscall.h b/linux-user/alpha/sysca

[Qemu-devel] [PATCH 22/34] linux-user: Remove real-time signal queuing

2015-09-05 Thread Timothy E Baldwin
As host signals are now blocked whenever guest signals are blocked, the queue of realtime signals in now in Linux. The Qemu queue is now redundant and removed. Signed-off-by: Timothy Edward Baldwin Conflicts: linux-user/qemu.h --- linux-user/main.c | 7 -- linux-user/qemu.h | 1

[Qemu-devel] [PATCH 13/34] linux-user: Fix signal before blocking system calls race and SA_RESTART

2015-09-05 Thread Timothy E Baldwin
If a signal is delivered immediately before a blocking system calls the handler will only be called after the system call returns, which may be a long time later or never. This is fixed by using a function (safe_syscall_base) that checks if a guest signal is pending prior to making a system call,

[Qemu-devel] [PATCH 29/34] linux-user: Support for restarting system calls for UniCore32 targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- WARNING - NOT TESTED linux-user/main.c | 7 ++- linux-user/unicore32/syscall.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index d86751a..9ca1c99 100644 --- a/linux-user/ma

[Qemu-devel] [PATCH 11/34] linux-user: Support for restarting system calls for SH4 targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- Works without signals, but my signal test case crashes with or without my changes. linux-user/main.c| 6 +- linux-user/sh4/syscall.h | 2 ++ linux-user/signal.c | 16 ++-- 3 files changed, 13 insertions(+), 11 deletions(-)

[Qemu-devel] [PATCH 27/34] linux-user: pause() should not pause if signal pending

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index da6d140..f89b730 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6106,7 +6106,10 @@ abi_long do

[Qemu-devel] [PATCH 25/34] linux-user: Restart exit() if signal pending

2015-09-05 Thread Timothy E Baldwin
Without this a signal could vanish on thread exit. Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 4839154..efe61e3 100644 --- a/linux-user/syscall.c +++ b

[Qemu-devel] [PATCH 05/34] linux-user: Support for restarting system calls for ARM targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/aarch64/syscall.h | 2 ++ linux-user/arm/syscall.h | 2 ++ linux-user/main.c| 47 +++- linux-user/signal.c | 10 +- 4 files changed, 38 insertions(+), 23 deletions(-) d

[Qemu-devel] [PATCH 18/34] linux-user: Fix race between multiple signals

2015-09-05 Thread Timothy E Baldwin
If multiple host signals are recieved in quick succession they would be queued in TaskState then delivered to the guest in spite of signals being blocked. Fixed by keeping host signals blocked until process_pending_signals() runs, this needs the guest signal state to be maintained by Qemu. Blockin

[Qemu-devel] [PATCH 10/34] linux-user: Support for restarting system calls for Microblaze targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- Works without signals, but my signal test case crashes with or without my changes. linux-user/main.c | 14 +- linux-user/microblaze/syscall.h | 2 ++ linux-user/signal.c | 2 +- 3 files changed, 12 insertions(+),

[Qemu-devel] [PATCH 26/34] linux-user: Restart kill() if signal pending

2015-09-05 Thread Timothy E Baldwin
Without this a signal could vanish if thread sends SIGKILL to itself. Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index efe61e3..da6d140 100644 --- a/linux-user

[Qemu-devel] [PATCH 21/34] linux-user: Remove redundant gdb_queuesig()

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- gdbstub.c | 13 - include/exec/gdbstub.h | 1 - 2 files changed, 14 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index ffe7e6e..fd319af 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1472,19 +1472,6 @@ void gdb_exit(CPUArchState

[Qemu-devel] [PATCH 33/34] linux-user: Support for restarting system calls for CRIS targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- WARNING - NOT TESTED linux-user/cris/syscall.h | 2 ++ linux-user/main.c | 6 +- linux-user/signal.c | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/linux-user/cris/syscall.h b/linux-user/cris/syscall.h index 295

[Qemu-devel] [PATCH 14/34] linux-user: Use safe_syscall for read and write system calls

2015-09-05 Thread Timothy E Baldwin
Restart read() and write() if signals occur before, or during with SA_RESTART Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b9ad7b6..c213588 100644 --- a

[Qemu-devel] [PATCH 20/34] linux-user: Remove redundant default action check in queue_signal()

2015-09-05 Thread Timothy E Baldwin
Both queue_signal() and process_pending_signals() did check for default actions of signals, this is redundant and also causes fatal and stopping signals to incorrectly cause guest system calls to be interrupted. The code in queue_signal() is removed. Signed-off-by: Timothy Edward Baldwin --- li

[Qemu-devel] [PATCH 32/34] linux-user: Support for restarting system calls for S390 targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- WARNING - NOT TESTED linux-user/main.c | 12 +--- linux-user/s390x/syscall.h | 2 ++ linux-user/signal.c| 4 ++-- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 0863

[Qemu-devel] [PATCH 15/34] linux-user: Remove redundant get_errno() calls

2015-09-05 Thread Timothy E Baldwin
The return value of openat was being translated by get_errno() twice. Fixed by removing calls of get_errno() in do_syscall() and keeping those in do_openat(). Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff -

[Qemu-devel] [PATCH 07/34] linux-user: Support for restarting system calls for PPC targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/main.c| 4 linux-user/ppc/syscall.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 124e9cc..5e9e3a8 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -1948,6 +1948,10 @@ v

[Qemu-devel] [PATCH 19/34] linux-user: Restart fork() if signals pending

2015-09-05 Thread Timothy E Baldwin
If there is a signal pending during fork() the signal handler will erroneously be called in both the parent and child, so handle any pending signals first. Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c

[Qemu-devel] [PATCH 28/34] linux-user: Restart sigaction() if signal pending

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/signal.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 15bd082..fc37f3b 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -629,7 +629,7 @@ out:

[Qemu-devel] [PATCH 08/34] linux-user: Support for restarting system calls for SPARC targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/main.c| 3 +++ linux-user/signal.c | 2 +- linux-user/sparc/syscall.h | 2 ++ linux-user/sparc64/syscall.h | 2 ++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index

[Qemu-devel] [PATCH 17/34] linux-user: Use safe_syscall for wait system calls

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e68eddb..281fa2d 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -698,6 +698,10 @@ safe_s

[Qemu-devel] [PATCH 03/34] linux-user: Support for restarting system calls

2015-09-05 Thread Timothy E Baldwin
This allows SA_RESTART to be supported along with various case where pending signals need to be handled before a system call. New macro TARGET_ERESTARTSYS which is the error code used by Linux to indicate that system call should be restarted. TARGET_QEMU_ESIGRETURN moved into errno_defs.h and ren

[Qemu-devel] [PATCH 30/34] linux-user: Support for restarting system calls for OpenRISC targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- WARNING - NOT TESTED linux-user/main.c | 22 ++ linux-user/openrisc/syscall.h | 2 ++ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 9ca1c99..b052e17 100644 --

[Qemu-devel] [PATCH 04/34] linux-user: Support for restarting system calls for x86 targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/i386/syscall.h | 2 ++ linux-user/main.c | 47 - linux-user/signal.c | 15 +++ linux-user/syscall.c| 2 -- linux-user/x86_64/syscall.h | 2 ++ 5 files change

[Qemu-devel] [PATCH 09/34] linux-user: Test for restarting system calls

2015-09-05 Thread Timothy E Baldwin
If DEBUG_ERESTARTSYS is set restart all system calls once. Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 04c91fb..80b8fa8 100644 --- a/linux-user/syscall.c +++ b/lin

[Qemu-devel] [PATCH 16/34] linux-user: Use safe_syscall for open and openat system calls

2015-09-05 Thread Timothy E Baldwin
Restart open() and openat() if signals occur before, or during with SA_RESTART. Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index df9b2ca..e68edd

[Qemu-devel] [PATCH 06/34] linux-user: Support for restarting system calls for MIPS targets

2015-09-05 Thread Timothy E Baldwin
Signed-off-by: Timothy Edward Baldwin --- linux-user/main.c | 4 linux-user/mips/syscall.h | 2 ++ linux-user/mips64/syscall.h | 2 ++ 3 files changed, 8 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 9653155..124e9cc 100644 --- a/linux-user/main.c +++ b/

[Qemu-devel] [PATCH 01/34] linux-user: Fix array bounds in errno conversion

2015-09-05 Thread Timothy E Baldwin
Check array bounds in host_to_target_errno() and target_to_host_errno(). Signed-off-by: Timothy Edward Baldwin --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 264debc..4e40dc6 100644 --- a/linux-us

[Qemu-devel] [PATCH 00/34] linux-user: Fix signal race conditions and SA_RESTART

2015-09-05 Thread Timothy E Baldwin
There are many races with signals in linux user: - Multiple host signals in quick succession, fixed by keeping host signals blocked, and checking if target signals are blocked before calling target signal handler. - Signal shortly before blocking system call, fixed by either: - Block ho

[Qemu-devel] [Bug 1492649] [NEW] QEMU soundhw HDA huge microphone lag

2015-09-05 Thread Nek
Public bug reported: I use a Windows 7 x86_64 guest with VGA passthrough and -soundhw hda. The audio plays fine, but the microphone input is delayed by more than 20 seconds. -soundhw ac97 does not have this delay but it has choppy sound playback and input. System: Arch linux Kernel: 4.1.6-1-ARCH

Re: [Qemu-devel] [PATCH 12/17] target-openrisc: Enable m[tf]spr from user mode

2015-09-05 Thread Bastian Koppelmann
On 09/03/2015 02:17 AM, Richard Henderson wrote: -if (dc->mem_idx == MMU_USER_IDX) { -gen_illegal_exception(dc); -return; +{ +TCGv_i32 tmp = tcg_temp_new_i32(); +tcg_gen_trunc_tl_i32(tmp, cpu_R[ra]); +tcg_gen_ori_i32(tmp,

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-05 Thread Peter Crosthwaite
On Fri, Sep 4, 2015 at 10:30 AM, Peter Maydell wrote: > On 4 September 2015 at 18:20, Richard Purdie > wrote: >> On Fri, 2015-09-04 at 13:43 +0100, Richard Purdie wrote: >>> On Fri, 2015-09-04 at 12:31 +0100, Peter Maydell wrote: >>> > On 4 September 2015 at 12:24, Richard Purdie >>> > wrote: >>

[Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-09-05 Thread Mark Cave-Ayland
Whilst investigating a migration issue, I noticed that the analyze-migration.py script had accidentally been broken by commit 61964. I've implemented a quick workaround to parse the configuration section into a separate Python object, however the solution works by parsing the SaveState properties

[Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-09-05 Thread Mark Cave-Ayland
Commit 61964 "Add configuration section" broke the analyze-migration.py script which terminates due to the unrecognised section. Fix the script by parsing the contents of the configuration section directly into a new ConfigurationSection object (although nothing is done with it yet). Signed-off-by

Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.

2015-09-05 Thread Peter Crosthwaite
On Fri, Sep 4, 2015 at 4:43 PM, Alistair Francis wrote: > On Fri, Sep 4, 2015 at 3:50 PM, Frederic Konrad > wrote: >> On 01/09/2015 22:58, Alistair Francis wrote: >>> >>> On Tue, Jul 21, 2015 at 10:17 AM, wrote: From: KONRAD Frederic Seems this field is not needed. >>> >>>

Re: [Qemu-devel] [PATCH v1 3/3] i.MX: Add GPIO device to i.MX25 SOC

2015-09-05 Thread Peter Crosthwaite
On Sat, Sep 5, 2015 at 1:17 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois Same comments as for P2. Otherwise, Reviewed-by: Peter Crosthwaite Regards, Peter > --- > hw/arm/fsl-imx25.c | 31 +++ > include/hw/arm/fsl-imx25.h | 15

Re: [Qemu-devel] [PATCH v1 2/3] i.MX: Add GPIO device to i.MX31 SOC

2015-09-05 Thread Peter Crosthwaite
"devices" in subject. On Sat, Sep 5, 2015 at 1:17 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > hw/arm/fsl-imx31.c | 30 ++ > include/hw/arm/fsl-imx31.h | 12 > 2 files changed, 42 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH V2] sdhci: use PRIx64 for uint64_t type

2015-09-05 Thread Peter Crosthwaite
On Sat, Sep 5, 2015 at 5:41 AM, Eric Blake wrote: > On 09/05/2015 03:12 AM, Sai Pavan Boddu wrote: >> Fix compile time warnings, because of type mismatch for unsigned long >> long type. >> >> Signed-off-by: Sai Pavan Boddu >> --- >> Changes for V2: >> Fix commit message. >> Correct line l

Re: [Qemu-devel] [PATCH V2] sdhci: use PRIx64 for uint64_t type

2015-09-05 Thread Peter Crosthwaite
On Sat, Sep 5, 2015 at 2:12 AM, Sai Pavan Boddu wrote: > Fix compile time warnings, because of type mismatch for unsigned long > long type. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite > --- > Changes for V2: > Fix commit message. > Correct line lenght. > --- > hw

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
On 05.09.2015 19:43, Vladimir Sementsov-Ogievskiy wrote: Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be qcow2 file with zero disk size but with several dirty bitmaps for other

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature: read-only mode. For now bitmaps are loaded only from writable bs's: in_use should be set in the image. Should we automatically load bitmaps in read-only mode if their storage is readonly? Hmm. I think it should be checked that bs_for - the disk, the bitmap is loading for is rea

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature: Migration of BdrvDirtyBitmap.file field. Bitmap 'percistancy' can be migrated only if its(bitmap) storage disk has id and the destination qemu has disk with same id. Stefan Hajnoczi wrote: Code might be necessary to ensure that: 1. The source host does not store the bitmap aft

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature: Periodic flushing of the bitmaps The idea: Disk is written often. Bitmap is updated more seldom. HBitmap previous level is updated even more seldom.. To not store all bitmap levels in file, just save in the image file the number of largest consistent level: flush bitmap: consis

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature? Bitmap auto loading. You can see flags for it in spec (0003), but it is not done yet. Is it really needed? Will it be useful for libvirt for ex? -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature: Do not stub on loding/storing large bitmaps: - background loading (bitmap started empty, and then merged with loaded parts) - meta bitmaps for storing (story only changed parts of the bitmap) -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for thi

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
qemu-img: print information about bitmaps ability of removing inconsistent bitmaps (in_use=true or corresponding autoclear-bit=0) -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature: Support of resizing a drive with dirty bitmaps (stored in it, stored in other disks). -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add tests. Including cases: - no writes - empty bitmaps - empty files - different cmd opts (file, file_id) - several bitmaps -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

Re: [Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add feature Allow qcow2 images without l1_table and other staff but only with dirty bitmaps with minimum overhead -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

[Qemu-devel] [PATCH 13/17] qemu: command line option for dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
The patch adds the following command line option: -dirty-bitmap [option1=val1][,option2=val2]... Avaliable options are: name The name of the bitmap. Should be unique per 'file'/'node' and per 'for_node'. file The separate qcow2 file for loading the bitmap 'name' from it. file_id When specified

[Qemu-devel] [PATCH 16/17] iotests: add VM.test_launcn()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Test vm can launch and print output in case of fail. This function is needed for testing erroneous cases Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qe

[Qemu-devel] [PATCH 14/17] qcow2-dirty-bitmap: add IN_USE flag

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
This flag is set on bitmap load and unset on store. If it is already set when loading the bitmap, the bitmap should not be load (it is in use by other drive or it is inconsistent (was not successfully saved)) Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 44 +++

[Qemu-devel] [PATCH 17/17] iotests: test internal persistent dirty bitmap

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add simple test cases for testing persistent dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/118| 112 ++ tests/qemu-iotests/118.out| 21 tests/qemu-iotests/group | 1 + tests/qemu-iotests/iote

[Qemu-devel] [PATCH 12/17] qcow2-dirty-bitmap: add autoclear bit

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add autoclear bit for handling rewriting image by old qemu version. If autoclear bit is not set, but Dirty bitmaps extension is found it would not be loaded and warning will be generated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 4 block/qcow2.c

[Qemu-devel] [PATCH 08/17] qcow2: add dirty bitmaps extension

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add dirty bitmap extension as specified in docs/specs/qcow2.txt. Load bitmap headers on open. Handle close and update_header. Handle resize: for now, just block resize if there are dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 79 +++

[Qemu-devel] [PATCH 11/17] block: add bdrv_load_dirty_bitmap()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
The funcion loads dirty bitmap from file, using underlying driver function. Note: the function doesn't change BdrvDirtyBitmap.file field. This field is only used by bdrv_store_dirty_bitmap() function and is ONLY written by bdrv_dirty_bitmap_set_file() function. Signed-off-by: Vladimir Sementsov-O

[Qemu-devel] [PATCH 15/17] qcow2-dirty-bitmaps: handle store reqursion

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
If persistent dirty bitmap bm tracks bs->file and stored in bs, then saving this bitmap to the image will change (make bits dirty) the bitmap bm. This is strange behaviour and should be forbidden. RFC: Should we check cases like bs_for == bs_file->file->file, or bs_for->file == bs_file, or bs_for-

[Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be qcow2 file with zero disk size but with several dirty bitmaps for other drives). Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH 09/17] qcow2-dirty-bitmap: add qcow2_dirty_bitmap_load_check()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
The function checks existing of the bitmap without loading it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 15 +++ block/qcow2-dirty-bitmap.c | 5 + block/qcow2.c | 1 + block/qcow2.h | 1 + include/block/block.h

[Qemu-devel] [PATCH 10/17] block: store persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Persistent dirty bitmaps are the bitmaps, for which the new field BdrvDirtyBitmap.file is not NULL. We save all persistent dirty bitmaps owned by BlockDriverState in corresponding bdrv_close(). BdrvDirtyBitmap.file is a BlockDriverState, where we want to save the bitmap. It may be set in bdrv_dirty

[Qemu-devel] [PATCH v3 RFC 0/17] block: persistent dirty bitmaps

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
v3: Hi all! After long delay I am starting a new thread about persistent dirty bitmaps. Not all ideas/requests are done from v2 thread, but I need to start somewhere. Also, there are a lot of code changes to be considered before everything is finished. Also, v2 thread is too large and it is hard t

[Qemu-devel] [PATCH 06/17] qcow2-dirty-bitmap: add qcow2_dirty_bitmap_load()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
This function loads block dirty bitmap from qcow2. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 155 + block/qcow2.c | 2 + block/qcow2.h | 5 ++ include/block/block_int.h | 5 ++ 4 files

[Qemu-devel] [PATCH 04/17] qcow2: Dirty Bitmaps Ext: structs and consts

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Add data structures and constraints accordingly to docs/specs/qcow2.txt Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/Makefile.objs| 2 +- block/qcow2-dirty-bitmap.c | 42 ++ block/qcow2.h | 28 3

[Qemu-devel] [PATCH 07/17] qcow2-dirty-bitmap: add qcow2_dirty_bitmap_store()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
This function stores block dirty bitmap to qcow2. If the bitmap with the same name, size and granularity already exists, it will be rewritten, if the bitmap with the same name exists but granularity or size does not match, an error will be genrated. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH 05/17] qcow2-dirty-bitmap: read dirty bitmap directory

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Adds qcow2_read_dirty_bitmaps, reading Dirty Bitmap Directory as specified in docs/specs/qcow2.txt Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 155 + block/qcow2.h | 10 +++ 2 files changed, 165 insertions

[Qemu-devel] [PATCH 02/17] block: add bdrv_dirty_bitmap_size()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 5 + include/block/block.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block.c b/block.c index 6d14f5b..8c39d0a 100644 --- a/block.c +++ b/block.c @@ -3632,6 +3632,11 @@ const char *bdrv_dirty_bitmap_name(const

[Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 2 +- include/block/block.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 4f7fc0d..6d14f5b 100644 --- a/block.c +++ b/block.c @@ -3591,7 +3591,7 @@ uint32_t bdrv_get_default_b

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-05 Thread Mark Cave-Ayland
On 04/09/15 17:46, Richard Henderson wrote: > On 09/04/2015 08:18 AM, Max Filippov wrote: >> On Wed, Sep 2, 2015 at 5:21 PM, Richard Henderson wrote: >>> git://github.com/rth7680/qemu.git tcg-search-2 >> >> That makes an impressive speedup for native kernel build on xtensa softmmu: >> down from 1

Re: [Qemu-devel] [PATCH] ARM targets: added ARM_FEATURE for Thumb-exception bit in system control register

2015-09-05 Thread Peter Maydell
On 5 September 2015 at 14:38, Mike Haben wrote: > Hi Peter, > You're quite right, on reading some more I see the correspondence with V7. > However... while reading up on the Cortex-M3/4/7, I also found > "Only Thumb and Thumb-2 instruction sets are supported in Cortex-M > architectures, but the

Re: [Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects.

2015-09-05 Thread Eric Blake
On 09/05/2015 07:25 AM, Eric Blake wrote: >> >> Oh, and tests/qapi-schema/test-qapi.py is annoying - even when it exits >> non-zero, it does NOT cause a failure in 'make check-qapi-schema'. > > Rather, it does not leave an obvious stack trace or immediate non-zero > status; and 'make check-qapi-sc

Re: [Qemu-devel] [PATCH] ARM targets: added ARM_FEATURE for Thumb-exception bit in system control register

2015-09-05 Thread Mike Haben
Hi Peter, You're quite right, on reading some more I see the correspondence with V7. However... while reading up on the Cortex-M3/4/7, I also found "Only Thumb and Thumb-2 instruction sets are supported in Cortex-M architectures, but the legacy 32-bit ARM instruction set isn't supported". U

Re: [Qemu-devel] [PATCH 0/2] alpha-host: Add Alpha host tcg backend to latest QEMU

2015-09-05 Thread Chen Gang
On 9/5/15 21:18, Max Filippov wrote: > On Sat, Sep 5, 2015 at 1:18 PM, Chen Gang wrote: >> Could any members tell me whether he/she can receive the patches (patch >> 1/2, 2/2 for alpha-host) via my qq mail address? >> >> It only seems OK, but I am not quite sure (really not sure). > > I saw these:

Re: [Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects.

2015-09-05 Thread Eric Blake
On 09/05/2015 07:19 AM, Eric Blake wrote: > On 09/04/2015 05:51 PM, Eric Blake wrote: >> We have a few fields that exist mainly to hold information from >> __init__() until check() (matching the fact that parsing is >> two-pass; the first to find type names, the second to associate >> types togethe

Re: [Qemu-devel] [PATCH RFC v4 05/32] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-05 Thread Eric Blake
On 09/03/2015 08:29 AM, Markus Armbruster wrote: > The old code prints the result of parsing (list of expression > dictionaries), and partial results of semantic analysis (list of enum > dictionaries, list of struct dictionaries). > > The new code prints a trace of a schema visit, i.e. what the ba

Re: [Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects.

2015-09-05 Thread Eric Blake
On 09/04/2015 05:51 PM, Eric Blake wrote: > We have a few fields that exist mainly to hold information from > __init__() until check() (matching the fact that parsing is > two-pass; the first to find type names, the second to associate > types together while honoring forward references), or which s

Re: [Qemu-devel] [PATCH 0/2] alpha-host: Add Alpha host tcg backend to latest QEMU

2015-09-05 Thread Max Filippov
On Sat, Sep 5, 2015 at 1:18 PM, Chen Gang wrote: > Could any members tell me whether he/she can receive the patches (patch > 1/2, 2/2 for alpha-host) via my qq mail address? > > It only seems OK, but I am not quite sure (really not sure). I saw these: http://lists.nongnu.org/archive/html/qemu-de

Re: [Qemu-devel] [PATCH] ARM targets: added ARM_FEATURE for Thumb-exception bit in system control register

2015-09-05 Thread Peter Maydell
On 5 September 2015 at 12:28, Mike Haben wrote: > Most ARM cores switch unconditionally to ARM mode when an exception occurs; > some Cortex variants have a "Thumb-exception enable" bit in the system > control register that allows an unconditional switch to Thumb mode instead > when handling except

Re: [Qemu-devel] [PATCH V2] sdhci: use PRIx64 for uint64_t type

2015-09-05 Thread Eric Blake
On 09/05/2015 03:12 AM, Sai Pavan Boddu wrote: > Fix compile time warnings, because of type mismatch for unsigned long > long type. > > Signed-off-by: Sai Pavan Boddu > --- > Changes for V2: > Fix commit message. > Correct line lenght. > --- > +#include > #include "hw/hw.h" > #include

[Qemu-devel] [PATCH] ARM targets: added ARM_FEATURE for Thumb-exception bit in system control register

2015-09-05 Thread Mike Haben
Most ARM cores switch unconditionally to ARM mode when an exception occurs; some Cortex variants have a "Thumb-exception enable" bit in the system control register that allows an unconditional switch to Thumb mode instead when handling exceptions. The presence of this bit seems unrelated to th

Re: [Qemu-devel] [PATCH V1] sdhci: use PRIx64 for uint64_t type

2015-09-05 Thread Sai Pavan Boddu
> -Original Message- > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Saturday, September 05, 2015 1:54 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org Developers; Peter Maydell; Alistair Francis; > Edgar Iglesias; Sai Pavan Boddu > Subject: Re: [PATCH V1] sdhci:

Re: [Qemu-devel] [PATCH 0/2] alpha-host: Add Alpha host tcg backend to latest QEMU

2015-09-05 Thread Chen Gang
Hello: Could any members tell me whether he/she can receive the patches (patch 1/2, 2/2 for alpha-host) via my qq mail address? It only seems OK, but I am not quite sure (really not sure). Thanks. On 8/31/15 17:17, Chen Gang wrote: > On 2015年08月31日 16:59, gang.chen.5...@gmail.com wrote: >> Fr

Re: [Qemu-devel] [RFCv2 1/2] pseries: Fix incorrect calculation of threads per socket for chip-id

2015-09-05 Thread Alexey Kardashevskiy
On 09/04/2015 02:56 PM, David Gibson wrote: On Fri, Sep 04, 2015 at 02:51:39PM +1000, David Gibson wrote: The device tree presented to pseries machine type guests includes an ibm,chip-id property which gives essentially the socket number of each vcpu core (individual vcpu threads don't get a nod

Re: [Qemu-devel] [RFCv2 2/2] spapr: Fix default NUMA node allocation for threads

2015-09-05 Thread Alexey Kardashevskiy
On 09/04/2015 02:51 PM, David Gibson wrote: At present, if guest numa nodes are requested, but the cpus in each node are not specified, spapr just uses the default behaviour or assigning each vcpu round-robin to nodes. If smp_threads != 1, that will assign adjacent threads in a core to different

[Qemu-devel] [PATCH V2] sdhci: use PRIx64 for uint64_t type

2015-09-05 Thread Sai Pavan Boddu
Fix compile time warnings, because of type mismatch for unsigned long long type. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Fix commit message. Correct line lenght. --- hw/sd/sdhci.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/

Re: [Qemu-devel] [PATCH v1 1/3] i.MX: Add GPIO device

2015-09-05 Thread Peter Crosthwaite
On Sat, Sep 5, 2015 at 1:17 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > hw/gpio/Makefile.objs | 1 + > hw/gpio/imx_gpio.c | 358 > + > include/hw/gpio/imx_gpio.h | 60 > 3 files changed, 4

Re: [Qemu-devel] [PATCH V1] sdhci: use PRIx64 for uint64_t type

2015-09-05 Thread Peter Crosthwaite
On Sat, Sep 5, 2015 at 1:07 AM, Sai Pavan Boddu wrote: > Fix compile time warnings, because of type missmatch for unsigned long long > type. > Commit message body should wrap to 72 chars. "mismatch". > Signed-off-by: Sai Pavan Boddu > --- > hw/sd/sdhci.c | 5 +++-- > 1 file changed, 3 inserti

[Qemu-devel] [PATCH v1 3/3] i.MX: Add GPIO device to i.MX25 SOC

2015-09-05 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- hw/arm/fsl-imx25.c | 31 +++ include/hw/arm/fsl-imx25.h | 15 +++ 2 files changed, 46 insertions(+) diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c index 6d157c9..035b7a8 100644 --- a/hw/arm/fsl-imx25.

[Qemu-devel] [PATCH v1 2/3] i.MX: Add GPIO device to i.MX31 SOC

2015-09-05 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- hw/arm/fsl-imx31.c | 30 ++ include/hw/arm/fsl-imx31.h | 12 2 files changed, 42 insertions(+) diff --git a/hw/arm/fsl-imx31.c b/hw/arm/fsl-imx31.c index 87548c8..aa938ed 100644 --- a/hw/arm/fsl-imx31.c ++

  1   2   >