On 13/08/2015 07:46, Liang Li wrote:
> Some cleanup operations take long time during the pause and copy stage,
> especially with the KVM patch 3ea3b7fa9af067, do these operations after
> the completion of live migration can help to reduce VM downtime.
>
> Ony the first patch changes the behavior
Just clean up code, no behavior change.
Signed-off-by: Liang Li
---
migration/block.c | 9 ++---
migration/ram.c | 9 ++---
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 55442bd..869798c 100644
--- a/migration/block.c
+++ b/
The function qemu_savevm_state_cancel is called after the migration
in migration_thread, it seems strange to 'cancel' it after completion,
rename it to qemu_savevm_state_cleanup looks better.
Signed-off-by: Liang Li
---
include/sysemu/sysemu.h | 2 +-
migration/migration.c | 2 +-
migration/sa
Because of the patch 3ea3b7fa9af067982f34b of kvm, now the migration_end()
is a time consuming operation, which takes about dozens of milliseconds, and
will prolong VM downtime. Such an operation should be done after migration
completion.
For a VM with 8G RAM, this patch can reduce the VM downtime
'cleanup' seems more appropriate than 'cancel'.
Signed-off-by: Liang Li
---
include/migration/vmstate.h | 2 +-
migration/block.c | 2 +-
migration/ram.c | 2 +-
migration/savevm.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/mig
Some cleanup operations take long time during the pause and copy stage,
especially with the KVM patch 3ea3b7fa9af067, do these operations after
the completion of live migration can help to reduce VM downtime.
Ony the first patch changes the behavior, the rest 3 patches are for code
cleanup.
Chang
> -Original Message-
> Date: Wed, 12 Aug 2015 14:15:54 +0300
> From: "Michael S. Tsirkin"
> To: Marcel Apfelbaum
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] virtio/vhost: drop unnecessary
> VHOST_SET_VRING call
> Message-ID: <20150812141448-mutt-send-email-...@
On (Tue) 11 Aug 2015 [20:21:18], Laszlo Ersek wrote:
> On 08/11/15 19:04, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port
> > state. However, the events may be for different ports, but the throttle
> > mecha
> -Original Message-
> From: Marc-André Lureau [mailto:marcandre.lur...@gmail.com]
> Sent: Wednesday, August 12, 2015 6:07 PM
> To: Michael S. Tsirkin
> Cc: Thibaut Collet; QEMU; stefa...@redhat.com; Jason Wang; Paolo Bonzini;
> Linhaifeng; Ouyang, Changchun
> Subject: Re: [PATCH v6 0/2]
> Am 13.08.2015 um 04:45 schrieb gchen gchen :
>
>> On 2015年08月12日 23:06, Richard Henderson wrote:
>> On 08/12/2015 12:59 AM, gchen gchen wrote:
Nack. There's 99 problems with host page size> guest page size. This
solves none of them, and in the hackiest way possible.
>>>
>>> Under
On 2015年08月12日 23:06, Richard Henderson wrote:
> On 08/12/2015 12:59 AM, gchen gchen wrote:
>>> Nack. There's 99 problems with host page size> guest page size. This
>>> solves none of them, and in the hackiest way possible.
>>>
>>
>> Under alpha virtual machine, if set i386 guest page size 8KB, i
On 08/12/2015 05:11 PM, Laurent Vivier wrote:
Le 12/08/2015 20:46, Richard Henderson a écrit :
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
+return (op1 & ~((1UL << bits) - 1)) | res; \
deposit32(op1, res, bits, 0)
You mean: deposit32(op1, 0, bits, res) ?
Yes, sorry. The operand
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
m68k: allow to update flags with operation on words and bytes
m68k: update CPU flags management
m68k: add X flag helpers
I wonder if we can talk about a different mechanism for tracking flags.
The x86 scheme tracks flags with 3 words: { op
Hello All:
For my company, it is useful to let qemu linux-user 8KB host support 4KB
guest, it may have many issues, but I want to try to fix them (with the
aid from qemu members). So I want to consult:
- Is it valuable and possible to fix these issues? (I guess, it is
valuable and possible, b
On 2015年08月12日 23:06, Richard Henderson wrote:> On 08/12/2015 12:59 AM,
gchen gchen wrote:>>> Nack. There's 99 problems with host page
size> guest page size. This>>> solves none of them, and in the
hackiest way possible.>>> Under alpha
virtual machine, if set i386 guest page size 8KB, it
On Thu, Aug 13, 2015 at 11:30:37AM +1000, Gavin Shan wrote:
> On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote:
> >On 08/11/2015 07:11 PM, Peter Maydell wrote:
> >>On 10 August 2015 at 08:13, Gavin Shan wrote:
> >>>The header file was introduced by following Linux upstream comm
On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote:
>On 08/11/2015 07:11 PM, Peter Maydell wrote:
>>On 10 August 2015 at 08:13, Gavin Shan wrote:
>>>The header file was introduced by following Linux upstream commits:
>>>
>>> commit ed3e81f ("powerpc/eeh: Move PE state constan
Hi Paolo & Marcelo,
Could please point out what issue the patch 317b0a6d8ba44e try to fix? I
found in live migration the cpu_synchronize_all_states will be called twice,
and it will take more than 1 ms sometimes. I try to do some optimization but
lack the knowledge about the background.
On Tue, Aug 11, 2015 at 11:54:08AM +1000, Alexey Kardashevskiy wrote:
>On 08/11/2015 10:57 AM, Gavin Shan wrote:
>>On Mon, Aug 10, 2015 at 10:24:56PM +1000, David Gibson wrote:
>>>On Fri, Aug 07, 2015 at 01:33:32PM +1000, Gavin Shan wrote:
The patch supports RTAS calls "ibm,{open,close}-errinjc
Le 12/08/2015 20:46, Richard Henderson a écrit :
> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>> +return (op1 & ~((1UL << bits) - 1)) | res; \
>
> deposit32(op1, res, bits, 0)
>
You mean: deposit32(op1, 0, bits, res) ?
Laurent
Le 13/08/2015 01:09, Richard Henderson a écrit :
> On 08/12/2015 03:43 PM, Laurent Vivier wrote:
>>
>>
>> Le 12/08/2015 19:05, Richard Henderson a écrit :
>>> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
---
target-m68k/translate.c | 34 +++
On 08/12/2015 03:43 PM, Laurent Vivier wrote:
Le 12/08/2015 19:05, Richard Henderson a écrit :
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
---
target-m68k/translate.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
Le 12/08/2015 19:05, Richard Henderson a écrit :
> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier
>> ---
>> target-m68k/translate.c | 34 +-
>> 1 file changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/target-m68k/translat
Add support for the Xilinx XADC core used in Zynq 7000.
References:
- Zynq-7000 All Programmable SoC Technical Reference Manual
- 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC
Dual 12-Bit 1 MSPS Analog-to-Digital Converter
Tested with Linux using qemu machine xilinx-zynq-a9 with device
On 08/12/2015 02:00 PM, Laszlo Ersek wrote:
> Assume there has been a long period of silence (no attempts to emit an
> event). Now some client code makes a call to emit the event.
>
> Will that event be emitted immediately, or will it be delayed to see if
> more are coming? I'd like to understand
Le 12/08/2015 23:19, Richard Henderson a écrit :
> On 08/12/2015 01:56 PM, Laurent Vivier wrote:
-DEF_HELPER_2(flush_flags, void, env, i32)
+DEF_HELPER_2(flush_flags, i32, env, i32)
>>>
>>> Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it
>>> reads some globals, but
On 08/12/2015 01:56 PM, Laurent Vivier wrote:
-DEF_HELPER_2(flush_flags, void, env, i32)
+DEF_HELPER_2(flush_flags, i32, env, i32)
Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it
reads some globals, but doesn't write any, or have any other side effects.
It writes "env->cc
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> uint32_t HELPER(rol32)(uint32_t val, uint32_t shift)
> {
> uint32_t result;
> @@ -1227,6 +1241,53 @@ void HELPER(set_mac_extu)(CPUM68KState *env, uint32_t
> val, uint32_t acc)
> env->macc[acc + 1] = res;
> }
>
> +/* load from a bitfiel
Le 12/08/2015 07:12, Richard Henderson a écrit :
> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>> @@ -798,9 +796,9 @@ void HELPER(mac_set_flags)(CPUM68KState *env,
>> uint32_t acc)
>> }
>> }
>>
>> -void HELPER(flush_flags)(CPUM68KState *env, uint32_t cc_op)
>> +uint32_t HELPER(flush_fla
On Wed, Aug 12, 2015 at 18:41:00 +0200, Paolo Bonzini wrote:
> page_find is reading the radix tree outside all locks, so it has to
> use the RCU primitives. It does not need RCU critical sections
> because the PageDescs are never removed, so there is never a need
> to wait for the end of code sect
Hi
- Original Message -
> On 08/12/15 21:46, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Create a seperate pending event structure MonitorQAPIEventPending.
> > Use a MonitorQAPIEventDelay callback to handle the delaying. This
> > allows other implementations of
On 08/12/15 21:46, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Create a seperate pending event structure MonitorQAPIEventPending.
> Use a MonitorQAPIEventDelay callback to handle the delaying. This
> allows other implementations of throttling.
>
> Signed-off-by: Marc-André L
From: Marc-André Lureau
Create a seperate pending event structure MonitorQAPIEventPending.
Use a MonitorQAPIEventDelay callback to handle the delaying. This
allows other implementations of throttling.
Signed-off-by: Marc-André Lureau
---
monitor.c| 124 +
From: Marc-André Lureau
Use a hash table to lookup the pending event corresponding to the "id"
field. The hash table may grow without limit here, the following patch
will add some cleaning.
Signed-off-by: Marc-André Lureau
---
monitor.c | 104 ++-
From: Marc-André Lureau
Do not let the hash table grow without limit, schedule a cleanup for
outdated event.
Signed-off-by: Marc-André Lureau
---
monitor.c | 51 ---
1 file changed, 48 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monit
From: Marc-André Lureau
QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port
state. However, the events may be for different ports, but the throttle
mechanism may replace the event for a different port, since it only
checks the event type.
The following series implements throttling
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/helper.c| 212
>
> target-m68k/helper.h| 14
> target-m68k/translate.c | 207 ++
> 3 files
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +#define HELPER_SHL(type, bits) \
> +uint32_t HELPER(glue(glue(shl, bits), _cc))(CPUM68KState *env, \
> +uint32_t val, uint32_t shift) \
> +{ \
> +type result; \
> +uint32_t cf; \
> +shift &= 63;
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +return (op1 & ~((1UL << bits) - 1)) | res; \
deposit32(op1, res, bits, 0)
Otherwise,
Reviewed-by: Richard Henderson
r~
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/cpu.h | 3 +
> target-m68k/helper.h| 6 ++
> target-m68k/op_helper.c | 143
>
> target-m68k/qregs.def | 1 +
> target-m68k/translat
Frederic Konrad writes:
> On 10/08/2015 17:27, fred.kon...@greensocs.com wrote:
>> From: KONRAD Frederic
>>
>> This protects TBContext with tb_lock to make tb_* thread safe.
>>
>> We can still have issue with tb_flush in case of multithread TCG:
>>An other CPU can be executing code during a
> Are you likely to push a v8 this week (or a temp branch?) with this and
> any other obvious fixes? I appreciate Paolo has given you a not-so-small
> pile of review comments as well so I wasn't looking for a complete new
> patch set!
FWIW, reviews of the patches I posted a hour or two ago are we
This bug has been reported on the Ubuntu ISO testing tracker.
A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1448985
** Tags added: iso-testing
--
You received this bug notification because you are a member of qemu-
devel-ml, which i
Hm, ok, thanks - sadly i don't have any board I can test this on with
me. Wonder whether a rpi2 (which I have but not with me) would work.
** Changed in: qemu (Ubuntu)
Status: Invalid => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscr
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/helper.c| 91
> +
> target-m68k/helper.h| 3 ++
> target-m68k/translate.c | 82
> 3 files change
I think it is in theory supposed to work, but possibly in practice it
doesn't...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1463172
Title:
destination arm board hangs after migration from x86 so
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +DISAS_INSN(scc_mem)
> +{
> +TCGLabel *l1;
> +int cond;
> +TCGv dest;
> +
> +l1 = gen_new_label();
> +cond = (insn >> 8) & 0xf;
> +dest = tcg_temp_local_new();
> +tcg_gen_movi_i32(dest, 0);
> +gen_jmpcc(s, cond ^ 1, l1)
On 10/08/2015 17:27, fred.kon...@greensocs.com wrote:
From: KONRAD Frederic
This protects TBContext with tb_lock to make tb_* thread safe.
We can still have issue with tb_flush in case of multithread TCG:
An other CPU can be executing code during a flush.
This can be fixed later by making
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/translate.c | 21 +++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 9a7558a..95d58d1 100644
> --- a/
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/translate.c | 34 +-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index adf4521..b7d15e9 100
Since a simple work-around exists I think the importance can be lowered.
** Summary changed:
- Ubuntu 14.04 LTS, 14.10, 15.04, 15.10 guests do not boot to Unity from
QEMU-KVM Ubuntu 14.04 LTS, 14.10, 15.04 hosts
+ llvmpipe i386 crashes when running on qemu64 cpu
** Description changed:
STEPS
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +gen_logic_cc(s, res, opsize);
> +
> +l1 = gen_new_label();
> +l2 = gen_new_label();
> +
> +gen_jmpcc(s, 6 /* !Z */, l1);
> +gen_store(s, opsize, addr, update);
> +tcg_gen_br(l2);
> +gen_set_label(l1);
> +tcg_gen_mov_i3
Marking as incomplete while waiting for test feedback.
** Changed in: qemu (Ubuntu)
Status: Confirmed => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1465935
Title:
kvm_irqchip_
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/translate.c | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-by: Richard Henderson
r~
** Changed in: qemu (Ubuntu)
Importance: Medium => Low
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/685096
Title:
USB Passthrough not working for Windows 7 guest
Status in QEMU:
Confirmed
St
Could someone confirm whether this is fixed in 15.04 and/or 15.10?
** Changed in: qemu (Ubuntu)
Status: Triaged => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1297218
Title:
gu
This will come in when implemented upstream.
** Changed in: qemu (Ubuntu)
Importance: High => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1163034
Title:
linux-user mode can't handle
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/translate.c | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index ae57792..adf4521 100644
> --- a/target-m68k/transla
I'm going to mark this invalid as I don't believe this is a supported
case. If someone can vouch for the fact that this is supposed to work,
please leave a comment.
** Changed in: qemu (Ubuntu)
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Improve TCG constant use by creating only once for several uses.
>
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/translate.c | 46 +++---
> 1 file changed, 27 insertions(+), 19 deletions(-)
>
> diff --
*** This bug is a duplicate of bug 1317603 ***
https://bugs.launchpad.net/bugs/1317603
** This bug has been marked a duplicate of bug 1317603
qemu-system-ppc does not terminate on VM exit
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> target-m68k/translate.c | 95
> ++---
> 1 file changed, 58 insertions(+), 37 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index
From: KONRAD Frederic
This protects TBContext with tb_lock to make tb_* thread safe.
We can still have issue with tb_flush in case of multithread TCG:
another CPU can be executing code during a flush.
This can be fixed later by making all other TCG thread exiting before calling
tb_flush().
Sig
There is some iffy lock hierarchy going on in translate-all.c. To
fix it, we need to take the mmap_lock in cpu-exec.c. Make the
functions globally available.
Signed-off-by: Paolo Bonzini
---
bsd-user/qemu.h | 2 --
include/exec/exec-all.h | 7 ++-
linux-user/qemu.h | 2 --
tr
softmmu requires more functions to be thread-safe, because translation
blocks can be invalidated from e.g. notdirty callbacks. Probably the
same holds for user-mode emulation, it's just that no one has ever
tried to produce a coherent locking there.
This patch will guide the introduction of more
From: KONRAD Frederic
Protect the list of queued work items with something other than
the BQL, as a preparation for running the work items outside it.
Signed-off-by: KONRAD Frederic
Signed-off-by: Paolo Bonzini
---
cpus.c| 22 ++
include/qom/cpu.h | 6 +-
The header is included from basically everywhere, thanks to cpu.h.
It should be moved to the (TCG only) files that actually need it.
As a start, remove non-TCG stuff.
While adding a #ifndef CONFIG_USER_ONLY include section to cpu-exec.c,
move memory API files under it.
Signed-off-by: Paolo Bonzin
tb_lock has to be taken inside the mmap_lock (example:
tb_invalidate_phys_range is called by target_mmap), but
tb_link_page is taking the mmap_lock and it is called
with the tb_lock held.
To fix this, take the mmap_lock in tb_find_slow, not
in tb_link_page.
Signed-off-by: Paolo Bonzini
---
cpu-
More #ifdefs are not nice, but this clarifies why its usage is not
protected by tb_lock.
Signed-off-by: Paolo Bonzini
---
translate-all.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index a6bff72..7aa5664 100644
--- a/translate
Signed-off-by: Paolo Bonzini
---
translate-all.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index 7aa5664..7727091 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -172,11 +172,13 @@ void cpu_gen_init(v
** Changed in: qemu (Ubuntu)
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1321028
Title:
qemu-system-ppc : file systems are not shutting down clean
Status in QEM
Hi, this is my attempt at 1) extracting upstreamable parts out of Fred's
MTTCG, and 2) documenting what's going on in user-mode MTTCG 3) fix
one bug in the process. I couldn't find any other locking problem
from reading the code.
The final two patches are not really upstreamable because they
add
Signed-off-by: Paolo Bonzini
---
cpu-exec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/cpu-exec.c b/cpu-exec.c
index 599e64d..bde5fd1 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -228,6 +228,7 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu,
uint8_t *tb_ptr)
return
page_find is reading the radix tree outside all locks, so it has to
use the RCU primitives. It does not need RCU critical sections
because the PageDescs are never removed, so there is never a need
to wait for the end of code sections that use a PageDesc.
Signed-off-by: Paolo Bonzini
---
transla
From: KONRAD Frederic
spinlock is only used in two cases:
* cpu-exec.c: to protect TranslationBlock
* mem_helper.c: for lock helper in target-i386 (which seems broken).
It's a pthread_mutex_t in user-mode so better using QemuMutex directly in this
case.
It allows as well to reuse tb_lock mut
From: KONRAD Frederic
This removes tcg_halt_cond global variable.
We need one QemuCond per virtual cpu for multithread TCG.
Signed-off-by: KONRAD Frederic
Message-Id: <1439220437-23957-9-git-send-email-fred.kon...@greensocs.com>
[Keep tcg_halt_cond for bisectability, while making it static. - P
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> -SRC_EA(env, tmp, OS_LONG, 0, &addr);
> +SRC_EA(env, tmp, opsize, -1, &addr);
Oh, I'm also wondering why you changed all of the inputs from unsigned to
signed. It appears to be unrelated to updating the modes, and unnecessary.
I'm a
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> case 6: /* cmpi */
> tcg_gen_mov_i32(dest, src1);
> tcg_gen_subi_i32(dest, dest, im);
> gen_update_cc_add(dest, tcg_const_i32(im));
> -set_cc_op(s, CC_OP_SUB);
> +SET_CC_OP(opsize, SUB);
> break
That field is now only used during initialization of BlockDriverStates
(opening images) and for error or warning messages. Performance is not
that much of an issue here, so we can drop the field and replace its use
by a call to bdrv_filename() or bdrv_filename_alloc(). By doing so we
can ensure the
Instead of returning a pointer to the filename, copy it into a buffer
specified by the caller.
Signed-off-by: Max Reitz
---
block.c | 25 ++---
include/block/block.h | 2 +-
monitor.c | 6 +-
3 files changed, 24 insertions(+), 9 deletions(-)
d
Split the part which actually refreshes the BlockDriverState.filename
field off of bdrv_refresh_filename() into a more generic function
bdrv_filename(), which first calls bdrv_refresh_filename() and then
stores a qemu-usable filename into the given buffer instead of
BlockDriverState.filename.
Sinc
In places which directly pass a filename to the OS, we should not use
the filename field at all but exact_filename instead (although the
former currently equals the latter if that is set).
In qemu-img's map command, we should be using the filename field; but
since this commit prepares to remove th
After drive-mirror replacing a Quorum child, the filename of the Quorum
BDS should reflect the change. This patch replaces the existing test for
whether the operation did actually exchange the BDS (which simply tested
whether the new BDS existed) by a test which examines the children list
contained
This series depends on
"[PATCH] block/raw-posix: Use raw_normalize_devicepath()".
The BDS filename field is generally only used when opening disk images
or emitting error or warning messages, the only exception to this rule
is the map command of qemu-img. However, using exact_filename there
inste
On 12/08/2015 17:19, Frederic Konrad wrote:
> BTW that affect KVM as well. Seems this mechanism is used as well with
> qemu_cpu_kick_self().. Which is a little strange as it seems the SIGIPI
> trigger a
> dummy signal handler?
>
> memset(&sigact, 0, sizeof(sigact));
> sigact.sa_handler =
The filename given to qemu_open() in block/raw-posix.c should generally
have been processed by raw_normalize_devicepath(); unless we are only
probing (in which case the caller often checks whether the file is a
block device or not, and this property will be changed by
raw_normalize_devicepath() on
On 08/12/2015 04:24 PM, Christoffer Dall wrote:
> On Wed, Aug 12, 2015 at 4:14 PM, Eric Auger wrote:
>> Hi,
>> On 08/12/2015 03:23 PM, Christoffer Dall wrote:
>>> On Wed, Aug 12, 2015 at 2:59 PM, Peter Maydell
>>> wrote:
On 12 August 2015 at 13:27, Pavel Fedin wrote:
> Hello!
>
>>
On 11/08/2015 15:59, Frederic Konrad wrote:
On 11/08/2015 14:45, Paolo Bonzini wrote:
On 10/08/2015 17:26, fred.kon...@greensocs.com wrote:
From: KONRAD Frederic
This is the 7th round of the MTTCG patch series.
Thanks to look at this.
Here is a list of issues that I found:
- tb_lock usage
On 08/12/2015 01:07 AM, Andreas Schwab wrote:
> Richard Henderson writes:
>
>> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>>> +opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD;
>>> +incr = opsize_bytes(opsize);
>>> +if (!is_load && (insn & 070) == 040) {
>>> +for (i = 15; i
On 08/12/2015 12:59 AM, gchen gchen wrote:
>> Nack. There's 99 problems with host page size> guest page size. This
>> solves none of them, and in the hackiest way possible.
>>
>
> Under alpha virtual machine, if set i386 guest page size 8KB, it will
> cause failure directly (any dynamically link
If host and target endianness does not match, loding an initramfs does not work.
Fix by writing boot parameters with appropriate endianness conversion.
Signed-off-by: Guenter Roeck
---
hw/sh4/r2d.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2
Hi,
On 08/12/2015 03:23 PM, Christoffer Dall wrote:
> On Wed, Aug 12, 2015 at 2:59 PM, Peter Maydell
> wrote:
>> On 12 August 2015 at 13:27, Pavel Fedin wrote:
>>> Hello!
>>>
I still think this is the wrong approach -- see my remarks
in the previous round of patch review.
>>>
>>> You
On 12/08/2015 16:11, Frederic Konrad wrote:
>> You could also allocate a new code buffer and free the old one with
>> call_rcu. This should simplify things a lot.
>
> Depending the size of the code buffer this might be a good idea. :).
32 megabytes.
Paolo
On Wed, Aug 12, 2015 at 4:10 PM, Paolo Bonzini wrote:
>
>
> On 12/08/2015 16:04, alvise rigo wrote:
>>> > clear algorithm:
>>> >if bytemap[vaddr] == 254
>>> > bytemap[vaddr] = CPU_ID
>> Isn't this also required for the clear algorithm?
>>
>> if bytemap[vaddr] < 254
>> /* this
On Wed, Aug 12, 2015 at 08:53:44AM +, Wu, Feng wrote:
>
>
> > -Original Message-
> > From: Jan Beulich [mailto:jbeul...@suse.com]
> > Sent: Wednesday, August 12, 2015 4:43 PM
> > To: Wu, Feng
> > Cc: stefano.stabell...@eu.citrix.com; xen-de...@lists.xensource.com;
> > qemu-devel@nongn
On 8/12/15 04:20, Michael S. Tsirkin wrote:
Now that smbios has its own directory, list its
maintainers. Same people as ACPI so just reuse that
entry.
Signed-off-by: Michael S. Tsirkin
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAIN
On Aug 12, 2015 6:32 AM, "Paolo Bonzini" wrote:
>
>
>
> On 09/08/2015 09:02, Michael Marineau wrote:
> > Using ccache with CCACHE_BASEDIR set to $(SRC_PATH) or a parent will
> > rewrite all absolute paths to relative paths. This interacts poorly with
> > QEMU's two-level build directory scheme. Fo
On Fri, Aug 07, 2015 at 05:02:14PM +0100, Peter Maydell wrote:
> From: Juan Quintela
>
> Update the CRIS CPU state save/load to use a VMStateDescription struct
> rather than cpu_save/cpu_load functions.
>
> Have to define TLBSet struct.
> Multidimensional arrays in C are a mess, just unroll them
On Wed, Aug 12, 2015 at 4:14 PM, Eric Auger wrote:
> Hi,
> On 08/12/2015 03:23 PM, Christoffer Dall wrote:
>> On Wed, Aug 12, 2015 at 2:59 PM, Peter Maydell
>> wrote:
>>> On 12 August 2015 at 13:27, Pavel Fedin wrote:
Hello!
> I still think this is the wrong approach -- see my re
The Linux kernel only accepts 34 Khz and 67 Khz clock rates, and
may crash if the actual clock rate is too low. The clock rate used to be
(ps-clk-frequency * 26 / 4), which resulted in a CPU frequency of
21 Khz if ps-clk-frequency was set to Hz. Change it to
(ps-clk-frequency *
1 - 100 of 188 matches
Mail list logo
