On Wed, Aug 12, 2015 at 08:53:44AM +0000, Wu, Feng wrote: > > > > -----Original Message----- > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: Wednesday, August 12, 2015 4:43 PM > > To: Wu, Feng > > Cc: stefano.stabell...@eu.citrix.com; xen-de...@lists.xensource.com; > > qemu-devel@nongnu.org > > Subject: RE: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle > > 64-bit > > bar with more than 4G size > > > > >>> On 12.08.15 at 09:10, <feng...@intel.com> wrote: > > > > > > > >> -----Original Message----- > > >> From: qemu-devel-bounces+feng.wu=intel....@nongnu.org > > >> [mailto:qemu-devel-bounces+feng.wu=intel....@nongnu.org] On Behalf Of > > >> Jan Beulich > > >> Sent: Wednesday, August 12, 2015 2:59 PM > > >> To: Wu, Feng > > >> Cc: xen-de...@lists.xensource.com; qemu-devel@nongnu.org; > > >> stefano.stabell...@eu.citrix.com > > >> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle > > 64-bit > > >> bar with more than 4G size > > >> > > >> >>> On 05.08.15 at 04:02, <feng...@intel.com> wrote: > > >> > @@ -491,8 +474,9 @@ static int > > >> xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry, > > >> > bar_ro_mask = XEN_PT_BAR_IO_RO_MASK | (r_size - 1); > > >> > break; > > >> > case XEN_PT_BAR_FLAG_UPPER: > > >> > + r = &d->io_regions[index-1]; > > >> > > >> Perhaps worth an assert(index > 0)? > > > > > > No problem, I will add it. BTW, do you have any other comments about this > > > patch? If no, I am > > > going to send out the new version with this changes. > > > > No - everything else looks to make sense (but continues to need > > testing). > > > > I don't have such a device in hand. Can anybody who has such a device help to > test this > patch? It would be highly appreciated!
Um, 4GB MMIO bars? Wouldn't the Nvidia Quadro K6000 12GB GDDR do it? I am sure that Intel would be OK expensing $4K of hardware :-) > > Thanks, > Feng > > > Jan > > > _______________________________________________ > Xen-devel mailing list > xen-de...@lists.xen.org > http://lists.xen.org/xen-devel
