Re: [Qemu-devel] [RFC] Virt machine memory map

2015-07-21 Thread Pavel Fedin
Hello! > > I think the theory we discussed at the time of putting in the PCIe > > device was that if we wanted this we'd add support for the other > > PCIe memory window (which would then live at somewhere above 4GB). > > Alex, can you remember what the idea was? > > Yes, pretty much. It would g

Re: [Qemu-devel] [PATCH v2 0/5] For QEMU 2.5: Network traffic dumping for -netdev devices

2015-07-21 Thread Jason Wang
On 07/13/2015 03:39 PM, Thomas Huth wrote: > The "-net dump" option only works with the "-net" option. So far, it > is not possible to dump network traffic with the "-netdev" option yet. > This patch series now fixes this ugliness by enabling dumping for the > "-netdev" option, too. > > Unlike wi

Re: [Qemu-devel] [PATCH v7 26/42] postcopy: Incoming initialisation

2015-07-21 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:39], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v2] cpu-exec: Do not invalidate original TB in cpu_exec_nocache()

2015-07-21 Thread Sergey Fedorov
ping. On 30.06.2015 12:35, Sergey Fedorov wrote: > Instead of invalidating an original TB in cpu_exec_nocache() > prematurely, just save a link to it in the temporary generated TB. If > cpu_io_recompile() is raised subsequently from the temporary TB, > invalidate the original one as well. That all

[Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-21 Thread Jason Wang
SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 9 - 1 file changed, 8 insertions(+),

[Qemu-devel] [PATCH V3 3/3] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported

2015-07-21 Thread Jason Wang
Chapter 6.3 of spec said " Transitional devices MUST offer, and if offered by the device transitional drivers MUST accept the following: VIRTIO_F_ANY_LAYOUT (27) " So this patch sets VIRTIO_F_ANY_LAYOUT when 1.0 is supported. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed

[Qemu-devel] [PATCH V3 1/3] virtio: get_features() can fail

2015-07-21 Thread Jason Wang
Signed-off-by: Jason Wang --- hw/9pfs/virtio-9p-device.c | 3 ++- hw/block/virtio-blk.c | 3 ++- hw/char/virtio-serial-bus.c | 3 ++- hw/display/virtio-gpu.c | 3 ++- hw/input/virtio-input.c | 3 ++- hw/net/virtio-net.c | 3 ++- hw/scsi/vhost-scsi.c| 3 ++- hw/scsi/

[Qemu-devel] [PATCH V3 0/3] Set correct blk feature for virtio 1.0

2015-07-21 Thread Jason Wang
Hi all: This series tries to set feature correctly for virtio-blk when virtio 1.0 is supported. Two isssues were addressed according to the spec: - scsi passthrough was not support in 1.0. This is done through: 1) let get_features() can fail 2) fail the get_features() when both scsi and virti

Re: [Qemu-devel] Does PCI hotplug work with IVSHMEM?

2015-07-21 Thread Ivano Cerrato
Thank you for the answer! Why do you say that it is not safe to do hotplug with ivshmem? Ivano Il 21/07/2015 18:37, Marc-André Lureau ha scritto: Hi On Tue, Jul 21, 2015 at 12:13 PM, Ivano Cerrato wrote: Is there any way to force the Guest OS to recognize the new device without rebooting

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-21 Thread Kevin O'Connor
On Tue, Jul 21, 2015 at 06:03:41PM +0200, Marc Marí wrote: > From: Gerd Hoffmann > > First draft of a fw_cfg dma interface. Designed as add-on to the > extisting fw_cfg interface, i.e. there is no select register. There > are four 32bit registers: Target address (low and high bits), transfer >

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Kevin O'Connor
On Tue, Jul 21, 2015 at 10:36:39PM +0200, Laszlo Ersek wrote: > On 07/21/15 22:16, Kevin O'Connor wrote: > > Without this ability we'd need to read the entire > > entry into a big linear area of memory and then memmove that around. > > If there is a way to accomplish this without an "offset" field

Re: [Qemu-devel] [PATCH v2 0/5] Add feature to start QEMU without vhost-user backend

2015-07-21 Thread Tetsuya Mukawa
On 2015/07/19 21:48, Michael S. Tsirkin wrote: > On Wed, Jun 24, 2015 at 07:57:45AM +0200, Michael S. Tsirkin wrote: >> On Wed, Jun 24, 2015 at 02:46:30PM +0900, Tetsuya Mukawa wrote: >>> On 2015/06/23 18:41, Michael S. Tsirkin wrote: On Tue, Jun 23, 2015 at 05:31:06PM +0900, Tetsuya Mukawa wr

Re: [Qemu-devel] [PATCH v4 0/6] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-21 Thread Fam Zheng
On Tue, 07/21 16:07, Paolo Bonzini wrote: > This puts together all pending fixes in a single series. > > Paolo > > v1->v2 > Split some changes to the tests to a separate patch > Fix commit message [Laszlo] > Clarify do...while loop in aio-win32.c [Kevin] > > v2->v3 >

Re: [Qemu-devel] [PATCH v2 5/6] qmp: Add blockdev-mirror command

2015-07-21 Thread Fam Zheng
On Mon, 07/20 17:33, Max Reitz wrote: > On 25.06.2015 05:22, Fam Zheng wrote: > >This will start a mirror job from a named device to another named > >device, its relation with drive-mirror is similar with blockdev-backup > >to drive-backup. > > > >In blockdev-mirror, the target node should be prepa

Re: [Qemu-devel] [PATCH v1 2/2] MAINTAINERS: Add ZynqMP to MAINTAINERS file

2015-07-21 Thread Alistair Francis
On Fri, Jul 17, 2015 at 5:38 PM, Peter Crosthwaite wrote: > On Thu, Jul 16, 2015 at 1:35 PM, Alistair Francis > wrote: >> Add the Xilinx ZynqMP SoC and EP108 machine to the maintainers >> file. >> >> Signed-off-by: Alistair Francis > > Reviewed-by: Peter Crosthwaite Thanks Peter. Alistair >

Re: [Qemu-devel] [PATCH v1 1/2] MAINTAINERS: Update Xilinx Maintainership

2015-07-21 Thread Alistair Francis
On Fri, Jul 17, 2015 at 5:37 PM, Peter Crosthwaite wrote: > On Thu, Jul 16, 2015 at 1:35 PM, Alistair Francis > wrote: >> Peter C is leaving Xilinx, so update the maintainer list >> to point to Alistair and Edgar from Xilinx and Peter's >> personal email address. >> >> Signed-off-by: Alistair Fra

[Qemu-devel] [PATCH for-2.4] spapr_drc: fix clang -fsanitizer=shift warning

2015-07-21 Thread Michael Roth
Current code for generating DRC type mask generates the following warning with clang -fsanitizer=undefined -fsanitizer=shift: runtime error: left shift of negative value -1 Fix this by calculating the mask like a sane person would. Signed-off-by: Michael Roth --- hw/ppc/spapr_drc.c | 2 +- 1

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-07-21 Thread Michael Roth
Quoting Peter Maydell (2015-07-21 06:42:41) > On 5 June 2015 at 16:20, Paolo Bonzini wrote: > > On 05/06/2015 17:08, Peter Maydell wrote: > >>> > Can someone add a checkpatch rule that forbids shifting left U or UL > >>> > constants (i.e. only ULL)? That would alleviate my concerns with these > >

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Laszlo Ersek
Oops, I got carried away a little bit, and forgot about a crucial detail: On 07/22/15 00:58, Laszlo Ersek wrote: [snip] > (1) [PATCH] efi_snp: improve compliance with the > EFI_SIMPLE_NETWORK_PROTOCOL spec > http://thread.gmane.org/gmane.network.ipxe.devel/3799 > Date: 2015-J

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:18, Peter Maydell wrote: > On 21 July 2015 at 17:10, Stefan Hajnoczi wrote: >> With regards to git.qemu.org mirroring: >> I could update the ipxe.git mirror URL on git.qemu.org to Gerd's >> public repo and change the description to indicate that this includes >> out-of-tree patches.

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:10, Stefan Hajnoczi wrote: > On Tue, Jul 21, 2015 at 3:28 PM, Paolo Bonzini wrote: >> On 21/07/2015 16:25, Peter Maydell wrote: > > Well, it did say "This pull finally fixes the efi boot support. ipxe is > updated to the latest master, two non-upstream commits needed to

Re: [Qemu-devel] [PATCH RFC v2 25/47] qapi: Make generators work on sorted schema expressions

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Order of expressions doesn't matter. QAPISchema().get_exprs() returns > expressions in the order they're parsed. > > I'm going to refactor this code. To check refactorings, I want to > diff the generated code, and for that I need to preserve its

Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-21 Thread Eric Blake
On 07/07/2015 07:45 AM, Kevin Wolf wrote: >>> Kevin has pointed out at the QAPI portion of this patch isn't ready >>> for prime time yet, so I will revert the patch and resend the pull >>> request. >> >> Yes please, I was not aware that adding the QAPI part >> has such an impact. I would appreciat

Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-21 Thread Eric Blake
On 07/07/2015 06:08 AM, Stefan Hajnoczi wrote: > From: Peter Lieven > > upcoming libnfs versions will support logging debug messages. Add > support for it in qemu through a per-drive option. > > Examples: > qemu -drive if=virtio,file=nfs://...,file.debug=2 > qemu-img create -o debug=2 nfs://..

Re: [Qemu-devel] [PATCH RFC v2 24/47] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > The old code prints the result of parsing (list of expression > dictionaries), and partial results of semantic analysis (list of enum > dictionaries, list of struct dictionaries). > > The new code prints a trace of a schema visit, i.e. what the ba

[Qemu-devel] [PATCH] vfio/pci: Fix bootindex

2015-07-21 Thread Alex Williamson
bootindex was incorrectly changed to a device Property during the platform code split, resulting in it no longer working. Remove it. Signed-off-by: Alex Williamson Cc: qemu-sta...@nongnu.org # v2.3+ --- hw/vfio/pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/

Re: [Qemu-devel] [PATCH RFC v2 23/47] qapi: New QAPISchemaVisitor

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > The visitor will help keeping the code generation code simple and > reasonably separated from QAPISchema details. Still no change to generated code until later patches start using this. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi

Re: [Qemu-devel] [PATCH v3] tcg/ppc: Improve unaligned load/store handling on 64-bit backend

2015-07-21 Thread Benjamin Herrenschmidt
On Tue, 2015-07-21 at 16:18 +0200, Alexander Graf wrote: > I can happily take on this after my paternity leave, but considering > that I'm out for 3 months in 1 month from now and have a pretty huge > pile of stuff that needs to get done until then I'd rather keep > things > low right now ;) >

Re: [Qemu-devel] [PATCH v3] tcg/ppc: Improve unaligned load/store handling on 64-bit backend

2015-07-21 Thread Benjamin Herrenschmidt
On Tue, 2015-07-21 at 15:48 +0200, Paolo Bonzini wrote: > > On 21/07/2015 14:26, Benjamin Herrenschmidt wrote: > >> > So who can pick those up? PPC TCG is pretty much unmaintained since Malc > >> > disappeared, no? > > Did you just raise your hand ? :-) > > > > Worst case I'm happy to just keep

Re: [Qemu-devel] [PATCH RFC v2 22/47] qapi: QAPISchema code generation helper methods

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > New methods c_name(), c_type(), c_null(), json_type(), > alternate_qtype(). > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 72 > +++-- > 1 file changed, 65 insertions(+), 7 del

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Laszlo Ersek
On 07/21/15 22:16, Kevin O'Connor wrote: > On Tue, Jul 21, 2015 at 10:06:51PM +0200, Laszlo Ersek wrote: >> On 07/21/15 18:26, Stefan Hajnoczi wrote: >>> On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: Signed-off-by: Marc Marí --- hw/nvram/fw_cfg.c | 19 ---

Re: [Qemu-devel] [PATCH RFC v2 21/47] qapi: New QAPISchema intermediate reperesentation

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > The QAPI code generators work with a syntax tree (nested dictionaries) > plus a few symbol tables (also dictionaties) on the side. s/dictionaties/dictionaries/ > > They have clearly outgrown these simple data structures. There's lots > of rumma

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Kevin O'Connor
On Tue, Jul 21, 2015 at 10:06:51PM +0200, Laszlo Ersek wrote: > On 07/21/15 18:26, Stefan Hajnoczi wrote: > > On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > >> Signed-off-by: Marc Marí > >> --- > >> hw/nvram/fw_cfg.c | 19 --- > >> 1 file changed, 16 insertions(+), 3 deletio

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:26, Stefan Hajnoczi wrote: > On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: >> Signed-off-by: Marc Marí >> --- >> hw/nvram/fw_cfg.c | 19 --- >> 1 file changed, 16 insertions(+), 3 deletions(-) > > No commit description, no docs/specs/fw_cfg.txt documentation.

Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:18, Stefan Hajnoczi wrote: > On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: >> From: Gerd Hoffmann >> >> This is what it takes to have a sorted fw_cfg file directory. >> Entries are inserted at the correct place instead of being >> appended to the end in case sorting is enabled.

[Qemu-devel] [PULL for-2.4 0/1] qemu-ga: small documentation versioning fix-up

2015-07-21 Thread Michael Roth
The following changes since commit 774ee4772b6838b78741ea52d4bf26b8922244c5: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150721' into staging (2015-07-21 12:21:08 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga

[Qemu-devel] [PATCH] qga: fixed versions for guest bus types in qapi-schema

2015-07-21 Thread Michael Roth
From: Olga Krishtal Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth Reviewed-by: Eric Blake *added semi-colon to better delineate 2.2 vs. 2.4 versioning Signed-off-by: Michael Roth --- qga/qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [RFC 4/7] enable fw_cfg dma for arm virt

2015-07-21 Thread Laszlo Ersek
On 07/21/15 19:04, Peter Maydell wrote: > On 21 July 2015 at 17:03, Marc Marí wrote: >> From: Gerd Hoffmann >> >> Signed-off-by: Gerd Hoffmann >> --- >> docs/specs/fw_cfg.txt | 6 ++ >> hw/arm/virt.c | 11 --- >> 2 files changed, 14 insertions(+), 3 deletions(-) >> >> diff

Re: [Qemu-devel] [PATCH 1/1] qga: fixed versions for guest bus types in qapi-schema

2015-07-21 Thread Michael Roth
Quoting Denis V. Lunev (2015-07-21 07:25:08) > From: Olga Krishtal > > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Michael Roth Thanks, applied with Eric's suggested fix-up squashed in: https://github.com/mdroth/qemu/commits/qga > --- > qga/qapi-s

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:03, Marc Marí wrote: > From: Gerd Hoffmann > > First draft of a fw_cfg dma interface. Designed as add-on to the > extisting fw_cfg interface, i.e. there is no select register. There > are four 32bit registers: Target address (low and high bits), transfer > length, control regist

Re: [Qemu-devel] [RFC 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:03, Marc Marí wrote: > From: "Gabriel L. Somlo" > > Document the behavior of fw_cfg_modify_iXX() for leak-less updating > of integer-type blobs. > > Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions > may be added later if necessary.. > > Signed-off-by: Gab

[Qemu-devel] [PATCH] ahci: fix ICC mask definition

2015-07-21 Thread John Snow
There are likely others that could be updated, but we'll go with a light touch for 2.4 for now. Without the Unsigned specifier, this shifts bits into the signed bit, which makes clang unhappy and could cause unwanted behavior. Reported-by: Peter Maydell Signed-off-by: John Snow --- hw/ide/ahci

Re: [Qemu-devel] [PATCH RFC v2 20/47] qapi: Rename class QAPISchema to QAPISchemaParser

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > I want to name a new class QAPISchema. > > While there, make it a new-style class. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric

Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Clean up white-space, brace placement, and superfluous Incomplete sentence. I bet it's because your editor line-wrapped, and the rest of your sentence was something like '#ifndef in a .c file.' (see [1] below), then git ate the line thinking it wa

Re: [Qemu-devel] [PULL 2/3] ahci: Force ICC bits in PxCMD to zero

2015-07-21 Thread John Snow
On 07/21/2015 09:02 AM, Peter Maydell wrote: > On 21 July 2015 at 13:55, Eric Blake wrote: >> On 07/21/2015 05:38 AM, Peter Maydell wrote: >>> On 20 July 2015 at 19:29, John Snow wrote: From: Stefan Fritsch The AHCI spec requires that the HBA sets the ICC bits to zero after the

Re: [Qemu-devel] [PATCH RFC v2 18/47] qapi-commands: Don't feed output of mcgen() to mcgen() again

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Multiple passes through mcgen() is prone to produce unwanted blank > lines, which we then combat by sprinkling .rstrip() on top. Just > don't do it. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 52 > +

[Qemu-devel] [PATCH V4 8/8] arm: xlnx-zynqmp: Add DisplayPort and DPDMA.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite --- hw/arm/xlnx-zynqmp.c | 20 include/hw/arm/xlnx-zynqmp.h | 5 + 2 files changed, 25 insertions(+) diff --git a/hw/arm/xlnx-z

[Qemu-devel] [PATCH V4 6/8] Introduce xilinx dpdma.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic --- hw/dma/Makefile.objs | 1 + hw/dma/xlnx_dpdma.c | 790 +++ hw/dma/xlnx_dpdma.h | 85 ++ 3 files changed, 876 insertions(+) create mode 100

[Qemu-devel] [PATCH V4 7/8] Introduce xilinx dp.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid . Graphic plane is connected to the channel 3. Video plane is connected to the channel 0. Audio stream are connected to the channels 4 and 5. Signed-off-by: KONRAD Frederic --- hw/d

[Qemu-devel] [PATCH V4 5/8] hw/i2c-ddc.c: Implement DDC I2C slave

2015-07-21 Thread fred . konrad
From: Peter Maydell Implement an I2C slave which implements DDC and returns the EDID data for an attached monitor. Signed-off-by: Peter Maydell - Rebased on the current master. - Modified for QOM. Signed-off-by: KONRAD Frederic --- default-configs/aarch64-softmmu.mak | 1 + hw/i2c/Mak

[Qemu-devel] [PATCH V4 2/8] Introduce AUX bus.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This introduces a new bus: aux-bus. It contains an address space for aux slaves devices and a bridge to an I2C bus for I2C through AUX transactions. Signed-off-by: KONRAD Frederic --- default-configs/aarch64-softmmu.mak | 1 + hw/misc/Makefile.objs | 1

[Qemu-devel] [PATCH V4 0/8] Xilinx DisplayPort.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This is the fourth version of this patch-set of the implementation of the Xilinx DisplayPort and DPDMA. This fourth version fix some functional bad behaviours. First patch introduces an AUX bus needed by the DP to read the DPCD. It's also possible to connect an I2C device

[Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic Seems this field is not needed. Signed-off-by: KONRAD Frederic --- hw/i2c/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c index 5a64026..e0f92de 100644 --- a/hw/i2c/core.c +++ b/hw/i2c/core.c @@ -13,7 +13,6 @@ struct I2CBus {

[Qemu-devel] [PATCH V4 4/8] introduce dpcd module.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This introduces a DPCD module. It wires on a aux-bus and can be accessed by driver to get lane-speed, etc. Signed-off-by: KONRAD Frederic --- default-configs/aarch64-softmmu.mak | 1 + hw/display/Makefile.objs| 1 + hw/display/dpcd.c | 17

[Qemu-devel] [PATCH V4 3/8] i2c: implement broadcast write.

2015-07-21 Thread fred . konrad
From: KONRAD Frederic This does a write to every slaves when the I2C bus get a write to address 0. Signed-off-by: KONRAD Frederic --- hw/i2c/core.c | 130 ++ 1 file changed, 76 insertions(+), 54 deletions(-) diff --git a/hw/i2c/core.c b/

Re: [Qemu-devel] [RFC 7/7] fw_cfg DMA for x86

2015-07-21 Thread Peter Maydell
On 21 July 2015 at 17:03, Marc Marí wrote: > Enable fw_cfg for x86 machines. Create new machine to avoid > incompatibilites. > @@ -1391,7 +1399,14 @@ FWCfgState *pc_memory_init(MachineState *machine, > option_rom_mr, >

Re: [Qemu-devel] [RFC 4/7] enable fw_cfg dma for arm virt

2015-07-21 Thread Peter Maydell
On 21 July 2015 at 17:03, Marc Marí wrote: > From: Gerd Hoffmann > > Signed-off-by: Gerd Hoffmann > --- > docs/specs/fw_cfg.txt | 6 ++ > hw/arm/virt.c | 11 --- > 2 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.t

[Qemu-devel] [RFC 5/7] fw_cfg file sort

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann This is what it takes to have a sorted fw_cfg file directory. Entries are inserted at the correct place instead of being appended to the end in case sorting is enabled. Compatibility fluff (enable sorting for new machine types only) isn't there yet. Signed-off-by: Gerd Hoffm

[Qemu-devel] [RFC 7/7] fw_cfg DMA for x86

2015-07-21 Thread Marc Marí
Enable fw_cfg for x86 machines. Create new machine to avoid incompatibilites. Signed-off-by: Marc Marí --- hw/i386/pc.c | 21 ++--- hw/i386/pc_piix.c| 25 +++-- hw/i386/pc_q35.c | 26 -- include/hw/i386/pc.h | 1 + 4 fi

[Qemu-devel] [RFC 3/7] fw_cfg dma: adapt to vmstate changes

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann --- hw/nvram/fw_cfg.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 5bcd0e0..0f35931 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -515,8 +515,16 @@ static bool is_versio

[Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Marc Marí
Signed-off-by: Marc Marí --- hw/nvram/fw_cfg.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 83205e0..9a39d45 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -47,8 +47,9 @@ #define FW_CFG_DMA_ADDR_LO

[Qemu-devel] [RFC 0/7] fw_cfg dma interface

2015-07-21 Thread Marc Marí
Work done by Gerd Hoffmann for ARM. Extended to be used in x86 platforms These patches, with the support in SeaBIOS (patches in the SeaBIOS mailing list) make the Linux kernel setup and boot approximately 10x faster. TODO: * Optimizations. For example, use memcpy instead of a loop if the tran

[Qemu-devel] [RFC 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-07-21 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo Signed-off-by: Gerd Hoffmann --- docs/sp

[Qemu-devel] [RFC 4/7] enable fw_cfg dma for arm virt

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- docs/specs/fw_cfg.txt | 6 ++ hw/arm/virt.c | 11 --- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt index 64d9192..eac83a1 100644 --- a/docs/specs/fw_cfg.txt

[Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there is no select register. There are four 32bit registers: Target address (low and high bits), transfer length, control register. See docs/specs/fw_cfg.txt update for detail

Re: [Qemu-devel] Does PCI hotplug work with IVSHMEM?

2015-07-21 Thread Marc-André Lureau
Hi On Tue, Jul 21, 2015 at 6:37 PM, Marc-André Lureau wrote: > > Check dmesg, it fails to allocate for me, but with 1G it works (f22 > x86_64). I don't know what's the reason behind it. I should have said "it failed to assign": [ 69.781673] pci :00:05.0: BAR 2: no space for [mem size 0x80

Re: [Qemu-devel] [PATCH RFC v2 17/47] qapi-commands: Inline gen_marshal_output_call()

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization libr

Re: [Qemu-devel] Does PCI hotplug work with IVSHMEM?

2015-07-21 Thread Marc-André Lureau
Hi On Tue, Jul 21, 2015 at 12:13 PM, Ivano Cerrato wrote: > Is there any way to force the Guest OS to recognize the new device without > rebooting? Such as rmmod/insmod or equivalent? This can be observed in qemu monitor too, info qtree: dev: ivshmem, id "" chardev = "" si

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > @@ -338,6 +340,10 @@ static void fw_cfg_dma_transfer(FWCfgState *s) > return; > } > > +for (i = 0; i < s->dma_off; ++i) { > +fw_cfg_read(s); > +} > + > for (i = 0; i < len; i++) { >

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > Signed-off-by: Marc Marí > --- > hw/nvram/fw_cfg.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) No commit description, no docs/specs/fw_cfg.txt documentation. I understand how the offset is supposed to work, bu

Re: [Qemu-devel] [PATCH RFC v2 16/47] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err'

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > gen_err_check() hard-codes 'local_err' instead of substituting the > argument. Currently harmless, since all callers pass either None or > 'local_err'. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 13 +++-- >

Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-21 Thread Eric Blake
On 06/22/2015 01:26 PM, Markus Armbruster wrote: > This is particularly useful when we abort in error_propagate(), > because there the stack backtrace doesn't lead to where the error was > created. Looks like this: > > Unexpected error at /work/armbru/qemu/blockdev.c:322: > qemu-system-x8

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Peter Maydell
On 21 July 2015 at 17:10, Stefan Hajnoczi wrote: > With regards to git.qemu.org mirroring: > I could update the ipxe.git mirror URL on git.qemu.org to Gerd's > public repo and change the description to indicate that this includes > out-of-tree patches. Please let me know if you'd like to go ahead

Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > From: Gerd Hoffmann > > This is what it takes to have a sorted fw_cfg file directory. > Entries are inserted at the correct place instead of being > appended to the end in case sorting is enabled. > > Compatibility fluff (enable sorting for new

Re: [Qemu-devel] [PATCH V3 7/8] Introduce xilinx dp.

2015-07-21 Thread Frederic Konrad
On 11/07/2015 02:29, Hyun Kwon wrote: Hi Fred, Thanks for the patch. -Original Message- From: fred.kon...@greensocs.com [mailto:fred.kon...@greensocs.com] Sent: Monday, July 06, 2015 9:22 AM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org; Peter Crosthwaite; Hyun Kwon; guillaume

Re: [Qemu-devel] [RFC 3/7] fw_cfg dma: adapt to vmstate changes

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > From: Gerd Hoffmann This patch should be squashed into the patch that adds fw_cfg_dma_enabled().

[Qemu-devel] [PATCH v2 2/2] block: qemu-iotests - add check for multiplication overflow in vpc

2015-07-21 Thread Jeff Cody
This checks that VPC is able to successfully fail (without segfault) on an image file with a max_table_entries that exceeds 0x4000. This table entry is within the valid range for VPC (although too large for this sample image). Signed-off-by: Jeff Cody --- tests/qemu-iotests/135

[Qemu-devel] [PATCH v2 0/2] block: vpc - prevent overflow

2015-07-21 Thread Jeff Cody
Changes: v2 now also checks that Max Table Entries is < SIZE_MAX / 4 (Thanks Stefan) This series fixes a bug found by Richard Jones. When we allocate the pagetable based on max_table_entries, we multiply the max table entry value by 4 to accomodate a table of 32-bit integers. However, max_table_

[Qemu-devel] [PATCH v2 1/2] block: vpc - prevent overflow if max_table_entries >= 0x40000000

2015-07-21 Thread Jeff Cody
When we allocate the pagetable based on max_table_entries, we multiply the max table entry value by 4 to accomodate a table of 32-bit integers. However, max_table_entries is a uint32_t, and the VPC driver accepts ranges for that entry over 0x4000. So during this allocation: s->pagetable = qem

Re: [Qemu-devel] [PATCH 6/7] error: Revamp interface documentation

2015-07-21 Thread Eric Blake
On 06/22/2015 01:26 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/qapi/error.h | 176 > --- > 1 file changed, 126 insertions(+), 50 deletions(-) > > diff --git a/include/qapi/error.h b/include/qapi/error.h > index

[Qemu-devel] ANNOUNCE: libguestfs 1.30 released

2015-07-21 Thread Richard W.M. Jones
I'm pleased to announce libguestfs 1.30, a library and set of tools for accessing and modifying virtual machine disk images. This release took 9 months of work by a considerable number of people, and has many new features (see release notes below). You can get libguestfs 1.30 here: Main website:

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 3:28 PM, Paolo Bonzini wrote: > On 21/07/2015 16:25, Peter Maydell wrote: >>> > >>> > Well, it did say "This pull finally fixes the efi boot support. ipxe is >>> > updated to the latest master, two non-upstream commits needed to make >>> > efi work are added on top, and th

Re: [Qemu-devel] [PATCH 5/7] error: error_set_errno() is unused, drop

2015-07-21 Thread Eric Blake
On 06/22/2015 01:26 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/qapi/error.h | 7 ++- > util/error.c | 5 ++--- > 2 files changed, 4 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvi

Re: [Qemu-devel] [PATCH V3 4/8] introduce dpcd module.

2015-07-21 Thread Frederic Konrad
On 11/07/2015 02:29, Hyun Kwon wrote: Hi Fred, Thanks for the patch. -Original Message- From: fred.kon...@greensocs.com [mailto:fred.kon...@greensocs.com] Sent: Monday, July 06, 2015 9:22 AM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org; Peter Crosthwaite; Hyun Kwon; guillaume

Re: [Qemu-devel] [PATCH V3 6/8] Introduce xilinx dpdma.

2015-07-21 Thread Frederic Konrad
On 11/07/2015 02:29, Hyun Kwon wrote: Hi Fred, Thanks for the patch. -Original Message- From: fred.kon...@greensocs.com [mailto:fred.kon...@greensocs.com] Sent: Monday, July 06, 2015 9:22 AM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org; Peter Crosthwaite; Hyun Kwon; guillaume

Re: [Qemu-devel] [PATCH 4/7] qga/vss-win32: Document the DLL requires non-null errp

2015-07-21 Thread Eric Blake
On 06/22/2015 01:26 PM, Markus Armbruster wrote: > requester.cpp uses this pattern to receive an error and pass it on to > the caller (err_is_set() macro peeled off for clarity): > > ... code that may set errset->errp ... > if (errset->errp && *errset->errp) { > ... handle error ..

Re: [Qemu-devel] [PATCH v3] tcg/ppc: Improve unaligned load/store handling on 64-bit backend

2015-07-21 Thread Aurelien Jarno
On 2015-07-21 14:04, Alexander Graf wrote: > On 07/21/15 11:46, Benjamin Herrenschmidt wrote: > >On Tue, 2015-07-21 at 07:39 +0100, Richard Henderson wrote: > >>On 07/21/2015 07:33 AM, Benjamin Herrenschmidt wrote: > >>>On Tue, 2015-07-21 at 07:27 +0100, Richard Henderson wrote: > On 07/21/2015

Re: [Qemu-devel] [PATCH v3] tcg/ppc: Improve unaligned load/store handling on 64-bit backend

2015-07-21 Thread Aurelien Jarno
On 2015-07-21 15:19, Benjamin Herrenschmidt wrote: > Currently, we get to the slow path for any unaligned access in the > backend, because we effectively preserve the bottom address bits > below the alignment requirement when comparing with the TLB entry, > so any non-0 bit there will cause the com

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Paolo Bonzini
On 21/07/2015 16:25, Peter Maydell wrote: >> > >> > Well, it did say "This pull finally fixes the efi boot support. ipxe is >> > updated to the latest master, two non-upstream commits needed to make >> > efi work are added on top, and the build process is tweaked a bit". > Right, but if you want

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Peter Maydell
On 21 July 2015 at 15:09, Paolo Bonzini wrote: > On 21/07/2015 15:57, Peter Maydell wrote: >> On 21 July 2015 at 14:47, Paolo Bonzini wrote: >> So is the proposal here that we ship a non-upstream IPXE? >> That was less than entirely clear from the pull request... > > Well, it did say "This pull f

Re: [Qemu-devel] [PATCH for-2.4 1/1] qga: fixed versions for guest bus types in qapi-schema

2015-07-21 Thread Eric Blake
On 07/21/2015 06:25 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Michael Roth doc-only, so I've added 2.4 to the subject line. > --- > qga/qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH v3] tcg/ppc: Improve unaligned load/store handling on 64-bit backend

2015-07-21 Thread Alexander Graf
On 07/21/15 15:48, Paolo Bonzini wrote: On 21/07/2015 14:26, Benjamin Herrenschmidt wrote: So who can pick those up? PPC TCG is pretty much unmaintained since Malc disappeared, no? Did you just raise your hand ? :-) Worst case I'm happy to just keep a branch of my things that have had externa

Re: [Qemu-devel] [PATCH RFC v2 15/47] qapi: Fix to reject union command arguments

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > A command's 'data' must be a struct type, given either as a > dictionary, or as struct type name. > > Commit dd883c6 tightened the checking there, but not enough: we still > accept 'union'. Fix to reject it. I was thinking that 'all dictionaries

[Qemu-devel] [PATCH v4 6/6] AioContext: optimize clearing the EventNotifier

2015-07-21 Thread Paolo Bonzini
It is pretty rare for aio_notify to actually set the EventNotifier. It can happen with worker threads such as thread-pool.c's, but otherwise it should never be set thanks to the ctx->notify_me optimization. The previous patch, unfortunately, added an unconditional call to event_notifier_test_and_

[Qemu-devel] [PATCH v4 5/6] AioContext: fix broken placement of event_notifier_test_and_clear

2015-07-21 Thread Paolo Bonzini
event_notifier_test_and_clear must be called before processing events. Otherwise, an aio_poll could "eat" the notification before the main I/O thread invokes ppoll(). The main I/O thread then never wakes up. This is an example of what could happen: i/o thread vcpu thread

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-21 Thread Paolo Bonzini
On 21/07/2015 15:57, Peter Maydell wrote: > On 21 July 2015 at 14:47, Paolo Bonzini wrote: >> On 21/07/2015 15:27, Peter Maydell wrote: > On 21/07/2015 10:21, Peter Maydell wrote: >>> The ipxe changes are pushed to git://git.kraxel.org/ipxe >>> (branch qemu,

[Qemu-devel] [PATCH v4 4/6] AioContext: fix broken ctx->dispatching optimization

2015-07-21 Thread Paolo Bonzini
This patch rewrites the ctx->dispatching optimization, which was the cause of some mysterious hangs that could be reproduced on aarch64 KVM only. The hangs were indirectly caused by aio_poll() and in particular by flash memory updates's call to blk_write(), which invokes aio_poll(). Fun stuff: they

[Qemu-devel] [PATCH v4 2/6] tests: remove irrelevant assertions from test-aio

2015-07-21 Thread Paolo Bonzini
In these tests, the purpose of the initial calls to aio_poll and g_main_context_iteration is simply to put the AioContext in a known state; the return value of the function does not really matter. The next patch will change those return values; change the assertions to a while loop which expresses

[Qemu-devel] [PATCH v4 0/6] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-21 Thread Paolo Bonzini
This puts together all pending fixes in a single series. Paolo v1->v2 Split some changes to the tests to a separate patch Fix commit message [Laszlo] Clarify do...while loop in aio-win32.c [Kevin] v2->v3 Decrement notify_me a little earlier in aio-posix.c. v3->v4

[Qemu-devel] [PATCH v4 3/6] aio-win32: reorganize polling loop

2015-07-21 Thread Paolo Bonzini
Preparatory bugfixes and tweaks to the loop before the next patch: - disable dispatch optimization during aio_prepare. This fixes a bug. - do not modify "blocking" until after the first WaitForMultipleObjects call. This is needed in the next patch. - change the loop to do...while. This makes

  1   2   >