Re: [Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-20 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:19PM +0800, Fam Zheng wrote: > Two callers pass error_abort now, which can be changed to check return value > and pass the error on. > > Signed-off-by: Fam Zheng > --- > hw/virtio/virtio.c | 27 ++- > 1 file changed, 18 insertions(+), 9 delet

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 22:34, Michael S. Tsirkin wrote: > On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: >> >> >> On 20/04/2015 19:36, Michael S. Tsirkin wrote: >>> At the implementation level, there's one big issue you seem to have >>> missed: DMA to invalid memory addresses causes a cras

Re: [Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-20 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:21PM +0800, Fam Zheng wrote: > When getting invalid data from vring, virtqueue_pop used to print an > error and exit. > > Add an errp parameter so it can return the error to callers. > > Signed-off-by: Fam Zheng > --- > hw/9pfs/virtio-9p.c | 2 +- > hw/blo

Re: [Qemu-devel] [PATCH 03/18] virtio: Return error from virtqueue_get_head

2015-04-20 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:18PM +0800, Fam Zheng wrote: > Return type is changed to int. > > When data is invalid, return -EINVAL with an error. > > Signed-off-by: Fam Zheng Problem is, callers can't really handle -EINVAL here, so it's adding dead code if we just apply patches 1-9. How abou

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 01:50:33PM +0800, Fam Zheng wrote: > On Tue, 04/21 07:22, Michael S. Tsirkin wrote: > > On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: > > > On Mon, 04/20 19:36, Michael S. Tsirkin wrote: > > > > On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > > > >

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-20 Thread Thomas Huth
Am Tue, 21 Apr 2015 10:24:48 +1000 schrieb David Gibson : > On Mon, Apr 20, 2015 at 05:34:56PM +0200, Thomas Huth wrote: > > The check "liobn & 0xULL" in spapr_tce_find_by_liobn() > > is completely useless since liobn is only declared as an uint32_t > > parameter. Fix this by using

Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-04-20 Thread Fam Zheng
On Fri, 04/17 18:25, devsk wrote: > Fam: Any updates on this? Hi, I'm still working on the patchset. Will send to the list once it's done. Fam > Thanks > > > On Tuesday, March 3, 2015 12:54 AM, Fam Zheng wrote: > > > On Tue, 03/03 09:36, Milos Vyletel wrote: > > On Sun, Mar 1, 201

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Fam Zheng
On Tue, 04/21 07:22, Michael S. Tsirkin wrote: > On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: > > On Mon, 04/20 19:36, Michael S. Tsirkin wrote: > > > On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > > > > Currently, virtio code chooses to kill QEMU if the guest passes any

Re: [Qemu-devel] [PATCH v1 1/1] S390 pci infrastructure modeling

2015-04-20 Thread Hong Bo Li
Sorry, I sent the patch three times by accident. Please take this one as the formal patch. This is a followup to the discussion started by Frank Blaschka: Option 1: s390x/pci: Extend pci representation by new zpci device Option 2: s390x/pci: rework pci infrastructure modeling This patch provid

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: > On Mon, 04/20 19:36, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > > > Currently, virtio code chooses to kill QEMU if the guest passes any > > > invalid > > > data with vring. > > > That has d

Re: [Qemu-devel] [[PATCH] 5/7] target-arm: Add TTBR regime function and use

2015-04-20 Thread Sergey Fedorov
On 27.03.2015 12:10, Greg Bellows wrote: > Add a utility function for choosing the correct TTBR system register based on > the specified MMU index. Add use of function on physical address lookup. > > Signed-off-by: Greg Bellows > --- > target-arm/helper.c | 44 --

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Fam Zheng
On Mon, 04/20 22:34, Michael S. Tsirkin wrote: > On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: > > > > > > On 20/04/2015 19:36, Michael S. Tsirkin wrote: > > > At the implementation level, there's one big issue you seem to have > > > missed: DMA to invalid memory addresses causes

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Fam Zheng
On Mon, 04/20 19:36, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > > Currently, virtio code chooses to kill QEMU if the guest passes any invalid > > data with vring. > > That has drawbacks such as losing unsaved data (e.g. when > > guest user is writing a

Re: [Qemu-devel] [PATCH v3 16/16] hw/intc/arm_gic: add gic_update() for grouping

2015-04-20 Thread Edgar E. Iglesias
On Wed, Apr 15, 2015 at 11:02:22AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > GICs with grouping (GICv2 or GICv1 with Security Extensions) have a > different exception generation model which is more complicated than > without interrupt grouping. We add a new function to handle this mod

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Shannon Zhao
On 2015/4/20 19:32, Cornelia Huck wrote: > On Mon, 20 Apr 2015 16:20:00 +0800 > shannon.z...@linaro.org wrote: > >> From: Shannon Zhao >> >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. >> The transports just sync the host features from backend. >> >> Signed-off-by: Shannon Zhao >>

Re: [Qemu-devel] [PATCH v3 07/16] hw/intc/arm_gic: Make ICDDCR/GICD_CTLR banked

2015-04-20 Thread Edgar E. Iglesias
On Wed, Apr 15, 2015 at 11:02:13AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > ICDDCR/GICD_CTLR is banked in GICv1 implementations with Security > Extensions or in GICv2 in independent from Security Extensions. > This makes it possible to enable forwarding of interrupts from > Distribut

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-20 Thread Wen Congyang
On 04/20/2015 11:30 PM, Stefan Hajnoczi wrote: > On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Yang Hongyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> docs/block-replicat

Re: [Qemu-devel] [PATCH v3 06/16] hw/intc/arm_gic: Add Interrupt Group Registers

2015-04-20 Thread Edgar E. Iglesias
On Wed, Apr 15, 2015 at 11:02:12AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > Interrupt Group Registers (previously called Interrupt Security > Registers) as defined in GICv1 with Security Extensions or GICv2 allow > to configure interrupts as Secure (Group0) or Non-secure (Group1). >

Re: [Qemu-devel] [PATCH v3 05/16] hw/intc/arm_gic: Add ns_access() function

2015-04-20 Thread Edgar E. Iglesias
On Wed, Apr 15, 2015 at 11:02:11AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > Security Extensions for GICv1 and GICv2 use register banking > to provide transparent access to seperate Secure and Non-secure > copies of GIC configuration registers. This function will later > be replaced b

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-20 Thread David Gibson
On Mon, Apr 20, 2015 at 05:34:56PM +0200, Thomas Huth wrote: > The check "liobn & 0xULL" in spapr_tce_find_by_liobn() > is completely useless since liobn is only declared as an uint32_t > parameter. Fix this by using target_ulong instead (this is what most > of the callers of this f

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-20 Thread Kevin O'Connor
On Tue, Apr 21, 2015 at 07:31:36AM +0800, Amos Kong wrote: > Hi Kevin, > > When I use old seabios in some stable linux release, some bootable > devices (2 ide disks) would be lost when I try to restart guest by > Ctrl+Alt+Delete during boot stage. > > Releated Red Hat BZ: https://bugzilla.redhat.

[Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-20 Thread Amos Kong
Hi Kevin, When I use old seabios in some stable linux release, some bootable devices (2 ide disks) would be lost when I try to restart guest by Ctrl+Alt+Delete during boot stage. Releated Red Hat BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1129549 I found an upstream commit [1] fixed this bu

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: > > > On 20/04/2015 19:36, Michael S. Tsirkin wrote: > > At the implementation level, there's one big issue you seem to have > > missed: DMA to invalid memory addresses causes a crash in memory core. > > I'm not sure whether it makes

Re: [Qemu-devel] [PATCH v2 4/4] target-arm: kvm - add support for HW assisted debug

2015-04-20 Thread Peter Maydell
On 31 March 2015 at 16:40, Alex Bennée wrote: > From: Alex Bennée > > This adds basic support for HW assisted debug. The ioctl interface to > KVM allows us to pass an implementation defined number of break and > watch point registers. When KVM_GUESTDBG_USE_HW_BP is specified these > debug registe

Re: [Qemu-devel] [[PATCH] 4/7] target-arm: Add AArch64 CPTR registers

2015-04-20 Thread Greg Bellows
On Thu, Apr 16, 2015 at 1:00 PM, Peter Maydell wrote: > On 27 March 2015 at 19:10, Greg Bellows wrote: > > Adds CPTR_EL2/3 system registers definitions and access function. > > > > Signed-off-by: Greg Bellows > > --- > > target-arm/cpu.h| 18 +- > > target-arm/helper.c | 43

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step

2015-04-20 Thread Peter Maydell
On 31 March 2015 at 16:40, Alex Bennée wrote: > This adds support for single-step. There isn't much to do on the QEMU > side as after we set-up the request for single step via the debug ioctl > it is all handled within the kernel. > > Signed-off-by: Alex Bennée > > --- > v2 > - convert to using

Re: [Qemu-devel] [PATCH v2 2/4] target-arm: kvm - implement software breakpoints

2015-04-20 Thread Peter Maydell
On 31 March 2015 at 16:40, Alex Bennée wrote: > These don't involve messing around with debug registers, just setting > the breakpoint instruction in memory. GDB will not use this mechanism if > it can't access the memory to write the breakpoint. > > All the kernel has to do is ensure the hypervis

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 19:36, Michael S. Tsirkin wrote: > At the implementation level, there's one big issue you seem to have > missed: DMA to invalid memory addresses causes a crash in memory core. > I'm not sure whether it makes sense to recover from virtio core bugs > when we can't recover from device

Re: [Qemu-devel] driver enhancement for Intel IGD passthrough

2015-04-20 Thread Alex Williamson
On Thu, 2015-04-16 at 17:24 +, Tian, Kevin wrote: > ping... > > > From: Tian, Kevin > > Sent: Friday, April 10, 2015 10:33 AM > > > > Hi, > > > > We are working on Linux/Windows graphics driver enhancement to > > remove those non-standard PCI resource accesses, e.g. to PCH/MCH > > registers,

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > Currently, virtio code chooses to kill QEMU if the guest passes any invalid > data with vring. > That has drawbacks such as losing unsaved data (e.g. when > guest user is writing a very long email), or possible denial of service in > a ne

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/4] blockjob: Allow nested pause

2015-04-20 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 04:13:55PM +0200, Paolo Bonzini wrote: > > > On 03/04/2015 16:05, Fam Zheng wrote: > > This patch changes block_job_pause to increase the pause counter and > > block_job_resume to decrease it. > > > > The counter will allow calling block_job_pause/block_job_resume > > unc

Re: [Qemu-devel] [PATCH] block: avoid unnecessary bottom halves

2015-04-20 Thread Stefan Hajnoczi
On Sat, Mar 28, 2015 at 07:37:18AM +0100, Paolo Bonzini wrote: > bdrv_aio_* APIs can use coroutines to achieve asynchronicity. However, > the coroutine may terminate without having yielded back to the caller > (for example because of something that invokes a nested event loop, > or because the cor

[Qemu-devel] [PATCH 09/10] Sort destination RAMBlocks to be the same as the source

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use the order of incoming RAMBlocks from the source to record an index number; that then allows us to sort the destination local RAMBlock list to match the source. Now that the RAMBlocks are known to be in the same order, this simplifies the RDMA Registration step

[Qemu-devel] [PATCH 06/10] Remove unneeded memset

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index e43fae4..4f7dd0d 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2469,7 +2469,6 @@ static void *qemu_rd

Re: [Qemu-devel] [PATCH] block: avoid unnecessary bottom halves

2015-04-20 Thread Stefan Hajnoczi
On Sat, Mar 28, 2015 at 07:37:18AM +0100, Paolo Bonzini wrote: > bdrv_aio_* APIs can use coroutines to achieve asynchronicity. However, > the coroutine may terminate without having yielded back to the caller > (for example because of something that invokes a nested event loop, > or because the cor

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Cornelia Huck
On Mon, 20 Apr 2015 15:34:06 +0100 Peter Maydell wrote: > On 20 April 2015 at 15:08, Cornelia Huck wrote: > > Hmm... isn't ->plugged() called after ->realize()? > > > > Maybe I'm just confused, so let's try to understand the callchain :) > > > > VirtIONetCcw is realized > > -> feature bits are

Re: [Qemu-devel] [PATCH] m25p80: add missing blk_attach_dev_nofail

2015-04-20 Thread Peter Crosthwaite
On Tue, Apr 14, 2015 at 8:29 AM, Paolo Bonzini wrote: > Of the block devices that poked into -drive options via drive_get_next, > m25p80 was the only one who also did not attach itself to the BlockBackend. > > Since sd does it, and all other devices go through a "drive" property, > with this chang

[Qemu-devel] [PATCH 08/10] Rework ram block hash

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RDMA uses a hash from block offset->RAM Block; this isn't needed on the destination, and now that the destination sorts the ramblock list, is harder to maintain. Split the hash so that it's only generated on the source. Signed-off-by: Dr. David Alan Gilbert ---

[Qemu-devel] [PATCH 05/10] Rework ram_control_load_hook to hook during block load

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We need the names of RAMBlocks as they're loaded for RDMA, reuse an existing QEMUFile hook with some small mods. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 4 +++- include/migration/migration.h | 2 +- include/migration/qemu-file.

[Qemu-devel] [PATCH 10/10] Sanity check RDMA remote data

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Perform some basic (but probably not complete) sanity checking on requests from the RDMA source. Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/migration/rdma.c b/migr

[Qemu-devel] [PATCH 02/10] qemu_ram_foreach_block: pass up error value, and down the ramblock name

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" check the return value of the function it calls and error if it's non-0 Fixup qemu_rdma_init_one_block that is the only current caller, and rdma_add_block the only function it calls using it. Pass the name of the ramblock to the function; helps in debugging. Sig

[Qemu-devel] [PATCH 07/10] Simplify rdma_delete_block and remove it's dependence on the hash

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" rdma_delete_block is currently very general, but it's only used in cleanup at the end. Simplify it and remove it's dependence on the hash table and remove all of the hash-table regeneration designed to handle the (unused) case of deleting an arbitrary block. Sign

[Qemu-devel] [PATCH 01/10] Rename RDMA structures to make destination clear

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RDMA has two data types that are named confusingly; RDMALocalBlock (pointed to indirectly by local_ram_blocks) RDMARemoteBlock (pointed to by block in RDMAContext) RDMALocalBlocks, as the name suggests is a data strucuture that represents the RDMAable RAM Blo

[Qemu-devel] [PATCH 03/10] Store block name in local blocks structure

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In a later patch the block name will be used to match up two views of the block list. Keep a copy of the block name with the local block list. (At some point it could be argued that it would be best just to let migration see the innards of RAMBlock and avoid the n

[Qemu-devel] [PATCH 04/10] Translate offsets to destination address space

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within the ram_addr_t space. The code currently assumes that the offsets on the sourc

[Qemu-devel] [PATCH 00/10] Remove RDMA migration dependence on RAMBlock offset

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RDMA migration currently relies on the source and destination RAMBlocks having the same offsets within ram_addr_t space; unfortunately that's just not true when: a) You hotplug on the source but then create the device on the command line on the destination.

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/4] Fix "stop" draining block jobs

2015-04-20 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 10:05:17PM +0800, Fam Zheng wrote: > v2: Use "pause" approach as suggested by Paolo. > > Stopping the vm will drive the block job all the way to the end, because the > sleep duration is too short, which means the block_job_sleep_ns in the block > jobs are unhelpful. That is

[Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-20 Thread Thomas Huth
The check "liobn & 0xULL" in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). And while we're at it, change the error mess

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-20 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Hongyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 153 > +++

Re: [Qemu-devel] [RFC PATCH 1/3] KVM: promote KVM_MEMSLOT_INCOHERENT to uapi

2015-04-20 Thread Christoffer Dall
On Wed, Mar 18, 2015 at 03:10:31PM -0400, Andrew Jones wrote: > Also rename to KVM_MEM_UNCACHED. > > Signed-off-by: Andrew Jones > --- > Documentation/virtual/kvm/api.txt | 16 ++-- > arch/arm/include/uapi/asm/kvm.h | 1 + > arch/arm/kvm/arm.c| 1 + > arch/arm/kvm

[Qemu-devel] [RFC/PATCH] Bad volume scaling with Win7 guest, spice audio, and Qemu Intel HDA codec

2015-04-20 Thread Wilck, Martin
Hello, I see a problem with input volume control on a Windows7 guest using the qemu Intel HDA codec. In short, moving the volume slider for the input volume from 0% to 1% under Windows results in the "gain" values in the emulated HW to jump from 0 to 40 (out of 74) (looking at "st->gain_[left|rig

Re: [Qemu-devel] [PATCH v2 0/4] QEMU support for KVM Guest Debug on arm64

2015-04-20 Thread Alex Bennée
Alex Bennée writes: > Hi, > > I thought I'd sent V1 to the list but apparently not. Anyway this > patch series provides the QEMU side of guest debug support for arm64. > I'm assuming the first patch will be dropped when a proper merge of > the linux-headers is done once the kernel side is upstre

Re: [Qemu-devel] [PATCH 6/6] watchdog: Add new Virtual Watchdog action INJECT-NMI

2015-04-20 Thread Cornelia Huck
On Fri, 17 Apr 2015 06:28:10 -0600 Eric Blake wrote: > On 04/17/2015 01:52 AM, Cornelia Huck wrote: > > From: Mao Chuan Li > > > > This patch allows QEMU to inject a NMI into a guest when the > > watchdog expires. > > > > Signed-off-by: Mao Chuan Li > > Reviewed-by: David Hildenbrand > > Sig

[Qemu-devel] [PATCH] linux-user: Use abi_ulong for TARGET_ELF_PAGESTART

2015-04-20 Thread Yongbok Kim
TARGET_ELF_PAGESTART is required to use abi_ulong to correctly handle addresses for different target bits width. This patch fixes a problem when running a 64-bit user mode application on 32-bit host machines. Signed-off-by: Yongbok Kim Reviewed-by: Peter Maydell --- linux-user/elfload.c |3

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-20 Thread Cornelia Huck
On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng wrote: > Currently, virtio code chooses to kill QEMU if the guest passes any invalid > data with vring. That has drawbacks such as losing unsaved data (e.g. when > guest user is writing a very long email), or possible denial of service in > a nested vm

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-20 Thread Jan Beulich
>>> On 20.04.15 at 16:32, wrote: > On Mon, Apr 20, 2015 at 03:08:09PM +0100, Jan Beulich wrote: >> >>> On 20.04.15 at 15:43, wrote: >> > did firmware reconfigure this device to report URs as fatal errors then? >> >> No, the Unsupported Request Error Serverity flag is zero. > > OK, that's the co

Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT

2015-04-20 Thread Peter Maydell
On 20 April 2015 at 13:39, Marc-André Lureau wrote: > Hi > > On Tue, Apr 14, 2015 at 6:07 PM, Eric Blake wrote: >> >> > +{ "machine", "vmport", QEMU_CAPS_MACHINE_VMPORT_OPT }, >> >> Ouch. qemu commit 0a7cf21 fixes what would have been a regression in >> 2.3 at exposing "mem-merge" through qu

Re: [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-20 Thread Christian Borntraeger
Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > From: Thomas Huth > > Add code to make use of the new ioctl for reading from / writing to > virtual guest memory. By using the ioctl, the memory accesses are now > protected with the so-called ipte-lock in the kernel. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH 04/10] sclp: sort into categories

2015-04-20 Thread Christian Borntraeger
Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > Sort the sclp consoles into the input category, just as virtio-serial. > Various other sclp devices don't have an obvious category, sort them > into misc. > > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck Acked-by: Christian Borntr

Re: [Qemu-devel] [PATCH 05/10] s390x/ipl: sort into categories

2015-04-20 Thread Christian Borntraeger
Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > The s390 ipl device has no real home (it's not really a storage device), > so let's sort it into the misc category. > > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > hw/s390x/ipl.c | 1 + >

Re: [Qemu-devel] [PATCH 03/10] s390-virtio: sort into categories

2015-04-20 Thread Christian Borntraeger
Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > Sort the various s390-virtio devices into the same categories as their > virtio-pci counterparts. > > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > hw/s390x/s390-virtio-bus.c | 9 +

Re: [Qemu-devel] [PATCH 02/10] virtio-ccw: sort into categories

2015-04-20 Thread Christian Borntraeger
Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > Sort the various virtio-ccw devices into the same categories as their > virtio-pci counterparts. > > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > hw/s390x/virtio-ccw.c | 9 + > 1 f

Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 15:11, Stefan Hajnoczi wrote: >> -memory_region_set_coalescing(&s->mem_vram); + >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > > This change isn't 100% clear to me. I guess that coalescing > (performance optimization) doesn't make sense when logging is > en

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Peter Maydell
On 20 April 2015 at 15:08, Cornelia Huck wrote: > Hmm... isn't ->plugged() called after ->realize()? > > Maybe I'm just confused, so let's try to understand the callchain :) > > VirtIONetCcw is realized > -> feature bits are used > -> embedded VirtIODevice is realized > -> VirtioCcwDevice is

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 03:08:09PM +0100, Jan Beulich wrote: > >>> On 20.04.15 at 15:43, wrote: > > On Mon, Apr 13, 2015 at 01:51:06PM +0100, Jan Beulich wrote: > >> >>> On 13.04.15 at 14:47, wrote: > >> > Can you check device capabilities register, offset 0x4 within > >> > pci express capability

Re: [Qemu-devel] running 64 bit user mode program on 32 bit host machine

2015-04-20 Thread Peter Maydell
On 20 April 2015 at 14:34, Yongbok Kim wrote: > Hi All, > > I have faced a problem to run a simple 64 bit Linux user mode application on > 32 bit Linux host machines. > I did some investigation and found out that the TARGET_ELF_PAGESTART macro > in > the linux-user/elfload.c is causing the problem

[Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-20 Thread Fabio Fantoni
I updated xen and qemu from xen 4.5.0 with its upstream qemu included to xen 4.5.1-pre with qemu upstream from stable-4.5 (changed Config.mk to use revision "master"). After few minutes I booted windows 7 64 bit domU qemu crash, tried 2 times with same result. In the domU's qemu log: qemu-syst

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Cornelia Huck
On Mon, 20 Apr 2015 21:32:52 +0800 Shannon Zhao wrote: > > > On 2015/4/20 19:32, Cornelia Huck wrote: > > On Mon, 20 Apr 2015 16:20:00 +0800 > > shannon.z...@linaro.org wrote: > > > >> From: Shannon Zhao > >> > >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > >> The transports j

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-20 Thread Jan Beulich
>>> On 20.04.15 at 15:43, wrote: > On Mon, Apr 13, 2015 at 01:51:06PM +0100, Jan Beulich wrote: >> >>> On 13.04.15 at 14:47, wrote: >> > Can you check device capabilities register, offset 0x4 within >> > pci express capability structure? >> > Bit 15 is 15 Role-Based Error Reporting. >> > Is it se

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 01:51:06PM +0100, Jan Beulich wrote: > >>> On 13.04.15 at 14:47, wrote: > > On Mon, Apr 13, 2015 at 01:40:59PM +0100, Jan Beulich wrote: > >> Quite possible. Looking at the ITP log we were provided, the UR > >> severity bit is clear (non-fatal), yet the error got surfaced t

[Qemu-devel] running 64 bit user mode program on 32 bit host machine

2015-04-20 Thread Yongbok Kim
Hi All, I have faced a problem to run a simple 64 bit Linux user mode application on 32 bit Linux host machines. I did some investigation and found out that the TARGET_ELF_PAGESTART macro in the linux-user/elfload.c is causing the problem. However I am not sure if this is the right solution a

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Shannon Zhao
On 2015/4/20 19:32, Cornelia Huck wrote: On Mon, 20 Apr 2015 16:20:00 +0800 shannon.z...@linaro.org wrote: From: Shannon Zhao Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. The transports just sync the host features from backend. Signed-off-by: Shannon Zhao Signed-off-by: Shan

Re: [Qemu-devel] [PATCH 0/2] virtfs-proxy-helper: small fixes

2015-04-20 Thread Stefan Hajnoczi
On Mon, Mar 30, 2015 at 02:57:14PM +0100, Stefan Hajnoczi wrote: > These fixes are not critical but it wouldn't hurt to get them into QEMU 2.3. > > See patches for descriptions. > > Stefan Hajnoczi (2): > virtfs-proxy-helper: add missing long option terminator > virtfs-proxy-helper: fail grac

[Qemu-devel] [PATCH] [hack] tseg test

2015-04-20 Thread Gerd Hoffmann
Put some unique content into tseg area when locked down for easy testing. --- hw/pci-host/q35.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 7d21399..1b2698f 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -200,7 +

Re: [Qemu-devel] [PATCH 00/22] Dirty bitmap atomic access and optimizations

2015-04-20 Thread Stefan Hajnoczi
On Thu, Mar 26, 2015 at 06:38:18PM +0100, Paolo Bonzini wrote: > QEMU is currently accessing the dirty bitmaps very liberally, > which is understandable since the accesses are cheap. This is > however not good for squeezing maximum performance out of dataplane, > and is also not good if the access

Re: [Qemu-devel] [PATCH 1/6] [fixup] add ESMRAMC default

2015-04-20 Thread Gerd Hoffmann
On Mo, 2015-04-20 at 14:27 +0200, Paolo Bonzini wrote: > > On 20/04/2015 14:07, Michael S. Tsirkin wrote: > > signature is missing. > > And it might be a good idea to add a cover letter, > > stick q35: in subject for patches, and add a > > bit of description in the commit log. > > The patches as

Re: [Qemu-devel] Unparking vCPU mechanism

2015-04-20 Thread Mohsin Kazmi
Hi Zhu, I was using the qemu command with "--cpu host". I removed that and after that it is working fine for me. Now everything is working perfectly fine. Thanks, Mohsin Kazmi On Mon, Apr 20, 2015 at 2:16 PM, Mohsin Kazmi wrote: > Hi Zhu, > I installed and enabled the --i

Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-04-20 Thread Stefan Hajnoczi
On Thu, Mar 26, 2015 at 06:38:22PM +0100, Paolo Bonzini wrote: > diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c > index 46f7b41..be62dd6 100644 > --- a/hw/display/g364fb.c > +++ b/hw/display/g364fb.c > @@ -489,7 +489,7 @@ static void g364fb_init(DeviceState *dev, G364State *s) > memory

Re: [Qemu-devel] [PATCH v4] vhost: fix log base address

2015-04-20 Thread Peter Maydell
On 20 April 2015 at 07:07, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2015 at 05:13:24PM +0200, Michael S. Tsirkin wrote: >> VHOST_SET_LOG_BASE got an incorrect address, causing >> migration errors and potentially even memory corruption. >> >> Reported-by: Wen Congyang >> Signed-off-by: Michael

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] null driver patches

2015-04-20 Thread Stefan Hajnoczi
On Wed, Apr 01, 2015 at 09:45:37AM +0800, Fam Zheng wrote: > v2: Change patch 01 to use realtime clock, that way we don't need to check the > VCPU state. [Stefan] > Added Eric's rev-by in 2&3. > Change title to "Null block driver" in 3. [Eric] > > The second patch allows testing commit

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 02:14:30PM +0200, Cornelia Huck wrote: > On Mon, 20 Apr 2015 11:12:37 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 20, 2015 at 10:54:11AM +0200, Cornelia Huck wrote: > > > On Fri, 17 Apr 2015 15:00:45 +0100 > > > Peter Maydell wrote: > > > > > > > On 17 April 20

Re: [Qemu-devel] [PATCH RFC] vhost-user: protocol extensions

2015-04-20 Thread Olivier MATZ
Hi Michael, On 04/06/2015 04:48 PM, Michael S. Tsirkin wrote: > This adds several extensions to the vhost user protocol: > - protocol feature negotiation similar to virtio features > - ability to report request failures > - ability to start/stop specific rings > > I went over all vhost-user imple

Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT

2015-04-20 Thread Marc-André Lureau
Hi On Tue, Apr 14, 2015 at 6:07 PM, Eric Blake wrote: > > +{ "machine", "vmport", QEMU_CAPS_MACHINE_VMPORT_OPT }, > > Ouch. qemu commit 0a7cf21 fixes what would have been a regression in > 2.3 at exposing "mem-merge" through query-command-line-options, but it > does NOT expose "vmport", whi

[Qemu-devel] [Bug 1446179] Re: QEMU 2.2.1 fails to build due to pixman libpng dependency

2015-04-20 Thread Erik Rull
sorry, my fault --disable-libpng fixed it in the configure option ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1446179 Title: QEMU 2.2.1 fails to

Re: [Qemu-devel] [PATCH 1/6] [fixup] add ESMRAMC default

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 14:07, Michael S. Tsirkin wrote: > signature is missing. > And it might be a good idea to add a cover letter, > stick q35: in subject for patches, and add a > bit of description in the commit log. The patches as they are do not apply to master. I expect Gerd to send the final vers

Re: [Qemu-devel] Unparking vCPU mechanism

2015-04-20 Thread Mohsin Kazmi
Hi Zhu, I installed and enabled the --iasl=IASL at "configuration" for qemu and then "make" it. When i tried to delete the cpu1 after adding it using hotplug/unplug, I am facing the kernel panic at guest os. Kernel version (3.11.10-301.fc20.x86_64) [root@fedora20 ~]# [ 208.733033] gene

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Cornelia Huck
On Mon, 20 Apr 2015 11:12:37 +0200 "Michael S. Tsirkin" wrote: > On Mon, Apr 20, 2015 at 10:54:11AM +0200, Cornelia Huck wrote: > > On Fri, 17 Apr 2015 15:00:45 +0100 > > Peter Maydell wrote: > > > > > On 17 April 2015 at 14:43, Cornelia Huck wrote: > > > > On Fri, 17 Apr 2015 20:13:42 +0800 >

Re: [Qemu-devel] [PATCH 1/6] [fixup] add ESMRAMC default

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 11:19:15AM +0200, Gerd Hoffmann wrote: > --- signature is missing. And it might be a good idea to add a cover letter, stick q35: in subject for patches, and add a bit of description in the commit log. Besides that Reviewed-by: Michael S. Tsirkin > hw/pci-host/q35.c

Re: [Qemu-devel] [PATCH 3/6] q35: implement SMRAM.D_LCK

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 11:19:17AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin > --- > hw/pci-host/q35.c | 8 +++- > include/hw/pci-host/q35.h | 3 +++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/hw/pci-host/q3

Re: [Qemu-devel] [PATCH 4/6] q35: add test for SMRAM.D_LCK

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 11:19:18AM +0200, Gerd Hoffmann wrote: > --- signature is missing. Besides that Reviewed-by: Michael S. Tsirkin > tests/Makefile | 2 ++ > tests/smram-test.c | 80 > ++ > 2 files changed, 82 insertions(+) > cr

Re: [Qemu-devel] [PATCH 2/6] add SMRAM+ESMRAMC wmask

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 11:19:16AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann I would probably squash 2 and 3, to reduce the chance of bisect related issues. Otherwise Reviewed-by: Michael S. Tsirkin > --- > hw/pci-host/q35.c | 2 ++ > include/hw/pci-host/q35.h | 9 +

Re: [Qemu-devel] [PATCH v02] add 1394 bus support

2015-04-20 Thread Itamar Tal
On Sun, Apr 19, 2015 at 8:21 PM, Andreas Färber wrote: > Hi, > > Am 19.04.2015 um 18:38 schrieb Itamar Tal: > > I've set it just after the subject field in the patch? Should I add it > > somewhere else and resubmit? > > Please compare other QEMU or Linux patches: It needs to go before --- > into

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 11:19, Gerd Hoffmann wrote: > +memory_region_del_subregion(mch->system_memory, &mch->tseg_blackhole); > +memory_region_set_enabled(&mch->tseg_blackhole, tseg_size); Please use "tseg_size > 0" here. Paolo > +memory_region_set_size(&mch->tseg_blackhole, tseg_size); > +

[Qemu-devel] [Bug 1446179] [NEW] QEMU 2.2.1 fails to build due to pixman libpng dependency

2015-04-20 Thread Erik Rull
Public bug reported: QEMU 2.2.1 does not compile properly when having set --disable-vnc-png due to the missing libpng support on the compile system. The worked great in QEMU 2.1.0 but 2.2.1 seems to have a missing dependency propagation to pixman which now requires libpng anyway. There seems to no

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Cornelia Huck
On Mon, 20 Apr 2015 16:20:00 +0800 shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > The transports just sync the host features from backend. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/net/virtio

Re: [Qemu-devel] [PATCH v3 0/7] aio: Support epoll by introducing qemu_poll abstraction

2015-04-20 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 10:02:30AM +0800, Fam Zheng wrote: > On Thu, 04/16 14:03, Stefan Hajnoczi wrote: > > On Thu, Apr 16, 2015 at 12:57:29PM +0800, Fam Zheng wrote: > > > v3: Rebase to master for 2.4. > > > Although epoll_pwait1 syscall is still being worked on [1], the QEMU > > > part > >

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-20 Thread Cornelia Huck
On Mon, 20 Apr 2015 16:20:00 +0800 shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > The transports just sync the host features from backend. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/net/virtio

Re: [Qemu-devel] Unparking vCPU mechanism

2015-04-20 Thread Zhu Guihua
On 04/16/2015 06:50 PM, Mohsin Kazmi wrote: Hi Zhu, I am testing the hot unplug feature using your github branch 'cpu-hotplug'. It is working fine when first time I added and deleted cpu. But when I tried to add cpu second time, it showed me the following error: (qemu) device_add k

[Qemu-devel] [PATCH 3/6] q35: implement SMRAM.D_LCK

2015-04-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/q35.c | 8 +++- include/hw/pci-host/q35.h | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 7093cc3..f0d840c 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -268,6

[Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-20 Thread Gerd Hoffmann
add tseg window to smram region, so cpus can access it in smm mode. Signed-off-by: Gerd Hoffmann --- hw/pci-host/q35.c | 13 + include/hw/pci-host/q35.h | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 412ff0a

  1   2   >