On 20/04/2015 15:11, Stefan Hajnoczi wrote: >> - memory_region_set_coalescing(&s->mem_vram); + >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > > This change isn't 100% clear to me. I guess that coalescing > (performance optimization) doesn't make sense when logging is > enabled?
No, it's just that coalescing is for MMIO, not RAM. Setting coalescing was a no-op. I'll make this a separate patch. Paolo