Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 11:34:49AM -0500, Corey Minyard wrote: > On 04/13/2015 02:00 AM, Michael S. Tsirkin wrote: > > On Sun, Apr 12, 2015 at 08:26:46PM -0500, Corey Minyard wrote: > >> On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: > >>> On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.or

Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term

2015-04-13 Thread Shannon Zhao
On 2015/4/14 13:56, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 04:55:13PM +0100, Alex Bennée wrote: >> >> Shannon Zhao writes: >> >>> From: Shannon Zhao >>> >>> Signed-off-by: Shannon Zhao >>> Signed-off-by: Shannon Zhao >> >> I was considering if the magic numbers should be defined so

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: > > > On 13/04/2015 18:34, Corey Minyard wrote: > > > > I made this the same as the ACPI code, which you have to have as a > > > > callback if you are adding it to a common SSDT. > > > > > > Not really I think. > > > > The AML functio

[Qemu-devel] [PATCH] qga: use unbuffered glib IO

2015-04-13 Thread WANG Chao
Glib's internal buffering implementation is opaque. It seems to grow up when receiving large chunk of data (eg. by guest-file-write). When that buffer become large, the glib main loop will stop notifying callback for small incoming chunk (eg. by guest-file-close) but wait until buffer is filled up

Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 04:55:13PM +0100, Alex Bennée wrote: > > Shannon Zhao writes: > > > From: Shannon Zhao > > > > Signed-off-by: Shannon Zhao > > Signed-off-by: Shannon Zhao > > I was considering if the magic numbers should be defined somewhere but I > guess that is the point of the stu

Re: [Qemu-devel] [PATCH 3/3] TPM2 ACPI table support

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 10:29:32PM -0400, Stefan Berger wrote: > On 04/13/2015 02:27 AM, Michael S. Tsirkin wrote: > >>@@ -1428,12 +1444,22 @@ void acpi_build(PcGuestInfo *guest_info, > >>AcpiBuildTables *tables) > >> acpi_add_table(table_offsets, tables_blob); > >> build_hpet(ta

Re: [Qemu-devel] [PATCH 1/3] Extend TPM TIS interface to version 2.0

2015-04-13 Thread Michael S. Tsirkin
On Tue, Mar 31, 2015 at 03:40:11PM -0400, Stefan Berger wrote: > Following the recent upgrade to version 1.3, extend the TPM TIS > interface with capabilities introduced for support of a TPM 2. > > TPM TIS for TPM 2 introduced the following extensions beyond the > TPM TIS 1.3 (used for TPM 1.2): >

Re: [Qemu-devel] [PATCH 2/3] tpm: Probe for connected TPM 1.2 or TPM 2

2015-04-13 Thread Michael S. Tsirkin
On Tue, Mar 31, 2015 at 03:40:12PM -0400, Stefan Berger wrote: > In the TPM passthrough backend driver, modify the probing code so > that we can check whether a TPM 1.2 or TPM 2 is being used > and adapt the behavior of the TPM TIS accordingly. > > Move the code that tested for a TPM 1.2 into tpm_

Re: [Qemu-devel] [PATCH RFC 18/19] json-parser: Fix to recognize null

2015-04-13 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qobject/json-parser.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake > > diff --git a/qobject/json-parser.c b/qobject/json-parser.c > index 4288267..717cb8f 100644 > --- a/qobject/js

Re: [Qemu-devel] [PATCH RFC 17/19] qobject: Add a special null QObject

2015-04-13 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: > I'm going to fix the JSON parser to recognize null. The obvious > representation of JSON null as (QObject *)NULL doesn't work, because > the parser already uses it as an error value. Perhaps we should > change it to free NULL for null, but that's

Re: [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code

2015-04-13 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: > QTYPE_NONE is a sentinel value. No QObject has this type code. > Document it properly. > > Fix dump_qobject() to abort() on QTYPE_NONE, just like for any other > invalid type code. > > Fix to_json() to abort() on all invalid type codes, not just

Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term

2015-04-13 Thread Shannon Zhao
On 2015/4/13 23:55, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao > > I was considering if the magic numbers should be defined somewhere but I > guess that is the point of the stub functions. > Yes, I th

Re: [Qemu-devel] [PATCH 3/3] TPM2 ACPI table support

2015-04-13 Thread Stefan Berger
On 04/13/2015 02:27 AM, Michael S. Tsirkin wrote: @@ -1428,12 +1444,22 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables) acpi_add_table(table_offsets, tables_blob); build_hpet(tables_blob, tables->linker); } -if (misc.has_tpm) { +if (misc.tpm_

Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters

2015-04-13 Thread Li, Liang Z
> Eric, can you review this and the following patch? I think they are correct, > but > I preffer someone more versed on QMP to review them. > > Thanks, Juan. Hi Juan & Eric, Since the latest QEMU is 2.3.0-rc2, is it possible to merge this serial of patches to QEMU 2.3? If it can't not,

Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-13 Thread Shannon Zhao
On 2015/4/13 23:58, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> Add PCIe controller in ACPI DSDT table, so the guest can detect >> the PCIe. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> --- >> hw/arm/virt-acpi-build.c | 140 >> +++

Re: [Qemu-devel] [PATCH v5 6/6] Qemu-Xen-vTPM: Add a parameter indicating whether the command that was a selftest

2015-04-13 Thread Stefan Berger
On 04/12/2015 04:50 PM, Stefan Berger wrote: On 04/10/2015 02:59 AM, Quan Xu wrote: and whether it completed successfully. Move tpm_passthrough_is_selftest() into tpm_util.c and rename it to tpm_util_is_selftest(). Signed-off-by: Quan Xu --- hw/tpm/Makefile.objs | 2 +- hw/tpm

[Qemu-devel] [PATCH] linux-user: in poll(), if nfds is 0, pfd can be NULL

2015-04-13 Thread Laurent Vivier
This problem appears with yum in Fedora 20 / PPC64 container. test case: #include #include int main(void) { int ret; ret = poll(NULL, 0, 1000); printf("%d\n", ret); } target test environment: Fedora 20 / PPC64 host test environment: Ubuntu 14.0.2 /

[Qemu-devel] [RFC 2/2] scripts: x86-cpu-model-dump script

2015-04-13 Thread Eduardo Habkost
This is an example script that can be used to help generate a config file that will reproduce a given CPU model from QEMU. The generated config file can be loaded using "-readconfig" to make QEMU create CPUs that will look exactly like the one used when cpu-model-dump was run. A --self-test mode i

[Qemu-devel] [RFC 1/2] target-i386: Introduce "-cpu custom"

2015-04-13 Thread Eduardo Habkost
Now that we can configure everything in a CPU using QOM properties, add a new CPU model name that won't load anything from the CPU model table. That means no CPUID field will be initialized with any data that depends on CPU model name, machine-type, or accelerator. This will allow management softw

[Qemu-devel] [RFC 0/2] target-i386: "custom" CPU model + script to dump existing CPU models

2015-04-13 Thread Eduardo Habkost
The problem: The existing libvirt APIs assume that if a given CPU model is runnable in a host kernel+hardware combination, it will be always runnable on that host even if the machine-type changes. That assumption is implied in some of libvirt interfaces, for example, at: 1) Host capabilities, wh

Re: [Qemu-devel] [PATCH RFC 15/19] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue()

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 58 > > 1 file changed, 24 insertions(+), 34 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-91

Re: [Qemu-devel] [PATCH RFC 14/19] qapi: Drop pointless flush() before close()

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.as

Re: [Qemu-devel] [PATCH RFC 13/19] qapi: Factor open_output(), close_output() out of generators

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 101 > +-- > scripts/qapi-event.py| 85 --- > scripts/qapi-types.py| 81 ---

Re: [Qemu-devel] [PATCH RFC 12/19] qapi: Turn generators' mandatory option -i into an argument

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Mandatory option is silly, and the error handling is missing: the > programs crash when -i isn't supplied. Make it an argument, and check > it properly. > > Signed-off-by: Markus Armbruster > --- > Makefile| 14 +++--- > scripts

Re: [Qemu-devel] [PATCH RFC 11/19] qapi: Fix generators to report command line errors decently

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Report to stderr, prefix with the program name. Also reject > extra arguments. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake

Re: [Qemu-devel] [PATCH RFC 10/19] qapi: Factor parse_command_line() out of the generators

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 34 +++--- > scripts/qapi-event.py| 32 +--- > scripts/qapi-types.py| 36 > s

Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Anything but --type sync (which is the default) suppresses output > entirely, which makes no sense. > > Dates back to the initial commit c17d990. Commit message says > "Currently only generators for synchronous qapi/qmp functions are > supported"

Re: [Qemu-devel] [PATCH RFC 08/19] qapi: qapi-event.py option -b does nothing, drop it

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > Makefile | 2 +- > scripts/qapi-event.py | 7 ++- > 2 files changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Lib

Re: [Qemu-devel] [PATCH RFC 07/19] qapi: Move camel_to_upper(), c_enum_const() to closely related code

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 50 +- > 1 file changed, 25 insertions(+), 25 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3

Re: [Qemu-devel] [PATCH RFC 06/19] qapi: Use c_enum_const() in generate_alternate_qtypes()

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Missed in commit b0b5819. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi-types.py | 6 ++ > scripts/qapi.py | 11 --- > 2 files changed, 2 insertions(+), 15 deletions(-) Reviewed-by: Eric Blake although I think I

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Nadav Amit
Paolo Bonzini wrote: > > > On 13/04/2015 01:32, Nadav Amit wrote: >> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { > > The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not > KVM_CAP_ENABLE_CAP_VM. > > Paolo > >> +ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUI

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Nadav Amit
Paolo Bonzini wrote: > > > On 13/04/2015 16:17, Nadav Amit wrote: >> Paolo Bonzini wrote: >> >>> On 13/04/2015 01:32, Nadav Amit wrote: +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { >>> >>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not >>> KVM_CAP_ENABLE_

Re: [Qemu-devel] Failing iotests in v2.3.0-rc2 / master

2015-04-13 Thread Andreas Färber
Am 13.04.2015 um 17:29 schrieb John Snow: > On 04/10/2015 11:41 PM, Andreas Färber wrote: >> Hi, >> >> 001 seems to hang for -qcow (or is not reasonably "quick": >5 min). >> > > I assume this was a one-off and you cannot reproduce it reliably. No, I could reproduce it both locally and in our buil

Re: [Qemu-devel] [PATCH v4 19/20] iotests: add simple incremental backup case

2015-04-13 Thread Max Reitz
On 06.04.2015 23:49, John Snow wrote: On 04/02/2015 10:27 AM, Stefan Hajnoczi wrote: On Fri, Mar 20, 2015 at 03:17:02PM -0400, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/124 | 153 + tests/qemu-iotests/124.out | 4 +

Re: [Qemu-devel] Failing iotests in v2.3.0-rc2 / master

2015-04-13 Thread Paolo Bonzini
On 11/04/2015 16:33, Andreas Färber wrote: > 067 is failing for -qcow2 on ppc64 (no $QEMU_PROG => qemu-system-ppc64). > Seems to hang after the below output. It really needs a PC machine, it seems. Paolo

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 18:00, Corey Minyard wrote: > On 04/13/2015 08:44 AM, Paolo Bonzini wrote: >> >> On 13/04/2015 03:30, Corey Minyard wrote: Hmm, I don't see patch 15/15 so I don't know how this is used. >>> Yeah, I resent and I don't know what's happened. All the others were >>> sent exactly t

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 18:34, Corey Minyard wrote: > > > I made this the same as the ACPI code, which you have to have as a > > > callback if you are adding it to a common SSDT. > > > > Not really I think. > > The AML functions require that you have a tree to attach what you are > adding. If you did your

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Corey Minyard
On 04/13/2015 02:00 AM, Michael S. Tsirkin wrote: > On Sun, Apr 12, 2015 at 08:26:46PM -0500, Corey Minyard wrote: >> On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: >>> On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: From: Corey Minyard There was no way to direct

Re: [Qemu-devel] [V9fs-developer] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2015-04-13 Thread Eric Van Hensbergen
Well, technically fid 3 isn't 'open', only fid 2 is open - at least according to the protocol. fid 3 and fid 2 are both clones of fid 1. However, thanks for the alternative workaround. If you get a chance, can you check that my change to the client to partially fix this for the other servers does

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Corey Minyard
On 04/13/2015 08:44 AM, Paolo Bonzini wrote: > > On 13/04/2015 03:30, Corey Minyard wrote: >>> Hmm, I don't see patch 15/15 so I don't know how this is used. >> Yeah, I resent and I don't know what's happened. All the others were >> sent exactly the same way. Something doesn't like that patch. >

Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-13 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Add PCIe controller in ACPI DSDT table, so the guest can detect > the PCIe. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 140 > +++ > 1 file changed,

Re: [Qemu-devel] [PATCH v4 18/20] hw/acpi/aml-build: Add aml_dword_io() term

2015-04-13 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/acpi/aml-build.c | 17 + > include/hw/acpi/aml-build.h | 5 + > 2 files changed, 22 insertions(+) > > diff --git a/hw/ac

Re: [Qemu-devel] [PATCH v4 17/20] hw/acpi/aml-build: Add aml_create_dword_field() term

2015-04-13 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/acpi/aml-build.c | 11 +++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/hw/acpi/aml-bui

Re: [Qemu-devel] [PATCH v4 15/20] hw/acpi/aml-build: Add aml_not() term

2015-04-13 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/acpi/aml-build.c | 9 + > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term

2015-04-13 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao I was considering if the magic numbers should be defined somewhere but I guess that is the point of the stub functions. Reviewed-by: Alex Bennée > --- > hw/acpi/aml-build.c |

Re: [Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output

2015-04-13 Thread Peter Maydell
On 13 April 2015 at 16:37, Alex Bennée wrote: > I'm not so sure about this. Shouldn't we be being a lot quieter by > default. At the moment the TCG tests are very noisy with their output > compared to the rest of the tests. On a V=0 run I expect just to see > test name and a PASS/FAIL. Yes, this

Re: [Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output

2015-04-13 Thread Alex Bennée
Andreas Färber writes: > Executing the binary pi_10.com terminates without a trailing newline. > > As it does not seem to be caused by the runcom program and since we > can't easily fix pi_10.com, add an echo after executing it. This places > "make:" output (or that of a target following it) on

Re: [Qemu-devel] [PATCH for-2.3? 5/7] tests/tcg: Fix run-runcom target

2015-04-13 Thread Alex Bennée
Andreas Färber writes: > The path had not been updated after relocating the TCG tests. > > Fix this to allow executing the test via `make -C tests/tcg run-runcom`. > > Signed-off-by: Andreas Färber Reviewed-by: Alex Bennée > --- > tests/tcg/Makefile | 2 +- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH for-2.3? 4/7] tests/tcg: Fix running x86_64 tests

2015-04-13 Thread Alex Bennée
Andreas Färber writes: > When ARCH != i386, the wrong test target was being added to the list of > tests to run. Fix this to have test-x86_64 run as well. > > Note that test-x86_64 produces two build warnings on gcc 4.8.3, but we > don't use -Werror for these tests: > > test-i386.c:2110:1: war

Re: [Qemu-devel] [PATCH for-2.3? 2/7] tests/tcg: Fix linux-test build

2015-04-13 Thread Alex Bennée
Andreas Färber writes: > Include a missing system header for struct rusage / getrusage(). > > Signed-off-by: Andreas Färber Reviewed-by: Alex Bennée > --- > tests/tcg/linux-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c > inde

Re: [Qemu-devel] Failing iotests in v2.3.0-rc2 / master

2015-04-13 Thread John Snow
On 04/10/2015 11:41 PM, Andreas Färber wrote: Hi, 001 seems to hang for -qcow (or is not reasonably "quick": >5 min). I assume this was a one-off and you cannot reproduce it reliably. Do you have any data on what call it might have hung on? 033 is failing for -vhdx. (Note that `make che

[Qemu-devel] [PATCH] qemu-config: remove stray inclusions of hw/ files

2015-04-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- util/qemu-config.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index 2d32ce7..fba511a 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -3,10 +3,8 @@ #include "qemu/option.h" #include "qemu/config-file.h

[Qemu-devel] [PATCH] range: remove useless inclusions

2015-04-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- dma-helpers.c | 1 - hw/acpi/pcihp.c | 1 - hw/i386/acpi-build.c | 1 - include/hw/i386/ich9.h| 1 - include/hw/pci-host/q35.h | 1 - 5 files changed, 5 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 6918572..f43a5a7

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-04-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 13/04/2015 13:35, Dr. David Alan Gilbert wrote: > >>> +qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); > >>> > >>> > > +*old_vm_running = runstate_is_running(); > > > >> > > > > >> > I think that needs some expla

Re: [Qemu-devel] [PATCH 2/3] tpm: Probe for connected TPM 1.2 or TPM 2

2015-04-13 Thread Stefan Berger
Eric Blake wrote on 04/13/2015 10:43:40 AM: > From: Eric Blake > To: Stefan Berger , "Xu, Quan" > , "qemu-devel@nongnu.org" de...@nongnu.org>, "m...@redhat.com" > Cc: Stefan Berger/Watson/IBM@IBMUS > Date: 04/13/2015 10:43 AM > Subject: Re: [Qemu-devel] [PATCH 2/3] tpm: Probe for connected TP

Re: [Qemu-devel] [RFC PATCH v2 21/23] spapr: Initialize hotplug memory address space

2015-04-13 Thread Igor Mammedov
On Mon, 13 Apr 2015 19:57:05 +0530 Bharata B Rao wrote: > On Mon, Apr 13, 2015 at 04:04:24PM +0200, Igor Mammedov wrote: > > On Mon, 13 Apr 2015 08:29:33 +0530 > > Bharata B Rao wrote: > > > > > On Wed, Mar 25, 2015 at 04:58:18PM +1100, David Gibson wrote: > > > > On Mon, Mar 23, 2015 at 07:06:

Re: [Qemu-devel] [PATCH 2/3] tpm: Probe for connected TPM 1.2 or TPM 2

2015-04-13 Thread Eric Blake
On 04/12/2015 02:59 PM, Stefan Berger wrote: > On 04/07/2015 04:54 AM, Xu, Quan wrote: >> >> In my opinion, I prefer to point out tpm_version in QEMU command line >> options, then >> tpm_util_test_tpmdev() tries to verify it. > > The only reason why I am not doing this was that libvirt for exampl

Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 16:40, Eric Blake wrote: +## >>> +# @MEM_UNPLUG_ERROR >>> +# >>> +# Emitted when memory hot unplug error occurs. >>> +# >>> +# @device: device name >>> +# >>> +# @msg: Informative message >>> >> Any reason you abbreviated instead of spelling i

Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error

2015-04-13 Thread Eric Blake
On 04/12/2015 07:56 PM, Zhu Guihua wrote: > > On 04/10/2015 11:37 PM, Eric Blake wrote: >> On 04/02/2015 03:50 AM, Zhu Guihua wrote: >>> When memory hot unplug fails, this patch adds support to send >>> QMP event to notify mgmt about this failure. >>> >>> Signed-off-by: Zhu Guihua >>> --- >>> d

Re: [Qemu-devel] [PATCH RFC 05/19] qapi: Simplify c_enum_const()

2015-04-13 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index e1c5ef2..3601d1d 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.p

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 16:33, Nadav Amit wrote: >>> >> Of course… >>> >> Do you want a v2 now, later (after 4.2), or would you change it yourself? >> > >> > Later, close to 4.2 but not necessarily after it. > Anyhow, in that case the KVM patch is also wrong (not reporting > KVM_CAP_DISABLE_QUIRKS is supp

Re: [Qemu-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 16:12, Liang Li wrote: > 2. Do the attach and detach operation with a time interval. eg. 10s. > > The error message will not disappear if retry, in this case, it's > a bug. > > In the 'xen_pt_region_add' and 'xen_pt_region_del', we should only care > about the 'xen-pc

Re: [Qemu-devel] [RFC PATCH v2 21/23] spapr: Initialize hotplug memory address space

2015-04-13 Thread Bharata B Rao
On Mon, Apr 13, 2015 at 04:04:24PM +0200, Igor Mammedov wrote: > On Mon, 13 Apr 2015 08:29:33 +0530 > Bharata B Rao wrote: > > > On Wed, Mar 25, 2015 at 04:58:18PM +1100, David Gibson wrote: > > > On Mon, Mar 23, 2015 at 07:06:02PM +0530, Bharata B Rao wrote: > > > > Initialize a hotplug memory r

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 16:17, Nadav Amit wrote: > Paolo Bonzini wrote: > >> >> >> On 13/04/2015 01:32, Nadav Amit wrote: >>> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { >> >> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not >> KVM_CAP_ENABLE_CAP_VM. >> >> Paolo >> >>> +

[Qemu-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-13 Thread Liang Li
Use the option like 'pci=[ '07:10,1', '0b:10.1', '81:10.1']' in HVM guest configuration file to assign more than one VF PCI devices to a guest, after the guest boot up, detach the VFs in sequence by 'xl pci-detach $DOM_ID $VF_BDF', and then attach the VFs by 'xl pci-attach $DOM_ID $VF_BDF' in seque

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Cornelia Huck
On Mon, 13 Apr 2015 13:26:31 +0200 "Michael S. Tsirkin" wrote: > BTW I suspect the stats code is broken for > cross-endian platforms: it should do LE unconditinally, > should it not? Stats are guest-endian for legacy, so no. Only the config space is always LE.

Re: [Qemu-devel] [RFC PATCH v2 21/23] spapr: Initialize hotplug memory address space

2015-04-13 Thread Igor Mammedov
On Mon, 13 Apr 2015 08:29:33 +0530 Bharata B Rao wrote: > On Wed, Mar 25, 2015 at 04:58:18PM +1100, David Gibson wrote: > > On Mon, Mar 23, 2015 at 07:06:02PM +0530, Bharata B Rao wrote: > > > Initialize a hotplug memory region under which all the hotplugged > > > memory is accommodated. Also ena

[Qemu-devel] [PATCH v5 10/17] target-s390x: Add S390 CPU model alias definition routines

2015-04-13 Thread Michael Mueller
This patch implements the infrastructure to dynamically add CPU model aliases. Signed-off-by: Michael Mueller Reviewed-by: Cornelia Huck --- target-s390x/cpu-models.c | 82 +++ target-s390x/cpu-models.h | 13 target-s390x/cpu.c| 1 +

Re: [Qemu-devel] [RFC PATCH v2 23/23] spapr: Memory hotplug support

2015-04-13 Thread Igor Mammedov
On Mon, 13 Apr 2015 08:33:16 +0530 Bharata B Rao wrote: > On Thu, Mar 26, 2015 at 02:57:45PM +1100, David Gibson wrote: > > On Mon, Mar 23, 2015 at 07:06:04PM +0530, Bharata B Rao wrote: > > > Make use of pc-dimm infrastructure to support memory hotplug > > > for PowerPC. > > > > > > Modelled on

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 01:32, Nadav Amit wrote: > +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not KVM_CAP_ENABLE_CAP_VM. Paolo > +ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0, > +

Re: [Qemu-devel] [PATCH for-2.3? 0/7] tests: Fix TCG make test

2015-04-13 Thread Peter Maydell
On 13 April 2015 at 12:36, Peter Maydell wrote: > On 11 April 2015 at 19:34, Andreas Färber wrote: >> Hello, >> >> In my quest to improve our test coverage, in light of the recent cpu_copy() >> breakage, >> I've taken a stab at make test and actually managed to get most of it to >> work on x86_

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 01:32, Nadav Amit wrote: > Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone > and therefore this hack is no longer needed. Since it violates the > specifications, it is removed. > > Signed-off-by: Nadav Amit > --- > hw/intc/apic_common.c | 9 ---

[Qemu-devel] [PATCH v5 13/17] target-s390x: Prepare accelerator during S390 CPU object realization

2015-04-13 Thread Michael Mueller
This patch implements routine s390_cpu_model_init(). It is called by the realize function during instantiation of an CPU object. Its task is to initialize the current accelerator with the properties of the selected processor model. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c | 3

[Qemu-devel] [Bug 1443462] [NEW] alt-gr not working with non-US keyboard

2015-04-13 Thread Mr J
Public bug reported: When using a non-US keyboard language through vnc and websockets, Alt-Gr keyboard combinations do not work. According to https://github.com/kanaka/noVNC/issues/406, this is a QEMU issue. Tested with Qemu 2.2.1 ** Affects: qemu Importance: Undecided Status: New

[Qemu-devel] [PATCH v5 12/17] target-s390x: Add S390 CPU class initialization routines

2015-04-13 Thread Michael Mueller
This patch provides routines to dynamically update the previously defined S390 CPU classes in the current host context. The main function performing this process is s390_setup_cpu_classes(). It takes the current host context and a facility list mask as parameter to setup the classes accordingly. It

[Qemu-devel] [PATCH v5 14/17] target-s390x: Initialize S390 CPU model name in CPUState

2015-04-13 Thread Michael Mueller
The cpu model name now gets initialized during CPU instance initialization. Signed-off-by: Michael Mueller --- target-s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 65dee3e..771acbd 100644 --- a/target-s390x/cpu.c +++ b/target-s390x/

[Qemu-devel] [PATCH v5 01/17] Introduce stub routine cpu_desc_avail

2015-04-13 Thread Michael Mueller
This patch introduces the function cpu_desc_avail() which returns by default true if not architecture specific implemented. Its intention is to indicate if the cpu model description is available for display by list_cpus(). This change allows cpu model descriptions to become dynamically created by e

[Qemu-devel] [PATCH v5 07/17] target-s390x: Generate facility defines per S390 CPU model

2015-04-13 Thread Michael Mueller
This patch introduces the helper "gen-facilities" which allows to generate facility list definitions and masks at compile time. Its flexibility is better and the error-proneness is lower when compared to static programming time added statements. The helper includes "target-s390x/cpu-facilities.h"

[Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-04-13 Thread Michael Mueller
This patch implements the QMP command 'query-cpu-definitions' in the S390 context. The command returns a list of cpu definitions in the current host context. A runnable and migratable cpu model has the related attributes set to true. The order attribute is used to bring the listed cpu definitions i

[Qemu-devel] [PATCH v5 09/17] target-s390x: Define S390 CPU model specific facility lists

2015-04-13 Thread Michael Mueller
This patch defines S390 CPU facilities and their presence at the different CPU model levels. Beside defining a base which facilities have to be requested per CPU model, these sets are associated to the defined CPU classes and used to calculate the list of supported CPU models in context of the curr

[Qemu-devel] [PATCH v5 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-04-13 Thread Michael Mueller
The QMP command query-cpus now additionally displays a model name and the backing accelerator. Both are omitted if the model name is not initialized. request: { "execute" : "query-cpus" } answer: { { "current": true, "CPU": 0, "model": "2827-ga2", "halted": fal

[Qemu-devel] [PATCH v5 17/17] target-s390x: Enable S390 CPU model usage

2015-04-13 Thread Michael Mueller
This patch enables QEMU to instantiate S390 CPUs with CPU model types. Signed-off-by: Michael Mueller --- hw/s390x/s390-virtio.c | 12 +++- target-s390x/helper.c | 9 ++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio

[Qemu-devel] [PATCH v5 00/17] s390x cpu model implementation

2015-04-13 Thread Michael Mueller
This patch set in combination with its kernel kvm patch set proposes an implementation of S390 CPU models. The origin of this item is to provide a means for management interfaces like libvirt to draw decisions if life guest migration to a target hypervisor is reasonable. A migration constraint is

[Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-13 Thread Michael Mueller
The patch implements routines to set and retrieve processor configuration data and to retrieve machine configuration data. The machine related data is used together with the CPU model facility lists to determine the list of supported CPU models of this host. The above mentioned routines have QEMU t

[Qemu-devel] [PATCH v5 02/17] Add accelerator id and model name to CPUState

2015-04-13 Thread Michael Mueller
The patch defines ids per accelerator and adds the accel_id and the model_name to the CPUState. The accel_id is initialized by common code, the model name needs to be initialized by target specific code. Signed-off-by: Michael Mueller --- include/qom/cpu.h | 5 + qapi-schema.json | 9

[Qemu-devel] [PATCH v5 08/17] target-s390x: Introduce S390 CPU models

2015-04-13 Thread Michael Mueller
This patch implements the static part of the S390 CPU class definitions. It defines S390 CPU models by means of virtual CPU ids (enum) which contain information on the CPU generation, the machine class, the GA number and the machine type. The CPU id is used to instantiate a CPU class per CPU model.

[Qemu-devel] [PATCH v5 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-04-13 Thread Michael Mueller
The HMP command info cpus now displays the CPU model name and the backing accelerator if part of the CPUState. (qemu) info cpus * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 Signed-off-by: Michael Mueller --- hmp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hmp.c b/

[Qemu-devel] [PATCH v5 06/17] target-s390x: Introduce S390 CPU facilities

2015-04-13 Thread Michael Mueller
The patch introduces S390 CPU facility bit numbers and names as well as the architectural facility size limit in bytes. Signed-off-by: Michael Mueller --- target-s390x/cpu-facilities.h | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 target-s

[Qemu-devel] [PATCH v2 01/14] memory: Define API for MemoryRegionOps to take attrs and return status

2015-04-13 Thread Peter Maydell
Define an API so that devices can register MemoryRegionOps whose read and write callback functions are passed an arbitrary pointer to some transaction attributes and can return a success-or-failure status code. This will allow us to model devices which: * behave differently for ARM Secure/NonSecur

[Qemu-devel] [PATCH v5 16/17] target-s390x: Introduce S390 CPU facility test routine

2015-04-13 Thread Michael Mueller
The patch introduces routine s390_facility_test() which allows to verify if a specific facility bit is set. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c | 29 + target-s390x/cpu-models.h | 1 + 2 files changed, 30 insertions(+) diff --git a/target-s3

[Qemu-devel] [PATCH v5 05/17] Add optional parameters to QMP command query-cpu-definitions

2015-04-13 Thread Michael Mueller
The patch adds optional parameters to the QMP command query-cpu-definitions. Thus the signature of routine arch_query_cpu_definitions needs to be changed for the stub function and all target implementations: target-arm target-i386 target-ppc target-s390 Signed-off-by: Michael Mueller --- includ

Re: [Qemu-devel] Very poor IO performance which looks like some design problem.

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 14:28, ein wrote: > > > Check out my update please: > http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg01318.html > > Using aio=native,cache=none results in 500%-2000% performance drop > comparing to bare metal and 300%-1000% comparing to > aio=threads,cache=unsafe. No

[Qemu-devel] [PATCH v2 09/14] Switch non-CPU callers from ld/st*_phys to address_space_ld/st*

2015-04-13 Thread Peter Maydell
Switch all the uses of ld/st*_phys to address_space_ld/st*, except for those cases where the address space is the CPU's (ie cs->as). This was done with the following script which generates a Coccinelle patch. A few over-80-columns lines in the result were rewrapped by hand where Coccinelle failed

[Qemu-devel] [PATCH v2 00/14] Add memory attributes and use them in ARM

2015-04-13 Thread Peter Maydell
I've included both the changes to the core memory system code and the target-arm changes as a usage example, but the ARM stuff is all at the end of the series, so if we want to split it and take it via separate subtrees that's fine. There are not many changes between v1 and v2 here: Changes v1->v

[Qemu-devel] [PATCH v2 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-13 Thread Peter Maydell
Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias --- dma-helpers.c| 3 ++- exec.c | 51 ++--

[Qemu-devel] [PATCH v2 12/14] target-arm: Add user-mode transaction attribute

2015-04-13 Thread Peter Maydell
Add a transaction attribute indicating that a memory access is being done from user-mode (unprivileged). This corresponds to an equivalent signal in ARM AMBA buses. Signed-off-by: Peter Maydell --- include/exec/memattrs.h | 2 ++ target-arm/helper.c | 1 + 2 files changed, 3 insertions(+) d

[Qemu-devel] [PATCH v2 13/14] target-arm: Use attribute info to handle user-only watchpoints

2015-04-13 Thread Peter Maydell
Now that we have memory access attribute information in the watchpoint checking code, we can correctly implement handling of watchpoints which should match only on userspace accesses, where LDRT/STRT/LDT/STT from EL1 are treated as userspace accesses. Signed-off-by: Peter Maydell Reviewed-by: Edg

[Qemu-devel] [PATCH v2 08/14] exec.c: Capture the memory attributes for a watchpoint hit

2015-04-13 Thread Peter Maydell
Capture the memory attributes for the transaction which triggered a watchpoint; this allows CPU specific code to implement features like ARM's "user-mode only WPs also hit for LDRT/STRT accesses made from privileged code". This change also correctly passes through the memory attributes to the under

[Qemu-devel] [PATCH v2 05/14] exec.c: Convert subpage memory ops to _with_attrs

2015-04-13 Thread Peter Maydell
Convert the subpage memory ops to _with_attrs; this will allow us to pass the attributes through to the underlying access functions. (Nothing uses the attributes yet.) Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias --- exec.c | 33 +--

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 13:32, Michael S. Tsirkin wrote: So you are suggesting each device add it's own SSDT? I'm not sure how that helps debugging, it seems simpler to add it to a common one. >>> >>> For example, it's easier to write a unit test: encode something specific >>> in one of the IDs

  1   2   >