On 13/04/2015 16:40, Eric Blake wrote: >>>> +## >>>> >>> +# @MEM_UNPLUG_ERROR >>>> >>> +# >>>> >>> +# Emitted when memory hot unplug error occurs. >>>> >>> +# >>>> >>> +# @device: device name >>>> >>> +# >>>> >>> +# @msg: Informative message >>> >> Any reason you abbreviated instead of spelling it out as 'message'? >> > >> > This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED >> > in docs/qmp/qmp-events.txt. > Just because existing code abbreviated does not mean that new code needs > to copy the bad example.
To some extent it does; consistency is a good thing to have. So I think "msg" is okay here. Paolo
