Re: [Qemu-devel] [PATCH qemu v5 04/12] spapr_pci_vfio: Enable multiple groups per container

2015-04-08 Thread David Gibson
On Wed, Apr 08, 2015 at 01:45:19PM +1000, Alexey Kardashevskiy wrote: > On 04/08/2015 12:01 PM, David Gibson wrote: > >On Tue, Mar 31, 2015 at 04:28:39PM +1100, Alexey Kardashevskiy wrote: > >>This enables multiple IOMMU groups in one VFIO container which means > >>that multiple devices from differ

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-08 Thread Peter Lieven
Am 07.04.2015 um 22:05 schrieb Paolo Bonzini: On 07/04/2015 20:44, Peter Lieven wrote: Has the cdrom the power of taking down the bus? IDE can only issue one command per bus, so hda/hdb can take down each other, and hdc/hdd can take down each other. However, hda cannot take down hdc and vice

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-08 Thread Peter Lieven
Am 07.04.2015 um 21:13 schrieb John Snow: On 04/07/2015 03:02 PM, Peter Lieven wrote: Am 07.04.2015 um 20:56 schrieb John Snow: On 04/07/2015 02:44 PM, Peter Lieven wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015

Re: [Qemu-devel] [PATCH v4 05/20] hw/acpi/aml-build: Add aml_interrupt() term

2015-04-08 Thread Shannon Zhao
On 2015/4/8 22:57, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> Add aml_interrupt() for describing device interrupt in resource template. >> These can be used to generating DSDT table for ACPI on ARM. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao

Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-04-08 Thread Shannon Zhao
On 2015/4/8 22:54, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> Add aml_memory32_fixed() for describing device mmio region in resource >> template. >> These can be used to generating DSDT table for ACPI on ARM. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: S

Re: [Qemu-devel] [PATCH v4 03/20] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM

2015-04-08 Thread Shannon Zhao
On 2015/4/8 22:37, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> Introduce a preliminary framework in virt-acpi-build.c with the main >> ACPI build functions. It exposes the generated ACPI contents to >> guest over fw_cfg. >> >> The required ACPI v5.1 tables for ARM

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-08 Thread Stefan Weil
Am 08.04.2015 um 22:27 schrieb Liviu Ionescu: On 08 Apr 2015, at 09:20, Stefan Weil wrote: Here is my package list (from Debian Jessie): ii binutils-mingw-w64-i686 2.22-8+deb7u2+2+deb7u1amd64 Cross-binutils for Win32 (x86) using MinGW-w64 ii binutils-mingw-w64-x86-64 2.22-8+d

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 19/23] spapr: CPU hot unplug support

2015-04-08 Thread Bharata B Rao
On Tue, Apr 07, 2015 at 04:45:17PM +1000, Alexey Kardashevskiy wrote: > On 03/24/2015 12:36 AM, Bharata B Rao wrote: > >Support hot removal of CPU for sPAPR guests by sending the hot > >unplug notification to the guest via EPOW interrupt. > > > >Signed-off-by: Bharata B Rao > >--- > > hw/ppc/spap

Re: [Qemu-devel] [PATCH for-2.3] cris: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-04-08 Thread Edgar E. Iglesias
On Sat, Apr 04, 2015 at 02:15:10PM +0200, Dirk Müller wrote: > Commit 0b183fc871:"memory: move mem_path handling to > memory_region_allocate_system_memory" split memory_region_init_ram and > memory_region_init_ram_from_file. Also it moved mem-path handling a step > up from memory_region_init_ram to

Re: [Qemu-devel] [PULL 22/62] block: Support Archipelago as a QEMU block backend

2015-04-08 Thread Andreas Färber
Am 08.08.2014 um 19:39 schrieb Kevin Wolf: > From: Chrysostomos Nanakos > > VM Image on Archipelago volume is specified like this: > > file.driver=archipelago,file.volume=[,file.mport=[, > file.vport=][,file.segment=]] > > 'archipelago' is the protocol. > > 'mport' is the port number on which

[Qemu-devel] seccomp breakage on arm

2015-04-08 Thread Andreas Färber
Hello, I am seeing the following build failure on openSUSE Tumbleweed armv7l with --enable-seccomp in v2.3.0-rc2: [ 551s] In file included from qemu-seccomp.c:16:0: [ 551s] /usr/include/libseccomp/seccomp.h:177:23: error: '__NR_mmap' undeclared here (not in a function) [ 551s] #define SCMP_SY

Re: [Qemu-devel] [PATCH v4 07/20] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-04-08 Thread Shannon Zhao
On 2015/4/9 2:53, Michael S. Tsirkin wrote: > On Fri, Apr 03, 2015 at 06:03:39PM +0800, Shannon Zhao wrote: >> @@ -135,6 +138,43 @@ struct AcpiFadtDescriptorRev1 >> } QEMU_PACKED; >> typedef struct AcpiFadtDescriptorRev1 AcpiFadtDescriptorRev1; >> >> +struct acpi_generic_address { >> +uint8

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v2] vhost-user: add multi queue support

2015-04-08 Thread Ouyang, Changchun
Hi guys, > -Original Message- > From: snabb-de...@googlegroups.com [mailto:snabb- > de...@googlegroups.com] On Behalf Of Michael S. Tsirkin > Sent: Monday, April 6, 2015 11:07 PM > To: Nikolay Nikolaev > Cc: Long, Thomas; snabb-de...@googlegroups.com; ebl...@redhat.com; > qemu-devel@nongnu

Re: [Qemu-devel] [PATCH] kvm: fix slot flags sync between Qemu and KVM

2015-04-08 Thread Xiao Guangrong
On 04/08/2015 06:46 PM, Paolo Bonzini wrote: On 08/04/2015 08:34, Xiao Guangrong wrote: We noticed that KVM keeps tracking dirty for the memslots when live migration failed which causes bad performance due to huge page mapping disallowed for this kind of memslot It is caused by slot flags d

Re: [Qemu-devel] [PATCH] tcg/tcg-op.c: Fix ld/st of 64 bit values on 32-bit bigendian hosts

2015-04-08 Thread Richard Henderson
On 04/08/2015 12:57 PM, Peter Maydell wrote: > Switch the ifdef back to HOST_WORDS_BIGENDIAN. > > Signed-off-by: Peter Maydell Doh. Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support

2015-04-08 Thread Zhu Guihua
On 04/08/2015 06:47 PM, Paulo Ricardo Paz Vital wrote: On Wed, 2015-04-08 at 11:52 +0200, Michael S. Tsirkin wrote: On Wed, Apr 08, 2015 at 05:49:42PM +0800, Zhu Guihua wrote: Ping... It's only been 4 days. We are finalizing 2.3 so pls sit tight. I agree with Michael, it's time to close 2.3

[Qemu-devel] [Bug 1441775] Re: possible null pointer dereference in qemuDomainPinEmulator()

2015-04-08 Thread Eric Blake
** Project changed: qemu => libvirt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1441775 Title: possible null pointer dereference in qemuDomainPinEmulator() Status in libvirt virtualization API:

Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-04-08 Thread Eric Blake
On 04/08/2015 03:29 AM, Alberto Garcia wrote: > Since this event can occur in nodes that cannot have a device name > associated, include also a field with the node name. > > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 8 ++-- > docs/qmp/qmp-events.txt | 21 +-

Re: [Qemu-devel] [PATCH] qemu-config: Accept empty option values

2015-04-08 Thread Eric Blake
On 04/08/2015 12:16 PM, Eduardo Habkost wrote: > Currently it is impossible to set an option in a config file to an empty > string, because the parser matches only lines containing non-empty > strings between double-quotes. > > As sscanf() "[" conversion specifier only matches non-empty strings, a

[Qemu-devel] [PATCH v5 18/21] iotests: add QMP event waiting queue

2015-04-08 Thread John Snow
A filter is added to allow callers to request very specific events to be pulled from the event queue, while leaving undesired events still in the stream. This allows to poll for completion data for multiple asynchronous events in any arbitrary order. A new timeout context is added to the qmp pull

[Qemu-devel] [PATCH v5 19/21] iotests: add simple incremental backup case

2015-04-08 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/124 | 174 +++-- tests/qemu-iotests/124.out | 4 +- 2 files changed, 172 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124 index 85675ec..5c3b434 100644 --- a/te

[Qemu-devel] [PATCH v5 17/21] iotests: add invalid input incremental backup tests

2015-04-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/124 | 104 + tests/qemu-iotests/124.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 110 insertions(+) create mode 100644 tests

[Qemu-devel] [PATCH v5 20/21] iotests: add incremental backup failure recovery test

2015-04-08 Thread John Snow
Test the failure case for incremental backups. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 57 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-io

[Qemu-devel] [PATCH v5 14/21] block: Ensure consistent bitmap function prototypes

2015-04-08 Thread John Snow
We often don't need the BlockDriverState for functions that operate on bitmaps. Remove it. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- block.c | 13 ++--- block/backup.c| 2 +- block/mirror.c| 26 ++

[Qemu-devel] [PATCH v5 21/21] iotests: add incremental backup granularity tests

2015-04-08 Thread John Snow
Test what happens if you fiddle with the granularity. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 58 +- tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 49 insertions(+), 13 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests

[Qemu-devel] [PATCH v5 11/21] qmp: add block-dirty-bitmap-clear

2015-04-08 Thread John Snow
Add bdrv_clear_dirty_bitmap and a matching QMP command, qmp_block_dirty_bitmap_clear that enables a user to reset the bitmap attached to a drive. This allows us to reset a bitmap in the event of a full drive backup. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi -

[Qemu-devel] [PATCH v5 16/21] hbitmap: truncate tests

2015-04-08 Thread John Snow
The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking by different amounts: - Less than the granularity - Less than the granularity, but across a boundary - Less than sizeof(unsigned

[Qemu-devel] [PATCH v5 10/21] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-04-08 Thread John Snow
For "dirty-bitmap" sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of "top" sync mode. Signed-off-by: Fam Zheng Signed-off-by: John Snow --- block.c

[Qemu-devel] [PATCH v5 15/21] block: Resize bitmaps on bdrv_truncate

2015-04-08 Thread John Snow
Signed-off-by: John Snow --- block.c| 18 ++ include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 48 3 files changed, 76 insertions(+) diff --git a/block.c b/block.c index 16209a2..42839a0 100644 --- a/

[Qemu-devel] [PATCH v5 02/21] qapi: Add optional field "name" to block dirty bitmap

2015-04-08 Thread John Snow
From: Fam Zheng This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented

[Qemu-devel] [PATCH v5 13/21] block: add BdrvDirtyBitmap documentation

2015-04-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index c104cdd..843b0bf 100644 --- a/block.c +++ b/block.c @@ -60,11 +60,11 @@ * or enabled. A frozen bi

[Qemu-devel] [PATCH v5 07/21] hbitmap: add hbitmap_merge

2015-04-08 Thread John Snow
We add a bitmap merge operation to assist in error cases where we wish to combine two bitmaps together. This is algorithmically O(bits) provided HBITMAP_LEVELS remains constant. For a full bitmap on a 64bit machine: sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits We may be able to improve

[Qemu-devel] [PATCH v5 12/21] qmp: Add dirty bitmap status field in query-block

2015-04-08 Thread John Snow
Add the "frozen" status booleans, to inform clients when a bitmap is occupied doing a task. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1

[Qemu-devel] [PATCH v5 09/21] block: Add bitmap successors

2015-04-08 Thread John Snow
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On creating a successor, we "freeze" the parent bi

[Qemu-devel] [PATCH v5 04/21] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-04-08 Thread John Snow
The new command pair is added to manage a user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is not specified, we will choose a default granu

[Qemu-devel] [PATCH v5 01/21] docs: incremental backup documentation

2015-04-08 Thread John Snow
Reviewed-by: Max Reitz Signed-off-by: John Snow --- docs/bitmaps.md | 311 1 file changed, 311 insertions(+) create mode 100644 docs/bitmaps.md diff --git a/docs/bitmaps.md b/docs/bitmaps.md new file mode 100644 index 000..ad8c33b --

[Qemu-devel] [PATCH v5 08/21] block: Add bitmap disabled status

2015-04-08 Thread John Snow
Add a status indicating the enabled/disabled state of the bitmap. A bitmap is by default enabled, but you can lock the bitmap into a read-only state by setting disabled = true. A previous version of this patch added a QMP interface for changing the state of the bitmap, but it has since been remove

[Qemu-devel] [PATCH v5 03/21] qmp: Ensure consistent granularity type

2015-04-08 Thread John Snow
We treat this field with a variety of different types everywhere in the code. Now it's just uint32_t. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- block.c | 11 ++- block/mirror.c| 4 ++-- inclu

[Qemu-devel] [PATCH v5 00/21] block: transactionless incremental backup series

2015-04-08 Thread John Snow
I've run out of cheeky jokes for my cover letters. This patchset enables the in-memory part of the incremental backup feature, without transactional support. Support for transactions was separated into a separate series which is also now available on-list. Getting this portion of the series commi

[Qemu-devel] [PATCH v5 06/21] hbitmap: cache array lengths

2015-04-08 Thread John Snow
As a convenience: between incremental backups, bitmap migrations and bitmap persistence we seem to need to recalculate these a lot. Because the lengths are a little bit-twiddly, let's just solidly cache them and be done with it. Reviewed-by: Max Reitz Signed-off-by: John Snow --- util/hbitmap.

[Qemu-devel] [PATCH v5 05/21] block: Introduce bdrv_dirty_bitmap_granularity()

2015-04-08 Thread John Snow
This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block.c | 8 ++-- include/block/block.h | 1 +

Re: [Qemu-devel] [PATCH 0/3] Add support for for GICv2m and MSIs to arm-virt

2015-04-08 Thread Nikolay Nikolaev
On Thu, Apr 9, 2015 at 12:20 AM, Christoffer Dall wrote: > Now when we have a host generic PCIe controller in the virt board, it > would be nice to be able to use MSIs so that we can eventually enable > VHOST with KVM. > > With these patches you can use MSIs with TCG and with KVM, but you still >

[Qemu-devel] [PATCH] translate-all: remove redundant page_find from tb_invalidate_phys_page

2015-04-08 Thread Emilio G. Cota
The callers have just looked up the page descriptor, so there's no point in searching again for it. Signed-off-by: Emilio G. Cota --- translate-all.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/translate-all.c b/translate-all.c index 11763c6..4d05898 100644 --

Re: [Qemu-devel] [PATCH 0/3] Add support for for GICv2m and MSIs to arm-virt

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 22:20, Christoffer Dall wrote: > Now when we have a host generic PCIe controller in the virt board, it > would be nice to be able to use MSIs so that we can eventually enable > VHOST with KVM. > > With these patches you can use MSIs with TCG and with KVM, but you still > need so

[Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt board

2015-04-08 Thread Christoffer Dall
Adding the GICv2m to the virt board should allow us to enable MSIs on the generic PCI host controller, in theory. Signed-off-by: Christoffer Dall --- hw/arm/virt.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/

Re: [Qemu-devel] [PATCH] tcg/tcg-op.c: Fix ld/st of 64 bit values on 32-bit bigendian hosts

2015-04-08 Thread Andreas Färber
Am 08.04.2015 um 21:57 schrieb Peter Maydell: > Commit 951c6300f7 out-of-lined the 32-bit-host versions of > tcg_gen_{ld,st}_i64, but in the process it inadvertently changed > an #ifdef HOST_WORDS_BIGENDIAN to #ifdef TCG_TARGET_WORDS_BIGENDIAN. > Since the latter doesn't get defined anywhere this m

[Qemu-devel] [PATCH 2/3] arm_gicv2m: Add GICv2m widget to support MSIs

2015-04-08 Thread Christoffer Dall
The ARM GICv2m widget is a little device that handle MSI interrupt writes to a trigger register and ties them to a range of interrupt lines wires to the GIC. It has a few status/id registers and the interrupt wires, and that's about it. A board instantiates the device by setting the base SPI numb

[Qemu-devel] [PATCH 0/3] Add support for for GICv2m and MSIs to arm-virt

2015-04-08 Thread Christoffer Dall
Now when we have a host generic PCIe controller in the virt board, it would be nice to be able to use MSIs so that we can eventually enable VHOST with KVM. With these patches you can use MSIs with TCG and with KVM, but you still need some fixes for the mapping of the IRQ index to the GSI number fo

[Qemu-devel] [PATCH 1/3] target-arm: Add GIC phandle to VirtBoardInfo

2015-04-08 Thread Christoffer Dall
Instead of passing the GIC phandle around between functions, add it to the VirtBoardInfo just like we do for the clock_phandle. We are about to add the v2m phandle as well, and it's easier not having to pass around a bunch of phandles, return multiple values from functions, etc. Signed-off-by: Ch

Re: [Qemu-devel] [PATCH v2] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 21:40, Timothy E Baldwin wrote: > Misspelled system call name in macro was causing timerfd_create not > to be supported for the ARM target. > > Signed-off-by: Timothy Edward Baldwin Thanks for the respin. Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v2] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.

2015-04-08 Thread Timothy E Baldwin
Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target. Signed-off-by: Timothy Edward Baldwin --- linux-user/arm/syscall_nr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_n

Re: [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 21:30, Peter Maydell wrote: > On 8 April 2015 at 21:26, Timothy E Baldwin > wrote: >> Misspelled system call name in macro was causing timerfd_create not to be >> supported for the ARM target. >> --- >> linux-user/arm/syscall_nr.h | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 21:26, Timothy E Baldwin wrote: > Misspelled system call name in macro was causing timerfd_create not to be > supported for the ARM target. > --- > linux-user/arm/syscall_nr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/arm/syscall_nr.h

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-08 Thread Liviu Ionescu
> On 08 Apr 2015, at 09:20, Stefan Weil wrote: > > Here is my package list (from Debian Jessie): > > ii binutils-mingw-w64-i686 2.22-8+deb7u2+2+deb7u1amd64 > Cross-binutils for Win32 (x86) using MinGW-w64 > ii binutils-mingw-w64-x86-64 2.22-8+deb7u2+2+deb7u1amd64

[Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.

2015-04-08 Thread Timothy E Baldwin
Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target. --- linux-user/arm/syscall_nr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h index 7d7be7c..53552be 100644 --- a

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-08 Thread Michael Roth
Quoting Peter Maydell (2015-04-08 15:02:49) > The second argument of g_base64_decode() is a 'gsize *', not a > 'size_t *'. Some compilation environments (like building 32-bit PPC > binaries on a PPC64 system) will complain about the mismatch: > > CCqga/commands-posix.o > qga/commands-posix.c

[Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-08 Thread Peter Maydell
The second argument of g_base64_decode() is a 'gsize *', not a 'size_t *'. Some compilation environments (like building 32-bit PPC binaries on a PPC64 system) will complain about the mismatch: CCqga/commands-posix.o qga/commands-posix.c: In function 'qmp_guest_set_user_password': qga/command

[Qemu-devel] [PATCH] tcg/tcg-op.c: Fix ld/st of 64 bit values on 32-bit bigendian hosts

2015-04-08 Thread Peter Maydell
Commit 951c6300f7 out-of-lined the 32-bit-host versions of tcg_gen_{ld,st}_i64, but in the process it inadvertently changed an #ifdef HOST_WORDS_BIGENDIAN to #ifdef TCG_TARGET_WORDS_BIGENDIAN. Since the latter doesn't get defined anywhere this meant we always took the "LE host" codepath, and stored

Re: [Qemu-devel] bios-tables-test failing for x86_64 on ppc

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 20:35, Peter Maydell wrote: > Looking at the generated TCG, I suspect the problem > is that tcg_gen_st_i64() isn't writing the two i32 > input values in the right order for the case where the > host is a 32-bit bigendian system... Yep. Commit 951c6300f7 out-of-lined the 32-bit-

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

2015-04-08 Thread Peter Lieven
Am 08.04.2015 um 21:22 schrieb Stefan Hajnoczi: > On Wed, Apr 8, 2015 at 6:08 PM, ronnie sahlberg > wrote: >> The nice part with the current patch of Peter is that qemu and >> libiscsi can be upgraded/downgraded independently. > That's fine for avoiding hassles for existing apps, like QEMU, and I'

Re: [Qemu-devel] bios-tables-test failing for x86_64 on ppc

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 19:03, Andreas Färber wrote: > I've resorted to setting up a ppc chroot on ppc64, and I can reproduce > that qemu-system-i386 shows SeaBIOS okay, but qemu-system-x86_64 > immediately aborts with the quoted error. Yeah, I can repro on the gcc compile farm's fedora ppc64 box. (I

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

2015-04-08 Thread Stefan Hajnoczi
On Wed, Apr 8, 2015 at 6:08 PM, ronnie sahlberg wrote: > The nice part with the current patch of Peter is that qemu and > libiscsi can be upgraded/downgraded independently. That's fine for avoiding hassles for existing apps, like QEMU, and I'm happy to merge the patch. For the library's API desi

[Qemu-devel] [PATCH v2 4/4] scripts: x86-cpu-model-dump script

2015-04-08 Thread Eduardo Habkost
This is an example script that can be used to help generate a config file that will reproduce a given CPU model from QEMU. The generated config file can be loaded using "-readconfig" to make QEMU create CPUs that will look exactly like the one used when cpu-model-dump was run. A cpu-model-dump-sel

[Qemu-devel] [PATCH v2 1/4] target-i386: Make "level" and "xlevel" properties static

2015-04-08 Thread Eduardo Habkost
Static properties require only 1 line of code, much simpler than the existing code that requires writing new getters/setters. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH v2 2/4] target-i386: X86CPU::xlevel2 QOM property

2015-04-08 Thread Eduardo Habkost
We already have "level" and "xlevel", only "xlevel2" is missing. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini --- target-i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2bbf01d..e657f10 100644 --- a/target

[Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
This uses the feature name arrays to register "feat-*" QOM properties for feature flags. This simply adds the properties so they can be configured using -global, but doesn't change x86_cpu_parse_featurestr() to use them yet. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use "cpuid-" pref

[Qemu-devel] [PATCH v2 0/4] target-i386: Feature properties, sample script for -global/-readconfig

2015-04-08 Thread Eduardo Habkost
This series adds feature flag properties to X86CPU, and adds a sample script to demonstrate how the new properties can be used to give management software more flexibility to control CPU features using -global and -readconfig. While at it, simplify the code for "level" and "xlevel" properties, and

Re: [Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command

2015-04-08 Thread Peter Maydell
On 17 February 2015 at 22:40, Michael Roth wrote: > From: "Daniel P. Berrange" > > Add a new 'guest-set-user-password' command for changing the password > +void qmp_guest_set_user_password(const char *username, > + const char *password, > +

Re: [Qemu-devel] [PATCH v4 07/20] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-04-08 Thread Michael S. Tsirkin
On Fri, Apr 03, 2015 at 06:03:39PM +0800, Shannon Zhao wrote: > @@ -135,6 +138,43 @@ struct AcpiFadtDescriptorRev1 > } QEMU_PACKED; > typedef struct AcpiFadtDescriptorRev1 AcpiFadtDescriptorRev1; > > +struct acpi_generic_address { > +uint8_t space_id;/* Address space where struct or

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-08 Thread Michael S. Tsirkin
On Tue, Apr 07, 2015 at 03:35:57PM +0200, Igor Mammedov wrote: > On Tue, 7 Apr 2015 13:07:31 +0100 > Peter Maydell wrote: > > > On 7 April 2015 at 03:43, Shannon Zhao > > wrote: > > > The ACPI table entry: > > > Method (_CBA, 0, NotSerialized) // _CBA: Configuration > > > Base Addre

Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-04-08 Thread Michael S. Tsirkin
On Wed, Apr 08, 2015 at 03:54:45PM +0100, Alex Bennée wrote: > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > > index 8d01959..fefe7c7 100644 > > --- a/hw/acpi/aml-build.c > > +++ b/hw/acpi/aml-build.c > > @@ -505,6 +505,28 @@ Aml *aml_call4(const char *method, Aml *arg1, Aml > > *arg2

[Qemu-devel] [Bug 1441781] Re: qemuProcessSetEmulatorAffinity() not behaving as expected

2015-04-08 Thread Chris Friesen
** Summary changed: - qemuProcessSetEmulatorAffinity() called before emulator process actually running + qemuProcessSetEmulatorAffinity() not behaving as expected ** Description changed: When running on a 24-CPU host and using vCPU and emulator pinning I've seen cases where the specified em

[Qemu-devel] [Bug 1441781] Re: qemuProcessSetEmulatorAffinity() called before emulator process actually running

2015-04-08 Thread Chris Friesen
** Description changed: - In qemuProcessStart() the code looks like this: + When running on a 24-CPU host and using vCPU and emulator pinning I've + seen cases where the specified emulator pinning isn't applied as + expected. - VIR_DEBUG("Setting cgroup for emulator (if required)"); - i

[Qemu-devel] [PATCH] qemu-config: Accept empty option values

2015-04-08 Thread Eduardo Habkost
Currently it is impossible to set an option in a config file to an empty string, because the parser matches only lines containing non-empty strings between double-quotes. As sscanf() "[" conversion specifier only matches non-empty strings, add a special case for empty strings. Signed-off-by: Edua

[Qemu-devel] [Bug 1395217] Re: Networking in qemu 2.0.0 and beyond is not compatible with Open Solaris (Illumos) 5.11

2015-04-08 Thread Cole Robinson
FWIW there's some other hits on this: Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1040500 Openstack mailing list: http://lists.openstack.org/pipermail/openstack-dev/2014-December/053478.html ** Bug watch added: Red Hat Bugzilla #1040500 https://bugzilla.redhat.com/show_bug.cgi?id=

[Qemu-devel] [Bug 1441781] [NEW] qemuProcessSetEmulatorAffinity() called before emulator process actually running

2015-04-08 Thread Chris Friesen
Public bug reported: In qemuProcessStart() the code looks like this: VIR_DEBUG("Setting cgroup for emulator (if required)"); if (qemuSetupCgroupForEmulator(vm) < 0) goto cleanup; VIR_DEBUG("Setting affinity of emulator threads"); if (qemuProcessSetEmulatorAffinity(vm) < 0

Re: [Qemu-devel] Last call for release-critical fixes for 2.3...

2015-04-08 Thread Andreas Färber
Am 08.04.2015 um 17:20 schrieb Peter Maydell: > It looks like we have perhaps only a few more issues which need fixes > to go into 2.3, so what I'd like to do is hold rc3 until we have them > all fixed and then roll an rc3 which will with luck be our final > release (bar the version number). > > C

[Qemu-devel] [PATCH 4/5] ui/console : remove 'struct' from 'typedef struct' type

2015-04-08 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao --- ui/console.c | 4 ++-- ui/spice-display.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/console.c b/ui/console.c index b15ca87..d8d268c 100644 --- a/ui/console.c +++ b/ui/console.c @@ -269,7 +269,7 @@ void graphic_hw_invalidate(Qe

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

2015-04-08 Thread ronnie sahlberg
On Wed, Apr 8, 2015 at 1:38 AM, Stefan Hajnoczi wrote: > On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: > > Please CC qemu-devel@nongnu.org in the future. All patches must be on > the qemu-devel mailing list so they can be merged (for transparency). > I have added qemu-devel to CC. > >> +

[Qemu-devel] [PATCH 2/5] ui/vnc : fix coding style

2015-04-08 Thread Chih-Min Chao
reported by checkpatch.pl Signed-off-by: Chih-Min Chao --- ui/vnc-auth-vencrypt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/vnc-auth-vencrypt.c b/ui/vnc-auth-vencrypt.c index a420ccb..65f1afa 100644 --- a/ui/vnc-auth-vencrypt.c +++ b/ui/vnc-auth-vencrypt.c

[Qemu-devel] [PATCH 5/5] hw/display : remove 'struct' from 'typedef QXL struct'

2015-04-08 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao --- hw/display/qxl.c | 2 +- ui/spice-display.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index b6d65b9..0cd314c 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -696,7 +696,7 @@ static inli

[Qemu-devel] [PATCH 1/5] bitops : fix coding style

2015-04-08 Thread Chih-Min Chao
don't mix tab and space. The rule is 4 spaces Signed-off-by: Chih-Min Chao --- include/qemu/bitops.h | 61 ++- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 90ca8df..8abdcf9

[Qemu-devel] [PATCH 0/5] fix coding style and use of typedef type

2015-04-08 Thread Chih-Min Chao
patch 1-2 fix the coding style related to space indent and brance position patch 3-5 remove the 'struct' from the type which has been typedef Chih-Min Chao (5): bitops : fix coding style ui/vnc : fix coding style ui/vnc : remove 'struct' of 'typedef struct' ui/c

[Qemu-devel] [PATCH 3/5] ui/vnc : remove 'struct' of 'typedef struct'

2015-04-08 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao --- ui/vnc-auth-vencrypt.c | 4 ++-- ui/vnc-tls.c | 10 +- ui/vnc-ws.c| 4 ++-- ui/vnc.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/ui/vnc-auth-vencrypt.c b/ui/vnc-auth-vencrypt.c index 65f1a

Re: [Qemu-devel] bios-tables-test failing for x86_64 on ppc

2015-04-08 Thread Andreas Färber
Am 08.04.2015 um 17:22 schrieb Peter Maydell: > On 8 April 2015 at 16:19, Andreas Färber wrote: >> Hello, >> >> With rcutorture fixed, I am still seeing the following failure in -rc2. >> It is only for /x86_64/acpi/..., not for /i386/acpi/...; only on ppc >> host, not on ppc64 or ppc64le (so not e

[Qemu-devel] [Bug 1441775] [NEW] possible null pointer dereference in qemuDomainPinEmulator()

2015-04-08 Thread Chris Friesen
Public bug reported: In src/qemu/qemu_driver.c the qemuDomainPinEmulator() routine basically does this virDomainObjPtr vm; if (!(vm = qemuDomObjFromDomain(dom))) goto cleanup; cleanup: qemuDomObjEndAPI(&vm); If "vm" is null, then this will crash. The bug seems to have

Re: [Qemu-devel] Last call for release-critical fixes for 2.3...

2015-04-08 Thread John Snow
On 04/08/2015 11:20 AM, Peter Maydell wrote: It looks like we have perhaps only a few more issues which need fixes to go into 2.3, so what I'd like to do is hold rc3 until we have them all fixed and then roll an rc3 which will with luck be our final release (bar the version number). Can people

Re: [Qemu-devel] [PATCH v2 for-2.3] arm: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-04-08 Thread Peter Maydell
On 4 April 2015 at 13:24, Dirk Müller wrote: > Commit 0b183fc871:"memory: move mem_path handling to > memory_region_allocate_system_memory" split memory_region_init_ram and > memory_region_init_ram_from_file. Also it moved mem-path handling a step > up from memory_region_init_ram to memory_region_

[Qemu-devel] [PATCH 2/2] MAINTAINERS: Change status of X86 to Maintained

2015-04-08 Thread Eduardo Habkost
"Odd Fixes" doesn't reflect the current status of target-i386. We have people looking after it, now. Signed-off-by: Eduardo Habkost --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7db4c00..f714a98 100644 --- a/MAINTAINERS +++ b/

[Qemu-devel] [PATCH 0/2] MAINTAINERS: X86 update

2015-04-08 Thread Eduardo Habkost
Add myself as X86 maintainer, and change its status to "Maintained". Eduardo Habkost (2): MAINTAINERS: Add myself to X86 MAINTAINERS: Change status of X86 to Maintained MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.1.0

[Qemu-devel] [PATCH 1/2] MAINTAINERS: Add myself to X86

2015-04-08 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d7e9ba2..7db4c00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -172,6 +172,7 @@ F: hw/unicore32/ X86 M: Paolo Bonzini M: Richard Henderson +M: Eduardo Habkost

[Qemu-devel] [PATCH] MAINTAINERS: Add myself as NUMA code maintainer

2015-04-08 Thread Eduardo Habkost
The "srat" and "numa" keywords will help get_maintainer.pl catch NUMA-related code in other files too. Signed-off-by: Eduardo Habkost --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d7e9ba2..978e714 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [Qemu-devel] [PATCH v6 02/36] qapi: Document type-safety considerations

2015-04-08 Thread Eric Blake
On 04/04/2015 10:07 PM, Eric Blake wrote: > Go into more details about the various types of valid expressions > in a qapi schema, including tweaks to document fixes being done > later in the current patch series. Also fix some stale and missing > documentation in the QMP specification. > > Signed

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-08 Thread Eric Blake
On 04/08/2015 10:21 AM, Erik Rull wrote: >>> 172.17.48.45 ~ # telnet 127.0.0.1 >>> {"QMP": {"version": {"qemu": {"micro": 0, "minor": 1, "major": 2}, >>> "package": >>> ""}, "capabilities": []}} >> >> You HAVE to use {"execute":"qmp_capabilities"} (possibly with an >> "id":...) as your first

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-04-08 Thread Eric Blake
On 04/08/2015 03:29 AM, Alberto Garcia wrote: > This function gets the device name associated with a BlockDriverState, > or its node name if the device name is empty. > > Signed-off-by: Alberto Garcia > Reviewed-by: Max Reitz > --- > block.c | 9 + > block/quorum.c

Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-04-08 Thread Eric Blake
On 04/08/2015 03:29 AM, Alberto Garcia wrote: > There are several error messages that identify a BlockDriverState by > its device name. However those errors can be produced in nodes that > don't have a device name associated. > > In those cases we should use bdrv_get_device_or_node_name() to fall

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-08 Thread Erik Rull
Hi Eric, > On April 8, 2015 at 6:16 PM Eric Blake wrote: > > > On 04/08/2015 10:10 AM, Erik Rull wrote: > >> > >> My suggestion is to create a script that sends the QMP command > >> "query-status" an then parse the result. The syntax and output is: > >> > >> -> { "execute": "query-status" } > >

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-08 Thread Leon Alrae
On 02/04/2015 17:47, Liviu Ionescu wrote: > >> On 02 Apr 2015, at 17:27, Matthew Fortune wrote: >> >> Liviu Ionescu writes: >>> for completeness: >>> >>> ilg-mbp:gnuarmeclipse-qemu.git ilg$ "/Applications/GNU ARM >>> Eclipse/QEMU/2.2.91-20150402-dev/bin/qemu-system-gnuarmeclipse" - >>> verbo

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-08 Thread Eric Blake
On 04/08/2015 10:10 AM, Erik Rull wrote: >> >> My suggestion is to create a script that sends the QMP command >> "query-status" an then parse the result. The syntax and output is: >> >> -> { "execute": "query-status" } >> <- { "return": { "running": true, "singlestep": false, "status": >> "running"

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-08 Thread Erik Rull
Hello Paulo, > On April 7, 2015 at 3:42 PM Paulo Ricardo Paz Vital > wrote: > > > On Tue, 2015-04-07 at 15:31 +0200, Erik Rull wrote: > > Hi all, > > > > I need a pretty simple way to get the current state of the VM running in > > QEMU - > > I only need the VM state (e.g. running, paused,...).

  1   2   3   >