On 4 April 2015 at 13:24, Dirk Müller <d...@dmllr.de> wrote:
> Commit 0b183fc871:"memory: move mem_path handling to
> memory_region_allocate_system_memory" split memory_region_init_ram and
> memory_region_init_ram_from_file. Also it moved mem-path handling a step
> up from memory_region_init_ram to memory_region_allocate_system_memory.
>
> Therefore for any board that uses memory_region_init_ram directly,
> -mem-path is not supported.
>
> Fix this by replacing memory_region_init_ram with
> memory_region_allocate_system_memory.
>
> Signed-off-by: Dirk Mueller <dmuel...@suse.com>

Applied to master, thanks. PS: you might want to check
your workflow for future patches, because this one had
a bunch of bad linewrapping that was a bit painful to
fix up manually. (Also your From and Signed-off-by have
different email addresses.)

PS: are you planning to submit another patch later for
the exynos boards?

It might also be nice if we could assert() if the board
init code never calls memory_region_allocate_system_memory();
then 'make check' would catch any new board models that
failed to do this, or old boards which we forgot to convert.

thanks
-- PMM

Reply via email to