Re: [Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
On Tue, 03 Feb 2015 16:22:32 +0100 Paolo Bonzini wrote: > > > On 03/02/2015 16:16, Thomas Huth wrote: > > Actually, I'd prefer to keep the "virtual" in the defines for the type > > of operation below: When it comes to s390 storage keys, we likely might > > need some calls for reading and writin

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-03 Thread David Woodhouse
On Tue, 2015-02-03 at 16:19 -0800, David Miller wrote: > From: David Woodhouse > Date: Mon, 02 Feb 2015 07:27:10 + > > > I'm guessing you don't want to push the *whole* management of the TLS > > control connection *and* the UDP transport, and probing the latter with > > keepalives, into the k

Re: [Qemu-devel] [PATCH v2 0/1] dataplane vs. endianness

2015-02-03 Thread David Gibson
On Tue, Jan 27, 2015 at 04:15:23PM +1100, David Gibson wrote: > On Mon, Jan 26, 2015 at 05:26:41PM +0100, Cornelia Huck wrote: > > Stefan: > > > > Here's v2 of my endianness patch for dataplane, with the extraneous > > vdev argument dropped from get_desc(). > > > > I orginally planned to send my

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-03 Thread Teruaki Ishizaki
(2015/02/02 15:52), Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle "block_size_shift" value for calculating VDI object size. When you start qemu, you

Re: [Qemu-devel] [PATCH 4/9] rcu: introduce RCU-enabled QLIST

2015-02-03 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > From: Mike Day > > Add RCU-enabled variants on the existing bsd DQ facility. Each > operation has the same interface as the existing (non-RCU) > version. Also, each operation is implemented as macro. > > Using the RCU-enabled QLIST, existing QLIST user

[Qemu-devel] [PATCH v2 04/12] acpi, mem-hotplug: Add unplug request cb for memory device.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Memory hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds unplug request cb for memory device. Ad

[Qemu-devel] [PATCH v2 06/12] acpi, ich9: Add memory hot unplug request support for ich9.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Call memory unplug request cb in ich9_pm_device_unplug_request_cb(). Signed-off-by: Zhu Guihua --- hw/acpi/ich9.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 5352e19..b85eed4 100644 --- a/hw/acpi/ich9.c ++

[Qemu-devel] [PATCH v2 08/12] acpi, mem-hotplug: Add unplug cb for memory device.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Reset all memory status, and unparent the memory device. Signed-off-by: Zhu Guihua --- hw/acpi/memory_hotplug.c | 34 ++ hw/core/qdev.c | 2 +- include/hw/acpi/memory_hotplug.h | 2 ++ include/hw/qdev-core.h

[Qemu-devel] [PATCH v2 07/12] pc-dimm: Add memory hot unplug request support for pc-dimm.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Implement memory unplug request cb for pc-dimm, and call it in pc_machine_device_unplug_request_cb(). Signed-off-by: Zhu Guihua --- hw/i386/pc.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8

[Qemu-devel] [PATCH v2 11/12] pc-dimm: Add memory hot unplug support for pc-dimm.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Implement unplug cb for pc-dimm. It remove the corresponding memory region, and unregister vmstat. At last, it calls memory unplug cb to reset memory status and do unparenting. Signed-off-by: Zhu Guihua --- hw/i386/pc.c | 20 ++-- 1 file changed, 18 insertions(+

Re: [Qemu-devel] [PATCH 7/9] rcu: prod call_rcu thread when calling synchronize_rcu

2015-02-03 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > call_rcu operates on the principle that either there is a steady stream of > incoming RCU callbacks, or it is not worthwhile to wake up and process the > few that are there. > > This however makes it hard to assert in testcases that all RCU callbacks > a

[Qemu-devel] [PATCH v2 00/12] QEmu memory hot unplug support

2015-02-03 Thread Zhu Guihua
Memory hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS finished handling unplug, unplug cb will be called to do the real removal of device. This series depends on the following patchset. [PATCH v2 0/5] Common unpl

[Qemu-devel] [PATCH v2 02/12] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Add a new API named acpi_memory_get_slot_status_descriptor() to obtain a single memory slot status. Doing this is because this procedure will be used by other functions in the next coming patches. Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- hw/acpi/memory_hotplug.c

[Qemu-devel] [PATCH v2 12/12] acpi: Add hardware implementation for memory hot unplug.

2015-02-03 Thread Zhu Guihua
From: Tang Chen This patch adds a new bit to memory hotplug IO port indicating that ej0 has been evaluated by guest OS. And call pc-dimm unplug cb to do the real removal. Signed-off-by: Hu Tao Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- docs/specs/acpi_mem_hotplug.txt | 9 +

[Qemu-devel] [PATCH v2 03/12] acpi, mem-hotplug: Add acpi_memory_hotplug_sci() to rise sci for memory hotplug.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Add a new API named acpi_memory_hotplug_sci() to send memory hotplug SCI. Doing this is because this procedure will be used by other functions in the next coming patches. Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- hw/acpi/core.c | 7 +++ hw/acpi/memor

Re: [Qemu-devel] [PATCH 6/9] cosmetic changes preparing for the following patches

2015-02-03 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > From: Mike Day > > Signed-off-by: Mike Day > Signed-off-by: Paolo Bonzini > --- > arch_init.c| 5 +-- > exec.c | 84 > +- > include/exec/cpu-all.h | 1 + > 3 files changed

[Qemu-devel] [PATCH v2 05/12] acpi, piix4: Add memory hot unplug request support for piix4.

2015-02-03 Thread Zhu Guihua
From: Hu Tao Call memory unplug request cb in piix4_device_unplug_request_cb(). Signed-off-by: Hu Tao Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- hw/acpi/piix4.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 14d40a

Re: [Qemu-devel] [PATCH 3/9] exec: RCUify AddressSpaceDispatch

2015-02-03 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > Note that even after this patch, most callers of address_space_* > functions must still be under the big QEMU lock, otherwise the memory > region returned by address_space_translate can disappear as soon as > address_space_translate returns. This will be

[Qemu-devel] [PATCH v2 10/12] acpi, ich9: Add memory hot unplug support for ich9.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Call memory unplug cb in ich9_pm_device_unplug_cb(). Signed-off-by: Zhu Guihua --- hw/acpi/ich9.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index b85eed4..3a8d712 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9

[Qemu-devel] [PATCH v2 01/12] acpi, mem-hotplug: Use PC_DIMM_SLOT_PROP in acpi_memory_plug_cb().

2015-02-03 Thread Zhu Guihua
From: Tang Chen Replace string "slot" in acpi_memory_plug_cb() with MACRO PC_DIMM_SLOT_PROP. Reviewed-by: Igor Mammedov Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- hw/acpi/memory_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/memory_hotplug

[Qemu-devel] [PATCH v2 09/12] acpi, piix4: Add memory hot unplug support for piix4.

2015-02-03 Thread Zhu Guihua
From: Tang Chen Call memory unplug cb in piix4_device_unplug_cb(). Signed-off-by: Zhu Guihua --- hw/acpi/piix4.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 8bd9007..acd054e 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/p

Re: [Qemu-devel] [PATCH 2/9] exec: make iotlb RCU-friendly

2015-02-03 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > After the previous patch, TLBs will be flushed on every change to > the memory mapping. This patch augments that with synchronization > of the MemoryRegionSections referred to in the iotlb array. > > With this change, it is guaranteed that iotlb_to_regi

Re: [Qemu-devel] [v4 12/13] migration: Add command to set migration parameter

2015-02-03 Thread Eric Blake
On 02/03/2015 06:26 PM, Li, Liang Z wrote: >> Hmm - do we really need two parameters here? Remember, compress >> threads is used only on the source, and decompress threads is used only on >> the destination. Having a single parameter, 'threads', which is set to >> compression threads on source a

[Qemu-devel] [PATCH v16 2/2] sPAPR: Implement sPAPRPHBClass::eeh_handler

2015-02-03 Thread Gavin Shan
The patch implements sPAPRPHBClass::eeh_handler so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan --- hw/ppc/spapr_pci_vfio.c | 58 + hw/vfio/common.c| 1 + 2 files changed, 59 insertions(+

[Qemu-devel] [PATCH v16 1/2] sPAPR: Implement EEH RTAS calls

2015-02-03 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: * RTAS calls are received in spapr_pci.c, sanity check is

[Qemu-devel] [PATCH v16 0/2] EEH Support for VFIO Devices

2015-02-03 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support, which was merged during 3.17 merge window. This patchset has been rebased to Alex Graf's QEMU repository: git://github.com/agraf/qemu.git (branch: ppc-next) The impleme

Re: [Qemu-devel] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-03 Thread David Gibson
On Wed, Feb 04, 2015 at 08:19:06AM +1100, Paul Mackerras wrote: > On Tue, Feb 03, 2015 at 05:10:51PM +1100, David Gibson wrote: > > qemu currently implements the hypercalls H_LOGICAL_CI_LOAD and > > H_LOGICAL_CI_STORE as PAPR extensions. These are used by the SLOF firmware > > for IO, because perf

Re: [Qemu-devel] [PATCH 1/9] exec: introduce cpu_reload_memory_map

2015-02-03 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > This for now is a simple TLB flush. This can change later for two > reasons: > > 1) an AddressSpaceDispatch will be cached in the CPUState object > > 2) it will not be possible to do tlb_flush once the TCG-generated code > runs outside the BQL. > > Si

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Chen, Tiejun
On 2015/2/3 19:07, Ian Campbell wrote: On Tue, 2015-02-03 at 09:04 +0800, Chen, Tiejun wrote: On 2015/2/2 20:54, Ian Jackson wrote: Wei Liu writes ("Re: [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough"): On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote:

Re: [Qemu-devel] [v4 12/13] migration: Add command to set migration parameter

2015-02-03 Thread Li, Liang Z
> > +++ b/migration/migration.c > > @@ -66,9 +66,12 @@ MigrationState *migrate_get_current(void) > > .bandwidth_limit = MAX_THROTTLE, > > .xbzrle_cache_size = DEFAULT_MIGRATE_CACHE_SIZE, > > .mbps = -1, > > -.compress_thread_count = > DEFAULT_MIGRATE_COMPRESS_THR

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Chen, Tiejun
On 2015/2/3 18:19, Wei Liu wrote: On Tue, Feb 03, 2015 at 09:01:53AM +0800, Chen, Tiejun wrote: On 2015/2/2 20:19, Wei Liu wrote: On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-03 Thread David Miller
From: David Woodhouse Date: Mon, 02 Feb 2015 07:27:10 + > I'm guessing you don't want to push the *whole* management of the TLS > control connection *and* the UDP transport, and probing the latter with > keepalives, into the kernel? I certainly don't :) Whilst Herbert Xu and I have discussed

[Qemu-devel] [PATCH 2/3] rcu: use rcu_{dereference, assign_pointer} instead of atomic_rcu_{read, set}

2015-02-03 Thread Emilio G. Cota
This matches the semantics of liburcu. Signed-off-by: Emilio G. Cota --- docs/rcu.txt | 33 +++-- include/qemu/atomic.h | 35 ++- memory.c | 6 +++--- tests/rcutorture.c| 4 ++-- 4 files changed, 38 insertion

[Qemu-devel] [PATCH 1/3] rcu: use call_rcu semantics from liburcu

2015-02-03 Thread Emilio G. Cota
The recently added call_rcu does not match liburcu's call_rcu's semantics; instead, call_rcu1 does. Fix it by doing the following: - Rename QEMU's call_rcu to call_rcu_first_elem - Rename QEMU's call_rcu1 to call_rcu The end goal is to be able to switch at compile-time between liburcu and QEMU's

[Qemu-devel] [PATCH 0/3] rcu: add option to use upstream liburcu

2015-02-03 Thread Emilio G. Cota
Hi Paolo + all, First off, thanks for your ongoing RCU work, which I'm closely following. As you stated in the initial RCU patch (7911747b), the intent is to keep the same API as liburcu's. I checked whether this was the case and found a couple of issues that I'm addressing in the appended series

[Qemu-devel] [PATCH 3/3] rcu: add liburcu knob to configure script

2015-02-03 Thread Emilio G. Cota
The default is --disable-liburcu, which means QEMU's RCU implementation is used. When building with --enable-liburcu, the memory barrier version of liburcu (urcu-mb) is linked against. We might want to make this configurable in the future for greater performance; for now we just match the liburcu

Re: [Qemu-devel] [PATCH v2 05/12] qcow2/overlaps: Protect refcount table

2015-02-03 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > Keep track of the refcount table in the metadata list to protect it > against accidental modifications. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 18 ++ > block/qcow2.c | 4 > 2 files changed, 22 insert

Re: [Qemu-devel] [PATCH v2 04/12] qcow2/overlaps: Protect image header

2015-02-03 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > Enter the image header into the metadata list to protect it against > accidental modifications. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake > > diff --git a/block/qcow2.c b/blo

Re: [Qemu-devel] [PATCH v2 03/12] qcow2: Create metadata list

2015-02-03 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > Create and destroy the metadata list on creation and destruction of a > qcow2 BDS, respectively. Skip creation if no overlap checks should be > performed. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 10 ++ > 1 file changed, 10 insertion

Re: [Qemu-devel] [PATCH v2 02/12] qcow2: Pull up overlap check option evaluation

2015-02-03 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > Pull up the absorption of the qcow2-relevant command line options and > the evaluation of the overlap check options in qcow2_open(). > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 96 > +-- >

Re: [Qemu-devel] [v4 13/13] migration: Add command to query migration parameter

2015-02-03 Thread Eric Blake
On 02/02/2015 04:05 AM, Liang Li wrote: > Add the qmp and hmp commands to query the parameters used in live > migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- I'd squash this with 12, if it doesn't make the patch feel too large. > +Query current migration parameters >

Re: [Qemu-devel] [v4 12/13] migration: Add command to set migration parameter

2015-02-03 Thread Eric Blake
On 02/02/2015 04:05 AM, Liang Li wrote: > Add the qmp and hmp commands to tune the parameters used in live > migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > hmp-commands.hx | 15 ++ > hmp.c | 35 ++ > h

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-02-03 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > The existing qcow2 metadata overlap detection function used existing > structures to determine the location of the image metadata, from plain > fields such as l1_table_offset and l1_size in the BDRVQcowState, over > image structures in memory such as the L

Re: [Qemu-devel] [PATCH 0/7] MIPS: IEEE 754-2008 features support

2015-02-03 Thread Maciej W. Rozycki
On Tue, 3 Feb 2015, Thomas Schwinge wrote: > > I think Thomas, being the writer of the majority of code comprising these > > patches > > Too bad that Git doesn't allow for listing several authors. ;-) I believe `Signed-off-by' serves this purpose: "The Signed-off-by: tag indicates that the

Re: [Qemu-devel] [PULL 00/10] s390x translator bug fixes

2015-02-03 Thread Peter Maydell
gt; are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tg-s390-20150203 > > for you to fetch changes up to 9ef1473693a1400a903567489d3122fc9511765d: > > target-s390x: fix and optimize slb* a

Re: [Qemu-devel] [v4 11/13] migration: Add interface to control compression

2015-02-03 Thread Eric Blake
On 02/02/2015 04:05 AM, Liang Li wrote: > The multiple compression threads can be turned on/off through > qmp and hmp interface before doing live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert > --- > migration/migration.c | 7 +-- >

Re: [Qemu-devel] [PATCH v2] qga: add guest-set-admin-password command

2015-02-03 Thread Eric Blake
On 01/12/2015 08:58 AM, Daniel P. Berrange wrote: > Add a new 'guest-set-admin-password' command for changing the > root/administrator password. This command is needed to allow > OpenStack to support its API for changing the admin password > on a running guest. > > Accepts either the raw password

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Gabriel L. Somlo
On Wed, Feb 04, 2015 at 12:49:22AM +0300, Denis V. Lunev wrote: > On 04/02/15 00:38, Gabriel L. Somlo wrote: > >On Tue, Feb 03, 2015 at 02:11:12PM -0600, Michael Roth wrote: > >> > >>This does seem like useful functionality, but I think I'd like to know > >>more about the actual use-cases being loo

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Michael Roth
Quoting Gabriel L. Somlo (2015-02-03 15:38:59) > On Tue, Feb 03, 2015 at 02:11:12PM -0600, Michael Roth wrote: > > > > This does seem like useful functionality, but I think I'd like to know > > more about the actual use-cases being looked at. > > The proposed functionality is mostly equivalent to

Re: [Qemu-devel] [PATCH 4/8] guest agent: add guest-pipe-open

2015-02-03 Thread Eric Blake
On 02/03/2015 02:57 PM, Eric Blake wrote: >> +# Returns: Guest file handle on success, as per guest-file-open. This >> +# handle is useable with the same interfaces as a handle returned by > >> + 'returns': 'int' } > > I'm not a fan of returning a bare 'int' - it is not extensible. Better > i

Re: [Qemu-devel] [PATCH 3/8] guest agent: guest-file-open: refactoring

2015-02-03 Thread Eric Blake
On 12/31/2014 06:06 AM, Denis V. Lunev wrote: > From: Simon Zolin > > Moved the code that sets non-blocking flag on fd into a separate function. > > Signed-off-by: Simon Zolin > Acked-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Michael Roth > --- > qga/commands-posix.c | 31 ++

Re: [Qemu-devel] [PATCH 4/8] guest agent: add guest-pipe-open

2015-02-03 Thread Eric Blake
On 12/31/2014 06:06 AM, Denis V. Lunev wrote: > From: Simon Zolin > > Creates a FIFO pair that can be used with existing file read/write > interfaces to communicate with processes spawned via the forthcoming > guest-file-exec interface. > > Signed-off-by: Simon Zolin > Acked-by: Roman Kagan >

[Qemu-devel] [PATCH v2 12/19] libqos/ahci: add ahci command functions

2015-02-03 Thread John Snow
This patch adds the AHCICommand structure, and a set of functions to operate on the structure. ahci_command_create - Initialize and create a new AHCICommand in memory ahci_command_free - Destroy this object. ahci_command_set_buffer - Set where the guest memory DMA buffer is. ahci_command_commit -

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Denis V. Lunev
On 04/02/15 00:38, Gabriel L. Somlo wrote: On Tue, Feb 03, 2015 at 02:11:12PM -0600, Michael Roth wrote: This does seem like useful functionality, but I think I'd like to know more about the actual use-cases being looked at. The proposed functionality is mostly equivalent to that offered by "

[Qemu-devel] [PATCH v2 13/19] libqos/ahci: add ahci command verify

2015-02-03 Thread John Snow
Helps to verify that a command completed successfully. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tests/ahci-test.c | 16 ++-- tests/libqos/ahci.c | 12 tests/libqos/ahci.h | 1 + 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/tests/ahc

[Qemu-devel] [PATCH v2 16/19] libqos/ahci: add ahci_io

2015-02-03 Thread John Snow
ahci_io is a wrapper around ahci_guest_io that takes a pointer to host memory instead, and will create a guest memory buffer and copy the data to/from as needed and as appropriate for a read/write command, such that after a read, the guest data will be in a host buffer, and for a write, the data wi

[Qemu-devel] [PATCH v2 19/19] qtest/ahci: Adding simple dma read-write test

2015-02-03 Thread John Snow
Adds a test case for AHCI wherein we write a 4K block of a changing pattern to sector 0, then read back that 4K and compare the transmit and receive buffers. Signed-off-by: John Snow --- tests/ahci-test.c | 55 +++ 1 file changed, 55 insertions

[Qemu-devel] [PATCH v2 11/19] libqos/ahci: Add ide cmd properties

2015-02-03 Thread John Snow
Add a structure that defines some properties of various IDE commands. These will be used to simplify the interface to the libqos AHCI calls, lessening the redundancy of specifying and respecifying properties of commands to various helper functions. Signed-off-by: John Snow --- tests/libqos/ahci.

[Qemu-devel] [PATCH v2 18/19] qtest/ahci: Assert sector size in identify test

2015-02-03 Thread John Snow
A minor sanity check to assert that the sector size is 512. The current block layer code deeply assumes that the IDE sector size will be 512 bytes, so we carry forward that assumption here. This is useful for the DMA tests, which currently assume that a sector will always be 512 bytes. Signed-off

[Qemu-devel] [PATCH v2 06/19] libqos/ahci: Add ahci_port_check_interrupts helper

2015-02-03 Thread John Snow
A helper that compares a given port's current interrupts and checks them against a supplied list of expected interrupt bits, and throws an error if they do not match. The helper then resets the requested interrupts on this port, and asserts that the interrupt register is now empty. Signed-off-by:

[Qemu-devel] [PATCH v2 09/19] qtest/ahci: Demagic ahci tests.

2015-02-03 Thread John Snow
Add human-readable command names and other miscellaneous #defines to help make the code more readable. Some of these definitions are not yet used in this current series, but for convenience and sanity they have been lumped together here, as it's more trouble than it is worth in a test suite to han

[Qemu-devel] [PATCH v2 10/19] qtest/ahci: add ahci_write_fis

2015-02-03 Thread John Snow
Similar to ahci_set_command_header, add a helper that takes an in-memory representation of a command FIS and writes it to guest memory, handling endianness as-needed. Signed-off-by: John Snow --- tests/ahci-test.c | 2 +- tests/libqos/ahci.c | 10 ++ tests/libqos/ahci.h | 1 + 3 file

[Qemu-devel] [PATCH v2 17/19] libqos/ahci: Add ahci_clean_mem

2015-02-03 Thread John Snow
Clean up guest memory being used in ahci_clean_mem, to be called during ahci_shutdown. With all guest memory leaks removed, add an option to the allocator to throw an assertion if a leak occurs. This test adds some sanity to both the AHCI library and the allocator. Signed-off-by: John Snow Revie

[Qemu-devel] [PATCH v2 03/19] qtest/ahci: rename 'Command' to 'CommandHeader'

2015-02-03 Thread John Snow
The structure name is a bit of a misnomer; the structure currently named command is actually the commandheader. A future patch in this series will add an actual "Command" structure, so we'll rename it now before the rest of the functions in this series try to use it. In addition, rename the "b1" a

[Qemu-devel] [PATCH v2 08/19] libqos/ahci: Add cmd response sanity check helpers

2015-02-03 Thread John Snow
This patch adds a few helpers to help sanity-check the response of the AHCI device after a command. ahci_d2h_check_sanity inspects the D2H Register FIS, ahci_pio_check_sanity inspects the PIO Setup FIS, and ahci_cmd_check_sanity inspects the command header. To support the PIO sanity check, a new

[Qemu-devel] [PATCH v2 07/19] libqos/ahci: Add port_check_nonbusy helper

2015-02-03 Thread John Snow
A simple helper that asserts a given port is not busy processing any commands via the TFD, Command Issue and SACT registers. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tests/ahci-test.c | 1 + tests/libqos/ahci.c | 18 ++ tests/libqos/ahci.h | 1 + 3 files chang

[Qemu-devel] [PATCH v2 00/19] qtest/ahci: add dma test

2015-02-03 Thread John Snow
Add a simple DMA r/w test to ahci-test. Oh, and for the first 18 patches, refactor everything into helpers so that each ahci_test isn't a thousand lines long. This patch depends upon the "ahci test preliminary refactoring" series upstream, which shuffled a lot of libqos and malloc facilities to s

[Qemu-devel] [PATCH v2 04/19] libqos/ahci: Add command header helpers

2015-02-03 Thread John Snow
Adds command header helper functions: -ahci_command_header_set -ahci_command_header_get, -ahci_command_destroy, and -ahci_cmd_pick These helpers help to quickly manage the command header information in the AHCI device. ahci_command_header_set and get will store or retrieve an AHCI command header,

[Qemu-devel] [PATCH v2 15/19] libqos/ahci: Add ahci_guest_io

2015-02-03 Thread John Snow
ahci_guest_io is a shorthand function that will, in one shot, execute a data command on the guest to the specified guest buffer location, in the requested amount. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tests/libqos/ahci.c | 15 +++ tests/libqos/ahci.h | 2 ++ 2 fil

[Qemu-devel] [PATCH v2 01/19] libqos/ahci: Add ahci_port_select helper

2015-02-03 Thread John Snow
This helper identifies which port of the AHCI HBA has a device we may run tests on. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tests/ahci-test.c | 19 ++- tests/libqos/ahci.c | 27 +++ tests/libqos/ahci.h | 1 + 3 files changed, 30 inserti

Re: [Qemu-devel] [PATCH v3 1/4] target-arm: Add CPU property to disable AArch64

2015-02-03 Thread Greg Bellows
On Tue, Feb 3, 2015 at 1:14 PM, Peter Maydell wrote: > On 27 January 2015 at 23:58, Greg Bellows wrote: > > Adds registration and get/set functions for enabling/disabling the > AArch64 > > execution state on AArch64 CPUs. By default AArch64 execution state is > enabled > > on AArch64 CPUs, sett

[Qemu-devel] [PATCH v2 05/19] libqos/ahci: Add ahci_port_check_error helper

2015-02-03 Thread John Snow
ahci_port_check_error checks a given port's error registers and asserts that everything from the port-level view is still OK. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tests/ahci-test.c | 8 +--- tests/libqos/ahci.c | 22 ++ tests/libqos/ahci.h | 1 + 3

[Qemu-devel] [PATCH v2 14/19] libqos/ahci: add ahci command size setters

2015-02-03 Thread John Snow
Adds setters for size, prd_size and both via set_sizes. Signed-off-by: John Snow --- tests/libqos/ahci.c | 22 ++ tests/libqos/ahci.h | 5 + 2 files changed, 27 insertions(+) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index d1e511a..60849ea 100644 --- a/test

[Qemu-devel] [PATCH v2 02/19] libqos/ahci: Add ahci_port_clear helper

2015-02-03 Thread John Snow
Add a helper that assists in clearing out potentially old error and FIS information from an AHCI port's data structures. This ensures we always start with a blank slate for interrupt and FIS receipt information. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tests/ahci-test.c | 9 ++

Re: [Qemu-devel] [PATCH 5/8] guest agent: add guest-exec and guest-exec-status interfaces

2015-02-03 Thread Eric Blake
On 12/31/2014 06:06 AM, Denis V. Lunev wrote: > From: Simon Zolin > > Interfaces to execute/manage processes in the guest. Child process' > stdin/stdout/stderr can be associated with handles for communication > via read/write interfaces. > > Signed-off-by: Simon Zolin > Acked-by: Roman Kagan >

Re: [Qemu-devel] [PATCH v3 1/4] target-arm: Add CPU property to disable AArch64

2015-02-03 Thread Greg Bellows
On Tue, Feb 3, 2015 at 3:21 PM, Christoffer Dall < christoffer.d...@linaro.org> wrote: > On Tue, Feb 3, 2015 at 10:15 PM, Peter Maydell > wrote: > > On 3 February 2015 at 19:14, Peter Maydell > wrote: > >> On 27 January 2015 at 23:58, Greg Bellows > wrote: > >>> static void aarch64_cpu_initfn(

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Gabriel L. Somlo
On Tue, Feb 03, 2015 at 02:11:12PM -0600, Michael Roth wrote: > > This does seem like useful functionality, but I think I'd like to know > more about the actual use-cases being looked at. The proposed functionality is mostly equivalent to that offered by "GuestInfo variables". So yes, initial act

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-02-03 Thread Denis V. Lunev
On 03/02/15 23:24, Michael Roth wrote: Quoting Denis V. Lunev (2015-01-13 04:13:03) On 09/01/15 22:29, Michael Roth wrote: Quoting Denis V. Lunev (2015-01-09 12:09:10) On 09/01/15 20:06, Michael Roth wrote: Quoting Denis V. Lunev (2014-12-31 07:06:46) hese patches for guest-agent add the fun

Re: [Qemu-devel] [PATCH 1/8] qga: fixed warning in qemu-ga.exe for mingw >= 4.9.1

2015-02-03 Thread Eric Blake
On 12/31/2014 06:06 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > strtok_r was redefined before the patch > > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Michael Roth > --- > include/sysemu/os-win32.h | 2 ++ > 1 file changed, 2 insertions(+) What's the actual c

Re: [Qemu-devel] [PATCHv2 1/2] m48t59: introduce new year_offset qdev property

2015-02-03 Thread Mark Cave-Ayland
On 01/02/15 19:50, Hervé Poussineau wrote: > Le 01/02/2015 19:39, Mark Cave-Ayland a écrit : >> Currently the m48t59 device uses the hardware model in order to determine >> whether the year value is offset from the hardware value. As this will >> soon be required by the x59 model, change the year

Re: [Qemu-devel] [PATCH v3 1/4] target-arm: Add CPU property to disable AArch64

2015-02-03 Thread Christoffer Dall
On Tue, Feb 3, 2015 at 10:15 PM, Peter Maydell wrote: > On 3 February 2015 at 19:14, Peter Maydell wrote: >> On 27 January 2015 at 23:58, Greg Bellows wrote: >>> static void aarch64_cpu_initfn(Object *obj) >>> { >>> +object_property_add_bool(obj, "aarch64", aarch64_cpu_get_aarch64, >>> +

Re: [Qemu-devel] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-03 Thread Paul Mackerras
On Tue, Feb 03, 2015 at 05:10:51PM +1100, David Gibson wrote: > qemu currently implements the hypercalls H_LOGICAL_CI_LOAD and > H_LOGICAL_CI_STORE as PAPR extensions. These are used by the SLOF firmware > for IO, because performing cache inhibited MMIO accesses with the MMU off > (real mode) is v

Re: [Qemu-devel] [PATCH v3 1/4] target-arm: Add CPU property to disable AArch64

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 19:14, Peter Maydell wrote: > On 27 January 2015 at 23:58, Greg Bellows wrote: >> static void aarch64_cpu_initfn(Object *obj) >> { >> +object_property_add_bool(obj, "aarch64", aarch64_cpu_get_aarch64, >> + aarch64_cpu_set_aarch64, NULL); >>

Re: [Qemu-devel] [PATCH 2/8] qga: implement file commands for Windows guest

2015-02-03 Thread Michael Roth
Quoting Denis V. Lunev (2014-12-31 07:06:48) > From: Olga Krishtal > > The following commands are implemented: > - guest_file_open > - guest_file_close > - guest_file_write > - guest_file_read > - guest_file_seek > - guest_file_flush > > Motivation is quite simple: Windows guests should be suppo

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Gabriel L. Somlo
On Tue, Feb 03, 2015 at 12:26:47PM -0700, Eric Blake wrote: > On 02/03/2015 12:09 PM, Gabriel L. Somlo wrote: > > Hi, > > > > I'm interested in adding a way for a host to pass environment variables > > into a qemu guest VM -- analogous to setting environment variables for > > a process to access v

[Qemu-devel] [PATCH v2 8/9] target-i386: Require APIC ID to be explicitly set before CPU realize

2015-02-03 Thread Eduardo Habkost
Instead of setting APIC ID automatically when creating a X86CPU, require the property to be set before realizing the object (which all callers of cpu_x86_create() already do). Signed-off-by: Eduardo Habkost Cc: Gu Zheng --- target-i386/cpu-qom.h | 2 +- target-i386/cpu.c | 7 ++- 2 file

[Qemu-devel] [PULL 10/10] target-s390x: fix and optimize slb* and slbg* computation of carry/borrow flag

2015-02-03 Thread Richard Henderson
From: Torbjorn Granlund This patch fixes the bug with borrow_in being set incorrectly, but it also simplifies the logic to be much more plain, improving speed. It fixes both the 32-bit SLB* and 64-bit SLBG*. The SLBG* change has been well-tested. I haven't tested the SLB* change explicitly, bu

[Qemu-devel] [PULL 09/10] target-s390x: support OC and NC in the EX instruction

2015-02-03 Thread Richard Henderson
From: Paolo Bonzini This is needed to run the GMP testsuite. Reported-by: Torbjorn Granlund Tested-by: Torbjorn Granlund Signed-off-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target-s390x/mem_helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-s390x/mem_h

[Qemu-devel] [PULL 07/10] target-s390x: Mark check_privileged() as !CONFIG_USER_ONLY

2015-02-03 Thread Richard Henderson
From: Peter Maydell The function check_privileged() is only used in the softmmu configs; wrap it in an #ifndef CONFIG_USER_ONLY to avoid clang warnings on the linux-user builds. [rth: Remove inline marker too; it was only there to prevent exactly this warning in GCC.] Signed-off-by: Peter Mayde

[Qemu-devel] [PULL 06/10] target-s390: Implement ECAG

2015-02-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 2 ++ target-s390x/translate.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 60dbe80..8d8e47e 100644 --- a/target-s390x/insn-data.def +++ b/target-s390x/

[Qemu-devel] [PULL 05/10] target-s390: Implement LURA, LURAG, STURG

2015-02-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/helper.h | 3 +++ target-s390x/insn-data.def | 4 target-s390x/mem_helper.c | 22 ++ target-s390x/translate.c | 26 ++ 4 files changed, 55 insertions(+) diff --git a/target-s390x/helper.h

[Qemu-devel] [PULL 08/10] disas/s390.c: Remove unused variables

2015-02-03 Thread Richard Henderson
From: Peter Maydell The variables s390_opformats and s390_num_opformats are unused and provoke clang warnings: disas/s390.c:849:33: warning: variable 's390_opformats' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct s390_opcode s390_opformats[] =

[Qemu-devel] [PULL 03/10] target-s390: Fix STIDP

2015-02-03 Thread Richard Henderson
The implementation had been incomplete, as we did not store the machine type. Note that the machine_type member is still unset during initialization, so this has no effect yet. Signed-off-by: Richard Henderson --- target-s390x/cpu.h | 4 +++- target-s390x/translate.c | 6 ++ 2 files c

[Qemu-devel] [PULL 01/10] target-s390: Implement SAM specification exception

2015-02-03 Thread Richard Henderson
Also, these are user-mode instructions; allow their use in CONFIG_USER_ONLY. Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 8 target-s390x/translate.c | 31 +++ 2 files changed, 31 insertions(+), 8 deletions(-) diff --git a/target-s390

[Qemu-devel] [PULL 02/10] target-s390: Implement EPSW

2015-02-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 2 ++ target-s390x/translate.c | 18 ++ 2 files changed, 20 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 42b99b2..859cfba 100644 --- a/target-s390x/insn-data.def +++ b

[Qemu-devel] [PULL 00/10] s390x translator bug fixes

2015-02-03 Thread Richard Henderson
nding bug fixes. r~ The following changes since commit 16017c48547960539fcadb1f91d252124f442482: softfloat: Clarify license status (2015-01-29 16:45:45 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tg-s390-20150203 for you to fetch changes

[Qemu-devel] [PULL 04/10] target-s390: Fix STURA

2015-02-03 Thread Richard Henderson
We were storing 16 bits instead of 32. Signed-off-by: Richard Henderson --- target-s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 5a55de8..4736b7b 100644 --- a/target-s390x/mem_helper.c +++ b/targ

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-02-03 Thread Michael Roth
Quoting Denis V. Lunev (2015-01-13 04:13:03) > On 09/01/15 22:29, Michael Roth wrote: > > Quoting Denis V. Lunev (2015-01-09 12:09:10) > >> On 09/01/15 20:06, Michael Roth wrote: > >>> Quoting Denis V. Lunev (2014-12-31 07:06:46) > hese patches for guest-agent add the functionality to execute

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Michael Roth
Quoting Gabriel L. Somlo (2015-02-03 13:09:22) > Hi, > > I'm interested in adding a way for a host to pass environment variables > into a qemu guest VM -- analogous to setting environment variables for > a process to access via getenv() and friends. > > The QEMU Guest Agent (QGA) does not appear

Re: [Qemu-devel] RFC: Proposal to add QEMU "Guest Environment Variables"

2015-02-03 Thread Denis V. Lunev
On 03/02/15 23:14, Gabriel L. Somlo wrote: Hi Denis, On Tue, Feb 03, 2015 at 10:14:03PM +0300, Denis V. Lunev wrote: On 03/02/15 22:09, Gabriel L. Somlo wrote: I'm interested in adding a way for a host to pass environment variables into a qemu guest VM -- analogous to setting environment vari

  1   2   3   >