On 01/02/15 19:50, Hervé Poussineau wrote: > Le 01/02/2015 19:39, Mark Cave-Ayland a écrit : >> Currently the m48t59 device uses the hardware model in order to determine >> whether the year value is offset from the hardware value. As this will >> soon be required by the x59 model, change the year offset to a qdev >> property and update the callers appropriately. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > > Hi, > > Is it possible to use a 'base_year' property, like in the mc146818rtc > device? > Usual values will be 0 (for year 2000) and 1968 (for sun4m). > > Regards, > > Hervé
Hi Hervé, Yes I could do this to match the mc146818rtc if that help makes everything consistent. Can you clarify exactly how the base_year wraparound works in the above example? (e.g. what happens for base_year 2001, and what are the maximum/minimum values that should be accepted for the wraparound logic). Also how should these patches get merged? According to get_maintainer.pl this part of the tree feels particularly unloved, or would you now consider yourself to be a reviewer/maintainer? ATB, Mark.
