From: Gonglei
Gonglei (2):
xen-pt: fix Negative array index read
xen-pt: fix Out-of-bounds read
hw/xen/xen_pt_config_init.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
--
1.7.12.4
From: Gonglei
The array length of s->real_device.io_regions[] is
"PCI_NUM_REGIONS - 1". Add a check, just make Coverity happy.
Signed-off-by: Gonglei
---
hw/xen/xen_pt_config_init.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init
From: Gonglei
Coverity spot:
Function xen_pt_bar_offset_to_index() may returns a negative
number (-1) value index, which as an index to array d->io_regions.
Let's directly and simply pass index as an argument to
xen_pt_bar_reg_parse().
Signed-off-by: Gonglei
---
hw/xen/xen_pt_config_init.c |
> -Original Message-
> From: xen-devel-boun...@lists.xen.org
> [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Wei Liu
> Sent: Friday, January 30, 2015 8:26 PM
> To: Chen, Tiejun
> Cc: Wei Liu; ian.campb...@citrix.com; m...@redhat.com; Ian Jackson;
> qemu-devel@nongnu.org; xen-de...
On Fri, Jan 30, 2015 at 01:53:47PM +0530, Bharata B Rao wrote:
> On Thu, Jan 29, 2015 at 12:48:39PM +1100, David Gibson wrote:
> > On Thu, Jan 08, 2015 at 11:40:17AM +0530, Bharata B Rao wrote:
> > > From: Gu Zheng
> >
> > This needs a commit message, it's not at all clear from the 1-line
> > de
Commit d8d95814609e replaced a number of memory_region_destroy()
calls with object_unparent() calls. The logic appears to be that
subregions need to be unparented, but the base region is destroyed
with the device object. Doing hotplug testing with vfio-pci I
occasionally get a segfault from objec
On 01/30/2015 02:06 PM, Don Slutz wrote:
> This adds two new inject commands:
>
> inject-vmport-reboot
> inject-vmport-halt
>
> And three guest info commands:
>
> vmport-guestinfo-set
> vmport-guestinfo-get
> query-vmport-guestinfo
>
> More details in qmp-commands.hx
>
> Signed-off-by: Don Slu
On Fri, Jan 30, 2015 at 02:32:25PM -0500, Max Reitz wrote:
> On 2015-01-30 at 13:41, Kashyap Chamarthy wrote:
> >On Fri, Jan 30, 2015 at 06:15:21PM +0100, Kevin Wolf wrote:
> >>Am 29.01.2015 um 17:25 hat Kashyap Chamarthy geschrieben:
[. . .]
> >>Copying Stefan because he's the master of AIO cont
On 2015-01-30 at 16:05, Peter Lieven wrote:
Am 30.01.2015 um 18:16 schrieb Max Reitz:
On 2015-01-30 at 09:33, Peter Lieven wrote:
this patch finally introduces multiread support to virtio-blk. While
multiwrite support was there for a long time, read support was missing.
The complete merge logi
Am 30.01.2015 um 22:05 hat Peter Lieven geschrieben:
> Am 30.01.2015 um 18:16 schrieb Max Reitz:
> > On 2015-01-30 at 09:33, Peter Lieven wrote:
> >> this patch finally introduces multiread support to virtio-blk. While
> >> multiwrite support was there for a long time, read support was missing.
> >
Hi,
Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.h should not
be equal to IOV_MAX instead of the hardcoded 1024?
Thanks,
Peter
Signed-off-by: Don Slutz
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fd335a4..b60ee6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -741,6 +741,13 @@ S: Maintained
F: hw/net/vmxnet*
F: hw/scsi/vmw_pvscsi*
+VMware port
+M: Don Slut
This adds two new inject commands:
inject-vmport-reboot
inject-vmport-halt
And three guest info commands:
vmport-guestinfo-set
vmport-guestinfo-get
query-vmport-guestinfo
More details in qmp-commands.hx
Signed-off-by: Don Slutz
---
hw/misc/vmport_rpc.c | 275 +
Based on
https://sites.google.com/site/chitchatvmback/backdoor
and testing on ESXi, this should be in MB not bytes.
Signed-off-by: Don Slutz
---
hw/misc/vmport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
index 7fcc00d..6b350ce 10064
The support included is enough to allow VMware tools to install in a
guest and provide guestinfo support. guestinfo support is provided
by what is known as VMware RPC support.
One of the better on-line references is:
https://sites.google.com/site/chitchatvmback/backdoor
As a place to get more a
This is done by adding a new machine property vmware-port-ring3 that
needs to be enabled to have any effect. It only effects accel=tcg
mode. It is needed if you want to use VMware tools in accel=tcg
mode.
Signed-off-by: Don Slutz
(cherry picked from commit 6d99c91fc9ae27b476e89a8cc880b4a46e2375
The support included is enough to allow VMware tools to install in a
guest and provide guestinfo support. guestinfo support is provided
by what is known as VMware RPC support.
If the guest is running VMware tools, then the "build version" of
the tools is also available via the property build-numb
This is the 1st part of "Add limited support of VMware's hyper-call
rpc".
This patch uses existing infrastructure used by vmmouse.c (provided
by vmport.c) to handle the VMware backdoor command 30.
One of the better on-line references is:
https://sites.google.com/site/chitchatvmback/backdoor
Mor
Am 30.01.2015 um 18:16 schrieb Max Reitz:
> On 2015-01-30 at 09:33, Peter Lieven wrote:
>> this patch finally introduces multiread support to virtio-blk. While
>> multiwrite support was there for a long time, read support was missing.
>>
>> The complete merge logic is moved into virtio-blk.c which
On 01/27/2015 02:45 PM, Max Reitz wrote:
The tray of an FDD is open iff there is no medium inserted (there are
only two states for an FDD: "medium inserted" or "no medium inserted").
This results in the tray being reported as open if qemu has been started
with the default floppy drive, which b
Thank you Stefan! Now I understand the workflow.
-Yaodong
On Fri, Jan 30, 2015 at 2:37 PM, Stefan Hajnoczi wrote:
> On Fri, Jan 30, 2015 at 8:13 PM, Yaodong Yang
> wrote:
> > An follow up questions.
> >
> > Suppose I have a running VM with two virtual disks, I would like to
> migrate
> > the v
On Fri, Jan 30, 2015 at 8:13 PM, Yaodong Yang wrote:
> An follow up questions.
>
> Suppose I have a running VM with two virtual disks, I would like to migrate
> the vm from host A to host B. Both host A and host B have their own isolated
> storage devices. Is there anyway to migrate the vm's memor
This allows to use MMC emulation with the Integrator/CP model. Well,
mostly. There seems to be timing issues with Linux so that the card is
not always detected (but most of the time).
Note that the read-only pin is intentionally left unconnected because
the PIC model could deliver it incorrectly a
An follow up questions.
Suppose I have a running VM with two virtual disks, I would like to migrate
the vm from host A to host B. Both host A and host B have their own
isolated storage devices. Is there anyway to migrate the vm's memory, two
virtual disk images and other states together from host
On 01/30/2015 02:37 PM, Kevin Wolf wrote:
The size of the stack allocated host[] array didn't account for the
terminating '\0' byte that sscanf() writes. Fix the array size.
Signed-off-by: Kevin Wolf
---
util/qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 30/01/15 22:48, Kevin Wolf wrote:
Am 30.01.2015 um 19:39 hat Denis V. Lunev geschrieben:
On 29/01/15 16:49, Denis V. Lunev wrote:
On 29/01/15 16:18, Kevin Wolf wrote:
Am 29.01.2015 um 11:50 hat Denis V. Lunev geschrieben:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT
Am 30.01.2015 um 19:39 hat Denis V. Lunev geschrieben:
> On 29/01/15 16:49, Denis V. Lunev wrote:
> >On 29/01/15 16:18, Kevin Wolf wrote:
> >>Am 29.01.2015 um 11:50 hat Denis V. Lunev geschrieben:
> >>>The following sequence
> >>> int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
> >>>
The size of the stack allocated host[] array didn't account for the
terminating '\0' byte that sscanf() writes. Fix the array size.
Signed-off-by: Kevin Wolf
---
util/qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
inde
On 2015-01-30 at 13:41, Kashyap Chamarthy wrote:
On Fri, Jan 30, 2015 at 06:15:21PM +0100, Kevin Wolf wrote:
Am 29.01.2015 um 17:25 hat Kashyap Chamarthy geschrieben:
$ qemu-system-x86_64 \
-nographic \
-nodefconfig\
-n
On 01/30/2015 09:25 AM, Yaodong Yang wrote:
> Hi all,
>
> I'm investigating the current schemes for the VM live storage migration in
> QEMU system. I have the following questions:
>
> 1. What is the functionality of drive_mirror in QEMU? Is it designed as a
> VM live storage migration approach?
On 01/30/2015 05:24 AM, Vladimir Sementsov-Ogievskiy wrote:
About added functions for BdrvDirtyBitmap:
some functions has needless BlockDriverState* parameter, and others -
doesn't:
with needless *bs:
bdrv_dirty_bitmap_make_anon
bdrv_dirty_bitmap_granularity
bdrv_clear_dirty_bitmap
without *
ahci_io is a wrapper around ahci_guest_io that takes a pointer to host
memory instead, and will create a guest memory buffer and copy the data
to/from as needed and as appropriate for a read/write command, such that
after a read, the guest data will be in a host buffer, and for a write,
the data wi
A minor sanity check to assert that the sector size is 512.
The current block layer code deeply assumes that the IDE
sector size will be 512 bytes, so we carry forward that assumption
here.
This is useful for the DMA tests, which currently assume that
a sector will always be 512 bytes.
Signed-off
This patch adds the AHCICommand structure, and a set of functions to
operate on the structure.
ahci_command_create - Initialize and create a new AHCICommand in memory
ahci_command_free - Destroy this object.
ahci_command_set_buffer - Set where the guest memory DMA buffer is.
ahci_command_commit -
Add a structure that defines some properties of various IDE commands.
These will be used to simplify the interface to the libqos AHCI calls,
lessening the redundancy of specifying and respecifying properties of
commands to various helper functions.
The "Invalid Command Sentinel" here that caps the
Am 30.01.2015 um 18:04 hat John Snow geschrieben:
>
>
> On 01/30/2015 09:32 AM, Kevin Wolf wrote:
> >Am 21.01.2015 um 10:34 hat Markus Armbruster geschrieben:
> >>I'm afraid I forgot much of the discussion we had before the break, and
> >>only now it's coming back, slowly.
> >>
> >>Quoting myself
This patch adds a few helpers to help sanity-check the response of the
AHCI device after a command.
ahci_d2h_check_sanity inspects the D2H Register FIS,
ahci_pio_check_sanity inspects the PIO Setup FIS, and
ahci_cmd_check_sanity inspects the command header.
To support the PIO sanity check, a new
Add human-readable command names and other miscellaneous #defines
to help make the code more readable.
Some of these definitions are not yet used in this current series,
but for convenience and sanity they have been lumped together here,
as it's more trouble than it is worth in a test suite to han
ahci_guest_io is a shorthand function that will, in one shot,
execute a data command on the guest to the specified guest buffer
location, in the requested amount.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 15 +++
tests/libqos/ahci.h | 2 ++
2 files changed, 17 insertions(+)
Clean up guest memory being used in ahci_clean_mem, to be
called during ahci_shutdown. With all guest memory leaks removed,
add an option to the allocator to throw an assertion if a leak
occurs.
This test adds some sanity to both the AHCI library and the
allocator.
Signed-off-by: John Snow
---
Adds command header helper functions:
-ahci_command_header_set
-ahci_command_header_get,
-ahci_command_destroy, and
-ahci_cmd_pick
These helpers help to quickly manage the command header information in
the AHCI device.
ahci_command_header_set and get will store or retrieve an AHCI command
header,
Add a routine that can be used to engage the AHCI
device at a not-granular level so that bringing up
the functionality of the HBA is easy in future tests
that are not concerned with testing the bring-up process.
Signed-off-by: John Snow
---
tests/ahci-test.c | 19 ---
1 file chan
Adds a test case for AHCI wherein we write a 4K
block of a changing pattern to sector 0, then
read back that 4K and compare the transmit and
receive buffers.
Signed-off-by: John Snow
---
tests/ahci-test.c | 52
1 file changed, 52 insertions(+)
ahci_port_check_error checks a given port's error registers and asserts
that everything from the port-level view is still OK.
Signed-off-by: John Snow
---
tests/ahci-test.c | 8 +---
tests/libqos/ahci.c | 22 ++
tests/libqos/ahci.h | 1 +
3 files changed, 24 insertion
Add a helper that assists in clearing out potentially old error and FIS
information from an AHCI port's data structures. This ensures we always
start with a blank slate for interrupt and FIS receipt information.
Signed-off-by: John Snow
---
tests/ahci-test.c | 9 ++---
tests/libqos/ahci.c
Helps to verify that a command completed successfully.
Signed-off-by: John Snow
---
tests/ahci-test.c | 16 ++--
tests/libqos/ahci.c | 12
tests/libqos/ahci.h | 1 +
3 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
The structure name is a bit of a misnomer; the structure currently named
command is actually the commandheader. A future patch in this series
will add an actual "Command" structure, so we'll rename it now before the
rest of the functions in this series try to use it.
In addition, rename the "b1" a
Adds setters for size, prd_size and both via set_sizes.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 22 ++
tests/libqos/ahci.h | 5 +
2 files changed, 27 insertions(+)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 594c821..3375d54 100644
--- a/test
This helper identifies which port of the
AHCI HBA has a device we may run tests on.
Signed-off-by: John Snow
---
tests/ahci-test.c | 19 ++-
tests/libqos/ahci.c | 27 +++
tests/libqos/ahci.h | 1 +
3 files changed, 30 insertions(+), 17 deletions(-)
dif
A simple helper that asserts a given port is not busy processing any
commands via the TFD, Command Issue and SACT registers.
Signed-off-by: John Snow
---
tests/ahci-test.c | 1 +
tests/libqos/ahci.c | 18 ++
tests/libqos/ahci.h | 1 +
3 files changed, 20 insertions(+)
diff -
Add a simple DMA r/w test to ahci-test.
Oh, and for the first 18 patches, refactor everything into helpers so
that each ahci_test isn't a thousand lines long.
This patch depends upon the "ahci test preliminary refactoring" series
upstream, which shuffled a lot of libqos and malloc facilities to
s
A helper that compares a given port's current interrupts and checks them
against a supplied list of expected interrupt bits, and throws an error
if they do not match.
The helper then resets the requested interrupts on this port, and asserts
that the interrupt register is now empty.
Signed-off-by:
On Fri, Jan 30, 2015 at 06:15:21PM +0100, Kevin Wolf wrote:
> Am 29.01.2015 um 17:25 hat Kashyap Chamarthy geschrieben:
> > $ qemu-system-x86_64 \
> > -nographic \
> > -nodefconfig\
> > -nodefaults \
> >
On 29/01/15 16:49, Denis V. Lunev wrote:
On 29/01/15 16:18, Kevin Wolf wrote:
Am 29.01.2015 um 11:50 hat Denis V. Lunev geschrieben:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
for (i = 0; i < 10; i++)
write(fd, buf, 4096);
perfor
On 01/30/15 05:23, Paul Durrant wrote:
>> -Original Message-
>> From: Don Slutz [mailto:dsl...@verizon.com]
>> Sent: 29 January 2015 19:41
>> To: Paul Durrant; Don Slutz; qemu-devel@nongnu.org; Stefano Stabellini
>> Cc: Peter Maydell; Olaf Hering; Alexey Kardashevskiy; Stefan Weil; Michael
This patch defines the RESET ioctl number for PPC architecture. Without it,
the reset() function of Event class can potentionally cause exception on
PPC.
Signed-off-by: Wei Huang
---
scripts/kvm/kvm_stat | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_s
This patch defines the list of kvm_exit reasons for aarch64. This list is
based on the Exception Class (EC) field of HSR register. With this patch
users can trace the execution of guest VMs better. A sample output from
command "kvm_stat -1 -t" is shown as the following:
<...>
kvm_exit(WATCHPT_HYP)
On Thu, Jan 29, 2015 at 9:48 PM, Sebastian Huber
wrote:
> Set initial MAC address to the one specified by the command line.
>
> Signed-off-by: Sebastian Huber
> Reviewed-by: Jason Wang
>
> v2: Remove superfluous whitespace change.
The inter-spin change-logs should not go into commit messages. T
On 01/30/2015 02:06 AM, Vladimir Sementsov-Ogievskiy wrote:
> is it better to add qmp_query_dirty_bitmap with underlying
> bdrv_query_dirty_bitmap, or to modify (add dirty regions information)
> existing qmp_query_block/qmp_query_dirty_bitmapS?
[please don't top-post on technical lists]
Extending
Hi, I've created for fun a pci dummy device in Qemu and the associated
linux driver.
Some friends wanted to know how I had done it so I did a write up.
If this can be of any use to someone who want to create his own device I
would be glad.
Also, if there are some error or some things implemented w
Hi,
I need to syncronize the simulation time of QEMU with another tool.
In order to do so I'd need to know in advance at least a rough estimation
of how much the virtual timer will progress upon executing the next block
of instruction(s) (QEMU_CLOCK_VIRTUAL_RT/QEMU_CLOCK_VIRTUAL)
in qemu/cpus.c se
On 01/26/2015 12:27 PM, Max Reitz wrote:
> We will need it in block/block-backend.c.
>
> Signed-off-by: Max Reitz
> ---
> block.c | 2 +-
> include/block/block_int.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake re
On 01/26/2015 12:27 PM, Max Reitz wrote:
> This function first removed the BlockBackend from the blk_backends list
> and cleared its name so it would no longer be found by blk_name(); since
> blk_next() now iterates through monitor_block_backends (which the BB is
> removed from in do_drive_del()),
On 01/26/2015 12:27 PM, Max Reitz wrote:
> The monitor does hold references to some BlockBackends so it should have
> a list of those BBs; blk_backends is a different list, as it contains
> references to all BBs (after a follow-up patch, that is), and that
> should not be changed because we do need
Am 29.01.2015 um 17:25 hat Kashyap Chamarthy geschrieben:
> A simple reproducer below.
>
> Export a disk image over NBD (I realize port 10809 is default, thought
> I'd explicitly mention anyhow):
>
> $ qemu-nbd --f qcow2 -p10809 \
> /var/lib/libvirt/images/cirros-0.3.3-x86_64-disk.img -
On 2015-01-30 at 09:33, Peter Lieven wrote:
this patch finally introduces multiread support to virtio-blk. While
multiwrite support was there for a long time, read support was missing.
The complete merge logic is moved into virtio-blk.c which has
been the only user of request merging ever since.
On 29 January 2015 at 15:06, Alexander Graf wrote:
> Now that we have a working "generic" PCIe host bridge driver, we can plug
> it into ARM's virt machine to always have PCIe available to normal ARM VMs.
> -/* 0x1000 .. 0x4000 reserved for PCI */
> +/* PCIe region layout: [ MMIO |
On 01/30/2015 09:32 AM, Kevin Wolf wrote:
Am 21.01.2015 um 10:34 hat Markus Armbruster geschrieben:
I'm afraid I forgot much of the discussion we had before the break, and
only now it's coming back, slowly.
Quoting myself on naming parameters identifying nodes[*]:
John Snow pointed out
On 30 January 2015 at 16:02, Maciej W. Rozycki wrote:
> Hmm, so perhaps my idea for a later improvement:
>
>> Eventually we might want to move the new inline functions into a
>> separate header to be included from softfloat.h instead of softfloat.c,
>> but let's make changes one step at a time.
On 01/30/2015 04:38 AM, Paolo Bonzini wrote:
On 30/01/2015 01:44, John Snow wrote:
Post-holiday bump that this is sitting out there, awaiting love.
If this gets merged, we should be able to enable Q35 migration soon,
which would be nice.
Not sure how valuable my opinion is as the author of
Hi all,
I'm investigating the current schemes for the VM live storage migration in
QEMU system. I have the following questions:
1. What is the functionality of drive_mirror in QEMU? Is it designed as a
VM live storage migration approach?
2. What's the difference between drive_mirror and vMotion?
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
>
> Oops, forgot to include Kevin and Stefan on cc for this.
Ping;
John R-b'd the two patches:
https://lists.gnu.org/archive/html/qemu-devel/2014-12/msg01133.html
http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01956.html
although
On 2015-01-29 at 04:37, Markus Armbruster wrote:
The QERR_ macros are leftovers from the days of "rich" error objects.
They're used with error_set() and qerror_report(), and expand into the
first *two* arguments. This trickiness has become pointless. Clean
up QERR_DEVICE_ENCRYPTED and QERR_DEVI
On 2015-01-30 at 09:33, Peter Lieven wrote:
Signed-off-by: Peter Lieven
---
block/block-backend.c | 5 +
include/sysemu/block-backend.h | 1 +
2 files changed, 6 insertions(+)
Reviewed-by: Max Reitz
On Fri, 30 Jan 2015, Leon Alrae wrote:
> > @@ -760,6 +760,6 @@ static inline int float128_is_any_nan(fl
> >
> > /*
> > | The pattern for a default generated quadruple-precision NaN.
> >
> > *--
On 2015-01-30 at 09:33, Peter Lieven wrote:
As it was not obvious (at least for me) where the 32 comes from;
add a constant for it.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
hw/block/virtio-blk.c | 2 +-
include/hw/virtio/virtio-blk.h | 4 +++-
2 files changed, 4 ins
On 30/01/15 18:42, Max Reitz wrote:
On 2015-01-30 at 10:41, Denis V. Lunev wrote:
On 30/01/15 17:58, Max Reitz wrote:
On 2015-01-30 at 03:42, Denis V. Lunev wrote:
There is a possibility that we are extending our image and thus
writing
zeroes beyond the end of the file. In this case we do not
On 2015-01-30 at 09:32, Peter Lieven wrote:
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
block.c| 2 ++
block/accounting.c | 7 +++
block/qapi.c | 2 ++
hmp.c | 6 +-
include/block/accounting.h | 3 +++
On 2015-01-30 at 10:41, Denis V. Lunev wrote:
On 30/01/15 17:58, Max Reitz wrote:
On 2015-01-30 at 03:42, Denis V. Lunev wrote:
There is a possibility that we are extending our image and thus writing
zeroes beyond the end of the file. In this case we do not need to care
about the hole to make s
On 30/01/15 17:58, Max Reitz wrote:
On 2015-01-30 at 03:42, Denis V. Lunev wrote:
There is a possibility that we are extending our image and thus writing
zeroes beyond the end of the file. In this case we do not need to care
about the hole to make sure that there is no data in the file under
thi
On 2015-01-29 at 21:49, Fam Zheng wrote:
This case utilizes qemu-io command "aio_{read,write} -q" to verify the
effectiveness of IO throttling options.
It's implemented by driving the vm timer from qtest protocol, so the
throttling timers are signaled with determinied time duration. Then we
veri
From: Fam Zheng
We have module build support around for a while, but also had it bitrot
several times. It probably makes sense to enable it by default so that
people can notice and use it.
Add --disable-modules as a counterpart to --enable-modules, which is
now turned on by default. If both are
This includes a (mangled) copy of the liburcu code. The main changes
are: 1) removing dependencies on many other header files in liburcu; 2)
removing for simplicity the tentative busy waiting in synchronize_rcu,
which has limited performance effects; 3) replacing futexes in
synchronize_rcu with Qe
With the introduction of QEMU_CLOCK_VIRTUAL_RT, the computation of
sc->diff_clk can be simplified nicely:
qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) -
qemu_clock_get_ns(QEMU_CLOCK_REALTIME) +
cpu_get_clock_offset()
= qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) -
(qemu_c
From: Fam Zheng
scsi_req_cancel_complete is responsible for releasing the request, so we
shouldn't skip it in any case. This doesn't affect the only existing
caller, virtio-scsi, but is useful for other devices once they use it.
Suggested-by: Paolo Bonzini
Signed-off-by: Fam Zheng
Signed-off-b
sc->diff_clk is already equal to sleep_delay (split in a second and a
nanosecond part). If you subtract sleep_delay - rem_delay, the result
is exactly rem_delay.
Cc: Sebastian Tanase
Signed-off-by: Paolo Bonzini
---
cpu-exec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
From: Jan Kiszka
Now that memory_region_destroy can be called from an RCU callback,
checking the BQL-protected global memory_region_transaction_depth
does not make much sense.
Signed-off-by: Jan Kiszka
Reviewed-by: Fam Zheng
Signed-off-by: Paolo Bonzini
---
memory.c | 1 -
1 file changed, 1
Do the entire lookup under RCU, which avoids atomic operations
in flatview_ref and flatview_unref.
Reviewed-by: Fam Zheng
Signed-off-by: Paolo Bonzini
---
memory.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/memory.c b/memory.c
index a844ced..9b91243 100644
--
rcutorture is the unit test for rcu.
Reviewed-by: Fam Zheng
Signed-off-by: Paolo Bonzini
---
tests/Makefile | 7 +-
tests/rcutorture.c | 448 +
2 files changed, 454 insertions(+), 1 deletion(-)
create mode 100644 tests/rcutorture.c
dif
The following changes since commit 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf:
Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127'
into staging (2015-01-27 22:25:56 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for y
Asynchronous callbacks provided by call_rcu are particularly important
for QEMU, because the BQL makes it hard to use synchronize_rcu.
In addition, the current RCU implementation is not particularly friendly
to multiple concurrent synchronize_rcu callers, making call_rcu even
more important.
Revi
Reviewed-by: Fam Zheng
Signed-off-by: Paolo Bonzini
---
include/qemu/rcu.h | 15 ++-
tests/rcutorture.c | 2 ++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
index cfef36e..da043f2 100644
--- a/include/qemu/rcu.h
+++ b/include
Replace the flat_view_mutex with RCU, avoiding futex contention for
dataplane on large systems and many iothreads.
Reviewed-by: Fam Zheng
Signed-off-by: Paolo Bonzini
---
include/exec/memory.h | 5 +
memory.c | 54 ++-
2 files ch
On 2015-01-29 at 04:37, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
block.c | 29 +
blockdev.c| 24 ++--
include/block/block.h | 1 +
monitor.c | 16 +++-
On 2015-01-29 at 04:36, Markus Armbruster wrote:
From: Markus Armbruster
Intentional?
The QERR_ macros are leftovers from the days of "rich" error objects.
They're used with error_set() and qerror_report(), and expand into the
first *two* arguments. This trickiness has become pointless. Cl
On 2015-01-29 at 04:36, Markus Armbruster wrote:
When find_block_job() fails, all its callers build the same Error
object. Build it in find_block_job() instead.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
blockdev.c | 19 ---
1 file changed, 8 insertions(+)
Simple "hello world" MIPS N32 userland program crashes with segfault due to
incorrectly defined stat structure in QEMU.
Correct "target_stat" definition to match kernel's "stat64" as in MIPS N32
there are only plain "stat" syscalls using 64-bit structure.
Reported-by: Daniel Sanders
Signed-off-b
On Thu, Jan 29, 2015 at 12:55 PM, Peter Maydell
wrote:
> Now we have the mmu_idx in get_phys_addr(), use it correctly to
> determine the behaviour of virtual to physical address translations,
> rather than using just an is_user flag and the current CPU state.
>
> Some TODO comments have been adde
On 2015-01-30 at 03:42, Denis V. Lunev wrote:
This sequence works efficiently if FALLOC_FL_ZERO_RANGE is not supported.
Unfortunately, FALLOC_FL_ZERO_RANGE is supported on really modern systems
and only for a couple of filesystems. FALLOC_FL_PUNCH_HOLE is much more
mature.
The sequence of 2 oper
Asynchronous callbacks provided by call_rcu are particularly important
for QEMU, because the BQL makes it hard to use synchronize_rcu.
In addition, the current RCU implementation is not particularly friendly
to multiple concurrent synchronize_rcu callers, making call_rcu even
more important.
Revi
1 - 100 of 222 matches
Mail list logo