On 01/30/2015 02:06 AM, Vladimir Sementsov-Ogievskiy wrote: > is it better to add qmp_query_dirty_bitmap with underlying > bdrv_query_dirty_bitmap, or to modify (add dirty regions information) > existing qmp_query_block/qmp_query_dirty_bitmapS?
[please don't top-post on technical lists] Extending an existing command may be reasonable, if the amount of information being added is compact (if you are adding several kilobytes of information, that might justify a new command, if only so that old callers don't waste time receiving large amounts of data on the wire just to sift through and discard it all to get at the older content they cared about). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
