Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-27 Thread Michael S. Tsirkin
> I've tried redo series with passing alloc list as first argument, > looks ugly as hell I tried too. Not too bad at all. See below: diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index f66da5d..820504a 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -491,14 +491,14 @@ s

[Qemu-devel] [PATCH v2 5/5] acpi, piix4: Add unplug cb for piix4.

2015-01-27 Thread Zhu Guihua
From: Tang Chen Memory and CPU hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds hotunplug cb to piix4, which me

[Qemu-devel] [PATCH v2 3/5] acpi, pc: Add unplug cb for pc machine.

2015-01-27 Thread Zhu Guihua
From: Tang Chen Memory and CPU hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds hotunplug cb to pc machine, whi

[Qemu-devel] [PATCH v2 1/5] acpi, pc: Add hotunplug request cb for pc machine.

2015-01-27 Thread Zhu Guihua
From: Tang Chen Memory and CPU hot unplug are both asynchronous procedures. They both need unplug request callback to initiate unplug operation. Add unplug handler to pc machine that will be used by following CPU and memory unplug patches. Reviewed-by: Igor Mammedov Signed-off-by: Tang Chen S

[Qemu-devel] [PATCH v2 2/5] acpi, ich9: Add hotunplug request cb for ich9.

2015-01-27 Thread Zhu Guihua
From: Tang Chen Memory and CPU hot unplug are both asynchronous procedures. They both need unplug request cb when the unplug operation happens. This patch adds hotunplug request cb for ich9, and memory and CPU hot unplug will share it. Reviewed-by: Igor Mammedov Signed-off-by: Tang Chen Signe

[Qemu-devel] [PATCH v2 4/5] acpi, ich9: Add unplug cb for ich9.

2015-01-27 Thread Zhu Guihua
From: Tang Chen Memory and CPU hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds hotunplug cb to ich9, which mem

[Qemu-devel] [PATCH v2 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug

2015-01-27 Thread Zhu Guihua
Memory and CPU hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to do the real removal of device. They both need pc-machine, piix4 and ich9 unplug and unplug reque

Re: [Qemu-devel] [PATCH v3 6/8] acpi: add build_append_namestring() helper

2015-01-27 Thread Michael S. Tsirkin
On Fri, Dec 19, 2014 at 11:47:02AM +, Igor Mammedov wrote: > Use build_append_namestring() instead of build_append_nameseg() > So user won't have to care whether name is NameSeg, NamePath or > NameString. > > See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding > > Signed-off-by: Igor Mamm

Re: [Qemu-devel] [PATCH v2 00/47] ACPI refactoring: replace template patching with C ASL API

2015-01-27 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:49:44PM +, Igor Mammedov wrote: > Git tree for playing with: > https://github.com/imammedo/qemu/commits/ASL_API_v2 > > Igor Mammedov (47): > acpi: introduce AML composer aml_append() > acpi: add acpi_scope() term > acpi: add acpi_device() term > acpi: add

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-27 Thread Michael S. Tsirkin
On Tue, Jan 27, 2015 at 11:29:09PM +0100, Igor Mammedov wrote: > On Mon, 26 Jan 2015 18:17:55 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Jan 26, 2015 at 04:34:01PM +0100, Andrew Jones wrote: > > > On Mon, Jan 26, 2015 at 04:09:20PM +0100, Igor Mammedov wrote: > > > > On Mon, 26 Jan 2015 10

Re: [Qemu-devel] [PATCH 1/2] vl.c: Fix error messages when parsing maxmem parameters

2015-01-27 Thread Peter Krempa
On Tue, Jan 27, 2015 at 11:15:41 -0700, Eric Blake wrote: > On 01/26/2015 08:31 AM, Peter Krempa wrote: > > Produce more human readable error messages and fix few spelling > > mistakes. > > > > Also remove a redundant check for the max memory size. > > > > Signed-off-by: Peter Krempa > > --- > >

Re: [Qemu-devel] Submit your Google Summer of Code project ideas and volunteer to mentor

2015-01-27 Thread Hannes Reinecke
On 01/27/2015 06:55 PM, John Snow wrote: > > > On 01/27/2015 07:48 AM, Hannes Reinecke wrote: >> On 01/23/2015 06:21 PM, Stefan Hajnoczi wrote: >>> Dear libvirt, KVM, and QEMU contributors, >>> The Google Summer of Code season begins soon and it's time to >>> collect >>> our thoughts for mentorin

Re: [Qemu-devel] [PATCH RESEND 0/2] PoC: Block replication for continuous checkpointing

2015-01-27 Thread Wen Congyang
On 12/27/2014 11:23 PM, Paolo Bonzini wrote: > > > On 26/12/2014 04:31, Yang Hongyang wrote: >> Please feel free to comment. >> We want comments/feedbacks as many as possiable please, thanks in advance. > > Hi Yang, > > I think it's possible to build COLO block replication from many basic > blo

[Qemu-devel] [Bug 1415181] Re: Access raw partitions from Windows

2015-01-27 Thread Stefan Weil
I am not sure whether I have understood your request completely. QEMU can access raw partitions if the OS supports them. MS Windows supports physical partitions and calls them \\.\PhysicalDrive0, \\.\PhysicalDrive1 and so on. Admin rights are required to access these devices. Depending on your shel

Re: [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files

2015-01-27 Thread Denis V. Lunev
On 27/01/15 21:05, Max Reitz wrote: On 2015-01-27 at 08:51, Denis V. Lunev wrote: fallocate() works fine and could handle properly with arbitrary size requests. Maybe "could properly handle arbitrary size requests" (or "...arbitrarily sized requests")? There is no sense to reduce the amoun

Re: [Qemu-devel] [RFC PATCH 02/11] hw/arm/virt-acpi-build: Basic framework for building ACPI tables

2015-01-27 Thread Shannon Zhao
On 2015/1/27 18:30, Igor Mammedov wrote: > On Tue, 27 Jan 2015 14:47:44 +0800 > Shannon Zhao wrote: > >> On 2015/1/26 18:19, Igor Mammedov wrote: >>> On Sat, 24 Jan 2015 17:21:11 +0800 >>> Shannon Zhao wrote: >>> Introduce a preliminary framework in virt-acpi-build.c with the main ACPI

Re: [Qemu-devel] [PATCH 10/15] exec: RCUify AddressSpaceDispatch

2015-01-27 Thread Fam Zheng
On Thu, 01/22 15:47, Paolo Bonzini wrote: > Note that even after this patch, most callers of address_space_* > functions must still be under the big QEMU lock, otherwise the memory > region returned by address_space_translate can disappear as soon as > address_space_translate returns. This will be

Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support

2015-01-27 Thread Michael Roth
Quoting Bharata B Rao (2015-01-27 22:19:56) > On Thu, Jan 22, 2015 at 04:16:01PM -0600, Michael Roth wrote: > > Quoting Bharata B Rao (2015-01-08 00:10:13) > > > +static void spapr_machine_device_plug(HotplugHandler *hotplug_dev, > > > + DeviceState *dev, Error

Re: [Qemu-devel] [PATCHv2 7/8] pseries: Move rtc_offset into RTC device's state structure

2015-01-27 Thread David Gibson
On Tue, Dec 23, 2014 at 07:41:22AM +0100, Alexander Graf wrote: > > > > > Am 23.12.2014 um 04:56 schrieb David Gibson : > > > >> On Tue, Dec 23, 2014 at 01:30:11AM +0100, Alexander Graf wrote: > >> > >> > >>> On 23.12.14 01:17, David Gibson wrote: > >>> The initial creation of the PAPR RTC qd

Re: [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps

2015-01-27 Thread David Gibson
On Tue, Jan 27, 2015 at 10:04:31AM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Wed, Dec 17, 2014 at 06:21:34PM +, Dr. David Alan Gilbert wrote: > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > On Fri, Oct 03, 2014 at 06:47:4

Re: [Qemu-devel] [PATCHv2 8/8] pseries: Export RTC time via QOM

2015-01-27 Thread David Gibson
On Tue, Dec 23, 2014 at 07:33:30AM +0100, Alexander Graf wrote: > > > > > Am 23.12.2014 um 04:14 schrieb David Gibson : > > > >> On Tue, Dec 23, 2014 at 01:26:58AM +0100, Alexander Graf wrote: > >> > >> > >>> On 23.12.14 01:17, David Gibson wrote: > >>> On x86, the guest's RTC can be read wit

Re: [Qemu-devel] [PATCH v4 37/47] Page request: Consume pages off the post-copy queue

2015-01-27 Thread David Gibson
On Tue, Jan 27, 2015 at 09:40:12AM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Wed, Jan 14, 2015 at 08:13:27PM +, Dr. David Alan Gilbert wrote: > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > On Fri, Oct 03, 2014 at 06:47:4

Re: [Qemu-devel] [PATCH v2] linux-user/main.c: Remove redundant end_exclusive() in arm_kernel_cmpxchg64_helper()

2015-01-27 Thread Chen Gang S
On 1/28/15 00:11, Michael Tokarev wrote: > 25.01.2015 14:03, Chen Gang S wrote: >> start/end_exclusive() need be pairs, except the start_exclusive() in > > "need TO be pairs", or "should be pairs" or "should be called in pairs". > >> stop_all_tasks() which is only used by force_sig(), which will

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-27 Thread Xu, Quan
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Tuesday, January 20, 2015 1:19 AM > To: Xu, Quan > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > stefano.stabell...@eu.citrix.com > Subject: Re: [v3 3/5] Qemu-Xen-vTPM: Register Xen s

Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support

2015-01-27 Thread Bharata B Rao
On Thu, Jan 22, 2015 at 04:16:01PM -0600, Michael Roth wrote: > Quoting Bharata B Rao (2015-01-08 00:10:13) > > +static void spapr_machine_device_plug(HotplugHandler *hotplug_dev, > > + DeviceState *dev, Error **errp) > > +{ > > +if (object_dynamic_cast(OBJE

Re: [Qemu-devel] [PATCH v4 08/17] spapr_events: re-use EPOW event infrastructure for hotplug events

2015-01-27 Thread Bharata B Rao
On Mon, Jan 26, 2015 at 10:26 PM, Michael Roth wrote: > Quoting David Gibson (2015-01-18 22:31:23) >> On Tue, Dec 23, 2014 at 06:30:22AM -0600, Michael Roth wrote: >> > + >> > +static void spapr_hotplug_req_event(sPAPRDRConnector *drc, uint8_t >> > hp_action) >> > +{ >> > +struct hp_log_full

Re: [Qemu-devel] [PATCH 09/50] block: Move guest_block_size into BlockBackend

2015-01-27 Thread John Priddy
I think I mistakenly got put on the CC list for this. Can the next replyer please remove j...@redhat.com? Thanks. -- John Priddy Solutions Architect Red Hat +1 (917) 576-8023 - Mobile j...@redhat.com - Original Message - > From: "Eric Blake" > To: "Max Reitz" , qemu-devel@nongnu.org >

[Qemu-devel] Multicast network breaks under high load

2015-01-27 Thread Brian Rak
I have two Ubuntu 14.04 KVM instances (kernel version 3.16.0-29-generic). (Running under qemu 2.2.0) They're connected using qemu's 'multicast' network type, and basic connectivity works fine. I can ping between the guests, they can transfer data, etc. I'll refer to them this way: guest1 -

[Qemu-devel] [Bug 1415181] [NEW] Access raw partitions from Windows

2015-01-27 Thread Sebastián Lacuesta
Public bug reported: I'm using a windows tablet that makes imposible usb booting. It would be nice to have access to raw partitions in order to run linux installers using qemu. I can successfully install several boot loaders using uefi, so I gues this feature would be very helpful. Thanks! **

Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Free the vec[i] in failure processing code block

2015-01-27 Thread Chen Gang S
Firstly, thank you for your work about the related patches and replying so much details. On 1/27/15 19:04, Michael Tokarev wrote: > 23.01.2015 13:01, Chen Gang S wrote: >> When failure occurs during allocating vec[i], also need free all >> allocated vec[i] in failure processing code block before

[Qemu-devel] [PATCH v6 3/5] qemu-iotests: Add VM method qtest() to iotests.py

2015-01-27 Thread Fam Zheng
This will allow test cases to run command in qtest protocol. It's write-only for now. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/iotests.py | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qem

[Qemu-devel] [PATCH v6 1/5] qemu-io: Account IO by aio_read and aio_write

2015-01-27 Thread Fam Zheng
This will enable accounting of aio requests issued from qemu-io aio read/write commands. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- qemu-io-cmds.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index e708552..29377cd 100644 --- a/qemu-i

[Qemu-devel] [PATCH v6 5/5] qemu-iotests: Add 093 for IO throttling

2015-01-27 Thread Fam Zheng
This case utilizes qemu-io command "aio_{read,write} -q" to verify the effectiveness of IO throttling options. It's implemented by driving the vm timer from qtest protocol, so the throttling timers are signaled with determinied time duration. Then we verify the completed IO requests are within 10%

[Qemu-devel] [PATCH v6 2/5] qtest: Add scripts/qtest.py

2015-01-27 Thread Fam Zheng
This adds scripts/qtest.py as a python library for qtest protocol. This is a skeleton with a basic "cmd" method to execute a command, reading and parsing of qtest output could be added later on demand. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- scripts/qtest.py | 71 ++

[Qemu-devel] [PATCH v6 0/5] block: Add a qemu-iotests case for IO throttling

2015-01-27 Thread Fam Zheng
v6: Less resource demanding patch 5. (Max) Add rev-by of Max to other patches. v5: Rebase and improve the test. Please review again. Patch dependencies: This test depends on the qtest timer fix to run correctly. http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01865.html

[Qemu-devel] [PATCH v6 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp

2015-01-27 Thread Fam Zheng
QMP command "block_set_io_throttle" expects underscores in parameters instead of dashes: {iops,bps}_{rd,wr,max}. Add optional argument conv_keys (defaults to True, backward compatible), it will be used in IO throttling test case. Reviewed-by: Benoit Canet Signed-off-by: Fam Zheng Reviewed-by: M

Re: [Qemu-devel] [PATCH 2/2] target-openrisc: Add l.lwa/l.swa support

2015-01-27 Thread Jia Liu
On Mon, Jan 26, 2015 at 6:18 PM, Sebastian Macke wrote: > Hi Jia, > > > On 1/26/2015 10:50 AM, Jia Liu wrote: >> >> Hi Sebastian, Christian >> >> On Sun, Jan 25, 2015 at 6:25 PM, Sebastian Macke >> wrote: >>> >>> From: Christian Svensson >>> >>> This patch adds support for atomic locks >>> and i

Re: [Qemu-devel] [PATCH v5 5/5] qemu-iotests: Add 093 for IO throttling

2015-01-27 Thread Fam Zheng
On Tue, 01/27 11:14, Max Reitz wrote: > On 2015-01-26 at 22:03, Fam Zheng wrote: > >On Mon, 01/26 15:45, Max Reitz wrote: > >>On 2015-01-16 at 03:46, Fam Zheng wrote: > >>>This case utilizes qemu-io command "aio_{read,write} -q" to verify the > >>>effectiveness of IO throttling options. > >>> > >>>

[Qemu-devel] [PATCH] qed: Really remove unused field QEDAIOCB.finished

2015-01-27 Thread Fam Zheng
The commit 533ffb17a that removed qed_aiocb_info.cancel said to remove this but didn't do it. Signed-off-by: Fam Zheng --- block/qed.h | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qed.h b/block/qed.h index d3934a0..615e676 100644 --- a/block/qed.h +++ b/block/qed.h @@ -133,7 +133,6 @

Re: [Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-27 Thread Gonglei
On 2015/1/27 18:49, Dinar Valeev wrote: > On 01/27/2015 10:18 AM, Gonglei wrote: >> On 2015/1/27 16:57, Dinar Valeev wrote: >> >>> On 01/27/2015 03:51 AM, Gonglei wrote: On 2015/1/27 7:52, dval...@suse.de wrote: > From: Dinar Valeev > > on sPAPR we need to update boot_order

[Qemu-devel] [PATCH RESEND 24/50] blockdev: Check BB validity in block-stream

2015-01-27 Thread Max Reitz
Call blk_is_available() before using blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Signed-off-by: Max Reitz --- blockdev.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9801a7e..74d26a6 100644 --- a/blockd

[Qemu-devel] [PATCH RESEND 13/50] block: Add BlockBackendRootState

2015-01-27 Thread Max Reitz
This structure will store some of the state of the root BDS if the BDS tree is removed, so that state can be restored once a new BDS tree is inserted. Signed-off-by: Max Reitz --- block/block-backend.c | 26 ++ include/block/block_int.h | 9 + inclu

[Qemu-devel] [Bug 1368815] Change abandoned on nova (master)

2015-01-27 Thread OpenStack Infra
Change abandoned by Tony Breeds (t...@bakeyournoodle.com) on branch: master Review: https://review.openstack.org/123957 Reason: The main distros we care about have landed or are in progress. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

[Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA

2015-01-27 Thread Max Reitz
In the drive-backup transaction, call blk_is_available() before using blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Signed-off-by: Max Reitz --- blockdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 0

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-01-27 Thread Michael Roth
Quoting Tyrel Datwyler (2015-01-27 16:05:52) > On 01/27/2015 01:36 PM, Michael Roth wrote: > > Quoting David Gibson (2015-01-26 23:24:11) > >> On Sun, Jan 25, 2015 at 11:21:26PM -0600, Michael Roth wrote: > >>> Quoting David Gibson (2015-01-16 00:21:55) > On Tue, Dec 23, 2014 at 06:30:17AM -06

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-27 Thread Chen, Tiejun
On 2015/1/27 22:40, Ian Jackson wrote: Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"): On 2015/1/23 8:43, Chen, Tiejun wrote: On 2015/1/22 8:51, Chen, Tiejun wrote: At this point I just concern here if we still use 'gfx

Re: [Qemu-devel] [PATCH] target-mips: fix CP0.BadVAddr by stopping translation on Address error

2015-01-27 Thread Maciej W. Rozycki
On Mon, 26 Jan 2015, Leon Alrae wrote: > BadVAddr is supposed to capture the most recent address that caused > the exception. Currently this is not happening as translation is not stopped > and BadVAddr is updated with subsequent addresses. > > Signed-off-by: Leon Alrae > --- I think this dese

Re: [Qemu-devel] [PATCH] target-mips: ll and lld cause AdEL exception for unaligned address

2015-01-27 Thread Maciej W. Rozycki
On Mon, 26 Jan 2015, Leon Alrae wrote: > Signed-off-by: Leon Alrae > --- Reviewed-by: Maciej W. Rozycki Maciej

Re: [Qemu-devel] [PATCH] target-mips: fix detection of the end of the page during translation

2015-01-27 Thread Maciej W. Rozycki
On Mon, 26 Jan 2015, Leon Alrae wrote: > The test is supposed to terminate TB if the end of the page is reached. > However, with current implementation it may never succeed for microMIPS or > mips16. > > Reported-by: Richard Henderson > Signed-off-by: Leon Alrae > --- I'm not sure if you need

[Qemu-devel] [PATCH v3 2/4] target-arm: Add feature parsing to virt

2015-01-27 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows --- v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(

[Qemu-devel] [PATCH v3 3/4] target-arm: Add 32/64-bit register sync

2015-01-27 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows --- v2 -> v3 - Conditionalize interrupt handler update of aarch64. --- target-arm/helpe

[Qemu-devel] [PATCH v3 4/4] target-arm: Add AArch32 guest support to KVM64

2015-01-27 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows --- v2 -> v3 - Conditionalize sync of 32-bit and 64-bit registers --- target-arm/kvm64.c | 33 + 1 file changed, 29

[Qemu-devel] [PATCH v3 1/4] target-arm: Add CPU property to disable AArch64

2015-01-27 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state dis

[Qemu-devel] [PATCH v3 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-01-27 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU co

Re: [Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > In the drive-backup transaction, call blk_is_available() before using > blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Took me a while to figure that TA meant transaction in the subject. Either spell it out, or just drop 'TA' entire

Re: [Qemu-devel] [PULL 00/11] linux-user-updates

2015-01-27 Thread Peter Maydell
available in the git repository at: > > git://git.linaro.org/people/riku.voipio/qemu.git > tags/pull-linux-user-20150127 > > for you to fetch changes up to 30b8b68eb574fd68060eebcc4da790fdfe18d668: > > linux-user: support targe

Re: [Qemu-devel] [PATCH RESEND 21/50] blockdev: Check BB validity in internal snapshot TA

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > Call blk_is_available() before using blk_bs() to obtain the root > BlockDriverState behind the BlockBackend. > > Signed-off-by: Max Reitz > --- > blockdev.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v1 1/2] target_arm: Remove memory region init from armv7m_init

2015-01-27 Thread Alistair Francis
On Wed, Jan 28, 2015 at 4:37 AM, Peter Maydell wrote: > On 24 January 2015 at 08:02, Alistair Francis wrote: >> This patch moves the memory region init code from the >> armv7m_init function to the stellaris_init function >> >> Signed-off-by: Alistair Francis >> Reviewed-by: Peter Crosthwaite >>

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-27 Thread Igor Mammedov
On Mon, 26 Jan 2015 18:17:55 +0200 "Michael S. Tsirkin" wrote: > On Mon, Jan 26, 2015 at 04:34:01PM +0100, Andrew Jones wrote: > > On Mon, Jan 26, 2015 at 04:09:20PM +0100, Igor Mammedov wrote: > > > On Mon, 26 Jan 2015 10:57:21 +0100 > > > Igor Mammedov wrote: > > > > > > > On Sat, 24 Jan 2015

[Qemu-devel] [PULL 07/11] linux-user: translate resource also for prlimit64

2015-01-27 Thread riku . voipio
From: Felix Janda The resource argument is translated from host to target for [gs]etprlimit but not for prlimit64. Fix this. Signed-off-by: Felix Janda Signed-off-by: Riku Voipio --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.

[Qemu-devel] [PULL 06/11] linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user

2015-01-27 Thread riku . voipio
From: Peter Maydell The function copy_siginfo_to_user() just calls tswap_siginfo(), so call the latter function directly and delete the wrapper function. The wrapper is actually misleading since it implies that the semantics are like the kernel function with the same name which copies the data to

Re: [Qemu-devel] [PATCH v2 4/4] target-arm: Add AArch32 guest support to KVM64

2015-01-27 Thread Greg Bellows
On Tue, Jan 27, 2015 at 3:21 PM, Christoffer Dall < christoffer.d...@linaro.org> wrote: > On Wed, Jan 21, 2015 at 12:49:53PM -0600, Greg Bellows wrote: > > Add 32-bit to/from 64-bit register synchronization on register gets and > puts. > > Set EL1_32BIT feature flag passed to KVM > > > > Signed-of

[Qemu-devel] [PULL 05/11] linux-user/main.c: Mark end_exclusive() as possibly unused

2015-01-27 Thread riku . voipio
From: Peter Maydell The function end_exclusive() isn't used on all targets; mark it as such to avoid a clang warning. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-use

[Qemu-devel] [PULL 08/11] linux-user: Fix ioctl cmd type mismatch on 64-bit targets

2015-01-27 Thread riku . voipio
From: Ed Swierk linux-user passes the cmd argument of the ioctl syscall as a signed long, but compares it to an unsigned int when iterating through the ioctl_entries list. When the cmd is a large value like 0x80047476 (TARGET_TIOCSWINSZ on mips64) it gets sign-extended to 0x80047476, cau

Re: [Qemu-devel] [PATCH RESEND 19/50] blockdev: Use BlockBackend for blockdev-backup TA

2015-01-27 Thread Max Reitz
On 2015-01-27 at 16:59, Eric Blake wrote: On 01/27/2015 12:45 PM, Max Reitz wrote: When preparing a blockdev-backup transaction, the BlockBackend should be used because there may be no medium associated to the BB (which would make bdrv_find() fail, whereas blk_by_name() does not). This does not

Re: [Qemu-devel] [PATCH RESEND 20/50] blockdev: Check blk_is_available() in sn-del-int-sync

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > Check whether the BlockBackend is actually available at the start of > snapshot-delete-internal-sync. Cute abbreviation in the subject line. > > Signed-off-by: Max Reitz > --- > blockdev.c | 18 +- > 1 file changed, 13 insertions(+), 5

[Qemu-devel] [PULL 00/11] linux-user-updates

2015-01-27 Thread riku . voipio
o/qemu.git tags/pull-linux-user-20150127 for you to fetch changes up to 30b8b68eb574fd68060eebcc4da790fdfe18d668: linux-user: support target-to-host SCM_CREDENTIALS (2015-01-27 22:33:57 +0200) linux-user updates since last pu

[Qemu-devel] [PULL 04/11] linux-user/main.c: Call cpu_exec_start/end on all target archs

2015-01-27 Thread riku . voipio
From: Peter Maydell The start_exclusive() infrastructure is used on all target architectures, even if only to do the "stop all CPUs before dumping core" in force_sig(), so be consistent and call cpu_exec_start/end in the main loop of every target. Signed-off-by: Peter Maydell Signed-off-by: Rik

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-01-27 Thread Tyrel Datwyler
On 01/27/2015 01:36 PM, Michael Roth wrote: > Quoting David Gibson (2015-01-26 23:24:11) >> On Sun, Jan 25, 2015 at 11:21:26PM -0600, Michael Roth wrote: >>> Quoting David Gibson (2015-01-16 00:21:55) On Tue, Dec 23, 2014 at 06:30:17AM -0600, Michael Roth wrote: > From: Nathan Fontenot >>

Re: [Qemu-devel] [PATCH RESEND 19/50] blockdev: Use BlockBackend for blockdev-backup TA

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > When preparing a blockdev-backup transaction, the BlockBackend should be > used because there may be no medium associated to the BB (which would > make bdrv_find() fail, whereas blk_by_name() does not). > > This does not make a real difference because blo

Re: [Qemu-devel] [PATCH RESEND 18/50] block: Respect empty BB in bdrv_query_info()

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/qapi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.a

Re: [Qemu-devel] [PATCH RESEND 17/50] block: Respect empty BB in bdrv_lookup_bs()

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > blk_by_name() may return a BlockBackend for which blk_bs() returns NULL. > In this case, an error should be returned (instead of just returning > NULL without modifying *errp). > > Signed-off-by: Max Reitz > --- > block.c | 5 + > 1 file changed, 5

[Qemu-devel] [PULL 10/11] linux-user: Fix broken m68k signal handling on 64 bit hosts

2015-01-27 Thread riku . voipio
From: Peter Maydell The m68k signal frame setup code which writes the signal return trampoline code to the stack was assuming that a 'long' was 32 bits; on 64 bit systems this meant we would end up writing the 32 bit (2 insn) trampoline sequence to retaddr+4,retaddr+6 instead of the intended reta

[Qemu-devel] [PULL 01/11] linux-user/signal.c: Remove current_exec_domain_sig()

2015-01-27 Thread riku . voipio
From: Peter Maydell Remove the function current_exec_domain_sig(), which always returns its argument. This was intended as a stub for supporting the kernel's exec_domain handling, but: * we don't have any of the other code for execution domains * in the kernel this handling is architecture-spec

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: Add 32/64-bit register sync

2015-01-27 Thread Greg Bellows
On Tue, Jan 27, 2015 at 3:20 PM, Christoffer Dall < christoffer.d...@linaro.org> wrote: > On Wed, Jan 21, 2015 at 12:49:52PM -0600, Greg Bellows wrote: > > Add AArch32 to AArch64 register sychronization functions. > > Replace manual register synchronization with new functions in > > aarch64_cpu_do

Re: [Qemu-devel] [PATCH RESEND 16/50] block: Prepare remaining BB functions for NULL BDS

2015-01-27 Thread Max Reitz
On 2015-01-27 at 16:36, Eric Blake wrote: On 01/27/2015 12:45 PM, Max Reitz wrote: There are several BlockBackend functions which, in theory, cannot fail. This patch makes them cope with the BlockDriverState pointer being NULL by making them fall back to some default action like ignoring the val

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-01-27 Thread Michael Roth
Quoting David Gibson (2015-01-26 23:24:11) > On Sun, Jan 25, 2015 at 11:21:26PM -0600, Michael Roth wrote: > > Quoting David Gibson (2015-01-16 00:21:55) > > > On Tue, Dec 23, 2014 at 06:30:17AM -0600, Michael Roth wrote: > > > > From: Nathan Fontenot > > > > > > > > Signed-off-by: Nathan Fonteno

[Qemu-devel] [PULL 09/11] mips64-linux-user: Fix definition of struct sigaltstack

2015-01-27 Thread riku . voipio
From: Ed Swierk Without this fix, qemu segfaults when emulating the sigaltstack syscall, because it incorrectly treats the ss_flags field as 64 bits rather than 32 bits. Signed-off-by: Ed Swierk Signed-off-by: Riku Voipio --- linux-user/mips64/target_signal.h | 2 +- 1 file changed, 1 inserti

Re: [Qemu-devel] [PATCH RESEND 16/50] block: Prepare remaining BB functions for NULL BDS

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > There are several BlockBackend functions which, in theory, cannot fail. > This patch makes them cope with the BlockDriverState pointer being NULL > by making them fall back to some default action like ignoring the value > in setters and returning the defau

Re: [Qemu-devel] [PATCH RESEND 15/50] block: Fail requests to empty BlockBackend

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > If there is no BlockDriverState in a BlockBackend or if the tray of the > guest device is open, fail all requests (where that is possible) with > -ENOMEDIUM. > > The reason the status of the guest device is taken into account is > because once the guest d

Re: [Qemu-devel] [PATCH v2 06/15] libqos: Update QGuestAllocator to be opaque

2015-01-27 Thread Marc Marí
El Mon, 19 Jan 2015 15:15:54 -0500 John Snow escribió: > To avoid the architecture-specific implementations of the generic > qtest allocator having to know about fields within the allocator, add > a page_size setter method for users or arch specializations to use. > The allocator will assume a def

Re: [Qemu-devel] [PATCH v2] spapr_vio/spapr_iommu: Move VIO bypass where it belongs

2015-01-27 Thread Alexey Kardashevskiy
On 01/27/2015 05:13 PM, Alexey Kardashevskiy wrote: > Instead of tweaking a TCE table device by adding there a bypass flag, > let's add an alias to RAM and IOMMU memory region, and enable/disable > those according to the selected bypass mode. > This way IOMMU memory region can have size of the actu

Re: [Qemu-devel] [PATCH v2 4/4] target-arm: Add AArch32 guest support to KVM64

2015-01-27 Thread Christoffer Dall
On Wed, Jan 21, 2015 at 12:49:53PM -0600, Greg Bellows wrote: > Add 32-bit to/from 64-bit register synchronization on register gets and puts. > Set EL1_32BIT feature flag passed to KVM > > Signed-off-by: Greg Bellows > --- > target-arm/kvm64.c | 21 + > 1 file changed, 17 ins

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: Add 32/64-bit register sync

2015-01-27 Thread Christoffer Dall
On Wed, Jan 21, 2015 at 12:49:52PM -0600, Greg Bellows wrote: > Add AArch32 to AArch64 register sychronization functions. > Replace manual register synchronization with new functions in > aarch64_cpu_do_interrupt() and HELPER(exception_return)(). > > Signed-off-by: Greg Bellows > --- > target-ar

Re: [Qemu-devel] [PATCH RESEND 14/50] block: Make some BB functions fall back to BBRS

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > If there is no BDS tree attached to a BlockBackend, functions that can > do so should fall back to the BlockBackendRootState structure (which are > blk_is_read_only() and blk_get_flags(), because the read-only status and > the "open flags" are part of the

[Qemu-devel] [PULL 02/11] linux-user/alpha: Add define for NR_shmat to enable shmat syscall

2015-01-27 Thread riku . voipio
From: Peter Maydell For historical reasons, the define for the shmat() syscall on Alpha is NR_osf_shmat; however it has the same semantics as this syscall does on all other architectures, so define TARGET_NR_shmat as well so that QEMU's code for the syscall is enabled. This patch brings our beha

[Qemu-devel] [PULL 11/11] linux-user: support target-to-host SCM_CREDENTIALS

2015-01-27 Thread riku . voipio
From: Alex Suykov When passing ancillary data through a unix socket, handle credentials properly instead of doing a simple copy and issuing a warning. Signed-off-by: Alex Suykov Signed-off-by: Riku Voipio --- linux-user/syscall.c | 18 ++ 1 file changed, 14 insertions(+), 4 de

[Qemu-devel] [PULL 03/11] linux-user/arm/nwfpe: Delete unused aCC array

2015-01-27 Thread riku . voipio
From: Peter Maydell The aCC array in fpopcode.c is completely unused in QEMU; delete it (silencing a clang warning). Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/arm/nwfpe/fpopcode.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/linux-use

Re: [Qemu-devel] [PATCH v2 00/15] ahci-test preliminary refactoring

2015-01-27 Thread John Snow
Ping: Waiting for reviews on patches #6 (Marc?), and re-reviews for patches #12 and #15 (Paolo?) Thanks --JS On 01/19/2015 03:15 PM, John Snow wrote: This series aims to do two main things: (1) Eliminate global state out of the ahci-test file so that the tests are more functional. This w

Re: [Qemu-devel] [PATCH RESEND 13/50] block: Add BlockBackendRootState

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > This structure will store some of the state of the root BDS if the BDS > tree is removed, so that state can be restored once a new BDS tree is > inserted. > > Signed-off-by: Max Reitz > --- > block/block-backend.c | 26 +

Re: [Qemu-devel] VersatilePB bug (or undefined behaviour)

2015-01-27 Thread Peter Maydell
On 27 January 2015 at 20:04, Marc Marí wrote: > The problem was mine, I specified (because I did not change if from > previous boots) 1G as memory for the Versatile machine, which only has > 256 MB of RAM > > Should this be a bug, or is undefined behaviour? I think it is not very > difficult to ch

[Qemu-devel] [PATCH RESEND 37/50] block: Add blk_remove_bs()

2015-01-27 Thread Max Reitz
This function removes the BlockDriverState associated with the given BlockBackend from that BB and sets the BDS pointer in the BB to NULL. Signed-off-by: Max Reitz --- block/block-backend.c | 22 +- include/sysemu/block-backend.h | 1 + 2 files changed, 22 insertion

Re: [Qemu-devel] [PATCH RESEND 12/50] block: Move I/O status and error actions into BB

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > These options are only relevant for the user of a whole BDS tree (like a > guest device or a block job) and should thus be moved into the > BlockBackend. > > Signed-off-by: Max Reitz > --- > block.c| 125 > --

[Qemu-devel] [PATCH RESEND 21/50] blockdev: Check BB validity in internal snapshot TA

2015-01-27 Thread Max Reitz
Call blk_is_available() before using blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Signed-off-by: Max Reitz --- blockdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 858d181..012c603 100644 --- a/blockdev.c

[Qemu-devel] [PATCH RESEND 47/50] blockdev: Add read-only option to blockdev-change-medium

2015-01-27 Thread Max Reitz
Add an option to qmp_blockdev_change_medium() which allows changing the read-only status of the block device whose medium is changed. Some drives do not have a inherently fixed read-only status; for instance, floppy disks can be set read-only or writable independently of the drive. Some users may

[Qemu-devel] [PATCH RESEND 01/50] blockdev: Allow creation of BDS trees without BB

2015-01-27 Thread Max Reitz
If the "id" field is missing from the options given to blockdev-add, just omit the BlockBackend and create the BlockDriverState tree alone. Signed-off-by: Max Reitz --- blockdev.c | 38 +- tests/qemu-iotests/087 | 20 t

[Qemu-devel] [PATCH RESEND 14/50] block: Make some BB functions fall back to BBRS

2015-01-27 Thread Max Reitz
If there is no BDS tree attached to a BlockBackend, functions that can do so should fall back to the BlockBackendRootState structure (which are blk_is_read_only() and blk_get_flags(), because the read-only status and the "open flags" are part of the BBRS). Signed-off-by: Max Reitz --- block/bloc

Re: [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into BlockBackend

2015-01-27 Thread Eric Blake
[replies to earlier patches in the other thread; moving the rest of my review here for the sake of improved cc] On 01/27/2015 12:45 PM, Max Reitz wrote: > As the comment above bdrv_get_stats() says, BlockAcctStats is something > which belongs to the device instead of each BlockDriverState. This pa

[Qemu-devel] [PATCH RESEND 20/50] blockdev: Check blk_is_available() in sn-del-int-sync

2015-01-27 Thread Max Reitz
Check whether the BlockBackend is actually available at the start of snapshot-delete-internal-sync. Signed-off-by: Max Reitz --- blockdev.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index ae1137f..858d181 100644 --- a/blockdev

Re: [Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in get_phys_addr()

2015-01-27 Thread Peter Maydell
On 27 January 2015 at 19:49, Greg Bellows wrote: > On Tue, Jan 27, 2015 at 12:12 PM, Peter Maydell > wrote: >> g_assert_not_reached(), but it didn't seem worth cluttering >> the switch with a bunch of extra labels just to assert that >> they weren't reachable. >> > > I see how it could clutter t

  1   2   3   4   >