On Thu, Jan 22, 2015 at 02:49:44PM +0000, Igor Mammedov wrote: > Git tree for playing with: > https://github.com/imammedo/qemu/commits/ASL_API_v2 > > Igor Mammedov (47): > acpi: introduce AML composer aml_append() > acpi: add acpi_scope() term > acpi: add acpi_device() term > acpi: add acpi_method() term > acpi: add acpi_if() term > acpi: add acpi_name() & acpi_name_decl() term > acpi: factor out ACPI const int packing out build_append_value() > acpi: extend build_append_{value|int}() to support 64-bit values > acpi: add acpi_int() term > acpi: add acpi_return() term > acpi: add acpi_arg0(), acpi_arg1(), acpi_arg2(), acpi_arg3() terms > acpi: add acpi_store() term > acpi: add acpi_and() term > acpi: add acpi_notify() term > acpi: add acpi_call1(), acpi_call2(), acpi_call3(), acpi_call4() > helpers > pc: acpi-build: drop template patching and create PCI bus tree > dynamically > acpi: add acpi_package() term > pc: acpi-build: drop unsupported PM1b_CNT.SLP_TYP > pc: acpi-build: generate _S[345] packages dynamically > acpi: add acpi_buffer() term > acpi: add acpi_resource_template() helper > acpi: add acpi_io() helper > acpi: include PkgLength size only when requested > acpi: add acpi_operation_region() term > acpi: add acpi_field() & acpi_named_field() terms > acpi: add acpi_local0() term > acpi: add acpi_string() term > pc: acpi-build: generate pvpanic device description dynamically > acpi: add acpi_varpackage() term > acpi: add acpi_equal() term > acpi: add acpi_processor() term > acpi: add acpi_eisaid() term > pc: acpi-build: drop template patching and CPU hotplug objects > dynamically > pc: acpi-build: create CPU hotplug IO region dynamically > acpi: add acpi_reserved_field() term > pc: acpi-build: drop template patching and memory hotplug objects > dynamically > pc: acpi-build: create memory hotplug IO region dynamically > acpi: add acpi_word_bus_number(), acpi_word_io(), acpi_dword_memory(), > acpi_qword_memory() terms > pc: pcihp: expose MMIO base and len as properties > pc: acpi-build: reserve PCIHP MMIO resources > pc: acpi-build: create PCI0._CRS dynamically > acpi: add acpi_def_block() term > pc: acpi-build: prepare to make ACPI tables blob opaque for table > building functions > pc: acpi-build: drop remaining ssdt_misc template and use > acpi_def_block() > acpi: add acpi_iqr_no_flags() term > pc: export applesmc IO port/len > pc: acpi-build: drop template patching and create Device(SMC) > dynamically
Looking at the patch list, I think it's not split optimally: a single patch adding all of the helpers will be easier to work with, and won't be harder to review I think.