Re: [Qemu-devel] [PATCH RFC 10/17] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-01-22 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 09:52:36PM +0200, Marcel Apfelbaum wrote: > From: Marcel Apfelbaum > > Use the newer pci_bus_num to correctly get the root bus number. > > Signed-off-by: Marcel Apfelbaum OK for now, but really bus numbers are a wrong thing to use for QMP. In particular they are often

Re: [Qemu-devel] [PATCH V2] s390x/pci: avoid sign extension in stpcifc

2015-01-22 Thread Markus Armbruster
Frank Blaschka writes: > this patch avoids sign extension and fixes a data conversion > bug in stpcifc. Both issues where found by Coverity. > > Signed-off-by: Frank Blaschka Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Markus Armbruster
Jiri Slaby writes: > On 01/22/2015, 04:53 PM, Paolo Bonzini wrote: >> On 22/01/2015 16:39, Eric Blake wrote: >>> On 01/22/2015 01:22 AM, Jiri Slaby wrote: Signed-off-by: Jiri Slaby --- docs/specs/edu.txt | 4 hw/misc/edu.c | 2 +- 2 files changed, 5 insertions(+), 1 deleti

Re: [Qemu-devel] [sheepdog] [PATCH v2] sheepdog: selectable object size support

2015-01-22 Thread Teruaki Ishizaki
Hi, Hitoshi Thanks for your review! (2015/01/22 14:22), Hitoshi Mitake wrote: At Tue, 20 Jan 2015 16:14:28 +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle "block_size_shift" value for calculating VDI

Re: [Qemu-devel] [PATCH v4 16/17] spapr_pci: enable basic hotplug operations

2015-01-22 Thread Alexey Kardashevskiy
On 12/23/2014 11:30 PM, Michael Roth wrote: > This enables hotplug for PHB bridges. Upon hotplug we generate the > OF-nodes required by PAPR specification and IEEE 1275-1994 > "PCI Bus Binding to Open Firmware" for the device. > > We associate the corresponding FDT for these nodes with the DrcEntr

[Qemu-devel] [PATCH v1 2/3] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-22 Thread Bharata B Rao
Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed by PowerPC memory hotplug code too. Signed-off-by: Bharata B Rao --- hw/i386/pc.c | 24 hw/mem/pc-dimm.c | 25 + include/hw/mem/pc-dimm.h | 1 + 3 files c

[Qemu-devel] [PATCH v1 1/3] pc: Fix DIMMs capacity calculation

2015-01-22 Thread Bharata B Rao
pc_existing_dimms_capacity() is returning DIMMs count rather than capacity. Fix this to return the capacity. Also consider only realized devices for capacity calculation. Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov --- hw/i386/pc.c | 26 ++ 1 file changed, 10

[Qemu-devel] [PATCH 3/3] pc-dimm: Add Error argument to pc_existing_dimms_capacity

2015-01-22 Thread Bharata B Rao
Now that pc_existing_dimms_capacity() is an API, include Error pointer as an argument and modify the caller appropriately. Suggested-by: Igor Mammedov Signed-off-by: Bharata B Rao --- hw/i386/pc.c | 4 ++-- hw/mem/pc-dimm.c | 31 ++- include/hw/m

[Qemu-devel] [PATCH v1 0/3] Fix pc DIMMs capacity calculation

2015-01-22 Thread Bharata B Rao
This is the v1 of the patchset that fixes pc DIMMs capacity calculation and makes pc_existing_dimms_capacity() an API. Changes in v1 - - As per Igor's suggestion, made pc_existing_dimms_capacity() to return the capacity value and take Error pointer as an argument. v0: http://lists.g

[Qemu-devel] [PATCH 2/2] qcow2-snapshot: Fixing bug of creating snapshots with the same name.

2015-01-22 Thread Julio Faracco
This commit fixes the bug #1396497. You can create multiple snapshots with the same name using 'qemu-img'. When you want to delete someone passing the name, it will remove the first occurence of the snapshot with that name. This commit fixes it. Before: $ qemu-img snapshot -c foo debian.qcow2 $ qe

[Qemu-devel] [PATCH 1/2] qcow2-snapshot: Change filter function to avoid NULL parameter when a snapshot will be created.

2015-01-22 Thread Julio Faracco
This is a trivial patch to change the filter 'find_snapshot_by_id_and_name' to 'find_snapshot_by_id_or_name'. The field 'Name' is not required. So this change avoid NULL parameters. And use the correct function to filter. Signed-off-by: Julio Faracco --- block/qcow2-snapshot.c | 2 +- 1 file cha

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-22 Thread Chen, Tiejun
On 2015/1/22 8:51, Chen, Tiejun wrote: On 2015/1/21 21:48, Gerd Hoffmann wrote: On Mi, 2015-01-21 at 11:37 +, Ian Jackson wrote: Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"): When we're working to support IGD GFX passthrough with qe

Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-22 Thread Don Slutz
On 01/22/15 13:46, Stefano Stabellini wrote: > xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an > unsigned long argument (in fact xen_pfn_t is defined as uint64_t on > ARM). > > Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. > > Signed-off-by: Stefano Stabel

Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-22 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/22/15 13:46, Stefano Stabellini wrote: > xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an > unsigned long argument (in fact xen_pfn_t is defined as uint64_t > on ARM). > > Also use xc_hvm_param_get instead of the deprecated > xc

Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support

2015-01-22 Thread Michael Roth
Quoting Bharata B Rao (2015-01-08 00:10:13) > Support CPU hotplug via device-add command. Use the exising EPOW event > infrastructure to send CPU hotplug notification to the guest. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 205 > +

Re: [Qemu-devel] [RFC PATCH v1 05/13] spapr: Support ibm, lrdr-capacity device tree property

2015-01-22 Thread Michael Roth
Quoting Bharata B Rao (2015-01-08 00:10:12) > Add support for ibm,lrdr-capacity since this is needed by the guest > kernel to know about the possible hot-pluggable CPUs and Memory. > > Define minimum hotpluggable memory size as 256MB and start storing maximum > possible memory for the guest in sPA

Re: [Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine Generation ID device

2015-01-22 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:52:46PM +0100, Igor Mammedov wrote: > On Tue, 16 Dec 2014 17:50:43 +0200 > Gal Hammer wrote: > > > Based on Microsoft's sepecifications (paper can be dowloaded from > > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > > description to the SSDT ACPI table a

Re: [Qemu-devel] [RFC PATCH v1 02/13] spapr: Add DRC dt entries for CPUs

2015-01-22 Thread Michael Roth
Quoting Bharata B Rao (2015-01-08 00:10:09) > Advertise CPU DR-capability to the guest via device tree. > > Signed-off-by: Bharata B Rao > Signed-off-by: Michael Roth >[spapr_drc_reset implementation] > --- > hw/ppc/spapr.c | 28 > 1 file changed, 28

Re: [Qemu-devel] [RFC PATCH v1 01/13] spapr: enable PHB/CPU/LMB hotplug for pseries-2.3

2015-01-22 Thread Michael Roth
Quoting Bharata B Rao (2015-01-08 00:10:08) > From: Michael Roth > > Introduce an sPAPRMachineClass sub-class of MachineClass to > handle sPAPR-specific machine configuration properties. > > The 'dr_phb[cpu,lmb]_enabled' field of that class can be set as > part of machine-specific init code, and

Re: [Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge

2015-01-22 Thread B02008
Looks that you forgot the "single legacy IRQ line" comment from v1. -Mike On 01/21/2015 06:18 PM, Alexander Graf wrote: With simple exposure of MMFG, ioport window, mmio window and an IRQ line we can successfully create a workable PCIe host bridge that can be mapped anywhere and only needs to g

[Qemu-devel] [PATCH v2 11/14] qemu-io: Use BlockBackend

2015-01-22 Thread Max Reitz
qemu-io should behave like a guest, therefore it should use BlockBackend to access the block layer. There are a couple of places where that is infeasible: First, the bdrv_debug_* functions could theoretically be mirrored in the BlockBackend, but since these are functions internal to the block laye

[Qemu-devel] [PATCH v2 10/14] qemu-io: Remove "growable" option

2015-01-22 Thread Max Reitz
Remove "growable" option from the "open" command and from the qemu-io command line. qemu-io is about to be converted to BlockBackend which will make sure that no request exceeds the image size, so the only way to keep "growable" would be to use BlockBackend if it is not given and to directly access

[Qemu-devel] [PATCH v2 06/14] qemu-img: Use blk_new_open() in img_rebase()

2015-01-22 Thread Max Reitz
Signed-off-by: Max Reitz --- qemu-img.c | 57 - 1 file changed, 24 insertions(+), 33 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index f82f62b..404580e 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2430,7 +2430,6 @@ static int img_reba

[Qemu-devel] [PATCH v2 08/14] qemu-nbd: Use blk_new_open() in main()

2015-01-22 Thread Max Reitz
Signed-off-by: Max Reitz --- qemu-nbd.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index d222512..fdc9590 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -386,7 +386,6 @@ int main(int argc, char **argv) { BlockBackend *

[Qemu-devel] [PATCH v2 14/14] block: Keep bdrv_check*_request()'s return value

2015-01-22 Thread Max Reitz
Do not throw away the value returned by bdrv_check_request() and bdrv_check_byte_request(). Fix up some coding style issues in the proximity of the affected hunks. Signed-off-by: Max Reitz --- block.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) d

[Qemu-devel] [PATCH v2 13/14] block: Remove "growable" from BDS

2015-01-22 Thread Max Reitz
Now that request clamping is done in the BlockBackend, the "growable" field can be removed from the BlockDriverState. All BDSs are now treated as being "growable" (that is, they are allowed to grow; they are not necessarily actually able to). Signed-off-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v2 02/14] block: Add blk_new_open()

2015-01-22 Thread Max Reitz
blk_new_with_bs() creates a BlockBackend with an empty BlockDriverState attached to it. Empty BDSs are not nice, therefore add an alternative function which combines blk_new_with_bs() with bdrv_open(). Note: In contrast to bdrv_open() which takes a BlockDriver parameter, blk_new_open() does not ta

[Qemu-devel] [PATCH v2 09/14] qemu-io: Use blk_new_open() in openfile()

2015-01-22 Thread Max Reitz
Signed-off-by: Max Reitz --- qemu-io.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 91a445a..81f8f64 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -39,7 +39,6 @@ static ReadLineState *readline_state; static int clos

[Qemu-devel] [PATCH v2 12/14] block: Clamp BlockBackend requests

2015-01-22 Thread Max Reitz
BlockBackend is used as the interface between the block layer and guest devices. It should therefore assure that all requests are clamped to the image size. Signed-off-by: Max Reitz --- block/block-backend.c | 152 ++ 1 file changed, 152 insertions

[Qemu-devel] [PATCH v2 04/14] block/xen: Use blk_new_open() in blk_connect()

2015-01-22 Thread Max Reitz
Signed-off-by: Max Reitz --- hw/block/xen_disk.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 21842a0..da333a4 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -899,28 +899,24 @@ static

[Qemu-devel] [PATCH v2 07/14] qemu-img: Use BlockBackend as far as possible

2015-01-22 Thread Max Reitz
Although qemu-img already creates BlockBackends, it does not do accesses to the images through them. This patch converts all of the bdrv_* calls for which this is currently possible to blk_* calls. Most of the remaining calls will probably stay bdrv_* calls because they really do operate on the BDS

[Qemu-devel] [PATCH v2 05/14] qemu-img: Use blk_new_open() in img_open()

2015-01-22 Thread Max Reitz
Signed-off-by: Max Reitz --- qemu-img.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7876258..f82f62b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -291,32 +291,24 @@ static BlockBackend *img_open(const char *id, const char

[Qemu-devel] [PATCH v2 00/14] block: Remove "growable", add blk_new_open()

2015-01-22 Thread Max Reitz
This series removes the "growable" field from the BlockDriverState object. Its use was to clamp guest requests against the limits of the BDS; however, this can now be done more easily by moving those checks into the BlockBackend functions. In a future series, "growable" may be reintroduced (maybe

[Qemu-devel] [PATCH v2 03/14] blockdev: Use blk_new_open() in blockdev_init()

2015-01-22 Thread Max Reitz
Due to different error propagation, this breaks tests 051 and 087; fix their output. Signed-off-by: Max Reitz --- blockdev.c | 92 +- tests/qemu-iotests/051.out | 60 +++--- tests/qemu-iotests/087.out | 8 ++--

[Qemu-devel] [PATCH v2 01/14] block: Lift some BDS functions to the BlockBackend

2015-01-22 Thread Max Reitz
Create the blk_* counterparts for the following bdrv_* functions (which make sense to call on the BlockBackend level): - bdrv_co_write_zeroes() - bdrv_write_compressed() - bdrv_truncate() - bdrv_discard() - bdrv_load_vmstate() - bdrv_save_vmstate() Signed-off-by: Max Reitz --- block/block-backen

[Qemu-devel] [PATCH RFC 17/17] hw/acpi: hack - generate dummy region ranges for first acpi-build (will be removed from the series)

2015-01-22 Thread Marcel Apfelbaum
The SSDT size is different from the first time is created and the second time because between them the BIOS sets ranges for the other PCI root busses. The OS-es cannot find the rsdt pointer after that, until this problem is solved, this hack can be used for testing. Signed-off-by: Marcel Apfelbau

[Qemu-devel] [PATCH RFC 13/17] hw/pci: inform bios if the system has more than one pci bridge

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum The bios looks for 'etc/extra-pci-roots' to decide if is going to scan further buses after bus 0 tree. Signed-off-by: Marcel Apfelbaum --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e07f1fa..9ef0917 1

[Qemu-devel] [PATCH RFC 16/17] hw/pci-bridge: hack - disable shpc bar (will be removed from the series)

2015-01-22 Thread Marcel Apfelbaum
Windows disables the pci-bridge if shpc bar has a memory conflict. Until this problem is solved, this hack can be used for tests. Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_bridge_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridg

[Qemu-devel] [PATCH RFC 12/17] hw/pci: introduce PCI Expander Bridge (PXB)

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum PXB is a "light-weight" host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses. As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus is a primary bus and can be associated with a NUMA node (different from the main host bridge) al

[Qemu-devel] [PATCH RFC 15/17] hw/pxb: add map_irq func

2015-01-22 Thread Marcel Apfelbaum
The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation. Synchronize between bios and Qemu by canceling pxb's effect. Signed-off-by: Marcel A

[Qemu-devel] [PATCH RFC 10/17] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index dccb3d1..bf31168 100644 --- a/hw/pci/pci.c +++ b/hw/pc

[Qemu-devel] [PATCH RFC 14/17] hw/pci: piix - suport multiple host bridges

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Instead of assuming it has only one bus, it enumerates all the host bridges until it finds the one with bus number corresponding with the config register. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/piix.c | 57 +-

[Qemu-devel] [PATCH RFC 09/17] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum This is a marker interface used to differentiate the "default" host bridge on a system with multiple host bridges. This differentiation is required only for pc machines for now by the ACPI subsystem. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 9 +

[Qemu-devel] [PATCH RFC 04/17] hw/acpi: add _CRS method for extra root busses

2015-01-22 Thread Marcel Apfelbaum
Save the IO/mem ranges assigned to the extra root busses to be removed from the root bus 0 range. Todo: find the actual bus numbers range for the root busses. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 110 +++ 1 file changed, 110

[Qemu-devel] [PATCH RFC 07/17] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel Apfelbaum --- hw/pci

[Qemu-devel] [PATCH RFC 11/17] hw/pci: implement iteration over multiple host bridges

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 8 include/hw/pci/pci_host.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index bf31168..d0d0035 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @

[Qemu-devel] [PATCH RFC 08/17] hw/pci: made pci_bus_num a PCIBusClass method

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Signed-off-by: Marcel Apfelbaum --- hw/i386/kvm/pci-assign.c | 1 + hw/pci/pci-hotplug-old.c | 1 + hw/pci/pci.c | 7 --- hw/pci/pci_bus.c | 10 +

[Qemu-devel] [PATCH RFC 03/17] hw/apci: add _PRT method for extra root busses

2015-01-22 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 77 1 file changed, 77 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9837120..cb77fa3 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -64

[Qemu-devel] [PATCH RFC 02/17] hw/acpi: add support for multiple root busses

2015-01-22 Thread Marcel Apfelbaum
If the machine has several root busses, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c

[Qemu-devel] [PATCH RFC 06/17] hw/pci: move pci bus related code to separate files

2015-01-22 Thread Marcel Apfelbaum
From: Marcel Apfelbaum This refactoring moves all the code needed (recursively) to register TYPE_PCI_BUS type to a new file hw/pci/pci_bus.c . This allows to properly add new functionality to the pci bus class. Signed-off-by: Marcel Apfelbaum --- arch_init.c | 1 + hw/alpha/typh

[Qemu-devel] [PATCH RFC 00/17] implement multiple primary busses for pc machines

2015-01-22 Thread Marcel Apfelbaum
This series depends on: - [SeaBIOS] [PATCH 0/2] fw/pci: better support for multiple host bridges (https://www.mail-archive.com/seabios@seabios.org/msg07103.html) - Not yet final, comments need to be adressed - [Qemu-devel] [PATCH v2 00/47] ACPI refactoring: replace template patching with

[Qemu-devel] [PATCH RFC 05/17] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-01-22 Thread Marcel Apfelbaum
If multiple root busses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary busses. todo: properly compute the bus ranges for root bus 0. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 74 ++

[Qemu-devel] [PATCH RFC 01/17] acpi: added needed acpi constructs

2015-01-22 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/acpi/acpi-build-utils.c | 107 +++-- include/hw/acpi/acpi-build-utils.h | 12 + 2 files changed, 116 insertions(+), 3 deletions(-) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 58f88c

[Qemu-devel] [PATCH] target-i386: Disable HLE and RTM on Haswell & Broadwell

2015-01-22 Thread Eduardo Habkost
All Haswell CPUs and some Broadwell CPUs were updated by Intel to have the HLE and RTM features disabled. This will prevent "-cpu Haswell,enforce" and "-cpu Broadwell,enforce" from running out of the box on those CPUs. Disable those features by default on Broadwell and Haswell CPU models, starting

Re: [Qemu-devel] [PATCH v5 1/3] qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking

2015-01-22 Thread Max Reitz
On 2015-01-19 at 08:16, Jun Li wrote: On Thu, 01/15 13:47, Max Reitz wrote: On 2015-01-03 at 07:23, Jun Li wrote: On Fri, 11/21 11:56, Max Reitz wrote: So, as for what I think we do need to do when shrinking (and keep in mind: The offset given to qcow2_truncate() is the guest size! NOT the hos

Re: [Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Jiri Slaby
On 01/22/2015, 04:53 PM, Paolo Bonzini wrote: > On 22/01/2015 16:39, Eric Blake wrote: >> On 01/22/2015 01:22 AM, Jiri Slaby wrote: >>> Signed-off-by: Jiri Slaby --- docs/specs/edu.txt >>> | 4 hw/misc/edu.c | 2 +- 2 files changed, 5 >>> insertions(+), 1 deletion(-) >>> >>> diff --git a/d

[Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-22 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini diff --git a/include/hw/xen/xen_common.h b/include/h

Re: [Qemu-devel] [PULL 0/3] input: misc fixes.

2015-01-22 Thread Peter Maydell
-20150120' > into staging (2015-01-20 16:19:58 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-input-20150122-1 > > for you to fetch changes up to 0ee4de5840ccc1072459ec68062bfb63c888a94d: >

Re: [Qemu-devel] [PATCH 0/2] virtio-blk: Switch to blk_aio_ioctl

2015-01-22 Thread Kevin Wolf
Am 20.01.2015 um 04:28 hat Fam Zheng geschrieben: > There are user complaints on guest's unresponsiveness when ioctl is blocked > due > to the lost connection to backend or other issues. This series changes scsi > request processing of virtio-blk to an asynchronous manner. Thanks, applied to the

Re: [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks

2015-01-22 Thread Kevin Wolf
Am 19.01.2015 um 21:49 hat Max Reitz geschrieben: > With the series adding unalignment checks and the series reworking the > zero cluster expansion code overlapping, the unalignment checks have not > been implemented in the latter code. > > This series fixes it. > > There are other places which w

[Qemu-devel] [ANNOUNCE] QEMU 2.1.3 Stable released

2015-01-22 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v2.1.3 stable release is now available at: http://wiki.qemu.org/download/qemu-2.1.3.tar.bz2 v2.1.3 is now tagged in the official qemu.git repository, and the stable-2.1 branch has been updated accordingly: http://git.qemu.org/?p=qemu.git;a

Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2015-01-22 Thread Jeff Cody
On Thu, Jan 22, 2015 at 04:24:45PM +, Lokesha, Amulya wrote: > > -Original Message- > From: Jeff Cody [mailto:jc...@redhat.com] > Sent: Thursday, January 22, 2015 9:33 PM > To: Lokesha, Amulya > Cc: Bug 1399191; Geoffroy, Daniel > Subject: Re: [Qemu-devel] [Bug 1399191] [NEW] Large VH

Re: [Qemu-devel] [PATCH] iotests: Test prefix for supported_oses in Python

2015-01-22 Thread Max Reitz
On 2015-01-22 at 11:52, Max Reitz wrote: sys.platform may be set to "linux2" instead of just "linux" (in theory, it could even be set to "linux3" or something else). The Python documentation on sys.platform recommends testing the prefix of the platform against "linux", so we should do that. Sign

Re: [Qemu-devel] [PULL 0/2] spice: fix coverity defect, add unix address support

2015-01-22 Thread Peter Maydell
t; Merge remote-tracking branch 'remotes/pmaydell/tags/pull-misc-20150120' > into staging (2015-01-20 16:19:58 +) > > are available in the git repository at: > > > git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20150122-1 > > for you to fetch chang

Re: [Qemu-devel] [PATCH] block: vhdx - force FileOffsetMB field to '0' for certain block states

2015-01-22 Thread Max Reitz
On 2015-01-20 at 16:01, Jeff Cody wrote: The v1.0.0 spec calls out PAYLOAD_BLOCK_ZERO FileOffsetMB field as being 'reserved'. In practice, this means that Hyper-V will fail to read a disk image with PAYLOAD_BLOCK_ZERO block states with a FileOffsetMB value other than 0. The other states that in

[Qemu-devel] [Bug 1392468] Re: qemu uses a bitmap icon

2015-01-22 Thread Jakub Jermar
For me the icon looks ugly if QEMU is run by the normal user. However, when run via sudo, it looks normal for some reason and does not display any of the white pixels. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [PATCH] iotests: Test prefix for supported_oses in Python

2015-01-22 Thread Max Reitz
sys.platform may be set to "linux2" instead of just "linux" (in theory, it could even be set to "linux3" or something else). The Python documentation on sys.platform recommends testing the prefix of the platform against "linux", so we should do that. Signed-off-by: Max Reitz --- tests/qemu-iotes

Re: [Qemu-devel] [PATCH RFC v6 15/20] virtio-net: no writeable mac for virtio-1

2015-01-22 Thread Cornelia Huck
On Tue, 20 Jan 2015 11:19:47 + Stefan Hajnoczi wrote: > On Thu, Dec 11, 2014 at 02:25:17PM +0100, Cornelia Huck wrote: > > Devices operating as virtio 1.0 may not allow writes to the mac > > address in config space. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/net/virtio-net.c |

Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2015-01-22 Thread Jeff Cody
On Thu, Jan 22, 2015 at 05:20:20AM +, Lokesha, Amulya wrote: >  > [...]   >  >> Yes, I have sent a patch that I believe fixes the issue (I cc'ed you on >> the patch).  If you wouldn't mind testing, and verifying that it fixes >> your particular issue, that would be great.  I test

Re: [Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Paolo Bonzini
On 22/01/2015 16:39, Eric Blake wrote: > On 01/22/2015 01:22 AM, Jiri Slaby wrote: >> Signed-off-by: Jiri Slaby --- docs/specs/edu.txt >> | 4 hw/misc/edu.c | 2 +- 2 files changed, 5 >> insertions(+), 1 deletion(-) >> >> diff --git a/docs/specs/edu.txt b/docs/specs/edu.txt index >> 360

Re: [Qemu-devel] [PATCH RFC] coverity: Improve model for GLib memory allocation

2015-01-22 Thread Paolo Bonzini
On 22/01/2015 15:55, Markus Armbruster wrote: > == Look like a bug == > > blockdev-nbd.c:35: leaked_handle: Handle variable "fd" going out of scope > leaks the handle. It's a false positive. After nbd_client_new calls nbd_send_negotiate, either it returns or client escapes via QTAILQ_INSERT_T

Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine

2015-01-22 Thread Alexander Graf
On 22.01.15 16:28, Claudio Fontana wrote: > Hi Alexander, > > thank you for the respin. I retested with the new mappings on OSv for AArch64, > and they show up ok in the guest. > > Just a couple minor comments below, otherwise I think this is good. > > On 21.01.2015 17:18, Alexander Graf wrote

[Qemu-devel] [PATCH v2 09/47] acpi: add acpi_int() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 11 +++ include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index b68e1d8..745e58b 100644 --- a/hw/acpi/acpi-build-utils.c +

[Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-22 Thread Igor Mammedov
Adds for dynamic AML creation, which will be used for piecing ASL/AML primitives together and hiding from user/caller details about how nested context should be closed/packed leaving less space for mistakes and necessity to know how AML should be encoded, allowing user to concentrate on ASL represe

[Qemu-devel] [PATCH v2 10/47] acpi: add acpi_return() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 9 + include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 745e58b..df5880f 100644 --- a/hw/acpi/acpi-build-utils.c +++ b

[Qemu-devel] [PATCH v2 11/47] acpi: add acpi_arg0(), acpi_arg1(), acpi_arg2(), acpi_arg3() terms

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 32 include/hw/acpi/acpi-build-utils.h | 5 + 2 files changed, 37 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index df5880f..6e10712 100644 --- a/hw/

[Qemu-devel] [PATCH v2 06/47] acpi: add acpi_name() & acpi_name_decl() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 24 include/hw/acpi/acpi-build-utils.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 40a1769..1bda2ec 100644 --- a/hw/acpi/acpi-

Re: [Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Eric Blake
On 01/22/2015 01:22 AM, Jiri Slaby wrote: > Signed-off-by: Jiri Slaby > --- > docs/specs/edu.txt | 4 > hw/misc/edu.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/docs/specs/edu.txt b/docs/specs/edu.txt > index 360af27ec8b1..1a23df9d21f6 100644 > --- a/doc

Re: [Qemu-devel] [PATCH v5 06/26] qcow2: Use 64 bits for refcount values

2015-01-22 Thread Eric Blake
On 12/15/2014 05:50 AM, Max Reitz wrote: > Refcounts may have a width of up to 64 bits, so qemu should use the same > width to represent refcount values internally. > > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 2 +- > block/qcow2-refcount.c | 46 ++--

[Qemu-devel] [PATCH v2 36/47] pc: acpi-build: drop template patching and memory hotplug objects dynamically

2015-01-22 Thread Igor Mammedov
in addition it saves us ~330LOC and makes it one binary blob less stored in QEMU source tree by removing need to keep and update hw/i386/ssdt-mem.hex.generated file there. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs | 2 +- hw/i386/acpi-build.c | 132 +

Re: [Qemu-devel] [PATCH v5 05/26] qcow2: Use unsigned addend for update_refcount()

2015-01-22 Thread Eric Blake
On 12/15/2014 05:50 AM, Max Reitz wrote: > update_refcount() and qcow2_update_cluster_refcount() currently take a > signed addend. At least one caller passes a value directly derived from > an absolute refcount that should be reached ("l2_refcount - 1" in > expand_zero_clusters_in_l1()). Therefore,

[Qemu-devel] [PATCH v2 35/47] acpi: add acpi_reserved_field() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 10 ++ include/hw/acpi/acpi-build-utils.h | 6 ++ 2 files changed, 16 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index cbc1241..644af1f 100644 --- a/hw/acpi/acpi-build-utils

[Qemu-devel] [PATCH v2 21/47] acpi: add acpi_resource_template() helper

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 8 include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 2d5e77a..32a4377 100644 --- a/hw/acpi/acpi-build-utils.c +++ b/h

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2015-01-22 Thread Eric Blake
On 12/21/2014 12:48 AM, Roy Vardi wrote: > From: Roy Vardi > > Add 'persistent' boolean flag to -net tap option. > When set to off - tap interface will be released on shutdown > When set to on\not specified - tap interface will remain > > Running with -net tap,persistent=off will

[Qemu-devel] [PATCH v2 27/47] acpi: add acpi_string() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 26 ++ include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 27 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 1affed2..fedf871 100644 --- a/hw/acpi/acpi-

Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine

2015-01-22 Thread Claudio Fontana
Hi Alexander, thank you for the respin. I retested with the new mappings on OSv for AArch64, and they show up ok in the guest. Just a couple minor comments below, otherwise I think this is good. On 21.01.2015 17:18, Alexander Graf wrote: > Now that we have a working "generic" PCIe host bridge dr

[Qemu-devel] [PATCH v2 34/47] pc: acpi-build: create CPU hotplug IO region dynamically

2015-01-22 Thread Igor Mammedov
it replaces a static complied in DSDT MMIO region for CPU hotplug with one created at runtime leaving only truly static CPU hotplug related ASL bits in DSDT. It also puts CPU_HOTPLUG_RESOURCE_DEVICE into PCI0 scope and reserves resources from it, preparing for dropping manual hole punching in PCI0.

Re: [Qemu-devel] [PATCH RFC] coverity: Improve model for GLib memory allocation

2015-01-22 Thread Markus Armbruster
Local scan results look great on first glance. Comparing summary.txt, I get -2 TAINTED_STRING 1 MISSING_LOCK 1 REVERSE_NEGATIVE -4 FORWARD_NULL -6 CHECKED_RETURN -21 RESOURCE_LEAK 4 TAINTED_SCALAR -2 NEGATIVE_RETURNS -3 NULL_RETURNS A closer examina

Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-22 Thread Igor Mammedov
On Thu, 22 Jan 2015 20:04:46 +0530 Bharata B Rao wrote: [...] > If you find the below patch to be fine, I will repost the series > with this patch included. Looks fine to me > > pc-dimm: Add Error argument to pc_existing_dimms_capacity > > From: Bharata B Rao > > Now that pc_existing_dimms

[Qemu-devel] [PATCH v2 20/47] acpi: add acpi_buffer() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 7 +++ include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 6282865..2d5e77a 100644 --- a/hw/acpi/acpi-build-utils.c +++ b/hw

[Qemu-devel] [PATCH v2 23/47] acpi: include PkgLength size only when requested

2015-01-22 Thread Igor Mammedov
Named/Reserved{Field} definition uses PkgLength [1] encoding to specify field length, however it doesn't include size of PkgLength field itself, while other block objects that have explicit length of its body account for PkgLength size while encoding it [2]. This special casing isn't mentioned in A

[Qemu-devel] [PATCH v2 40/47] pc: acpi-build: reserve PCIHP MMIO resources

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b26bc6d..a09bf28 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -105,6 +105,8 @@ typedef struct A

[Qemu-devel] [PATCH v2 05/47] acpi: add acpi_if() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 8 include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index d0b0159..40a1769 100644 --- a/hw/acpi/acpi-build-utils.c +++ b/h

[Qemu-devel] [PATCH v2 32/47] acpi: add acpi_eisaid() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 31 +++ include/hw/acpi/acpi-build-utils.h | 1 + 2 files changed, 32 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index e51196b..cbc1241 100644 --- a/hw/acpi/

Re: [Qemu-devel] [PATCH 2/3] kvm_stat: Update exit reasons to the latest defintion

2015-01-22 Thread Wei Huang
On 01/22/2015 06:56 AM, Paolo Bonzini wrote: > > > On 21/01/2015 22:15, Wei Huang wrote: >> +56: 'ACPI_WRITE', > > APIC_WRITE. :) > > Will fix when committing. Gerr... thanks! -Wei > > Paolo > >> +58: 'INVPCID', >> } >> >

[Qemu-devel] [PATCH v2 31/47] acpi: add acpi_processor() term

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 20 include/hw/acpi/acpi-build-utils.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c index 587723d..e51196b 100644 --- a/hw/acpi/acpi-buil

[Qemu-devel] [PATCH v2 19/47] pc: acpi-build: generate _S[345] packages dynamically

2015-01-22 Thread Igor Mammedov
Replaces template patching with packages composed using ASL API. Note on behavior change: If S3 or S4 is disabled, respective packages won't be created and put into SSDT. Which saves us some space in SSDT and doesn't confuse guest OS with mangled package names as it was done originally. Signed-of

[Qemu-devel] [PATCH v2 33/47] pc: acpi-build: drop template patching and CPU hotplug objects dynamically

2015-01-22 Thread Igor Mammedov
in addition it saves us ~400LOC and makes it one binary blob less stored in QEMU source tree by removing need to keep and update hw/i386/ssdt-proc.hex.generated file there. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs | 2 +- hw/i386/acpi-build.c| 94 ++

[Qemu-devel] [PATCH v2 47/47] pc: acpi-build: drop template patching and create Device(SMC) dynamically

2015-01-22 Thread Igor Mammedov
patch moves SMC device into SSDT and creates it only when device is present, which makes ACPI tables smaller in default case when device is not present. PS: also it fixes wrong IO range in CRS if "iobase" property is set to a not default value. Signed-off-by: Igor Mammedov --- hw/i386/acpi-buil

[Qemu-devel] [PATCH v2 25/47] acpi: add acpi_field() & acpi_named_field() terms

2015-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: fix style error: line over 80 chr --- hw/acpi/acpi-build-utils.c | 28 include/hw/acpi/acpi-build-utils.h | 6 ++ 2 files changed, 34 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c

  1   2   3   >