Re: [Qemu-devel] [PATCH 04/12] spapr_pci: add set-indicator RTAS interface

2014-12-31 Thread Bharata B Rao
On Tue, Dec 23, 2014 at 8:42 PM, Michael Roth wrote: > > Hi Bharata, > > I've submitted v4 of PCI hotplug. The development branch is here: > > https://github.com/mdroth/qemu/commits/spapr-hotplug-pci > > and is based on top of a 'core' branch organized similar to what you proposed: > > https:/

Re: [Qemu-devel] [PATCH] Fixes fullscreen aspect ratio and leaving fullscreen mode problem on Mac OS X

2014-12-31 Thread Peter Maydell
On 30 December 2014 at 04:17, Programmingkid wrote: > This patch fixes these problems for QEMU on Mac OS X: > - fullscreen mode not having the correct aspect ratio > - the inability to leave fullscreen mode > > signed-off-by: John Arbuckle So how do you get into full screen mode in the first pla

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 20:25, Paolo Bonzini wrote: > > > On 31/12/2014 18:29, Peter Maydell wrote: >> On 31 December 2014 at 16:23, Paolo Bonzini wrote: >>> $ arm-softmmu/qemu-system-arm -M virt -machine accel=qtest \ >>> -qtest stdio -uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8 >>> writew 0x902

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Paolo Bonzini
On 31/12/2014 18:29, Peter Maydell wrote: > On 31 December 2014 at 16:23, Paolo Bonzini wrote: >> $ arm-softmmu/qemu-system-arm -M virt -machine accel=qtest \ >> -qtest stdio -uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8 >> writew 0x9020008 0x0200 >> readl 0x902 >> >> The readl sho

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 19:08, Ard Biesheuvel wrote: > On 31 December 2014 at 17:37, Peter Maydell wrote: >> On 31 December 2014 at 17:17, Peter Maydell wrote: >>> One thing I did notice in the dmesg: >>> >>> [ 35.798423] alg: hash: Test 1 failed for sha1-ce >>> [ 35.799135] : d3 5b 9a 85 7f 18 4

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 18:08, Ard Biesheuvel wrote: > On 31 December 2014 at 17:37, Peter Maydell wrote: >> It doesn't happen on LE TCG hosts. Joy :-) > I will need to find out first if this is the kernel driver or the > emulation failing. I never tested the former on BE, as the models > don't s

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 18:58, Laszlo Ersek wrote: > On 12/31/14 18:44, Peter Maydell wrote: >> On 31 December 2014 at 17:17, Peter Maydell wrote: >>> Unpatched QEMU + QEMU_EFI.fd.v4 : doesn't boot (doesn't load kernel) >>> Patched QEMU + QEMU_EFI.fd.v4_noswizzle : boots OK (dracut-initqueue >>> starts downlo

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Ard Biesheuvel
On 31 December 2014 at 17:37, Peter Maydell wrote: > On 31 December 2014 at 17:17, Peter Maydell wrote: >> One thing I did notice in the dmesg: >> >> [ 35.798423] alg: hash: Test 1 failed for sha1-ce >> [ 35.799135] : d3 5b 9a 85 7f 18 48 21 97 5c 12 72 a8 96 62 88 >> [ 35.799815] 0

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 18:37, Peter Maydell wrote: > On 31 December 2014 at 17:17, Peter Maydell wrote: >> One thing I did notice in the dmesg: >> >> [ 35.798423] alg: hash: Test 1 failed for sha1-ce >> [ 35.799135] : d3 5b 9a 85 7f 18 48 21 97 5c 12 72 a8 96 62 88 >> [ 35.799815] 0010: c3

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 18:44, Peter Maydell wrote: > On 31 December 2014 at 17:17, Peter Maydell wrote: >> Unpatched QEMU + QEMU_EFI.fd.v4 : doesn't boot (doesn't load kernel) >> Patched QEMU + QEMU_EFI.fd.v4_noswizzle : boots OK (dracut-initqueue >> starts downloading things). > > Just noticed you asked fo

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Paolo Bonzini
On 31/12/2014 18:04, Laszlo Ersek wrote: > > *If* it prints the number that the guest CPU sees immediately when it > performs the wide read, then it should print 0x32cb0046, on both > big and little endian hosts; assuming a little endian guest. Yes. Paolo > Namely, the fw_cfg (sub)str

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 17:17, Peter Maydell wrote: > Unpatched QEMU + QEMU_EFI.fd.v4 : doesn't boot (doesn't load kernel) > Patched QEMU + QEMU_EFI.fd.v4_noswizzle : boots OK (dracut-initqueue > starts downloading things). Just noticed you asked for the full matrix of tests: patched QEMU + fd.v4

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 17:17, Peter Maydell wrote: > One thing I did notice in the dmesg: > > [ 35.798423] alg: hash: Test 1 failed for sha1-ce > [ 35.799135] : d3 5b 9a 85 7f 18 48 21 97 5c 12 72 a8 96 62 88 > [ 35.799815] 0010: c3 d2 e1 f0 > [ 35.807121] alg: hash: Test 1 fai

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 16:23, Paolo Bonzini wrote: > $ arm-softmmu/qemu-system-arm -M virt -machine accel=qtest \ > -qtest stdio -uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8 > writew 0x9020008 0x0200 > readl 0x902 > > The readl should return "OK 0x4600cb32". On BE ppc64 hos

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 16:27, Laszlo Ersek wrote: > On 12/31/14 16:17, Peter Maydell wrote: >> On 31 December 2014 at 14:07, Laszlo Ersek wrote: >>> Of course this also renders the issue mostly moot -- if none of us can >>> test the code on a BE host, then that use case simply doesn't exist in >>

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 17:23, Paolo Bonzini wrote: > > > On 31/12/2014 16:17, Peter Maydell wrote: >> On 31 December 2014 at 14:07, Laszlo Ersek wrote: Of course this also renders the issue mostly moot -- if none of us can test the code on a BE host, then that use case simply doesn't exist in >>>

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 16:17, Peter Maydell wrote: > On 31 December 2014 at 14:07, Laszlo Ersek wrote: >> Of course this also renders the issue mostly moot -- if none of us can >> test the code on a BE host, then that use case simply doesn't exist in >> practice. > > If you can give me a test image and a co

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Paolo Bonzini
On 31/12/2014 16:17, Peter Maydell wrote: > On 31 December 2014 at 14:07, Laszlo Ersek wrote: >> > Of course this also renders the issue mostly moot -- if none of us can >> > test the code on a BE host, then that use case simply doesn't exist in >> > practice. > If you can give me a test image a

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 14:07, Laszlo Ersek wrote: > Of course this also renders the issue mostly moot -- if none of us can > test the code on a BE host, then that use case simply doesn't exist in > practice. If you can give me a test image and a command line I can test it on one of the PPC64 boxe

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
On 12/31/14 14:20, Paolo Bonzini wrote: > > > On 31/12/2014 12:21, Laszlo Ersek wrote: >> Because register emulation in QEMU is integer-preserving, not >> string-preserving (see (2)), we have to jump through a few hoops. >> >> (3a) We defined the memory mapped fw_cfg data register as >> DEVICE_BI

[Qemu-devel] [PATCH v2 1/2] zynq_gpio: GPIO model for Zynq SoC

2014-12-31 Thread Colin Leitner
Based on the pl061 model. This model implements all four banks with 32 I/Os each. The I/Os are placed in named groups: * bankX_in for the 32 inputs of each bank * bankX_out for the 32 outputs of each bank Basic I/O and IRQ support tested with the Zynq GPIO driver in Linux 3.12. Signed-off-by:

[Qemu-devel] [PATCH v2 2/2] xilinx_zynq: Add zynq-gpio to the machine

2014-12-31 Thread Colin Leitner
Signed-off-by: Colin Leitner --- hw/arm/xilinx_zynq.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 06e6e24..6d8c0d9 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -202,6 +202,8 @@ static void zynq_init(MachineState *ma

[Qemu-devel] [PATCH v2 0/2] Reworked Zynq GPIO model

2014-12-31 Thread Colin Leitner
Hello everyone, this is the second version with most of the review points addressed. Two notable exceptions: * The bank registers are handled like in the original patch * I couldn't get rid of the intermediate set_irq callbacks because qdev_init_gpio_in_named won't allow me to set the opaqu

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Paolo Bonzini
On 31/12/2014 12:21, Laszlo Ersek wrote: > Because register emulation in QEMU is integer-preserving, not > string-preserving (see (2)), we have to jump through a few hoops. > > (3a) We defined the memory mapped fw_cfg data register as > DEVICE_BIG_ENDIAN. > > The particular choice is not really

[Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2014-12-31 Thread Denis V. Lunev
hese patches for guest-agent add the functionality to execute commands on a guest UNIX machine. These patches add the following interfaces: guest-pipe-open guest-exec guest-exec-status With these interfaces it's possible to: * Open an anonymous pipe and work with it as with a file using already

[Qemu-devel] [PATCH 2/8] qga: implement file commands for Windows guest

2014-12-31 Thread Denis V. Lunev
From: Olga Krishtal The following commands are implemented: - guest_file_open - guest_file_close - guest_file_write - guest_file_read - guest_file_seek - guest_file_flush Motivation is quite simple: Windows guests should be supported with the same set of features as Linux one. Also this patch is

[Qemu-devel] [PATCH 1/8] qga: fixed warning in qemu-ga.exe for mingw >= 4.9.1

2014-12-31 Thread Denis V. Lunev
From: Olga Krishtal strtok_r was redefined before the patch Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Michael Roth --- include/sysemu/os-win32.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index af3fbc4..84e

[Qemu-devel] [PATCH 5/8] guest agent: add guest-exec and guest-exec-status interfaces

2014-12-31 Thread Denis V. Lunev
From: Simon Zolin Interfaces to execute/manage processes in the guest. Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. Signed-off-by: Simon Zolin Acked-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth --- qga/comma

[Qemu-devel] [PATCH 6/8] guest agent: ignore SIGPIPE signal

2014-12-31 Thread Denis V. Lunev
From: Simon Zolin If write operation fails on a pipe whose reading end is closed, qemu-ga won't be terminated, but instead write() will fail with error EPIPE. execve() inherits signals that are ignored, so reset SIGPIPE to its default handler before calling execve() in a forked process. Signed-

[Qemu-devel] [PATCH 4/8] guest agent: add guest-pipe-open

2014-12-31 Thread Denis V. Lunev
From: Simon Zolin Creates a FIFO pair that can be used with existing file read/write interfaces to communicate with processes spawned via the forthcoming guest-file-exec interface. Signed-off-by: Simon Zolin Acked-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth --- qga/comman

[Qemu-devel] [PATCH 7/8] guest agent: add guest-pipe-open command on Windows

2014-12-31 Thread Denis V. Lunev
From: Simon Zolin Create anonymous pipe that can be passed as a stdin/stdout/stderr handle to a child process spawned using forthcoming guest-file-exec command. Working with a pipe is done using the existing interfaces guest-file-*. Signed-off-by: Simon Zolin Signed-off-by: Denis V. Lunev CC:

[Qemu-devel] [PATCH 3/8] guest agent: guest-file-open: refactoring

2014-12-31 Thread Denis V. Lunev
From: Simon Zolin Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin Acked-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth --- qga/commands-posix.c | 31 +++ 1 file changed, 23 insertions(+), 8 del

[Qemu-devel] [PATCH 8/8] guest agent: add guest-exec and guest-exec-status interfaces on Windows

2014-12-31 Thread Denis V. Lunev
From: Simon Zolin guest-exec command executes a new process on a guest machine. Command-line arguments, environment, stdin/stdout/stderr handles can be passed to a new process. guest-exec-status command gets the status of process executed by 'guest-exec'. Signed-off-by: Simon Zolin Signed-off

[Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2014-12-31 Thread Laszlo Ersek
(1) Let's contemplate what device endianness means, for a memory mapped device register (independently of QEMU -- that is, on physical hardware). It determines the byte order that the device will put on the data bus when the device is producing a *numerical value* for the CPU. This byte order may

[Qemu-devel] [RFC PATCH v2] hw/arm/boot: Add support for NUMA on ARM64

2014-12-31 Thread Shannon Zhao
Add support for NUMA on ARM64. Tested successfully running a guest Linux kernel with the following patch applied: - arm64:numa: adding numa support for arm64 platforms. http://www.spinics.net/lists/arm-kernel/msg365316.html Changes v1 ... v2: Take into account Peter's comments: * rename virt_memo

Re: [Qemu-devel] [PATCH v3 6/7] tests/Makefile: Add check-block to make check on Linux

2014-12-31 Thread Peter Maydell
On 31 December 2014 at 04:30, Fam Zheng wrote: > "make check-block" does nothing on other platforms, but still takes some > time to enumerate all the tests. So let's only add it for Linux for now. > > Signed-off-by: Fam Zheng > --- > tests/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > >