Re: [Qemu-devel] [RFC PATCH v6 08/32] icount: implement icount requesting

2014-12-09 Thread Paolo Bonzini
On 10/12/2014 07:35, Pavel Dovgalyuk wrote: > No, it worked well and I deleted _nocache version of that function. > But I still need _raw one to get the instructions counter. Oh, great. This patch can also go in early. Paolo

[Qemu-devel] [PATCH] NetKVM: fix for indirectc mode when vring is full

2014-12-09 Thread Ting Wang
In function vring_add_indirect, there is no limiti about free entry in vring. If vring is full, vq->num_free will be less than zero, and the address of vq->vring.desc becomes illegal. Signed-off-by: Ting Wang --- NetKVM/NDIS5/VirtIO/VirtIORing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Qemu-devel] [PATCH Part1 1/5] acpi, pc: Add hotunplug request cb for pc machine.

2014-12-09 Thread Tang Chen
Hi Igor, On 11/18/2014 08:44 PM, Igor Mammedov wrote: On Mon, 17 Nov 2014 13:03:13 +0800 Tang Chen wrote: in subj s/cb/callback|handler/ Memory and CPU hot unplug are both asynchronize procedures. s/asynchronize/asynchronous/ They both need unplug request cb when the unplug operation happe

Re: [Qemu-devel] [RFC PATCH v6 08/32] icount: implement icount requesting

2014-12-09 Thread Pavel Dovgalyuk
No, it worked well and I deleted _nocache version of that function. But I still need _raw one to get the instructions counter. Sent using CloudMagic On вт, Дек 09, 2014 at 8:39 PM, Paolo Bonzini wrote: On 08/12/2014 08:53, Pavel Dovgalyuk wrote: >  if (!cpu_can_do

Re: [Qemu-devel] [PATCH 2/2] atapi migration: Throw recoverable error to avoid recovery

2014-12-09 Thread John Snow
On 12/09/2014 01:15 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" (With the previous atapi_dma flag recovery) If migration happens between the ATAPI command being written and the bmdma being started, the DMA is dropped. Eventually the guest times out and recovers, bu

Re: [Qemu-devel] [PATCH 2/4] hw/virtio-blk: add a constant for max number of merged requests

2014-12-09 Thread Fam Zheng
On Tue, 12/09 17:26, Peter Lieven wrote: > As it was not obvious (at least for me) where the 32 comes from; > add a constant for it. > > Signed-off-by: Peter Lieven > Reviewed-by: Eric Blake > --- > hw/block/virtio-blk.c |2 +- > include/hw/virtio/virtio-blk.h |4 +++- > 2 file

Re: [Qemu-devel] [PATCH 1/2] Restore atapi_dma flag across migration

2014-12-09 Thread John Snow
On 12/09/2014 01:15 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" If a migration happens just after the guest has kicked off an ATAPI command and kicked off DMA, we lose the atapi_dma flag, and the destination tries to complete the command as PIO rather than DMA. Thi

[Qemu-devel] [Bug 1292234] Re: qcow2 image corruption in trusty (qemu 1.7 and 2.0 candidate)

2014-12-09 Thread Chris J Arges
Serge, So I was able to just compile my own qemu and test with that. I did attempt a reverse bisect, and was able to reproduce as early as v1.1 and also reproduce on master HEAD. v1.0 was inconclusive because qcow2 format I made with the newer binary seemed to be incompatible with v1.0; however

Re: [Qemu-devel] [PATCH RESEND for 2.3 4/6] xbzrle: check 8 bytes at a time after an concurrency scene

2014-12-09 Thread ChenLiang
On 2014/12/10 11:18, Amit Shah wrote: > On (Mon) 24 Nov 2014 [19:55:50], arei.gong...@huawei.com wrote: >> From: ChenLiang >> >> The logic of old code is correct. But Checking byte by byte will >> consume time after an concurrency scene. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei

Re: [Qemu-devel] [Bug 1292234] Re: qcow2 image corruption in trusty (qemu 1.7 and 2.0 candidate)

2014-12-09 Thread Serge Hallyn
Excellent! Any chance you can start bisecting with http://people.canonical.com/~serge/binaries.{0..68}/{qemu-img,qemu- system-x86_64} ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1292234 Title:

Re: [Qemu-devel] [PATCH RESEND for 2.3 4/6] xbzrle: check 8 bytes at a time after an concurrency scene

2014-12-09 Thread Amit Shah
On (Mon) 24 Nov 2014 [19:55:50], arei.gong...@huawei.com wrote: > From: ChenLiang > > The logic of old code is correct. But Checking byte by byte will > consume time after an concurrency scene. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > xbzrle.c | 28 ++-

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-12-09 Thread Amit Shah
On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote: > This patchset fixes CVE-2014-7840: invalid > migration stream can cause arbitrary qemu memory > overwrite. > First patch includes the minimal fix for the issue. > Follow-up patches on top add extra checking to reduce the > chance this kin

Re: [Qemu-devel] [PATCH RESEND for 2.3 0/6] xbzrle: optimize the xbzrle

2014-12-09 Thread Amit Shah
On (Mon) 24 Nov 2014 [19:55:46], arei.gong...@huawei.com wrote: > From: ChenLiang > > Hi, > > This set of patches rebase on > https://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg04956.html, > > Those patches have been reviewed before half a year. > For now I rebase them with the master

Re: [Qemu-devel] [PATCH v2 0/4] More migration file cleanup

2014-12-09 Thread Amit Shah
On (Tue) 09 Dec 2014 [12:15:29], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This is a small set of patches that shuffle migration code > around, but doesn't change the behaviour: > > 1) Move a lot of the migration source into a separate 'migration' directory >

Re: [Qemu-devel] [PATCH v2 1/4] Start migrating migration code into a migration directory

2014-12-09 Thread Amit Shah
On (Tue) 09 Dec 2014 [12:15:30], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. > > I've not touched: >arch_init.c - that's mostly RAM migration bu

Re: [Qemu-devel] [PATCH] qmp-command.hx: add missing docs for migration capabilites

2014-12-09 Thread Amit Shah
On (Tue) 09 Dec 2014 [08:35:05], Eric Blake wrote: > On 12/08/2014 11:38 PM, zhanghailiang wrote: > > Signed-off-by: zhanghailiang > > --- > > qmp-commands.hx | 6 ++ > > 1 file changed, 6 insertions(+) > > > > - "xbzrle": XBZRLE support > > +- "rdma-pin-all": pin all pages when use of RDM

Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server

2014-12-09 Thread Josh Durgin
On 12/09/2014 01:49 AM, Stefan Hajnoczi wrote: On Tue, Dec 9, 2014 at 3:52 AM, Josh Durgin wrote: On 12/08/2014 05:58 AM, Jun Li wrote: On Fri, 12/05 18:01, Max Reitz wrote: On 2014-12-05 at 16:32, Jun Li wrote: Currently, qemu-img can not create qcow2 image format on rbd server. Analysis

Re: [Qemu-devel] [PATCH] block: fix big write

2014-12-09 Thread Ming Lei
On Wed, Dec 10, 2014 at 1:45 AM, Paolo Bonzini wrote: > > > On 08/12/2014 08:19, Ming Lei wrote: >>> > >>> > Alternatively, I'd accept a SCSI patch setting max_ws_blocks and friends >>> > to 2GB - 1 block. >> It should be better to not introduce the limit and split the writes >> into size of 2GB -

Re: [Qemu-devel] [PATCH v9 07/10] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2014-12-09 Thread Fam Zheng
On Tue, 12/09 17:44, Stefan Hajnoczi wrote: > On Mon, Dec 01, 2014 at 03:30:13PM -0500, John Snow wrote: > > From: Fam Zheng > > > > For "dirty-bitmap" sync mode, the block job will iterate through the > > given dirty bitmap to decide if a sector needs backup (backup all the > > dirty clusters an

Re: [Qemu-devel] migration from qemu2.1.2 to qemu2.2

2014-12-09 Thread William Dauchy
Hi David, Thank you for the quick answer. On Dec09 18:55, Dr. David Alan Gilbert wrote: > You don't tell us what that command line is! > If you're using -M pc or -M q35 that's expected; if you're not > it's probably a bug - please show us the command line. sorry it's indeed with `-M pc`. So I m

[Qemu-devel] [PATCH 1/2] target-arm: Split NO_MIGRATE into ALIAS and NO_RAW

2014-12-09 Thread Peter Maydell
We currently mark ARM coprocessor/system register definitions with the flag ARM_CP_NO_MIGRATE for two different reasons: 1) register is an alias on to state that's also visible via some other register, and that other register is the one responsible for migrating the state 2) register is not a

[Qemu-devel] [PATCH 2/2] target-arm: Add checks that cpreg raw accesses are handled

2014-12-09 Thread Peter Maydell
Add assertion checking when cpreg structures are registered that they either forbid raw-access attempts or at least make an attempt at handling them. Also add an assert in the raw-accessor-of-last-resort, to avoid silently doing a read or write from offset zero, which is actually AArch32 CPU regist

[Qemu-devel] [PATCH 0/2] target-arm: fix broken sync of sysregs between QEMU and KVM 32 bit

2014-12-09 Thread Peter Maydell
This patchset fixes a regression in the synchronization of system registers between QEMU and KVM for 32-bit ARM hosts. The most obvious effect of the bug is that trying to access memory via the gdbstub doesn't work, because gdbstub thinks the MMU is off and doesn't get the virt-to-phys translation

Re: [Qemu-devel] [PATCH v11 06/26] target-arm: add secure state bit to CPREG hash

2014-12-09 Thread Greg Bellows
Sounds good. Thanks for catching and fixing this. On 9 December 2014 at 12:43, Peter Maydell wrote: > On 17 November 2014 at 16:47, Greg Bellows > wrote: > > Added additional NS-bit to CPREG hash encoding. Updated hash lookup > > locations to specify hash bit currently set to non-secure. > >

Re: [Qemu-devel] migration from qemu2.1.2 to qemu2.2

2014-12-09 Thread Dr. David Alan Gilbert
* William Dauchy (will...@gandi.net) wrote: > Hello, > > I have been testing live migration from qemu2.1.2 to qemu2.2.0 under > kvm - with same config and same command line. > > the process crashes with: > > Unknown combination of migration flags: 0 > qemu: warning: error while loading state sec

Re: [Qemu-devel] [PATCH v11 06/26] target-arm: add secure state bit to CPREG hash

2014-12-09 Thread Peter Maydell
On 17 November 2014 at 16:47, Greg Bellows wrote: > Added additional NS-bit to CPREG hash encoding. Updated hash lookup > locations to specify hash bit currently set to non-secure. > > Signed-off-by: Greg Bellows > Reviewed-by: Peter Maydell > > --- > > v8 -> v9 > - Fixed CP_REG_NS_MASK > - Cha

Re: [Qemu-devel] migration from qemu2.1.2 to qemu2.0

2014-12-09 Thread William Dauchy
(sorry bad subject, I meant qemu2.2) -- William signature.asc Description: Digital signature

[Qemu-devel] migration from qemu2.1.2 to qemu2.0

2014-12-09 Thread William Dauchy
Hello, I have been testing live migration from qemu2.1.2 to qemu2.2.0 under kvm - with same config and same command line. the process crashes with: Unknown combination of migration flags: 0 qemu: warning: error while loading state section id 2 Don't know if it's supposed to be supported or not.

[Qemu-devel] [ANNOUNCE] QEMU 2.2.0 is now available

2014-12-09 Thread Michael Roth
On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 2.2.0 release. This release contains 1700+ commits from 171 authors. http://wiki.qemu.org/download/qemu-2.2.0.tar.bz2 The full list of changes are available at: http://wiki.qemu.org/ChangeLog/2.2 Highlights includ

Re: [Qemu-devel] [PATCH 0/7] MIPS: IEEE 754-2008 features support

2014-12-09 Thread Maciej W. Rozycki
On Tue, 9 Dec 2014, Peter Maydell wrote: > >> I really really want to hold this patchset off until the softfloat > >> relicensing has gone through, because repeating that work would > >> be really painful... > > > > Understood. Do you have an ETA for this to happen? > > It's waiting for people

[Qemu-devel] [PATCH 1/2] Restore atapi_dma flag across migration

2014-12-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If a migration happens just after the guest has kicked off an ATAPI command and kicked off DMA, we lose the atapi_dma flag, and the destination tries to complete the command as PIO rather than DMA. This upsets Linux; modern libata based kernels stumble and recover

[Qemu-devel] [PATCH 2/2] atapi migration: Throw recoverable error to avoid recovery

2014-12-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" (With the previous atapi_dma flag recovery) If migration happens between the ATAPI command being written and the bmdma being started, the DMA is dropped. Eventually the guest times out and recovers, but that can take many seconds. (This is rare, on a pingpong readi

[Qemu-devel] [PATCH 0/2] ATAPI migration fix/hack

2014-12-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This pair of patches fixes a problem where IDE/ATAPI cdrom reads get lost/corrupted over migration. The first of the patches (restore atapi_dma flag) is a simple fix that I think is safe; it no longer causes corruption in the case we saw, but does still trigger a l

Re: [Qemu-devel] TCG multithread plan.

2014-12-09 Thread Lluís Vilanova
Frederic Konrad writes: > Hi everybody, > Here is the plan we will follow: > We will be focusing - from the outset - on the end goal of multi-threaded TCG > in full system emulation mode. On the way, we expect this will ‘fix’ user > mode. > The plan is: > * Create one cache per CPU as a first

Re: [Qemu-devel] [PATCH v5 1/2] Add device listener interface

2014-12-09 Thread Andreas Färber
Am 09.12.2014 um 18:40 schrieb Paolo Bonzini: > On 08/12/2014 12:12, Paul Durrant wrote: >>> -Original Message- >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >>> Sent: 05 December 2014 11:45 >>> To: Paul Durrant; qemu-devel@nongnu.org >>> Cc: Michael S. Tsirkin; Andreas Faerber"; Pet

Re: [Qemu-devel] [PATCH V9 1/3] docs: vm generation id device's description

2014-12-09 Thread Eric Blake
On 12/09/2014 09:14 AM, Gal Hammer wrote: > Signed-off-by: Gal Hammer > > --- > docs/specs/vmgenid.txt | 27 +++ > 1 file changed, 27 insertions(+) > create mode 100644 docs/specs/vmgenid.txt > > diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt > new file mo

Re: [Qemu-devel] [PATCH] SCSI: splite write_zero in unit of at most INT_MAX bytes

2014-12-09 Thread Paolo Bonzini
On 08/12/2014 10:20, Ming Lei wrote: > Currently block can not handle big write well when write > size is bigger than INT_MAX, so split the write zero into > smaller size of chunks to meet block's requirement. > > This patch fixes one WRITE SAME 16 failure in linux VM side. Can you just set max

Re: [Qemu-devel] [PATCH v9 08/10] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}

2014-12-09 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 03:30:14PM -0500, John Snow wrote: > From: Fam Zheng > > This adds three qmp commands to transactions. > > Users can stop a dirty bitmap, start backup of it, and start another > dirty bitmap atomically, so that the dirty bitmap is tracked > incrementally and we don't miss

Re: [Qemu-devel] [PATCH] block: fix big write

2014-12-09 Thread Paolo Bonzini
On 08/12/2014 08:19, Ming Lei wrote: >> > >> > Alternatively, I'd accept a SCSI patch setting max_ws_blocks and friends >> > to 2GB - 1 block. > It should be better to not introduce the limit and split the writes > into size of 2GB - 1 block since there is only the limit for write zero. Why? Tha

Re: [Qemu-devel] [PATCH v9 07/10] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2014-12-09 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 03:30:13PM -0500, John Snow wrote: > From: Fam Zheng > > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "

Re: [Qemu-devel] [PATCH v4 00/10] VM Power Management

2014-12-09 Thread Paolo Bonzini
I had replied to this message, but my reply never got to the list. Let's try again. I wonder if this might be papering over a bug in the host cpufreq driver. If the guest is not doing much and leaving a lot of idle CPU time, the host should scale down the frequency of that CPU. In the case of pi

Re: [Qemu-devel] [PATCH v5 1/2] Add device listener interface

2014-12-09 Thread Paolo Bonzini
On 08/12/2014 12:12, Paul Durrant wrote: >> -Original Message- >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Sent: 05 December 2014 11:45 >> To: Paul Durrant; qemu-devel@nongnu.org >> Cc: Michael S. Tsirkin; Andreas Faerber"; Peter Crosthwaite; Igor >> Mammedov; Markus Armbruster

Re: [Qemu-devel] [RFC PATCH v6 08/32] icount: implement icount requesting

2014-12-09 Thread Paolo Bonzini
On 08/12/2014 08:53, Pavel Dovgalyuk wrote: > if (!cpu_can_do_io(cpu)) { > -fprintf(stderr, "Bad clock read\n"); > +fprintf(stderr, "Bad icount read\n"); > +exit(1); > } > icount -= (cpu->icount_decr.u16.low + cpu->icount_extra); >

Re: [Qemu-devel] [PATCH v9 06/10] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2014-12-09 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 03:30:12PM -0500, John Snow wrote: > +/** > + * Return a dirty bitmap (if present), after validating > + * the device and bitmap names. Returns NULL on error, > + * including when the device and/or bitmap is not found. > + */ > +static BdrvDirtyBitmap *block_dirty_bitmap_loo

Re: [Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0

2014-12-09 Thread Cornelia Huck
On Tue, 9 Dec 2014 15:46:46 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote: > > virtio-ccw should now have everything in place to operate virtio 1.0 > > devices, so let's enable revision 1. > > > > Signed-off-by: Cornelia Huck > > Looks like t

Re: [Qemu-devel] [PATCH v9 04/10] hbitmap: Add hbitmap_copy

2014-12-09 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 03:30:10PM -0500, John Snow wrote: > +HBitmap *hbitmap_copy(const HBitmap *bitmap) > +{ > +int i; > +uint64_t size; > +HBitmap *hb = g_memdup(bitmap, sizeof(HBitmap)); > + > +size = bitmap->size; > +for (i = HBITMAP_LEVELS - 1; i >= 0; i--) { > +s

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-09 Thread Richard W.M. Jones
On Tue, Dec 09, 2014 at 03:47:44PM +, Peter Maydell wrote: > On 9 December 2014 at 15:41, Laszlo Ersek wrote: > > Again, this was the idea that Rich had in 2010 (see the links in the > > discussion thus far). It was rejected back then (which is why I didn't > > even try to resurrect it now), a

Re: [Qemu-devel] Cubietruck: cannot create KVM guests: "kvm_init_vcpu failed: Invalid argument"

2014-12-09 Thread Kashyap Chamarthy
On Tue, Dec 09, 2014 at 11:27:02AM +, Richard W.M. Jones wrote: > On Tue, Dec 09, 2014 at 10:53:41AM +, Peter Maydell wrote: > > On 9 December 2014 at 10:50, Kashyap Chamarthy wrote: > > > Booting a minimal KVM guest throws the below error on Cubietruck: > > > > > > "kvm_init_vcpu failed

[Qemu-devel] [PATCH 1/4] block: add accounting for merged requests

2014-12-09 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Eric Blake --- block.c|2 ++ block/accounting.c |7 +++ block/qapi.c |2 ++ hmp.c |6 +- include/block/accounting.h |3 +++ qapi/block-core.json |9 ++

[Qemu-devel] [PATCH 0/4] virtio-blk: add multiread support

2014-12-09 Thread Peter Lieven
this series adds the long missing multiread support to virtio-blk. some remarks: - i introduced rd_merged and wr_merged block accounting stats to blockstats as a generic interface which can be set from any driver that will introduce multirequest merging in the future. - the knob to disable

[Qemu-devel] [PATCH 3/4] block-backend: expose bs->bl.max_transfer_length

2014-12-09 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/block-backend.c |5 + include/sysemu/block-backend.h |1 + 2 files changed, 6 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index d0692b1..545580f 100644 --- a/block/block-backend.c +++ b/block/block-backend.c

[Qemu-devel] [PATCH 4/4] virtio-blk: introduce multiread

2014-12-09 Thread Peter Lieven
this patch finally introduces multiread support to virtio-blk. While multiwrite support was there for a long time, read support was missing. To achieve this the patch does several things which might need further explanation: - the whole merge and multireq logic is moved from block.c into virt

[Qemu-devel] [PATCH 2/4] hw/virtio-blk: add a constant for max number of merged requests

2014-12-09 Thread Peter Lieven
As it was not obvious (at least for me) where the 32 comes from; add a constant for it. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake --- hw/block/virtio-blk.c |2 +- include/hw/virtio/virtio-blk.h |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH V9 1/3] docs: vm generation id device's description

2014-12-09 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..9a09d11 --- /dev/null +++ b/docs/sp

[Qemu-devel] [PATCH V9 3/3] tests: add a unit test for the vmgenid device.

2014-12-09 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 48 2 files changed, 50 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index 16f0e4c..612441a 100644 --- a/tes

[Qemu-devel] [PATCH V9 0/3] Virtual Machine Generation ID

2014-12-09 Thread Gal Hammer
Hi, Resending patches after the release of version 2.2. Please note that this patch set doesn't include the *.hex.generated files and the binary ACPI tables (make check will fail). Thanks, Gal. V9 - Add a unit test. - Rebased to version 2.2. - Removed hex.generated the binary files f

[Qemu-devel] [PATCH V9 2/3] i386: Add a Virtual Machine Generation ID device

2014-12-09 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- default-configs/i386-

Re: [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_granularity()

2014-12-09 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 03:30:09PM -0500, John Snow wrote: > diff --git a/include/block/block.h b/include/block/block.h > index 066ded6..f180f93 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -440,6 +440,8 @@ void bdrv_dirty_bitmap_make_anon(BlockDriverState *bs, > BdrvDir

[Qemu-devel] [Bug 1400768] Re: Fatal error when running with '-machine isapc' on 2.1.2

2014-12-09 Thread #1
Hello, I too have the same results. Below is an additional snippet where the call is made through valgrind. While valgrind grinds, the SDL window displays "Guest has not initialized the display (yet)." ==16648== Memcheck, a memory error detector ==16648== Copyright (C) 2002-2013, and

Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2014-12-09 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 03:30:08PM -0500, John Snow wrote: > diff --git a/block.c b/block.c > index e5c6ccf..3f27519 100644 > --- a/block.c > +++ b/block.c > @@ -5420,6 +5420,25 @@ int bdrv_get_dirty(BlockDriverState *bs, > BdrvDirtyBitmap *bitmap, int64_t sector > } > } > > +#define BDB_M

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-09 Thread Peter Maydell
On 9 December 2014 at 15:41, Laszlo Ersek wrote: > Again, this was the idea that Rich had in 2010 (see the links in the > discussion thus far). It was rejected back then (which is why I didn't > even try to resurrect it now), and Peter has now asked if anything has > changed that would make that a

[Qemu-devel] [Bug 1400768] [NEW] Fatal error when running with '-machine isapc' on 2.1.2

2014-12-09 Thread Matthew Thode
Public bug reported: all I have are the traces, should hopefully be easy to reproduce. # qemu-system-i386 -machine isapc VNC server running on `::1:5900' qemu: fatal: Trying to execute code outside RAM or ROM at 0x1a0dff44 EAX=000f0f88 EBX=0010 ECX=07fc EDX=002c ESI=6f5c EDI=0800

Re: [Qemu-devel] [RFC PATCH V2 4/4] virtio-blk: introduce multiread

2014-12-09 Thread Peter Lieven
On 05.12.2014 16:05, Eric Blake wrote: On 12/05/2014 04:50 AM, Peter Lieven wrote: this patch finally introduce multiread support to virtio-blk while s/introduce/introduces/ s/virtio-blk while/virtio-blk. While/ multiwrite support was there for a long time read support was missing. s/time/ti

Re: [Qemu-devel] [RFC PATCH V2 1/4] block: add accounting for merged requests

2014-12-09 Thread Peter Lieven
On 05.12.2014 15:58, Eric Blake wrote: On 12/05/2014 04:50 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven --- block.c|2 ++ block/accounting.c |7 +++ block/qapi.c |2 ++ hmp.c |6 +- include/block

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-09 Thread Laszlo Ersek
On 12/09/14 10:31, Gerd Hoffmann wrote: > Hi, > >> So... after playing with this thing for some time, it's become clear >> that "MMIO traps" are painfully slow on the aarch64 platform we've been >> working on (using KVM). > > So, as we don't have compatibility requirements, and we also can't pl

Re: [Qemu-devel] [PATCH] qmp-command.hx: add missing docs for migration capabilites

2014-12-09 Thread Eric Blake
On 12/08/2014 11:38 PM, zhanghailiang wrote: > Signed-off-by: zhanghailiang > --- > qmp-commands.hx | 6 ++ > 1 file changed, 6 insertions(+) > - "xbzrle": XBZRLE support > +- "rdma-pin-all": pin all pages when use of RDMA during migration s/use of/using/ With the grammar fix, Reviewed-b

Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests

2014-12-09 Thread Eric Blake
On 12/09/2014 12:38 AM, Fam Zheng wrote: > This will make it easier to keep checkpatch.pl happy. > > Fam Zheng (2): > qemu-iotests: Remove traling whitespaces in *.out > block: Don't add trailing space in "Formating..." message Series: Reviewed-by: Eric Blake -- Eric Blake eblake redhat

Re: [Qemu-devel] about tracetool

2014-12-09 Thread Stefan Hajnoczi
On Tue, Dec 02, 2014 at 09:46:50AM +0900, Ady Wahyudi Paundu wrote: > I know that simpletrace records go to memory buffer before it flushed > to file by a writer thread. My question is how to call this thread > (preferably using python), so I can make the flush process periodical? Look at the sou

Re: [Qemu-devel] [PATCH v3] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list()

2014-12-09 Thread Andreas Färber
Am 05.11.2014 um 08:03 schrieb Jun Li: > Currently when *obj is not a TYPE_DEVICE, qemu will abort. This patch just > fixed it. When *obj is not a TYPE_DEVICE, just do not add it to hotpluggable > device list. > > This patch also fixed the following issue: > 1, boot qemu using cli: > $ /opt/qemu-g

Re: [Qemu-devel] [PATCH] nvme: 64kB page size fixes

2014-12-09 Thread Stefan Hajnoczi
On Tue, Dec 02, 2014 at 09:18:59PM +0100, Paolo Bonzini wrote: > > > On 27/11/2014 04:39, Anton Blanchard wrote: > > Initialise our maximum page size capability to 64kB and increase > > the page_size variable from 16 to 32 bits. > > > > Signed-off-by: Anton Blanchard > > -- > > > > diff --git

Re: [Qemu-devel] [PATCH v2] Block migration: fix return value

2014-12-09 Thread Stefan Hajnoczi
On Tue, Nov 25, 2014 at 05:30:02PM -0600, grhookatw...@gmail.com wrote: > From: Gary R Hook > > Modify block_save_iterate() to return positive/zero/negative > (success/not done/failure) return status. The computation of > the blocks transferred (an int64_t) exceeds the size of an > int return val

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-09 Thread Bryan D. Payne
> > By "evidence", I mean actual numbers for actual QEMU code. Nothing > sophisticated, just use your new interface in a way you consider > relevant for your own use case, then approximate this use with existing > interfaces. The approximation can be very rough. For instance, showing > that doin

Re: [Qemu-devel] [PATCH v3] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list()

2014-12-09 Thread Andreas Färber
Am 08.12.2014 um 15:07 schrieb Jun Li: > Ping, why does this patch has not been merged until now? Could anyone give > some explanations? Thx. I had already applied the previous version of the patch to qom-next. I'll drop it and replace it with this version then. Regards, Andreas > On Wed, 11/05

Re: [Qemu-devel] [PATCH 0/5] tpm: Extend the TPM TIS implementation

2014-12-09 Thread Stefan Berger
On 12/09/2014 09:45 AM, Michael S. Tsirkin wrote: On Tue, Dec 09, 2014 at 09:40:28AM -0500, Stefan Berger wrote: On 12/09/2014 09:35 AM, Michael S. Tsirkin wrote: On Tue, Dec 09, 2014 at 09:18:54AM -0500, Stefan Berger wrote: The following series of patches extends the TPM TIS implementation t

Re: [Qemu-devel] [PATCH 0/5] tpm: Extend the TPM TIS implementation

2014-12-09 Thread Michael S. Tsirkin
On Tue, Dec 09, 2014 at 09:40:28AM -0500, Stefan Berger wrote: > On 12/09/2014 09:35 AM, Michael S. Tsirkin wrote: > >On Tue, Dec 09, 2014 at 09:18:54AM -0500, Stefan Berger wrote: > >>The following series of patches extends the TPM TIS implementation to > >>version 1.3. This will lead to a TIS ver

Re: [Qemu-devel] [PATCH 0/5] tpm: Extend the TPM TIS implementation

2014-12-09 Thread Stefan Berger
On 12/09/2014 09:35 AM, Michael S. Tsirkin wrote: On Tue, Dec 09, 2014 at 09:18:54AM -0500, Stefan Berger wrote: The following series of patches extends the TPM TIS implementation to version 1.3. This will lead to a TIS version that supports TPM 2. For this I would post relatively small patches

Re: [Qemu-devel] [PATCH 0/5] tpm: Extend the TPM TIS implementation

2014-12-09 Thread Michael S. Tsirkin
On Tue, Dec 09, 2014 at 09:18:54AM -0500, Stefan Berger wrote: > The following series of patches extends the TPM TIS implementation to > version 1.3. This will lead to a TIS version that supports TPM 2. > For this I would post relatively small patches afterwards. > > Regards, >Stefan Since t

Re: [Qemu-devel] [PATCH 9/9] pc: acpi-build: replace recursive PCI bus tree generation with loop based

2014-12-09 Thread Michael S. Tsirkin
On Tue, Dec 09, 2014 at 03:01:00PM +0100, Igor Mammedov wrote: > On Mon, 8 Dec 2014 22:43:24 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 08, 2014 at 04:08:08PM +, Igor Mammedov wrote: > > > it replaces PCI tree structure in SSDT with a set of scopes > > > describing each PCI bus as

[Qemu-devel] [PATCH 1/5] tpm: Extend sts register to 32 bit

2014-12-09 Thread Stefan Berger
More recent TIS specs extend the STS register to 32 bit. While we don't store the TIS interface state, yet, we can extend it without sideeffects. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_ti

[Qemu-devel] [PATCH 4/5] tpm: Support for TIS selftest done flag

2014-12-09 Thread Stefan Berger
Extend the backend to check whether the TPM_ContinueSelfTest finished successfully and provide a flag to the TIS front-end if it successfully finished. The TIS then sets a flag in all localities in the STS register and keeps it until the next reset. Signed-off-by: Stefan Berger --- hw/tpm/tpm_in

[Qemu-devel] [PATCH 3/5] tpm: Support for XFIFO register

2014-12-09 Thread Stefan Berger
Support for the XFIFO register (range) of the TIS 1.3 specification. We support a range of 64 bytes. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 6170693..a37c7ce 100644 --- a/hw/tpm/tpm_tis.c

[Qemu-devel] [PATCH 5/5] tpm: Support for capability flags of TIS 1.3

2014-12-09 Thread Stefan Berger
Provide the TIS 1.3 capability flags. The interface now looks like a TIS 1.3 interface. It's fully compatible with previous TIS 1.2 and drivers written for TIS 1.2 continue to work. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) d

[Qemu-devel] [PATCH 2/5] tpm: Allow 32 & 16 bit accesses to the registers

2014-12-09 Thread Stefan Berger
Improve the access to the registers with 32 and 16 bit reads and writes. Also enable access to a non-base register address, such as reads of the 2nd byte of a register. Map the FIFO byte access to any byte within its 4 byte register (following specs). Signed-off-by: Stefan Berger --- hw/tpm/tpm_

[Qemu-devel] [PATCH 0/5] tpm: Extend the TPM TIS implementation

2014-12-09 Thread Stefan Berger
The following series of patches extends the TPM TIS implementation to version 1.3. This will lead to a TIS version that supports TPM 2. For this I would post relatively small patches afterwards. Regards, Stefan Stefan Berger (5): tpm: Extend sts register to 32 bit tpm: Allow 32 & 16 bit a

Re: [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable

2014-12-09 Thread Igor Mammedov
On Tue, 9 Dec 2014 14:51:59 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 09, 2014 at 12:45:27PM +0100, Igor Mammedov wrote: > > On Tue, 9 Dec 2014 12:34:02 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 09, 2014 at 11:27:16AM +0100, Igor Mammedov wrote: > > > > On Mon, 8 Dec 201

Re: [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable

2014-12-09 Thread Igor Mammedov
On Tue, 9 Dec 2014 14:51:59 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 09, 2014 at 12:45:27PM +0100, Igor Mammedov wrote: > > On Tue, 9 Dec 2014 12:34:02 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 09, 2014 at 11:27:16AM +0100, Igor Mammedov wrote: > > > > On Mon, 8 Dec 201

[Qemu-devel] [PATCH 1/1] MAINTAINERS: Update email addresses for Chrysostomos Nanakos

2014-12-09 Thread Chrysostomos Nanakos
Remove first email address and let the one from which I am contributing. Signed-off-by: Chrysostomos Nanakos --- MAINTAINERS |1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index bcb69e8..a33d8f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1089,7 +1089,6 @@ S:

Re: [Qemu-devel] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write

2014-12-09 Thread Paolo Bonzini
On 09/12/2014 08:15, zhanghailiang wrote: > Refactor superio_ioport_writeb to fix the out of bounds write warning. > > In addition, fix two typos: s/chage/change/ > > Signed-off-by: zhanghailiang > --- > - using bool instead of int for can_write as suggested by Stefan Weil > - fix two typos:

[Qemu-devel] [PATCH 0/1] Update email addresses for Chrysostomos Nanakos

2014-12-09 Thread Chrysostomos Nanakos
Remove first email address and let the one from which I am contributing. Chrysostomos Nanakos (1): MAINTAINERS: Update email addresses for Chrysostomos Nanakos MAINTAINERS |1 - 1 file changed, 1 deletion(-) -- 1.7.10.4

Re: [Qemu-devel] [PATCH 9/9] pc: acpi-build: replace recursive PCI bus tree generation with loop based

2014-12-09 Thread Igor Mammedov
On Mon, 8 Dec 2014 22:43:24 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 08, 2014 at 04:08:08PM +, Igor Mammedov wrote: > > it replaces PCI tree structure in SSDT with a set of scopes > > describing each PCI bus as a separate scope with a child devices. > > It makes code easier to follow a

Re: [Qemu-devel] Cubietruck: cannot create KVM guests: "kvm_init_vcpu failed: Invalid argument"

2014-12-09 Thread Peter Maydell
On 9 December 2014 at 12:33, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 9 December 2014 at 11:25, Richard W.M. Jones wrote: >> > I really think that qemu should just "do the right thing" though. >> >> Tricky, because you have to use the same CPU as the

Re: [Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0

2014-12-09 Thread Michael S. Tsirkin
On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote: > virtio-ccw should now have everything in place to operate virtio 1.0 > devices, so let's enable revision 1. > > Signed-off-by: Cornelia Huck Looks like this will allow revision 1 for all devices, we only want this for virtio 1 devi

[Qemu-devel] KVM call for 2014-12-09

2014-12-09 Thread Juan Quintela
Hi Just a gentle reminder that Today we have a call to continue talking about multithread. Thanks, Juan.

Re: [Qemu-devel] KVM call for agenda for 2014-12-08

2014-12-09 Thread Juan Quintela
Alexander Spyridakis wrote: > Hello, > > Is this call still going to happen today? I haven't yet received the > contact details. Just sent it, it would be in 20 mins. Later, Juan.

Re: [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state

2014-12-09 Thread Cornelia Huck
On Mon, 8 Dec 2014 09:18:59 +0100 Frank Blaschka wrote: > Remove all unnecessary calls to cpu_synchronize_state > > Signed-off-by: Frank Blaschka > --- > hw/s390x/s390-pci-inst.c | 6 -- > 1 file changed, 6 deletions(-) Applied to s390-next.

Re: [Qemu-devel] [PATCH 0/2] s390/pci: add 2 more features

2014-12-09 Thread Cornelia Huck
On Fri, 5 Dec 2014 10:19:57 +0100 Frank Blaschka wrote: > Coni, Alex, Christian, > > here are 2 more s390/pci features on top of the base pci support. > Thx! > > Frank > > Frank Blaschka (2): > s390/pci: add error event support > s390/pci: implement stpcifc instruction > > hw/s390x/s390

Re: [Qemu-devel] [PATCH 1/2] s390/pci: add error event support

2014-12-09 Thread Cornelia Huck
On Fri, 5 Dec 2014 10:19:58 +0100 Frank Blaschka wrote: > From: Frank Blaschka > > This patch adds support to generate s390 pci error events It also uses the new infrastructure for iota error handling (which confused me when I read this), so I modified the patch description to read: "This pa

Re: [Qemu-devel] Cubietruck: cannot create KVM guests: "kvm_init_vcpu failed: Invalid argument"

2014-12-09 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 9 December 2014 at 11:25, Richard W.M. Jones wrote: > > I really think that qemu should just "do the right thing" though. > > Tricky, because you have to use the same CPU as the host if > you want to use KVM That's an unusally strict require

Re: [Qemu-devel] KVM call for agenda for 2014-12-08

2014-12-09 Thread Alexander Spyridakis
Hello, Is this call still going to happen today? I haven't yet received the contact details. Thanks and best regards.

Re: [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable

2014-12-09 Thread Michael S. Tsirkin
On Tue, Dec 09, 2014 at 01:57:51PM +0100, Igor Mammedov wrote: > On Tue, 9 Dec 2014 14:51:59 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 09, 2014 at 12:45:27PM +0100, Igor Mammedov wrote: > > > On Tue, 9 Dec 2014 12:34:02 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue, D

  1   2   >