On 05.12.2014 16:05, Eric Blake wrote:
On 12/05/2014 04:50 AM, Peter Lieven wrote:
this patch finally introduce multiread support to virtio-blk while
s/introduce/introduces/
s/virtio-blk while/virtio-blk. While/
multiwrite support was there for a long time read support was missing.
s/time/time,/
To achieve this the patch does serveral things which might need futher
s/serveral/several/
s/futher/further/
explaination:
s/explaination/explanation/
- the whole merge and multireq logic is moved from block.c into
virtio-blk. This is move is a preparation for directly creating a
coroutine out of virtio-blk.
Can this move be done as a separate prerequisite patch? Mixing code
motion and new features in the same patch is harder to review.
The issue is that the code is not movable. I could artifically use
the new code in a new patch only for write requests and add
another patch to add read merging. But I doubt that it would make
it easier to review but even harder.
Peter
