[Qemu-devel] [PATCH for-2.3 1/2] qemu-iotests: Remove traling whitespaces in *.out

2014-12-08 Thread Fam Zheng
This is simply: $ cd tests/qemu-iotests; sed -i -e 's/ *$//' *.out Signed-off-by: Fam Zheng --- tests/qemu-iotests/001.out | 2 +- tests/qemu-iotests/002.out | 2 +- tests/qemu-iotests/003.out | 2 +- tests/qemu-iotests/004.out | 2 +- tests/qemu-iotests/005.out | 2 +- tests/qemu-i

[Qemu-devel] [PATCH for-2.3 2/2] block: Don't add trailing space in "Formating..." message

2014-12-08 Thread Fam Zheng
Change the message printing code to output a separator for each option string before it instead of after, then we don't one more extra ' ' in the end. To update qemu-iotests output files, most of the times one would just copy the *.out.bad to *.out. With this change we will not have the space disl

[Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests

2014-12-08 Thread Fam Zheng
This will make it easier to keep checkpatch.pl happy. Fam Zheng (2): qemu-iotests: Remove traling whitespaces in *.out block: Don't add trailing space in "Formating..." message block.c| 4 +- include/qemu/option.h | 2 +- tests/qemu-iotests/001.out | 2 +- test

[Qemu-devel] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write

2014-12-08 Thread zhanghailiang
Refactor superio_ioport_writeb to fix the out of bounds write warning. In addition, fix two typos: s/chage/change/ Signed-off-by: zhanghailiang --- - using bool instead of int for can_write as suggested by Stefan Weil - fix two typos: s/chage/change --- hw/isa/vt82c686.c | 41

Re: [Qemu-devel] [PATCH] vt82c686: fix coverity warning about out-of-bounds write

2014-12-08 Thread zhanghailiang
On 2014/12/9 14:04, Stefan Weil wrote: Am 09.12.2014 um 06:44 schrieb zhanghailiang: Refactor superio_ioport_writeb to fix the out of bounds write warning. Signed-off-by: zhanghailiang --- hw/isa/vt82c686.c | 39 ++- 1 file changed, 18 insertions(+), 21 d

[Qemu-devel] [PATCH] qmp-command.hx: add missing docs for migration capabilites

2014-12-08 Thread zhanghailiang
Signed-off-by: zhanghailiang --- qmp-commands.hx | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qmp-commands.hx b/qmp-commands.hx index 718dd92..4f0b36e 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -3184,6 +3184,9 @@ migrate-set-capabilities Enable/Disable migration capabilit

Re: [Qemu-devel] Redundant VDE network

2014-12-08 Thread Dmitry Antipov
On 12/08/2014 08:53 PM, Stefan Hajnoczi wrote: Try: qemu-system-sparc -m 256 \ -netdev vde,sock=/tmp/vde0,id=vde0 \ -device ne2k_pci,netdev=vde0 \ -netdev vde,sock=/tmp/vde1,id=vde1 \ -device ne2k_pci,netdev=vde1 \ -hda vm0.img This works just fine for qemu-system-x86

Re: [Qemu-devel] [PATCH] vt82c686: fix coverity warning about out-of-bounds write

2014-12-08 Thread Stefan Weil
Am 09.12.2014 um 06:44 schrieb zhanghailiang: > Refactor superio_ioport_writeb to fix the out of bounds write warning. > > Signed-off-by: zhanghailiang > --- > hw/isa/vt82c686.c | 39 ++- > 1 file changed, 18 insertions(+), 21 deletions(-) > > diff --git a/hw

[Qemu-devel] [PATCH] vt82c686: fix coverity warning about out-of-bounds write

2014-12-08 Thread zhanghailiang
Refactor superio_ioport_writeb to fix the out of bounds write warning. Signed-off-by: zhanghailiang --- hw/isa/vt82c686.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index e0c235c..4516af0 100

Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server

2014-12-08 Thread Josh Durgin
On 12/08/2014 05:58 AM, Jun Li wrote: On Fri, 12/05 18:01, Max Reitz wrote: On 2014-12-05 at 16:32, Jun Li wrote: Currently, qemu-img can not create qcow2 image format on rbd server. Analysis the code as followings: when create qcow2 format image: qcow2_create2 bdrv_create_file(filename, opt

[Qemu-devel] [PATCH v2] virtio: remove useless declaration of virtio_net_init()

2014-12-08 Thread arei.gonglei
From: Gonglei commit 1773d9ee (virtio-net: cleanup: init and exit function) removed the definition of virtio_net_init(), but didn't remove its declaration in the header. Clean that up. Cc: Markus Armbruster Signed-off-by: Gonglei --- v2: update the patch's tilte and commit message as sugges

[Qemu-devel] [PATCH 7/7] target-mips: Add IEEE 754-2008 features support

2014-12-08 Thread Maciej W. Rozycki
Add support for the IEEE 754-2008 features introduced to revision 3.50 [1][2] of the MIPS Architecture as follows. 1. IEEE 754-2008 NaN encoding. Implement the CP1.FCSR.NAN2008 bit with the expected intepretation. Update code to handle CP1.FCSR.NAN2008 correctly in CTC1 and the GDB s

[Qemu-devel] [PATCH 5/7] softfloat: Rework `*_is_*_nan' functions

2014-12-08 Thread Maciej W. Rozycki
Precompute the possible results, and then pick the suitable one. The calculation of the unused result will be optimized away by the compiler at any reasonable optimization level, so no run-time performance loss. Signed-off-by: Thomas Schwinge Signed-off-by: Maciej W. Rozycki --- qemu-softfloa

[Qemu-devel] [PATCH 4/7] softfloat: Add SoftFloat status parameter to `*_nan' functions

2014-12-08 Thread Maciej W. Rozycki
Mechanically update `*_nan' functions with a SoftFloat status parameter where qNaNs and sNaNs need to be told apart. Update all callers accordingly. Signed-off-by: Thomas Schwinge Signed-off-by: Maciej W. Rozycki --- BTW, this is another patch checkpatch.pl hangs on. Please apply. qemu-so

[Qemu-devel] [PATCH 6/7] softfloat: Add SoftFloat status `nan2008_mode' flag

2014-12-08 Thread Maciej W. Rozycki
Add support for switching between legacy NaN and IEEE 754-2008 NaN modes where required, currently for the MIPS target only. Also handle the saving and restoration of the `nan2008_mode' status flag. Use qNaN bit patterns for the 2008 NaN mode as from revision 5.00 [1][2] of the MIPS Architectu

[Qemu-devel] [PATCH 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2014-12-08 Thread Maciej W. Rozycki
Mechanically replace `*_default_nan' variables with inline functions and convert references accordingly. Use `__inline__' rather than `inline' so that the latter does not cause the definitions to become static as a result of macro expansion, the functions are best inlined when referred to from

[Qemu-devel] [PATCH 2/7] softfloat: Simplify `floatx80ToCommonNaN' function

2014-12-08 Thread Maciej W. Rozycki
Make the bit shuffling in one place only and replace input if required instead. Signed-off-by: Thomas Schwinge Signed-off-by: Maciej W. Rozycki --- qemu-softfloat-floatx80-nan.diff Index: qemu-git-trunk/fpu/softfloat-specialize.h =

[Qemu-devel] [PATCH 1/7] softfloat: Fix sNaN handling in FP conversion operations

2014-12-08 Thread Maciej W. Rozycki
Fix sNaN handling in floating-point format conversion operations, that are classified by the IEEE 754-2008 standard as general-computational operations [1]: "5.4 formatOf general-computational operations "5.4.2 Conversion operations for floating-point formats and decimal character sequences "

[Qemu-devel] [PATCH 0/7] MIPS: IEEE 754-2008 features support

2014-12-08 Thread Maciej W. Rozycki
Hi, This patch series comprises changes to QEMU, both the MIPS backend and generic SoftFloat support code, to support IEEE 754-2008 features introduced to revision 3.50 of the MIPS Architecture as follows. 1. IEEE 754-2008 NaN encoding. As many of you have been aware it has been a long pra

Re: [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define

2014-12-08 Thread Gonglei
On 2014/12/8 23:34, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> commit 1773d9ee (virtio-net: cleanup: init and exit function) >> had removed realization of virtio_net_init(), but didn't remove >> the define of head file. Let's remove it. >> >> Signed-off-by: Gonglei > > I get

Re: [Qemu-devel] Providing a mechanism to reopen() file based chardevs

2014-12-08 Thread Tony Breeds
On Mon, Dec 08, 2014 at 09:48:12AM +, Daniel P. Berrange wrote: > My long term desired approach to deal with this problem in OpenStack (and > other libvirt based mgmt apps) is to have a separate log daemon in libvirt > eg a virtlogd daemon. Take QEMU out of the business of writing to files >

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-12-08 Thread Gu Zheng
+cc Gleb, KVM guys, On 12/09/2014 12:38 AM, Peter Maydell wrote: > On 8 December 2014 at 15:38, Igor Mammedov wrote: >> On Mon, 8 Dec 2014 10:50:21 + >> Peter Maydell wrote: >>> Why can't the kernel handle our just destroying the vcpu and >>> later recreating it if necessary? That seems the

[Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-08 Thread Laszlo Ersek
Introduce the new boolean field "arm_boot_info.firmware_loaded". When this field is set, it means that the portion of guest DRAM that the VCPU normally starts to execute, or the pflash chip that the VCPU normally starts to execute, has been populated by board-specific code with full-fledged guest f

[Qemu-devel] [PATCH v3 3/7] fw_cfg: expose the "data_memwidth" prop with fw_cfg_init_data_memwidth()

2014-12-08 Thread Laszlo Ersek
We rebase fw_cfg_init() to the new function for compatibility with current callers. Signed-off-by: Laszlo Ersek --- Notes: v3: - new in v3 [Drew Jones] include/hw/nvram/fw_cfg.h | 3 +++ hw/nvram/fw_cfg.c | 15 +++ 2 files changed, 14 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v3 2/7] fw_cfg: introduce the "data_memwidth" property

2014-12-08 Thread Laszlo Ersek
The "data_memwidth" property is capable of changing the maximum valid access size to the MMIO data register, and (corresponding to the previous patch) resizes the memory region similarly, at device realization time. (Because "data_iomem" is configured and installed dynamically now, we must delay t

[Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_buffer()

2014-12-08 Thread Laszlo Ersek
In the next patch we'd like to reuse the image decompression facility without installing the output as a ROM at a specific guest-phys address. In addition, expose LOAD_IMAGE_MAX_GUNZIP_BYTES, because that's a straightforward "max_sz" argument for the new load_image_gzipped_buffer(). Signed-off-by

[Qemu-devel] [PATCH v3 4/7] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
fw_cfg already supports exposure over MMIO (used in ppc/mac_newworld.c, ppc/mac_oldworld.c, sparc/sun4m.c); we can easily add it to the "virt" board. Because MMIO access is slow on ARM KVM, we enable the guest, with fw_cfg_init_data_memwidth(), to transfer up to 8 bytes with a single access. This

[Qemu-devel] [PATCH v3 7/7] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware

2014-12-08 Thread Laszlo Ersek
The virt board already ensures mutual exclusion between -bios and -pflash unit#0; we only need to set "bootinfo.firmware_loaded", introduced in the previous patch, if either of those options was used to load the guest firmware. Signed-off-by: Laszlo Ersek --- Notes: v3: - unchanged hw/

[Qemu-devel] [PATCH v3 1/7] fw_cfg: max access size and region size are the same for MMIO data reg

2014-12-08 Thread Laszlo Ersek
Make it clear that the maximum access size to the MMIO data register determines the full size of the memory region. Currently the max access size is 1. Ensure that if a larger size were used in "fw_cfg_data_mem_ops.valid.max_access_size", the memory subsystem would split the access to byte-sized a

[Qemu-devel] [PATCH v3 0/7] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt

2014-12-08 Thread Laszlo Ersek
v3 fuses the two earlier patchsets in dependency order, seeks to address Peter's comment (for v2) about the size of the fw_cfg region in the DTB, and strives to implement Drew Jones' idea about the AWAP (as wide as possible) access to the MMIO data register. Changes are mentioned per patch too. T

Re: [Qemu-devel] [PATCH 0/3] hw/arm/virt: boot with -kernel -initrd -append on top of UEFI

2014-12-08 Thread Laszlo Ersek
On 12/05/14 19:55, Peter Maydell wrote: > On 5 December 2014 at 18:36, Laszlo Ersek wrote: >> A number of tools depend on passing the kernel image, the initial >> ramdisk, and the kernel command line to the guest on the QEMU command >> line (options -kernel, -initrd, -append, respectively). At the

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
On 11/30/14 17:59, Laszlo Ersek wrote: > fw_cfg already supports exposure over MMIO (used in ppc/mac_newworld.c, > ppc/mac_oldworld.c, sparc/sun4m.c); we can easily add it to the "virt" > board. > > The mmio register block of fw_cfg is advertized in the device tree. As > base address we pick 0x090

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
On 12/09/14 00:18, Christopher Covington wrote: > Hi Laszlo, > > On 12/08/2014 09:01 AM, Laszlo Ersek wrote: >> On 11/30/14 17:59, Laszlo Ersek wrote: >>> fw_cfg already supports exposure over MMIO (used in ppc/mac_newworld.c, >>> ppc/mac_oldworld.c, sparc/sun4m.c); we can easily add it to the "vi

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 23:18, Christopher Covington wrote: > Just a thought--would it be possible to add a > DMA-the-whole-thing-to-this-address register to the simulated device? That was an idea raised in the 2010 thread that Laszlo mentioned: http://thread.gmane.org/gmane.comp.emulators.qemu/775

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-12-08 Thread Amos Kong
On Wed, Nov 12, 2014 at 11:44:35AM +0200, Michael S. Tsirkin wrote: > This patchset fixes CVE-2014-7840: invalid > migration stream can cause arbitrary qemu memory > overwrite. > First patch includes the minimal fix for the issue. > Follow-up patches on top add extra checking to reduce the > chance

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
On 12/08/14 22:34, Peter Maydell wrote: > On 8 December 2014 at 21:19, Laszlo Ersek wrote: >> So the following in addition makes it work on TCG (x86_64) too: >> >> - >> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c >> index 7147fea..c2bc44c 100644 >> --- a/hw/nvram/fw_cfg.c >>

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Christopher Covington
Hi Laszlo, On 12/08/2014 09:01 AM, Laszlo Ersek wrote: > On 11/30/14 17:59, Laszlo Ersek wrote: >> fw_cfg already supports exposure over MMIO (used in ppc/mac_newworld.c, >> ppc/mac_oldworld.c, sparc/sun4m.c); we can easily add it to the "virt" >> board. >> >> The mmio register block of fw_cfg is

[Qemu-devel] [PATCHv3 5/5] sdhci: Set a default frequency clock

2014-12-08 Thread Kevin O'Connor
The Linux SDHCI PCI driver will only register the device if there is a clock frequency set. So, set a default frequency of 52Mhz. Signed-off-by: Kevin O'Connor --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index d22740b..

[Qemu-devel] [PATCHv3 4/5] sdhci: Support SDHCI devices on PCI

2014-12-08 Thread Kevin O'Connor
Support for PCI devices following the "SD Host Controller Simplified Specification Version 2.00" spec. Signed-off-by: Kevin O'Connor --- default-configs/pci.mak | 2 ++ hw/sd/sdhci.c | 44 hw/sd/sdhci.h | 9 - 3 files cha

[Qemu-devel] [PATCHv3 2/5] sdhci: Add "sysbus" to sdhci QOM types and methods

2014-12-08 Thread Kevin O'Connor
Update the sdhci sysbus QOM types and methods so that sysbus is in their name. This is in preparation for adding PCI versions of these types and methods. Signed-off-by: Kevin O'Connor --- hw/sd/sdhci.c | 39 --- hw/sd/sdhci.h | 6 +++--- 2 files changed, 27

[Qemu-devel] [PATCHv3 1/5] sdhci: Remove class "virtual" methods

2014-12-08 Thread Kevin O'Connor
The SDHCIClass defines a series of class "methods". However, no code in the QEMU tree overrides these methods or even uses them outside of sdhci.c. Remove the virtual methods and replace them with direct calls to the underlying functions. This simplifies the process of extending the sdhci code t

[Qemu-devel] [PATCHv3 3/5] sdhci: Define SDHCI PCI ids

2014-12-08 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- docs/specs/pci-ids.txt | 2 ++ include/hw/pci/pci.h | 1 + include/hw/pci/pci_ids.h | 1 + 3 files changed, 4 insertions(+) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index 3c65e1a..9b57d5e 100644 --- a/docs/specs/pci-ids.txt +++ b/docs/s

[Qemu-devel] [PATCHv3 0/5] Add support for SDHCI PCI devices

2014-12-08 Thread Kevin O'Connor
I'd like to be able to emulate SD cards on x86 machines for testing purposes. This patch series modifies the existing SDHCI code so that it can also be used as a PCI device, and can thus be used on any PCI platform (such as x86). I have done basic sdhci testing of this series with Linux on x86 by

Re: [Qemu-devel] [PATCH 9/9] pc: acpi-build: replace recursive PCI bus tree generation with loop based

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:08PM +, Igor Mammedov wrote: > it replaces PCI tree structure in SSDT with a set of scopes > describing each PCI bus as a separate scope with a child devices. > It makes code easier to follow and a little bit smaller. > > In addition it makes simplier to convert c

Re: [Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:06PM +, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov I'm not sure this makes sense for these constants. Device Check seems more readable than ACPI_DEV_CHK. If your object here is readability, please do not abbreviate. Generally ability to match spec name

Re: [Qemu-devel] mksh on Slackware (was Re: CVS: herc.mirbsd.org: src)

2014-12-08 Thread enh
On Mon, Dec 8, 2014 at 12:49 PM, Thorsten Glaser wrote: > I’ve successfully (modulo the things that just didn’t exist, > or didn’t work with toolbox) run the testsuite on Android > (on the emulator) once, with a native Bionic perl. (AOSP master now has toybox, which should help with this side of

Re: [Qemu-devel] mksh on Slackware (was Re: CVS: herc.mirbsd.org: src)

2014-12-08 Thread enh
On Mon, Dec 8, 2014 at 4:34 AM, Thorsten Glaser wrote: > The image has JOE 0.1.5, some sort of jupp¹-ish editor, > which made me happy. But I’ve got another problem: I can’t > run mksh’s testsuite, whose driver is written in Perl, which > I don’t speak. have you considered using sh instead? :-)

Re: [Qemu-devel] [PATCH 0/9] pc: acpi: various fixes and cleanups

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:07:59PM +, Igor Mammedov wrote: > this series is an early attempt to shave off a bunch of > not directly related patches from already big dynamic > AML series (although it's dependency for it) > > main target of this series is: > > pc: acpi-build: replace recursive

Re: [Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo initialization

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:02PM +, Igor Mammedov wrote: > zero initialize AcpiPmInfo struct to reduce code bloat > a little bit. > > Signed-off-by: Igor Mammedov I generally prefer explicit initialization, but it's a matter of taste. > --- > hw/i386/acpi-build.c | 8 ++-- > 1 file c

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 21:19, Laszlo Ersek wrote: > So the following in addition makes it work on TCG (x86_64) too: > > - > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 7147fea..c2bc44c 100644 > --- a/hw/nvram/fw_cfg.c > +++ b/hw/nvram/fw_cfg.c > @@ -31,7 +31,7 @@ > #

Re: [Qemu-devel] [PATCH 5/9] acpi: move generic aml building helpers into dedictated file

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:04PM +, Igor Mammedov wrote: > the will be later used for composing AML primitives > and all that could be reused later for ARM machines > as well. > > Signed-off-by: Igor Mammedov It will be easy to move when needed. Why do it now? > --- > hw/acpi/Makefile.o

Re: [Qemu-devel] [PATCH 6/9] acpi: add build_append_namestring() helper

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:05PM +, Igor Mammedov wrote: > Use build_append_namestring() instead of build_append_nameseg() > So user won't have to care whether name is NameSeg, NamePath or > NameString. > > See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding > > Signed-off-by: Igor Mamm

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
On 12/08/14 20:39, Laszlo Ersek wrote: > On 12/08/14 15:41, Peter Maydell wrote: >> On 8 December 2014 at 14:01, Laszlo Ersek wrote: >>> Peter, can we introduce a second, 64-bit wide, data register, for >>> fw_cfg? (Or even two -- Drew suggested the LDP instruction for the guest.) >> >> I don't ha

Re: [Qemu-devel] [PATCH 4/9] acpi: build_append_nameseg(): add padding if necessary

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:03PM +, Igor Mammedov wrote: > According to ACPI spec NameSeg shorter than 4 characters > must be padded up to 4 characters with "_" symbol. > ACPI 5.0: 20.2.2 "Name Objects Encoding" > > Do it in build_append_nameseg() so that caller shouldn't know > or care abo

Re: [Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 20:14, Chengyu Song wrote: > Hello Peter, > >> Thanks for sending this patch. I've provided some detailed >> review below -- there are quite a lot of comments but the >> fixes needed are all very minor. > > I'm not very familiar with the CP emulation, especially the NO_MIGRAT

Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:00PM +, Igor Mammedov wrote: > ACPI parser in XP considers PNP0A06 devices of CPU and > memory hotplug as duplicates. Adding unique _UID > to CPU hotplug device fixes BSOD. > > Signed-off-by: Igor Mammedov And let's add them for memory hotplug as well? Also, if

Re: [Qemu-devel] mksh on Slackware (was Re: CVS: herc.mirbsd.org: src)

2014-12-08 Thread Thorsten Glaser
enh dixit: [ mksh testsuite ] >have you considered using sh instead? :-) Not pure sh, that’s nowhere near enough. Maybe mksh. But if the one just built has issues, that may mask it. If another, you’ve got hen/egg problems. Maybe C. But then, (cross-)building a C program to test another one just

Re: [Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-08 Thread Chengyu Song
Hello Peter, > Thanks for sending this patch. I've provided some detailed > review below -- there are quite a lot of comments but the > fixes needed are all very minor. I'm not very familiar with the CP emulation, especially the NO_MIGRATE flag, so thank you very much for the comment. > In this

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
On 12/08/14 15:41, Peter Maydell wrote: > On 8 December 2014 at 14:01, Laszlo Ersek wrote: >> Peter, can we introduce a second, 64-bit wide, data register, for >> fw_cfg? (Or even two -- Drew suggested the LDP instruction for the guest.) > > I don't have an in-principle objection. I do require th

Re: [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:01PM +, Igor Mammedov wrote: > when bridge hotplug is disabled, i.e. for machine > types less then 2.0, bridge device was created as > hotpluggable by mistake since commit 133a2da. > > Fix it by just creating it as a present device. > > Signed-off-by: Igor Mammed

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-08 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 2.0.0+dfsg-2ubuntu1.8 --- qemu (2.0.0+dfsg-2ubuntu1.8) trusty-proposed; urgency=medium * debian/qemu-system-x86.qemu-kvm.upstart: create /dev/kvm in a container. (LP: #1370199) * Cherrypick upstream patch to fix intermittent qemu-img co

[Qemu-devel] [Bug 1368815] Update Released

2014-12-08 Thread Brian Murray
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

[Qemu-devel] Virtualization of TPM in QEMU

2014-12-08 Thread Muhammad Faraz Hyder
Is there anyone who has virtualized the TPM using KVM/QEMU Hypervisor. I am trying to use IBM software TPM and trying to virtualize it to the VMs , but unable to do so. Regards, Faraz

Re: [Qemu-devel] Redundant VDE network

2014-12-08 Thread Dmitry Antipov
On 12/08/2014 08:53 PM, Stefan Hajnoczi wrote: Try: qemu-system-sparc -m 256 \ -netdev vde,sock=/tmp/vde0,id=vde0 \ -device ne2k_pci,netdev=vde0 \ -netdev vde,sock=/tmp/vde1,id=vde1 \ -device ne2k_pci,netdev=vde1 \ -hda vm0.img The is the newer syntax and it should wor

Re: [Qemu-devel] Redundant VDE network

2014-12-08 Thread Stefan Hajnoczi
On Mon, Dec 8, 2014 at 3:00 PM, Dmitry Antipov wrote: > (This is a partial repost from qemu-discuss@ list since I'm suspecting a > bug) > > I'm using QEMU 2.1.1 to emulate SPARC system and have vde network between > two > VMs and host system, organized as shown: > > host >

Re: [Qemu-devel] [PATCH v8 00/19] KVM platform device passthrough

2014-12-08 Thread Eric Auger
On 12/08/2014 06:04 PM, Alex Williamson wrote: > On Sun, 2014-11-30 at 18:35 +, Eric Auger wrote: >> This RFC series aims at enabling KVM platform device passthrough. >> It implements a VFIO platform device, derived from VFIO PCI device. >> >> The VFIO platform device uses the host VFIO platfor

Re: [Qemu-devel] [PATCH v8 00/19] KVM platform device passthrough

2014-12-08 Thread Alex Williamson
On Sun, 2014-11-30 at 18:35 +, Eric Auger wrote: > This RFC series aims at enabling KVM platform device passthrough. > It implements a VFIO platform device, derived from VFIO PCI device. > > The VFIO platform device uses the host VFIO platform driver which must > be bound to the assigned devic

Re: [Qemu-devel] suggestion for the QEMU advent calendar

2014-12-08 Thread Stefan Hajnoczi
On Mon, Dec 8, 2014 at 4:54 PM, Fabian Greffrath wrote: > Am Montag, den 08.12.2014, 11:03 -0500 schrieb John Snow: >> If manually installing a bootable grub sounds gross, [...] > > Actually, this turns out not to be necessary at all. After all, GRUB > Invaders is a multiboot-compliant kernel game

Re: [Qemu-devel] suggestion for the QEMU advent calendar

2014-12-08 Thread Fabian Greffrath
Am Montag, den 08.12.2014, 11:03 -0500 schrieb John Snow: > If manually installing a bootable grub sounds gross, [...] Actually, this turns out not to be necessary at all. After all, GRUB Invaders is a multiboot-compliant kernel game and as such can be loaded directly by means of qemu's -kernel p

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 15:38, Igor Mammedov wrote: > On Mon, 8 Dec 2014 10:50:21 + > Peter Maydell wrote: >> Why can't the kernel handle our just destroying the vcpu and >> later recreating it if necessary? That seems the more logical >> approach than trying to keep fds hanging around in users

Re: [Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-08 Thread Peter Maydell
On 6 December 2014 at 21:01, Chengyu Song wrote: > In AA64 mode, certain system registers are access through MSR/MRS > instructions instead of MCR/MRC. This patch added more such registers: > > /* ARMv8 manual rev A.d, D7.4.10 */ > PMINTENCLR_EL1 > > /* ARMv8 manual rev A.d, D7.4.11 */ > PMINTENSE

[Qemu-devel] [PATCH 9/9] pc: acpi-build: replace recursive PCI bus tree generation with loop based

2014-12-08 Thread Igor Mammedov
it replaces PCI tree structure in SSDT with a set of scopes describing each PCI bus as a separate scope with a child devices. It makes code easier to follow and a little bit smaller. In addition it makes simplier to convert current template patching approach to completely dynamically generated SSD

[Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values

2014-12-08 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 4 ++-- include/hw/acpi/acpi_gen_utils.h | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0f6202d..a33d130 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i38

[Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo initialization

2014-12-08 Thread Igor Mammedov
zero initialize AcpiPmInfo struct to reduce code bloat a little bit. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 1fb92e5..f5ec66a 100644 --- a/hw/i386/acpi-buil

[Qemu-devel] [PATCH 6/9] acpi: add build_append_namestring() helper

2014-12-08 Thread Igor Mammedov
Use build_append_namestring() instead of build_append_nameseg() So user won't have to care whether name is NameSeg, NamePath or NameString. See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding Signed-off-by: Igor Mammedov --- hw/acpi/acpi_gen_utils.c | 86

[Qemu-devel] [PATCH 8/9] acpi: drop min-bytes in build_package()

2014-12-08 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi_gen_utils.c | 14 -- hw/i386/acpi-build.c | 13 ++--- include/hw/acpi/acpi_gen_utils.h | 4 ++-- 3 files changed, 12 insertions(+), 19 deletions(-) diff --git a/hw/acpi/acpi_gen_utils.c b/hw/acpi/acpi_gen_util

[Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable

2014-12-08 Thread Igor Mammedov
when bridge hotplug is disabled, i.e. for machine types less then 2.0, bridge device was created as hotpluggable by mistake since commit 133a2da. Fix it by just creating it as a present device. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PATCH 4/9] acpi: build_append_nameseg(): add padding if necessary

2014-12-08 Thread Igor Mammedov
According to ACPI spec NameSeg shorter than 4 characters must be padded up to 4 characters with "_" symbol. ACPI 5.0: 20.2.2 "Name Objects Encoding" Do it in build_append_nameseg() so that caller shouldn't know or care about it. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 18 ++

[Qemu-devel] [PATCH 5/9] acpi: move generic aml building helpers into dedictated file

2014-12-08 Thread Igor Mammedov
the will be later used for composing AML primitives and all that could be reused later for ARM machines as well. Signed-off-by: Igor Mammedov --- hw/acpi/Makefile.objs| 1 + hw/acpi/acpi_gen_utils.c | 169 +++ hw/i386/acpi-build.c

[Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

2014-12-08 Thread Igor Mammedov
ACPI parser in XP considers PNP0A06 devices of CPU and memory hotplug as duplicates. Adding unique _UID to CPU hotplug device fixes BSOD. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw

[Qemu-devel] [PATCH 0/9] pc: acpi: various fixes and cleanups

2014-12-08 Thread Igor Mammedov
this series is an early attempt to shave off a bunch of not directly related patches from already big dynamic AML series (although it's dependency for it) main target of this series is: pc: acpi-build: replace recursive PCI bus tree generation with loop based A simplified PCI description gen

Re: [Qemu-devel] suggestion for the QEMU advent calendar

2014-12-08 Thread John Snow
On 12/08/2014 10:54 AM, Fabian Greffrath wrote: Am Montag, den 08.12.2014, 10:14 + schrieb Stefan Hajnoczi: If you have the time to create the image yourself, please let me know. I'd love to, but how do I create an image with just GRUB and the game, but no actual OS? - Fabian I wou

Re: [Qemu-devel] [PATCH] vhost-user: multiqueue support

2014-12-08 Thread Eric Blake
On 12/06/2014 09:52 AM, Nikolay Nikolaev wrote: > Vhost-user will implement the multiqueueu support in a similar way to what > vhost already has - a separate thread for each queue. > > To enable multiquue funcionality - a new command line parameter > "queues" is introduced for the vhost-user netde

Re: [Qemu-devel] suggestion for the QEMU advent calendar

2014-12-08 Thread Fabian Greffrath
Am Montag, den 08.12.2014, 10:14 + schrieb Stefan Hajnoczi: > If you have the time to create the image yourself, please let me know. I'd love to, but how do I create an image with just GRUB and the game, but no actual OS? - Fabian

Re: [Qemu-devel] [PATCH] qapi-schema: fix typo about change-vnc-password

2014-12-08 Thread Eric Blake
On 12/08/2014 04:40 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/qapi-schema.json b/qapi-schema.json > index 9ffdcf8..563b4ad 100644 > -

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-12-08 Thread Igor Mammedov
On Mon, 8 Dec 2014 10:50:21 + Peter Maydell wrote: > On 8 December 2014 at 10:28, Gu Zheng wrote: > > Yes, it's a limitation now, but it is not the final implementation. > > As to the QEMU side, the vcpu object in kernel is stateless, and a > > reset operation will be done when we hot add a

Re: [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define

2014-12-08 Thread Markus Armbruster
writes: > From: Gonglei > > commit 1773d9ee (virtio-net: cleanup: init and exit function) > had removed realization of virtio_net_init(), but didn't remove > the define of head file. Let's remove it. > > Signed-off-by: Gonglei I get what you mean by "realization", but the technical term is def

Re: [Qemu-devel] dtb support on x86 machines

2014-12-08 Thread João Henrique Freitas
Hi, Any thoughts? Thanks. On Sun, Nov 30, 2014 at 6:16 PM, João Henrique Ferreira de Freitas wrote: > Hi, > > > I would like to share my work-in-progress about device-tree on qemux x86 > machine. The patch is not fully functional but works as a proof of concept. > It is based on qemu stable-2.1

[Qemu-devel] mksh on Slackware (was Re: CVS: herc.mirbsd.org: src)

2014-12-08 Thread Thorsten Glaser
Hi all! Thanks for this: >Commit ID: 100548597A713CD6746 >CVSROOT: /cvs >Module name: src >Changes by:t...@herc.mirbsd.org2014/12/08 12:20:42 UTC > >Modified files: > bin/mksh : Build.sh > >Log message: >port this to GNU bash 1.12.1 from http://www.qemu-advent-cale

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-08 Thread Markus Armbruster
"Bryan D. Payne" writes: >> >> Actually, it sends it through a UNIX domain socket. Still I/O, just >> different I/O. "Faster" is plausible, but by how much I can't say >> without measurements. "Several orders of magnitude" needs evidence. >> > > I've been testing introspection performance on b

[Qemu-devel] Redundant VDE network

2014-12-08 Thread Dmitry Antipov
(This is a partial repost from qemu-discuss@ list since I'm suspecting a bug) I'm using QEMU 2.1.1 to emulate SPARC system and have vde network between two VMs and host system, organized as shown: host tap0 + 192.168.100.254 + | |

Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server

2014-12-08 Thread Kevin Wolf
Am 08.12.2014 um 14:50 hat Jun Li geschrieben: > On Mon, 12/08 11:07, Kevin Wolf wrote: > > Am 05.12.2014 um 16:32 hat Jun Li geschrieben: > > > Currently, qemu-img can not create qcow2 image format on rbd server. > > > Analysis > > > the code as followings: > > > when create qcow2 format image: >

[Qemu-devel] TCG multithread plan.

2014-12-08 Thread Frederic Konrad
Hi everybody, Here is the plan we will follow: We will be focusing - from the outset - on the end goal of multi-threaded TCG in full system emulation mode. On the way, we expect this will ‘fix’ user mode. The plan is: * Create one cache per CPU as a first step. We can do more next and share a

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 14:41, Peter Maydell wrote: > We also need to make sure it works with TCG QEMU. (64-bit access > to devices is something we've needed previously in ARM QEMU, so > though in theory it should work it would need testing.) "is not something we've needed previously", obviously.

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 14:01, Laszlo Ersek wrote: > Peter, can we introduce a second, 64-bit wide, data register, for > fw_cfg? (Or even two -- Drew suggested the LDP instruction for the guest.) I don't have an in-principle objection. I do require that whatever mechanism we provide is usable by 32

[Qemu-devel] [PATCH v1] [Review Request] RTC Support in e500

2014-12-08 Thread Amit Tomar
I am new to QEMU and tried to provide support for RTC in e500. Please review the following set of patches that would add RTC support in e500 and guide me. Tested it on both x86 and ppc host machines. Signed-off-by: Amit Singh Tomar --- default-configs/ppc-softmmu.mak |2 + default-co

Re: [Qemu-devel] AMD video card passthrough reset issues

2014-12-08 Thread Lucio Andrés Illanes Albornoz
Has there been any progress on this matter?

Re: [Qemu-devel] [PATCH v3] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list()

2014-12-08 Thread Jun Li
Ping, why does this patch has not been merged until now? Could anyone give some explanations? Thx. Regards, Jun Li On Wed, 11/05 15:03, Jun Li wrote: > Currently when *obj is not a TYPE_DEVICE, qemu will abort. This patch just > fixed it. When *obj is not a TYPE_DEVICE, just do not add it to hotp

Re: [Qemu-devel] [PATCH v2] arm: add fw_cfg to "virt" board

2014-12-08 Thread Laszlo Ersek
On 11/30/14 17:59, Laszlo Ersek wrote: > fw_cfg already supports exposure over MMIO (used in ppc/mac_newworld.c, > ppc/mac_oldworld.c, sparc/sun4m.c); we can easily add it to the "virt" > board. > > The mmio register block of fw_cfg is advertized in the device tree. As > base address we pick 0x090

Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server

2014-12-08 Thread Jun Li
On Fri, 12/05 18:01, Max Reitz wrote: > On 2014-12-05 at 16:32, Jun Li wrote: > >Currently, qemu-img can not create qcow2 image format on rbd server. Analysis > >the code as followings: > >when create qcow2 format image: > >qcow2_create2 > > bdrv_create_file(filename, opts, &local_err); --> Here

  1   2   >