Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-12 Thread Markus Armbruster
Eric Blake writes: > On 11/12/2014 11:48 AM, Gary Hook wrote: >> The function uses a ternary return value (<, >, == 0) defined as an >> int. The code in in this function uses int64_t types to collect >> ftell() return values and use their difference as the return >> value. Unfortunately, narrowin

Re: [Qemu-devel] Better Cortex-M support?

2014-11-12 Thread Liviu Ionescu
On 13 Nov 2014, at 02:11, Alistair Francis wrote: > I am trying to model the Netduino Plus 2 (STM32F4xx - Cortex-M4) board... > upstreamed to mainline by using the Netduino 2 board (STM32F2xx - > Cortex-M3). ok, great work! however, I'm more interested in a more systematic approach; before goi

[Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

2014-11-12 Thread Robin Lee
We met the same problem when compiling qemu 2.0.0 on CentOS6, and fixed it with a similar patch to the configure script. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1258168 Title: QEMU fails to b

Re: [Qemu-devel] [PATCH 2/2] spapr: Fix stale HTAB during live migration (TCG)

2014-11-12 Thread Alexey Kardashevskiy
On 11/05/2014 05:17 PM, Samuel Mendoza-Jonas wrote: > If a TCG guest reboots during a running migration HTAB entries are not > marked dirty, and the destination boots with an invalid HTAB. > > When a reboot occurs reset the state of HTAB migration, and explicitly > inform the destination of invali

Re: [Qemu-devel] [PATCH 1/2] spapr: Fix stale HTAB during live migration (KVM)

2014-11-12 Thread Alexey Kardashevskiy
On 11/05/2014 05:17 PM, Samuel Mendoza-Jonas wrote: > If a guest reboots during a running migration, changes to the > hash page table are not necessarily updated on the destination. > Opening a new file descriptor to the HTAB forces the migration > handler to resend the entire table. > > Signed-of

Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian

2014-11-12 Thread Alexey Kardashevskiy
On 11/04/2014 02:10 AM, Alexander Graf wrote: > > > On 03.11.14 15:56, Cedric Le Goater wrote: >> On 11/03/2014 03:53 PM, Alexander Graf wrote: >>> >>> >>> On 27.10.14 11:23, Cédric Le Goater wrote: Currently, when the page tables are saved, the kvm_get_htab_header structs and the ptes

Re: [Qemu-devel] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2014-11-12 Thread Aravinda Prasad
On Thursday 13 November 2014 09:27 AM, David Gibson wrote: > On Tue, Nov 11, 2014 at 12:45:05PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 11 November 2014 08:54 AM, David Gibson wrote: >>> On Wed, Nov 05, 2014 at 12:42:03PM +0530, Aravinda Prasad wrote: This series of patches add sup

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-12 Thread Aravinda Prasad
On Thursday 13 November 2014 09:22 AM, David Gibson wrote: > On Tue, Nov 11, 2014 at 12:14:31PM +0530, Aravinda Prasad wrote: >> On Tuesday 11 November 2014 08:46 AM, David Gibson wrote: >>> On Wed, Nov 05, 2014 at 12:43:15PM +0530, Aravinda Prasad wrote: > [snip] + . = 0x200 + /* >>>

[Qemu-devel] [PATCH] virtio-net: correctly advertise host features

2014-11-12 Thread Jason Wang
We should not advertise the feature that depends on ctrl vq is it was not enabled. And not advertise the VIRTIO_NET_F_CTRL_RX_EXTRA is VIRTIO_NET_F_CTRL_RX is not enabled. Otherwise, this may confuse guest driver and lead unexpected bugs. Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 15 +

Re: [Qemu-devel] dynamic sysbus instantiation and load_dtb implementation

2014-11-12 Thread David Gibson
On Fri, Oct 24, 2014 at 02:38:39PM +0200, David Gibson wrote: > On Thu, Oct 23, 2014 at 01:26:08PM +0200, Alexander Graf wrote: > > > > > > On 23.10.14 13:24, Peter Maydell wrote: > > > On 23 October 2014 12:23, Alexander Graf wrote: > > >> On 23.10.14 12:19, Ard Biesheuvel wrote: > > >>> The re

Re: [Qemu-devel] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2014-11-12 Thread David Gibson
On Tue, Nov 11, 2014 at 12:45:05PM +0530, Aravinda Prasad wrote: > > > On Tuesday 11 November 2014 08:54 AM, David Gibson wrote: > > On Wed, Nov 05, 2014 at 12:42:03PM +0530, Aravinda Prasad wrote: > >> This series of patches add support for fwnmi in powerKVM guests. > >> > >> Currently upon mach

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-12 Thread David Gibson
On Tue, Nov 11, 2014 at 12:14:31PM +0530, Aravinda Prasad wrote: > On Tuesday 11 November 2014 08:46 AM, David Gibson wrote: > > On Wed, Nov 05, 2014 at 12:43:15PM +0530, Aravinda Prasad wrote: [snip] > >> + . = 0x200 > >> + /* > >> + * Trampoline saves r3 in sprg2 and issues private hcall > >>

Re: [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps

2014-11-12 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:49PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Prior to the start of postcopy, ensure that everything that will > be transferred later is a whole host-page in size. > > This is accomplished by discarding partially transferred ho

Re: [Qemu-devel] [PATCH v4 44/47] Postcopy; Handle userfault requests

2014-11-12 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:50PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > userfaultfd is a Linux syscall that gives an fd that receives a stream > of notifications of accesses to pages marked as MADV_USERFAULT, and > allows the program to acknowledge those

Re: [Qemu-devel] [PATCH v4 45/47] Start up a postcopy/listener thread ready for incoming page data

2014-11-12 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:51PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The loading of a device state (during postcopy) may access guest > memory that's still on the source machine and thus might need > a page fill; split off a separate thread that handl

Re: [Qemu-devel] [PATCH v4 41/47] qemu_ram_block_from_host

2014-11-12 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:47PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Postcopy sends RAMBlock names and offsets over the wire (since it can't > rely on the order of ramaddr being the same), and it starts out with > HVA fault addresses from the kernel.

Re: [Qemu-devel] [PATCH v4 42/47] Don't sync dirty bitmaps in postcopy

2014-11-12 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:48PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Once we're in postcopy the source processors are stopped and memory > shouldn't change any more, so there's no need to look at the dirty > map. > > There are two notes to this: >

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-12 Thread Eric Blake
On 11/12/2014 01:27 PM, Markus Armbruster wrote: > Missed in commit 705be72. > > Signed-off-by: Markus Armbruster > --- > block/raw-posix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Eric Blake > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index e100ae

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-12 Thread Eric Blake
On 11/12/2014 01:27 PM, Markus Armbruster wrote: > Commit 5500316 (May 2012) implemented raw_co_is_allocated() as > follows: > > Thus, the FIEMAP code executes rarely. Makes it a nice hidey-hole for > bugs. Worse, bugs hiding there can theoretically bite even on a host > that has SEEK_HOLE/SEEK

[Qemu-devel] [PATCH 2/2] acpi-build: Make DPRINTF working for acpi-build

2014-11-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/i386/acpi-build.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4ab44bf..8cec9aa 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -67,6 +67,14 @

[Qemu-devel] [PATCH 0/2] acpi-build: trivial fixes

2014-11-12 Thread arei.gonglei
From: Gonglei Those two fixes make sence and have no risk for being applied in qemu-2.2 release version. Thanks, Gonglei (2): acpi-build: adjust indention 8 -> 4 spaces acpi-build: Make DPRINTF working for acpi-build hw/i386/acpi-build.c | 22 ++ 1 file changed, 14 ins

[Qemu-devel] [PATCH 1/2] acpi-build: adjust indention 8 -> 4 spaces

2014-11-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4003b6b..4ab44bf 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -272,12 +272,12 @@ build_heade

Re: [Qemu-devel] [PATCH v4 40/47] Postcopy: Use helpers to map pages during migration

2014-11-12 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:46PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In postcopy, the destination guest is running at the same time > as it's receiving pages; as we receive new pages we must put > them into the guests address space atomically to avoid

[Qemu-devel] [PATCH] virtio-bus: avoid breaking build when open DEBUG switch

2014-11-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/virtio/virtio-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c index eb77019..dfd2d8c 100644 --- a/hw/virtio/virtio-bus.c +++ b/hw/virtio/virtio-bus.c @@ -58,7 +58,7 @@ void virt

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-12 Thread Fam Zheng
On Wed, 11/12 20:27, Markus Armbruster wrote: > Commit 5500316 (May 2012) implemented raw_co_is_allocated() as > follows: > > 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl > > 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() > > 3. Else pretend there are no holes > >

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-12 Thread Fam Zheng
On Wed, 11/12 20:27, Markus Armbruster wrote: > Missed in commit 705be72. > > Signed-off-by: Markus Armbruster > --- > block/raw-posix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index e100ae2..706d3c0 100644 > --- a/bloc

[Qemu-devel] [PATCH 6/6] cpu: add device_add foo-x86_64-cpu support

2014-11-12 Thread Gu Zheng
From: Chen Fan Add support to device_add foo-x86_64-cpu, and additional checks of apic id are added into x86_cpuid_set_apic_id() to avoid duplicate. Besides, in order to support "device/device_add foo-x86_64-cpu" which without specified apic id, we assign cpuid_apic_id with a default broadcast va

[Qemu-devel] [PATCH 5/6] acpi:cpu hotplug: set pcmachine as icc bus' hotplug handler

2014-11-12 Thread Gu Zheng
As the pre-check in the qdev_device_add(): if (qdev_hotplug && bus && !qbus_is_hotpluggable(bus)) { qerror_report(QERR_BUS_NO_HOTPLUG, bus->name); return NULL; } if device has parent bus, the bus must have valid hotplug_handler, otherwise can not hot plug. Currently cpu hotp

[Qemu-devel] [PATCH 4/6] monitor: use cc->get_arch_id as the cpu index

2014-11-12 Thread Gu Zheng
Use cc->get_arch_id as the cpu index to avoid the cpu index duplicated issue in the QMP/HMP command output. Signed-off-by: Gu Zheng Signed-off-by: Zhu Guihua --- cpus.c|4 +++- monitor.c |4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 0c

[Qemu-devel] [PATCH 3/6] qom/cpu: move apic vmstate register into x86_cpu_apic_realize

2014-11-12 Thread Gu Zheng
move apic vmstate register into x86_cpu_apic_realize, and use cc->get_arch_id as the instance id to avoid using the auto-id which will break the migration if we add device not in order. Signed-off-by: Gu Zheng Signed-off-by: Zhu Guihua --- hw/intc/apic_common.c |3 +-- include/hw/

[Qemu-devel] [PATCH 2/6] qom/cpu: move register_vmstate to common CPUClass.realizefn

2014-11-12 Thread Gu Zheng
Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, and use cc->get_arch_id as the instance id that suggested by Igor to fix the migration issue. Signed-off-by: Gu Zheng Signed-off-by: Zhu Guihua --- exec.c| 32 +++- include/qom/cpu.

[Qemu-devel] [PATCH 1/6] cpu: introduce CpuTopoInfo structure for argument simplification

2014-11-12 Thread Gu Zheng
From: Chen Fan Reviewed-by: Eduardo Habkost Signed-off-by: Chen Fan Signed-off-by: Gu Zheng Signed-off-by: Zhu Guihua --- target-i386/topology.h | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/top

[Qemu-devel] [PATCH 0/6] cpu: add device_add foo-x86_64-cpu support

2014-11-12 Thread Gu Zheng
This series is based on the previous patchset from Chen Fan: https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html We try to make cpu hotplug with device_add, and make "-device foo-x86_64-cpu" available,also we can set apic-id property with command line, if without setting apic-id

Re: [Qemu-devel] Better Cortex-M support?

2014-11-12 Thread Alistair Francis
On Thu, Nov 13, 2014 at 12:23 AM, Liviu Ionescu wrote: > > On 12 Nov 2014, at 15:51, Peter Maydell wrote: > >> ... I'd suggest looking at Alistair's patches >> on the list for supporting the netduino2, I figure I will fill you in on what I am trying to do, in case it is any help. I am trying to

Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"

2014-11-12 Thread Peter Maydell
On 12 November 2014 22:25, Paolo Bonzini wrote: > The plan was to move [*] down into the devices. Devices that do not > need to arrayify properties (e.g. most qdev-ified devices) can then skip > the [*] and have nicer names. Qdev devices have array properties already via a different mechanism, r

Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 18:14, Andreas Färber wrote: >> > This reverts commit 339659041f87a76f8b71ad3d12cadfc5f89b4bb3. >> > >> > It's been replaced by object_gen_new_property_name(). >> > >> > Signed-off-by: Markus Armbruster >> > --- >> > qom/object.c | 21 - >> > 1 file changed,

Re: [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 20:27, Markus Armbruster wrote: > See PATCH 2/2 for rationale. > > Would you like this included in 2.2? > > Markus Armbruster (2): > raw-posix: Fix comment for raw_co_get_block_status() > raw-posix: SEEK_HOLE suffices, get rid of FIEMAP > > block/raw-posix.c | 132 > +++

[Qemu-devel] [Bug 1391942] [NEW] Unnecessary events option of the trace argument with UST backend

2014-11-12 Thread Francis Deslauriers
Public bug reported: When running configure with the --enable-trace-backends=ust option and compiling. The user should not have to specify a the "events" and "file" options because they are not used with that tracing framework. Right now, in order the use this option the need to specify a dumm

[Qemu-devel] [PATCH v3 4/4] PPC: e500 pci host: Add support for ATMUs

2014-11-12 Thread Alexander Graf
The e500 PCI controller has configurable windows that allow a guest OS to selectively map parts of the PCI bus space to CPU address space and to selectively map parts of the CPU address space for DMA requests into PCI visible address ranges. So far, we've simply assumed that this mapping is 1:1 an

[Qemu-devel] [PATCH v3 0/4] PPC: e500: Support more RAM

2014-11-12 Thread Alexander Graf
The e500 target today only supports 3GB of guest RAM. This can be too little depending on your use case, so this patch set increases that limit to a whopping 48GB! Of course this change is too intrusive for 2.2, so I'm posting this explicitly for 2.3. v1 -> v2: - make pci pio window device tre

[Qemu-devel] [PATCH v3 1/4] PPC: e500: Move CCSR definition to params

2014-11-12 Thread Alexander Graf
We want to have different MMIO region offsets for the mpc8544ds machine and our e500 PV machine, so move the definitions of those into the machine specific params struct. Signed-off-by: Alexander Graf --- v1 -> v2: - make pci pio window device tree exposure dynamic v2 -> v3: - rename the

[Qemu-devel] [PATCH v3 2/4] PPC: e500: Move CCSR and MMIO space to upper end of address space

2014-11-12 Thread Alexander Graf
On e500 we're basically guaranteed to have 36bits of physical address space available for our enjoyment. Older chips (like the mpc8544) only had 32bits, but everything from e500v2 onwards bumped it up. It's reasonably safe to assume that if you're using the PV machine, your guest kernel is configu

[Qemu-devel] [PATCH v3 3/4] PPC: mpc8554ds: Tell user about exceeding RAM limits

2014-11-12 Thread Alexander Graf
The mpc8544ds board only supports up to 3GB of RAM due to its limited address space. When the user requests more, abort and tell him that he should use less. Signed-off-by: Alexander Graf --- hw/ppc/mpc8544ds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/ppc/mpc8544ds.c b/hw/pp

[Qemu-devel] [2.3 V2 PATCH 3/6] target-ppc: mffs. Should Set CR1 from FPSCR Bits

2014-11-12 Thread Tom Musta
Update the Move From FPSCR (mffs.) instruction to correctly set CR[1] from FPSCR[FX,FEX,VX,OX]. Signed-off-by: Tom Musta --- target-ppc/translate.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 2d79e39..f3c57b8 1

[Qemu-devel] [2.3 V2 PATCH 4/6] target-ppc: Fully Migrate to gen_set_cr1_from_fpscr

2014-11-12 Thread Tom Musta
Eliminate the set_rc argument from the gen_compute_fprf utility and the corresponding (and incorrect) implementation. Replace it with calls to the gen_set_cr1_from_fpscr() utility. Signed-off-by: Tom Musta --- target-ppc/translate.c | 55 --- 1 file

[Qemu-devel] [2.3 V2 PATCH 2/6] target-ppc: Fix Floating Point Move Instructions That Set CR1

2014-11-12 Thread Tom Musta
The Floating Point Move instructions (fmr., fabs., fnabs., fneg., and fcpsgn.) incorrectly copy FPSCR[FPCC] instead of [FX,FEX,VX,OX]. Furthermore, the current code does this via a call to gen_compute_fprf, which is awkward since these instructions do not actually set FPRF. Change the code to use

[Qemu-devel] [2.3 V2 PATCH 1/6] target-ppc: VXSQRT Should Not Be Set for NaNs

2014-11-12 Thread Tom Musta
The Power ISA square root instructions (fsqrt[s], frsqrte[s]) must set the FPSCR[VXSQRT] flag when operating on a negative value. However, NaNs have no sign and therefore this flag should not be set when operating on one. Change the order of the checks in the helper code. Move the SNaN-to-QNaN ma

[Qemu-devel] [2.3 V2 PATCH 5/6] target-ppc: Eliminate set_fprf Argument From gen_compute_fprf

2014-11-12 Thread Tom Musta
The set_fprf argument to the gen_compute_fprf() utility is no longer needed -- gen_compute_fprf() is now called only when FPRF is actually computed and set. Eliminate the obsolete argument. Signed-off-by: Tom Musta --- target-ppc/translate.c | 38 +++--- 1 file

[Qemu-devel] [2.3 V2 PATCH 6/6] target-ppc: Eliminate set_fprf Argument From helper_compute_fprf

2014-11-12 Thread Tom Musta
The set_fprf argument to the helper_compute_fprf helper function is no longer necessary -- the helper is only invoked when FPSCR[FPRF] is going to be set. Eliminate the unnecessary argument from the function signature and its corresponding implementation. Change the return value of the helper to

[Qemu-devel] [2.3 V2 PATCH 0/6] target-ppc: Assorted Floating Point Bugs and Cleanup

2014-11-12 Thread Tom Musta
This patch series corrects some issues with floating point emulation on Power. Patch 1 corrects a corner case in the square root instructions, which incorrectly react to NaN whose sign bit is a 1. Patches 2-6 correct a rather pervasive problem with modeling of the CR[1] field (i.e. the "dot form"

Re: [Qemu-devel] [Crash-utility] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Dave Anderson
- Original Message - > > Can you fetch that in "crash"? If you can, then there's nothing to do on > > the qemu side (and I'll have to apologize for spamming a bunch of lists > > :/). Well, let's be clear -- I was the one who put you up to it... But no apology is required -- and in fact

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Petr Tesarik
On Wed, 12 Nov 2014 21:30:20 +0100 Laszlo Ersek wrote: > adding back a few CC's because this discussion is useful > > On 11/12/14 19:43, Petr Tesarik wrote: > > V Wed, 12 Nov 2014 15:50:32 +0100 > > Laszlo Ersek napsáno: > > > >> On 11/12/14 09:04, Petr Tesarik wrote: > >>> On Wed, 12 Nov 2014

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Petr Tesarik
On Wed, 12 Nov 2014 10:43:59 -0500 Christopher Covington wrote: > On 11/12/2014 10:03 AM, Laszlo Ersek wrote: > > On 11/12/14 15:48, Christopher Covington wrote: > >> Thanks Petr and Laszlo for entertaining my questions. I've got one last > >> one if > >> you have the time. > >> > >> On 11/12/20

Re: [Qemu-devel] [PATCH v4 14/21] target-mips: add AUI, LSA and PCREL instruction families

2014-11-12 Thread Paolo Bonzini
On 08/10/2014 12:55, Leon Alrae wrote: > case OPC_LUI: > -tcg_gen_movi_tl(cpu_gpr[rt], imm << 16); > -MIPS_DEBUG("lui %s, " TARGET_FMT_lx, regnames[rt], uimm); > +if (rs != 0 && (ctx->insn_flags & ISA_MIPS32R6)) { > +/* OPC_AUI */ > +tcg_gen_ad

Re: [Qemu-devel] [PATCH v3 1/2] blkdebug: Simplify and improve filename generation

2014-11-12 Thread Eric Blake
On 11/11/2014 02:23 AM, Max Reitz wrote: > Instead of actually recreating the options from scratch, just reuse the > options given for creating the BDS, which are the configuration file > name and additional options. In case there are no additional options we > can thus create a plain filename. >

Re: [Qemu-devel] [PATCH v3 2/2] iotests: Plain blkdebug filename generation

2014-11-12 Thread Eric Blake
On 11/11/2014 02:23 AM, Max Reitz wrote: > Add one test whether blkdebug is able to generate a plain filename if > given a configuration file and a file to be tested only; and add another > test whether blkdebug is able to do the same without being given a > configuration file. > > Signed-off-by:

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Dave Anderson
- Original Message - > adding back a few CC's because this discussion is useful > > On 11/12/14 19:43, Petr Tesarik wrote: > > V Wed, 12 Nov 2014 15:50:32 +0100 > > Laszlo Ersek napsáno: > > > >> On 11/12/14 09:04, Petr Tesarik wrote: > >>> On Wed, 12 Nov 2014 12:08:38 +0900 (JST) > >>

Re: [Qemu-devel] [PATCH v2 1/5] block/qapi: Add cache information to query-block

2014-11-12 Thread Eric Blake
On 11/12/2014 09:11 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 7 +++ > hmp.c | 8 > qapi/block-core.json | 20 +++- > tests/qemu-iotests/051.out | 1 + > tests/qemu-iotests/067.out | 10 +--

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Laszlo Ersek
adding back a few CC's because this discussion is useful On 11/12/14 19:43, Petr Tesarik wrote: > V Wed, 12 Nov 2014 15:50:32 +0100 > Laszlo Ersek napsáno: > >> On 11/12/14 09:04, Petr Tesarik wrote: >>> On Wed, 12 Nov 2014 12:08:38 +0900 (JST) >>> HATAYAMA Daisuke wrote: >> Anyway, phys_b

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-12 Thread Eric Blake
On 11/12/2014 11:48 AM, Gary Hook wrote: > The function uses a ternary return value (<, >, == 0) defined as an int. The > code in in this function uses int64_t types to collect ftell() return values > and use their difference as the return value. Unfortunately, narrowing of > integer types resul

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Eric Blake
On 11/12/2014 10:45 AM, Max Reitz wrote: > On 2014-11-12 at 15:21, Max Reitz wrote: >> On 2014-11-12 at 15:19, Eric Blake wrote: >>> On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. >>> A thoug

[Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-12 Thread Markus Armbruster
Commit 5500316 (May 2012) implemented raw_co_is_allocated() as follows: 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() 3. Else pretend there are no holes Later on, raw_co_is_allocated() was generalized to raw_co_get_blo

[Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-12 Thread Markus Armbruster
Missed in commit 705be72. Signed-off-by: Markus Armbruster --- block/raw-posix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index e100ae2..706d3c0 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1555,9 +1555,7 @@ static

[Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP

2014-11-12 Thread Markus Armbruster
See PATCH 2/2 for rationale. Would you like this included in 2.2? Markus Armbruster (2): raw-posix: Fix comment for raw_co_get_block_status() raw-posix: SEEK_HOLE suffices, get rid of FIEMAP block/raw-posix.c | 132 -- 1 file changed, 48 i

[Qemu-devel] runtime configurable semihosting

2014-11-12 Thread Liviu Ionescu
> semihosting ... be runtime configurable on this, I think. I took a quick look at the syntax of command options and monitor commands, and I would suggest the following: - extend the option "-semihosting" with an optional "target=native|gdb|auto", default auto - if necessary, add a monitor co

Re: [Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-11-12 Thread Maciej W. Rozycki
On Wed, 12 Nov 2014, Peter Maydell wrote: > > @@ -208,12 +206,12 @@ int cpu_load(QEMUFile *f, void *opaque, > > MIPSCPU *cpu = mips_env_get_cpu(env); > > int i; > > > > -if (version_id < 3) { > > +if (version_id != CPU_SAVE_VERSION) { > > return -EINVAL; > > } > >

[Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-12 Thread Gary Hook
The function uses a ternary return value (<, >, == 0) defined as an int. The code in in this function uses int64_t types to collect ftell() return values and use their difference as the return value. Unfortunately, narrowing of integer types results in the disposal of the left-most bits that won

[Qemu-devel] [PATCH 0/1] block migration: fix return value mismatch

2014-11-12 Thread Gary Hook
This patch rectifies the mismatch between the expected return value of block_save iterate() and the errant computation within the function.

Re: [Qemu-devel] [PATCH] mips: Fix the 64-bit case for microMIPS MOVE16 and MOVEP

2014-11-12 Thread Maciej W. Rozycki
On Wed, 12 Nov 2014, Andreas Färber wrote: > Please consistently use "target-mips: " when that's what you're > touching. (For hw/mips/ it's less consistent what to use.) Sure. What about MIPS changes that span files contained within target-mips/ and elsewhere? I have such changes in my queue.

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-12 Thread Pawel Moll
On Wed, 2014-11-12 at 08:32 +, Shannon Zhao wrote: > On 2014/11/11 23:11, Pawel Moll wrote: > > On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: > >> As the current virtio-mmio only support single irq, > >> so some advanced features such as vhost-net with irqfd > >> are not supported. And

Re: [Qemu-devel] [PATCH] mips: Fix the 64-bit case for microMIPS MOVE16 and MOVEP

2014-11-12 Thread Andreas Färber
Hi Maciej, Please consistently use "target-mips: " when that's what you're touching. (For hw/mips/ it's less consistent what to use.) Leon, please sanitize subjects before sending them out, it makes them easier to skim in git-log and cgit. Thanks, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 904

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Peter Maydell
On 12 November 2014 09:08, Claudio Fontana wrote: > As mentioned by others, I'd rather see an implementation of ACPI in QEMU which > learns from the experience of X86 (and possibly shares some code if possible), > rather than going in a different direction by creating device trees first, > and the

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread Stefano Stabellini
On Wed, 12 Nov 2014, Roger Pau Monne wrote: > This patch fixes two issues with persistent grants and the disk PV backend > (Qdisk): > > - Don't use batch mappings when using persistent grants, doing so prevents >unmapping single grants (the whole area has to be unmapped at once). The real is

Re: [Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-11-12 Thread Peter Maydell
On 12 November 2014 16:07, Maciej W. Rozycki wrote: > Fix the FP state save/restore operations by saving the `flush_to_zero' > rather than the `float_detect_tininess' setting. There is no provision > for the latter in MIPS hardware, whereas the former is controlled by the > CP1.FCSR.FS bit. As a

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Max Reitz
On 2014-11-12 at 15:21, Max Reitz wrote: On 2014-11-12 at 15:19, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Peter Maydell
On 12 November 2014 16:25, Paolo Bonzini wrote: > On 12/11/2014 17:13, Arnd Bergmann wrote: >> > Same as real hardware. Firmware (SeaBIOS or OVMF) builds the memory >> > map, decides where in the free space the BARs go, and programs the PCI >> > devices accordingly. >> > >> > kvmtool is the speci

Re: [Qemu-devel] [PATCH for-xen-4.5] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread Konrad Rzeszutek Wilk
On Wed, Nov 12, 2014 at 03:55:51PM +, George Dunlap wrote: > On 11/12/2014 03:45 PM, Roger Pau Monne wrote: > >This patch fixes two issues with persistent grants and the disk PV backend > >(Qdisk): > > > > - Don't use batch mappings when using persistent grants, doing so prevents > >unmapp

Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"

2014-11-12 Thread Andreas Färber
Am 12.11.2014 um 18:08 schrieb Markus Armbruster: > This reverts commit 339659041f87a76f8b71ad3d12cadfc5f89b4bb3. > > It's been replaced by object_gen_new_property_name(). > > Signed-off-by: Markus Armbruster > --- > qom/object.c | 21 - > 1 file changed, 21 deletions(-) Ac

Re: [Qemu-devel] [PATCH 0/4] qom: Replace "automatic arrayification"

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 18:08, Markus Armbruster wrote: > "Automatic arrayification" is a convenience feature for creating a > bunch of properties with a common type, accessors and so forth, named > in a peculiar way: "foo[0]", "foo[1]", ... It's implemented by making > property names ending with "[*]" ma

[Qemu-devel] [PATCH 3/4] qdev: Use object_gen_new_property_name() instead of "arrayification"

2014-11-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/core/qdev.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 413b413..53d1e25 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -376,17 +376,19 @@ void qdev_init_gpio_in_named(De

[Qemu-devel] [PATCH 0/4] qom: Replace "automatic arrayification"

2014-11-12 Thread Markus Armbruster
"Automatic arrayification" is a convenience feature for creating a bunch of properties with a common type, accessors and so forth, named in a peculiar way: "foo[0]", "foo[1]", ... It's implemented by making property names ending with "[*]" magical. The magic is uncalled for, as names can be just

[Qemu-devel] [PATCH 2/4] memory: Use object_gen_new_property_name() instead of "arrayification"

2014-11-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/memory.c b/memory.c index 0f4fdc7..b65c785 100644 --- a/memory.c +++ b/memory.c @@ -894,10 +894,10 @@ void memory_region_init(MemoryRegion *mr, if (name) { char

[Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"

2014-11-12 Thread Markus Armbruster
This reverts commit 339659041f87a76f8b71ad3d12cadfc5f89b4bb3. It's been replaced by object_gen_new_property_name(). Signed-off-by: Markus Armbruster --- qom/object.c | 21 - 1 file changed, 21 deletions(-) diff --git a/qom/object.c b/qom/object.c index 4c46662..2aed3de 1006

[Qemu-devel] [PATCH 1/4] qom: New object_gen_new_property_name()

2014-11-12 Thread Markus Armbruster
The next few commits will use it to replace object_property_add()'s "automatic arrayification" (commit 3396590). "Automatic arrayification" is a convenience feature for creating a bunch of properties with a common type, accessors and so forth, named in a peculiar way: "foo[0]", "foo[1]", ... It's

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 17:13, Arnd Bergmann wrote: > > Same as real hardware. Firmware (SeaBIOS or OVMF) builds the memory > > map, decides where in the free space the BARs go, and programs the PCI > > devices accordingly. > > > > kvmtool is the special one here. Xen, VMware, Hyper-V all do the same >

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Arnd Bergmann
On Wednesday 12 November 2014 17:04:30 Paolo Bonzini wrote: > On 12/11/2014 16:57, Arnd Bergmann wrote: > > > > It seems to me like complicated stuff like that definitely belongs > > > > in the UEFI/bootloader blob, though. I'd rather QEMU just modelled > > > > the hardware and let the guest (or th

[Qemu-devel] [PATCH v2 3/5] block/hmp: Allow info = NULL in print_block_info()

2014-11-12 Thread Kevin Wolf
This allows printing infos of BlockDriverStates that aren't at the root of the graph (and logically implementing a BlockBackend). Signed-off-by: Kevin Wolf --- hmp.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/hmp.c b/hmp.c index 0eba50

[Qemu-devel] [PATCH v2 2/5] block/hmp: Factor out print_block_info()

2014-11-12 Thread Kevin Wolf
The new function prints the info for a single BlockDriverState. Signed-off-by: Kevin Wolf --- hmp.c | 192 +- 1 file changed, 97 insertions(+), 95 deletions(-) diff --git a/hmp.c b/hmp.c index 10f383b..0eba501 100644 --- a/hmp.c ++

[Qemu-devel] [PATCH v2 5/5] monitor: Fix HMP tab completion

2014-11-12 Thread Kevin Wolf
Commands with multiple boolean flag options (like 'info block') didn't provide correct completion because only the first one was skipped. Signed-off-by: Kevin Wolf --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 3e7c640..e3219e0 10064

[Qemu-devel] [PATCH v2 1/5] block/qapi: Add cache information to query-block

2014-11-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qapi.c | 7 +++ hmp.c | 8 qapi/block-core.json | 20 +++- tests/qemu-iotests/051.out | 1 + tests/qemu-iotests/067.out | 10 +- 5 files changed, 40 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v2 4/5] block/hmp: Allow node-name in 'info block'

2014-11-12 Thread Kevin Wolf
The optional parameter specifying a block device allows now to use a node-name instead of a drive name (and therefore to inspect any node in the graph). The new -n options allows listing all named nodes instead of BlockBackends. Signed-off-by: Kevin Wolf --- hmp.c | 31 ++

[Qemu-devel] [PATCH v2 0/5] block: QMP cache info and HMP node support

2014-11-12 Thread Kevin Wolf
This was supposed to be the first part of a series allowing to override the cache mode for backing files, and more specifically to support the test cases for that series. However, this work turned out to be a bit more complicated than I had hoped, and the query improvement is nice to have on its o

[Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-11-12 Thread Maciej W. Rozycki
Fix the FP state save/restore operations by saving the `flush_to_zero' rather than the `float_detect_tininess' setting. There is no provision for the latter in MIPS hardware, whereas the former is controlled by the CP1.FCSR.FS bit. As a result all the older saved state images are invalid as t

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 16:57, Arnd Bergmann wrote: > > > It seems to me like complicated stuff like that definitely belongs > > > in the UEFI/bootloader blob, though. I'd rather QEMU just modelled > > > the hardware and let the guest (or the firmware, which is guest > > > code from QEMU's point of view) s

Re: [Qemu-devel] State of ARM FIQ in Qemu

2014-11-12 Thread Greg Bellows
On 12 November 2014 07:56, Tim Sander wrote: > Hi Greg > > > > Bad mode in data abort handler detected > > > Internal error: Oops - bad mode: 0 [#1] PREEMPT SMP ARM > > > Modules linked in: firq(O) ipv6 > > > CPU: 0 PID: 103 Comm: systemd-udevd Tainted: G O 3.14.0 #1 > > > task: bf2b930

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Arnd Bergmann
On Wednesday 12 November 2014 16:52:25 Paolo Bonzini wrote: > On 12/11/2014 16:39, Peter Maydell wrote: > > > Definitely, I think having the OS manually program the BARs only makes > > > sense > > > in an environment where you don't have a full-featured boot loader or you > > > don't trust it. In

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread George Dunlap
On 11/12/2014 03:45 PM, Roger Pau Monne wrote: This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Don't use batch mappings when using persistent grants, doing so prevents unmapping single grants (the whole area has to be unmapped at once). - Unmap persi

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 16:39, Peter Maydell wrote: > > Definitely, I think having the OS manually program the BARs only makes sense > > in an environment where you don't have a full-featured boot loader or you > > don't trust it. In servers and virtual machines, the PCI bus should always > > come > > ful

[Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread Roger Pau Monne
This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Don't use batch mappings when using persistent grants, doing so prevents unmapping single grants (the whole area has to be unmapped at once). - Unmap persistent grants before switching to the closed state, s

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Christopher Covington
On 11/12/2014 10:03 AM, Laszlo Ersek wrote: > On 11/12/14 15:48, Christopher Covington wrote: >> Thanks Petr and Laszlo for entertaining my questions. I've got one last one >> if >> you have the time. >> >> On 11/12/2014 09:10 AM, Laszlo Ersek wrote: >>> On 11/12/14 14:26, Petr Tesarik wrote:

  1   2   3   >