Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-10-29 Thread Wangting (Kathy)
> On Tue, 2014-02-18 at 13:11 -0800, Nicholas A. Bellinger wrote: >> On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote: >> > On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: >> > >> > >> > >> > > > > > Hi Yan, >> > > > > > >> > > > > > So recently I've been doing som

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-10-29 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 2.1+dfsg-4ubuntu7 --- qemu (2.1+dfsg-4ubuntu7) vivid; urgency=medium * Apply two patches to fix intermittent qemu-img corruption (LP: #1368815) - 501-block-raw-posix-fix-disk-corruption-in-try-fiemap - 502-block-raw-posic-use-seek

[Qemu-devel] [PATCH] Add bootloader name to multiboot implementation

2014-10-29 Thread Drew DeVault
The name is set to "qemu". Signed-off-by: Drew DeVault --- For the future, it may be useful to add a command line flag for setting this to some user-specified value. I also considered naming it "qemu-system-i386" or "qemu-system-x86_64" (as appropriate), but couldn't find an easy way to get those

[Qemu-devel] [PATCH v2] dump: fix use-after-free for s->fd

2014-10-29 Thread arei.gonglei
From: Gonglei After commit 4c7e251a (), when dump memory completed, the s->fd will be closed twice. We should return directly when dump completed. Using do/while block, make the badly chosen return values of get_next_block() more visible and fix this issue. Signed-off-by: Gonglei --- v2 -> v1:

Re: [Qemu-devel] [PATCH] virtio-serial: avoid crash when port has no name

2014-10-29 Thread Amit Shah
On (Wed) 29 Oct 2014 [17:32:27], Marc-André Lureau wrote: > It seems "name" is not mandatory, and the following command line (based > on one generated by current libvirt) will crash qemu at start: > > qemu-system-x86_64 \ > -device virtio-serial-pci \ > -device virtserialport,name=foo \ >

[Qemu-devel] [PATCH v6 10/10] qemu-iotests: Add tests for drive-backup sync=dirty-bitmap

2014-10-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/056| 33 ++--- tests/qemu-iotests/056.out| 4 ++-- tests/qemu-iotests/iotests.py | 8 3 files changed, 40 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/056 b/tests/qemu-iotests/056

[Qemu-devel] [PATCH v6 09/10] qmp: Add dirty bitmap 'enabled' field in query-block

2014-10-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index e574faa..f4d145c 100644 --- a/block.c +++ b/block.c @@ -5375,6 +5375,7 @@ BlockDirtyInfoList *bdrv_query_dirty_bitmaps(Bl

[Qemu-devel] [PATCH v6 08/10] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}

2014-10-29 Thread Fam Zheng
This adds three qmp commands to transactions. Users can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. Signed-off-by: Fam Zheng --- blockdev.c | 92 +

[Qemu-devel] [PATCH v6 05/10] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap

2014-10-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block.c | 26 +- include/block/block.h | 4 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 1b12541..39381cd 100644 --- a/block.c +++ b/block.c @@ -53,6 +53,8 @@ struct BdrvDirtyBitm

[Qemu-devel] [PATCH v6 07/10] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2014-10-29 Thread Fam Zheng
For "dirty-bitmap" sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of "top" sync mode. There are two bitmap use modes for sync=dirty-bitmap: - reset: backup

[Qemu-devel] [PATCH v6 04/10] hbitmap: Add hbitmap_copy

2014-10-29 Thread Fam Zheng
This makes a deep copy of an HBitmap. Signed-off-by: Fam Zheng --- include/qemu/hbitmap.h | 8 util/hbitmap.c | 16 2 files changed, 24 insertions(+) diff --git a/include/qemu/hbitmap.h b/include/qemu/hbitmap.h index 550d7ce..b645cfc 100644 --- a/include/qemu/

[Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2014-10-29 Thread Fam Zheng
The new command pair is added to manage user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. Signed-off-by: Fam Zheng --- blockdev.c | 55 +

[Qemu-devel] [PATCH v6 06/10] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2014-10-29 Thread Fam Zheng
This allows to put the dirty bitmap into a disabled state where no more writes will be tracked. It will be used before backup or writing to persistent file. Signed-off-by: Fam Zheng --- block.c | 15 +++ blockdev.c| 42 ++

[Qemu-devel] [PATCH v6 03/10] block: Introduce bdrv_dirty_bitmap_granularity()

2014-10-29 Thread Fam Zheng
This returns the granularity (in sectors) of dirty bitmap. Signed-off-by: Fam Zheng Reviewed-by: Benoit Canet --- block.c | 6 ++ include/block/block.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/block.c b/block.c index dafde4b..1b12541 100644 --- a/block.c +++ b/bl

[Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-10-29 Thread Fam Zheng
v6: Rebased v4 of the series on top of qemu.git. (skipping v5 since it was used by me as a private sending, for those who received it, the code is the same :) This is the in memory part of the incremental backup feature. With the added commands, we can create a bitmap on a block backend,

[Qemu-devel] [PATCH v6 01/10] qapi: Add optional field "name" to block dirty bitmap

2014-10-29 Thread Fam Zheng
This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented bdrv_find_dirty_bi

Re: [Qemu-devel] [PATCH 5/5] target-tricore: Add instructions of RC opcode format

2014-10-29 Thread Richard Henderson
On 10/29/2014 06:22 AM, Bastian Koppelmann wrote: > +} else if (shift_count > 0) { > +low = tcg_temp_new(); > +high = tcg_temp_new(); > + > +tcg_gen_andi_tl(low, r1, 0x); > +tcg_gen_andi_tl(high, r1, 0x); > +tcg_gen_shli_tl(low, low, shift_cou

Re: [Qemu-devel] [PATCH 4/5] target-tricore: Add instructions of BRR opcode format

2014-10-29 Thread Richard Henderson
On 10/29/2014 06:22 AM, Bastian Koppelmann wrote: > +case OPCM_32_BRR_LOOP: > +if (MASK_OP_BRR_OP2(ctx->opcode) == OPC2_32_BRR_LOOP) { > +gen_loop(ctx, r1, offset * 2); > +} else { > +gen_save_pc(ctx->pc + offset * 2); > +} gen_goto_tb. Also wor

[Qemu-devel] [PATCH] target-tricore: check return value before using it

2014-10-29 Thread zhanghailiang
We reference the return value of cpu before checking whether it is NULL, The checking code is after that which violates code style. It makes no difference if the cpu is NULL, qemu process will terminate. But one will be 'Segmentation fault' and the other will report a error which is what we want.

Re: [Qemu-devel] [PATCH 3/5] target-tricore: Add instructions of BRN opcode format

2014-10-29 Thread Richard Henderson
On 10/29/2014 06:22 AM, Bastian Koppelmann wrote: > +if (MASK_OP_BRN_OP2(ctx->opcode) == OPC2_32_BRN_JNZ_T) { > +tcg_gen_brcondi_tl(TCG_COND_NE, temp, 0, l1); > +} else { > +tcg_gen_brcondi_tl(TCG_COND_EQ, temp, 0, l1); > +} > +gen_goto_tb(ctx

Re: [Qemu-devel] [PATCH 2/5] target-tricore: Add instructions of BRC opcode format

2014-10-29 Thread Richard Henderson
On 10/29/2014 06:22 AM, Bastian Koppelmann wrote: > Add instructions of BRC opcode format. > Fixed OP2_BRC_JGE -> OP2_32_BRC_JGE. > > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 53 > +++- > target-tricore/tricore-opcodes.h |

Re: [Qemu-devel] [PATCH 1/5] target-tricore: Add instructions of BOL opcode format

2014-10-29 Thread Richard Henderson
On 10/29/2014 06:22 AM, Bastian Koppelmann wrote: > Add instructions of BOL opcode format. > > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 48 > > target-tricore/tricore-opcodes.h | 4 +++- > 2 files changed, 51 insertio

Re: [Qemu-devel] [PATCH 1/5] target-tricore: Add instructions of BOL opcode format

2014-10-29 Thread Richard Henderson
On 10/29/2014 06:22 AM, Bastian Koppelmann wrote: > Add instructions of BOL opcode format. > > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 48 > > target-tricore/tricore-opcodes.h | 4 +++- > 2 files changed, 51 insertio

Re: [Qemu-devel] [PATCH] dump: fix use-after-free for s->fd

2014-10-29 Thread Gonglei
On 2014/10/29 23:00, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> After commit 4c7e251a (), when dump memory completed, >> the s->fd will be closed twice. We should return >> directly when dump completed. >> >> Signed-off-by: Gonglei >> --- >> dump.c | 1 + >> 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 11/20] target-mips: add MSA I5 format instruction

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > +uint8_t df = (ctx->opcode >> 21) & 0x3; > +int64_t s5 = (ctx->opcode >> 16) & 0x1f; > +s5 = (s5 << 59) >> 59; /* sign extend s5 to 64 bits*/ Mixed declarations and code are not allowed. This issue occurs also in subsequent patches (12, 15, 17, 1

Re: [Qemu-devel] [PATCH v2 11/20] target-mips: add MSA I5 format instruction

2014-10-29 Thread James Hogan
Hi Yongbok, On Wed, Oct 29, 2014 at 01:41:59AM +, Yongbok Kim wrote: > +DEF_HELPER_5(msa_addvi_df, void, env, i32, i32, i32, s64) > +DEF_HELPER_5(msa_ceqi_df, void, env, i32, i32, i32, s64) > +DEF_HELPER_5(msa_clei_s_df, void, env, i32, i32, i32, s64) > +DEF_HELPER_5(msa_clei_u_df, void, env,

Re: [Qemu-devel] [PATCH v2 08/20] target-mips: add msa_helper.c

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > add msa_helper.c > > Signed-off-by: Yongbok Kim > --- > target-mips/Makefile.objs |2 +- > target-mips/msa_helper.c | 49 > + > 2 files changed, 50 insertions(+), 1 deletions(-) > create mode 100644 targ

Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > > Signed-off-by: Yongbok Kim > --- > target-mips/op_helper.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > index 7cbf4cf..e878442 100644 > --- a/target-mips/op_helpe

Re: [Qemu-devel] [PATCH v2 03/20] target-mips: remove duplicated mips/ieee mapping function

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > > Signed-off-by: Yongbok Kim > --- > target-mips/cpu.h |4 > target-mips/gdbstub.c |7 --- > target-mips/op_helper.c |4 ++-- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/target-mips/cpu.h b/target-mips/

[Qemu-devel] Bug in recent postcopy patch

2014-10-29 Thread Gary Hook
*Knock* *knock* *knock* Is this thing on? I applied the 47 pieces of the recent postcopy patch to 2.1.2 and am poking around. An attempt to migrate results in a NULL pointer dereference in savevm.c. Here is info from gdb: Most of qemu_savevm_state_pending() succeeds, until it gets to the end. He

Re: [Qemu-devel] [PATCH] iscsi: Refuse to open as writable if the LUN is write protected

2014-10-29 Thread Peter Lieven
Am 29.10.2014 um 19:28 schrieb Paolo Bonzini : > On 10/29/2014 05:18 PM, Peter Lieven wrote: >> Am 29.10.2014 um 14:31 schrieb Paolo Bonzini: >>> >>> On 10/29/2014 02:13 PM, Fam Zheng wrote: Before, when a write protected iSCSI target is attached as scsi-disk with BDRV_O_RDWR, we repor

Re: [Qemu-devel] [PATCH v3 5/6] target-i386: Don't enable nested VMX by default

2014-10-29 Thread Eduardo Habkost
On Wed, Oct 29, 2014 at 06:40:48PM +0100, Andreas Färber wrote: > Am 03.10.2014 um 21:39 schrieb Eduardo Habkost: > > TCG doesn't support VMX, and nested VMX is not enabled by default on the > > KVM kernel module. > > > > So, there's no reason to have VMX enabled by default on the core2duo and > >

Re: [Qemu-devel] Timer list lock contention

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 06:04 PM, Sergey Fedorov wrote: > Hi! > > I am wondering is there any case when timer list lock could be under > contention? Most of the time, the timer list is accessed under the "big QEMU lock" (qemu_mutex_lock_iothread/qemu_mutext_unlock_iothread), so the timer list lock itself

Re: [Qemu-devel] [PATCH] iscsi: Refuse to open as writable if the LUN is write protected

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 05:18 PM, Peter Lieven wrote: > Am 29.10.2014 um 14:31 schrieb Paolo Bonzini: >> >> On 10/29/2014 02:13 PM, Fam Zheng wrote: >>> Before, when a write protected iSCSI target is attached as scsi-disk >>> with BDRV_O_RDWR, we report it as writable, while in fact all writes >>> will fail.

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 05:37 PM, Liviu Ionescu wrote: >> > I mean that writes to ROM or flash via gdb should modify the ROM >> > directly, unlike writes by the CPU. > you may be right, but I don't see the point related to semihosting, in this > case the BRKs are permanent in flash. It's not, it's just s

Re: [Qemu-devel] [PATCH 00/17] RFC: userfault v2

2014-10-29 Thread Peter Maydell
On 29 October 2014 17:46, Andrea Arcangeli wrote: > After some chat during the KVMForum I've been already thinking it > could be beneficial for some usage to give userland the information > about the fault being read or write ...I wonder if that would let us replace the current nasty mess we use

Re: [Qemu-devel] [PATCH 00/17] RFC: userfault v2

2014-10-29 Thread Andrea Arcangeli
Hi Zhanghailiang, On Mon, Oct 27, 2014 at 05:32:51PM +0800, zhanghailiang wrote: > Hi Andrea, > > Thanks for your hard work on userfault;) > > This is really a useful API. > > I want to confirm a question: > Can we support distinguishing between writing and reading memory for > userfault? > Th

Re: [Qemu-devel] [PATCH v3 5/6] target-i386: Don't enable nested VMX by default

2014-10-29 Thread Andreas Färber
Am 03.10.2014 um 21:39 schrieb Eduardo Habkost: > TCG doesn't support VMX, and nested VMX is not enabled by default on the > KVM kernel module. > > So, there's no reason to have VMX enabled by default on the core2duo and > coreduo CPU models, today. Even the newer Intel CPU model definitions > don

[Qemu-devel] [PATCH 1/1] get_maintainer.pl: Add 'THE REST'

2014-10-29 Thread Don Slutz
For an example of how this might look: k=50;i=0;for sha in $(git log --no-merges --format=format:"%h" -$k);do let i=$i+1 git show $sha >/tmp/a clear echo $i head -20 /tmp/a echo echo echo to: ./scripts/get_maintainer.pl --no-git-fallback --no-m /tmp/a echo echo cc: ./scripts/get_mainta

[Qemu-devel] [Bug 1379340] Re: qemu-kvm guest panic for AMD smp trusty guests

2014-10-29 Thread Serge Hallyn
Thanks for reporting this bug. Would it be possible for you to test with the daily upstream kernel builds, to rule out any temporary kernel regressions? Instructions for that are here: https://wiki.ubuntu.com/Kernel/MainlineBuilds I'll also build an uptodate daily qemu build so we can test whe

Re: [Qemu-devel] [PATCH v3 4/6] target-i386: Remove unsupported bits from all CPU models

2014-10-29 Thread Andreas Färber
Am 03.10.2014 um 21:39 schrieb Eduardo Habkost: > The following CPU features were never supported by neither TCG or KVM, > so they are useless on the CPU model definitions, today: > > * CPUID_DTS (DS) > * CPUID_HT > * CPUID_TM > * CPUID_PBE > * CPUID_EXT_DTES64 > * CPUID_EXT_DSCPL > * CPUID

[Qemu-devel] [Bug 1379340] Re: qemu-kvm guest panic for AMD smp trusty guests

2014-10-29 Thread Serge Hallyn
** Summary changed: - qemu-kvm guest panic for smp trusty guests + qemu-kvm guest panic for AMD smp trusty guests -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1379340 Title: qemu-kvm guest panic

Re: [Qemu-devel] [RFC PATCH v2 00/23] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2014-10-29 Thread Stefan Hajnoczi
On Wed, Oct 29, 2014 at 05:54:00PM +0800, Wen Congyang wrote: > On 10/29/2014 05:34 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > > > > > > > >> Hi all: > >> > >> I will start to implement disk replication. Before doing this, I think we > >> should decide

[Qemu-devel] Timer list lock contention

2014-10-29 Thread Sergey Fedorov
Hi! I am wondering is there any case when timer list lock could be under contention? Thanks, Serge

[Qemu-devel] [PATCH] hw/arm/realview.c: Fix memory leak in realview_init()

2014-10-29 Thread Nikita Belov
Variable 'ram_lo' is allocated unconditionally, but used only in some cases. When it is unused pointer will be lost at function exit, resulting in a memory leak. Free memory in this case. Valgrind output: ==16879== 240 bytes in 1 blocks are definitely lost in loss record 6,033 of 7,018 ==16879==

[Qemu-devel] [PATCH] hw/i386/acpi-build.c: Fix memory leak in acpi_build_tables_cleanup()

2014-10-29 Thread Nikita Belov
There are three ACPI tables: 'linker_data', 'rsdp' and 'table_data'. They are used differently. Two of them are being copied before using and only the copy is used later. But the third is used directly. Because of that we need to free two tables completely and delete only wrapper for the third one.

[Qemu-devel] [PATCH] i6300esb: fix reading config registers and accept writes of all length

2014-10-29 Thread Adam Hoka
Don't require configuration register write to be off a certain length, as some PCI implementations always access them in 32bit only. This is because it's in fact the only kind of access supported by the standard, anything else is implementation dependent. Add support for reading back the configura

[Qemu-devel] [PATCH] virtio-serial: avoid crash when port has no name

2014-10-29 Thread Marc-André Lureau
It seems "name" is not mandatory, and the following command line (based on one generated by current libvirt) will crash qemu at start: qemu-system-x86_64 \ -device virtio-serial-pci \ -device virtserialport,name=foo \ -device virtconsole Program received signal SIGSEGV, Segmentation f

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Liviu Ionescu
On 29 Oct 2014, at 17:31, Paolo Bonzini wrote: > That's due to usage of the breakpoint instruction, as Peter pointed out. >> Are we treating the >> breakpoint as a breakpoint and dropping into gdb >> rather than treating it as a semihosting call? my first thought was that the semihosting BRKs

Re: [Qemu-devel] [PATCH] iscsi: Refuse to open as writable if the LUN is write protected

2014-10-29 Thread Peter Lieven
Am 29.10.2014 um 14:31 schrieb Paolo Bonzini: > > On 10/29/2014 02:13 PM, Fam Zheng wrote: >> Before, when a write protected iSCSI target is attached as scsi-disk >> with BDRV_O_RDWR, we report it as writable, while in fact all writes >> will fail. >> >> One way to improve this is to report write p

Re: [Qemu-devel] [PATCH] hw/arm/realview.c: Fix memory leak in realview_init()

2014-10-29 Thread Peter Maydell
On 29 October 2014 14:03, Nikita Belov wrote: > Variable 'ram_lo' is allocated unconditionally, but used only in some cases. > When it is unused pointer will be lost at function exit, resulting in a > memory leak. Free memory in this case. > > Valgrind output: > ==16879== 240 bytes in 1 blocks are

Re: [Qemu-devel] [PATCH 01/17] ahci: Fix CD-ROM signature

2014-10-29 Thread John Snow
On 10/29/2014 04:11 AM, Hannes Reinecke wrote: On 10/29/2014 09:07 AM, Markus Armbruster wrote: Copying John Snow for additional AHCI expertise. Hannes Reinecke writes: The CD-ROM signature is 0xeb140101, not 0xeb14. Without this change OVMF/Duet runs into a timeout trying to detect a

Re: [Qemu-devel] nbd-server / monitor to copy files/directory in to running VM.

2014-10-29 Thread Daniel P. Berrange
On Wed, Oct 29, 2014 at 03:20:28PM +, Stefan Hajnoczi wrote: > On Tue, Oct 28, 2014 at 10:02:21AM -0700, Jd wrote: > > qemu monitor seems to have command to open, write, close commands. I tried > > them and I could create a file (after going through encoding). How can I > > create a directory

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-10-29 Thread Stefan Hajnoczi
On Wed, Oct 29, 2014 at 02:54:32PM +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 28.10.2014 um 17:03 hat Markus Armbruster geschrieben: > >> If the user neglects to specify the image format, QEMU probes the > >> image to guess it automatically, for convenience. > >> > >> Relying

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 04:18 PM, Liviu Ionescu wrote: > > On 29 Oct 2014, at 17:11, Paolo Bonzini wrote: > >> On 10/28/2014 03:40 PM, Peter Maydell wrote: >>> I think writes via gdb will be treated in the same way as >>> writes by the CPU (ie interpreted as attempts to program >>> the flash device). QE

Re: [Qemu-devel] [PATCH 1/2] block: JSON filenames and relative backing files

2014-10-29 Thread Kevin Wolf
Am 23.10.2014 um 20:00 hat Max Reitz geschrieben: > On 23.10.2014 19:42, Eric Blake wrote: > >On 10/23/2014 08:56 AM, Max Reitz wrote: > >>When using a relative backing file name, qemu needs to know the > >>directory of the top image file. For JSON filenames, such a directory > >>cannot be easily d

Re: [Qemu-devel] [PATCH RFC 1/2] block: Factor bdrv_probe_all() out of find_image_format()

2014-10-29 Thread Stefan Hajnoczi
On Tue, Oct 28, 2014 at 05:03:39PM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block.c | 45 - > 1 file changed, 32 insertions(+), 13 deletions(-) Reviewed-by: Stefan Hajnoczi pgpdJrG1ASKFX.pgp Description: PGP signatu

Re: [Qemu-devel] nbd-server / monitor to copy files/directory in to running VM.

2014-10-29 Thread Stefan Hajnoczi
On Tue, Oct 28, 2014 at 10:02:21AM -0700, Jd wrote: > qemu monitor seems to have command to open, write, close commands. I tried > them and I could create a file (after going through encoding). How can I > create a directory using this ? Do you mean the code in qga/? That is the QEMU guest agen

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Liviu Ionescu
On 29 Oct 2014, at 17:11, Paolo Bonzini wrote: > On 10/28/2014 03:40 PM, Peter Maydell wrote: >> I think writes via gdb will be treated in the same way as >> writes by the CPU (ie interpreted as attempts to program >> the flash device). QEMU doesn't support a "debug access" >> abstraction. > >

Re: [Qemu-devel] [PATCH] inetd enabled qemu-nbd

2014-10-29 Thread Eric Blake
On 10/28/2014 09:36 PM, Jun Sheng wrote: > From: Chaos Eternal > > > Signed-off-by: Jun Sheng Using a pseudonym for the git authorship (the From: line) is unusual (but not unheard of in this project). What is weirder is that your S-o-B uses a real name; if you don't mind exposing your real na

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Paolo Bonzini
On 10/28/2014 03:40 PM, Peter Maydell wrote: > I think writes via gdb will be treated in the same way as > writes by the CPU (ie interpreted as attempts to program > the flash device). QEMU doesn't support a "debug access" > abstraction. I think they should work right. See cpu_memory_rw_debug. P

Re: [Qemu-devel] [PATCH] Simple performance logging and network limiting based on trace option

2014-10-29 Thread Stefan Hajnoczi
On Tue, Oct 28, 2014 at 04:33:42PM +0100, Harald Schieche wrote: Missing commit description: What problem are you trying to solve? The "Signed-off-by" goes here. > diff --git a/block/raw-posix.c b/block/raw-posix.c > index 475cf74..3c5cc71 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posi

[Qemu-devel] [PATCH] target-ppc: Fix Altivec Shifts

2014-10-29 Thread Tom Musta
Fix the implementation of the Altivec shift left and shift right instructions (vsl, vsr) which erroneously inverts shift direction on big endian hosts. Signed-off-by: Tom Musta --- target-ppc/int_helper.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/targe

Re: [Qemu-devel] [PATCH] dump: fix use-after-free for s->fd

2014-10-29 Thread Markus Armbruster
writes: > From: Gonglei > > After commit 4c7e251a (), when dump memory completed, > the s->fd will be closed twice. We should return > directly when dump completed. > > Signed-off-by: Gonglei > --- > dump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dump.c b/dump.c > index 06a491

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Peter Maydell
On 29 October 2014 13:28, Christopher Covington wrote: > I've sometimes thought it might be cool if QEMU could consume a DTB and > emulate whatever is described, assuming the devices and configurations are > supported. I've yet to come up with a real problem to motivate this > "solution", though.

Re: [Qemu-devel] [Xen-devel] [PATCH v4 0/2] Use ioreq-server API

2014-10-29 Thread Paul Durrant
Ping? > -Original Message- > From: xen-devel-boun...@lists.xen.org [mailto:xen-devel- > boun...@lists.xen.org] On Behalf Of Paul Durrant > Sent: 16 October 2014 13:11 > To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org > Subject: [Xen-devel] [PATCH v4 0/2] Use ioreq-server API > >

Re: [Qemu-devel] [PATCH 02/17] atapi: clear sense code

2014-10-29 Thread Stefan Hajnoczi
On Wed, Oct 29, 2014 at 08:53:37AM +0100, Hannes Reinecke wrote: > The sense code needs to be cleared after REQUEST SENSE. > > Signed-off-by: Hannes Reinecke > --- > hw/ide/atapi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c > inde

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Andreas Färber
Am 29.10.2014 um 14:28 schrieb Christopher Covington: > On 10/28/2014 01:08 PM, Peter Maydell wrote: >> On 28 October 2014 16:38, Liviu Ionescu wrote: >>> I'm not sure what the QEMU definition of '-machine' stands for, a device >>> or a board, but I think that the ARM definitions are good candidat

Re: [Qemu-devel] [PATCH 01/17] ahci: Fix CD-ROM signature

2014-10-29 Thread Stefan Hajnoczi
On Wed, Oct 29, 2014 at 08:53:36AM +0100, Hannes Reinecke wrote: > The CD-ROM signature is 0xeb140101, not 0xeb14. > Without this change OVMF/Duet runs into a timeout trying > to detect a SATA cdrom. > > Signed-off-by: Hannes Reinecke > --- > hw/ide/ahci.h | 2 +- > 1 file changed, 1 inserti

Re: [Qemu-devel] Dirty block tracking : External file

2014-10-29 Thread Stefan Hajnoczi
On Tue, Oct 28, 2014 at 4:52 PM, Jd wrote: > If it is complete, can some one point to the branch / label from which I can > get it. Fam's patches are available in the mailing list archive: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02309.html A lot of the infrastructure has already

Re: [Qemu-devel] Dirty block tracking : External file

2014-10-29 Thread Stefan Hajnoczi
On Tue, Oct 28, 2014 at 4:52 PM, Jd wrote: > If it is complete, can some one point to the branch / label from which I can > get it. Fam's patches are available in the mailing list archive: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02309.html A lot of the infrastructure has already

Re: [Qemu-devel] Dirty block tracking : External file

2014-10-29 Thread Stefan Hajnoczi
On Tue, Oct 28, 2014 at 4:52 PM, Jd wrote: > If it is complete, can some one point to the branch / label from which I can > get it. Fam's patches are available in the mailing list archive: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02309.html A lot of the infrastructure has already

Re: [Qemu-devel] [PATCH v3 09/15] target-mips: update cpu_save/cpu_load to support new registers

2014-10-29 Thread Yongbok Kim
On 24/10/2014 13:42, Leon Alrae wrote: Signed-off-by: Leon Alrae --- target-mips/cpu.h | 2 +- target-mips/machine.c | 26 +- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 4687f4f..c66a725 100644 --- a

Re: [Qemu-devel] [PATCH v3 08/15] target-mips: add BadInstr and BadInstrP support

2014-10-29 Thread Yongbok Kim
On 24/10/2014 13:42, Leon Alrae wrote: BadInstr Register (CP0 Register 8, Select 1) The BadInstr register is a read-only register that capture the most recent instruction which caused an exception. BadInstrP Register (CP0 Register 8, Select 2) The BadInstrP register contains the prior branch ins

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-10-29 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.10.2014 um 17:03 hat Markus Armbruster geschrieben: >> If the user neglects to specify the image format, QEMU probes the >> image to guess it automatically, for convenience. >> >> Relying on format probing is insecure for raw images (CVE-2008-2004). >> If the guest wri

[Qemu-devel] [PATCH 5/6] iotests: padded parallels image test

2014-10-29 Thread Denis V. Lunev
Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. "Padding" is a value which should be added to guest LBA to obtain sector number inside the image. This results in a shifted images. 0123offset inside image (in 51

[Qemu-devel] [PATCH v2 0/6] parallels format support improvements

2014-10-29 Thread Denis V. Lunev
The patchset implements additional compatibility bits for Parallels format: - initial support of parsing of Parallels DiskDeskriptor.xml Typically Parallels disk bundle consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which

[Qemu-devel] [PATCH 6/6] parallels: change copyright information in the image header

2014-10-29 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index d07e4f7..1491211 100644 --- a/block/parallels.c +++ b/b

[Qemu-devel] [PATCH 4/6] block/parallels: support padded Parallels images

2014-10-29 Thread Denis V. Lunev
Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. For the time being Parallels was created an optimization for such OSes in its desktop product. Desktop users are not qualified enough to create properly aligned installation

[Qemu-devel] [PATCH 2/6] block/parallels: allow to specify DiskDescriptor.xml instead of image file

2014-10-29 Thread Denis V. Lunev
Typically Parallels disk bundle consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. This patch allows to specify this XML file as a filename for an image to open. It is allowed only to op

[Qemu-devel] [PATCH 1/6] configure: add dependency from libxml2

2014-10-29 Thread Denis V. Lunev
This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. The patch also adds clause to checkpatch.pl to un

[Qemu-devel] [PATCH 3/6] iotests: simple parallels XML disk descriptor file test added

2014-10-29 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- tests/qemu-iotests/076| 6 ++ tests/qemu-iotests/076.out| 4 tests/qemu-iotests/sample_images/parallels-sim

Re: [Qemu-devel] [PATCH] iscsi: Refuse to open as writable if the LUN is write protected

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 02:13 PM, Fam Zheng wrote: > Before, when a write protected iSCSI target is attached as scsi-disk > with BDRV_O_RDWR, we report it as writable, while in fact all writes > will fail. > > One way to improve this is to report write protect flag as true to > guest, but a even better wa

Re: [Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-29 Thread Xiaodong Gong
On 10/28/14, Stefan Hajnoczi wrote: > On Wed, Oct 08, 2014 at 08:42:32PM +0800, Xiaodong Gong wrote: >> Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu >> can't read snapshot volume of vhd, and can't support other storage >> features of vhd file. >> >> This patch add read parent

Re: [Qemu-devel] Better Cortex-M support?

2014-10-29 Thread Christopher Covington
On 10/28/2014 01:08 PM, Peter Maydell wrote: > On 28 October 2014 16:38, Liviu Ionescu wrote: >> I'm not sure what the QEMU definition of '-machine' stands for, a device >> or a board, but I think that the ARM definitions are good candidates for >> QEMU emulation names. > > -machine specifies a b

Re: [Qemu-devel] [PATCH 10/13] megasas: Implement DCMD_CLUSTER_RESET_LD

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 02:23 PM, Hannes Reinecke wrote: > On 10/29/2014 01:54 PM, Paolo Bonzini wrote: >> >> >> On 10/29/2014 01:00 PM, Hannes Reinecke wrote: >>> +trace_megasas_dcmd_reset_ld(cmd->index, target_id); >>> +for (i = 0; i < s->fw_cmds; i++) { >>> +MegasasCmd *tmp_cmd = &s->fra

[Qemu-devel] [PATCH 1/2] pc: Add pc_compat_2_1() function

2014-10-29 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 13 - hw/i386/pc_q35.c | 13 - 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 91a20cb..162b77e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -30

[Qemu-devel] [PATCH 2/2] smbios: Encode UUID according to SMBIOS specification

2014-10-29 Thread Eduardo Habkost
Differently from older versions, SMBIOS version 2.6 is explicit about the encoding of UUID fields: > Although RFC 4122 recommends network byte order for all fields, the PC > industry (including the ACPI, UEFI, and Microsoft specifications) has > consistently used little-endian byte encoding for th

[Qemu-devel] [PATCH 0/2] smbios: Encode UUID according to SMBIOS specification

2014-10-29 Thread Eduardo Habkost
This fixes the bug described at: https://bugzilla.redhat.com/show_bug.cgi?id=1152922 Cc: "Michael S. Tsirkin" Cc: Gabriel L. Somlo Cc: Gerd Hoffmann Eduardo Habkost (2): pc: Add pc_compat_2_1() function smbios: Encode UUID according to SMBIOS specification hw/i386/pc_piix.c| 17

Re: [Qemu-devel] [PATCH 10/13] megasas: Implement DCMD_CLUSTER_RESET_LD

2014-10-29 Thread Hannes Reinecke
On 10/29/2014 01:54 PM, Paolo Bonzini wrote: On 10/29/2014 01:00 PM, Hannes Reinecke wrote: +trace_megasas_dcmd_reset_ld(cmd->index, target_id); +for (i = 0; i < s->fw_cmds; i++) { +MegasasCmd *tmp_cmd = &s->frames[i]; +if (tmp_cmd->req && tmp_cmd->req->dev->lun == targ

[Qemu-devel] [PATCH] iscsi: Refuse to open as writable if the LUN is write protected

2014-10-29 Thread Fam Zheng
Before, when a write protected iSCSI target is attached as scsi-disk with BDRV_O_RDWR, we report it as writable, while in fact all writes will fail. One way to improve this is to report write protect flag as true to guest, but a even better way is to refuse using a write protected LUN to guest. T

Re: [Qemu-devel] [PATCH] vl.c: Fix Coverity complaining for vmstate_dump_file

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 01:49 PM, arei.gong...@huawei.com wrote: > From: Gonglei > > commit abfd9ce3(migration: dump vmstate info as a json > file for static analysis) introduce a new command, > '-dump-vmstate', that takes a filename > as an argument. When executed, QEMU will dump the vmstate information

Re: [Qemu-devel] [PATCH v2 RESEND] Add skip_dump flag to ignore memory region during dump

2014-10-29 Thread Paolo Bonzini
On 09/15/2014 05:58 AM, Nikunj A Dadhania wrote: > The PCI MMIO might be disabled or the device in the reset state. > Make sure we do not dump these memory regions. > > Signed-off-by: Nikunj A Dadhania > Acked-by: Alex Williamson > CC: Paolo Bonzini > --- > > Resending, missed to CC Paolo >

Re: [Qemu-devel] [PATCH] vl.c: Fix Coverity complaining for vmstate_dump_file

2014-10-29 Thread Amit Shah
On (Wed) 29 Oct 2014 [20:49:43], arei.gong...@huawei.com wrote: > From: Gonglei > > commit abfd9ce3(migration: dump vmstate info as a json > file for static analysis) introduce a new command, > '-dump-vmstate', that takes a filename > as an argument. When executed, QEMU will dump the vmstate inf

Re: [Qemu-devel] [PATCH 10/13] megasas: Implement DCMD_CLUSTER_RESET_LD

2014-10-29 Thread Paolo Bonzini
On 10/29/2014 01:00 PM, Hannes Reinecke wrote: > +trace_megasas_dcmd_reset_ld(cmd->index, target_id); > +for (i = 0; i < s->fw_cmds; i++) { > +MegasasCmd *tmp_cmd = &s->frames[i]; > +if (tmp_cmd->req && tmp_cmd->req->dev->lun == target_id) { Why ->lun? Paolo > +

Re: [Qemu-devel] [PATCH 0/2] buildsys: Convert SDL_CFLAGS to .mo-cflags

2014-10-29 Thread Paolo Bonzini
On 10/28/2014 09:47 AM, Fam Zheng wrote: > This is actually the first user of the *.mo rule syntax. It's the recommended > way to specify per object flags, which also makes the sophisticated rules in > rules.mak less likely to bit rot. Applied, thanks. Paolo > Fam > > > > Fam Zheng (2): > r

[Qemu-devel] [PATCH] vl.c: Fix Coverity complaining for vmstate_dump_file

2014-10-29 Thread arei.gonglei
From: Gonglei commit abfd9ce3(migration: dump vmstate info as a json file for static analysis) introduce a new command, '-dump-vmstate', that takes a filename as an argument. When executed, QEMU will dump the vmstate information for the machine type it's invoked with to the file, and quit. Appa

[Qemu-devel] [PATCH 0/5] Add TriCore BOL, BRC, BRN, BRR and RC instructions

2014-10-29 Thread Bastian Koppelmann
Hi, this is the next round of TriCore patches, which adds BOL, BRC, BRN, BRR and RC instructions. I'm not quite sure about the softfreeze. Since this patch has not been announced after the softfreeze, do I have to wait with a pull-request to after the release of 2.2? thanks, Bastian Bastian K

[Qemu-devel] [PATCH 3/5] target-tricore: Add instructions of BRN opcode format

2014-10-29 Thread Bastian Koppelmann
Add instructions of BRN opcode format. Add MASK_OP_BRN_DISP15_SEXT. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 30 ++ target-tricore/tricore-opcodes.h | 1 + 2 files changed, 31 insertions(+) diff --git a/target-tricore/translate.c b/ta

[Qemu-devel] [PATCH 5/5] target-tricore: Add instructions of RC opcode format

2014-10-29 Thread Bastian Koppelmann
Add instructions of RC opcode format. Add helper for mul, sha, absdif with signed saturation on overflow. Add helper for add, sub, mul with unsigned saturation on overflow. Add microcode generator functions: * gen_add_CC, which calculates the carry bit. * gen_addc_CC, which adds the carry b

  1   2   3   >