On Wed, Oct 29, 2014 at 08:53:36AM +0100, Hannes Reinecke wrote: > The CD-ROM signature is 0xeb140101, not 0xeb140000. > Without this change OVMF/Duet runs into a timeout trying > to detect a SATA cdrom. > > Signed-off-by: Hannes Reinecke <h...@suse.de> > --- > hw/ide/ahci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h > index e223258..970eea8 100644 > --- a/hw/ide/ahci.h > +++ b/hw/ide/ahci.h > @@ -161,7 +161,7 @@ > #define AHCI_CMD_HDR_CMD_FIS_LEN 0x1f > #define AHCI_CMD_HDR_PRDT_LEN 16 > > -#define SATA_SIGNATURE_CDROM 0xeb140000 > +#define SATA_SIGNATURE_CDROM 0xeb140101
Looks good, this change is justified by ATA/ATAPI-4 "9.1 Signature and persistence". Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
pgpejSvIi0PjH.pgp
Description: PGP signature
