Re: [Qemu-devel] [RFC PATCH v3 15/18] linux headers update for SPAPR (DDW + EEH)

2014-09-25 Thread Alexey Kardashevskiy
On 09/26/2014 03:40 PM, David Gibson wrote: > On Fri, Aug 29, 2014 at 08:12:19PM +1000, Alexey Kardashevskiy wrote: >> Since the changes are not in upstream yet, no tag or branch is specified >> here. >> >> EEH is included to have a chance of catching problems with some shifted >> IOCTL number or

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Gerd Hoffmann
Hi, > > -static void usb_hid_initfn(USBDevice *dev, int kind) > > +static void usb_hid_initfn(USBDevice *dev, int kind, > > + const USBDesc *usb1, const USBDesc > > *usb2, > > + Error **errp) > > I don't think it is a good idea that adding usb

Re: [Qemu-devel] [RFC patch 0/6] vfio based pci pass-through for qemu/KVM on s390

2014-09-25 Thread Frank Blaschka
On Wed, Sep 24, 2014 at 10:05:57AM -0600, Alex Williamson wrote: > On Wed, 2014-09-24 at 10:47 +0200, Frank Blaschka wrote: > > On Mon, Sep 22, 2014 at 02:47:31PM -0600, Alex Williamson wrote: > > > On Fri, 2014-09-19 at 13:54 +0200, frank.blasc...@de.ibm.com wrote: > > > > This set of patches impl

[Qemu-devel] [Bug 1373362] Re: qemu-2.1.1 i386-softmmu compile error: q35_dsdt_applesmc_sta undeclared

2014-09-25 Thread Thomas Eschenbacher
I retried it on another machine, running Kubuntu 14.10 (x86_64) -> fails at exactly the same point ! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1373362 Title: qemu-2.1.1 i386-softmmu compile err

Re: [Qemu-devel] [RFC PATCH v3 15/18] linux headers update for SPAPR (DDW + EEH)

2014-09-25 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:19PM +1000, Alexey Kardashevskiy wrote: > Since the changes are not in upstream yet, no tag or branch is specified here. > > EEH is included to have a chance of catching problems with some shifted > IOCTL number or other random stuff like that. > > Signed-off-by: Ale

Re: [Qemu-devel] [RFC PATCH v3 12/18] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support

2014-09-25 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:16PM +1000, Alexey Kardashevskiy wrote: > NO RESET > > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > which can support page sizes other than 4K. > > The existing implementat

Re: [Qemu-devel] [RFC PATCH v3 17/18] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-09-25 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:21PM +1000, Alexey Kardashevskiy wrote: > This enables DDW RTAS-related ioctls in VFIO. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-25 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:17PM +1000, Alexey Kardashevskiy wrote: > This implements DDW for emulated PHB. > > This advertises the query/create/remove RTAS tokens in device tree. > This does not advertise the reset RTAS token though, will be added later. > > The "ddw" property is enabled by de

Re: [Qemu-devel] [RFC PATCH v3 14/18] spapr_pci_vfio: Call spapr_pci::reset on reset

2014-09-25 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:18PM +1000, Alexey Kardashevskiy wrote: > This enables use of the parent class rest() callback in VFIO. > > This effectively enables reset of PHBs TCE IOMMU object(s) which are not > bus devices and do not get reset by qemu_devices_reset() called from > a machine rese

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-25 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:20PM +1000, Alexey Kardashevskiy wrote: > This implements DDW for VFIO. Host kernel support is required for this. > > After this patch DDW will be enabled on all machines but pseries-2.1. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * remove()/re

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > v2: rebase > > Signed-off-by: Jan Vesely > --- > hw/usb/dev-hid.c | 38 ++ > 1 file changed, 18 insertions(+), 20 deletions(-) > > diff --git a/hw/usb/dev-hid.c

Re: [Qemu-devel] [PULL 2/7] input: use kbd delays for send_key monitor command

2014-09-25 Thread Amos Kong
On Wed, Jun 04, 2014 at 09:44:06AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/input-legacy.c | 45 ++--- > 1 file changed, 6 insertions(+), 39 deletions(-) > > diff --git a/ui/input-legacy.c b/ui/input-legacy.c > index 2a53860..3

[Qemu-devel] [PATCH qom v3 12/14] qdev: gpio: Remove qdev_init_gpio_out x1 restriction

2014-09-25 Thread Peter Crosthwaite
Previously this was restricted to a single call per-dev/per-name. With the conversion of the GPIO output state to QOM the implementation can now handle repeated calls. Remove the restriction. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --- hw/core/qdev.c | 3 +-- 1 file change

[Qemu-devel] [PATCH qom v3 14/14] sysbus: Use TYPE_DEVICE GPIO functionality

2014-09-25 Thread Peter Crosthwaite
Re-implement the Sysbus GPIOs to use the existing TYPE_DEVICE GPIO named framework. A constant string name is chosen to avoid conflicts with existing unnamed GPIOs. This unifies GPIOs are IRQs for sysbus devices and allows removal of all Sysbus state for GPIOs. Any existing and future-added funct

[Qemu-devel] [PATCH qom v3 13/14] qdev: gpio: Define qdev_pass_gpios()

2014-09-25 Thread Peter Crosthwaite
Allows a container to take ownership of GPIOs in a contained device and automatically connect them as GPIOs to the container. This prepares for deprecation of the SYSBUS IRQ functionality, which has this feature. We push it up to the device level instead of sysbus level. There's nothing sysbus spe

[Qemu-devel] [PATCH qom v3 10/14] irq: Remove qemu_irq_intercept_out

2014-09-25 Thread Peter Crosthwaite
No more users left and obsoleted by qdev_intercept_gpio_out. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --- hw/core/irq.c| 6 -- include/hw/irq.h | 1 - 2 files changed, 7 deletions(-) diff --git a/hw/core/irq.c b/hw/core/irq.c index 4a580a2..8a62a36 100644 --- a/hw/

[Qemu-devel] [PATCH qom v3 09/14] qtest/irq: Rework IRQ interception

2014-09-25 Thread Peter Crosthwaite
Change the qtest intercept handler to accept just the individual IRQ being intercepted as opaque. n is still expected to be correctly set as for the original intercepted irq. qemu_intercept_irq_in is updated accordingly. Then covert the qemu_irq_intercept_out call to use qdev intercept version. Th

[Qemu-devel] [PATCH qom v3 11/14] qdev: gpio: delete NamedGPIOList::out

2014-09-25 Thread Peter Crosthwaite
All users of GPIO outputs are fully QOMified, using QOM properties to access the GPIO data. Delete. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --- hw/core/qdev.c | 1 - include/hw/qdev-core.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/core/qdev.c b/hw/cor

[Qemu-devel] [PATCH qom v3 08/14] qdev: gpio: Add API for intercepting a GPIO

2014-09-25 Thread Peter Crosthwaite
To replace the old qemu_irq intercept API (which had users reaching into qdev private state for GPIOs). Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --- changed since v1 (Alex review): Accept an alredy inited qemu_irq as arg and return the disconnected (allow arbitrary opaque set

[Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement qdev_connect_gpio QOM style

2014-09-25 Thread Peter Crosthwaite
Re-implement as a link setter. This should allow the QOM framework to keep track of ref counts properly etc. We need to add a default parent for the connecting input incase it's coming from a non-qdev source. We simply parent the IRQ to the machine in this case. Reviewed-by: Alexander Graf Signe

[Qemu-devel] [PATCH qom v3 05/14] qom: Allow clearing of a Link property

2014-09-25 Thread Peter Crosthwaite
By passing in NULL to object_property_set_link. The lead user of this is the QDEV GPIO framework which will implement GPIO disconnects via an "unlink". Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --- qom/object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH qom v3 06/14] qom: Demote already-has-a-parent to a regular error

2014-09-25 Thread Peter Crosthwaite
Rather than an abort(). This allows callers to decide whether parenting an already-parented object is a fatal error condition. Useful for providing a default value for an object's parent in the case where you want to set one iff it doesn't already have one. Reviewed-by: Alexander Graf Signed-off

[Qemu-devel] [PATCH qom v3 04/14] qmp: qstring: Handle NULL strings

2014-09-25 Thread Peter Crosthwaite
Create a valid qobject even if the input string is null. qstring->string will be NULL and length will be 0. This prepares support for clearing of QOM Link properties where NULL canonical path string will be passes through this API. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --

[Qemu-devel] [PATCH qom v3 03/14] qdev: gpio: Register GPIO outputs as QOM links

2014-09-25 Thread Peter Crosthwaite
Within the object that contains the GPIO output. This allows for connecting GPIO outputs via setting of a Link property. Also clear the link value to zero. This catch-alls the case where a device improperly inits a gpio_out (malloc instead of malloc0). Reviewed-by: Alexander Graf Signed-off-by:

[Qemu-devel] [PATCH qom v3 02/14] qdev: gpio: Register GPIO inputs as child objects

2014-09-25 Thread Peter Crosthwaite
To the device that contains them. This will allow for referencing a GPIO input from it's canonical path (exciting for dynamic machine generation!) Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite --- Define propname variable at start of function. hw/core/qdev.c | 9 + 1 fil

[Qemu-devel] [PATCH qom v3 01/14] qdev: gpio: Don't allow name share between I and O

2014-09-25 Thread Peter Crosthwaite
Only allow a GPIO name to be one or the other. Inputs and outputs are functionally different and should be in different namespaces. Prepares support for the QOMification of IRQs as Links or Child objects. The alternative is to munge names .e.g. with "-in" or "-out" suffixes when giving QOM names.

[Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

2014-09-25 Thread Peter Crosthwaite
Hi All, So phase one was the QOMification of qemu_irq. This is the next step. We start to setup GPIOs as proper QOM objects. Inputs are child objects of their device. Outputs are settable Links and connection is made via proper setting of a QOM link. We then cleanup Sysbus to simply re-use device

Re: [Qemu-devel] [PATCH 3/3] vga-pci: add qext region to mmio

2014-09-25 Thread David Gibson
On Tue, Sep 23, 2014 at 02:30:57PM +0200, Gerd Hoffmann wrote: > Add a qemu extented register range to the standard vga mmio bar. > Right nowe there are two registers: One readonly register returning the > size of the region (so we can easily add more registers there if needed) > and one endian co

Re: [Qemu-devel] [PATCH 2/3] vga: Add endian control register

2014-09-25 Thread David Gibson
On Tue, Sep 23, 2014 at 02:30:56PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > Include the endian state in the migration stream as an optional > subsection which we only include when the endian isn't the default, > thus enabling backward compatibility of the common case. > > S

Re: [Qemu-devel] [PATCH 1/3] vga: Make fb endian a common state variable

2014-09-25 Thread David Gibson
On Tue, Sep 23, 2014 at 02:30:55PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > And initialize it based on target endian > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david A

Re: [Qemu-devel] [PATCH 8/8] vga: Rename vga_template.h to vga-helpers.h

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:56PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > It's no longer a template, we only instanciate the file once. > > Keep it a #included file so the functions remain static. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 7/8] vga: Remove some "should be done in BIOS" comments

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:55PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > Not all platforms have a VGA BIOS, powerpc typically relies on > using the DISPI interface to initialize the card. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann Reviewe

Re: [Qemu-devel] [PATCH 2/8] vga: Remove remainder of old conversion cruft

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:50PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > All the macros used to generate different versions of vga_template.h > are now unnecessary, take them all out and remove the _32 suffix from > most functions. > > Signed-off-by: Benjamin Herrenschmi

Re: [Qemu-devel] [PATCH 1/8] vga: Start cutting out non-32bpp conversion support

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:49PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > Nowadays, we either share a surface with the host, or we create > a 32bpp ARGB console surface. > > So we only need to draw/convert to 32bpp, enabling us to remove > all but one instance of vga_temp

Re: [Qemu-devel] [PATCH 5/8] vga: Simplify vga_draw_blank() a bit

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:53PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > The test for surface_bits_per_pixel() isn't necessary anymore, > the 8bpp case never happens. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:51PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > Provide different functions for converting from an LE vs a BE > framebuffer. We cannot rely on the simple cases always being > shared surfaces since cirrus will need to always shadow for > cursor emu

Re: [Qemu-devel] [PATCH 4/8] vga: Remove rgb_to_pixel indirection

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:52PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > We always use rgb_to_pixel32 nowadays. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson -- David Gibson| I'll have my musi

Re: [Qemu-devel] [PATCH 6/8] cirrus: Remove non-32bpp cursor drawing

2014-09-25 Thread David Gibson
On Mon, Sep 22, 2014 at 04:44:54PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > We only draw cursor on non-shared surfaces (so it seems...) and > these are always 32bpp > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson -- D

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-09-25 Thread Alexey Kardashevskiy
On 09/08/2014 06:47 AM, Alexander Graf wrote: > > > On 25.08.14 15:45, Aravinda Prasad wrote: >> This patch adds FWNMI support in qemu for powerKVM >> guests by handling the ibm,nmi-register rtas call. >> Whenever OS issues ibm,nmi-register RTAS call, the >> machine check notification address is

Re: [Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-09-25 Thread Alexey Kardashevskiy
On 09/26/2014 12:31 PM, David Gibson wrote: > On Thu, Sep 25, 2014 at 08:06:40PM +1000, Alexey Kardashevskiy wrote: >> On 09/25/2014 07:43 PM, Alexander Graf wrote: >>> >>> >>> On 25.09.14 09:02, Alexey Kardashevskiy wrote: The only case when sPAPR NVRAM migrates now is if is backed by a file

Re: [Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-09-25 Thread David Gibson
On Thu, Sep 25, 2014 at 08:06:40PM +1000, Alexey Kardashevskiy wrote: > On 09/25/2014 07:43 PM, Alexander Graf wrote: > > > > > > On 25.09.14 09:02, Alexey Kardashevskiy wrote: > >> The only case when sPAPR NVRAM migrates now is if is backed by a file and > >> copy-storage migration is performed.

Re: [Qemu-devel] [PATCH v1 0/3] monitor: add peripheral device del completion support

2014-09-25 Thread Zhu Guihua
ping ... On Thu, 2014-09-18 at 15:53 +0800, Zhu Guihua wrote: > After inputting device_del command in monitor, we expect to list all > hotpluggable devices automatically by pressing tab key. This patchset provides > the function to list all peripheral devices such as memory devices. > > Zhu Guihu

Re: [Qemu-devel] [PATCH 2/2] iohandler: Add Linux implementation of iohandler GSource

2014-09-25 Thread Fam Zheng
On Thu, 09/25 21:45, Paolo Bonzini wrote: > Il 25/09/2014 19:21, Fam Zheng ha scritto: > > +while (true) { > > +r = epoll_pwait(s->epollfd.fd, events, MAX_EVENTS, 0, &origmask); > > You can save a syscall by doing this just once. You would just get a > readable epoll file descriptor o

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:43:40AM +0100, Peter Maydell wrote: > On 26 September 2014 00:31, Edgar E. Iglesias > wrote: > > On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: > >> Oh, yes, that's the trap enable bit. In that case we shouldn't > >> be using EXCP_SMC: this isn't routing

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Peter Maydell
On 26 September 2014 00:31, Edgar E. Iglesias wrote: > On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: >> Oh, yes, that's the trap enable bit. In that case we shouldn't >> be using EXCP_SMC: this isn't routing the SMC exception, it's >> taking a Hyp trap exception, and in AArch32 th

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: > On 25 September 2014 23:55, Edgar E. Iglesias > wrote: > > On Thu, Sep 25, 2014 at 07:47:16PM +0100, Peter Maydell wrote: > >> > +/* In NS EL1, HCR controlled routing to EL2 has priority over SMD. > >> > */ > >> > +if (!se

Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn

2014-09-25 Thread Peter Maydell
On 26 September 2014 00:06, Edgar E. Iglesias wrote: > On Fri, Sep 26, 2014 at 12:01:11AM +0100, Peter Maydell wrote: >> On 25 September 2014 23:20, Edgar E. Iglesias >> wrote: >> > On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote: >> >> HCR.TGE isn't actually relevant for some exce

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Peter Maydell
On 25 September 2014 23:55, Edgar E. Iglesias wrote: > On Thu, Sep 25, 2014 at 07:47:16PM +0100, Peter Maydell wrote: >> > +/* In NS EL1, HCR controlled routing to EL2 has priority over SMD. */ >> > +if (!secure && cur_el == 1 && (env->cp15.hcr_el2 & HCR_TSC)) { >> > +env->excepti

[Qemu-devel] [PATCH v2 2/2] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Tony Breeds
try_fiemap() uses FIEMAP_FLAG_SYNC which has a significant performance impact. Prefer seek_hole() over fiemap() to avoid this impact where possible. seek_hole is more widely used and, arguably, has potential to be optimised in the kernel. Reported-By: Michael Steffens Signed-off-by: Tony Breeds

[Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap

2014-09-25 Thread Tony Breeds
Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter. Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl. This has the downside of significantly reducing performance. Reported-By: Michael Steffens Signed-off-by: Tony Breeds Cc: Kevin Wolf Cc: Markus Armbruster Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn

2014-09-25 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:01:11AM +0100, Peter Maydell wrote: > On 25 September 2014 23:20, Edgar E. Iglesias > wrote: > > On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote: > >> HCR.TGE isn't actually relevant for some exceptions > >> (eg SMC), and the HVC handling you have below >

Re: [Qemu-devel] [PATCH v6 10/10] target-arm: Add support for VIRQ and VFIQ

2014-09-25 Thread Edgar E. Iglesias
On Thu, Sep 25, 2014 at 08:36:41PM +0100, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Acked-by: Greg Bellows > > Signed-off-by: Edgar E. Iglesias > > --- > > cpu-exec.c | 12 > > target-arm/cpu.c

[Qemu-devel] [Patch v3 8/8] netduino2: Add the Netduino 2 Machine

2014-09-25 Thread Alistair Francis
This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis --- Changes from RFC: - Remove CPU passthrough hw/arm/Makefile.objs | 1 + hw/arm/netduino2.c | 54 +++

[Qemu-devel] [Patch v3 6/8] target_arm: Change the reset values based on the ELF entry

2014-09-25 Thread Alistair Francis
The Netduino 2 machine won't run unless the reset_pc is based on the ELF entry point. Signed-off-by: Alistair Francis Signed-off-by: Peter Crosthwaite --- V2: - Malloc straight away, thanks to Peter C hw/arm/armv7m.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(

[Qemu-devel] [Patch v3 7/8] stm32f205: Add the stm32f205 SoC

2014-09-25 Thread Alistair Francis
This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine. Signed-off-by: Alistair Francis --- Changes from RFC: - Small changes thanks to Peter C - Split the config settings to device level default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs

[Qemu-devel] [Patch v3 5/8] target_arm: Parameterise the irq lines for armv7m_init

2014-09-25 Thread Alistair Francis
This patch allows the board to specifiy the number of NVIC interrupt lines when using armv7m_init. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 7 --- hw/arm/stellaris.c | 5 - include/hw/arm/arm.h | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/

[Qemu-devel] [Patch v3 3/8] stm32f205_SYSCFG: Add the stm32f205 SYSCFG

2014-09-25 Thread Alistair Francis
This patch adds the stm32f205 System Configuration Controller. This is used to configure what memory is mapped at address 0 (although that is not supported) as well as configure how the EXTI interrupts work (also not supported at the moment). This device is not required for basic examples, but mor

[Qemu-devel] [Patch v3 2/8] stm32f205_USART: Add the stm32f205 USART Controller

2014-09-25 Thread Alistair Francis
This patch adds the stm32f205 USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis --- V3: - Update debug printing V2: - Drop charecters if the device is not enabled - Thanks to Peter C Changes from RFC: - Small changes thanks to Peter C - USART now imple

[Qemu-devel] [Patch v3 4/8] target_arm: Remove memory region init from armv7m_init

2014-09-25 Thread Alistair Francis
This patch moves the memory region init code from the armv7m_init function to the stellaris_init function Signed-off-by: Alistair Francis --- V3: - Rename the flash_size argument to mem_size - Remove the sram_size and related code - Thanks to Peter C V2: - Change the memory region names to

[Qemu-devel] [Patch v3 1/8] stm32f205_timer: Add the stm32f205 Timer

2014-09-25 Thread Alistair Francis
This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis --- V3: - Update debug statements - Correct the units for timer_mod - Correctly set timer_offset from resets V2: - Reorder the Makefile config - Fix up the debug printing - Correct the t

[Qemu-devel] [Patch v3 0/8] Netduino 2 Machine Model

2014-09-25 Thread Alistair Francis
This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at: https://github.com/alistair23/qemu/tree/netduino2.3 This patch series makes some changes to the armv7m_init function that allow

Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn

2014-09-25 Thread Peter Maydell
On 25 September 2014 23:20, Edgar E. Iglesias wrote: > On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote: >> HCR.TGE isn't actually relevant for some exceptions >> (eg SMC), and the HVC handling you have below >> effectively ends up ignoring the route_to_el2 >> information. That sugges

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Edgar E. Iglesias
On Thu, Sep 25, 2014 at 07:47:16PM +0100, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h | 1 + > > target-arm/helper-a64.c| 1 + > > target-arm/he

Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn

2014-09-25 Thread Edgar E. Iglesias
On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > > --- a/target-arm/helper.c > > +++ b/target-arm/helper.c > > @@ -3652,7 +3652,33 @@ void switch_mode(CPUARMState *env, int mode) > > */ > > unsigned int arm_excp_target

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Edgar E. Iglesias
On Thu, Sep 25, 2014 at 07:15:29PM +0100, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h| 19 ++- > > target-arm/helper.c | 35

[Qemu-devel] [PATCH] qemu-ga: added windows support for 'guest-network-get-interfaces'

2014-09-25 Thread Kenth Andersson
This is my first patch so I hope I got everything right. Signed-off-by: Kenth Andersson --- configure| 2 +- qga/commands-win32.c | 267 ++- 2 files changed, 266 insertions(+), 3 deletions(-) diff --git a/configure b/configure inde

Re: [Qemu-devel] [PATCH v3 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-25 Thread BenoƮt Canet
On Tue, Sep 23, 2014 at 03:36:03PM +0200, Kevin Wolf wrote: > Do we have a KVM Forum block layer agenda yet? I think this thread could > already contain a few topics to discuss there. Being the guy who constantly bring back painfull issues (Block filters, Block Backend) on the table I think we sho

[Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Jan Vesely
v2: rebase Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 467ec86..90746ed 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -566,9 +566,23

[Qemu-devel] [PATCH v2 3/3] usb-hid: Add high speed keyboard configuration

2014-09-25 Thread Jan Vesely
v2: rebase Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index a946528..7b67489 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @

[Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration

2014-09-25 Thread Jan Vesely
v2: add usb_mouse_properties use macros for bmAttributes v3: rebase v4: rebase Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 71 +++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index

[Qemu-devel] [ANNOUNCE] QEMU 2.1.2 Stable released

2014-09-25 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v2.1.2 stable release is now available at: http://wiki.qemu.org/download/qemu-2.1.2.tar.bz2 v2.1.2 is now tagged in the official qemu.git repository, and the stable-2.1 branch has been updated accordingly: http://git.qemu.org/?p=qemu.git;a

[Qemu-devel] vm fork

2014-09-25 Thread Tina Li
Hi,We are doing a project about using a customed command in qemu to fork the current vm. As only the current thread will be copied to the child process, so we need to create other threads. And the vm and vcpus need to be re-registered in the child process, and the IO thread also need to handled

[Qemu-devel] [RFC 00/10] Target-specific unit test support, add unit tests for target-i386/cpu.c code

2014-09-25 Thread Eduardo Habkost
This is an attempt to write unit tests for the target-i386/cpu.c code. By now, I just implemented 3 simple test cases, to ensure X86CPU objects can be created, and to ensure the CPU features are set properly depending on the CPU model table. Eduardo Habkost (10): tests: Add missing include to te

[Qemu-devel] [RFC 06/10] tests: Make test-x86-cpuid target-specific

2014-09-25 Thread Eduardo Habkost
Instead of using a test-specific hack to add -I$(SRC_PATH)/target-i386, add test-x86-cpuid to $(test-obj-x86_64-softmmu-y). Signed-off-by: Eduardo Habkost --- tests/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 95566d9..f

[Qemu-devel] [RFC 10/10] tests: test-x86-cpu: Add KVM feature bit initialization test

2014-09-25 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- tests/test-x86-cpu.c | 28 1 file changed, 28 insertions(+) diff --git a/tests/test-x86-cpu.c b/tests/test-x86-cpu.c index e8e9a74..afd5088 100644 --- a/tests/test-x86-cpu.c +++ b/tests/test-x86-cpu.c @@ -54,6 +54,33 @@ static void

[Qemu-devel] [RFC 04/10] tests: Move fake yield_until_fd_readable() to coroutine-stub.c

2014-09-25 Thread Eduardo Habkost
Other test code will use the function. Signed-off-by: Eduardo Habkost --- tests/Makefile | 1 + tests/coroutine-stub.c | 13 + tests/test-vmstate.c | 11 --- 3 files changed, 14 insertions(+), 11 deletions(-) create mode 100644 tests/coroutine-stub.c diff --git a

[Qemu-devel] [RFC 09/10] tests: test-x86-cpu: Add TCG feature bit initialization test

2014-09-25 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- tests/test-x86-cpu.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/test-x86-cpu.c b/tests/test-x86-cpu.c index 9227e20..e8e9a74 100644 --- a/tests/test-x86-cpu.c +++ b/tests/test-x86-cpu.c @@ -30,6 +30,30 @@ static void tes

[Qemu-devel] [RFC 08/10] target-i386: Isolate enabled-by-default features to a separate array

2014-09-25 Thread Eduardo Habkost
This will make it easier to write unit tests for the feature initialization logic. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 90d0a05..8d1af64 100644 --- a/targe

[Qemu-devel] [RFC 03/10] bitmap.h: Don't include qemu-common.h

2014-09-25 Thread Eduardo Habkost
This will avoid unexpected circular header dependencies in the future. Signed-off-by: Eduardo Habkost --- include/qemu/bitmap.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 1babd5d..8c50d70 100644 --- a/include/qemu/b

[Qemu-devel] [RFC 05/10] tests: Support target-specific unit tests

2014-09-25 Thread Eduardo Habkost
To make unit tests that depend on target-specific files, use check-unit--y and test-obj--y. Note that the qtest test cases were per-*arch* (e.g. i386, mips, ppc), not per-*target* (e.g. i386-softmmu, x86_64-linux-user), because they implicitly apply only to the -softmmu targets. Target-specific un

[Qemu-devel] [RFC 07/10] tests: Add unit test for X86CPU code

2014-09-25 Thread Eduardo Habkost
To allow the unit test file include target-i386/cpu.c code, lots of stub functions were needed to fulfill dependencies. The unit test includes target-i386/cpu.c instead of simply linking against cpu.o because the test code will use static variables/functions from cpu.c. Note: I couldn't add depen

[Qemu-devel] [RFC 02/10] bitops.h: Don't include qemu-common.h

2014-09-25 Thread Eduardo Habkost
This removes the following circular dependency: bitops.h -> qemu-common.h -> target-i386/cpu.h -> target-i386/cpu-qom.h -> qom/cpu.h -> qdev-core.h -> bitmap.h -> bitops.h. Signed-off-by: Eduardo Habkost --- include/qemu/bitops.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[Qemu-devel] [RFC 01/10] tests: Add missing include to test-bitops.c

2014-09-25 Thread Eduardo Habkost
The test code needs osdep.h for the ARRAY_SIZE macro. Signed-off-by: Eduardo Habkost --- tests/test-bitops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bitops.c b/tests/test-bitops.c index 8238eb5..47b5d3e 100644 --- a/tests/test-bitops.c +++ b/tests/test-bitops.c @@ -8,6 +8,

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-25 Thread minyard
From: Corey Minyard Adds a "reconnect" option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey Minyard --- qapi-sc

[Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-09-25 Thread minyard
From: Corey Minyard This way we can tell if the socket is connected or not. It also splits the string conversions out into separate functions to make this more convenient. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 102 --

[Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect

2014-09-25 Thread minyard
From: Corey Minyard Move all socket configuration to qmp_chardev_open_socket(). qemu_chr_open_socket_fd() just opens the socket. This is getting ready for the reconnect code, which will call open_sock_fd() on a reconnect attempt. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qe

[Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket

2014-09-25 Thread minyard
From: Corey Minyard It seems that it might be a good idea to know what is at the remote end of a socket for tracking down issues. So add that to the socket filename. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 27 ++- 1 file changed, 18 i

[Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver

2014-09-25 Thread minyard
From: Corey Minyard This keeps them from having to be passed around and makes them available for later functions, like printing and reconnecting. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 65 - 1 file

[Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define

2014-09-25 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 8623c70..f9d2a02 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -84,6 +84,7 @@ #def

[Qemu-devel] [PATCH v3 0/6] chardev: Add reconnecting to client sockets

2014-09-25 Thread minyard
I believe this fixes all identified issues. Thanks to all that have commented to help with this. -corey

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Greg Bellows
Thanks for the clarification. On 25 September 2014 14:53, Peter Maydell wrote: > On 25 September 2014 20:49, Greg Bellows wrote: > > Is it necessary to make SCR 64-bit if it is 32-bit on both v7 and v8? > > See previous round of reviews -- all AArch64 system registers > are 64 bits ("32 bit" in

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Peter Maydell
On 25 September 2014 20:49, Greg Bellows wrote: > Is it necessary to make SCR 64-bit if it is 32-bit on both v7 and v8? See previous round of reviews -- all AArch64 system registers are 64 bits ("32 bit" in the ARM ARM is just a shorthand for "64 bit with the top half RES0"; there is no "read 32

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Greg Bellows
Is it necessary to make SCR 64-bit if it is 32-bit on both v7 and v8? On 25 September 2014 13:15, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h| 19

Re: [Qemu-devel] [PATCH 2/2] iohandler: Add Linux implementation of iohandler GSource

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 19:21, Fam Zheng ha scritto: > +while (true) { > +r = epoll_pwait(s->epollfd.fd, events, MAX_EVENTS, 0, &origmask); You can save a syscall by doing this just once. You would just get a readable epoll file descriptor on the next main loop iteration. Also, origmask is an

Re: [Qemu-devel] [PATCH] kvm/valgrind: dont mark memory as initialized

2014-09-25 Thread Peter Maydell
On 25 September 2014 20:07, Christian Borntraeger wrote: > since commit 7dda5dc82a77 ("migration: initialize RAM to zero") the > guest memory is defined zero. No need to call valgrind on guest memory. > This reverts commit 62fe83318d2f ("qemu: Use valgrind annotations to > mark kvm guest memory as

Re: [Qemu-devel] [PATCH v6 10/10] target-arm: Add support for VIRQ and VFIQ

2014-09-25 Thread Peter Maydell
On 13 September 2014 05:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Acked-by: Greg Bellows > Signed-off-by: Edgar E. Iglesias > --- > cpu-exec.c | 12 > target-arm/cpu.c| 29 ++--- > target-arm/cpu.h| 36 +++

Re: [Qemu-devel] [PATCH v6 09/10] target-arm: Add IRQ and FIQ routing to EL2 and 3

2014-09-25 Thread Peter Maydell
On 13 September 2014 05:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Reviewed-by: Greg Bellows > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 12 > target-arm/helper.c | 14 ++ > 2 files changed, 26 insertions(+) > > diff --git a/targe

[Qemu-devel] [PATCH] kvm/valgrind: dont mark memory as initialized

2014-09-25 Thread Christian Borntraeger
since commit 7dda5dc82a77 ("migration: initialize RAM to zero") the guest memory is defined zero. No need to call valgrind on guest memory. This reverts commit 62fe83318d2f ("qemu: Use valgrind annotations to mark kvm guest memory as defined") thus speeding up kvm start if /valgrind/valgrind.h is a

[Qemu-devel] Intel Haswell : Cache monitoring technology and libvirt

2014-09-25 Thread Jd
Hi We are looking to get processor level cache metrics for each running VM. Does QEMU/KVM (or libvirt) set RMID for tagging processor cache metrics ? How do I find RMID for a particular VM ? (Once RMID is known, I am assuming we will be able to query the processor via MSRs to get values) Any he

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Peter Maydell
On 13 September 2014 05:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 6 ++ > target-arm/helper.h| 1 + > target-arm/inter

  1   2   3   >