On 09/12/14 21:59, Gabriel L. Somlo wrote:
> On Fri, Sep 12, 2014 at 08:26:01PM +0200, Paolo Bonzini wrote:
>> So it could be an OVMF bug related to multifunction devices.
>>
>> Well, you could try moving devices around in different functions.
>> You could try moving ehci1 to 0 and the UHCIs to 1/2
From: "Edgar E. Iglesias"
Acked-by: Greg Bellows
Signed-off-by: Edgar E. Iglesias
---
cpu-exec.c | 12
target-arm/cpu.c| 29 ++---
target-arm/cpu.h| 36 +---
target-arm/helper-a64.c | 2 ++
targe
From: "Edgar E. Iglesias"
Reviewed-by: Greg Bellows
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h| 12
target-arm/helper.c | 14 ++
2 files changed, 26 insertions(+)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index c24af40..a5123f8 100644
--- a/targe
From: "Edgar E. Iglesias"
Reviewed-by: Greg Bellows
Signed-off-by: Edgar E. Iglesias
---
cpu-exec.c | 5 ++---
target-arm/cpu.h | 15 +++
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index bd93165..d017588 100644
--- a/cpu-exec.c
++
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h | 1 +
target-arm/helper-a64.c| 1 +
target-arm/helper.c| 6 ++
target-arm/helper.h| 1 +
target-arm/internals.h | 6 ++
target-arm/op_helper.c | 26 +++
Signed-off-by: John Snow
---
hw/ide/ahci.c | 169 ++
1 file changed, 86 insertions(+), 83 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index e4eae0c..5bc5a92 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -936,10 +936,94 @@ st
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h | 1 +
target-arm/helper-a64.c| 1 +
target-arm/helper.c| 28 +++-
target-arm/helper.h| 1 +
target-arm/internals.h | 6 ++
target-arm/op_helper.c
From: "Edgar E. Iglesias"
Not all exception types update both FAR and ESR.
Reviewed-by: Alex Bennée
Reviewed-by: Greg Bellows
Signed-off-by: Edgar E. Iglesias
---
target-arm/helper-a64.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target-arm/helper-a64.c b/targ
Instead of checking for a known byte, inspect the
fields of this byte explicitly to produce more meaningful
error messages and improve the readability of this section.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff
This patch introduces a few changes to how FIS packets are
deciphered in the AHCI virtual device.
(1) Packets may now either update the Control register or
the Command register, but not both. This is according
to the SATA 3.2 specification which states:
"...the device either initiates
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h| 19 ++-
target-arm/helper.c | 35 +--
2 files changed, 51 insertions(+), 3 deletions(-)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 36507f9..c69d471 1
From: "Edgar E. Iglesias"
Reviewed-by: Alex Bennée
Reviewed-by: Greg Bellows
Reviewed-by: Peter Maydell
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index a5e8e0d..7f8a410 100644
--- a/tar
The SDB FIS creation was mangled;
We were writing the error byte to byte 0,
and omitting the SDB FIS magic byte.
Though the SDB packet layout states that:
byte 0: Must be 0xA1 to indicate SDB FIS.
byte 1: Port multiplier select & other flags
byte 2: status byte.
byte 3: error byte.
This patch add
The prepare_buf callback takes an argument named /is_write/,
however in core.c we are checking to see if this DMA command
is /is_read/. I am adding a small macro to correct this oversight.
Impact: Nothing, yet.
-The prepare_buf callback is only used in ahci and pci, and both
versions of this call
From: "Edgar E. Iglesias"
Introduce new_el and new_mode in preparation for future patches
that add support for taking exceptions to and from EL2 and 3.
No functional change.
Reviewed-by: Peter Maydell
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h| 7 +++
target-arm/helper
Error checking in ahci's handle_cmd is re-ordered so that we
initialize as few things as possible before we've done our
sanity checking. This simplifies returning from this call
in case of an error.
A check to make sure the DMA memory map succeeds with the
correct size is also added, and the debug
This impacts both BMDMA and AHCI HBA interfaces for IDE.
Currently, we confuse the difference between a PRD having
"0 bytes" and a PRD having "0 complete sectors."
This leads to, in the BMDMA case, leaked memory for short PRDTs,
and infinite loops in the AHCI case.
the "prepare_buf" callback is r
This patch series collects a number of fixes centered
around improving the AHCI device.
A number of them used to be tied to as-yet unposted
ahci-test patches, but I have separated them out
in order to post them standalone and collect feedback.
This series as a whole fixes a number of crashes,
bug
Several fields of the NCQFIS structure are
ambiguously named. This patch clarifies the
intended (if unsupported) usage of the NCQ
fields to aid in creating more meaningful
debug messages through the NCQ codepaths.
This patch also adds an is_ncq() helper to
avoid repetition for checking this proper
Currently, DMA read/write operations neglect to update
the byte count after a successful transfer like ATAPI
DMA read or PIO read/write operations do.
We correct this oversight by adding another callback into
the IDEDMAOps structure. The commit callback is called
whenever we are cleaning up a scat
From: "Edgar E. Iglesias"
Reviewed-by: Greg Bellows
Reviewed-by: Peter Maydell
Signed-off-by: Edgar E. Iglesias
---
target-arm/cpu.h| 36
target-arm/helper.c | 34 ++
2 files changed, 70 insertions(+)
diff --git a/targe
AHCI devices support a feature where individual entries in the
scatter-gather list may have interrupt request bits set, in order
to receive notification partway through a command that a portion
of a transfer has completed. AHCI specs refer to this as the
DPS bit or Descriptor Processed Status. It i
From: "Edgar E. Iglesias"
Hi,
This is a second round of AArch64 EL2/3 patches working on the exception
model. Among other things adding HVC/SMC, interrupt routing to EL2/3 and
Virtual IRQs/FIQs. The VIRQ/VFIQ support only adds the external signal
delivery method.
This conflicts slightly with th
When the command completion code in IDE and AHCI
was unified to put all command completion inside
of a callback, "cmd_done," we neglected to
ensure that all AHCI/ATAPI command paths would
eventually register as finished. for the PCI
interface to IDE this is not a problem because
cmd_done is a nop,
v2:
- Instead of using ide_set_inactive, use ide_stop_transfer
- ATAPI helpers use either ide_atapi_cmd_ok or ide_atapi_cmd_error,
instead of ide_stop_transfer directly.
John Snow (1):
ide/atapi: Mark non-data commands as complete
hw/ide/atapi.c | 7 +++
1 file changed, 3 insertions(
On Fri, Sep 12, 2014 at 6:05 PM, Paolo Bonzini wrote:
> Il 12/09/2014 03:39, TeLeMan ha scritto:
>> On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote:
>>> diff --git a/aio-win32.c b/aio-win32.c
>>> index 4542270..61e3d2d 100644
>>> --- a/aio-win32.c
>>> +++ b/aio-win32.c
>>> +bool was_dispa
Public bug reported:
-- Found in releases qemu-2.0.0, qemu-2.0.2, qemu-2.1.0. Tested on
Ubuntu 14.04 using Ext4 filesystems.
The command
qemu-img convert -O raw inputimage.qcow2 outputimage.raw
intermittently creates corrupted output images, when the input image is
not yet fully synchronized
** Also affects: nova
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in Open
On 12 September 2014 01:09, Gerd Hoffmann wrote:
> Hi folks,
>
> Lets kick off the virtio-gpu review process, starting with the virtio
> protocol.
>
> This is a tiny patch series for qemu. Patch #1 carries the header file
> describing the virtual hardware: config space, command structs being
>
>> Can the host refuse due to lack of resources?
>
> Yes. virtgpu_ctrl_hdr.type in the response will be set to
> VIRTGPU_RESP_ERR_* then. Current implementation does that only on
> malloc() failure, there is no accounting (yet) to limit the amout of
> memory the guest is allowed to allocate.
We
If memory allocation fails when using the -mem-prealloc command-line
option, QEMU exits without printing any error information to
the user:
# qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages
# echo $?
1
This commit adds an error message, so that we print instead:
# qemu [...] -m 1G -m
From: Gonglei
error: 'i' undeclared (first use in this function)
Signed-off-by: Gonglei
Signed-off-by: Luiz Capitulino
---
monitor.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 34cee74..667efb7 100644
--- a/monitor.c
+++ b/monitor.c
@
Two trivial fixes.
The following changes since commit 6cd14054b67774cc58a51fca6660cfa1d3c08059:
libqos virtio: Increase ISR timeout (2014-09-12 13:58:07 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
for you to fetch changes up to e4d9df4fb1
On Fri, Sep 12, 2014 at 08:26:01PM +0200, Paolo Bonzini wrote:
> So it could be an OVMF bug related to multifunction devices.
>
> Well, you could try moving devices around in different functions.
> You could try moving ehci1 to 0 and the UHCIs to 1/2/7.
>
> Or drop uhci2/uhci3 and move the two re
On 12.09.14 21:31, Pierre Mallard wrote:
> This patch series enable floating point instruction in 440x5 CPUs
> which have the capabilities to have optional APU FPU in double precision mode.
>
> 1) Allow fc[tf]id[*] mnemonics for non TARGET_PPC64 with a new insn2 flag
> 2) Create a new 440x5 impl
This patch remove limitation for fc[tf]id[*] on 32 bits targets and
add a new insn flag for signed integer 64 conversion PPC2_FP_CVT_S64
Signed-off-by: Pierre Mallard
---
target-ppc/cpu.h|5 -
target-ppc/fpu_helper.c |6 --
target-ppc/helper.h |2 --
t
This patch add a new processor type 440x5wDFPU for Virtex 5 PPC440
with an external APU FPU in double precision mode
Signed-off-by: Pierre Mallard
---
target-ppc/cpu-models.c |3 +++
target-ppc/translate_init.c | 38 ++
2 files changed, 41 insertions
This patch series enable floating point instruction in 440x5 CPUs
which have the capabilities to have optional APU FPU in double precision mode.
1) Allow fc[tf]id[*] mnemonics for non TARGET_PPC64 with a new insn2 flag
2) Create a new 440x5 implementing floating point instructions
Pierre Mallard
More random crap I ran into while iterating on BlockBackends.
Markus Armbruster (4):
blockdev: Disentangle BlockDriverState and DriveInfo creation
block: Keep DriveInfo alive until BlockDriverState dies
qemu-nbd: Destroy the BlockDriverState properly
block: Improve message for device name
Suggested-by: Benoit Canet
Signed-off-by: Markus Armbruster
---
block.c| 3 ++-
tests/qemu-iotests/087.out | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 6faf36f..02ea90f 100644
--- a/block.c
+++ b/block.c
@@ -347,7 +347,8 @@ Bl
No problem I repost, I triple check, hope this time everythng will be
correct, sorry for the extra work time ...
Pierre
On Fri, Sep 12, 2014 at 4:29 PM, Tom Musta wrote:
> On 9/11/2014 2:17 PM, Pierre Mallard wrote:
> > This patch series enable floating point instruction in 440x5 CPUs
> > which
blockdev_init() mixes up BlockDriverState and DriveInfo initialization
Finish the BlockDriverState job before starting to mess with
DriveInfo. Easier on the eyes.
Signed-off-by: Markus Armbruster
---
blockdev.c | 43 +++
1 file changed, 23 insertions(+),
If the BDS's refcnt > 0, drive_del() destroys the DriveInfo, but not
the BDS. This can happen in three places:
* Device model destruction during unplug: blockdev_auto_del()
* Xen IDE unplug: pci_piix3_xen_ide_unplug()
* drive_del command when no device model is attached: do_drive_del()
The oth
Match the bdrv_new() with a bdrv_unref(), just to be tidy.
Signed-off-by: Markus Armbruster
---
qemu-nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 9bc152e..f3cf8a2 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -769,7 +769,7 @@ int main(int
usb_msd_init() calls qemu_opts_create() with a made-up ID and false
fail_if_exists. If the ID already exists, it happily messes up those
options, then fails drive_new(), because the BlockDriverState with
that ID already exists, too.
Reproducer: -drive if=none,id=usb0,format=raw -usbdevice disk:tm
On 09/12/2014 12:08 PM, Paolo Bonzini wrote:
Il 12/09/2014 18:00, John Snow ha scritto:
When the command completion code in IDE and AHCI
was unified to put all command completion inside
of a callback, "cmd_done," we neglected to
ensure that all AHCI/ATAPI command paths would
eventually registe
Quoting Paolo Bonzini (2014-09-12 11:29:46)
> Il 12/09/2014 18:17, Michael Roth ha scritto:
> > Quoting Paolo Bonzini (2014-09-12 10:39:49)
> >> Il 12/09/2014 17:34, Michael Roth ha scritto:
> >>>
> >>> { 'union': 'UserDefUnion',
> >>> 'base': 'UserDefZero',
> >>> 'data': { 'a' : 'int', 'b' : '
Il 12/09/2014 20:18, Gabriel L. Somlo ha scritto:
>> > Now *that* is really strange, especially as UHCI1 is pci function 0,
>> > without probing that successfully you wouldn't see the other pci
>> > functions (1+2+7 for uhci2+uhci3+ehci) in the same slot in the first
>> > place.
> I've only ever sk
Hi Gerd,
On Fri, Sep 12, 2014 at 08:46:19AM +0200, Gerd Hoffmann wrote:
> > Obviously, since QEMU was routing the slow keyboard+mouse to UHCI1,
> > which for some reason gets masked when OVMF is used, things weren't
> > working.
>
> Try '-device usb-mouse,port=5 -device usb-kbd,port=6'. That lin
GDB assumes that watchpoint set via the gdbstub remote protocol will
behave in the same way as hardware watchpoints for the target. In
particular, whether the CPU stops with the PC before or after the insn
which triggers the watchpoint is target dependent. Allow guest CPU
code to specify which beha
On Fri, Sep 12, 2014 at 11:17:35AM +0200, BALATON Zoltan wrote:
> On Thu, 11 Sep 2014, Gabriel L. Somlo wrote:
> >On Thu, Sep 11, 2014 at 11:34:03PM +0200, Alexander Graf wrote:
> >>XNU also populates its device tree based on the DSDT. Maybe there's a
> >>subtle difference there?
> >
> >This was th
On Fri, 12 Sep 2014 20:01:04 +0300
Stratos Psomadakis wrote:
> On 12/09/2014 06:21 μμ, Luiz Capitulino wrote:
> > On Fri, 12 Sep 2014 17:07:32 +0300
> > Stratos Psomadakis wrote:
> >
> >> Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug
> >> in
> >> the way the HMP mon
On 12/09/2014 06:21 μμ, Luiz Capitulino wrote:
> On Fri, 12 Sep 2014 17:07:32 +0300
> Stratos Psomadakis wrote:
>
>> Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in
>> the way the HMP monitor handles its command buffer. When a client closes the
>> connection to the mo
Il 12/09/2014 18:17, Michael Roth ha scritto:
> Quoting Paolo Bonzini (2014-09-12 10:39:49)
>> Il 12/09/2014 17:34, Michael Roth ha scritto:
>>>
>>> { 'union': 'UserDefUnion',
>>> 'base': 'UserDefZero',
>>> 'data': { 'a' : 'int', 'b' : 'UserDefB' } }
>>>
>>> If UserDefUnion.a is 0, UserDefUnion
Quoting Paolo Bonzini (2014-09-12 10:39:49)
> Il 12/09/2014 17:34, Michael Roth ha scritto:
> >
> > { 'union': 'UserDefUnion',
> > 'base': 'UserDefZero',
> > 'data': { 'a' : 'int', 'b' : 'UserDefB' } }
> >
> > If UserDefUnion.a is 0, UserDefUnion.data will cast it to a NULL value and
> > caus
Il 12/09/2014 18:00, John Snow ha scritto:
> When the command completion code in IDE and AHCI
> was unified to put all command completion inside
> of a callback, "cmd_done," we neglected to
> ensure that all AHCI/ATAPI command paths would
> eventually register as finished. for the PCI
> interface t
Il 11/09/2014 10:47, Zhang Haoyu ha scritto:
> Currently, we call ioapic_service() immediately when we find the irq is still
> active during eoi broadcast. But for real hardware, there's some dealy between
> the EOI writing and irq delivery (system bus latency?). So we need to emulate
> this behavi
From: Hu Tao
preallocation=falloc allocates disk space by posix_fallocate(),
preallocation=full allocates disk space by writing zeros to disk.
Both modes imply preallocation=metadata.
Signed-off-by: Hu Tao
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 63 +
From: Hu Tao
This patch prepares for the subsequent patches.
Signed-off-by: Hu Tao
Reviewed-by: Max Reitz
Reviewed-by: Kevin Wolf
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 28 ++--
qapi/block-core.json | 17
When the command completion code in IDE and AHCI
was unified to put all command completion inside
of a callback, "cmd_done," we neglected to
ensure that all AHCI/ATAPI command paths would
eventually register as finished. for the PCI
interface to IDE this is not a problem because
cmd_done is a nop,
From: Markus Armbruster
For some device models, the guest can prevent unplug. Some users need a
way to forcibly revoke device model access to the block backend then, so
the underlying images can be safely used for something else.
drive_del lets you do that. Unfortunately, it conflates revoking
From: Stefan Hajnoczi
Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use
with operation blocker") broke the error path because it consumed
local_err instead of propagating it.
The caller has no way to know that the function failed. This caused
virtio-blk to start "successfu
From: Hu Tao
This patch adds a new option preallocation for raw format, and implements
falloc and full preallocation.
Signed-off-by: Hu Tao
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 92 +++
qemu-doc.texi |
From: Chrysostomos Nanakos
Run resize grow test to ensure that existing data
is not lost during grow and new space is zeroed.
Signed-off-by: Chrysostomos Nanakos
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/025 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu
From: Stratos Psomadakis
Make sure to pass the correct fd via SCM_RIGHTS in socket_scm_helper.c
(i.e. fd_to_send, not socket-fd).
Signed-off-by: Stratos Psomadakis
Signed-off-by: Dimitris Aragiorgis
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/socket_scm_helper.c | 2 +-
1 file changed,
From: Luiz Capitulino
BLOCK_IO_ERROR events are logged by libvirt, which helps with
post mortem analysis of guests. However, one information that
we miss today is a human readable string describing the cause
of the I/O error.
This commit adds that string it to BLOCK_IO_ERROR. Note that
this stri
From: Hu Tao
Currently the file size requested by user is rounded down to nearest
sector, causing the actual file size could be a bit less than the size
user requested. Since some formats (like qcow2) record virtual disk
size in bytes, this can make the last few bytes cannot be accessed.
This pa
From: Benoît Canet
Extract the block accounting statistics into a structure so the block device
models can hold them in the future.
CC: Kevin Wolf
CC: Stefan Hajnoczi
CC: Max Reitz
CC: Eric Blake
Signed-off-by: Benoît Canet
Signed-off-by: Kevin Wolf
---
block.c | 11 +++
From: Chrysostomos Nanakos
Signed-off-by: Chrysostomos Nanakos
Signed-off-by: Kevin Wolf
---
block/archipelago.c | 63 +++--
1 file changed, 61 insertions(+), 2 deletions(-)
diff --git a/block/archipelago.c b/block/archipelago.c
index 22a7daa..4
From: Hu Tao
and avoid converting it back later.
Signed-off-by: Hu Tao
Reviewed-by: Max Reitz
Reviewed-by: Benoît Canet
Signed-off-by: Kevin Wolf
---
block/gluster.c | 9 -
block/qcow.c | 8
block/qcow2.c | 10 +-
block/raw-posix.c | 12 ++--
bl
From: Markus Armbruster
Dragging block_int.h into a header is *not* nice. Fortunately, this
is the only offender.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
include/block/thread-pool.h | 6 +-
thread-pool.c | 1 -
2 files changed, 1 insertion(+), 6 delet
From: Luiz Capitulino
Management software, such as RHEV's vdsm, want to be able to allocate
disk space on demand. The basic use case is to start a VM with a small
disk and then the disk is enlarged when QEMU hits a ENOSPC condition.
To this end, the management software has to be notified when QE
From: Benoît Canet
This is the next step for decoupling block accounting functions from
BlockDriverState.
In a future commit the BlockAcctStats structure will be moved from
BlockDriverState to the device models structures.
Note that bdrv_get_stats was introduced so device models can retrieve the
From: Markus Armbruster
Commit 6db9560 split off the growable case so it can use
bdrv_file_open() instead of bdrv_open() then. Growable BDSes become
anonymous. Weird.
Commit 2e40134 folded bdrv_file_open() back into bdrv_open() with new
flag BDRV_O_PROTOCOL. We still have two bdrv_open() call
From: Benoît Canet
The middle term goal is to move the BlockAcctStats structure in the device
models.
(Capturing I/O accounting statistics in the device models is good for billing)
This patch make a small step in this direction by removing a reference to BDRV.
CC: Kevin Wolf
CC: Stefan Hajnocz
From: Valentin Manea
Set the IDE MMIO memory type to little endian. The ATA specs identify
words part of the control commands encoded as little endian.
While this has no impact on little endian systems, it's required for big
endian systems(eg OpenRisc).
Signed-off-by: Valentin Manea
Signed-off-
From: Markus Armbruster
drive_del() closes just fine.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/ide/piix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index 59319eb..49e78a7 100644
--- a/hw/ide/piix.c
+++ b/hw/ide/piix.c
@@ -182,7 +
From: Markus Armbruster
The Error object was leaked after failed bdrv_new(). While there,
streamline control flow a bit.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/block/xen_disk.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
From: Xiaodong Gong
cpu_to_be32() is wrong since vhd_type is an enum constant
(just a regular CPU-endian integer).
Signed-off-by: Xiaodong Gong
Signed-off-by: Kevin Wolf
---
block/vpc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index
From: Benoît Canet
The plan is to add new accounting metrics (latency, invalid requests, failed
requests, queue depth) and block.c is overpopulated so it will be better to work
in a separate module.
Moreover the long term plan is to have statistics in each of the BDS of the
graph
for metrology
The following changes since commit 10601bef566461efbea81ee344ed3355ce71954a:
Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into
staging (2014-09-09 15:08:05 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to
h 'remotes/kraxel/tags/pull-console-20140905-2'
> into staging (2014-09-11 11:44:17 +0100)
>
> are available in the git repository at:
>
>
> git://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/pull-target-arm-20140912
>
> for you to fetch changes up to 92d
On 12.09.14 17:28, Alex Williamson wrote:
> On Fri, 2014-09-12 at 16:27 +0530, Nikunj A Dadhania wrote:
>> The PCI MMIO might be disabled or the device in the reset state.
>> Make sure we do not dump these memory regions.
>>
>> Signed-off-by: Nikunj A Dadhania
I think you want to CC Paolo, as a
On Fri, Sep 12, 2014 at 12:37 PM, Richard Henderson wrote:
> Alpha do_interrupt doesn't mess with cpu->interrupt_request at all, and
> doesn't
> generate two calls to do_interrupt. The one call finds the vector for the
> given interrupt, modifies the PC, and swaps to the shadow register bank.
>
On 09/12/2014 07:14 AM, Claudio Fontana wrote:
>> > +++ b/tcg/tcg.h
>> > @@ -194,7 +194,6 @@ typedef struct TCGPool {
>> > typedef enum TCGType {
>> > TCG_TYPE_I32,
>> > TCG_TYPE_I64,
>> > -TCG_TYPE_COUNT, /* number of different types */
>> >
>> > /* An alias for the size of t
On Fri, 2014-09-12 at 16:27 +0530, Nikunj A Dadhania wrote:
> The PCI MMIO might be disabled or the device in the reset state.
> Make sure we do not dump these memory regions.
>
> Signed-off-by: Nikunj A Dadhania
> ---
Looks ok to me.
Acked-by: Alex Williamson
> V1:
>* Make the flag gene
Il 12/09/2014 17:34, Michael Roth ha scritto:
>
> { 'union': 'UserDefUnion',
> 'base': 'UserDefZero',
> 'data': { 'a' : 'int', 'b' : 'UserDefB' } }
>
> If UserDefUnion.a is 0, UserDefUnion.data will cast it to a NULL value and
> cause the output visitor to bail, when really it should just be
On 09/12/2014 07:33 AM, Martin Galvan wrote:
> On Thu, Sep 11, 2014 at 8:52 PM, Richard Henderson wrote:
>> On 09/11/2014 03:13 PM, Peter Maydell wrote:
>> In particular, I'd expect the invalid exception to be recognized, and then
>> the
>> cpu loop exited, before the single-step exception could
I have tested with 3.11 kernel, Kernel should be fine.. But it wouldn't
harm testing with latest kernel, may be it can provide some extra hints..
Anshul Makkar
On Fri, Sep 12, 2014 at 3:52 PM, Bharata B Rao
wrote:
> On Fri, Sep 12, 2014 at 4:23 PM, Anshul Makkar
> wrote:
> > During plugging we
Quoting Paolo Bonzini (2014-09-12 05:17:12)
> Il 12/09/2014 01:20, Michael Roth ha scritto:
> > In some cases an input visitor might bail out on filling out a
> > struct for various reasons, such as missing fields when running
> > in strict mode. In the case of a QAPI Union type, this may lead
> >
Quoting Eric Blake (2014-09-11 21:29:24)
> On 09/11/2014 05:20 PM, Michael Roth wrote:
> > In some cases an input visitor might bail out on filling out a
> > struct for various reasons, such as missing fields when running
> > in strict mode. In the case of a QAPI Union type, this may lead
> > to ca
On Fri, 12 Sep 2014 17:07:32 +0300
Stratos Psomadakis wrote:
> Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in
> the way the HMP monitor handles its command buffer. When a client closes the
> connection to the monitor, tcp_chr_read() will detect the G_IO_HUP conditio
Is there a minimum version of qemu that would be required to use the
FIEMAP_FLAG_SYNC flag?
** Changed in: nova
Status: New => Triaged
** Changed in: nova
Importance: Undecided => Medium
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscri
On Wed, 10 Sep 2014 19:03:50 +0800
zhanghailiang wrote:
> The second parameter of dump_error is unused, but one purpose of
> using this function is to report the error info.
>
> Use error_set to return the error info to the caller.
This is a very good change, but it turns out it needs more work
On 11 September 2014 16:21, Gerd Hoffmann wrote:
> pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> We don't check for a minimum version.
> RHEL-6 is probably older.
Ubuntu LTS hits this too.
> Try 'configure --without-system-pixman' as workaround (after checking
> out the pixma
On 12.09.14 16:40, Tom Musta wrote:
> On 9/12/2014 9:28 AM, Tom Musta wrote:
>> On 9/11/2014 2:17 PM, Pierre Mallard wrote:
>>> This patch remove limitation for fc[tf]id[*] on 32 bits targets and
>>> add a new insn flag for signed integer 64 conversion PPC2_FP_CVT_S64
>>> ---
>>> target-ppc/cpu.
The qemu-aarch64 and qemu-system-aarch64 binaries include support
for all the 32 bit ARM CPUs as well as the 64 bit ones. This means
we need to build in the GDB XML files for the 32 bit CPUs too.
Otherwise gdb will complain:
warning: while parsing target description (at line 1): Could not load XML
Il 08/07/2014 12:34, Fabio Fantoni ha scritto:
Il 08/07/2014 12:06, Fabio Fantoni ha scritto:
Il 08/07/2014 10:53, David Jaša ha scritto:
Hi,
On Út, 2014-07-08 at 10:13 +0200, Fabio Fantoni wrote:
On xen 4.5 (tried with qemu 2.0.0/2.1-rc0, spice 0.12.5 and client
with
spice-gtk 0.23/0.25) wi
On 9/11/2014 2:17 PM, Pierre Mallard wrote:
> This patch add a new processor type 440x5wDFPU for Virtex 5 PPC440
> with an external APU FPU in double precision mode
> ---
> target-ppc/cpu-models.c |3 +++
> target-ppc/translate_init.c | 38 ++
> 2 file
On 9/12/2014 9:28 AM, Tom Musta wrote:
> On 9/11/2014 2:17 PM, Pierre Mallard wrote:
>> This patch remove limitation for fc[tf]id[*] on 32 bits targets and
>> add a new insn flag for signed integer 64 conversion PPC2_FP_CVT_S64
>> ---
>> target-ppc/cpu.h|5 -
>> target-ppc/fpu_
1 - 100 of 268 matches
Mail list logo
