[Qemu-devel] [PATCH] qemu-io: initialize progname with error_set_progname()

2014-08-10 Thread Hitoshi Mitake
Calling error_get_progname() in the context of qemu-io can cause segmentation fault because qemu-io doesn't initialize its progname with error_set_progname(). This patch adds the initialization. Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hitoshi Mitake --- qemu-io.c | 1 + 1 file change

Re: [Qemu-devel] [patch] qcow2: double free snapshots

2014-08-10 Thread Zhang Haoyu
>Hi, > >> Subject: [Qemu-devel] [patch] qcow2: double free snapshots >> >> In qcow2_open(), if qcow2_read_snapshots() failed, qcow2_open() -> >> qcow2_free_snapshots() will be called, NULL snapshots dereference happened. >> because qcow2_free_snapshots has been performed before in the fail case of

Re: [Qemu-devel] USB PCI host bus adapter hot plug

2014-08-10 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] USB PCI host bus adapter hot plug > > Hi! > > I noticed that QMP's "device_add usb-ehci,id=i2,bus=pci.0" fails on PCI > hotplug. The same for pci-ohci and this is because their initfn() do > "dc->hotpluggable = false". So I removed those and now I can hotplug USB >

[Qemu-devel] [PATCH v3 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-10 Thread Hitoshi Mitake
Recently, sheepdog revived its VDI locking functionality. This patch updates sheepdog driver of QEMU for this feature. It changes an error code for a case of failed locking. -EBUSY is a suitable one. Reported-by: Valerio Pachera Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Liu Yuan Cc: MORITA Kazuta

[Qemu-devel] [PATCH v3 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Hitoshi Mitake
The update is required for supporting iSCSI multipath. It doesn't affect behavior of QEMU driver but adding a new field to vdi request struct is required. Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Liu Yuan Cc: MORITA Kazutaka Signed-off-by: Hitoshi Mitake --- block/sheepdog.c | 8 +++- 1 fi

[Qemu-devel] [PATCH v3 0/2] sheepdog driver update related to VDI locking feature

2014-08-10 Thread Hitoshi Mitake
Recently, sheepdog revived VDI locking functionality. This patchset updates sheepdog driver of QEMU for this feature. v3: - keep backward compatibility v2: - don't handle SD_RES_VDI_NOT_LOCKED as a special case Hitoshi Mitake (2): sheepdog: adopting protocol update for VDI locking sheep

[Qemu-devel] USB PCI host bus adapter hot plug

2014-08-10 Thread Alexey Kardashevskiy
Hi! I noticed that QMP's "device_add usb-ehci,id=i2,bus=pci.0" fails on PCI hotplug. The same for pci-ohci and this is because their initfn() do "dc->hotpluggable = false". So I removed those and now I can hotplug USB hosts but none of them is able to actually work: root@aiktest-le:~# echo 1 >/

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Liu Yuan
On Mon, Aug 11, 2014 at 11:34:56AM +0800, Liu Yuan wrote: > On Mon, Aug 11, 2014 at 11:17:33AM +0900, Hitoshi Mitake wrote: > > At Fri, 8 Aug 2014 15:49:37 +0800, > > Liu Yuan wrote: > > > > > > On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: > > > > At Fri, 8 Aug 2014 13:20:39 +08

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Liu Yuan
On Mon, Aug 11, 2014 at 11:17:33AM +0900, Hitoshi Mitake wrote: > At Fri, 8 Aug 2014 15:49:37 +0800, > Liu Yuan wrote: > > > > On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: > > > At Fri, 8 Aug 2014 13:20:39 +0800, > > > Liu Yuan wrote: > > > > > > > > On Thu, Aug 07, 2014 at 04:

[Qemu-devel] [PATCH v2 0/2] sheepdog driver update related to VDI locking feature

2014-08-10 Thread Hitoshi Mitake
Recently, sheepdog revived VDI locking functionality. This patchset updates sheepdog driver of QEMU for this feature. v2: - don't handle SD_RES_VDI_NOT_LOCKED as a special case Hitoshi Mitake (2): sheepdog: adopting protocol update for VDI locking sheepdog: improve error handling for a case

[Qemu-devel] [PATCH v2 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-10 Thread Hitoshi Mitake
Recently, sheepdog revived its VDI locking functionality. This patch updates sheepdog driver of QEMU for this feature. It changes an error code for a case of failed locking. -EBUSY is a suitable one. Reported-by: Valerio Pachera Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Liu Yuan Cc: MORITA Kazuta

[Qemu-devel] [PATCH v2 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Hitoshi Mitake
The update is required for supporting iSCSI multipath. It doesn't affect behavior of QEMU driver but adding a new field to vdi request struct is required. Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Liu Yuan Cc: MORITA Kazutaka Signed-off-by: Hitoshi Mitake --- block/sheepdog.c | 8 +++- 1 fi

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-10 Thread Chen, Tiejun
On 2014/8/11 4:27, Michael S. Tsirkin wrote: On Thu, Aug 07, 2014 at 09:40:49AM +0800, Chen, Tiejun wrote: On 2014/8/7 5:07, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 06:17:02PM +0800, Chen, Tiejun wrote: On 2014/8/6 17:45, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 02:50:33P

Re: [Qemu-devel] [RFC PATCH v3 1/6] QEMUSizedBuffer/QEMUFile

2014-08-10 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Sanidhya Kashyap > Sent: Saturday, August 09, 2014 2:27 PM > To: qemu list > Cc: Sanidhya Kashyap; Joel Schopp; Stefan Berger; D

Re: [Qemu-devel] [PATCH 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-10 Thread Hitoshi Mitake
At Fri, 8 Aug 2014 14:43:16 +0800, Liu Yuan wrote: > > On Fri, Aug 08, 2014 at 03:17:59PM +0900, Hitoshi Mitake wrote: > > At Fri, 8 Aug 2014 13:31:39 +0800, > > Liu Yuan wrote: > > > > > > On Thu, Aug 07, 2014 at 04:28:40PM +0900, Hitoshi Mitake wrote: > > > > Recently, sheepdog revived its VDI

Re: [Qemu-devel] [patch] qcow2: double free snapshots

2014-08-10 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [patch] qcow2: double free snapshots > > In qcow2_open(), if qcow2_read_snapshots() failed, qcow2_open() -> > qcow2_free_snapshots() will be called, NULL snapshots dereference happened. > because qcow2_free_snapshots has been performed before in the fail case of > qcow

[Qemu-devel] [PATCH] memory: Update obsolete comment about AddrRange field type

2014-08-10 Thread Fam Zheng
We are not 64 bit any more since 08dafab4 memory: use 128-bit integers for sizes and intermediates but the comment is forgotten to be updated. Signed-off-by: Fam Zheng --- memory.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 64d7176..dbe6675

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Hitoshi Mitake
At Fri, 8 Aug 2014 15:49:37 +0800, Liu Yuan wrote: > > On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: > > At Fri, 8 Aug 2014 13:20:39 +0800, > > Liu Yuan wrote: > > > > > > On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote: > > > > The update is required for supporti

Re: [Qemu-devel] [PATCH] test-coroutine: add baseline test that times the cost of function calls

2014-08-10 Thread Ming Lei
Hi, On Wed, Aug 6, 2014 at 5:33 PM, Paolo Bonzini wrote: > This can be used to compute the cost of coroutine operations. In the > end the cost of the function call is a few clock cycles, so it's pretty > cheap for now, but it may become more relevant as the coroutine code > is optimized. > > For

Re: [Qemu-devel] [RFC PATCH 00/10] spapr: vfio: Enable Dynamic DMA windows (DDW)

2014-08-10 Thread Alexey Kardashevskiy
On 08/05/2014 11:30 AM, Alexey Kardashevskiy wrote: > On 07/31/2014 07:34 PM, Alexey Kardashevskiy wrote: >> At the moment sPAPR PHB supports only a single 32bit window >> which is normally 1..2GB which is not enough for high performance devices. >> >> PAPR spec enables creating an additional windo

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-10 Thread Michael S. Tsirkin
On Thu, Aug 07, 2014 at 09:40:49AM +0800, Chen, Tiejun wrote: > > > On 2014/8/7 5:07, Michael S. Tsirkin wrote: > >On Wed, Aug 06, 2014 at 06:17:02PM +0800, Chen, Tiejun wrote: > >>On 2014/8/6 17:45, Michael S. Tsirkin wrote: > >>>On Wed, Aug 06, 2014 at 02:50:33PM +0800, Tiejun Chen wrote: > >>>

Re: [Qemu-devel] [PATCH 0/2] tpm: acpi generation tweaks

2014-08-10 Thread Michael S. Tsirkin
On Fri, Aug 08, 2014 at 03:25:46PM -0400, Stefan Berger wrote: > On 07/30/2014 07:34 AM, Michael S. Tsirkin wrote: > >This tweaks tpm code slightly for readability > >and robustness. On top of Stefen's patches. > > Are you going to upstream my patches and yours ? > >Stefan Weren't there any

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-08-10 Thread Paolo Bonzini
Il 10/08/2014 13:32, Gal Hammer ha scritto: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table. > > The GUID is set using a new "-vmgenid" command line parameter. > > Signed-off-by

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-08-10 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468..88314f

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-08-10 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a new "-vmgenid" command line parameter. Signed-off-by: Gal Hammer --- hw/i386/acpi-build.c | 23

[Qemu-devel] [PATCH 0/2] Virtual Machine Generation ID

2014-08-10 Thread Gal Hammer
Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The first one add a new ACPI directive which allow to use a 16-bytes buffer in an ACPI table. This buffer is for storing the VM's UUID. The second is the ACPI tables changes and the required command