Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-08-01 Thread Jan Kiszka
On 2014-08-01 19:16, Alex Williamson wrote: >> Also, it may let some of our device >> models deviate from their real versions (I suppose, e.g., none of the >> e1000 devices we currently emulate exposed FLR). > > Of course, but what are the chances that the driver will care? No drivers of GPOSes,

[Qemu-devel] [PATCH target-arm] arm: armv7m: Respect elf entry point

2014-08-01 Thread Peter Crosthwaite
ARMv7M has it's own bootloader (separate from the regular ARM bootloader) that is elf aware. It is able to load elfs but it does not set the program counter to the elf entry point. Make it more consistent with the regular ARM bootloader by setting the program counter to the given elf entry point.

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-08-01 Thread Ming Lei
On Sat, Aug 2, 2014 at 12:03 AM, Stefan Hajnoczi wrote: > On Fri, Aug 01, 2014 at 10:52:55PM +0800, Ming Lei wrote: >> On Fri, Aug 1, 2014 at 9:48 PM, Ming Lei wrote: >> > On Fri, Aug 1, 2014 at 9:13 PM, Stefan Hajnoczi >> > wrote: >> >> On Fri, Aug 01, 2014 at 10:54:02AM +0800, Ming Lei wrote:

[Qemu-devel] [PATCH v2 7/7] iotests: Expand test 061

2014-08-01 Thread Max Reitz
Add some tests for progress output to 061. Signed-off-by: Max Reitz --- tests/qemu-iotests/061 | 25 + tests/qemu-iotests/061.out | 30 ++ tests/qemu-iotests/group | 2 +- 3 files changed, 56 insertions(+), 1 deletion(-) diff --git a/te

[Qemu-devel] [PATCH v2 5/7] block/qcow2: Make get_refcount() global

2014-08-01 Thread Max Reitz
Reading the refcount of a cluster is an operation which can be useful in all of the qcow2 code, so make that function globally available. While touching this function, amend the comment describing the "addend" parameter: It is (no longer, if it ever was) necessary to have it set to -1 or 1; any va

[Qemu-devel] [PATCH v2 6/7] block/qcow2: Simplify shared L2 handling in amend

2014-08-01 Thread Max Reitz
Currently, we have a bitmap for keeping track of which clusters have been created during the zero cluster expansion process. This was necessary because we need to properly increase the refcount for shared L2 tables. However, now we can simply take the L2 refcount and use it for the cluster allocat

[Qemu-devel] [PATCH v2 4/7] block/qcow2: Implement status CB for amend

2014-08-01 Thread Max Reitz
The only really time-consuming operation potentially performed by qcow2_amend_options() is zero cluster expansion when downgrading qcow2 images from compat=1.1 to compat=0.10, so report status of that operation and that operation only through the status CB. For this, approximate the progress as th

[Qemu-devel] [PATCH v2 2/7] qemu-img: Add progress output for amend

2014-08-01 Thread Max Reitz
Now that bdrv_amend_options() supports a status callback, use it to display a progress report. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 25 ++--- qemu-img.texi| 2 +- 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/qemu-

[Qemu-devel] [PATCH v2 0/7] block/qcow2: Improve zero cluster expansion

2014-08-01 Thread Max Reitz
The main purpose of this series is to add a progress report to qemu-img amend. This is achieved by adding a callback function to bdrv_amend_options() - the reasons for this choice are explained in patch 1. While adapting qcow2's expand_zero_clusters_in_l1() accordingly, I noticed a way to simplify

[Qemu-devel] [PATCH v2 1/7] block: Add status callback to bdrv_amend_options()

2014-08-01 Thread Max Reitz
Depending on the changed options and the image format, bdrv_amend_options() may take a significant amount of time. In these cases, a way to be informed about the operation's status is desirable. Since the operation is rather complex and may fundamentally change the image, implementing it as AIO or

[Qemu-devel] [PATCH v2 3/7] qemu-img: Fix insignificant memleak

2014-08-01 Thread Max Reitz
As soon as options is set in img_amend(), it needs to be freed before the function returns. This leak is rather insignificant, as qemu-img will exit subsequently anyway, but there's no point in not fixing it. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- qemu-i

Re: [Qemu-devel] [PATCH 26/28] ahci: Add test_hba_spec to ahci-test.

2014-08-01 Thread John Snow
On 07/31/2014 10:01 AM, Stefan Hajnoczi wrote: On Mon, Jul 07, 2014 at 02:18:07PM -0400, John Snow wrote: +/*** IO macros for the AHCI memory registers. ***/ +#define void_incr(vptr, OFST) ((void *)((char *)(vptr) + (OFST))) I'm pretty sure QEMU takes advantage of GCC's void pointer arithmetic

Re: [Qemu-devel] [PATCH v2 7/7] target-arm: Call the pmccntr_sync function when swapping ELs

2014-08-01 Thread Peter Crosthwaite
On Sat, Aug 2, 2014 at 1:35 AM, Peter Maydell wrote: > On 26 June 2014 06:02, Alistair Francis wrote: >> Call the new pmccntr_sync() function when there is a possibility >> of swapping ELs (I.E. when there is an exception) >> >> Signed-off-by: Alistair Francis >> --- >> >> target-arm/helper-a64

Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-08-01 Thread Le Tan
2014-08-01 23:25 GMT+08:00 Alex Williamson : > On Fri, 2014-08-01 at 09:35 +0800, Le Tan wrote: >> Hi Alex, >> >> 2014-07-30 22:46 GMT+08:00 Alex Williamson : >> > On Wed, 2014-07-30 at 22:16 +0800, Le Tan wrote: >> >> Hi Michael, >> >> >> >> 2014-07-30 21:16 GMT+08:00 Michael S. Tsirkin : >> >> >

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.1.0 is now available

2014-08-01 Thread Peter Maydell
On 1 August 2014 17:41, Michael Roth wrote: > On behalf of the QEMU Team, I'd like to announce the availability of > the QEMU 2.1.0 release. This release contains 2200+ commits from 180 > authors. > Thank you to everyone involved! Yep, thanks to everybody who helped get this one out of the door;

Re: [Qemu-devel] [PATCH v2 0/5] AArch64 TLB performance improvements

2014-08-01 Thread Peter Maydell
On 1 August 2014 17:06, Peter Maydell wrote: > I'm taking the first two of these into target-arm.next because > they're obvious standalone bugfixes. I need to think about the > last three a bit more: I dislike just dropping the ARMv5 CPUs > from qemu-system-aarch64, it's kind of arbitrary. So: *

Re: [Qemu-devel] [PATCH alt 6/7] block/qcow2: Simplify shared L2 handling in amend

2014-08-01 Thread Max Reitz
On 31.07.2014 10:24, Benoît Canet wrote: The Saturday 26 Jul 2014 à 21:22:10 (+0200), Max Reitz wrote : Currently, we have a bitmap for keeping track of which clusters have been created during the zero cluster expansion process. This was necessary because we need to properly increase the refcou

Re: [Qemu-devel] [PATCH alt 4/7] block/qcow2: Implement status CB for amend

2014-08-01 Thread Max Reitz
On 01.08.2014 22:38, Eric Blake wrote: On 08/01/2014 02:18 PM, Max Reitz wrote: +if (status_cb) { +status_cb(bs, *visited_l1_entries << (s->l2_bits + s->cluster_bits), + l1_entries << (s->l2_bits + s->cluster_bits)); Shifting is a multiplication so it k

Re: [Qemu-devel] about -enable-kvm options

2014-08-01 Thread Richard W.M. Jones
On Fri, Aug 01, 2014 at 11:15:29AM +0800, Gareth wrote: > Hi all > > What does '-enable-kvm' option mean? I have heard two versions of answers: It's a shortcut for: $qemu -machine accel=kvm > a) guest OS would have /dev/kvm device and which could help vm in guest OS > (nested vm) That's nest

Re: [Qemu-devel] [PATCH alt 4/7] block/qcow2: Implement status CB for amend

2014-08-01 Thread Eric Blake
On 08/01/2014 02:18 PM, Max Reitz wrote: >>> +if (status_cb) { >>> +status_cb(bs, *visited_l1_entries << (s->l2_bits + >>> s->cluster_bits), >>> + l1_entries << (s->l2_bits + s->cluster_bits)); >> Shifting is a multiplication so it keep proportionality inta

Re: [Qemu-devel] [PATCH alt 7/7] iotests: Expand test 061

2014-08-01 Thread Max Reitz
On 31.07.2014 10:30, Benoît Canet wrote: The Saturday 26 Jul 2014 à 21:22:11 (+0200), Max Reitz wrote : Add some tests for progress output to 061. Signed-off-by: Max Reitz --- tests/qemu-iotests/061 | 27 +++ tests/qemu-iotests/061.out | 32 ++

Re: [Qemu-devel] [PATCH alt 4/7] block/qcow2: Implement status CB for amend

2014-08-01 Thread Max Reitz
On 31.07.2014 10:06, Benoît Canet wrote: The Saturday 26 Jul 2014 à 21:22:08 (+0200), Max Reitz wrote : The only really time-consuming operation potentially performed by qcow2_amend_options() is zero cluster expansion when downgrading qcow2 images from compat=1.1 to compat=0.10, so report status

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-01 Thread Michael Tokarev
02.08.2014 00:10, John Snow wrote: [] > For at least the immediate future, the AHCI device doesn't support the > mixed-mode SATA/PATA access models, though I suppose we could, it seems like > a more obvious and simple solution to just allow the shorthand syntactic > sugar commands to use the nat

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-01 Thread John Snow
On 06/12/2014 05:03 AM, Markus Armbruster wrote: Michael Tokarev writes: 10.06.2014 10:34, Paolo Bonzini wrote: Il 10/06/2014 08:30, Michael Tokarev ha scritto: Hello. The question is: are the drive shortcuts - -cdrom, -hda, -hdb etc - supposed to work in -machine q35 too? Or are they mer

Re: [Qemu-devel] [PATCH alt 2/7] qemu-img: Add progress output for amend

2014-08-01 Thread Max Reitz
On 31.07.2014 09:56, Benoît Canet wrote: The Saturday 26 Jul 2014 à 21:22:06 (+0200), Max Reitz wrote : Now that bdrv_amend_options() supports a status callback, use it to display a progress report. Signed-off-by: Max Reitz --- qemu-img.c | 26 +++--- 1 file changed, 23

Re: [Qemu-devel] [PATCH alt 1/7] block: Add status callback to bdrv_amend_options()

2014-08-01 Thread Max Reitz
On 31.07.2014 09:51, Benoît Canet wrote: The Saturday 26 Jul 2014 à 21:22:05 (+0200), Max Reitz wrote : Depending on the changed options and the image format, bdrv_amend_options() may take a significant amount of time. In these cases, a way to be informed about the operation's status is desirab

Re: [Qemu-devel] [PATCH v2 0/5] AArch64 TLB performance improvements

2014-08-01 Thread Paolo Bonzini
Il 30/07/2014 17:20, Alex Bennée ha scritto: > Hi, > > Not too much has changed: > > * added a review tag > * fixed up review comments > * added some notes about benchmark results > * added a patch to disable ARMv5 in AArch64 build > > The most important thing is I've measured a 25-30% i

[Qemu-devel] [PATCH] l2tpv3 (configure): it is linux-specific

2014-08-01 Thread Michael Tokarev
Some non-linux systems, for example a system with FreeBSD kernel and glibc, may declare struct mmsghdr (in glibc) but may not have linux-specific header file linux/ip.h. The actual implementation in qemu includes this linux-specific header file unconditionally, so compilation fails if it is not pr

[Qemu-devel] [PATCH v2 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-08-01 Thread Alex Bligh
Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to disabled. Rename machine type pc-1.0 to pc-1.0-qemu-git. Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm or pc-1.0-qemu-git depending on the value of the config option. Sign

[Qemu-devel] [PATCH v2 1/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-01 Thread Alex Bligh
Add a machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm version 1.0. Signed-off-by: Alex Bligh --- hw/acpi/piix4.c | 49 -- hw/i386/pc_piix.c| 31 + hw/timer/i8254_common.c | 4

[Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-01 Thread Alex Bligh
This patch series adds inbound migrate capability from qemu-kvm version 1.0. The main ideas are those set out in Cole Robinson's patch here: http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20 however, rather than patching statically (and breaking inbound m

[Qemu-devel] 2.1 build failure on [k]freebsd: net/l2tpv3.c:26: linux/ip.h: No such file or directory

2014-08-01 Thread Michael Tokarev
The test in configure checks for struct mmsghdr in sys/socket.h, but actual source (net/l2tpv3.c) includes a linux-specific header, linux/ip.h. This fails on at least kFreeBSD (Debian with FreeBSD header and glibc), because glibc declares mmsghdr but does not provide linux/ip.h. Probably the conf

Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest

2014-08-01 Thread Joel Schopp
On 08/01/2014 09:19 AM, Paolo Bonzini wrote: > Il 01/08/2014 16:02, Joel Schopp ha scritto: I think the patch is right but, besides these considerations, does this bug still manifest itself after Andrew fixed the start address of the device at 0x9001 (IIRC it was the pl031)? >>

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2014-08-01 Thread Paul Boven
As another test (still running qemu-git-2.1.0-rc2-git-20140721), I disabled NTP on the two servers (and rebooted them), but left it running on the guest. When doing the migration, server a (where the guest was running) had an NTP offset of -3.037619 s, and server b was at -3.337718 s. The guest wa

Re: [Qemu-devel] [PATCH v2 5/5] target-arm: A64: disable a bunch of ARMv5 machines

2014-08-01 Thread Peter Maydell
On 1 August 2014 17:45, Christopher Covington wrote: > On 07/30/2014 11:20 AM, Alex Bennée wrote: >> If you attempt to run a system image which uses 1k pages in the >> qemu-system-aarch64 build it will fail thanks to the change to 12 bit >> pages. The boards are still available for the qemu-system

Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-08-01 Thread Alex Williamson
On Fri, 2014-08-01 at 18:39 +0200, Jan Kiszka wrote: > On 2014-08-01 18:35, Alex Williamson wrote: > > On Fri, 2014-08-01 at 09:25 -0600, Alex Williamson wrote: > >> On Fri, 2014-08-01 at 09:35 +0800, Le Tan wrote: > >>> Hi Alex, > >>> > >>> 2014-07-30 22:46 GMT+08:00 Alex Williamson : > On We

Re: [Qemu-devel] [PATCH v2 5/5] target-arm: A64: disable a bunch of ARMv5 machines

2014-08-01 Thread Christopher Covington
On 07/30/2014 11:20 AM, Alex Bennée wrote: > If you attempt to run a system image which uses 1k pages in the > qemu-system-aarch64 build it will fail thanks to the change to 12 bit > pages. The boards are still available for the qemu-system-arm build. I fail to understand the correlation between A

[Qemu-devel] [ANNOUNCE] QEMU 2.1.0 is now available

2014-08-01 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 2.1.0 release. This release contains 2200+ commits from 180 authors. http://wiki.qemu.org/download/qemu-2.1.0.tar.bz2 The full list of changes are available at: http://wiki.qemu.org/ChangeLog/2.1 Highlight

Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-08-01 Thread Jan Kiszka
On 2014-08-01 18:35, Alex Williamson wrote: > On Fri, 2014-08-01 at 09:25 -0600, Alex Williamson wrote: >> On Fri, 2014-08-01 at 09:35 +0800, Le Tan wrote: >>> Hi Alex, >>> >>> 2014-07-30 22:46 GMT+08:00 Alex Williamson : On Wed, 2014-07-30 at 22:16 +0800, Le Tan wrote: > Hi Michael, >

Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-08-01 Thread Alex Williamson
On Fri, 2014-08-01 at 09:25 -0600, Alex Williamson wrote: > On Fri, 2014-08-01 at 09:35 +0800, Le Tan wrote: > > Hi Alex, > > > > 2014-07-30 22:46 GMT+08:00 Alex Williamson : > > > On Wed, 2014-07-30 at 22:16 +0800, Le Tan wrote: > > >> Hi Michael, > > >> > > >> 2014-07-30 21:16 GMT+08:00 Michael

Re: [Qemu-devel] [PATCH v2 0/5] AArch64 TLB performance improvements

2014-08-01 Thread Peter Maydell
On 30 July 2014 16:20, Alex Bennée wrote: > Hi, > > Not too much has changed: > > * added a review tag > * fixed up review comments > * added some notes about benchmark results > * added a patch to disable ARMv5 in AArch64 build > > The most important thing is I've measured a 25-30% improv

[Qemu-devel] [PULL 3/3] qemu: support xen hvm direct kernel boot

2014-08-01 Thread Stefano Stabellini
From: Chunyan Liu qemu side patch to support xen HVM direct kernel boot: if -kernel exists, calls xen_load_linux(), which will read kernel/initrd and add a linuxboot.bin or multiboot.bin option rom. The linuxboot.bin/multiboot.bin will load kernel/initrd and jump to execute kernel directly. It's

[Qemu-devel] [PATCH v4 2/2] trace: add some tcg tracing support

2014-08-01 Thread Alex Bennée
This adds a couple of tcg specific trace-events which are useful for tracing execution though tcg generated blocks. It's been tested with lttng user space tracing but is generic enough for all systems. The tcg events are: * translate_block - when a subject block is translated * exec_tb - when

[Qemu-devel] [PATCH v4 1/2] trace: teach lttng backend to use format strings

2014-08-01 Thread Alex Bennée
This makes the UST backend pay attention to the format string arguments that are defined when defining payload data. With this you can now ensure integers are reported in hex mode if you want. Signed-off-by: Alex Bennée --- v2 - remove silly debug statements v3 - fix spelling - rebase to

[Qemu-devel] [PATCH v4 0/2] a few simple trace fixes

2014-08-01 Thread Alex Bennée
Hi Stefan, As v3 posted earlier today but with a format string fix which didn't show up in the ust build I tested it on Alex Bennée (2): trace: teach lttng backend to use format strings trace: add some tcg tracing support cpu-exec.c | 6 ++ scripts/tra

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-08-01 Thread Stefan Hajnoczi
On Fri, Aug 01, 2014 at 10:52:55PM +0800, Ming Lei wrote: > On Fri, Aug 1, 2014 at 9:48 PM, Ming Lei wrote: > > On Fri, Aug 1, 2014 at 9:13 PM, Stefan Hajnoczi wrote: > >> On Fri, Aug 01, 2014 at 10:54:02AM +0800, Ming Lei wrote: > >>> On Fri, Aug 1, 2014 at 12:30 AM, Paolo Bonzini > >>> wrote:

[Qemu-devel] [PULL 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-08-01 Thread Stefano Stabellini
From: Roger Pau Monne The current behaviour of tap_open for BSD systems differ greatly from it's Linux counterpart. Since FreeBSD supports interface renaming and tap device cloning by opening /dev/tap, implement a FreeBSD specific version of tap_open that behaves like it's Linux counterpart. Thi

Re: [Qemu-devel] [RFC PATCH 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > Virtual machine (VM) replication is a well known technique for > providing application-agnostic software-implemented hardware fault > tolerance "non-stop service". COLO is a high availability solution. > Both primary VM (PVM) and secondary VM (SVM) r

[Qemu-devel] [PULL 1/3] xen: fix usage of ENODATA

2014-08-01 Thread Stefano Stabellini
From: Roger Pau Monne ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the hypervisor are translated to ENOENT. Also, the error code is returned in errno if the call returns -1, so compare the error code with the value in errno instead of the value returned by the function. Signe

Re: [Qemu-devel] [PATCH v3 1/8] CODING_STYLE: Section about conditional statement

2014-08-01 Thread Eric Blake
On 08/01/2014 01:46 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > Yoda conditions lack readability, and QEMU has a > strict compiler configuration for checking a common > mistake like "if (dev = NULL)". Make it a written rule. > > Signed-off-by: Gonglei > --- > CODING_STYLE | 14 +

Re: [Qemu-devel] [PATCH 01/10] AioContext: take bottom halves into account when computing aio_poll timeout

2014-08-01 Thread Paolo Bonzini
Il 01/08/2014 16:34, Stefan Hajnoczi ha scritto: > On Wed, Jul 09, 2014 at 11:53:01AM +0200, Paolo Bonzini wrote: >> diff --git a/async.c b/async.c >> index 34af0b2..ac40eab 100644 >> --- a/async.c >> +++ b/async.c >> @@ -152,39 +152,43 @@ void qemu_bh_delete(QEMUBH *bh) >> bh->deleted = 1; >>

[Qemu-devel] [PULL 0/3] Xen tree 2014-08-01

2014-08-01 Thread Stefano Stabellini
The following changes since commit 541bbb07eb197a870661ed702ae1f15c7d46aea6: Update version for v2.1.0 release (2014-08-01 13:31:29 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-20140801 for you to fetch changes up to

Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

2014-08-01 Thread Eric Blake
On 08/01/2014 12:41 AM, Markus Armbruster wrote: > +if (data == NULL) { Wouldn't it be even more idiomatic as: if (!data) { Probably applies throughout your series. >>> OK, will do. Thanks! >> >> Not so quick! You are free to use that in your patches,

Re: [Qemu-devel] [PATCH for-2.1] target-arm: Fix bit test in sp_el0_access

2014-08-01 Thread Peter Maydell
On 26 July 2014 08:26, Stefan Weil wrote: > Static code analyzers complain about a dubious & operation used for a > boolean value. The code does not test the PSTATE_SP bit as it should. > > Cc: Peter Maydell > Signed-off-by: Stefan Weil > --- > > Hello Peter, > > I'm not sure whether the "!" is

Re: [Qemu-devel] [RFC PATCH v3 04/49] fdc: adding vmstate for save/restore

2014-08-01 Thread Dr. David Alan Gilbert
* Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote: > VMState added by this patch preserves correct > loading of the FDC device state. This is a pretty big series, but I suspect most people don't need most of these devices, especially for replay/reverse execution stuff. Why don't you boil this dow

[Qemu-devel] [PATCH v3 2/4] libqos: Change free function called in malloc

2014-08-01 Thread John Snow
From: Marc Marí Signed-off-by: Marc Marí Signed-off-by: John Snow --- tests/libqos/malloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h index 46f6000..5565381 100644 --- a/tests/libqos/malloc.h +++ b/tests/libqos/malloc.h @@

[Qemu-devel] [PATCH v3 4/4] qtest/ide: Uninitialize PC allocator

2014-08-01 Thread John Snow
Use the new call to pc_alloc_uninit as a test for the new pathways. The leak checking / assert pathways are not enabled in this patch, leaving this as an option to future test writers. Signed-off-by: John Snow --- tests/ide-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ide-

[Qemu-devel] [PATCH v3 3/4] libqos: add a simple first-fit memory allocator

2014-08-01 Thread John Snow
Implement a simple first-fit memory allocator that attempts to keep track of leased blocks of memory in order to be able to re-use blocks. Additionally, allow the user to specify when initializing the device that upon cleanup, we would like to assert that there are no blocks in use. This may be us

[Qemu-devel] [PATCH v3 1/4] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-08-01 Thread John Snow
From: Marc Marí Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí Signed-off-by: John Snow --- tests/libqos/malloc-pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c..2efd095 100644 --- a/tests/libqos/

[Qemu-devel] [PATCH v3 0/4] libqos: add a simple first-fit memory allocator

2014-08-01 Thread John Snow
This set collects two patches by Marc Marí already on the mailing list, but goes further by adding a simple memory allocator that allows us to track and debug freed memory, and optionally keep track of any leaks. For convenience: https://github.com/jnsnow/qemu/tree/libqos-alloc v2: use QTAILQ as

Re: [Qemu-devel] [PATCH v2 7/7] target-arm: Call the pmccntr_sync function when swapping ELs

2014-08-01 Thread Peter Maydell
On 26 June 2014 06:02, Alistair Francis wrote: > Call the new pmccntr_sync() function when there is a possibility > of swapping ELs (I.E. when there is an exception) > > Signed-off-by: Alistair Francis > --- > > target-arm/helper-a64.c |5 + > target-arm/helper.c |7 +++ > ta

Re: [Qemu-devel] [RFC PATCH 7/7] cpus: reclaim allocated vCPU objects

2014-08-01 Thread Anshul Makkar
Hi Gu, Thanks for clarifying. Ah I missed that bit of the patch. Sorry about that and for making noise. Yes, now cpu-hotplug and unplug works fine. Next week I plan to run a series of automated and stress test. Will keep the group posted about the results. Thanks Anshul Makkar On Fri, Aug 1, 2

Re: [Qemu-devel] [PATCH v2 2/7] target-arm: Implement PMCCNTR_EL0 and related registers

2014-08-01 Thread Peter Maydell
On 26 June 2014 06:02, Alistair Francis wrote: > This patch adds support for the ARMv8 version of the PMCCNTR and > related registers. It also starts to implement the PMCCFILTR_EL0 > register. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > > target-arm/cpu.h|

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-08-01 Thread Ming Lei
On Fri, Aug 1, 2014 at 10:17 PM, Paolo Bonzini wrote: > Il 01/08/2014 15:48, Ming Lei ha scritto: >> On Fri, Aug 1, 2014 at 9:13 PM, Stefan Hajnoczi wrote: >>> On Fri, Aug 01, 2014 at 10:54:02AM +0800, Ming Lei wrote: On Fri, Aug 1, 2014 at 12:30 AM, Paolo Bonzini wrote: > Il 31/07/2014

Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-08-01 Thread Alex Williamson
On Fri, 2014-08-01 at 09:35 +0800, Le Tan wrote: > Hi Alex, > > 2014-07-30 22:46 GMT+08:00 Alex Williamson : > > On Wed, 2014-07-30 at 22:16 +0800, Le Tan wrote: > >> Hi Michael, > >> > >> 2014-07-30 21:16 GMT+08:00 Michael S. Tsirkin : > >> > On Wed, Jul 30, 2014 at 08:24:04PM +0800, Le Tan wrote

Re: [Qemu-devel] [RFC PATCH 16/17] COLO ram cache: implement colo ram cache on slaver

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > The ram cache was initially the same as PVM's memory. At > checkpoint, we cache the dirty memory of PVM into ram cache > (so that ram cache always the same as PVM's memory at every > checkpoint), flush cached memory to SVM after we received > all PVM

Re: [Qemu-devel] [RFC PATCH 13/17] COLO ctl: implement colo save

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > implement colo save My postcopy 'QEMU_VM_CMD_PACKAGED' does something similar to parts of this with the QEMUSizedBuffer, we might be able to share some more: https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg00886.html > +/* we send t

Re: [Qemu-devel] [RFC PATCH 15/17] COLO save: reuse migration bitmap under colo checkpoint

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > reuse migration bitmap under colo checkpoint, only send dirty pages > per-checkpoint. > > Signed-off-by: Yang Hongyang > --- > arch_init.c| 20 +++- > include/migration/migration-colo.h | 2 ++ > migration-

Re: [Qemu-devel] [PATCH 3/4] libqos: add a simple first-fit memory allocator

2014-08-01 Thread Stefan Hajnoczi
On Thu, Jul 31, 2014 at 05:14:12PM -0400, John Snow wrote: > > On 07/31/2014 06:13 AM, Stefan Hajnoczi wrote: > >On Wed, Jul 30, 2014 at 06:28:28PM -0400, John Snow wrote: > >>-static uint64_t pc_alloc(QGuestAllocator *allocator, size_t size) > >>+static inline void mlist_insert(MemList *head, Mem

Re: [Qemu-devel] [PATCH for-2.2 00/10] AioContext cleanups and Win32 socket support

2014-08-01 Thread Paolo Bonzini
Il 01/08/2014 16:52, Stefan Hajnoczi ha scritto: > I'm happy with this series except for my question about int vs int64_t > types for nanosecond time values. That was just an oversight, thanks for the review. I'll take a look next Monday. Paolo

Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command

2014-08-01 Thread Eduardo Habkost
On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command. > > Example QMP command: > -> { "execute": "set-bootindex", "arguments": { "id": "ide0-0-1", > "bootindex": 1, "suffix": "/disk@0"}} > <- {

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > implement colo checkpoint protocol. > > Checkpoint synchronzing points. > > Primary Secondary > NEW @ > Suspend > SUSPENDED @

Re: [Qemu-devel] [RFC PATCH 10/17] COLO ctl: introduce is_slave() and is_master()

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > is_slaver is to determine whether the QEMU instance is a > slaver(migration target) at runtime. > is_master is to determine whether the QEMU instance is a > master(migration starter) at runtime. > This 2 APIs will be used later. Since the names are

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-08-01 Thread Ming Lei
On Fri, Aug 1, 2014 at 9:48 PM, Ming Lei wrote: > On Fri, Aug 1, 2014 at 9:13 PM, Stefan Hajnoczi wrote: >> On Fri, Aug 01, 2014 at 10:54:02AM +0800, Ming Lei wrote: >>> On Fri, Aug 1, 2014 at 12:30 AM, Paolo Bonzini wrote: >>> > Il 31/07/2014 18:13, Ming Lei ha scritto: >>> >> Follows 'perf rep

Re: [Qemu-devel] [RFC PATCH 07/17] COLO buffer: implement colo buffer as well as QEMUFileOps based on it

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > We need a buffer to store migration data. > > On save side: > all saved data was write into colo buffer first, so that we can know > the total size of the migration data. this can also separate the data > transmission from colo control data, we us

Re: [Qemu-devel] [PATCH for-2.2 00/10] AioContext cleanups and Win32 socket support

2014-08-01 Thread Stefan Hajnoczi
On Wed, Jul 09, 2014 at 11:53:00AM +0200, Paolo Bonzini wrote: > This series simplifies heavily aio_poll by splitting it into three > phases: prepare (aio_compute_timeout), poll, dispatch. The resulting > code shares more logic between aio_poll and the GSource wrappers, > and makes it easier to ad

Re: [Qemu-devel] [RFC PATCH 05/17] COLO save: integrate COLO checkpointed save into qemu migration

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > Integrate COLO checkpointed save flow into qemu migration. > Add a migrate state: MIG_STATE_COLO, enter this migrate state > after the first live migration successfully finished. > Create a colo thread to do the checkpointed save. In postcopy

Re: [Qemu-devel] [PATCH v4 4/8] bootindex: delete bootindex when device is removed

2014-08-01 Thread Eduardo Habkost
On Thu, Jul 31, 2014 at 05:47:29PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Device should be removed from global boot list when > it is hot-unplugged. > > Signed-off-by: Chenliang > Signed-off-by: Gonglei > --- > hw/block/virtio-blk.c| 1 + > hw/i386/kvm/pci-assign.c | 1

Re: [Qemu-devel] [RFC PATCH 04/17] COLO info: use colo info to tell migration target colo is enabled

2014-08-01 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > migrate colo info to migration target to tell the target colo is > enabled. If I understand this correctly this means that you send a 'colo info' device information for migrations that don't have COLO enabled; that's bad because it breaks migration

Re: [Qemu-devel] [PATCH v1 00/16] target-arm: Parts of the AArch64 EL2/3 exception model

2014-08-01 Thread Peter Maydell
On 1 August 2014 15:35, Peter Maydell wrote: > On 30 May 2014 08:28, Edgar E. Iglesias wrote: >> This is a second round of AArch64 EL2/3 patches working on the exception >> model. Among other things adding HVC/SMC, interrupt routing to EL2/3 and >> Virtual IRQs/FIQs. The VIRQ/VFIQ support only ad

Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest

2014-08-01 Thread Joel Schopp
> I agree. > > I think the patch is right but, besides these considerations, does this > bug still manifest itself after Andrew fixed the start address of the > device at 0x9001 (IIRC it was the pl031)? The device I see with that address is: hw/arm/virt.c:[VIRT_RTC] = { 0x9001, 0x1000

Re: [Qemu-devel] [PATCH 01/10] AioContext: take bottom halves into account when computing aio_poll timeout

2014-08-01 Thread Stefan Hajnoczi
On Wed, Jul 09, 2014 at 11:53:01AM +0200, Paolo Bonzini wrote: > diff --git a/async.c b/async.c > index 34af0b2..ac40eab 100644 > --- a/async.c > +++ b/async.c > @@ -152,39 +152,43 @@ void qemu_bh_delete(QEMUBH *bh) > bh->deleted = 1; > } > > -static gboolean > -aio_ctx_prepare(GSource *sou

Re: [Qemu-devel] [PATCH v1 00/16] target-arm: Parts of the AArch64 EL2/3 exception model

2014-08-01 Thread Peter Maydell
On 30 May 2014 08:28, Edgar E. Iglesias wrote: > This is a second round of AArch64 EL2/3 patches working on the exception > model. Among other things adding HVC/SMC, interrupt routing to EL2/3 and > Virtual IRQs/FIQs. The VIRQ/VFIQ support only adds the external signal > delivery method. > > Patch

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-08-01 Thread Eduardo Habkost
On Wed, Jul 30, 2014 at 07:29:56AM +, Gonglei (Arei) wrote: > Hi, > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Friday, July 25, 2014 5:52 PM > > > > > +del_boot_device_path(dev); > > > > You can call this from device_finalize() instead of

Re: [Qemu-devel] [PATCH v3 09/16] target-arm: A64: Refactor aarch64_cpu_do_interrupt

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce new_el and new_mode in preparation for future patches > that add support for taking exceptions to and from EL2 and 3. > No functional change. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h

Re: [Qemu-devel] [PATCH v3 11/16] target-arm: Don't take interrupts targeting lower ELs

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Reviewed-by: Alex Bennée > Reviewed-by: Greg Bellows > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h

Re: [Qemu-devel] [PATCH v3 16/16] target-arm: Add support for VIRQ and VFIQ

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Acked-by: Greg Bellows > Signed-off-by: Edgar E. Iglesias > --- > cpu-exec.c | 12 > target-arm/cpu.c| 20 ++-- > target-arm/cpu.h| 24 +

Re: [Qemu-devel] [PATCH v3 15/16] target-arm: Add IRQ and FIQ routing to EL2 and 3

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -3312,6 +3312,19 @@ unsigned int arm_excp_target_el(CPUState *cs, unsigned > int excp_idx) > target_el = 2; > } > break; > +

[Qemu-devel] QEMU Developer Collaboration Patterns

2014-08-01 Thread codeface
Dear QEMU Developers, The University of Passau is currently studying the mechanisms that contribute to effective collaboration in open-source projects so that appropriate tools and techniques are created to support the needs of open-source developers. To achieve this goal, we are evaluating

Re: [Qemu-devel] [PATCH v3 14/16] target-arm: A64: Emulate the SMC insn

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 6 ++ > target-arm/helper.h| 1 + > target-arm/internals.

[Qemu-devel] [PATCH v3 0/2] a few simple trace fixes

2014-08-01 Thread Alex Bennée
Hi Stefan, I've re-based these two on tracing-next. Otherwise now changes from the last post. Alex Bennée (2): trace: teach lttng backend to use format strings trace: add some tcg tracing support cpu-exec.c | 6 ++ scripts/tracetool/__init__.py

Re: [Qemu-devel] [PATCH v3 13/16] target-arm: A64: Emulate the HVC insn

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 28 +++- > target-arm/helper.h| 1 + >

[Qemu-devel] [PATCH v3 1/2] trace: teach lttng backend to use format strings

2014-08-01 Thread Alex Bennée
This makes the UST backend pay attention to the format string arguments that are defined when defining payload data. With this you can now ensure integers are reported in hex mode if you want. Signed-off-by: Alex Bennée --- v2 - remove silly debug statements v3 - fix spelling - rebase to

[Qemu-devel] [PATCH v3 2/2] trace: add some tcg tracing support

2014-08-01 Thread Alex Bennée
This adds a couple of tcg specific trace-events which are useful for tracing execution though tcg generated blocks. It's been tested with lttng user space tracing but is generic enough for all systems. The tcg events are: * translate_block - when a subject block is translated * exec_tb - when

Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest

2014-08-01 Thread Paolo Bonzini
Il 01/08/2014 16:02, Joel Schopp ha scritto: >> > >> > I think the patch is right but, besides these considerations, does this >> > bug still manifest itself after Andrew fixed the start address of the >> > device at 0x9001 (IIRC it was the pl031)? > The device I see with that address is: > hw/

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-08-01 Thread Paolo Bonzini
Il 01/08/2014 15:48, Ming Lei ha scritto: > On Fri, Aug 1, 2014 at 9:13 PM, Stefan Hajnoczi wrote: >> On Fri, Aug 01, 2014 at 10:54:02AM +0800, Ming Lei wrote: >>> On Fri, Aug 1, 2014 at 12:30 AM, Paolo Bonzini wrote: Il 31/07/2014 18:13, Ming Lei ha scritto: > Follows 'perf report' resu

Re: [Qemu-devel] [PATCH v3 2/7] bootindex: add del_boot_device_path function

2014-08-01 Thread Eduardo Habkost
On Sat, Jul 26, 2014 at 12:45:28PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Introduce a del_boot_device_path() cleanup fw_cfg content > when hot-unplugging devcie refer to bootindex. > > Signed-off-by: Gonglei > Signed-off-by: Chenliang > --- > include/sysemu/sysemu.h | 1 +

[Qemu-devel] [Bug 1351271] [NEW] qemu deletes the backing file in snapshot mode

2014-08-01 Thread Giancarlo Formicuccia
Public bug reported: The file removal occurs during the "change" operation. It happens only in snapshot mode. Minimal steps to reproduce the problem: $ dd if=/dev/zero of=file.img bs=1M count=1 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 0.00288727 s, 363 MB/s $ ls file.img fil

Re: [Qemu-devel] [PATCH] monitor: Remove hardcoded watchdog event names

2014-08-01 Thread Luiz Capitulino
On Tue, 29 Jul 2014 23:22:40 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles Applied to the qmp-next branch, thanks. > --- > monitor.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 5bc70a6..7465775 100644 > --

Re: [Qemu-devel] [PATCH v3 12/16] target-arm: A64: Correct updates to FAR and ESR on exceptions

2014-08-01 Thread Peter Maydell
On 17 June 2014 09:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Not all exception types update both FAR and ESR. > > Reviewed-by: Alex Bennée > Reviewed-by: Greg Bellows > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper-a64.c | 6 ++ > 1 file changed, 2 insertio

  1   2   >