Hi
> +if (bootindex >= 0) {
> +node = g_malloc0(sizeof(FWBootEntry));
> +node->bootindex = bootindex;
> +if (suffix) {
> +node->suffix = g_strdup(suffix);
> +} else if (old_entry) {
> +node->suffix = g_strdup(old_entry->suffix);
> +
As soon as options is set in img_amend(), it needs to be freed before
the function returns. This leak is rather insignifcant, as qemu-img will
exit subsequently anyway, but there's no point in not fixing it.
Signed-off-by: Max Reitz
---
qemu-img.c | 4 +++-
1 file changed, 3 insertions(+), 1 del
Now that bdrv_amend_options() supports a status callback, use it to
display a progress report.
Signed-off-by: Max Reitz
---
qemu-img.c | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 90d6b79..a06f425 100644
--- a/qemu-
Add some tests for progress output to 061.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/061 | 27 +++
tests/qemu-iotests/061.out | 32
tests/qemu-iotests/group | 2 +-
3 files changed, 60 insertions(+), 1 deletion(-)
diff --git
Depending on the changed options and the image format,
bdrv_amend_options() may take a significant amount of time. In these
cases, a way to be informed about the operation's status is desirable.
Since the operation is rather complex and may fundamentally change the
image, implementing it as AIO or
Currently, we have a bitmap for keeping track of which clusters have
been created during the zero cluster expansion process. This was
necessary because we need to properly increase the refcount for shared
L2 tables.
However, now we can simply take the L2 refcount and use it for the
cluster allocat
The only really time-consuming operation potentially performed by
qcow2_amend_options() is zero cluster expansion when downgrading qcow2
images from compat=1.1 to compat=0.10, so report status of that
operation and that operation only through the status CB.
For this, approximate the progress as th
Reading the refcount of a cluster is an operation which can be useful in
all of the qcow2 code, so make that function globally available.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 23 ---
block/qcow2.h | 2 ++
2 files changed, 14 insertions(+), 11 deleti
The main purpose of this series is to add a progress report to
qemu-img amend. This is achieved by adding a callback function to
bdrv_amend_options() - the reasons for this choice are explained in
patch 1.
While adapting qcow2's expand_zero_clusters_in_l1() accordingly, I
noticed a way to simplify
Hey,
Found a little bug in latest qemu:
In function: static int blk_send_response_one(struct ioreq *ioreq)
File: qemu\hw\block\xen_disk.c
Code:
default:dst = NULL;}memcpy(dst, &resp, sizeof(resp));
Just add simple check for dst and it will be all cool ;-)
Best regards,Mateusz K
On 2014-07-22 17:47, Le Tan wrote:
> Add Intel IOMMU emulation to q35 chipset and expose it to the guest.
> 1. Add a machine option. Users can use "-machine vtd=on|off" in the command
> line to enable/disable Intel IOMMU. The default is off.
Better call it "iommu". We could once reuse the switch w
On 26 July 2014 08:26, Stefan Weil wrote:
> Static code analyzers complain about a dubious & operation used for a
> boolean value. The code does not test the PSTATE_SP bit as it should.
>
> Cc: Peter Maydell
> Signed-off-by: Stefan Weil
> ---
>
> Hello Peter,
>
> I'm not sure whether the "!" is
Il 25/07/2014 18:01, Alex Bligh ha scritto:
> ping: anyone got any views on this one?
Just wait for 2.1 to get out of the door. :)
Paolo
> On 22 Jul 2014, at 19:43, Alex Bligh wrote:
>
>> Add a machine type pc-1.0-qemu-kvm for live migrate compatibility
>> with qemu-kvm version 1.0.
>>
>> Sign
Static code analyzers complain about a dubious & operation used for a
boolean value. The code does not test the PSTATE_SP bit as it should.
Cc: Peter Maydell
Signed-off-by: Stefan Weil
---
Hello Peter,
I'm not sure whether the "!" is correct at all, because code and comment
don't seem to match
There's just one trivial patch this time, fixing another
occurence of "allows to" in help text. Please consider
applying for 2.1.
Thanks,
/mjt
The following changes since commit c60a57ff497667780132a3fcdc1500c83af5d5c0:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into st
Signed-off-by: Michael Tokarev
---
qemu-options.hx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 9e54686..1549625 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1437,7 +1437,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net,
"-n
Il 25/07/2014 18:17, Laszlo Ersek ha scritto:
> In favor of your idea OTOH, as you explained, it would work for all
> possible ACPI configurations, and not break for a random few ones like
> Paolo's approach (talking about patch #2 of that set, the procedural
> _PRT is great in any case).
Note tha
17 matches
Mail list logo
