Re: [Qemu-devel] [PATCH V2 6/6] image-fuzzer: GPLv2 license file

2014-07-09 Thread Fam Zheng
On Fri, 07/04 15:39, Maria Kustova wrote: > Signed-off-by: Maria Kustova You have the copyright headers in each file, so it's not really necessary to put the license here. No need to respin for this, if it's unwanted in the end, maintainer could probably skip when merging the series. Fam

Re: [Qemu-devel] [PATCH for-2.1?] scripts: qapi-event.py: support vendor extension

2014-07-09 Thread Luiz Capitulino
On Wed, 09 Jul 2014 09:43:53 -0600 Eric Blake wrote: > On 07/08/2014 12:17 PM, Luiz Capitulino wrote: > > The event code generator barfs when it sees a dot in an event > > argument, this makes it impossible to support vendor extensions > > in event arguments as they always contain dots. Fix this

Re: [Qemu-devel] [PATCH V2 2/6] runner: Tool for fuzz tests execution

2014-07-09 Thread Fam Zheng
On Fri, 07/04 15:39, Maria Kustova wrote: > v1 -> v2: > Added parameter for a fuzzer configuration file In the future revisions, please put such revision change notes below a '---' line, like: Signed-off-by: Your Name --- v1 -> v2: change This way, it doesn't get into git log

Re: [Qemu-devel] [PATCH RFC V2 6/6] xen: introduce xenpv-softmmu.mak

2014-07-09 Thread Wei Liu
On Fri, Jul 04, 2014 at 04:10:13PM +0100, Stefano Stabellini wrote: > I realize now that patch #5 and #6 of this series feel through the > cracks. Could you please rebase and resend? > Hi Peter and Paolo I would like to ask for your suggestion on how to move this forward. The first few refactor

Re: [Qemu-devel] [PATCH] ui/gtk: Restore keyboard focus after Page change

2014-07-09 Thread Stefan Hajnoczi
On Tue, Jul 08, 2014 at 02:01:23PM -0400, John Snow wrote: > In the GTK UI, after changing focus to the qemu monitor Notebook Page, > when restoring focus to the virtual machine page, the keyboard focus is lost > to a hidden GTK widget. Focus can only be restored to the virtual machine by > pressin

[Qemu-devel] [ANNOUNCE] QEMU 2.1.0-rc1 is now available

2014-07-09 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 2.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.1.0-rc1.tar.bz2 You can help i

[Qemu-devel] [Bug 1324112] Re: qemu parallel building error on libcacard.la

2014-07-09 Thread Fam Zheng
Could be because of this rule: > # libtool will build the .o files, too > $(libcacard-obj-y): | $(libcacard-lobj-y) Does removing the "|" (order deps) solve the issue? Fam -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bug

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 18/18] Add qtest for vhost-user

2014-07-09 Thread Nikolay Nikolaev
On Wed, Jul 9, 2014 at 5:24 PM, Kevin Wolf wrote: > Am 27.05.2014 um 14:07 hat Nikolay Nikolaev geschrieben: >> This test creates a 'server' chardev to listen for vhost-user messages. >> Once VHOST_USER_SET_MEM_TABLE is received it mmaps each received region, >> and read 1k bytes from it. The read

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-09 Thread Dr. David Alan Gilbert
Ondergetekende: Physically is there *anything* different between the nodes in your #33 that exhibited no errors and those that exhibited a lot? CPU model/vendor, number of sockets, system vendor etc? (I'm wondering about a synchronised/unsynchronised tsc type issue). -- You received this bug

Re: [Qemu-devel] [PATCH RFC V2 6/6] xen: introduce xenpv-softmmu.mak

2014-07-09 Thread Stefano Stabellini
On Wed, 9 Jul 2014, Wei Liu wrote: > On Fri, Jul 04, 2014 at 04:10:13PM +0100, Stefano Stabellini wrote: > > I realize now that patch #5 and #6 of this series feel through the > > cracks. Could you please rebase and resend? > > > > Hi Peter and Paolo > > I would like to ask for your suggestion o

[Qemu-devel] [PULL 08/10] oslib-posix: Fix new compiler error with -Wclobbered

2014-07-09 Thread Paolo Bonzini
From: Stefan Weil Newer versions of gcc report a warning (or an error with -Werror) when compiler option -Wclobbered (or -Wextra) is active: util/oslib-posix.c:372:12: error: variable ‘hpagesize’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] The rewritten code fixes this warn

[Qemu-devel] [PATCH 056/156] savevm: Ignore minimum_version_id_old if there is no load_state_old

2014-07-09 Thread Michael Roth
From: Peter Maydell At the moment we require vmstate definitions to set minimum_version_id_old to the same value as minimum_version_id if they do not provide a load_state_old handler. Since the load_state_old functionality is required only for a handful of devices that need to retain migration co

[Qemu-devel] [Bug 1335444] Re: qemu loses serial console data on EAGAIN

2014-07-09 Thread Kirill Batuzov
Thank you for detailed bug report. I've submitted a patch that should fix the problem. http://git.qemu.org/?p=qemu.git;a=commitdiff;h=3f0838ab8557c6071a5931183b2d7fed568cd35c;hp=8b81bb3b069d4007bc44c8d5888d630b7f0b42ff -- You received this bug notification because you are a member of qemu- devel

Re: [Qemu-devel] [RFC v4 06/13] hw/vfio/pci: split vfio_get_device

2014-07-09 Thread Alex Williamson
On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: > vfio_get_device now takes a VFIODevice as argument. The function is split > into 4 functional parts: dev_info query, device check, region populate > and interrupt populate. the last 3 are specialized by parent device and > are added into Device

[Qemu-devel] [PATCH v3 2.1 2/4] virtio-blk: Bypass error action and I/O accounting on invalid r/w

2014-07-09 Thread Markus Armbruster
When a device model's I/O operation fails, we execute the error action. This lets layers above QEMU implement thin provisioning, or attempt to correct errors before they reach the guest. But when the I/O operation fails because it's invalid, reporting the error to the guest is the only sensible a

[Qemu-devel] [PATCH 0/3] Virtio PCI libqos driver

2014-07-09 Thread Marc Marí
Add first functions for virtio PCI libqos driver in two steps. Add more debugging tools. Marc Marí (3): tests: Functions bus_foreach and device_find from libqos virtio API tests: Add virtio device initialization libqtest: add QTEST_LOG for debugging qtest testcases tests/Makefile

[Qemu-devel] [PULL for-2.1 0/3] s390x: bugfixes

2014-07-09 Thread Cornelia Huck
The following changes since commit eaa4980185943da6e36f6f2e052d41924705e1ea: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2014-07-08 11:38:12 +0100) are available in the git repository at: git://github.com/cohuck/qemu.git tags/s390x-20140708 for

[Qemu-devel] [RFC 25/25] target-i386: Move KVM CPUID hacking to accelerator cpu_post_init hook

2014-07-09 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- include/hw/i386/accel.h | 7 +++ include/qemu/typedefs.h | 2 ++ target-i386/cpu.c | 54 ++--- target-i386/kvm.c | 51 ++ 4 files changed, 71 insertions(+),

[Qemu-devel] [PATCH 028/156] vmxnet3: validate interrupt indices coming from guest

2014-07-09 Thread Michael Roth
From: Dmitry Fleytman CVE-2013-4544 Signed-off-by: Dmitry Fleytman Reported-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert Message-id: 1396604722-11902-2-git-send-email-dmi...@daynix.com Signed-off-by: Peter Maydell (cherry picked from commit 8c

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-09 Thread Alex Bennée
Peter Maydell writes: > On 8 July 2014 17:13, Al Viro wrote: >> On Tue, Jul 08, 2014 at 09:05:10AM +0100, Peter Maydell wrote: >> >> BTW, are there any more or less uptodate docs on qemu profiling? I mean, >> things like perf/oprofile on the host obviously end up lumping all tcg >> output toge

[Qemu-devel] vm panics because assign different driver, why?

2014-07-09 Thread yue
hi,all please tell me the defferences between two commands of the following two groups. my test vm is http://wiki.qemu.org/download/linux-0.2.img.bz2 qemu is qemu-kvm-0.12.1.2-2.415.el6_5.10.x86_64 kernel is 2.6.32-279.el6.x86_64, centos 6.3 ---

[Qemu-devel] [PATCH 097/156] qcow2: Avoid integer overflow in get_refcount (CVE-2014-0143)

2014-07-09 Thread Michael Roth
From: Kevin Wolf This ensures that the checks catch all invalid cluster indexes instead of returning the refcount of a wrong cluster. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit db8a31d11d6a60f48d6817530640d75aa72a9a2f) Signed-off

Re: [Qemu-devel] [RFC v4 03/13] hw/vfio/pci: Remove unneeded include files

2014-07-09 Thread Alex Williamson
On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: > Signed-off-by: Eric Auger > --- > hw/vfio/pci.c | 12 > 1 file changed, 12 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 5c7bfd5..a7df3de 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -18,26 +18,1

[Qemu-devel] [PATCH 135/156] aio: fix qemu_bh_schedule() bh->ctx race condition

2014-07-09 Thread Michael Roth
From: Stefan Hajnoczi qemu_bh_schedule() is supposed to be thread-safe at least the first time it is called. Unfortunately this is not quite true: bh->scheduled = 1; aio_notify(bh->ctx); Since another thread may run the BH callback once it has been scheduled, there is a race condition if t

Re: [Qemu-devel] [PATCH v4] spapr: add uuid/host details to device tree

2014-07-09 Thread Nikunj A Dadhania
Alexander Graf writes: > On 08.07.14 07:00, Nikunj A Dadhania wrote: >> Useful for identifying the guest/host uniquely within the >> guest. Adding following properties to the guest root node. >> >> vm,uuid - uuid of the guest >> host-model - Host model number >> host-serial - Host machine serial

[Qemu-devel] [PATCH] qtest: fix vhost-user-test compilation with old GLib

2014-07-09 Thread Nikolay Nikolaev
Mising G_TIME_SPAN_SECOND definition breaks the RHEL6 compilation as GLib version before 2.26 does not have it. In such case just define it. Reported-by: Kevin Wolf Signed-off-by: Nikolay Nikolaev --- tests/vhost-user-test.c |4 1 file changed, 4 insertions(+) diff --git a/tests/vhost

[Qemu-devel] [PATCH 2/3] tests: Add virtio device initialization

2014-07-09 Thread Marc Marí
Add functions to read and write virtio header fields. Add feature checking and status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 32 tests/libqos/virtio-pci.h | 17 ++

Re: [Qemu-devel] [PATCH v2 2.1 2/4] virtio-blk: Bypass error action and I/O accounting on invalid r/w

2014-07-09 Thread Kevin Wolf
Am 04.07.2014 um 15:31 hat Markus Armbruster geschrieben: > When a device model's I/O operation fails, we execute the error > action. This lets layers above QEMU implement thin provisioning, or > attempt to correct errors before they reach the guest. But when the > I/O operation fails because it'

[Qemu-devel] [PULL 05/10] watchdog: fix deadlock with -watchdog-action pause

2014-07-09 Thread Paolo Bonzini
qemu_clock_enable says: /* Disabling the clock will wait for related timerlists to stop * executing qemu_run_timers. Thus, this functions should not * be used from the callback of a timer that is based on @clock. * Doing so would cause a deadlock. */ and it indeed does: vm_stop uses qemu_clo

[Qemu-devel] [PATCH 050/156] ssd0323: fix buffer overun on invalid state load

2014-07-09 Thread Michael Roth
From: "Michael S. Tsirkin" CVE-2013-4538 s->cmd_len used as index in ssd0323_transfer() to store 32-bit field. Possible this field might then be supplied by guest to overwrite a return addr somewhere. Same for row/col fields, which are indicies into framebuffer array. To fix validate after load

[Qemu-devel] [RFC 08/25] accel: Move KVM accel registration to kvm-all.c

2014-07-09 Thread Eduardo Habkost
Note that this has an user-visible side-effect: instead of reporting "KVM is not supported for this target", QEMU binaries not supporting KVM will report "kvm accelerator does not exist". As kvm_availble() always return 1 when CONFIG_KVM is enabled, we don't need to set AccelClass.available anymor

[Qemu-devel] [PATCH 081/156] bochs: Fix bitmap offset calculation

2014-07-09 Thread Michael Roth
From: Kevin Wolf 32 bit truncation could let us access the wrong offset in the image. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit a9ba36a45dfac645a810c31ce15ab393b69d820a) Signed-off-by: Michael Roth

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-09 Thread Richard Henderson
On 07/08/2014 01:20 PM, Al Viro wrote: > Aha... So you've caught that one already... I've looked at your branch; > AFAICS, the only thing missing there is treating stores to FPCR.DNOD in > system mode as "not implemented" (which it is in the code as well as in > 21[0-3]64 hardware). Is it loaded

[Qemu-devel] [PULL 1/3] disas/libvixl: prepend the include path of libvixl header files

2014-07-09 Thread Peter Maydell
From: Stefano Stabellini Currently the Makefile of disas/libvixl appends -I$(SRC_PATH)/disas/libvixl to QEMU_CFLAGS. As a consequence C++ files that #include "utils.h", such as disas/libvixl/a64/instructions-a64.cc, are going to look for utils.h on all the other include paths first. When buildin

Re: [Qemu-devel] [RFC v4 05/13] hw/vfio/pci: Introduce VFIORegion

2014-07-09 Thread Alex Williamson
On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: > This structure is going to be shared by VFIOPCIDevice and > VFIOPlatformDevice. VFIOBAR includes it. > > vfio_eoi becomes an ops of VFIODevice specialized by parent device. > This makes possible to transform vfio_bar_write/read into generic >

[Qemu-devel] [PATCH 114/156] parallels: Fix catalog size integer overflow (CVE-2014-0143)

2014-07-09 Thread Michael Roth
From: Kevin Wolf The first test case would cause a huge memory allocation, leading to a qemu abort; the second one to a too small malloc() for the catalog (smaller than s->catalog_size), which causes a read-only out-of-bounds array access and on big endian hosts an endianess conversion for an und

[Qemu-devel] [PATCH 052/156] zaurus: fix buffer overrun on invalid state load

2014-07-09 Thread Michael Roth
From: "Michael S. Tsirkin" CVE-2013-4540 Within scoop_gpio_handler_update, if prev_level has a high bit set, then we get bit > 16 and that causes a buffer overrun. Since prev_level comes from wire indirectly, this can happen on invalid state load. Similarly for gpio_level and gpio_dir. To fix

[Qemu-devel] [PATCH 069/156] qemu-iotests: add ./check -cloop support

2014-07-09 Thread Michael Roth
From: Stefan Hajnoczi Add the cloop block driver to qemu-iotests. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit 47f73da0a7d36e399eaa353d93afce90de9b599d) Signed-off-by: Michael Roth --- tests/qemu-i

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-09 Thread Peter Maydell
On 8 July 2014 18:20, Al Viro wrote: > On Tue, Jul 08, 2014 at 05:33:16PM +0100, Peter Maydell wrote: > >> > Incidentally, combination of --enable-gprof and (default) --enable-pie >> > won't build - it dies with ld(1) complaining about relocs in gcrt1.o. >> >> This sounds like a toolchain bug to m

[Qemu-devel] [PATCH 118/156] qcow1: Validate L2 table size (CVE-2014-0222)

2014-07-09 Thread Michael Roth
From: Kevin Wolf Too large L2 table sizes cause unbounded allocations. Images actually created by qemu-img only have 512 byte or 4k L2 tables. To keep things consistent with cluster sizes, allow ranges between 512 bytes and 64k (in fact, down to 1 entry = 8 bytes is technically working, but L2 t

[Qemu-devel] [PATCH 089/156] qcow2: Check refcount table size (CVE-2014-0144)

2014-07-09 Thread Michael Roth
From: Kevin Wolf Limit the in-memory reference count table size to 8 MB, it's enough in practice. This fixes an unbounded allocation as well as a buffer overflow in qcow2_refcount_init(). Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commi

[Qemu-devel] [PATCH v4 2.1 3/4] virtio-blk: Treat read/write beyond end as invalid

2014-07-09 Thread Markus Armbruster
The block layer fails such reads and writes just fine. However, they then get treated like valid operations that fail: the error action gets executed. Unwanted; reporting the error to the guest is the only sensible action. Reject them before passing them to the block layer. This bypasses the er

Re: [Qemu-devel] [PATCH] pass $($*.o-cflags) first to gcc/g++

2014-07-09 Thread Paolo Bonzini
Il 09/07/2014 23:59, Stefano Stabellini ha scritto: On Wed, 9 Jul 2014, Paolo Bonzini wrote: What package is it that has the conflicting utils.h file? Any chance to get it fixed in your distro? Here I get: $ find /usr/include/ -name utils.h /usr/include/libnl3/netlink/utils.h /usr/include/lib

[Qemu-devel] [RFC 17/25] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-07-09 Thread Eduardo Habkost
Now that we create an accel object before calling machine_init, we can simply use the object to save all KVMState data. Signed-off-by: Eduardo Habkost --- kvm-all.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index fdb2fb5..9185a62 1006

[Qemu-devel] [PATCH 044/156] vmstate: fix buffer overflow in target-arm/machine.c

2014-07-09 Thread Michael Roth
From: "Michael S. Tsirkin" CVE-2013-4531 cpreg_vmstate_indexes is a VARRAY_INT32. A negative value for cpreg_vmstate_array_len will cause a buffer overflow. VMSTATE_INT32_LE was supposed to protect against this but doesn't because it doesn't validate that input is non-negative. Fix this macro

[Qemu-devel] [PATCH 098/156] qcow2: Check new refcount table size on growth

2014-07-09 Thread Michael Roth
From: Kevin Wolf If the size becomes larger than what qcow2_open() would accept, fail the growing operation. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit 2b5d5953eec0cc541857c3df812bdf8421596ab2) Signed-off-by: Michael Roth --- b

[Qemu-devel] [PATCH 019/156] ide: Correct improper smart self test counter reset in ide core.

2014-07-09 Thread Michael Roth
From: Benoît Canet The SMART self test counter was incorrectly being reset to zero, not 1. This had the effect that on every 21st SMART EXECUTE OFFLINE: * We would write off the beginning of a dynamically allocated buffer * We forgot the SMART history Fix this. Signed-off-by: Benoit Canet Mes

[Qemu-devel] [PATCH 141/156] vhost: fix resource leak in error handling

2014-07-09 Thread Michael Roth
From: "Michael S. Tsirkin" vhost_verify_ring_mappings leaks mappings on error. Fix this up. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin (cherry picked from commit 8617343faae6ba7e916137c6c9e3ef22c00565d8) Signed-off-by: Michael Roth --- hw/virtio/vhost.c | 10 ++ 1 f

[Qemu-devel] [PATCH 077/156] bochs: Unify header structs and make them QEMU_PACKED

2014-07-09 Thread Michael Roth
From: Kevin Wolf This is an on-disk structure, so offsets must be accurate. Before this patch, sizeof(bochs) != sizeof(header_v1), which makes the memcpy() between both invalid. We're lucky enough that the destination buffer happened to be the larger one, and the memcpy size to be taken from the

Re: [Qemu-devel] [RFC] COLO HA Project proposal

2014-07-09 Thread Michael R. Hines
On 07/03/2014 11:42 AM, Hongyang Yang wrote: I wonder if there is anyway to coordinate this between COLO, Michael Hines microcheckpointing and the two separate reverse-execution projects that also need to do some similar things. Are there any standard APIs for the heartbeet thing we can already

[Qemu-devel] [PULL 18/18] target-alpha: Remove DNOD bit from FPCR

2014-07-09 Thread Richard Henderson
It was never implemented, thus even for EV6 and EV7 the bit is read-as-zero, writes-ignored. Reported-by: Al Viro Signed-off-by: Richard Henderson --- target-alpha/cpu.h| 1 - target-alpha/helper.c | 8 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/target-alpha/cpu

[Qemu-devel] [PATCH 083/156] vpc: Validate block size (CVE-2014-0142)

2014-07-09 Thread Michael Roth
From: Kevin Wolf This fixes some cases of division by zero crashes. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit 5e71dfad763d67bb64be79e20e93411c0c30ad25) Conflicts: tests/qemu-iotests/group *fixed context mismatches in g

[Qemu-devel] [PULL 07/18] target-alpha: Fix cvttq vs large integers

2014-07-09 Thread Richard Henderson
The range +- 2**63 - 2**64 was returning the wrong truncated result. We also incorrectly signaled overflow for -2**63. Reported-by: Al Viro Signed-off-by: Richard Henderson --- target-alpha/fpu_helper.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target-alpha

[Qemu-devel] [PATCH 100/156] qcow2: Protect against some integer overflows in bdrv_check

2014-07-09 Thread Michael Roth
From: Kevin Wolf Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit 0abe740f1de899737242bcba1fb4a9857f7a3087) Signed-off-by: Michael Roth --- block/qcow2-refcount.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-09 Thread Richard Henderson
On 07/08/2014 09:13 AM, Al Viro wrote: > Frankly, I suspect that it's better to have qemu-system-alpha behave like > the actual hardware does (including "FPCR.DNOD can't be set") and keep the > linux-user behaviour as is, for somebody brave and masochistic enough to > fight that one. And no, it's

[Qemu-devel] [PATCH 155/156] hw: Fix qemu_allocate_irqs() leaks

2014-07-09 Thread Michael Roth
From: Andreas Färber Replace qemu_allocate_irqs(foo, bar, 1)[0] with qemu_allocate_irq(foo, bar, 0). This avoids leaking the dereferenced qemu_irq *. Cc: Markus Armbruster Reviewed-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber [PC Changes: * Applied change

Re: [Qemu-devel] [PATCH] vl.c: Keep maxram_size and ram_size consistent unless specified otherwise

2014-07-09 Thread Bruce Rogers
>>> On 7/8/2014 at 07:23 AM, wrote: > On Mon, 7 Jul 2014 17:05:22 -0600 > Bruce Rogers wrote: > >> When using a memory size less than the default amount with older pc >> machine types, a failure occurs because of the way maxram_size and >> ram_size get initialized. Keep maxram_size and ram_si

[Qemu-devel] [RFC 18/25] accel: Get target name as argument when initializing accelerator

2014-07-09 Thread Eduardo Habkost
We will look for target-specific accel subclasses, if available. Signed-off-by: Eduardo Habkost --- arch_init.c| 6 ++ hw/core/accel.c| 2 +- include/hw/accel.h | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 7870c0c..79f3d6a 1

Re: [Qemu-devel] live migration + licensing issue.

2014-07-09 Thread Anshul Makkar
Thanks. I got the point. Anshul Makkar On Wed, Jul 9, 2014 at 9:36 AM, Markus Armbruster wrote: > Anshul Makkar writes: > >> Hi, >> >> Yeah, I am aware of this option. But the point where I am concerned is >> that if Windows VM is running in QEMU 1.0 with pc-model 1.0 and then I >> upgrade the

[Qemu-devel] [PATCH v2 0/9] target-mips: implement features required in MIPS64 Release 6

2014-07-09 Thread Leon Alrae
This patch series implement set of features whose presence became mandatory in MIPS64R6: - KScratch registers, - Read-Inhibit and Execute-Inhibit page protection bits, - TLB Invalidate (TLBINV and TLBINVF instructions), - BadInstr and BadInstrP. This series should be applied on the top of pending p

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] qemu-img: Remove redundancy "ret = -1"

2014-07-09 Thread Chen Gang
On 07/09/2014 09:58 PM, Michael Tokarev wrote: > 03.07.2014 17:57, Chen Gang wrote: >> In this case, 'ret' is already '-1', so need not do it again. > > It's a very minor thing in an error path, maybe compiler even > eliminates this statement entirely by its own already. > Yeah, normal compiler

Re: [Qemu-devel] [PATCH 1/7] hw/misc/platform_devices: helpers for dynamic instantiation of platform devices

2014-07-09 Thread Alexander Graf
On 07.07.14 09:08, Eric Auger wrote: This new module implements routines which help in dynamic instantiation of sysbus devices. Machine files can use those generic routines. --- Dynamic sysbus device allocation fully written by Alex Graf. [Eric Auger] Those functions were initially in ppc e50

[Qemu-devel] [PATCH 062/156] linux-user/elfload.c: Update ARM HWCAP bits

2014-07-09 Thread Michael Roth
From: Peter Maydell The kernel has added support for a number of new ARM HWCAP bits; add them to QEMU, including support for setting them where we have a corresponding CPU feature bit. We were also incorrectly setting the VFPv3D16 HWCAP -- this means "only 16 D registers", not "supports 16-bit f

[Qemu-devel] [RFC 03/25] accel: Create struct AccelType

2014-07-09 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/core/accel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/core/accel.c b/hw/core/accel.c index 04da696..c23c04b 100644 --- a/hw/core/accel.c +++ b/hw/core/accel.c @@ -40,13 +40,15 @@ static int tcg_init(MachineClass *mc) r

[Qemu-devel] [PULL 17/18] target-alpha: Fix fpcr_flush_to_zero initialization

2014-07-09 Thread Richard Henderson
The two bits required are UNDZ and UNFD, not UNDZ and DNOD. Signed-off-by: Richard Henderson --- target-alpha/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-alpha/helper.c b/target-alpha/helper.c index 6bcde21..26d5188 100644 --- a/target-alpha/helper.c +++

[Qemu-devel] [PATCH 057/156] virtio: validate config_len on load

2014-07-09 Thread Michael Roth
From: "Michael S. Tsirkin" Malformed input can have config_len in migration stream exceed the array size allocated on destination, the result will be heap overflow. To fix, that config_len matches on both sides. CVE-2014-0182 Reported-by: "Dr. David Alan Gilbert" Signed-off-by: Michael S. Tsi

[Qemu-devel] [RFC 05/25] accel: Move accel name lookup to separate function

2014-07-09 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/core/accel.c | 57 + 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/hw/core/accel.c b/hw/core/accel.c index 00a71c0..7f9b715 100644 --- a/hw/core/accel.c +++ b/hw/core/accel.c @@ -55,11

Re: [Qemu-devel] [RFC PATCH v2] spapr: Enable use of huge pages

2014-07-09 Thread Paolo Bonzini
Il 09/07/2014 15:59, Alexey Kardashevskiy ha scritto: Did you mean something like below? If so, I have to change MR tree and place RMA under RAM, I guess. You could also use priorities, but the patch below looks nicer. Thanks, Paolo

[Qemu-devel] [PULL for-2.1 0/3] target-arm queue

2014-07-09 Thread Peter Maydell
target-arm patches for 2.1rc1; just a handful of bug fixes. thanks -- PMM The following changes since commit eaa4980185943da6e36f6f2e052d41924705e1ea: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2014-07-08 11:38:12 +0100) are available in the git

[Qemu-devel] [PATCH 120/156] qcow1: Stricter backing file length check

2014-07-09 Thread Michael Roth
From: Kevin Wolf Like qcow2 since commit 6d33e8e7, error out on invalid lengths instead of silently truncating them to 1023. Also don't rely on bdrv_pread() catching integer overflows that make len negative, but use unsigned variables in the first place. Cc: qemu-sta...@nongnu.org Signed-off-by

[Qemu-devel] [PATCH 026/156] po/Makefile: fix $SRC_PATH reference

2014-07-09 Thread Michael Roth
From: Michael Tokarev The rule for messages.po appears to be slightly wrong. Move the `cd' command within parens. Signed-off-by: Michael Tokarev Tested-by: Stefan Weil (cherry picked from commit b920cad6693d6f2baa0217543c9f9cca5ebaf6ce) Signed-off-by: Michael Roth --- po/Makefile | 4 ++-- 1

[Qemu-devel] [RFC 23/25] target-i386: Move accelerator-specific code outside X86CPU.instance_init

2014-07-09 Thread Eduardo Habkost
The code will be changed to use the accelerator object, so it has to be outside instance_init (which can't get any extra parameters). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 61 +++ 1 file changed, 34 insertions(+), 27 deletions(

[Qemu-devel] [RFC 24/25] target-i386: Accept "host" as value for CPU vendor

2014-07-09 Thread Eduardo Habkost
When using vendor=host, the host CPU vendor will be used. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 406ce02..eaae1ce 100644 --- a/target-i386/cpu.c +++ b/targ

[Qemu-devel] Which method executes the translated blocks (TBs)?

2014-07-09 Thread Anderson Sartor
Hi all, Which method, in fact, executes the TBs (full-system emulation)? Is it tcg_qemu_tb_exec() from cpu_exec()? At this point, is it possible for the execution of the TB to be interrupted (it will try to execute this TB again)? If positive, how do I know whether a TB was completely executed? Th

[Qemu-devel] [PULL 2/3] hw/arm/vexpress: Alias NOR flash at 0 for vexpress-a9

2014-07-09 Thread Peter Maydell
Make the vexpress-a9 board alias the first NOR flash region at address zero, like vexpress-a15. This makes "-bios" actually usable on this board. Signed-off-by: Peter Maydell Message-id: 1404310070-3561-1-git-send-email-peter.mayd...@linaro.org Reviewed-by: Greg Bellows --- hw/arm/vexpress.c |

Re: [Qemu-devel] live migration + licensing issue.

2014-07-09 Thread Anshul Makkar
Hi, Yeah, I am aware of this option. But the point where I am concerned is that if Windows VM is running in QEMU 1.0 with pc-model 1.0 and then I upgrade the QEMU to 2.0 and I specify machine as pc-1.2, then Windows will see this as change in hardware and complain about the license. Sorry, if my

Re: [Qemu-devel] [PULL for-2.1 0/3] s390x: bugfixes

2014-07-09 Thread Peter Maydell
On 8 July 2014 14:29, Cornelia Huck wrote: > The following changes since commit eaa4980185943da6e36f6f2e052d41924705e1ea: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2014-07-08 11:38:12 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH for-2.1] test-string-output-visitor: Fix unterminated string

2014-07-09 Thread Eric Blake
On 07/09/2014 08:14 AM, Kevin Wolf wrote: > Don't forget to add a terminating '\0' or the test case will be randomly > failing. The broken code was added in commit b4900c0e. Sorry, but I prefer this solution better: https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg01595.html > > Signed-o

[Qemu-devel] [PATCH 02/10] aio-win32: Evaluate timers after handles

2014-07-09 Thread Paolo Bonzini
This is similar to what aio_poll does in the stand-alone case. Signed-off-by: Paolo Bonzini --- aio-win32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/aio-win32.c b/aio-win32.c index fe7ee5b..7b28411 100644 --- a/aio-win32.c +++ b/aio-win32.c @@ -109,9 +109,6 @@ bo

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-09 Thread Peter Maydell
No; this is a a complicated issue to fix that basically requires a significant restructuring of the linux-user code. Nobody's done that yet and as far as I know nobody's said they plan to do so either. -- You received this bug notification because you are a member of qemu- devel-ml, which is subs

Re: [Qemu-devel] live migration + licensing issue.

2014-07-09 Thread Alexandre DERUMIER
Hi, AFAIK this change has occured between the switch from qemu-kvm to qemu. (qemu 1.3 if I remember) Don't have see license problem after other upgrade (qemu 1.3->1.4->1.5 ...) But It's always better to use volume licenses, no more problem in case of virtual hardware change. - Mail orig

[Qemu-devel] [PATCH 149/156] nbd: Don't validate from and len in NBD_CMD_DISC.

2014-07-09 Thread Michael Roth
From: Hani Benhabiles These values aren't used in this case. Currently, the from field in the request sent by the nbd kernel module leading to a false error message when ending the connection with the client. $ qemu-nbd some.img -v // After nbd-client -d /dev/nbd0 nbd.c:nbd_trip():L1031: From:

[Qemu-devel] [PATCH] target-ppc: Fix number of threads per core limit

2014-07-09 Thread Alexey Kardashevskiy
The number of threads per core is different for POWER6/7/8 CPUs. Guest systems do not expect to see more threads per core than a specific CPU supports so we need to limit this number. This limit is implemented by ppc_get_compat_smt_threads(). However it has a problem as it checks for PCR (Processo

Re: [Qemu-devel] virtio + virtq + iommu

2014-07-09 Thread Anshul Makkar
Hi, Any suggestions. Anshul Makkar On Tue, Jul 8, 2014 at 5:21 PM, Anshul Makkar wrote: > Hi, > > Was tracing the buffer handling code flow after the kick has been > initiated from the guest in case of virtio. > > Found this function > cpu_physical_memory_map->address_space_map->address_space_t

Re: [Qemu-devel] [PULL 37/37] tests: add human format test for string output visitor

2014-07-09 Thread Peter Maydell
On 9 July 2014 20:14, Andreas Färber wrote: > Am 29.06.2014 19:00, schrieb Michael S. Tsirkin: >> From: Hu Tao >> >> Signed-off-by: Hu Tao >> Acked-by: Michael S. Tsirkin >> Signed-off-by: Michael S. Tsirkin >> --- >> tests/test-string-output-visitor.c | 109 >> ++

[Qemu-devel] [PULL 04/18] target-alpha: Set fpcr_exc_status even for disabled exceptions

2014-07-09 Thread Richard Henderson
The qualifiers can suppress the raising of exceptions, but real hardware still records that the exceptions occurred. Reported-by: Al Viro Signed-off-by: Richard Henderson --- target-alpha/fpu_helper.c | 67 ++- target-alpha/translate.c | 41 +

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-09 Thread Al Viro
On Tue, Jul 08, 2014 at 09:59:33PM -0700, Richard Henderson wrote: > On 07/08/2014 01:20 PM, Al Viro wrote: > > Aha... So you've caught that one already... I've looked at your branch; > > AFAICS, the only thing missing there is treating stores to FPCR.DNOD in > > system mode as "not implemented"

[Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device properties in -device FOO, help output

2014-07-09 Thread Stefan Hajnoczi
These two patches fix the -device FOO,help output regression that Cole spotted in QEMU 2.0-rc0. The problem is that virtio-blk-pci qdev properties have been converted to QOM alias properties but -device FOO,help shows only qdev properties. We simply need to update -device FOO,help code to use bot

[Qemu-devel] [RFC 00/25] QOMify accelerator code

2014-07-09 Thread Eduardo Habkost
Git tree: https://github.com/ehabkost/qemu-hacks/tree/accel-qom.v1 This is an attempt to convert the accel initialization and registration code to be QOM-based. I see two use cases for this: * KVM-specific CPU compat bits; * Probing for accelerator-specific CPU model "runnable" information.

[Qemu-devel] [PATCH 03/10] aio-win32: Factor out duplicate code into aio_dispatch_handlers

2014-07-09 Thread Paolo Bonzini
Later, the call to aio_dispatch will move int the GSource wrapper, while the standalone case will still be call the component functions aio_bh_poll, aio_dispatch_handlers and timerlistgroup_run_timers. Signed-off-by: Paolo Bonzini --- aio-win32.c | 89 +++-

Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

2014-07-09 Thread Jeff Cody
On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote: > VM Image on Archipelago volume is specified like this: > > file.driver=archipelago,file.volume=[,file.mport=[, > file.vport=][,file.segment=]] > > 'archipelago' is the protocol. > > 'mport' is the port number on which mapper

[Qemu-devel] [PATCH 136/156] kvmclock: Ensure time in migration never goes backward

2014-07-09 Thread Michael Roth
From: Alexander Graf When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the kvm returned time. To make sure we never go backwards, calculate what the guest would

[Qemu-devel] [PATCH v3 3/4] virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and VirtQueueElement

2014-07-09 Thread Stefan Hajnoczi
In commit de6c8042ec55da18702fa51f09072fcaa315edc3 ("virtio-blk: Avoid zeroing every request structure") we avoided the 40 KB memset when allocating VirtIOBlockReq. The memset was reintroduced in commit 671ec3f056559f22a2531a91dce3a258b9b5eb8a ("virtio-blk: Convert VirtIOBlockReq.elem to pointer")

[Qemu-devel] [RFC 11/25] accel: Remove tcg_available() function

2014-07-09 Thread Eduardo Habkost
As the function always return 1, it is not needed anymore. Signed-off-by: Eduardo Habkost --- arch_init.c| 5 - hw/core/accel.c| 1 - include/sysemu/arch_init.h | 1 - 3 files changed, 7 deletions(-) diff --git a/arch_init.c b/arch_init.c index 8ddaf35..7870c0c 1

Re: [Qemu-devel] [RFC v4 04/13] hw/vfio/pci: introduce VFIODevice

2014-07-09 Thread Alex Williamson
On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: > Introduce the VFIODevice struct that is going to be shared by > VFIOPCIDevice and VFIOPlatformDevice. > > Additional fields will be added there later on for review > convenience. > > the group's device_list becomes a list of VFIODevice > > T

[Qemu-devel] dataplane degradation in 2.1

2014-07-09 Thread Andrey Korolyov
Hello, I`ve observed an immediate crash running tagged -rc1 with virtio-blk(675879f6f3c9463e103735a4e41e9deb0bee9b39). Please take a look on attached backtrace, hope that the fix still can made its way to 2.1. 1.6 works well with same config, so it`s clearly a regression. /usr/bin/qemu-system-x86_

[Qemu-devel] [PATCH for-2.1] test-string-output-visitor: Fix unterminated string

2014-07-09 Thread Kevin Wolf
Don't forget to add a terminating '\0' or the test case will be randomly failing. The broken code was added in commit b4900c0e. Signed-off-by: Kevin Wolf --- tests/test-string-output-visitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-string-output-visito

[Qemu-devel] [PULL 15/18] target-alpha: Raise IOV from CVTQL

2014-07-09 Thread Richard Henderson
Even if an exception isn't taken, the status flags need updating and the result should be written to the destination. Move the body of cvtql out of line, since we now always need a call. Reported-by: Al Viro Signed-off-by: Richard Henderson --- target-alpha/fpu_helper.c | 8 ++-- target-a

[Qemu-devel] [PULL for-2.1 1/3] pc-bios/s390-ccw: store proper subsystem information word

2014-07-09 Thread Cornelia Huck
From: Christian Borntraeger POP chapter 17 requires to store a subsystem information word at 184 during IPL. Furthermore bytes 188-191 should be zero. The bootmap might contain data blocks that are written to the first page. We have to write these values after we processed the bootmap and before

Re: [Qemu-devel] [PATCH for-2.1] dma-helpers: Fix too long qiov

2014-07-09 Thread Eric Blake
On 07/09/2014 11:23 AM, Kevin Wolf wrote: > If the size of the scatter/gather list isn't a multiple of 512, the > number of sectors for the block layer request is rounded down, resulting > in a qiov that doesn't match the request length. Truncate the qiov to the > new length of the request. > > Th

  1   2   3   >