On Wed, 09 Jul 2014 09:43:53 -0600 Eric Blake <ebl...@redhat.com> wrote:
> On 07/08/2014 12:17 PM, Luiz Capitulino wrote: > > The event code generator barfs when it sees a dot in an event > > argument, this makes it impossible to support vendor extensions > > in event arguments as they always contain dots. Fix this by > > replacing dots by hyphens in the generated code. > > > > PS: Event names and QMP command arguments may suffer from the > > same issue, but I'm not checking/fixing them today. > > > > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> > > --- > > scripts/qapi-event.py | 8 ++++---- > > scripts/qapi.py | 4 ++++ > > 2 files changed, 8 insertions(+), 4 deletions(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > This is borderline on whether it is a bug fix worth applying in 2.1 - it > is fixing something that is new to this release (event-as-qapi) and > which affects downstream vendors; but at the same time, it is something > which cannot be triggered _except_ by downstream vendors, which are > perfectly capable of applying this patch even if it misses 2.1. I'll > leave it up to you. I'm not sure it qualifies. On the one hand it's a bug in new code that didn't exist before, on the other hand this is by far not blocker and it doesn't cause any code to malfunction.
