Re: [Qemu-devel] [RFC v1 19/25] sysbus: Setup memory regions as dynamic props

2014-05-28 Thread Peter Crosthwaite
On Fri, May 16, 2014 at 12:00 PM, Peter Crosthwaite wrote: > Dynamically allocate Memory Region pointers and set them up as QOM > links. Plug these dynamic links to the sysbus_init_mmio() and > sysbus_mmio_get_region APIs. > > This allows for removal of the Sysbus Memory Regions as state. All > th

Re: [Qemu-devel] qemu-ppc and NUMA topology

2014-05-28 Thread Nishanth Aravamudan
On 29.05.2014 [11:57:01 +1000], Alexey Kardashevskiy wrote: > On 05/29/2014 05:57 AM, Nishanth Aravamudan wrote: > > On 27.05.2014 [14:59:03 -0700], Nishanth Aravamudan wrote: > >> On 20.05.2014 [12:44:15 +1000], Alexey Kardashevskiy wrote: > >>> On 05/20/2014 10:06 AM, Nishanth Aravamudan wrote: >

[Qemu-devel] [RFC PATCH 2/2] qemu: support xen hvm direct kernel boot

2014-05-28 Thread Chunyan Liu
[support xen HVM direct kernel boot] qemu side patch: if -kernel exists, calls xen_load_linux(), which will read kernel/initrd and add a linuxboot.bin or multiboot.bin option rom. The linuxboot.bin/multiboot.bin will load kernel/initrd and jump to execute kernel directly. It's working when xen uses

[Qemu-devel] [RFC PATCH 1/2] xen: pass kernel initrd to qemu

2014-05-28 Thread Chunyan Liu
[support xen HVM direct kernel boot] xen side patch: support 'kernel', 'ramdisk', 'root', 'extra' in HVM config file, parse config file, pass -kernel, -initrd and -append parameters to qemu. [config example] kernel="/mnt/vmlinuz-3.0.13-0.27-default" ramdisk="/mnt/initrd-3.0.13-0.27-default" root="

[Qemu-devel] [RFC PATCH 0/2] support xen HVM direct kernel boot

2014-05-28 Thread Chunyan Liu
Following previous discussion: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03843.html I spent lot of time to understand xen xc_hvm_build, hvmloader code, and qemu pc_memory_init, xen_ram_init code, and wrote experimental code to test. Now it's basically working based on seabios. Talk

[Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-05-28 Thread Alexey Kardashevskiy
This replaces fprintf(stderr) with error_report. This prints line number of the trace which does not exist or is not traceable. This moves local variables to the beginning of the function because of the QEMU coding style. Suggested-by: Lluís Vilanova Signed-off-by: Alexey Kardashevskiy --- Ll

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Put tempfiles in subdir so we can clean up libtool files

2014-05-28 Thread Ed Maste
On 6 May 2014 10:36, Eric Blake wrote: > > mktemp is not POSIX. BSD mktemp lacks -t: > > http://www.freebsd.org/cgi/man.cgi?query=mktemp&apropos=0&sektion=1&manpath=Red+Hat+Linux%2Fi386+9&format=html You managed to link to a mktemp man page for some old Red Hat version there (note the URL); Free

Re: [Qemu-devel] qemu-ppc and NUMA topology

2014-05-28 Thread Alexey Kardashevskiy
On 05/29/2014 05:57 AM, Nishanth Aravamudan wrote: > On 27.05.2014 [14:59:03 -0700], Nishanth Aravamudan wrote: >> On 20.05.2014 [12:44:15 +1000], Alexey Kardashevskiy wrote: >>> On 05/20/2014 10:06 AM, Nishanth Aravamudan wrote: On 19.05.2014 [15:37:52 -0700], Nishanth Aravamudan wrote: >

Re: [Qemu-devel] [PATCH V9 3/4] raw-posix: Add full image preallocation option

2014-05-28 Thread Hu Tao
On Wed, May 28, 2014 at 07:36:26AM +0200, Markus Armbruster wrote: > Peter Lieven writes: > > > Am 27.05.2014 um 21:24 schrieb Eric Blake : > > > >> On 05/27/2014 02:22 AM, Chen Fan wrote: > >>> From: Hu Tao > >>> > >>> This patch adds a new option preallocation for raw format, and implements >

Re: [Qemu-devel] [PATCH V9 2/4] raw, qcow2: don't convert file size to sector size

2014-05-28 Thread Hu Tao
On Thu, May 29, 2014 at 12:24:43AM +0200, Max Reitz wrote: > On 27.05.2014 21:13, Eric Blake wrote: > >On 05/27/2014 02:22 AM, Chen Fan wrote: > >>From: Hu Tao > >> > >>and avoid converting it back later. And round up file size to nearest > >>sector. > >The fact that you started a sentence with "A

Re: [Qemu-devel] [PATCH v3 3/9] spapr_pci: Introduce a finish_realize() callback

2014-05-28 Thread Alexey Kardashevskiy
On 05/29/2014 01:11 AM, Alexander Graf wrote: > > On 27.05.14 07:36, Alexey Kardashevskiy wrote: >> The spapr-pci PHB initializes IOMMU for emulated devices only. >> The upcoming VFIO support will do it different. However both emulated >> and VFIO PHB types share most of the initialization code. >

Re: [Qemu-devel] [v3][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-05-28 Thread Chen, Tiejun
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Wednesday, May 28, 2014 8:24 PM > To: Chen, Tiejun > Cc: Stefano Stabellini; anthony.per...@citrix.com; m...@redhat.com; > kelly.zyta...@amd.com; qemu-devel@nongnu.org; > xen-de...@lists.xensou

Re: [Qemu-devel] [v3][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-28 Thread Chen, Tiejun
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Wednesday, May 28, 2014 8:30 PM > To: Chen, Tiejun > Cc: Stefano Stabellini; anthony.per...@citrix.com; m...@redhat.com; > kelly.zyta...@amd.com; qemu-devel@nongnu.org; > xen-de...@lists.xensou

Re: [Qemu-devel] [PATCH] [qemu-devel] fix wrong order when doing live block migration setup

2014-05-28 Thread Chai Wen
Hi Kevin & Stefan How about this fix ? On 05/28/2014 09:13 AM, Chai Wen wrote: > On 05/27/2014 06:11 PM, Fam Zheng wrote: > >> On Tue, 05/27 16:54, chai wen wrote: >>> If we want to track dirty blocks using dirty_maps on a BlockDriverState >>> when doing live block-migration, its correspoding

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-28 Thread Eduardo Habkost
On Tue, May 27, 2014 at 10:51:28PM -0300, Marcelo Tosatti wrote: > On Tue, May 27, 2014 at 12:55:01PM -0300, Eduardo Habkost wrote: > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > > > > > > Migration blocker is redudant: blocking savevm is sufficient. > > > > > > > Removin

[Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

2014-05-28 Thread Petar Jovanovic
From: Petar Jovanovic >From MIPS documentation (Volume III): UserLocal Register (CP0 Register 4, Select 2) Compliance Level: Recommended. The UserLocal register is a read-write register that is not interpreted by the hardware and conditionally readable via the RDHWR instruction. This register

Re: [Qemu-devel] [v2 PATCH] target-mips: implement UserLocal Register

2014-05-28 Thread Petar Jovanovic
>> make it accessable to unprivileged software via register 29 (ULR) of the > "accessible" Fixed in v3. > static void save_fpu(QEMUFile *f, CPUMIPSFPUContext *fpu) > @@ -173,6 +174,7 @@ static void load_tc(QEMUFile *f, TCState *tc) > qemu_get_betls(f, &tc->CP0_TCSchedule); > qemu_get_b

Re: [Qemu-devel] [Qemu-ppc] [V4 PATCH 1/6] target-ppc: Support little-endian PPC64 in user mode.

2014-05-28 Thread Alexander Graf
On 28.05.14 22:34, Tom Musta wrote: Look at ELF header to determine ABI version on PPC64. This is required for executing the first instruction correctly. Also print correct machine name in uname() system call. Signed-off-by: Doug Kwan You sure that's his email address? :) Alex

Re: [Qemu-devel] [PATCH v7 3/3] sPAPR: EEH support for VFIO PCI device

2014-05-28 Thread Alexander Graf
On 28.05.14 23:54, Benjamin Herrenschmidt wrote: On Wed, 2014-05-28 at 13:24 +0200, Alexander Graf wrote: int (*eeh_handler)(PCIDevice *pdev, int opcode, int option); If we need a PCI device level callback, yes. I think a PCI device level callback is preferable regardless of whether the c

Re: [Qemu-devel] [PATCH 2/2] qcow2: Return useful error code in refcount_init()

2014-05-28 Thread Max Reitz
On 29.05.2014 00:33, Eric Blake wrote: On 05/28/2014 04:19 PM, Max Reitz wrote: If bdrv_pread() returns an error, it is very unlikely that it was ENOMEM. In this case, the return value should be passed along; as bdrv_pread() will always either return the number of bytes read or a negative value

Re: [Qemu-devel] [PATCH 1/2] qcow2: Fix memory leak in copy_sectors()

2014-05-28 Thread Eric Blake
On 05/28/2014 04:19 PM, Max Reitz wrote: > If bs->drv is NULL, iov.iov_base should not be leaked. > > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/block/qcow2-cluster.c b/block/qcow2-

Re: [Qemu-devel] [PATCH 2/2] qcow2: Return useful error code in refcount_init()

2014-05-28 Thread Eric Blake
On 05/28/2014 04:19 PM, Max Reitz wrote: > If bdrv_pread() returns an error, it is very unlikely that it was > ENOMEM. In this case, the return value should be passed along; as > bdrv_pread() will always either return the number of bytes read or a > negative value (the error code), the condition fo

Re: [Qemu-devel] [PATCH V9 2/4] raw, qcow2: don't convert file size to sector size

2014-05-28 Thread Max Reitz
On 27.05.2014 21:13, Eric Blake wrote: On 05/27/2014 02:22 AM, Chen Fan wrote: From: Hu Tao and avoid converting it back later. And round up file size to nearest sector. The fact that you started a sentence with "And" makes me wonder if this should be two patches. Signed-off-by: Hu Tao ---

[Qemu-devel] [PATCH 1/2] qcow2: Fix memory leak in copy_sectors()

2014-05-28 Thread Max Reitz
If bs->drv is NULL, iov.iov_base should not be leaked. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 33e6826..d391c5a 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow

[Qemu-devel] [PATCH 2/2] qcow2: Return useful error code in refcount_init()

2014-05-28 Thread Max Reitz
If bdrv_pread() returns an error, it is very unlikely that it was ENOMEM. In this case, the return value should be passed along; as bdrv_pread() will always either return the number of bytes read or a negative value (the error code), the condition for checking whether bdrv_pread() failed can be sim

[Qemu-devel] [PATCH 0/2] qcow2: Small fixes

2014-05-28 Thread Max Reitz
Very minor fixes for qcow2. This series (patch 2, to be exact) depends on Kevin's "block: Handle failure for potentially large allocations" series. Max Reitz (2): qcow2: Fix memory leak in copy_sectors() qcow2: Return useful error code in refcount_init() block/qcow2-cluster.c | 3 ++- bloc

Re: [Qemu-devel] [PATCH v2 07/20] iscsi: Handle failure for potentially large allocations

2014-05-28 Thread Eric Blake
On 05/28/2014 08:37 AM, Kevin Wolf wrote: > Some code in the block layer makes potentially huge allocations. Failure > is not completely unexpected there, so avoid aborting qemu and handle > out-of-memory situations gracefully. > > This patch addresses the allocations in the iscsi block driver. >

Re: [Qemu-devel] [PATCH v2 11/20] qcow2: Handle failure for potentially large allocations

2014-05-28 Thread Max Reitz
On 28.05.2014 16:37, Kevin Wolf wrote: Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the qcow2 block driver. Signed-off-b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] ppc-e500: on write to MMUCSR0, pass GPR content, not SPR number, to low-level TLB-flush routine

2014-05-28 Thread Alexander Graf
On 28.05.14 19:25, Alex Zuepke wrote: A "mtspr SPRMMUCSR0, reg" always flushed TLB0, because it passed the SPR number 0x3f4 to the flush routine. But we want to flush either TLB0 or TBL1 depending on the GPR value. Signed-off-by: Alex Zuepke Thanks, applied to ppc-next with a shortened sub

Re: [Qemu-devel] [PATCH v7 3/3] sPAPR: EEH support for VFIO PCI device

2014-05-28 Thread Benjamin Herrenschmidt
On Wed, 2014-05-28 at 13:24 +0200, Alexander Graf wrote: > >int (*eeh_handler)(PCIDevice *pdev, int opcode, int option); > > If we need a PCI device level callback, yes. I think a PCI device level callback is preferable regardless of whether the current VFIO creates a PHB for a group/domain/P

Re: [Qemu-devel] [PATCH] gtk: fix linker error

2014-05-28 Thread Peter Maydell
On 28 May 2014 21:35, Gerd Hoffmann wrote: > commit 3158a3482b0093e41f2b2596fba50774ea31ae08 added a XkbGetKeyboard > call, we'll need libX11 for that. Add it, otherwise the build will fail > with a linker error (unless X11 is linked anyway for other reasons, SDL > for example). Isn't this going

Re: [Qemu-devel] [PATCH v2 10/10] block: Avoid bdrv_get_geometry() where errors should be detected

2014-05-28 Thread Max Reitz
On 28.05.2014 16:25, Markus Armbruster wrote: bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster --- block.c | 11 --- block/qapi.c | 14 ++ qemu-img.c | 59 ++

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Max Reitz
On 28.05.2014 23:26, Max Reitz wrote: On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Si

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Max Reitz
On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Signed-off-by: Markus Armbruster --- q

Re: [Qemu-devel] [PATCH v2 10/10] block: Avoid bdrv_get_geometry() where errors should be detected

2014-05-28 Thread Eric Blake
On 05/28/2014 08:25 AM, Markus Armbruster wrote: > bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or > bdrv_getlength() instead where that's obviously inappropriate. > > Signed-off-by: Markus Armbruster > --- > block.c | 11 --- > block/qapi.c | 14 ++ > qemu-i

Re: [Qemu-devel] [PATCH] tcg-i386: Fix win64 qemu store

2014-05-28 Thread Stefan Weil
Am 28.05.2014 23:04, schrieb Richard Henderson: > The first non-register argument isn't placed at offset 0. > > Cc: Stefan Weil > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > --- > > You were right, Stefan. Naturally,

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Max Reitz
On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Signed-off-by: Markus Armbruster --- q

[Qemu-devel] segfault with -vga none

2014-05-28 Thread BALATON Zoltan
Running 'qemu-system-i386 -vga none' I get: Program received signal SIGSEGV, Segmentation fault. 0x557f67ef in timer_mod (ts=0x0, expire_time=10419598) at qemu-timer.c:442 442 timer_mod_ns(ts, expire_time * ts->scale); (gdb) bt #0 0x557f67ef in timer_mod (ts=0x0, expire

[Qemu-devel] [PATCH] tcg-i386: Fix win64 qemu store

2014-05-28 Thread Richard Henderson
The first non-register argument isn't placed at offset 0. Cc: Stefan Weil Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- You were right, Stefan. Naturally, this bug really manifest until paging is enabled, thus all the ro

Re: [Qemu-devel] [PATCH v3 00/10] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-05-28 Thread Lluís Vilanova
Richard Henderson writes: > On 05/28/2014 10:42 AM, Lluís Vilanova wrote: >> Files generating guest code (TCG) must include "trace-tcg.h". Files declaring >> per-target helpers ("${target}/helper.h") must include >> "trace/generated-helpers.h". > This should be simpler now, with the header rearra

Re: [Qemu-devel] [PATCH v2 08/10] block: Drop superfluous aligning of bdrv_getlength()'s value

2014-05-28 Thread Max Reitz
On 28.05.2014 16:25, Markus Armbruster wrote: It returns a multiple of the sector size. Signed-off-by: Markus Armbruster --- block.c | 1 - block/qcow2.c | 1 - 2 files changed, 2 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PULL 0/8] QOM devices patch queue 2014-05-28

2014-05-28 Thread Peter Maydell
On 28 May 2014 18:28, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue. Please pull. > > I've verified that the machine changes still build on FreeBSD. > > QOM/QTest infrastructure fixes and device conve

[Qemu-devel] [V4 PATCH 3/6] target-ppc: Add a new user mode target for little-endian PPC64.

2014-05-28 Thread Tom Musta
Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V3: Addressing comment from Peter Maydell. Adding libdecnumber enable. configure |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0e516f9..3ccbe4b 100755 --- a/configure +++ b/config

[Qemu-devel] [V4 PATCH 4/6] target-ppc: Support VSX in PPC User Mode

2014-05-28 Thread Tom Musta
Some modern tool chains use VSX instructions. Therefore attempt to enable the VSX MSR bit by default, just like similar bits (FP, VEC, SPE, etc.). Signed-off-by: Tom Musta --- V3: new patch target-ppc/translate_init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/t

[Qemu-devel] [V4 PATCH 2/6] target-ppc: Allow little-endian user mode.

2014-05-28 Thread Tom Musta
This allows running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user mode we set MSR.LE during initialization. Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V2: Overhaul handling of byteswapping in code generation and mem helpers. V3: Eliminating MSR

[Qemu-devel] [PATCH] gtk: fix linker error

2014-05-28 Thread Gerd Hoffmann
commit 3158a3482b0093e41f2b2596fba50774ea31ae08 added a XkbGetKeyboard call, we'll need libX11 for that. Add it, otherwise the build will fail with a linker error (unless X11 is linked anyway for other reasons, SDL for example). Cc: Richard Henderson Signed-off-by: Gerd Hoffmann --- configure

[Qemu-devel] [V4 PATCH 5/6] target-ppc: Confirm That .bss Pages Are Valid

2014-05-28 Thread Tom Musta
The existing code does a check to ensure that a .bss region is properly mmap'd. When additional mmap is required, the (guest) pages are also validated. However, this code has a bug: when host page size is larger than target page size, it is possible for the .bss pages to already be (host) mapped

[Qemu-devel] [V4 PATCH 6/6] target-ppc: Store Quadword Conditional Drops Size Bit

2014-05-28 Thread Tom Musta
The size and register information are encoded into the reserve_info field of CPU state in the store conditional translation code. Specifically, the size is shifted left by 5 bits (see target-ppc/translate.c gen_conditional_store). The user-mode store conditional code erroneously extracts the siz

[Qemu-devel] [V4 PATCH 1/6] target-ppc: Support little-endian PPC64 in user mode.

2014-05-28 Thread Tom Musta
Look at ELF header to determine ABI version on PPC64. This is required for executing the first instruction correctly. Also print correct machine name in uname() system call. Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V3: Addressing Peter Maydell's comments regarding how and where t

[Qemu-devel] [V4 PATCH 0/6] Adding New Target ppc64le-linux-user

2014-05-28 Thread Tom Musta
This is a follow up to the patch series initiated by Doug Kwan http://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg01936.html Tom Musta (6): target-ppc: Support little-endian PPC64 in user mode. target-ppc: Allow little-endian user mode. target-ppc: Add a new user mode target for litt

Re: [Qemu-devel] qemu-ppc and NUMA topology

2014-05-28 Thread Nishanth Aravamudan
On 27.05.2014 [14:59:03 -0700], Nishanth Aravamudan wrote: > On 20.05.2014 [12:44:15 +1000], Alexey Kardashevskiy wrote: > > On 05/20/2014 10:06 AM, Nishanth Aravamudan wrote: > > > On 19.05.2014 [15:37:52 -0700], Nishanth Aravamudan wrote: > > >> Hi Alexey, > > >> > > >> I've been looking at hw/pp

Re: [Qemu-devel] [Qemu-stable] qemu segfault in librbd / aio_notify

2014-05-28 Thread Stefan Priebe
is this: commit 271c0f68b4eae72691721243a1c37f46a3232d61 Author: Fam Zheng Date: Wed May 21 10:42:13 2014 +0800 aio: Fix use-after-free in cancellation path Stefan Am 28.05.2014 21:40, schrieb Stefan Priebe: Hello, i mean since using qemu 2.0 i've now seen several times the following s

[Qemu-devel] gtk build failure on ppc64-linux

2014-05-28 Thread Richard Henderson
LINK aarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: ../ui/gtk.o: undefined reference to symbol 'XkbGetKeyboard' /usr/bin/ld: note: 'XkbGetKeyboard' is defined in DSO /lib64/libX11.so.6 so try adding it to the linker command line /lib64/libX11.so.6: could not read symbols: Invalid operation col

[Qemu-devel] qemu segfault in librbd / aio_notify

2014-05-28 Thread Stefan Priebe
Hello, i mean since using qemu 2.0 i've now seen several times the following segfault: (gdb) bt #0 0x7f2af1196433 in event_notifier_set (e=0x124) at util/event_notifier-posix.c:97 #1 0x7f2af0db1afc in aio_notify (ctx=0x0) at async.c:246 #2 0x7f2af0db1697 in qemu_bh_schedule (bh

Re: [Qemu-devel] [PATCH] q35: Fix memory_region_del_eventfd: Assertion `i != mr->ioeventfd_nb' failed.

2014-05-28 Thread Etienne Martineau
Hi Marcel, thanks for your reply. On 14-05-28 05:10 AM, Marcel Apfelbaum wrote: > This is correct since now you are using a Root Complex Port. > If you don't want to use a config file use: > > [...] -device ioh3420,bus=pcie.0,id=ich9-pcie-port-1,slot=3 You're right I could have done it on the c

Re: [Qemu-devel] [PATCH v3 00/10] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-05-28 Thread Richard Henderson
On 05/28/2014 10:42 AM, Lluís Vilanova wrote: > Files generating guest code (TCG) must include "trace-tcg.h". Files declaring > per-target helpers ("${target}/helper.h") must include > "trace/generated-helpers.h". This should be simpler now, with the header rearrangement that went into mainline to

Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 20:24, Andreas Färber ha scritto: >>> +void alpha_cpu_do_unaligned_access(CPUState *cs, vaddr addr, >>> + int is_write, int is_user, >>> uintptr_t retaddr) >>> { >>> -AlphaCPU *cpu = alpha_env_get_cpu(env); >>> -CPUState *cs = CPU(cpu); >>>

Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU

2014-05-28 Thread Andreas Färber
Am 28.05.2014 20:17, schrieb Paolo Bonzini: > Il 28/05/2014 19:20, Andreas Färber ha scritto: >>> +void alpha_cpu_do_unaligned_access(CPUState *cs, vaddr addr, >>> + int is_write, int is_user, >>> uintptr_t retaddr) >>> { >>> -AlphaCPU *cpu = alpha_env_get_cpu

Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 19:20, Andreas Färber ha scritto: +void alpha_cpu_do_unaligned_access(CPUState *cs, vaddr addr, + int is_write, int is_user, uintptr_t retaddr) { -AlphaCPU *cpu = alpha_env_get_cpu(env); -CPUState *cs = CPU(cpu); +AlphaCPU *cpu = ALPHA

[Qemu-devel] [PATCH v2 1/1] bsd-user: refresh freebsd system call numbers

2014-05-28 Thread Sean Bruno
From: Stacey Son Update FreeBSD system call numbers in freebsd/syscall_nr.h. Signed-off bY: Stacey Son Signed-off-by: Sean Bruno Reviewed-by: Ed Maste --- bsd-user/freebsd/syscall_nr.h | 813 +++--- 1 file changed, 445 insertions(+), 368 deletions(-) dif

[Qemu-devel] [PATCH v3 05/10] trace: [tcg] Declare TCG tracing helper routines

2014-05-28 Thread Lluís Vilanova
Generate header "trace/generated-helpers.h" with the necessary TCG helper declarations for tracing events in guest code at execution time: * gen_helper_trace_${event}_exec Routine to transform mixed native and TCG argument types to TCG types and call TCG helper 'gen_helper_trace_${event}_exec

[Qemu-devel] [PATCH v3 10/10] trace: [tcg] Include TCG-tracing header on all targets

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-alpha/translate.c |3 +++ target-arm/translate-a64.c|2 ++ target-arm/translate.c|3 +++ target-cris/translate.c |3 +++ target-i386/translate.c |3 +++ target-lm32/translate.c |3 +++ target-m68k/

[Qemu-devel] [PATCH v3 09/10] trace: [tcg] Include event definitions in "trace.h"

2014-05-28 Thread Lluís Vilanova
Otherwise the user has to explicitly include an auto-generated header. Signed-off-by: Lluís Vilanova --- include/trace.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/trace.h b/include/trace.h index c15f498..44a1f1f 100644 --- a/include/trace.h +++ b/include/trace.h @@ -2,5 +2,6

[Qemu-devel] [PATCH v3 08/10] trace: [tcg] Generate TCG tracing routines

2014-05-28 Thread Lluís Vilanova
Generate header "trace/generated-tcg-tracers.h" with the necessary routines for tracing events in guest code: * trace_${event}_tcg Convenience wrapper that calls the translation-time tracer 'trace_${event}_trans', and calls 'gen_helper_trace_${event}_exec to generate the TCG code to later t

[Qemu-devel] [PATCH v2 10/10] trace: [tcg] Include TCG-tracing header on all targets

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-alpha/translate.c |3 +++ target-arm/translate-a64.c|2 ++ target-arm/translate.c|3 +++ target-cris/translate.c |3 +++ target-i386/translate.c |3 +++ target-lm32/translate.c |3 +++ target-m68k/

[Qemu-devel] [PATCH v3 07/10] trace: [tcg] Include TCG-tracing helpers on all helper.h

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-alpha/helper.h |2 ++ target-arm/helper.h|2 ++ target-cris/helper.h |2 ++ target-i386/helper.h |2 ++ target-lm32/helper.h |2 ++ target-m68k/helper.h |2 ++ target-microblaze/helper.h |2 +

[Qemu-devel] [PATCH v3 02/10] trace: [tcg] Argument type transformation rules

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/transform.py | 166 1 file changed, 166 insertions(+) create mode 100644 scripts/tracetool/transform.py diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py new file mode 100644

[Qemu-devel] [PATCH v3 01/10] trace: [tcg] Add documentation

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 40 1 file changed, 40 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index c6ab1c1..2e035a5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -307,3 +307,43 @@ guard such comput

[Qemu-devel] [PATCH v3 06/10] trace: [tcg] Define TCG tracing helper routines

2014-05-28 Thread Lluís Vilanova
Generate file "trace/generated-helpers.c" with the necessary TCG helper routines for tracing events in guest code at execution time: * helper_trace_${event}_exec_proxy TCG helper implementation to cast TCG-compatible argument types to native types and call tracing routine 'trace_${event}_exec

Re: [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers

2014-05-28 Thread Stefan Weil
Am 28.05.2014 19:43, schrieb Richard Henderson: > On 05/28/2014 10:21 AM, Stefan Weil wrote: >> The alpha ROM obviously does not trigger coroutines. Block I/O usually does. > > Sure. But obviously it also contains load/store operations. > > > r~ > My remark on coroutines should explain why yo

Re: [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers

2014-05-28 Thread Richard Henderson
On 05/28/2014 10:21 AM, Stefan Weil wrote: > The alpha ROM obviously does not trigger coroutines. Block I/O usually does. Sure. But obviously it also contains load/store operations. r~

[Qemu-devel] [PATCH v3 04/10] trace: [tcg] Add 'tcg' event property

2014-05-28 Thread Lluís Vilanova
Transforms event: tcg name(...) "...", "..." into two internal events: tcg-trans name_trans(...) "..." tcg-exec name_exec(...) "..." Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py| 64 +++--- scripts/tracetool/format/events_h.py |

[Qemu-devel] [PATCH v3 03/10] trace: [tcg] Argument type transformation machinery

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index e8e8edc..bd3fd85 100644 --- a/scripts/tracetool/__init__.py +++

[Qemu-devel] [PATCH v3 00/10] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-05-28 Thread Lluís Vilanova
NOTE: TCG code for execution-time event tracing is always generated, regardless of wether the event has been dynamically disabled or not (unless the event has the static "disable" property). This approach keeps this series simple, and a future series will handle the case of

Re: [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers

2014-05-28 Thread Stefan Weil
Am 28.05.2014 19:21, schrieb Stefan Weil: > Am 28.05.2014 19:12, schrieb Richard Henderson: >> On 05/27/2014 03:37 PM, Stefan Weil wrote: >>> Hi Richard, >>> >>> this patch has broken the 64 bit version of QEMU for Windows: a Linux >>> guest starts booting, but hangs after "Booting the kernel.". I

Re: [Qemu-devel] [PATCH v2 01/10] trace: [tcg] Add documentation

2014-05-28 Thread Lluís Vilanova
I forgot to add the cover. I'll resend as v3 with a cover. Sorry, Lluis

[Qemu-devel] [PATCH v2 05/10] trace: [tcg] Declare TCG tracing helper routines

2014-05-28 Thread Lluís Vilanova
Generate header "trace/generated-helpers.h" with the necessary TCG helper declarations for tracing events in guest code at execution time: * gen_helper_trace_${event}_exec Routine to transform mixed native and TCG argument types to TCG types and call TCG helper 'gen_helper_trace_${event}_exec

[Qemu-devel] [PATCH v2 07/10] trace: [tcg] Include TCG-tracing helpers on all helper.h

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-alpha/helper.h |2 ++ target-arm/helper.h|2 ++ target-cris/helper.h |2 ++ target-i386/helper.h |2 ++ target-lm32/helper.h |2 ++ target-m68k/helper.h |2 ++ target-microblaze/helper.h |2 +

[Qemu-devel] [PATCH v2 03/10] trace: [tcg] Argument type transformation machinery

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index e8e8edc..bd3fd85 100644 --- a/scripts/tracetool/__init__.py +++

[Qemu-devel] [PATCH v2 01/10] trace: [tcg] Add documentation

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 40 1 file changed, 40 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index c6ab1c1..2e035a5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -307,3 +307,43 @@ guard such comput

Re: [Qemu-devel] [PATCH v2 07/10] block: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-05-28 Thread Eric Blake
On 05/28/2014 08:25 AM, Markus Armbruster wrote: > Instead of bdrv_getlength(). > > Aside: a few of these callers don't handle errors. I didn't > investigate whether they should. > > Signed-off-by: Markus Armbruster > --- > block-migration.c | 9 - > block.c | 3 +-- > block/

[Qemu-devel] [PATCH v2 06/10] trace: [tcg] Define TCG tracing helper routines

2014-05-28 Thread Lluís Vilanova
Generate file "trace/generated-helpers.c" with the necessary TCG helper routines for tracing events in guest code at execution time: * helper_trace_${event}_exec_proxy TCG helper implementation to cast TCG-compatible argument types to native types and call tracing routine 'trace_${event}_exec

[Qemu-devel] [PATCH v2 04/10] trace: [tcg] Add 'tcg' event property

2014-05-28 Thread Lluís Vilanova
Transforms event: tcg name(...) "...", "..." into two internal events: tcg-trans name_trans(...) "..." tcg-exec name_exec(...) "..." Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py| 64 +++--- scripts/tracetool/format/events_h.py |

[Qemu-devel] [PULL 6/8] machine: Make -machine opts properties of MachineState

2014-05-28 Thread Andreas Färber
From: Marcel Apfelbaum Make machine's QemuOpts QOM properties of /machine. The properties are automatically filled in. This opens the possibility to create opts per machine rather than global. Signed-off-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin Acked-by: Michael Roth Signed-off-by: A

[Qemu-devel] [PATCH v2 08/10] trace: [tcg] Generate TCG tracing routines

2014-05-28 Thread Lluís Vilanova
Generate header "trace/generated-tcg-tracers.h" with the necessary routines for tracing events in guest code: * trace_${event}_tcg Convenience wrapper that calls the translation-time tracer 'trace_${event}_trans', and calls 'gen_helper_trace_${event}_exec to generate the TCG code to later t

[Qemu-devel] [PATCH v2 02/10] trace: [tcg] Argument type transformation rules

2014-05-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/transform.py | 166 1 file changed, 166 insertions(+) create mode 100644 scripts/tracetool/transform.py diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py new file mode 100644

[Qemu-devel] [PATCH v2 09/10] trace: [tcg] Include event definitions in "trace.h"

2014-05-28 Thread Lluís Vilanova
Otherwise the user has to explicitly include an auto-generated header. Signed-off-by: Lluís Vilanova --- include/trace.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/trace.h b/include/trace.h index c15f498..44a1f1f 100644 --- a/include/trace.h +++ b/include/trace.h @@ -2,5 +2,6

[Qemu-devel] [PULL 8/8] ssi: Name the CS GPIO

2014-05-28 Thread Andreas Färber
From: Peter Crosthwaite To get it out of the default GPIO list. This allows child devices to use the un-named GPIO namespace without having to be SSI aware. That is, there is no more need for machines to know about the obscure policy where GPIO 0 is the SSI chip-select and GPIO 1..N are the concr

[Qemu-devel] [PULL 4/8] qapi: Avoid output visitor crashing if it encounters a NULL value

2014-05-28 Thread Andreas Färber
From: Marcel Apfelbaum A NULL value is not added to visitor's stack, but there is no check for that when the visitor tries to return that value, leading to QEMU crash. Reviewed-by: Eric Blake Acked-by: Luiz Capitulino Signed-off-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin Acked-by: Mic

[Qemu-devel] [PULL 3/8] vl.c: Do not set 'type' property in obj_set_property()

2014-05-28 Thread Andreas Färber
From: Marcel Apfelbaum Filter out also 'type' property when setting object's properties. Reviewed-by: Paolo Bonzini Signed-off-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin Acked-by: Michael Roth Signed-off-by: Andreas Färber --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[Qemu-devel] [PULL 0/8] QOM devices patch queue 2014-05-28

2014-05-28 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. I've verified that the machine changes still build on FreeBSD. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Marcel Apfelbaum Cc: Peter Crosthwaite The following changes since commit 3ee933c9d4869891a5614fba4815a

[Qemu-devel] [PULL 1/8] qom-test: Test qom-list on link<> properties

2014-05-28 Thread Andreas Färber
From: Cole Robinson But don't test their properties, otherwise we will recurse forever. Their properties are already tested when we encounter them as child<> properties elsewhere in the hierarchy, like /machine/unattached/... This would have caught the crash fixed by 92b3eead. Signed-off-by: Co

[Qemu-devel] [PULL 7/8] qdev: Implement named GPIOs

2014-05-28 Thread Andreas Färber
From: Peter Crosthwaite Implement named GPIOs on the Device layer. Listifies the existing GPIOs stuff using string keys. Legacy un-named GPIOs are preserved by using a NULL name string - they are just a single matchable element in the name list. Reviewed-by: Peter Maydell Signed-off-by: Peter C

[Qemu-devel] [PULL 5/8] tests: Check empty QMP output visitor

2014-05-28 Thread Andreas Färber
From: Marcel Apfelbaum Checks the output visitor behaviour for NULL values. Signed-off-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin Acked-by: Michael Roth Signed-off-by: Andreas Färber --- tests/test-qmp-output-visitor.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/

[Qemu-devel] [PATCH 1/1] ppc-e500: on write to MMUCSR0, pass GPR content, not SPR number, to low-level TLB-flush routine

2014-05-28 Thread Alex Zuepke
A "mtspr SPRMMUCSR0, reg" always flushed TLB0, because it passed the SPR number 0x3f4 to the flush routine. But we want to flush either TLB0 or TBL1 depending on the GPR value. Signed-off-by: Alex Zuepke --- target-ppc/translate_init.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[Qemu-devel] (no subject)

2014-05-28 Thread Alex Zuepke
Put qemu-devel on CC

Re: [Qemu-devel] [PULL v4 00/18] tcg patch queue

2014-05-28 Thread Peter Maydell
On 28 May 2014 17:41, Richard Henderson wrote: > Ho hum. One more fix, this time for win32 in 11/18. > I installed enough mingw64 cross to compile and test. Applied; thanks for fixing up the issues. -- PMM

Re: [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers

2014-05-28 Thread Stefan Weil
Am 28.05.2014 19:12, schrieb Richard Henderson: > On 05/27/2014 03:37 PM, Stefan Weil wrote: >> Hi Richard, >> >> this patch has broken the 64 bit version of QEMU for Windows: a Linux >> guest starts booting, but hangs after "Booting the kernel.". I got a bug >> report from a user and did a "git bi

Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU

2014-05-28 Thread Andreas Färber
Am 23.05.2014 17:20, schrieb Paolo Bonzini: > We will reference it from more files in the next patch. To avoid > ruining the small steps we're making towards multi-target, make > it a method of CPU rather than just a global. > > Signed-off-by: Paolo Bonzini > --- > include/exec/softmmu_template

Re: [Qemu-devel] [PATCH v2 06/10] block: Use bdrv_nb_sectors() in img_convert()

2014-05-28 Thread Eric Blake
On 05/28/2014 08:25 AM, Markus Armbruster wrote: > Instead of bdrv_getlength(). Replace variable output_length by > output_sectors. > > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake

  1   2   3   4   >