On 28 May 2014 21:35, Gerd Hoffmann <kra...@redhat.com> wrote: > commit 3158a3482b0093e41f2b2596fba50774ea31ae08 added a XkbGetKeyboard > call, we'll need libX11 for that. Add it, otherwise the build will fail > with a linker error (unless X11 is linked anyway for other reasons, SDL > for example).
Isn't this going to break the Windows build by trying to link X11 if GTK is enabled? Also the code currently assumes that 'gtk and ndef _WIN32' means X11, which I think is probably not true for MacOSX GTK. I wouldn't object if we just disabled GTK for MacOSX though, since I think things get very confused if we don't use ui/cocoa.c because of the things that file does involving intercepting main(). thanks -- PMM
