Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-19 Thread Gerd Hoffmann
On Mo, 2014-05-19 at 19:09 +0300, Michael S. Tsirkin wrote: > On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > > Changelog: > > OK I queued this, but not yet pushed (to collect acks). > Gerd if it should be your tree instead pls let me know. I was planning to do a pull for this

Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Marc Marí
El Mon, 19 May 2014 15:07:18 -0600 Eric Blake escribió: > On 05/17/2014 05:03 PM, Marc Marí wrote: > > Modify debug macros to have the same format through the codebase > > and use regular ifs instead of ifdef. > > > > As the debug printf is always put in code, some formats had to be > > changed t

[Qemu-devel] [PATCH v20 05/15] block: Add bdrv_set_backing_hd()

2014-05-19 Thread Fam Zheng
This is the common but non-trivial steps to assign or change the backing_hd of BDS. Signed-off-by: Fam Zheng --- block.c | 36 +++- include/block/block.h | 1 + 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH qom v5 2/2] ssi: Name the CS GPIO.

2014-05-19 Thread Peter Crosthwaite
To get it out of the default GPIO list. This allows child devices to use the un-named GPIO namespace without having to be SSI aware. That is, there is no more need for machines to know about the obscure policy where GPIO 0 is the SSI chip-select and GPIO 1..N are the concrete class GPIOs (defined l

[Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-19 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not

[Qemu-devel] [PATCH qom v5 1/2] qdev: Implement named GPIOs

2014-05-19 Thread Peter Crosthwaite
Implement named GPIOs on the Device layer. Listifies the existing GPIOs stuff using string keys. Legacy un-named GPIOs are preserved by using a NULL name string - they are just a single matchable element in the name list. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- Changed si

[Qemu-devel] [PATCH qom v5 0/2] Named GPIOs

2014-05-19 Thread Peter Crosthwaite
This series implements Named GPIOs on the qdev level. Patch 1 is the feature presentation. Second patch I give a useful example of the feature's use (an SSI cleanup). This kinda falls through the cracks between the active maintainerships. In v4 review, Peter suggested QOM queue, can this go via?

[Qemu-devel] [PATCH v20 07/15] block: Parse "backing" option to reference existing BDS

2014-05-19 Thread Fam Zheng
Now it's safe to allow reference for backing_hd in the interface. Signed-off-by: Fam Zheng --- block.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index efec10a..4fc2dd7 100644 --- a/block.c +++ b/block.c @@ -1445,12 +1445,35

[Qemu-devel] DMA and e1000 networking driver

2014-05-19 Thread Ayaz Akram
Can e1000 driver in linux be used without DMA involvement? Actually I am trying to use e1000 network driver on octeon linux( to be run on QEMU), and I have not emulated any DMA controller, so I was wondering if I can be able to run networking without DMA's involvement?

[Qemu-devel] [PATCH V2 3/3] virtio-net: announce self by guest

2014-05-19 Thread Jason Wang
It's hard to track all mac addresses and their configurations (e.g vlan or ipv6) in qemu. Without this information, it's impossible to build proper garp packet after migration. The only possible solution to this is let guest (who knows all configurations) to do this. So, this patch introduces a ne

[Qemu-devel] [PATCH V2 1/3] migration: export SELF_ANNOUNCE_ROUNDS

2014-05-19 Thread Jason Wang
Export it for other users. Signed-off-by: Jason Wang --- include/migration/vmstate.h |2 ++ savevm.c|1 - 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 7e45048..6edce98 100644 --- a/inclu

[Qemu-devel] [PATCH V2 2/3] migration: introduce self_announce_delay()

2014-05-19 Thread Jason Wang
This patch introduces self_announce_delay() to calculate the delay for the next announce round. This could be used by other device e.g virtio-net who wants to do announcing by itself. Signed-off-by: Jason Wang --- include/migration/vmstate.h |8 savevm.c|2 +-

[Qemu-devel] [PATCH V2 0/3] virtio-net: announce self by guest

2014-05-19 Thread Jason Wang
Hi all: This series tries to do the announcing by guest through virito-net. This is done through inject the notificaiton interrupt to guest several times after migration and then guest driver will send the proper garp packets. Recent Linux driver has already had this support. Tested with ping to

[Qemu-devel] [PATCH v20 15/15] qemu-iotests: Image fleecing test case 089

2014-05-19 Thread Fam Zheng
This tests the workflow of creating a lightweight point-in-time snapshot with blockdev-backup command, and exporting it with built-in NBD server. It's tested that any post-snapshot writing to the original device doesn't change data seen in NBD target. Signed-off-by: Fam Zheng --- tests/qemu-iot

[Qemu-devel] [PATCH v20 14/15] qemu-iotests: Test blockdev-backup in 055

2014-05-19 Thread Fam Zheng
This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng --- tests/qemu-iotests/055 | 277 ++--- tests/qemu-iotests/055.out | 4 +- 2 files c

[Qemu-devel] [PATCH v20 13/15] block: Add blockdev-backup to transaction

2014-05-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 48 qapi-schema.json | 3 +++ 2 files changed, 51 insertions(+) diff --git a/blockdev.c b/blockdev.c index 287a2d8..14c5be6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1411,6 +1411,49 @@ static voi

[Qemu-devel] [PATCH v20 12/15] block: Allow backup on referenced named BlockDriverState

2014-05-19 Thread Fam Zheng
Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng --- block.c | 2

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-19 Thread Jason Wang
On 05/19/2014 06:06 PM, Michael S. Tsirkin wrote: > On Mon, May 19, 2014 at 05:34:38PM +0800, Jason Wang wrote: >> > On 05/18/2014 05:04 PM, Michael S. Tsirkin wrote: >>> > > On Fri, May 16, 2014 at 01:02:51PM +0800, Jason Wang wrote: > >> On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote:

[Qemu-devel] [PATCH v20 11/15] qmp: Add command 'blockdev-backup'

2014-05-19 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction of

[Qemu-devel] [PATCH v20 10/15] commit: Use bdrv_drop_intermediate

2014-05-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/mirror.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 6a53d79..b4b12d0 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -493,14 +493,10 @@ immediate_exit: if (bdrv_get_flags(s->t

[Qemu-devel] [PATCH v20 09/15] stream: Use bdrv_drop_intermediate and drop close_unused_images

2014-05-19 Thread Fam Zheng
This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng --- block/stream.c | 42 +- 1 file changed, 1 insertion(+), 41 deletions(-) diff --git a/block/stream.c b/block/stream.c index dd0b4ac..1b348a2 100644 --- a/block/stream.c +++ b/block/st

[Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation blocker

2014-05-19 Thread Fam Zheng
This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g. in place of star

[Qemu-devel] [PATCH v20 08/15] block: Support dropping active in bdrv_drop_intermediate

2014-05-19 Thread Fam Zheng
Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs to work with op blockers. Signed-off-by: Fam Zheng --- block.c| 139 - block/commit.c |

[Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-19 Thread Fam Zheng
It makes no sense to check for "any" blocker on bs, we are here only because of the mechanical conversion from in_use to op_blockers. Remove it now, and let the callers check specific operation types. Backup and mirror already have it, add checker to stream and commit. Signed-off-by: Fam Zheng Re

[Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-05-19 Thread Fam Zheng
Thanks for Eric's and Markus' reviewing! v20: Rebase to master, with minor improvements as listed below: [02/15] block: Introduce op_blockers to BlockDriverState Better error message in bdrv_op_is_blocked. (Markus) [03/15] block: Replace in_use with operation blocker

[Qemu-devel] [PATCH v20 02/15] block: Introduce op_blockers to BlockDriverState

2014-05-19 Thread Fam Zheng
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage is: * BDS user w

[Qemu-devel] [PATCH v20 01/15] block: Add BlockOpType enum

2014-05-19 Thread Fam Zheng
This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng Reviewed-by: Benoit Canet Reviewed-by: Jeff Cody --- include/block/block.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/block/block.h b/include/block/block

Re: [Qemu-devel] [PATCH v2 0/2] prep: Remove some clearly wrong assumptions

2014-05-19 Thread Hervé Poussineau
Ping. Le 23/04/2014 23:19, Hervé Poussineau a écrit : Hi, These two patches remove some bugs for a PReP firmware. Note that first patch is very PReP-oriented, and breaks OHW compatibility with other QEMU emulations (oldworld and newworld machines). Patches to remove corresponding hacks on QEM

Re: [Qemu-devel] [Xen-devel] [v2][PATCH 6/8] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-19 Thread Chen, Tiejun
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Monday, May 19, 2014 9:34 PM > To: Zhang, Yang Z > Cc: Chen, Tiejun; anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com; > m...@redhat.com; kelly.zyta...@amd.com; peter.mayd...@linaro.org; >

Re: [Qemu-devel] [Xen-devel] [v2][PATCH 3/8] xen, gfx passthrough: basic graphics passthrough support

2014-05-19 Thread Chen, Tiejun
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Monday, May 19, 2014 8:10 PM > To: Konrad Rzeszutek Wilk > Cc: Chen, Tiejun; anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com; > m...@redhat.com; kelly.zyta...@amd.com; peter.mayd...

[Qemu-devel] [PATCH] block: Fix compiler warning (unused local function)

2014-05-19 Thread Stefan Weil
Warning from gcc: block/iscsi.c:384:13: error: ‘iscsi_allocationmap_is_allocated’ defined but not used [-Werror=unused-function] The function is only used if LIBISCSI_FEATURE_IOVECTOR is defined. Signed-off-by: Stefan Weil --- block/iscsi.c |2 ++ 1 file changed, 2 insertions(+) diff --

Re: [Qemu-devel] [PATCH v19 15/16] qemu-iotests: Test blockdev-backup in 055

2014-05-19 Thread Fam Zheng
On Mon, 05/19 13:46, Eric Blake wrote: > On 05/11/2014 07:35 PM, Fam Zheng wrote: > > This applies cases on drive-backup on blockdev-backup, except cases with > > target format and mode. > > > > Also add a case to check source == target. > > > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-i

Re: [Qemu-devel] [PATCH v19 09/16] block: Support dropping active in bdrv_drop_intermediate

2014-05-19 Thread Fam Zheng
On Mon, 05/19 13:38, Eric Blake wrote: > On 05/11/2014 07:35 PM, Fam Zheng wrote: > > Dropping intermediate could be useful both for commit and stream, and > > BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs > > to work with op blockers. > > > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH v19 07/16] block: Add backing_blocker in BlockDriverState

2014-05-19 Thread Fam Zheng
On Mon, 05/19 22:23, Markus Armbruster wrote: > Eric Blake writes: > > > On 05/11/2014 07:35 PM, Fam Zheng wrote: > >> This makes use of op_blocker and blocks all the operations except for > >> commit target, on each BlockDriverState->backing_hd. > >> > >> The asserts for op_blocker in bdrv_swap

Re: [Qemu-devel] [PATCH v19 04/16] block: Replace in_use with operation blocker

2014-05-19 Thread Fam Zheng
On Mon, 05/19 16:28, Markus Armbruster wrote: > Fam Zheng writes: > > > This drops BlockDriverState.in_use with op_blockers: > > > > - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). > > - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). > > - Check bdrv_op_is_blocked

Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum

2014-05-19 Thread Fam Zheng
On Mon, 05/19 18:15, Markus Armbruster wrote: > Eric Blake writes: > > > On 05/11/2014 07:35 PM, Fam Zheng wrote: > >> This adds the enum of all the operations that can be taken on a block > >> device. > >> > >> Signed-off-by: Fam Zheng > >> Reviewed-by: Benoit Canet > >> Reviewed-by: Jeff Cod

Re: [Qemu-devel] qemu-ppc and NUMA topology

2014-05-19 Thread Alexey Kardashevskiy
On 05/20/2014 10:06 AM, Nishanth Aravamudan wrote: > On 19.05.2014 [15:37:52 -0700], Nishanth Aravamudan wrote: >> Hi Alexey, >> >> I've been looking at hw/ppc/spapr.c::spapr_populate_memory() and ran >> into a few questions: >> >> 1) The values from 1 to nb_numa_nodes are used as indices into the

[Qemu-devel] [PATCH v2] aio: Fix use-after-free in cancellation path

2014-05-19 Thread Fam Zheng
The current flow of canceling a thread from THREAD_ACTIVE state is: 1) Caller wants to cancel a request, so it calls thread_pool_cancel. 2) thread_pool_cancel waits on the conditional variable elem->check_cancel. 3) The worker thread changes state to THREAD_DONE once the task is

[Qemu-devel] [PATCH v2] qemu-iotests: Handle cache mode option in 091

2014-05-19 Thread Fam Zheng
We should allow testing this on tmpfs. Any cache setting in iotests should try to obey $CACHEMODE. The cache mode is still "none" by default but overridable Signed-off-by: Fam Zheng --- v2: Add _default_cache_mode and _supported_cache_modes. (Kevin) --- tests/qemu-iotests/091 | 6 -- 1 fil

Re: [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091

2014-05-19 Thread Fam Zheng
On Mon, 05/19 16:40, Kevin Wolf wrote: > Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben: > > We should allow testing this on tmpfs. Any cache setting in iotests > > should try to obey $CACHEMODE. > > > > Signed-off-by: Fam Zheng > > Should we set _default_cache_mode=none then at least? Yes we

Re: [Qemu-devel] qemu-ppc and NUMA topology

2014-05-19 Thread Nishanth Aravamudan
On 19.05.2014 [15:37:52 -0700], Nishanth Aravamudan wrote: > Hi Alexey, > > I've been looking at hw/ppc/spapr.c::spapr_populate_memory() and ran > into a few questions: > > 1) The values from 1 to nb_numa_nodes are used as indices into the > node_mem array, but that is not populated, necessarily,

Re: [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy

2014-05-19 Thread Eduardo Habkost
On Tue, May 06, 2014 at 05:27:46PM +0800, Hu Tao wrote:\ [...] > +static void > +set_host_nodes(Object *obj, Visitor *v, void *opaque, const char *name, > + Error **errp) > +{ > +#ifdef CONFIG_NUMA > +HostMemoryBackend *backend = MEMORY_BACKEND(obj); > +uint16List *l = NULL; >

[Qemu-devel] [PATCH 6/7] monitor: Add host_net_remove arguments completion.

2014-05-19 Thread Hani Benhabiles
Relies on readline unique completion strings patch to make the added vlan/hub completion values unique, instead of using something like a hash table. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 38 ++ 3

Re: [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy

2014-05-19 Thread Eduardo Habkost
On Tue, May 06, 2014 at 05:27:46PM +0800, Hu Tao wrote: [...] > @@ -203,6 +296,20 @@ host_memory_backend_memory_init(UserCreatable *uc, Error > **errp) > if (backend->prealloc) { > os_mem_prealloc(memory_region_get_fd(&backend->mr), ptr, sz); > } > + > +#ifdef CONFIG_NUMA > +

[Qemu-devel] monitor: Command completion for various commands

2014-05-19 Thread Hani Benhabiles
A set of patches adding completion support for various hmp commands. Following other series that were merged earlier. Hani Benhabiles (7): monitor: Add ringbuf_write and ringbuf_read argument completion. monitor: Add watchdog_action argument completion. monitor: Add migrate_set_capability co

[Qemu-devel] [PATCH 2/7] monitor: Add watchdog_action argument completion.

2014-05-19 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 14 ++ 3 files changed, 17 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index dcec5ef..45e1763 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1359,6 +1359,7 @

[Qemu-devel] [PATCH 1/7] monitor: Add ringbuf_write and ringbuf_read argument completion.

2014-05-19 Thread Hani Benhabiles
Export chr_is_ringbuf() function. Also remove left-over function prototypes while at it. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ include/sysemu/char.h | 3 +-- monitor.c | 39 +++ qemu-char.

[Qemu-devel] [PATCH 7/7] monitor: Add delvm and loadvm argument completion.

2014-05-19 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ monitor.c | 48 3 files changed, 52 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 935f744..d68a00b 100644 --- a/hmp-commands.hx +++ b/h

Re: [Qemu-devel] monitor: Command completion for various commands

2014-05-19 Thread Hani Benhabiles
On Tue, May 20, 2014 at 12:01:01AM +0100, Hani Benhabiles wrote: > A set of patches adding completion support for various hmp commands. Following > other series that were merged earlier. > Resent the complete series. Please ignore this incomplete one. Sorry for the flood. > Hani Benhabiles (7):

[Qemu-devel] [PATCH 3/7] monitor: Add migrate_set_capability completion.

2014-05-19 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 21 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 45e1763..919af6e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -975,6 +97

[Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument completion.

2014-05-19 Thread Hani Benhabiles
Also fix the parameters documentation. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 14 ++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 919af6e..6aaec1b 100644 --- a/hm

[Qemu-devel] [PATCH 5/7] readline: Make completion strings always unique.

2014-05-19 Thread Hani Benhabiles
There is no need to clutter the user's choices with repeating the same value multiple times. Signed-off-by: Hani Benhabiles --- util/readline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/readline.c b/util/readline.c index 8baec55..7214e84 100644 --- a/util/readline.c +++ b/ut

[Qemu-devel] monitor: Command completion for various commands

2014-05-19 Thread Hani Benhabiles
A set of patches adding completion support for various hmp commands. Following other series that were merged earlier. Hani Benhabiles (7): monitor: Add ringbuf_write and ringbuf_read argument completion. monitor: Add watchdog_action argument completion. monitor: Add migrate_set_capability co

[Qemu-devel] [PATCH 3/7] monitor: Add migrate_set_capability completion.

2014-05-19 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 21 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 45e1763..919af6e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -975,6 +97

[Qemu-devel] [PATCH 1/7] monitor: Add ringbuf_write and ringbuf_read argument completion.

2014-05-19 Thread Hani Benhabiles
Export chr_is_ringbuf() function. Also remove left-over function prototypes while at it. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ include/sysemu/char.h | 3 +-- monitor.c | 39 +++ qemu-char.

[Qemu-devel] [PATCH 2/7] monitor: Add watchdog_action argument completion.

2014-05-19 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 14 ++ 3 files changed, 17 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index dcec5ef..45e1763 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1359,6 +1359,7 @

[Qemu-devel] qemu-ppc and NUMA topology

2014-05-19 Thread Nishanth Aravamudan
Hi Alexey, I've been looking at hw/ppc/spapr.c::spapr_populate_memory() and ran into a few questions: 1) The values from 1 to nb_numa_nodes are used as indices into the node_mem array, but that is not populated, necessarily, linearly. vl.c::add_node() uses the nodeid parameter as the index into n

Re: [Qemu-devel] [PATCH] block: iscsi build fix if LIBISCSI_FEATURE_IOVECTOR is not defined

2014-05-19 Thread Peter Lieven
Am 19.05.2014 um 23:13 schrieb Jeff Cody : > Commit b03c380 introduced the function > iscsi_allocationmap_is_allocated(), however it is only used within a > code block that is conditionally compiled. This produces a warning > (error with -werror) of "defined but not used" for the the function, i

[Qemu-devel] [PATCH v4] QemuOpt: add unit tests

2014-05-19 Thread Leandro Dorileo
Cover basic aspects and API usage for QemuOpt. The current implementation covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter replacement/cleanup job. Other APIs should be covered in future improvements. Signed-off-by: Leandro Dorileo --- Notes: V4: + call

Re: [Qemu-devel] [PATCH] vl.c: daemonize before guest memory allocation

2014-05-19 Thread Igor Mammedov
On Mon, 19 May 2014 15:28:55 -0600 Eric Blake wrote: > On 05/19/2014 03:24 PM, Igor Mammedov wrote: > > memory allocated for guest before QEMU is demonized and then mapped > > s/demonized/daemonized/ > > > later in guest's addess space after it is demonized, leads to EPT > > s/addess/address/,

Re: [Qemu-devel] [PATCH v3] QemuOpt: add unit tests

2014-05-19 Thread Leandro Dorileo
On Fri, May 02, 2014 at 10:40:33AM +0200, Stefan Hajnoczi wrote: > On Tue, Mar 25, 2014 at 10:27:19AM -0300, Leandro Dorileo wrote: > > Cover basic aspects and API usage for QemuOpt. The current implementation > > covers the API's planned to be changed by Chunyan Liu in his > > QEMUOptionParameter

Re: [Qemu-devel] [PATCH v3] QemuOpt: add unit tests

2014-05-19 Thread Leandro Dorileo
On Wed, Apr 30, 2014 at 10:28:26AM +0200, Markus Armbruster wrote: > Leandro Dorileo writes: > > > Hi Andreas, > > > > On Mon, Apr 28, 2014 at 09:02:12PM +0200, Andreas Färber wrote: > >> Am 28.04.2014 20:55, schrieb Leandro Dorileo: > >> > ping? > >> > > >> > > >> > On Tue, Mar 25, 2014 at 10:

Re: [Qemu-devel] [PATCH] vl.c: daemonize before guest memory allocation

2014-05-19 Thread Eric Blake
On 05/19/2014 03:24 PM, Igor Mammedov wrote: > memory allocated for guest before QEMU is demonized and then mapped s/demonized/daemonized/ > later in guest's addess space after it is demonized, leads to EPT s/addess/address/, daemonized again > violation and QEMU abort. > > To avoid this and s

[Qemu-devel] [PATCH] vl.c: daemonize before guest memory allocation

2014-05-19 Thread Igor Mammedov
memory allocated for guest before QEMU is demonized and then mapped later in guest's addess space after it is demonized, leads to EPT violation and QEMU abort. To avoid this and similar issues switch to deamonized mode early before processing applying/processing other options. Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 2/2] nbd: Don't validate from and len in NBD_CMD_DISC.

2014-05-19 Thread Hani Benhabiles
On Mon, May 19, 2014 at 01:05:12PM +0200, Paolo Bonzini wrote: > Il 18/05/2014 12:50, Hani Benhabiles ha scritto: > >These values aren't used in this case. > > > >Currently, the from field in the request sent by the nbd kernel module > >leading > >to a false error message when ending the connectio

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2014-05-19 Thread Bruce Rogers
Martin, The OBS Virtualization/qemu project doesn't build QEMU v2.0 with libusb support for openSUSE 13.1, because the version provided in that distro was 1.0.9, and QEMU's configure requires 1.0.13. Bruce -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH] block: iscsi build fix if LIBISCSI_FEATURE_IOVECTOR is not defined

2014-05-19 Thread Jeff Cody
Commit b03c380 introduced the function iscsi_allocationmap_is_allocated(), however it is only used within a code block that is conditionally compiled. This produces a warning (error with -werror) of "defined but not used" for the the function, if LIBISCSI_FEATURE_IOVECTOR is not defined. This wra

Re: [Qemu-devel] [PATCH V26 00/32] replace QEMUOptionParameter with QemuOpts

2014-05-19 Thread Leandro Dorileo
On Sun, May 18, 2014 at 09:02:45PM -0600, Chun Yan Liu wrote: > > > >>> On 5/6/2014 at 09:26 PM, in message > <20140506132615.gv15...@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi > wrote: > > On Tue, Apr 29, 2014 at 05:10:24PM +0800, Chunyan Liu wrote: > > > This patch series is to replace Q

Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Eric Blake
On 05/17/2014 05:03 PM, Marc Marí wrote: > Modify debug macros to have the same format through the codebase and use > regular > ifs instead of ifdef. > > As the debug printf is always put in code, some formats had to be changed to > avoid warnings treated as errors at compile time.. > > Signed-o

Re: [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Eric Blake
On 05/17/2014 05:03 PM, Marc Marí wrote: > Modify debug macros to have the same format through the codebase and use > regular > ifs instead of ifdef. > > Signed-off-by: Marc Marí > --- > hw/sd/sd.c |8 +--- > hw/sd/ssi-sd.c | 19 --- > 2 files changed, 17 insertion

[Qemu-devel] [PATCH v2] target-arm: implement CPACR register logic for ARMv7

2014-05-19 Thread Fabian Aggeler
In ARMv7 the CPACR register allows to control access rights to coprocessor 0-13 interfaces. Bits corresponding to unimplemented coprocessors should be RAZ/WI. Bits ASEDIS, D32DIS, TRCDIS are UNK/SBZP if VFP is not implemented and RAO/WI in some cases. Treating TRCDIS as RAZ/WI since we neither impl

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Alexander Graf
On 19.05.14 22:33, Peter Crosthwaite wrote: On Tue, May 20, 2014 at 2:50 AM, Richard Henderson wrote: On 05/19/2014 09:45 AM, Marc Marí wrote: This STDOUT vs _log() choice is a bit irregular, and I think you might be better off abandoning it completely. Richard, Alex, do we really need to opt

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Peter Crosthwaite
On Tue, May 20, 2014 at 2:50 AM, Richard Henderson wrote: > On 05/19/2014 09:45 AM, Marc Marí wrote: >>> > This STDOUT vs _log() choice is a bit irregular, and I think you might >>> > be better off abandoning it completely. Richard, Alex, do we really >>> > need to optionally route printfery to lo

Re: [Qemu-devel] [PATCH v19 07/16] block: Add backing_blocker in BlockDriverState

2014-05-19 Thread Markus Armbruster
Eric Blake writes: > On 05/11/2014 07:35 PM, Fam Zheng wrote: >> This makes use of op_blocker and blocks all the operations except for >> commit target, on each BlockDriverState->backing_hd. >> >> The asserts for op_blocker in bdrv_swap are removed because with this >> change, the target of bloc

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-19 Thread Alexander Graf
On 19.05.14 19:03, Michael Mueller wrote: On Mon, 19 May 2014 16:49:28 +0200 Alexander Graf wrote: On 19.05.14 16:18, Michael Mueller wrote: On Mon, 19 May 2014 13:48:08 +0200 Alexander Graf wrote: On 19.05.14 12:53, Michael Mueller wrote: On Fri, 16 May 2014 22:31:12 +0200 Alexander Gra

Re: [Qemu-devel] [PATCH v4 0/4] little-endian dump for ppc64

2014-05-19 Thread Alexander Graf
On 19.05.14 19:57, Greg Kurz wrote: Hi, Here are latest bits I have to support ppc64le guest dumps. Changes since v3 are: - fixed altivec registers support (patch 2) - kicked "virtio" out of the descriton of patch 3 since it won't rely on LPCR_ILE The other two patches are unchanged. I rese

Re: [Qemu-devel] [PATCH v19 15/16] qemu-iotests: Test blockdev-backup in 055

2014-05-19 Thread Eric Blake
On 05/11/2014 07:35 PM, Fam Zheng wrote: > This applies cases on drive-backup on blockdev-backup, except cases with > target format and mode. > > Also add a case to check source == target. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/055 | 275 > +

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-19 Thread Michael S. Tsirkin
On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > Changelog: > > new in v4: > - slightly improved commit blurbs > > v3: > - endian-ness fix (1/3) now correctly handles cpuid version and features > - included documentation (qemu-options.hx) for type 0 uefi flag (2/3) > -

Re: [Qemu-devel] [PATCH v19 07/16] block: Add backing_blocker in BlockDriverState

2014-05-19 Thread Eric Blake
On 05/11/2014 07:35 PM, Fam Zheng wrote: > This makes use of op_blocker and blocks all the operations except for > commit target, on each BlockDriverState->backing_hd. > > The asserts for op_blocker in bdrv_swap are removed because with this > change, the target of block commit has at least the ba

Re: [Qemu-devel] [PATCH v19 09/16] block: Support dropping active in bdrv_drop_intermediate

2014-05-19 Thread Eric Blake
On 05/11/2014 07:35 PM, Fam Zheng wrote: > Dropping intermediate could be useful both for commit and stream, and > BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs > to work with op blockers. > > Signed-off-by: Fam Zheng > --- > block.c| 139 > +++

[Qemu-devel] [Bug 1320968] [NEW] qemu-system-ppc -cpu G2leGP3 crashes

2014-05-19 Thread Brandon Williams
Public bug reported: qemu crashes when running qemu-system-ppc -cpu G2leGP3 : qemu-system-ppc -cpu G2leGP3 Error: Trying to register SPR 1013 (3f5) twice ! qemu-system-ppc -version QEMU emulator version 2.0.50, Copyright (c) 2003-2008 Fabrice Bellard ** Affects: qemu Importance: Undecided

[Qemu-devel] [Bug 1320968] Re: qemu-system-ppc -cpu G2leGP3 crashes

2014-05-19 Thread Brandon Williams
** Tags added: ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1320968 Title: qemu-system-ppc -cpu G2leGP3 crashes Status in QEMU: New Bug description: qemu crashes when running qemu-system

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-19 Thread Dr. David Alan Gilbert
* Andreas F?rber (afaer...@suse.de) wrote: > Am 19.05.2014 15:06, schrieb Greg Kurz: > > On Mon, 19 May 2014 10:39:09 +0200 > > Greg Kurz wrote: > >> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > >> index 7fbad29..6578854 100644 > >> --- a/hw/virtio/virtio.c > >> +++ b/hw/virtio/virtio.c

[Qemu-devel] [PATCH v4 3/4] target-ppc: ppc can be either endian

2014-05-19 Thread Greg Kurz
POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR special purpose register to decide the endianness to use when entering interrupt handlers. When running a Linux guest, this provides a hint on the endianness used by the kernel. And when it comes to dumping a guest, the information is

[Qemu-devel] [PATCH v4 4/4] target-ppc: Set the correct endianness in ELF dump header

2014-05-19 Thread Greg Kurz
From: Bharata B Rao Signed-off-by: Bharata B Rao Reviewed-by: Alexander Graf Signed-off-by: Greg Kurz --- No change. target-ppc/arch_dump.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target-ppc/arch_dump.c b/target-ppc/arch_dump.c index 5a3b40d..5aca

[Qemu-devel] [PATCH v4 2/4] target-ppc: Support dump for little endian ppc64

2014-05-19 Thread Greg Kurz
From: Bharata B Rao Fix ppc64 arch specific dump code to support all combinations of little/big endian hosts/guests. FWIW the current code is broken for altivec registers when guest and host have a different endianness: these 128-bit registers are written to guest memory as a two 64-bit entities

[Qemu-devel] [PATCH v4 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-05-19 Thread Greg Kurz
From: Bharata B Rao Make DumpState and endian conversion routines available for arch-specific dump code by moving into dump.h. DumpState will be needed by arch-specific dump code to access target endian information from DumpState->ArchDumpInfo. Also break the dependency of dump.h from stubs/dump.

[Qemu-devel] [PATCH v4 0/4] little-endian dump for ppc64

2014-05-19 Thread Greg Kurz
Hi, Here are latest bits I have to support ppc64le guest dumps. Changes since v3 are: - fixed altivec registers support (patch 2) - kicked "virtio" out of the descriton of patch 3 since it won't rely on LPCR_ILE The other two patches are unchanged. I resend the whole patch set in case Alex feel

Re: [Qemu-devel] [PATCH] configure: Put tempfiles in a subdir of the build directory

2014-05-19 Thread Peter Maydell
On 19 May 2014 18:46, Eric Blake wrote: > On 05/19/2014 11:19 AM, Peter Maydell wrote: >> -# NB: do not call "exit" in the trap handler; this is buggy with some >> shells; >> -# see <1285349658-3122-1-git-send-email-loic.min...@linaro.org> >> -trap "rm -f $TMPC $TMPO $TMPCXX $TMPE" EXIT INT QUIT

Re: [Qemu-devel] [PATCH] configure: Put tempfiles in a subdir of the build directory

2014-05-19 Thread Eric Blake
On 05/19/2014 11:19 AM, Peter Maydell wrote: > When libtool support was added to configure, the new temporary files > were left out of the list of files cleaned up on exit; this results > in a lot of stale .lo files being left around in /tmp. Worse, libtool > creates a /tmp/.libs directory which we

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-19 Thread Greg Kurz
On Mon, 19 May 2014 19:06:39 +0200 Andreas Färber wrote: > Am 19.05.2014 15:06, schrieb Greg Kurz: > > On Mon, 19 May 2014 10:39:09 +0200 > > Greg Kurz wrote: > >> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > >> index 7fbad29..6578854 100644 > >> --- a/hw/virtio/virtio.c > >> +++ b/hw/

[Qemu-devel] [PATCH] configure: Put tempfiles in a subdir of the build directory

2014-05-19 Thread Peter Maydell
When libtool support was added to configure, the new temporary files were left out of the list of files cleaned up on exit; this results in a lot of stale .lo files being left around in /tmp. Worse, libtool creates a /tmp/.libs directory which we can't easily clean up. Put all our temporary files

Re: [Qemu-devel] [PATCH v2 5/5] error: error_is_set() is finally unused; remove

2014-05-19 Thread Eric Blake
On 05/19/2014 10:57 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/qapi/error.h | 6 -- > util/error.c | 5 - > 2 files changed, 11 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-devel] [PATCHv3 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-05-19 Thread Andreas Färber
Am 19.05.2014 15:03, schrieb Mark Cave-Ayland: > On 08/05/14 15:34, Andreas Färber wrote: >> Am 19.02.2014 22:39, schrieb Mark Cave-Ayland: >>> On 19/02/14 13:35, Leandro Dorileo wrote: > +static void cg3_realizefn(DeviceState *dev, Error **errp) > +{ > +SysBusDevice *sbd = SYS_BUS_

Re: [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling

2014-05-19 Thread Eric Blake
On 05/19/2014 10:57 AM, Markus Armbruster wrote: > Character backend open hasn't been fully converted to the Error API. > Some opens fail without setting an error. qmp_chardev_add() needs to > detect when that happens, and set a generic error. Explain that in a > comment, and inline error_is_set(

Re: [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set()

2014-05-19 Thread Eric Blake
On 05/19/2014 10:57 AM, Markus Armbruster wrote: > Using error_is_set(ERRP) to find out whether a function failed is > either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP > may be null, because errors go undetected when it is. It's fragile > when proving ERRP non-null involves a

Re: [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp)

2014-05-19 Thread Eric Blake
On 05/19/2014 10:57 AM, Markus Armbruster wrote: > Using error_is_set(errp) to check whether a function call failed is > fragile: it breaks when errp is null. Check perfectly suitable return > values instead when possible. As far as I can tell, errp can't be > null there, but this is more robust

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-19 Thread Richard W.M. Jones
On Mon, May 19, 2014 at 06:00:26PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > VMWare apparently doesn't like running under QEMU due to our > incomplete emulation of it's special IO Port. This adds a > -machine suboption to allow it to be turned off. > > Sign

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-19 Thread Andreas Färber
Am 19.05.2014 15:06, schrieb Greg Kurz: > On Mon, 19 May 2014 10:39:09 +0200 > Greg Kurz wrote: >> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c >> index 7fbad29..6578854 100644 >> --- a/hw/virtio/virtio.c >> +++ b/hw/virtio/virtio.c [...] >> @@ -839,10 +849,39 @@ typedef struct VirtIOSubse

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-19 Thread Michael Mueller
On Mon, 19 May 2014 16:49:28 +0200 Alexander Graf wrote: > > On 19.05.14 16:18, Michael Mueller wrote: > > On Mon, 19 May 2014 13:48:08 +0200 > > Alexander Graf wrote: > > > >> On 19.05.14 12:53, Michael Mueller wrote: > >>> On Fri, 16 May 2014 22:31:12 +0200 > >>> Alexander Graf wrote: > >>>

  1   2   3   >