On 05/19/2014 10:57 AM, Markus Armbruster wrote: > Using error_is_set(errp) to check whether a function call failed is > fragile: it breaks when errp is null. Check perfectly suitable return > values instead when possible. As far as I can tell, errp can't be > null there, but this is more robust and more obviously correct > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > qemu-char.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
