Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Samuel Thibault
Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > The search part looks OK to me but when adding to the arp table, don't > you at least want to avoid adding mappings for 0.0.0.0/32? I don't see the gain, actually. It would mean burning some CPU all the time just to save a small po

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Edgar E. Iglesias
On Thu, May 08, 2014 at 12:15:09AM +0200, Samuel Thibault wrote: > Do not special-case addresses with zero host part, as we do not > necessarily know how big it is, and the guest can fake them anyway. Hi Samuel, The search part looks OK to me but when adding to the arp table, don't you at least

[Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-07 Thread Fam Zheng
This drops the unnecessary bdrv_truncate() from, and also improves, cluster allocation code path. Before, when we need a new cluster, get_cluster_offset truncates the image to bdrv_getlength() + cluster_size, and returns the offset of added area, i.e. the image length before truncating. This is n

[Qemu-devel] [PATCH v3 2/3] vl.c: Use qemu_get_boot_opts

2014-05-07 Thread Peter Crosthwaite
To simplfiy and make consistent with surrounding code using qemu_get_machine_opts(). Create a new local variable name boot_opts for consistency as well. Signed-off-by: Peter Crosthwaite --- vl.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) dif

[Qemu-devel] [PATCH v3 3/3] nvram: fw_cfg: Fix -boot options in nvram/fw_cfg

2014-05-07 Thread Peter Crosthwaite
Multiple -boot options with the same ID are merged. All but the one without an ID are to be silently ignored. In other places, we query boot options with qemu_get_boot_opts(). This is correct. In this instance, we instead query whatever options come first in the list. This is wrong. When the -b

[Qemu-devel] [PATCH v3 1/3] vl.c: Add qemu_get_boot_opts()

2014-05-07 Thread Peter Crosthwaite
Same basic idea as qemu_get_machine_opts(). Signed-off-by: Peter Crosthwaite --- changed since v2: Use qemu_get_opts_singleton(Pao review) include/sysemu/sysemu.h | 1 + vl.c| 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/sysemu/sysemu.h b/include/

[Qemu-devel] [PATCH v3 0/3] Introduce qemu_get_boot_opts()

2014-05-07 Thread Peter Crosthwaite
Hi Markus, This series introduces qemu_get_boot_opts(), in much the same way as was done for qemu_get_machine_opts(). As usual, I have out-of-scope and out-of-tree usages :) But P3 does clean up the three existing instances of the long-and-awkward form of this query and makes the one in vl.c cons

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-07 Thread Gonglei (Arei)
Hi, > >> In Xen platform, after using upstream qemu, the all of pci devices will > >> show > >> hotplug in the windows guest. In this situation, the windows guest may > occur > >> blue screen when VM' user click the icon of VGA card for trying unplug VGA > >> card. > >> However, we don't hope VM'

[Qemu-devel] [PATCH] memory: Don't update all memory region when ioeventfd changed

2014-05-07 Thread arei.gonglei
From: Gonglei memory mappings don't rely on ioeventfds, there is no need to destroy and rebuild them when manipulating ioeventfds, otherwise it scarifies performance. according to testing result, each ioeventfd deleing needs about 5ms, within which memory mapping rebuilding needs about 4ms. With

Re: [Qemu-devel] [PATCH v1 4/5] xilinx_timer: Fix writes into TCSR register

2014-05-07 Thread Edgar E. Iglesias
On Thu, May 08, 2014 at 12:45:03PM +1000, Peter Crosthwaite wrote: > On Thu, May 8, 2014 at 11:35 AM, Edgar E. Iglesias > wrote: > > From: Guenter Roeck > > > > The TCSR register has only 11 valid bits. This is now used by the > > linux kernel to auto-detect endianness, and causes Linux 3.15-rc1

Re: [Qemu-devel] virtio-serial-pci very expensive during live migration

2014-05-07 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] virtio-serial-pci very expensive during live > migration > > Il 06/05/2014 22:01, Chris Friesen ha scritto: > > > > It seems like the main problem is that we loop over all the queues, > > calling virtio_pci_set_host_notifier_internal() on each of them. That > >

Re: [Qemu-devel] [PATCH v1 4/5] xilinx_timer: Fix writes into TCSR register

2014-05-07 Thread Peter Crosthwaite
On Thu, May 8, 2014 at 11:35 AM, Edgar E. Iglesias wrote: > From: Guenter Roeck > > The TCSR register has only 11 valid bits. This is now used by the > linux kernel to auto-detect endianness, and causes Linux 3.15-rc1 > and later to hang when run under qemu-microblaze. Mask valid bits > before wr

Re: [Qemu-devel] [PATCH v1 3/5] xilinx_intc: Fix writes into MER register

2014-05-07 Thread Peter Crosthwaite
On Thu, May 8, 2014 at 11:35 AM, Edgar E. Iglesias wrote: > From: Guenter Roeck > > The MER register only has two valid bits. This is now used by > the linux kernel to auto-detect endianness, and causes Linux 3.15-rc1 > and later to hang when run under qemu-microblaze. Mask valid bits before > wr

Re: [Qemu-devel] [PATCH v1 2/5] microblaze: Respect the reset vector

2014-05-07 Thread Peter Crosthwaite
On Thu, May 8, 2014 at 11:35 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite > --- > target-microblaze/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu

Re: [Qemu-devel] [PATCH v1 1/5] microblaze: Support loading of u-boot initrd images

2014-05-07 Thread Peter Crosthwaite
On Thu, May 8, 2014 at 11:35 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite > --- > hw/microblaze/boot.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/hw/microblaze/boot.c b/

[Qemu-devel] [PATCH v1 4/5] xilinx_timer: Fix writes into TCSR register

2014-05-07 Thread Edgar E. Iglesias
From: Guenter Roeck The TCSR register has only 11 valid bits. This is now used by the linux kernel to auto-detect endianness, and causes Linux 3.15-rc1 and later to hang when run under qemu-microblaze. Mask valid bits before writing the register to solve the problem. Signed-off-by: Guenter Roeck

[Qemu-devel] [PATCH v1 3/5] xilinx_intc: Fix writes into MER register

2014-05-07 Thread Edgar E. Iglesias
From: Guenter Roeck The MER register only has two valid bits. This is now used by the linux kernel to auto-detect endianness, and causes Linux 3.15-rc1 and later to hang when run under qemu-microblaze. Mask valid bits before writing the register to solve the problem. Signed-off-by: Guenter Roeck

[Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type()

2014-05-07 Thread Amos Kong
It's ugly to add const prefix for parameter type by a if statement outsider c_type(). This patch adds a parameter to do it. Signed-off-by: Amos Kong Suggested-by: Markus Armbruster --- scripts/qapi-commands.py | 4 +--- scripts/qapi.py | 4 +++- 2 files changed, 4 insertions(+), 4 dele

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-07 Thread Marcelo Tosatti
On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote: > When we migrate we ask the kernel about its current belief on what the guest > time would be. However, I've seen cases where the kvmclock guest structure > indicates a time more recent than the kvm returned time. > > To make sure we

[Qemu-devel] [PATCH v1 5/5] microblaze: boot: Don't hack the elf entry point

2014-05-07 Thread Edgar E. Iglesias
From: Peter Crosthwaite There was some modulo logic to ensure that Microblaze always booted into physical RAM regardless of the elf entry. Removed it, as QEMU should fail gracefully when given a bad elf, rather than attempt to run it. Signed-off-by: Peter Crosthwaite Signed-off-by: Edgar E. Igl

[Qemu-devel] [PATCH v1 2/5] microblaze: Respect the reset vector

2014-05-07 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-microblaze/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c index 8e04811..0379f2b 100644 --- a/target-microblaze/cpu.c +++ b/target-microblaze/cpu.c @@ -96,6 +96,8

[Qemu-devel] [PATCH v1 0/5] MicroBlaze queue

2014-05-07 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" These are some patches sitting in my queue that I'd like to push out. Cheers, Edgar Edgar E. Iglesias (2): microblaze: Support loading of u-boot initrd images microblaze: Respect the reset vector Guenter Roeck (2): xilinx_intc: Fix writes into MER register xil

[Qemu-devel] [PATCH v1 1/5] microblaze: Support loading of u-boot initrd images

2014-05-07 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/microblaze/boot.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c index 48d9e7a..deeecfc 100644 --- a/hw/microblaze/boot.c +++ b/hw/microblaze/boot.c @@

[Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list

2014-05-07 Thread Amos Kong
The space before pointers is redundant. Signed-off-by: Amos Kong --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index c6579be..25834e3 100644 --- a/scripts/qapi-visit.py +++ b/scri

[Qemu-devel] [PATCH v4 3/3] qapi: Suppress unwanted space between type and identifier

2014-05-07 Thread Amos Kong
We always generate a space between type and identifier in parameter and variable declarations, even when idiomatic C style doesn't have a space there. Suppress it. Signed-off-by: Amos Kong --- scripts/qapi.py | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/

[Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code

2014-05-07 Thread Amos Kong
Not a serious issue, but it's helpful if we can fix it. V2: split change of scripts/qapi-visit.py to a split patch, eat space by using a special char as Markus suggested V3: update commitlog, update special string, fix of adding const replace string by pattern V4: fix pattern to cleanup sp

Re: [Qemu-devel] [PATCH v1 16/22] target-arm: A64: Forbid ERET to unimplemented ELs

2014-05-07 Thread Edgar E. Iglesias
On Wed, May 07, 2014 at 10:00:11AM +0100, Peter Maydell wrote: > On 6 May 2014 07:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Check for EL2 support before returning to it. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/op_helper.c | 8 +++- > > 1 file

Re: [Qemu-devel] [PATCH v1 02/22] target-arm: Make elr_el1 an array

2014-05-07 Thread Edgar E. Iglesias
On Wed, May 07, 2014 at 03:10:54PM +1000, Peter Crosthwaite wrote: > On Tue, May 6, 2014 at 4:08 PM, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > No functional change. > > Prepares for future additions of the EL2 and 3 versions of this reg. > > > > Signed-off-by: Edgar E. Igle

Re: [Qemu-devel] [PATCH v1 01/22] target-arm: A64: Add friendly logging of PSTATE A and I flags

2014-05-07 Thread Edgar E. Iglesias
On Wed, May 07, 2014 at 09:50:27AM +0100, Peter Maydell wrote: > On 6 May 2014 07:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/translate-a64.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff

Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file

2014-05-07 Thread Luiz Capitulino
On Wed, 07 May 2014 20:46:15 +0200 Lluís Vilanova wrote: > The primitive uses JSON syntax, and include paths are relative to the file > using the directive: > > { 'include': 'path/to/file.json' } > > Signed-off-by: Lluís Vilanova > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-07 Thread Alexander Graf
On 08.05.14 01:21, Marcelo Tosatti wrote: On Tue, May 06, 2014 at 09:18:27AM +0200, Alexander Graf wrote: On 06.05.14 01:31, Marcelo Tosatti wrote: On Mon, May 05, 2014 at 08:23:43PM -0300, Marcelo Tosatti wrote: Hi Alexander, On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-07 Thread Marcelo Tosatti
On Tue, May 06, 2014 at 09:54:35PM +0200, Marcin Gibuła wrote: > >Yes, and it isn't. Any ideas why it's not? This patch really just uses > >the guest visible kvmclock time rather than the host view of it on > >migration. > > > >There is definitely something very broken on the host's side since it >

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-07 Thread Marcelo Tosatti
On Tue, May 06, 2014 at 09:18:27AM +0200, Alexander Graf wrote: > > On 06.05.14 01:31, Marcelo Tosatti wrote: > >On Mon, May 05, 2014 at 08:23:43PM -0300, Marcelo Tosatti wrote: > >>Hi Alexander, > >> > >>On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote: > >>>When we migrate we ask t

[Qemu-devel] [PATCH 6/6] monitor: Add netdev_del id argument completion.

2014-05-07 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 26 ++ 3 files changed, 28 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index a7f9b2f..2e462c0 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1252,

[Qemu-devel] [PATCH 5/6] monitor: Add netdev_add type argument completion.

2014-05-07 Thread Hani Benhabiles
Also update the command's documentation. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 15 +++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 3e7b29c..a7f9b2f 100644 --- a

[Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches

2014-05-07 Thread Hani Benhabiles
Compared to v1: * Dropped patch 02/07 for help completion conversion. * Nothing else changed. 04,05 and 06 are R-b by Stefan. Hani Benhabiles (6): monitor: Convert sendkey to use command_completion. monitor: Add chardev-remove command completion. monitor: Add chardev-add backend argument com

[Qemu-devel] [PATCH 2/6] monitor: Add chardev-remove command completion.

2014-05-07 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index b4b23c8..ba88e2a 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1639,6 +

[Qemu-devel] [PATCH 4/6] monitor: Add set_link arguments completion.

2014-05-07 Thread Hani Benhabiles
Make it possible to query all net clients without specifying an ID when calling qemu_find_net_clients_except(). This also adds the add_completion_option() function which is to be used for other commands completions as well. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h

[Qemu-devel] [PATCH 3/6] monitor: Add chardev-add backend argument completion.

2014-05-07 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index ba88e2a..93fa534 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1623,6 +

[Qemu-devel] [PATCH 1/6] monitor: Convert sendkey to use command_completion.

2014-05-07 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 32 +++- 3 files changed, 25 insertions(+), 9 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8971f1b..b4b23c8 100644 --- a/hmp-commands.hx +++ b/hmp

Re: [Qemu-devel] virtio-serial-pci very expensive during live migration

2014-05-07 Thread Chris Friesen
On 05/07/2014 12:39 AM, Paolo Bonzini wrote: Il 06/05/2014 22:01, Chris Friesen ha scritto: It seems like the main problem is that we loop over all the queues, calling virtio_pci_set_host_notifier_internal() on each of them. That in turn calls memory_region_add_eventfd(), which calls memory_re

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-07 Thread Andreas Färber
Am 07.05.2014 23:48, schrieb Peter Maydell: > On 7 May 2014 21:19, Eduardo Habkost wrote: >> If a given machine have max_cpus set, not just smp_cpus needs to be >> limited, but the total number of CPUs (considering CPU hotplug) for the >> machine. >> >> As smp_parse() already ensures smp_cpus <= m

[Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Samuel Thibault
Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Signed-off-by: Samuel Thibault --- This is particularly bad actually, one can for instance simply do this inside a Linux guest ip addr add 192.0.0.0/1 dev eth0 an

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-07 Thread Peter Maydell
On 7 May 2014 21:19, Eduardo Habkost wrote: > If a given machine have max_cpus set, not just smp_cpus needs to be > limited, but the total number of CPUs (considering CPU hotplug) for the > machine. > > As smp_parse() already ensures smp_cpus <= max_cpus, we just need to > check if max_cpus exceed

Re: [Qemu-devel] [PATCH 2/7] monitor: Convert help|? to use command_completion.

2014-05-07 Thread Hani Benhabiles
On Mon, May 05, 2014 at 03:51:37PM -0400, Luiz Capitulino wrote: > On Sun, 27 Apr 2014 17:00:03 +0100 > Hani Benhabiles wrote: > > > Signed-off-by: Hani Benhabiles > > --- > > hmp-commands.hx | 1 + > > hmp.h | 1 + > > monitor.c | 24 +--- > > 3 files chan

Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version

2014-05-07 Thread Hani Benhabiles
On Tue, May 06, 2014 at 07:28:35PM +0100, Peter Maydell wrote: > On 6 May 2014 19:16, Mike Day wrote: > > This updates scripts/checkpatch.pl to version 0.32. Also, > > forward-ported the QEMU checks for no tabs and correct capitalization > > of "QEMU." Finally, make --no-tree the default option si

Re: [Qemu-devel] [PATCH v3 0/4] little-endian dump for ppc64

2014-05-07 Thread Andreas Färber
Am 05.05.2014 10:02, schrieb Greg Kurz: > Bharata B Rao (3): > dump: Make DumpState and endian conversion routines available for > arch-specific dump code > ppc64-dump: Support dump for little endian ppc64 > ppc64 dump: Set the correct endianness in ELF dump header Both 2/4 and

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

2014-05-07 Thread Alexander Graf
On 05/07/2014 10:54 PM, Tom Musta wrote: On 5/7/2014 2:02 PM, Tom Musta wrote: It feels like there is an endianness issue here but I have not yet been able to put my finger on it. OK ... after more thought and scribbling ... here is what I mean Suppose I have a 64-bit value 0xa0a1a2a3a4a

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

2014-05-07 Thread Tom Musta
On 5/7/2014 2:02 PM, Tom Musta wrote: > It feels like there is an endianness issue here but I have not yet been able > to put my finger on it. OK ... after more thought and scribbling ... here is what I mean Suppose I have a 64-bit value 0xa0a1a2a3a4a5a6a7 stored in guest memory and it gets

[Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-07 Thread Eduardo Habkost
If a given machine have max_cpus set, not just smp_cpus needs to be limited, but the total number of CPUs (considering CPU hotplug) for the machine. As smp_parse() already ensures smp_cpus <= max_cpus, we just need to check if max_cpus exceeds the limit. Signed-off-by: Eduardo Habkost --- vl.c

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Michael Tokarev
07.05.2014 22:09, Paolo Bonzini wrote: > Il 07/05/2014 14:50, Peter Maydell ha scritto: >> git bisect says it's this makefile change. >> >> I think the problem here is that the rune for applying obj-specific >> CFLAGS is only in the Rules.make line for %.o: %.c, and not in >> the lines for building

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-07 Thread Michael S. Tsirkin
On Wed, May 07, 2014 at 02:48:48PM -0400, Konrad Rzeszutek Wilk wrote: > On Sun, May 04, 2014 at 05:25:15PM +0800, arei.gong...@huawei.com wrote: > > From: Gaowei > > > > In Xen platform, after using upstream qemu, the all of pci devices will show > > hotplug in the windows guest. In this situati

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Benoît Canet
The Wednesday 07 May 2014 à 21:44:06 (+0200), Markus Armbruster wrote : > Eric Blake writes: > > > On 05/06/2014 07:27 AM, Luiz Capitulino wrote: > >> On Tue, 6 May 2014 15:07:40 +0200 > >> Benoît Canet wrote: > >> > >>> I am trying to use this series to modularise the block API. > >>> > >>> He

Re: [Qemu-devel] [PATCHv3 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-05-07 Thread Paolo Bonzini
Il 05/03/2014 11:05, Paolo Bonzini ha scritto: Il 19/02/2014 10:05, Mark Cave-Ayland ha scritto: +#define CG3_REG_SIZE0x20 + +#define CG3_REG_FBC_CTRL0x10 +#define CG3_REG_FBC_STATUS 0x11 +#define CG3_REG_FBC_CURSTART0x12 +#define CG3_REG_FBC_CUREND 0x13 +#defin

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Markus Armbruster
Eric Blake writes: > On 05/06/2014 07:27 AM, Luiz Capitulino wrote: >> On Tue, 6 May 2014 15:07:40 +0200 >> Benoît Canet wrote: >> >>> I am trying to use this series to modularise the block API. >>> >>> Here are my finding. >>> >>> I tried to make a qmp/block.json including VM state related API

Re: [Qemu-devel] [PATCH] qapi: fix null pointer dereference on invalid parameter

2014-05-07 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 07 May 2014 18:55:26 +0200 > Markus Armbruster wrote: > >> Peter Lieven writes: >> >> > On 07.05.2014 05:05, Eric Blake wrote: >> >> On 05/06/2014 06:24 PM, Peter Lieven wrote: >> >>> qemu segfaults if it receives an invalid parameter via a >> >>> qmp command

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

2014-05-07 Thread Tom Musta
On 5/7/2014 3:20 AM, Greg Kurz wrote: > On Mon, 05 May 2014 13:04:35 +0200 > Alexander Graf wrote: >> On 05/05/2014 10:05 AM, Greg Kurz wrote: >>> From: Bharata B Rao >>> >>> Fix ppc64 arch specific dump code to work correctly for little endian >>> guests. >>> >>> We introduce a NoteFuncArg type

Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2014-05-07

2014-05-07 Thread Peter Maydell
gt; /mjt > > The following changes since commit 8d1dc5d188b84a2b2aeb9bd39fddb3d2c67be60c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20140507' into > staging (2014-05-07 16:06:38 +0100) > > are available in the git repository at: > > > g

Re: [Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support options for memory hotplug

2014-05-07 Thread Matthew Rosato
On 05/07/2014 02:50 PM, Alexander Graf wrote: > On 05/07/2014 08:05 PM, Matthew Rosato wrote: >> From: Igor Mammedov >> >> From: Igor Mammedov >> >> Add following parameters: >>"slots" - total number of hotplug memory slots >>"maxmem" - maximum possible memory >> >> "slots" and "maxmem" s

Re: [Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support options for memory hotplug

2014-05-07 Thread Alexander Graf
On 05/07/2014 08:05 PM, Matthew Rosato wrote: From: Igor Mammedov From: Igor Mammedov Add following parameters: "slots" - total number of hotplug memory slots "maxmem" - maximum possible memory "slots" and "maxmem" should go in pair and "maxmem" should be greater than "mem" for memory

Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file

2014-05-07 Thread Lluís Vilanova
This resend fixes a couple things: * Remove double import of os package * Incorrect error checking in the "include-before-err" test. Thanks, Lluis Lluís Vilanova writes: > The primitive uses JSON syntax, and include paths are relative to the file > using the directive: > { 'include': 'pa

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-07 Thread Konrad Rzeszutek Wilk
On Sun, May 04, 2014 at 05:25:15PM +0800, arei.gong...@huawei.com wrote: > From: Gaowei > > In Xen platform, after using upstream qemu, the all of pci devices will show > hotplug in the windows guest. In this situation, the windows guest may occur > blue screen when VM' user click the icon of VGA

[Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file

2014-05-07 Thread Lluís Vilanova
The primitive uses JSON syntax, and include paths are relative to the file using the directive: { 'include': 'path/to/file.json' } Signed-off-by: Lluís Vilanova Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- docs/qapi-code-gen.txt | 11 + scripts/qapi.

Re: [Qemu-devel] [PATCH] qapi: fix null pointer dereference on invalid parameter

2014-05-07 Thread Luiz Capitulino
On Wed, 07 May 2014 18:55:26 +0200 Markus Armbruster wrote: > Peter Lieven writes: > > > On 07.05.2014 05:05, Eric Blake wrote: > >> On 05/06/2014 06:24 PM, Peter Lieven wrote: > >>> qemu segfaults if it receives an invalid parameter via a > >>> qmp command instead of throwing an error. > >>> >

[Qemu-devel] [PATCH v3 3/4] virtio-ccw: Include standby memory when calculating storage increment

2014-05-07 Thread Matthew Rosato
When determining the memory increment size, use the maxmem size if it was specified. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 44 target-s390x/cpu.h |3 +++ 2 files changed, 39 insertions(+), 8 deletions(-) diff --

[Qemu-devel] [PATCH v3 4/4] sclp-s390: Add memory hotplug SCLPs

2014-05-07 Thread Matthew Rosato
Add memory information to read SCP info and add handlers for Read Storage Element Information, Attach Storage Element, Assign Storage and Unassign Storage. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c| 245 ++-- target-s390x/cpu.h | 15

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Paolo Bonzini
Il 07/05/2014 14:50, Peter Maydell ha scritto: git bisect says it's this makefile change. I think the problem here is that the rune for applying obj-specific CFLAGS is only in the Rules.make line for %.o: %.c, and not in the lines for building a .o file from a .cc, .cpp or .m file. That should p

[Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support options for memory hotplug

2014-05-07 Thread Matthew Rosato
From: Igor Mammedov From: Igor Mammedov Add following parameters: "slots" - total number of hotplug memory slots "maxmem" - maximum possible memory "slots" and "maxmem" should go in pair and "maxmem" should be greater than "mem" for memory hotplug to be enabled. Signed-off-by: Matthew Ros

[Qemu-devel] [PATCH v3 0/4] s390: Support for Hotplug of Standby Memory

2014-05-07 Thread Matthew Rosato
This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). New options, maxmem and slots, are added to the QEMU command line memory parameter to specify the total amount of memory available to the guest as well as the number of me

[Qemu-devel] [PATCH v3 2/4] sclp-s390: Add device to manage s390 memory hotplug

2014-05-07 Thread Matthew Rosato
Add sclpMemoryHotplugDev to contain associated data structures, etc. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c | 32 include/hw/s390x/sclp.h | 19 +++ 2 files changed, 51 insertions(+) diff --git a/hw/s390x/sclp.c b/hw/s390x/s

Re: [Qemu-devel] [PULL 0/7] xen-140507-2

2014-05-07 Thread Peter Maydell
On 7 May 2014 17:21, Stefano Stabellini wrote: > The following changes since commit 8d1dc5d188b84a2b2aeb9bd39fddb3d2c67be60c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20140507' into > staging (2014-05-07 16:06:38 +0100) > > are available in the gi

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Luiz Capitulino
On Wed, 07 May 2014 19:20:14 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Wed, 07 May 2014 19:07:56 +0200 > > Lluís Vilanova wrote: > > >> Luiz Capitulino writes: > >> > >> > On Mon, 5 May 2014 14:21:26 -0400 > >> > Luiz Capitulino wrote: > >> > >> >> On Fri, 2 May 2014 1

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Lluís Vilanova
Luiz Capitulino writes: > On Wed, 07 May 2014 19:07:56 +0200 > Lluís Vilanova wrote: >> Luiz Capitulino writes: >> >> > On Mon, 5 May 2014 14:21:26 -0400 >> > Luiz Capitulino wrote: >> >> >> On Fri, 2 May 2014 15:52:19 +0200 >> >> Lluís Vilanova wrote: >> >> >> >> > Adds an include primiti

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Peter Maydell
On 7 May 2014 18:05, Michael Tokarev wrote: > Interesting. It looks like I should add C++ compiler to my test environment, > because I really verified the change and it builds here just fine, but it does > not detect C++ so does not try to build C++ files. Yep; we didn't want to require everybod

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Luiz Capitulino
On Wed, 07 May 2014 19:07:56 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Mon, 5 May 2014 14:21:26 -0400 > > Luiz Capitulino wrote: > > >> On Fri, 2 May 2014 15:52:19 +0200 > >> Lluís Vilanova wrote: > >> > >> > Adds an include primitive to the syntax of QAPI schema files,

Re: [Qemu-devel] [PULL v2 00/11] pc,net,MAINTAINERS,build updates

2014-05-07 Thread Peter Maydell
On 7 May 2014 17:16, Michael S. Tsirkin wrote: > Same as v2 but tweaked some commits to include Signed-off-by: Michael > S. Tsirkin line. > > The following changes since commit 9898370497da3f18e0c9555b65c858eabc78ab50: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-smbios-2' into >

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Lluís Vilanova
Luiz Capitulino writes: > On Mon, 5 May 2014 14:21:26 -0400 > Luiz Capitulino wrote: >> On Fri, 2 May 2014 15:52:19 +0200 >> Lluís Vilanova wrote: >> >> > Adds an include primitive to the syntax of QAPI schema files, allowing >> > these to >> > be modularized into multiple per-topic files in

Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2014-05-07

2014-05-07 Thread Michael Tokarev
07.05.2014 21:03, Michael Tokarev wrote: > Another pull request for trivial patches. It is the same as previous > (2014-05-05) but without the problematic Makefile patch. > > So I'm not resending all the individual patches, as they're the same. On change actually appeared. I had to resolve a tr

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Michael Tokarev
07.05.2014 16:50, Peter Maydell wrote: > Hi; I'm afraid this pull breaks the build of the A64 disassembler: > > c++ -I/home/petmay01/linaro/qemu-for-merges/tcg > -I/home/petmay01/linaro/qemu-for-merges/tcg/i386 > -I/home/petmay01/linaro/qemu-for-merges/linux-headers > -I/home/petmay01/linaro/qemu

[Qemu-devel] [PULL 00/21] Trivial patches for 2014-05-07

2014-05-07 Thread Michael Tokarev
d2c67be60c: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20140507' into staging (2014-05-07 16:06:38 +0100) are available in the git repository at: git://git.corpit.ru/qemu.git tags/trivial-patches-2014-05-07 for you to fetch changes up to 8e25c274ae5830cf879fa5d2d7f98f4d6f

Re: [Qemu-devel] Help needed testing on ppc

2014-05-07 Thread Alexander Graf
On 05/07/2014 05:31 PM, Tom Musta wrote: On 5/6/2014 6:17 PM, BALATON Zoltan wrote: On Tue, 6 May 2014, Tom Musta wrote: On 5/6/2014 5:03 AM, BALATON Zoltan wrote: I'd appreciate some insight and help. [snip] (1) Why is MorphOS using this invalid instruction form? Would it be easier to fix

Re: [Qemu-devel] [PATCH] qapi: fix null pointer dereference on invalid parameter

2014-05-07 Thread Markus Armbruster
Peter Lieven writes: > On 07.05.2014 05:05, Eric Blake wrote: >> On 05/06/2014 06:24 PM, Peter Lieven wrote: >>> qemu segfaults if it receives an invalid parameter via a >>> qmp command instead of throwing an error. >>> >>> For example: >>> { "execute": "blockdev-add", >>> "arguments": { "op

Re: [Qemu-devel] qtest and pci mmio?

2014-05-07 Thread Paolo Bonzini
Il 07/05/2014 18:06, Gerd Hoffmann ha scritto: > Hi, > > Trying to add something real to the new ehci test. Having trouble > accessing the ehci mmio registers. uhci io registers are working fine. > Current patch attached, which just does a register dump to stderr. uhci > looks sane. ehci sho

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Luiz Capitulino
On Mon, 5 May 2014 14:21:26 -0400 Luiz Capitulino wrote: > On Fri, 2 May 2014 15:52:19 +0200 > Lluís Vilanova wrote: > > > Adds an include primitive to the syntax of QAPI schema files, allowing > > these to > > be modularized into multiple per-topic files in the future. > > > > Signed-off-by

[Qemu-devel] [PULL v2 06/11] apic: use emulated lapic version 0x14 on pc machines >= 2.1

2014-05-07 Thread Michael S. Tsirkin
From: "Gabriel L. Somlo" Add "version" property to local apic, and have it default to 0x14 for pc machines starting at 2.1. For compatibility with previous releases, pc machines up to 2.0 will have their local apic version set to 0x11. Signed-off-by: Gabriel L. Somlo Acked-by: Alexander Graf R

[Qemu-devel] [PULL 2/7] qemu-xen: free all the pirqs for msi/msix when driver unload

2014-05-07 Thread Stefano Stabellini
From: Zhenzhong Duan Pirqs are not freed when driver unload, then new pirqs are allocated when driver reload. This could exhaust pirqs if do it in a loop. This patch fixes the bug by freeing pirqs when ENABLE bit is cleared in msi/msix control reg. There is also other way of fixing it such as r

[Qemu-devel] [PULL 1/7] exec: Limit translation limiting in address_space_translate to xen

2014-05-07 Thread Stefano Stabellini
From: Alexey Kardashevskiy The address_space_translate() function cuts the returned plen (page size) to hardcoded TARGET_PAGE_SIZE. This function can be used on pages bigger than that so this limiting should not be used on such pages. Since originally the limiting was introduced for XEN, we can

Re: [Qemu-devel] [PULL 0/7] xen-140507

2014-05-07 Thread Stefano Stabellini
On Wed, 7 May 2014, Peter Maydell wrote: > On 7 May 2014 16:09, Stefano Stabellini > wrote: > > The following changes since commit 951916d02c59cd0eddd57c3d66f87f921931e394: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-6' into > > staging (2014-05-06 13:06:32 +0100) > > > >

[Qemu-devel] [PULL 6/7] pass an inclusive address range to xc_domain_pin_memory_cacheattr

2014-05-07 Thread Stefano Stabellini
xc_domain_pin_memory_cacheattr expects an inclusive address range: adjust the parameters. Signed-off-by: Stefano Stabellini --- xen-hvm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen-hvm.c b/xen-hvm.c index 0a49055..a64486c 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@

[Qemu-devel] [PULL v2 11/11] configure: make source tree build more robust

2014-05-07 Thread Michael S. Tsirkin
When source directory can be arrived at by two paths, configure might misdetect an out of tree build. The simplest way to trigger the problem is running configure using a full path. E.g. ( refers to qemu source tree): ln -s cd /configure A more practical way is when make runs config

[Qemu-devel] [PULL v2 10/11] MAINTAINERS: addresses for responsible disclosure

2014-05-07 Thread Michael S. Tsirkin
Adding addresses to MAINTAINERS, as agreed on the last conference call: http://wiki.qemu.org/SecurityProcess People sometimes detect security issues in upstream QEMU and don't know where to report them in a non-public way. Of course whoever just wants full disclosure can just go public, but there

[Qemu-devel] [PULL 4/7] xen: move Xen HVM files under hw/i386/xen

2014-05-07 Thread Stefano Stabellini
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Stefano Stabellini --- hw/i386/Makefile.objs |2 +- hw/i386/xen/Makefile.objs |1 + hw/i386/xen/xen_apic.c | 97 ++ hw/i386/xen/xen_platform.c | 450 hw/i386/xen/xen_pv

[Qemu-devel] [PULL 0/7] xen-140507-2

2014-05-07 Thread Stefano Stabellini
The following changes since commit 8d1dc5d188b84a2b2aeb9bd39fddb3d2c67be60c: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20140507' into staging (2014-05-07 16:06:38 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xe

[Qemu-devel] [PULL v2 08/11] smbus: return -1 if nothing found at the given address

2014-05-07 Thread Michael S. Tsirkin
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Acked-by: Michael S. Tsirkin Reviewed-by: Andreas Färber Signed-off-by: Michael S. Tsirkin --- include/hw/i2c/smbus.h | 12 +- hw/i2c/smbus.c | 62 +++--- 2 files changed, 50 insertio

[Qemu-devel] [PULL 7/7] xen_disk: add discard support

2014-05-07 Thread Stefano Stabellini
From: Olaf Hering Implement discard support for xen_disk. It makes use of the existing discard code in qemu. The discard support is enabled unconditionally. The tool stack may provide a property "discard-enable" in the backend node to optionally disable discard support. This is helpful in case

[Qemu-devel] [PULL 3/7] xen: move Xen PV machine files to hw/xenpv

2014-05-07 Thread Stefano Stabellini
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Stefano Stabellini --- hw/i386/Makefile.objs |2 +- hw/i386/xen_domainbuild.c | 299 hw/i386/xen_domainbuild.h | 13 -- hw/i386/xen_machine_pv.c | 109 hw/xenpv/Ma

[Qemu-devel] [PULL v2 07/11] smbus: allow returning an error from reads

2014-05-07 Thread Michael S. Tsirkin
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Acked-by: Michael S. Tsirkin Reviewed-by: Andreas Färber Signed-off-by: Michael S. Tsirkin --- include/hw/i2c/smbus.h | 6 +++--- hw/i2c/smbus.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/hw/i2c/

[Qemu-devel] [PULL v2 04/11] i8259: don't abort when trying to use level sensitive irqs

2014-05-07 Thread Michael S. Tsirkin
From: Hervé Poussineau This is a guest-triggerable error, as seen when using Xenix 2.3.4. Replace hw_error by LOG_UNIMPL, so that guests can continue. With this patch, I can install and use Xenix 2.3.4a without any problem. I can also start installation of Xenix 2.3.4q, but it fails due to not fi

Re: [Qemu-devel] [PULL 00/10] pc,net,MAINTAINERS,build updates

2014-05-07 Thread Michael S. Tsirkin
On Wed, May 07, 2014 at 05:13:06PM +0100, Peter Maydell wrote: > On 7 May 2014 16:37, Michael S. Tsirkin wrote: > > The following changes since commit 9898370497da3f18e0c9555b65c858eabc78ab50: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-smbios-2' into > > staging (2014-05-06

[Qemu-devel] [PULL v2 02/11] acpi-build: properly decrement objects' reference counters

2014-05-07 Thread Michael S. Tsirkin
From: Kirill Batuzov Object returned by object_property_get_qobject needs its reference counter to be decremented when it is not needed by caller anymore. Signed-off-by: Kirill Batuzov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 6 ++ 1 fi

  1   2   3   4   >