Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Use cpu_physical_memory_read and cpu_physical_memory_write

2014-04-07 Thread Michael Tokarev
07.04.2014 22:28, Stefan Weil пишет: > These functions don't need type casts (as does cpu_physical_memory_rw) > and also make the code better readable. This will wait 2.0. While technically it is quite simple, but we're too close to release now. Thanks, /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix grammar in comment

2014-04-07 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v17 02/14] block: Introduce op_blockers to BlockDriverState

2014-04-07 Thread Fam Zheng
On Sun, 04/06 19:49, Jeff Cody wrote: > On Mon, Mar 10, 2014 at 03:25:58PM +0800, Fam Zheng wrote: > > BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX > > elements. Each list is a list of blockers of an operation type > > (BlockOpType), that marks this BDS as currently bloc

Re: [Qemu-devel] [PATCH 3/4] qemu-img: Implement commit like QMP

2014-04-07 Thread Markus Armbruster
Max Reitz writes: > On 07.04.2014 21:10, Eric Blake wrote: >> On 04/07/2014 11:29 AM, Max Reitz wrote: >>> qemu-img should use QMP commands whenever possible in order to ensure >>> feature completeness of both online and offline image operations. As >>> qemu-img itself has no access to QMP (since

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-07 Thread Gerd Hoffmann
On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote: > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > > I simply like it better, you don't? :) > > > > I still think we should make this simply depend on absolute/re

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Gerd Hoffmann
On Mo, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); > > > > > One thing I'd do is maybe check that the relevant memory type is >

Re: [Qemu-devel] [PATCH] Fix grammar in comment

2014-04-07 Thread Peter Crosthwaite
On Tue, Apr 8, 2014 at 3:42 AM, Stefan Weil wrote: > Signed-off-by: Stefan Weil Reviewed-by: Peter Crosthwaite > --- > hw/i2c/smbus_eeprom.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c > index 86f35c1..72c09cb 10064

[Qemu-devel] Fw: Who signed gemu-1.7.1.tar.bz2?

2014-04-07 Thread Alex Davis
The signature has the RSA key ID ADF0D2D9, which does not match any ID in gpg-keyring.gpg. I code, therefore I am

[Qemu-devel] [PATCH] target-arm: return more meaningful exit status

2014-04-07 Thread Eric Botcazou
Hi, this partially addresses a long-standing limitation of the ARM semi-hosting mode, whereby the only exit status of the emulator is 0, whatever the exit status of the target executable, by mapping arguments of the SYS_EXIT syscall. See https://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02

[Qemu-devel] [PATCH for-2.1 v2 2/2] util/fifo: Generalise for common integer widths

2014-04-07 Thread Peter Crosthwaite
Add support for 16, 32 and 64 bit width FIFOs. The push and pop functions are patched to accept uint64_t always to support up to 64bit integer elements. The element width is set at creation time. The backing storage for all element types is still uint8_t regardless of element width so some save-lo

[Qemu-devel] [PATCH for-2.1 v2 1/2] util/fifo: s/fifo8/fifo globally

2014-04-07 Thread Peter Crosthwaite
This prepares support for generalising FIFO support to more integer widths. Signed-off-by: Peter Crosthwaite --- hw/char/serial.c | 30 ++--- hw/net/allwinner_emac.c | 72 +++--- hw/ssi/xilinx_spi.c | 42 +- h

[Qemu-devel] [PATCH for-2.1 v2 0/2] Generalise FIFO to more integer types

2014-04-07 Thread Peter Crosthwaite
There is a utility helper for dealing with 8 bit fifos. This should be applicable to other integer widths as well. These two patches generalise this FIFO to work for 16, 32 and 64 bit ints. CC some recent contributors around this code. changed since v1: Rebased to include fifo buffer functionali

Re: [Qemu-devel] [PATCH v24 05/31] QemuOpts: move qemu_opt_del ahead for later calling

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:23PM +0800, Chunyan Liu wrote: > In later patch, qemu_opt_get_del functions will be added, they will > first get the option value, then call qemu_opt_del to remove the option > from opt list. To prepare for that purpose, move qemu_opt_del ahead first. > > Reviewed-by:

Re: [Qemu-devel] [PATCH v24 04/31] QemuOpts: change opt->name|str from (const char *) to (char *)

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:22PM +0800, Chunyan Liu wrote: > qemu_opt_del() already assumes that all QemuOpt instances contain > malloc'd name and value; but it had to cast away const because > opts_start_struct() was doing its own thing and using static storage > instead. By using the correct t

Re: [Qemu-devel] [PATCH v24 03/31] qapi: output def_value_str when query command line options

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:21PM +0800, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Reviewed-by: Eric Blake > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > qapi-schema.json | 6 +- > qm

Re: [Qemu-devel] [PATCH v24 07/31] QemuOpts: add qemu_opts_print_help to replace print_option_help

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:25PM +0800, Chunyan Liu wrote: > print_option_help takes QEMUOptionParameter as parameter, add > qemu_opts_print_help to take QemuOptsList as parameter for later > replace work. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dori

Re: [Qemu-devel] [PATCH v24 02/31] QemuOpts: add def_value_str to QemuOptDesc

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:20PM +0800, Chunyan Liu wrote: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. > > Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise, > if desc->def_value_str is set, retur

Re: [Qemu-devel] [PATCH] target-ppc: Add @cpu_dt_id into migration stream

2014-04-07 Thread Alexey Kardashevskiy
On 03/28/2014 12:07 AM, Alexey Kardashevskiy wrote: > On 03/27/2014 11:57 PM, Peter Maydell wrote: >> On 27 March 2014 12:49, Alexey Kardashevskiy wrote: >>> On 03/27/2014 11:37 PM, Andreas Färber wrote: Am 27.03.2014 03:41, schrieb Alexey Kardashevskiy: > This should prevent the destinat

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-07 Thread Alexey Kardashevskiy
On 04/08/2014 04:53 AM, Andreas Färber wrote: > Am 07.04.2014 05:27, schrieb Alexey Kardashevskiy: >> On 04/04/2014 11:28 PM, Alexander Graf wrote: >>> On 04/04/2014 07:17 AM, Alexey Kardashevskiy wrote: On 03/24/2014 04:28 PM, Alexey Kardashevskiy wrote: > Currently only migration fails i

Re: [Qemu-devel] [PATCH v24 01/31] QemuOpts: move find_desc_by_name ahead for later calling

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:19PM +0800, Chunyan Liu wrote: > Reviewed-by: Eric Blake > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dorileo > --- > util/qemu-option.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/util/qemu-opti

Re: [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts

2014-04-07 Thread Leandro Dorileo
On Thu, Apr 03, 2014 at 05:54:18PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > one Qemu Option structure is kept in QEMU code. > > --- > Changes to v23: > * Improve conversion functions, make .assigned info not lost. > * Upda

Re: [Qemu-devel] why we build only some optional modules as modules?

2014-04-07 Thread Fam Zheng
On Sun, 04/06 10:17, Michael Tokarev wrote: > 06.04.2014 04:52, Fam Zheng wrote: > > On Sat, 04/05 18:29, Michael Tokarev wrote: > >> A quick (hopefully) question. > >> > >> Why build-as-modules only enabled for a few optional modules only, > >> why not build as modules everything, to reduce common

[Qemu-devel] [PATCH 2.0] PPC: Add l1 cache sizes for 970 and above systems

2014-04-07 Thread Alexander Graf
Book3s_64 guests expect the L1 cache size in device tree, so let's give them proper values for all CPU types we support. This fixes a "not compliant" warning with sles11 guests on -M pseries for me. Signed-off-by: Alexander Graf --- target-ppc/translate_init.c | 8 1 file changed, 8 in

[Qemu-devel] [PATCH v10 2/2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-04-07 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. Reviewed-by: Andreas Färber Signed-off-by: Thomas Falcon --- Difference from v9: Fixed a coding style mistake --- target-ppc/gdbstub.c | 19 +++

[Qemu-devel] [PATCH v10 0/2] target-ppc: gdbstub little endian support patches

2014-04-07 Thread Thomas Falcon
The first patch pulls the register length calculation into its own function, and the second adds support for little endian ppc in gdbstub. Thomas Falcon (2): target-ppc: extract register length calculation in gdbstub target-ppc: gdbstub allow byte swapping for reading/writing registers targe

[Qemu-devel] [PATCH v10 1/2] target-ppc: extract register length calculation in gdbstub

2014-04-07 Thread Thomas Falcon
This patch extracts the method to determine a register's size into a separate function. Reviewed-by: Andreas Färber Signed-off-by: Thomas Falcon --- target-ppc/gdbstub.c | 105 ++- 1 file changed, 71 insertions(+), 34 deletions(-) diff --git a/ta

Re: [Qemu-devel] [V2 PATCH 1/2] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Peter Maydell
On 7 April 2014 22:15, Tom Musta wrote: > > +/* > + * Disassembler for the monitor. 'flags' has the following values: > + * i386 - 1 means 16 bit code, 2 means 64 bit code. > + * ppc - bits 0:15 specify (optionally) the machine instruction set; > + * bit 16 indicates little endian.

Re: [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region

2014-04-07 Thread Peter Maydell
On 7 April 2014 21:40, Andreas Färber wrote: > Am 07.04.2014 21:32, schrieb Andreas Färber: >> I tested .bswap = false - that fixes ppc64 host but breaks x86_64 host. > > Same results for the following patch (x86_64 broken, ppc64 fixed): > > diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c > i

Re: [Qemu-devel] [PATCH] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-04-07 Thread Eric Blake
On 04/05/2014 10:43 AM, Jun Li wrote: > This patch fixed the following bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1084302 . > path_combine can not calculate the correct full path name for backing_file. > Such as: > create a snapshot chain: > sn2->sn1->$BASE_IMG > backing file is : /home/woo

[Qemu-devel] [V2 PATCH 1/2] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Tom Musta
The monitor support for disassembling instructions does not honor the MSR[LE] bit for PowerPC processors. This change enhances the monitor_disas() routine by supporting a flag bit for Little Endian mode. Bit 16 is used since that bit was used in the analagous guest disassembly routine target_disa

[Qemu-devel] [V2 PATCH 0/2] QEMU Monitor Instruction Disassembly Incorrect for PPC LE

2014-04-07 Thread Tom Musta
Fix disassembly in the QEMU monitor for Little Endian codes. Also fix the comment and tighten up a flag check in the closely related disassembler code for tracing. V2: Addressing comments from Peter Maydell. Tom Musta (2): monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC

[Qemu-devel] [V2 PATCH 2/2] target-ppc: Fix target_disas

2014-04-07 Thread Tom Musta
Inspect only bit 16 for the Little Endian test. Correct comment preceding the target_disas() function. Signed-off-by: Tom Musta --- disas.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index 1e09293..968366d 100644 --- a/disas.c +++ b/disas.c @@

Re: [Qemu-devel] [PATCH v17 12/14] block: Add blockdev-backup to transaction

2014-04-07 Thread Eric Blake
On 03/10/2014 01:26 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockdev.c | 48 > qapi-schema.json | 1 + > 2 files changed, 49 insertions(+) > > +++ b/qapi-schema.json > @@ -1972,6 +1972,7 @@ >'data': { > 'blockde

Re: [Qemu-devel] [PATCH v17 10/14] qmp: Add command 'blockdev-backup'

2014-04-07 Thread Eric Blake
On 03/10/2014 01:26 AM, Fam Zheng wrote: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Also add blocker on target bs, since the target is also a named device > now. > > Add check and report error for bs == target which beca

Re: [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region

2014-04-07 Thread Andreas Färber
Am 07.04.2014 21:32, schrieb Andreas Färber: > Am 05.04.2014 22:26, schrieb Hervé Poussineau: >> Hi Andreas, >> >> Le sam. 05 avril 2014 17:41:43 CEST, Andreas Färber a écrit : >>> Hi Hervé, >>> >>> Am 20.03.2014 00:36, schrieb Andreas Färber: From: Hervé Poussineau Remove now dupli

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Michael S. Tsirkin
On Sun, Apr 06, 2014 at 12:47:37PM +0300, Michael S. Tsirkin wrote: > ACPI0004 seems too new: > Windows XP complains about an unrecognized device. > This is a regression since 1.7. > Use PNP0A06 instead - Generic Container Device. > > Signed-off-by: Michael S. Tsirkin ping Just making sure we d

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote: > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > I simply like it better, you don't? :) > > I still think we should make this simply depend on absolute/relative > pointer mode instead of asking the user to switch it manually

Re: [Qemu-devel] [PATCH v9 2/2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-04-07 Thread Andreas Färber
Am 07.04.2014 22:02, schrieb Thomas Falcon: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. > > Signed-off-by: Thomas Falcon > --- > Differences from v8: > > Separated into multiple patches > ppc

[Qemu-devel] [PATCH for-2.0 2/2] vss-win32: Fix build with mingw64-headers-3.1.0

2014-04-07 Thread Michael Roth
From: Tomoki Sekiyama In mingw64-headers-3.1.0, definition of _com_issue_error() is added, which conflicts with definition in install.cpp. This adds version checking for mingw headers to disable the definition when the headers>=3.1 is used. Signed-off-by: Tomoki Sekiyama Signed-off-by: Michael

[Qemu-devel] [PATCH for-2.0 1/2] Makefile: add qga-vss-dll-obj-y to nested variables

2014-04-07 Thread Michael Roth
From: Tomoki Sekiyama The build rule for qga/vss-win32/qga-vss.dll is broken by commit ba1183da9a10b94611cad88c44a5c6df005f9b55, because it misses qga-vss-dll-obj-y in the list of nested variables. This fixes build of qga-vss.dll by adding qga-vss-dll-obj-y to the list. Signed-off-by: Tomoki Sek

[Qemu-devel] [PULL for-2.0 0/2] qemu-ga w32 build fixes

2014-04-07 Thread Michael Roth
Hi Peter, Please pull the following 2 patches, which fix a w32 build regression for qemu-ga that was introduced during 2.0 development cycle. The following changes since commit 55519a4b244e4822774b593e36647ecf7598286b: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.0' in

[Qemu-devel] [PATCH v9 2/2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-04-07 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. Signed-off-by: Thomas Falcon --- Differences from v8: Separated into multiple patches ppc_gdb_swap_register(...) is now a static function Removed "cpu" f

Re: [Qemu-devel] [PATCH v9 1/2] target-ppc: extract register length calculation in gdbstub

2014-04-07 Thread Andreas Färber
Am 07.04.2014 22:02, schrieb Thomas Falcon: > This patch extracts the method to determine a register's size > into a separate function. > > Signed-off-by: Thomas Falcon > --- > Differences from v8: > > Separated into multiple patches > Removed "cpu" from function name Reviewed-by: Andreas Färbe

Re: [Qemu-devel] [PATCH 4/4] qemu-img: Enable progress output for commit

2014-04-07 Thread Eric Blake
On 04/07/2014 11:30 AM, Max Reitz wrote: > Implement progress output for the commit command by querying the > progress of the block job. Yay! I've been asking for this for a while. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 32 +++

[Qemu-devel] [PATCH v9 1/2] target-ppc: extract register length calculation in gdbstub

2014-04-07 Thread Thomas Falcon
This patch extracts the method to determine a register's size into a separate function. Signed-off-by: Thomas Falcon --- Differences from v8: Separated into multiple patches Removed "cpu" from function name --- target-ppc/gdbstub.c | 105 ++- 1 fi

[Qemu-devel] [PATCH v9 0/2] target-ppc: gdbstub little endian support patches

2014-04-07 Thread Thomas Falcon
The first patch pulls register length calculation into its own function and the second adds support for little endian ppc in gdbstub. Thomas Falcon (2): target-ppc: extract register length calculation in gdbstub target-ppc: gdbstub allow byte swapping for reading/writing registers target-ppc

Re: [Qemu-devel] [PATCH 1/4] block-commit: Expose granularity

2014-04-07 Thread Max Reitz
On 07.04.2014 21:06, Eric Blake wrote: On 04/07/2014 11:29 AM, Max Reitz wrote: Allow QMP users to manipulate the granularity used in the block-commit command. Signed-off-by: Max Reitz --- @@ -214,6 +215,13 @@ void commit_start(BlockDriverState *bs, BlockDriverState *base, orig_base_fla

Re: [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region

2014-04-07 Thread Andreas Färber
Am 05.04.2014 22:26, schrieb Hervé Poussineau: > Hi Andreas, > > Le sam. 05 avril 2014 17:41:43 CEST, Andreas Färber a écrit : >> Hi Hervé, >> >> Am 20.03.2014 00:36, schrieb Andreas Färber: >>> From: Hervé Poussineau >>> >>> Remove now duplicated code from prep board. >>> >>> Signed-off-by: Herv

Re: [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region

2014-04-07 Thread Paolo Bonzini
Il 05/04/2014 19:20, Peter Maydell ha scritto: >> It means "default endianness of the guest cpu" so that accesses coming >> from the CPU get passed in the value they had in the CPU registers :). > > > In that case, behaviour should be the same between x86 host and openSUSE > ppc/ppc64 and OSX pp

Re: [Qemu-devel] [PATCH 3/4] qemu-img: Implement commit like QMP

2014-04-07 Thread Max Reitz
On 07.04.2014 21:10, Eric Blake wrote: On 04/07/2014 11:29 AM, Max Reitz wrote: qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just

Re: [Qemu-devel] [PATCH 3/4] qemu-img: Implement commit like QMP

2014-04-07 Thread Eric Blake
On 04/07/2014 11:29 AM, Max Reitz wrote: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically require > just everything being linked into qemu

Re: [Qemu-devel] [PATCH 1/4] block-commit: Expose granularity

2014-04-07 Thread Eric Blake
On 04/07/2014 11:29 AM, Max Reitz wrote: > Allow QMP users to manipulate the granularity used in the block-commit > command. > > Signed-off-by: Max Reitz > --- > @@ -214,6 +215,13 @@ void commit_start(BlockDriverState *bs, BlockDriverState > *base, > orig_base_flags= bdrv_get_flags(bas

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Kevin O'Connor
On Mon, Apr 07, 2014 at 02:05:21PM -0400, Gabriel L. Somlo wrote: > On Mon, Apr 07, 2014 at 11:23:44AM -0400, Kevin O'Connor wrote: > > So, I'm suggesting QEMU produce two new fw_cfg files: an anchor file > > with the valid anchor table (the address pointer can be just set to > > zero), and an smbi

Re: [Qemu-devel] [PATCH 2/4] block-commit: speed is an optional parameter

2014-04-07 Thread Max Reitz
On 07.04.2014 20:55, Eric Blake wrote: On 04/07/2014 11:29 AM, Max Reitz wrote: As speed is an optional parameter for the QMP block-commit command, it should be set to 0 if not given (as it is undefined if has_speed is false), that is, the speed should not be limited. Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH 2/4] block-commit: speed is an optional parameter

2014-04-07 Thread Eric Blake
On 04/07/2014 11:29 AM, Max Reitz wrote: > As speed is an optional parameter for the QMP block-commit command, it > should be set to 0 if not given (as it is undefined if has_speed is > false), that is, the speed should not be limited. > > Signed-off-by: Max Reitz > --- > blockdev.c | 1 + > 1 f

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-07 Thread Andreas Färber
Am 07.04.2014 05:27, schrieb Alexey Kardashevskiy: > On 04/04/2014 11:28 PM, Alexander Graf wrote: >> On 04/04/2014 07:17 AM, Alexey Kardashevskiy wrote: >>> On 03/24/2014 04:28 PM, Alexey Kardashevskiy wrote: Currently only migration fails if CPU version is different even a bit. For exam

Re: [Qemu-devel] [PATCH v17 08/14] block: Support dropping active in bdrv_drop_intermediate

2014-04-07 Thread Jeff Cody
On Mon, Mar 10, 2014 at 03:26:04PM +0800, Fam Zheng wrote: > Dropping intermediate could be useful both for commit and stream, and > BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs > to work with op blockers. > > Signed-off-by: Fam Zheng > --- > block.c| 139 > +

[Qemu-devel] [PATCH 27/26] tcg-aarch64: Introduce tcg_out_insn_3312, _3310, _3313

2014-04-07 Thread Richard Henderson
Merge TCGMemOp size, AArch64LdstType type and a few stray opcode bits into a single I3312_* argument, eliminating some magic numbers from helper functions. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 129 --- 1 file changed, 76 inse

[Qemu-devel] [PATCH] misc: Use cpu_physical_memory_read and cpu_physical_memory_write

2014-04-07 Thread Stefan Weil
These functions don't need type casts (as does cpu_physical_memory_rw) and also make the code better readable. Signed-off-by: Stefan Weil --- cpus.c |2 +- hw/i386/kvmvapic.c | 31 ++- hw/intc/apic.c |4 ++-- target-s3

[Qemu-devel] [PATCH 0/4] qemu-img: Implement commit like QMP

2014-04-07 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (du

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gabriel L. Somlo
On Mon, Apr 07, 2014 at 11:23:44AM -0400, Kevin O'Connor wrote: > So, I'm suggesting QEMU produce two new fw_cfg files: an anchor file > with the valid anchor table (the address pointer can be just set to > zero), and an smbios table file with the complete set of smbios tables > formatted according

Re: [Qemu-devel] [PATCH 06/97] vmstate: Refactor & increase tests for primitive types

2014-04-07 Thread Eduardo Habkost
On Mon, Apr 07, 2014 at 05:20:24AM +0200, Juan Quintela wrote: > This commit refactor the simple tests to test all integer types. We > move to hex because it is easier to read values of different types. > > Signed-off-by: Juan Quintela > --- > tests/test-vmstate.c | 195 > ++

[Qemu-devel] [PATCH] Fix grammar in comment

2014-04-07 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/i2c/smbus_eeprom.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 86f35c1..72c09cb 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -71,7 +71,7 @@ static void eeprom_writ

Re: [Qemu-devel] [PATCH 05/97] vmstate: refactor opening of files

2014-04-07 Thread Eduardo Habkost
On Mon, Apr 07, 2014 at 05:20:23AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela Reviewed-by: Eduardo Habkost -- Eduardo

[Qemu-devel] [PATCH 3/4] qemu-img: Implement commit like QMP

2014-04-07 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of block-comm

[Qemu-devel] [PATCH 1/4] block-commit: Expose granularity

2014-04-07 Thread Max Reitz
Allow QMP users to manipulate the granularity used in the block-commit command. Signed-off-by: Max Reitz --- block/commit.c| 16 +--- block/mirror.c| 4 ++-- blockdev.c| 21 +++-- include/block/block_int.h | 6 -- qapi-sch

[Qemu-devel] [PATCH 4/4] qemu-img: Enable progress output for commit

2014-04-07 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 32 ++-- qemu-img.texi| 2 +- 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/q

[Qemu-devel] [PATCH 2/4] block-commit: speed is an optional parameter

2014-04-07 Thread Max Reitz
As speed is an optional parameter for the QMP block-commit command, it should be set to 0 if not given (as it is undefined if has_speed is false), that is, the speed should not be limited. Signed-off-by: Max Reitz --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/bl

Re: [Qemu-devel] [PULL for-2.0 0/2] QOM devices patch queue 2014-04-07

2014-04-07 Thread Peter Maydell
On 7 April 2014 17:57, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Anthony Liguori > > Cc: Stefan Hajnoczi > Cc: Paolo Bonzini > Cc: Alexey Kardashevskiy > > The following changes since commit b

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Only enter MSR_POW when no interrupts pending

2014-04-07 Thread Tom Musta
On 4/6/2014 3:55 PM, Alexander Graf wrote: > We were entering the power saving state even when interrupts (like an > external interrupt or a decrementer interrupt) were still in flight. > > In case we find a pending interrupt, don't enter power saving state. > > Signed-off-by: Alexander Graf > -

[Qemu-devel] [PULL for-2.0 0/2] QOM devices patch queue 2014-04-07

2014-04-07 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Stefan Hajnoczi Cc: Paolo Bonzini Cc: Alexey Kardashevskiy The following changes since commit bd7ce902ab2b5e4f5cd53e1e032d89789b6932a8: Merge remote-tracking branc

[Qemu-devel] [PULL for-2.0 2/2] tests: Update check-clean rule

2014-04-07 Thread Andreas Färber
Only i386, x86_64, sparc and sparc64 qtests were cleaned up. Make this more generic to not miss any newly tested targets. Reported-by: Alexey Kardashevskiy Suggested-by: Peter Maydell Signed-off-by: Andreas Färber --- tests/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PULL for-2.0 1/2] fw-path-provider: Change GPL version to 2+

2014-04-07 Thread Andreas Färber
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/fw-path-provider.c| 3 ++- include/hw/fw-path-provider.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/core/fw-path-provider.c b/hw

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 5 April 2014 15:25, Michael Tokarev wrote: > When installing modules (when --enable-modules is specified for > ./configure), Makefile uses the following construct to replace all > slashes with dashes in module name: > > ${s//\//-} > > This is a bash-specific substitution mechanism. POSIX does

Re: [Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Tom Musta
On 4/7/2014 10:00 AM, Peter Maydell wrote: > It seems a touch dubious to assume the area of memory > being dissassembled is necessarily the same endianness > the CPU happens to be currently... I don't disagree but it is less dubious than relying on TARGET_WORDS_BIGENDIAN, which is what the code cu

Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-07 Thread Peter Maydell
On 3 April 2014 20:56, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, There are now patches proposed to the kernel to supply this: http://www.spinics.net/lists/arm-kernel/msg320268.html thanks -- PMM

Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-07 Thread Richard Henderson
On 04/07/2014 12:58 AM, Claudio Fontana wrote: >> +|| (insn & 0x3bc0) == 0x2840 /* C3.3.7 */ > > I think the Load (L) bit should be 0 here so > > == 0x2800 Oops. Fixed. > >> +|| (insn & 0x3be00c00) == 0x38000400 /* C3.3.8 */ > > With V=1, an op

Re: [Qemu-devel] [RFC] copy OEM ACPI parameters from SLIC table to RSDT

2014-04-07 Thread Chris Evich
On 04/06/2014 08:21 AM, Laszlo Ersek wrote: > (2) I recently found this forum post from Chris Evich (CC'd): > > Libvirt + Fedora 20 + Windows 8.1 OEM + UEFI = Oh My! > http://forums.fedoraforum.org/showthread.php?p=1694052 > > (scroll up to the start of the thread). FWIW: "Works" in my insta

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 05:16:13PM +0300, Marcel Apfelbaum wrote: > On Mon, 2014-04-07 at 17:09 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 04:51:54PM +0300, Marcel Apfelbaum wrote: > [...] > > > > > I don't think we'll need that for the SHPC bridge. > > > > > > > > Why not? > > >

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Andreas Färber
Am 07.04.2014 12:00, schrieb Juan Quintela: > "Dr. David Alan Gilbert" wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> Hi >>> >>> Look at the diffstat. Almost all the additions are at >>> test-vmstate.c. That is the reason why it is called a simplification. >>> >>> What this series d

Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule

2014-04-07 Thread Peter Maydell
On 14 February 2014 04:03, Alexey Kardashevskiy wrote: > Like this? Against what should I rebase my patches and repost them? > > > diff --git a/tests/Makefile b/tests/Makefile > index 94b32b7..2577843 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -323,7 +323,9 @@ check-block: $(patsubs

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 April 2014 15:25, Richard Henderson wrote: >> On 04/06/2014 08:27 AM, Peter Maydell wrote: >>> (if C compilers had a "behave >>> like a sane 2s complement system for signed arithmetic" >>> option I'd be advocating for us using it...) >> >> -fwrapv. > > Well, we shoul

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 7 April 2014 16:30, Markus Armbruster wrote: > Peter Maydell writes: > >> On 5 April 2014 15:25, Michael Tokarev wrote: >>> ifneq ($(CONFIG_MODULES),) >>> $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)" >>> for s in $(patsubst %.mo,%$(DSOSUF),$(modules-m)); do \ >>> -

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:22:06PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 16:25:30 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: > > > On Mon, 7 Apr 2014 15:07:15 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, A

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Markus Armbruster
Peter Maydell writes: > On 5 April 2014 15:25, Michael Tokarev wrote: >> When installing modules (when --enable-modules is specified for >> ./configure), Makefile uses the following construct to replace all >> slashes with dashes in module name: >> >> ${s//\//-} >> >> This is a bash-specific su

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:26:02PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 11:13:01 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > > > Notify PIIX4_PM/ICH9LPC device about h

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Kevin O'Connor
On Mon, Apr 07, 2014 at 10:49:54AM -0400, Gabriel L. Somlo wrote: > On Mon, Apr 07, 2014 at 10:14:36AM -0400, Kevin O'Connor wrote: > > How about having QEMU produce the smbios table with a dummy type0 > > table and then both seabios and ovmf can replace the type0 table if > > desired. After all,

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Avi Kivity
On 04/07/2014 06:17 PM, Peter Maydell wrote: On 7 April 2014 15:56, Avi Kivity wrote: On 04/06/2014 01:18 PM, Peter Maydell wrote: The alternative would be to say that Int128 should have undefined behaviour on underflow/overflow and the test code is wrong, but that doesn't seem very useful to

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:25:30PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 15:07:15 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: > > > > On Mon, 7 Apr

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:56, Avi Kivity wrote: > On 04/06/2014 01:18 PM, Peter Maydell wrote: >> The alternative would be to say that Int128 should have >> undefined behaviour on underflow/overflow and the test >> code is wrong, but that doesn't seem very useful to me. > Isn't the test broken here? It

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 13:23:54 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > > so that it would send SCI to guest

Re: [Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:50, Tom Musta wrote: > The monitor support for disassembling instructions does not honor the MSR[LE] > bit for PowerPC processors. > > This change enhances the monitor_disas() routine by supporting a flag bit > for Little Endian mode. Bit 16 is used since that bit was used in t

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Avi Kivity
On 04/06/2014 01:18 PM, Peter Maydell wrote: On 6 April 2014 08:09, Michael Tokarev wrote: 28.03.2014 19:12, Peter Maydell wrote: Add casts when we're performing arithmetic on the .hi parts of an Int128, to avoid undefined behaviour. [] static inline Int128 int128_sub(Int128 a, Int128 b)

[Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Tom Musta
The monitor support for disassembling instructions does not honor the MSR[LE] bit for PowerPC processors. This change enhances the monitor_disas() routine by supporting a flag bit for Little Endian mode. Bit 16 is used since that bit was used in the analagous guest disassembly routine target_disa

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gabriel L. Somlo
On Mon, Apr 07, 2014 at 10:14:36AM -0400, Kevin O'Connor wrote: > How about having QEMU produce the smbios table with a dummy type0 > table and then both seabios and ovmf can replace the type0 table if > desired. After all, if OVMF is splitting the blob into tables, it can > just as easily replace

[Qemu-devel] [PATCH 2.0] ppce500_spin: Initialize struct properly

2014-04-07 Thread Alexander Graf
The spinning struct is in guest endianness, so we need to initialize its variables in guest endianness too. This fixes booting e500 guests with SMP on x86 for me. Signed-off-by: Alexander Graf --- hw/ppc/ppce500_spin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:25, Richard Henderson wrote: > On 04/06/2014 08:27 AM, Peter Maydell wrote: >> (if C compilers had a "behave >> like a sane 2s complement system for signed arithmetic" >> option I'd be advocating for us using it...) > > -fwrapv. Well, we should use that then :-) thanks -- PMM

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 11:13:01 -0300 Eduardo Habkost wrote: > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > > so that it would send SCI to guest notifying about > >

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Laszlo Ersek
On 04/07/14 16:14, Kevin O'Connor wrote: > On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote: The only fly in this ointment may be that type 0 doesn't have a fixed length that could be edited in place, if you consider the various strings that get tacked on to the end of i

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammed

  1   2   >