On 7 April 2014 22:15, Tom Musta <tommu...@gmail.com> wrote: > > +/* > + * Disassembler for the monitor. 'flags' has the following values: > + * i386 - 1 means 16 bit code, 2 means 64 bit code. > + * ppc - bits 0:15 specify (optionally) the machine instruction set; > + * bit 16 indicates little endian. > + * others - unused > + */ > void monitor_disas(Monitor *mon, CPUArchState *env, > target_ulong pc, int nb_insn, int is_physical, int flags)
I think it would be better to (1) fix the target_disas() comment so it is correct and (2) just say here that the flags word has the same meaning as for target_disas(). [I should probably fix the ARM monitor_disas flag handling...] thanks -- PMM
