Re: [Qemu-devel] [PATCH] pci-assign: add a way to blacklist loading of unstable roms

2014-04-04 Thread Alex Williamson
On Fri, 2014-04-04 at 18:49 -0400, Bandan Das wrote: > commit 4b9430294ed added an option in vfio to blacklist > roms that are known to be unstable. Add a similar mechanism > for pci-assign as well. The default behavior is to disable > loading but can be overriden by specifying rombar or romfile I

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-04 Thread Kevin O'Connor
On Wed, Apr 02, 2014 at 12:35:26AM +0200, Laszlo Ersek wrote: > On 04/02/14 00:00, Kevin O'Connor wrote: > > On Tue, Apr 01, 2014 at 11:44:12PM +0200, Laszlo Ersek wrote: > >> Right now, OVMF can accept individual fields, or table-at-a-time blobs, > >> via fw_cfg. > >> > >> The internal interface (

Re: [Qemu-devel] [PATCH v5 08/10] xbzrle: check 8 bytes at a time after an concurrency scene

2014-04-04 Thread 陈梁
> * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: >> From: ChenLiang >> >> The logic of old code is correct. But Checking byte by byte will >> consume time after an concurrency scene. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei >> --- >> xbzrle.c | 28 +

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-04 Thread Kevin O'Connor
On Fri, Apr 04, 2014 at 09:15:14PM -0400, Gabriel L. Somlo wrote: > On Fri, Apr 04, 2014 at 08:34:11PM -0400, Kevin O'Connor wrote: > > > > > > IMO 'dmidecode -t0' should show what firmware you are running > > > (seabios/ovmf/coreboot/whatever), not something made up by qemu. > > > > Ultimately m

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-04 Thread Gabriel L. Somlo
On Fri, Apr 04, 2014 at 08:34:11PM -0400, Kevin O'Connor wrote: > > > > IMO 'dmidecode -t0' should show what firmware you are running > > (seabios/ovmf/coreboot/whatever), not something made up by qemu. > > Ultimately my preference would be to make a clean break from the > existing smbios fw_cfg

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-04 Thread Kevin O'Connor
On Wed, Apr 02, 2014 at 05:04:57PM +0200, Gerd Hoffmann wrote: > > > - therefore, the maximum granularity of QEMU-generated > > > elements should be full tables of a given type, and > > > not the full SMBIOS blob at once (other mechanisms to > > > allow the BIOS to insert its own type

[Qemu-devel] [Bug 1301047] Re: Windows guest freezes while using USB passthrough.

2014-04-04 Thread zelluz
** Description changed: I have the following issue with my Windows 8.1 guest. (Technical stuff is at the bottom): I have vfio-binded my graphics card(NVIDIA GTX670) and is passing it through to the guest. I run heavy 3D applications such as games(Guild Wars 2, Diablo 3, DOTA etc) whic

[Qemu-devel] [Bug 1301047] Re: Windows guest freezes while using USB passthrough.

2014-04-04 Thread zelluz
** Description changed: I have the following issue with my Windows 8.1 guest. (Technical stuff is at the bottom): I have vfio-binded my graphics card(NVIDIA GTX670) and is passing it through to the guest. I run heavy 3D applications such as games(Guild Wars 2, Diablo 3, DOTA etc) whic

[Qemu-devel] [Bug 1301047] Re: Windows guest freezes while using USB passthrough.

2014-04-04 Thread zelluz
More technical information about Rocksmith Real Tone Cable(almost all the way to the bottom, beneath "Rocksmith Real Tone Cable): http://forums.ubi.com/showthread.php/802854-Rocksmith-2014-PC-Configuration-and-FAQ-Forums Here is the output of lsusb -vvv: Bus 003 Device 005: ID 12ba:00ff Licensed

[Qemu-devel] [Bug 1301047] Re: Windows guest freezes while using USB passthrough.

2014-04-04 Thread zelluz
** Description changed: I have the following issue with my Windows 8.1 guest. (Technical stuff is at the bottom): I have vfio-binded my graphics card(NVIDIA GTX670) and is passing it through to the guest. I run heavy 3D applications such as games(Guild Wars 2, Diablo 3, DOTA etc) whic

Re: [Qemu-devel] [PATCH for-2.0 v3 1/1] char/serial: Fix emptyness handling

2014-04-04 Thread Brian Jackson
On 04/04/2014 07:13 AM, Peter Crosthwaite wrote: > On Fri, Mar 28, 2014 at 10:10 PM, Paolo Bonzini wrote: >> Il 28/03/2014 12:43, Don Slutz ha scritto: >> >>> Ping. (Since this is a bug fix, I think it can go into 2.0) >>> -Don Slutz Not sure what the exact standard is for 2.0 stuff... but c

Re: [Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI

2014-04-04 Thread Brian Jackson
On 04/04/2014 05:41 AM, Takashi Iwai wrote: > Hi, > > this is the revisited patch series. The only difference from v2 > is that now they are checkpatch-clean and Cole's acks have been > added to patches 1-3. Is this 2.0 material? > > > Takashi >

[Qemu-devel] [PATCH] pci-assign: add a way to blacklist loading of unstable roms

2014-04-04 Thread Bandan Das
commit 4b9430294ed added an option in vfio to blacklist roms that are known to be unstable. Add a similar mechanism for pci-assign as well. The default behavior is to disable loading but can be overriden by specifying rombar or romfile Signed-off-by: Bandan Das --- Note: ignored checkpatch repor

Re: [Qemu-devel] [PATCH 0/5] xen: add Intel IGD passthrough support

2014-04-04 Thread Kevin O'Connor
On Fri, Feb 21, 2014 at 02:44:08PM +0800, Yang Zhang wrote: > From: Yang Zhang > > The following patches are ported from Xen Qemu-traditional branch which are > adding Intel IGD passthrough supporting to Qemu upstream. > > To pass through IGD to guest, user need to add following lines in Xen con

[Qemu-devel] [PATCH v8] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-04-04 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-off-by: Thomas Falcon --- Differences for v7:

Re: [Qemu-devel] [PATCH v5 09/10] migration: optimize xbzrle by reducing data copy

2014-04-04 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: ChenLiang > > Reducing data copy can reduce cpu overhead. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei Yes, with the previous patches that's now correct. Reviewed-by: Dr. David Alan Gilbert > --- > arch_init.c | 8

Re: [Qemu-devel] [PATCH v5 08/10] xbzrle: check 8 bytes at a time after an concurrency scene

2014-04-04 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: ChenLiang > > The logic of old code is correct. But Checking byte by byte will > consume time after an concurrency scene. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > xbzrle.c | 28 ++--

Re: [Qemu-devel] [PATCH v5 07/10] xbzrle: don't check the value in the vm ram repeatedly

2014-04-04 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: ChenLiang > > xbzrle_encode_buffer checks the value in the vm ram repeatedly. > It is risk if runs xbzrle_encode_buffer on changing data. > And it is not necessary. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: ChenLi

[Qemu-devel] [PULL 07/10] block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()

2014-04-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index d89c344..990a754 100644 --- a/block.c +++ b/block.c @@ -1184,7 +1184,12 @@ void bdrv_append_temp_snapshot(BlockDriverState *bs, Error **

[Qemu-devel] [PULL 09/10] iothread: make IOThread struct definition public

2014-04-04 Thread Kevin Wolf
From: Stefan Hajnoczi Make the IOThread struct definition public so objects can be embedded in parent structs. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Tested-by: Christian Borntraeger Signed-off-by: Kevin Wolf --- include/sysemu/iothread.h | 12 +++- iothread.c

[Qemu-devel] [PULL 08/10] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-04-04 Thread Kevin Wolf
From: Peter Maydell Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() does not return zero-initialized memory. Spotted by the clang sanitizer (which complained when the value loaded in dma_complete() was not valid for a bool type); this might have resulted in leaking the A

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc1 is now available

2014-04-04 Thread Kevin Wolf
Am 04.04.2014 um 21:10 hat Paolo Bonzini geschrieben: > Il 04/04/2014 16:57, Peter Maydell ha scritto: > >OK; I've updated the wiki page. Patches I know about for 2.0: > > > >[0/2] fix bugs involving linux-user signal handling > >[0/2] A15 board bugfixes > >dma-helpers: Initialize DMAAIOCB in_canc

[Qemu-devel] [PULL 05/10] qemu-iotests: Remove CR line endings in reference output

2014-04-04 Thread Kevin Wolf
qemu doesn't print these CRs any more. The test still didn't fail because the output comparison ignores line endings, but the change turns up each time when you want to update the output. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/051.out | 10 +- 1 file cha

[Qemu-devel] [PULL 06/10] block: Fix snapshot=on for protocol parsed from filename

2014-04-04 Thread Kevin Wolf
Since commit 9fd3171a, BDRV_O_SNAPSHOT uses an option QDict to specify the originally requested image as the backing file of the newly created temporary snapshot. This means that the filename is stored in "file.filename", which is an option that is not parsed for protocol names. Therefore things li

[Qemu-devel] [PULL 04/10] block: Don't parse 'filename' option

2014-04-04 Thread Kevin Wolf
When using the QDict option 'filename', it is supposed to be interpreted literally. The code did correctly avoid guessing the protocol from any string before the first colon, but it still called bdrv_parse_filename() which would, for example, incorrectly remove a 'file:' prefix in the raw-posix dri

[Qemu-devel] [PULL 10/10] dataplane: replace iothread object_add() with embedded instance

2014-04-04 Thread Kevin Wolf
From: Stefan Hajnoczi Before IOThread was its own object, each virtio-blk device would create its own internal thread. We need to preserve this behavior for backwards compatibility when users do not specify -device virtio-blk-pci,iothread=. This patch changes how the internal IOThread object is

[Qemu-devel] [PULL 01/10] iscsi: Don't set error if already set in iscsi_do_inquiry

2014-04-04 Thread Kevin Wolf
From: Fam Zheng This eliminates the possible assertion failure in error_setg(). Signed-off-by: Fam Zheng Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/iscsi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 21c18a

[Qemu-devel] [PULL 03/10] qcow2: Put cache reference in error case

2014-04-04 Thread Kevin Wolf
When qcow2_get_cluster_offset() sees a zero cluster in a version 2 image, it (rightfully) returns an error. But in doing so it shouldn't leak an L2 table cache reference. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/qcow2-cluster.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL 02/10] qcow2: Flush metadata during read-only reopen

2014-04-04 Thread Kevin Wolf
If lazy refcounts are enabled for a backing file, committing to this backing file may leave it in a dirty state even if the commit succeeds. The reason is that the bdrv_flush() call in bdrv_commit() doesn't flush refcount updates with lazy refcounts enabled, and qcow2_reopen_prepare() doesn't take

[Qemu-devel] [PULL 00/10] Block patches for 2.0

2014-04-04 Thread Kevin Wolf
The following changes since commit 5913815a17387a5e9825c734ccab760588471ee5: Update version for v2.0.0-rc1 release (2014-04-03 15:51:01 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 54bee5c2b487250dcb8631ddff4

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc1 is now available

2014-04-04 Thread Paolo Bonzini
Il 04/04/2014 16:57, Peter Maydell ha scritto: OK; I've updated the wiki page. Patches I know about for 2.0: [0/2] fix bugs involving linux-user signal handling [0/2] A15 board bugfixes dma-helpers: Initialize DMAAIOCB in_cancel flag target-i386: reorder fields in cpu/msr_hyperv_hypercall subse

Re: [Qemu-devel] For 2.0? Re: [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue

2014-04-04 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/04/2014 03:57 AM, arei.gong...@huawei.com wrote: > > From: ChenLiang > > > > V5-->V4 > > * Fix two issues: one is cache_insert don't update the page which > > has been in the cache. Another avoiding the risk that run > > xbzrle_encode_buffer on

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-04-04 Thread Kevin Wolf
Am 28.03.2014 um 15:22 hat Peter Maydell geschrieben: > Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() > does not return zero-initialized memory. Spotted by the clang sanitizer > (which complained when the value loaded in dma_complete() was not valid > for a bool type); t

Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-04-04 Thread Samuel Thibault
Hello, Samuel Thibault, le Thu 20 Mar 2014 10:03:20 +0100, a écrit : > Stefan Hajnoczi, le Thu 20 Mar 2014 08:58:11 +0100, a écrit : > > My suggestion is to split all the preparation and cleanups into a > > smaller patch series that can be applied easily. > > > > It will make the real IPv6 series

Re: [Qemu-devel] [V2 PATCH 0/9] target-ppc: VSX Bug Fixes

2014-04-04 Thread Peter Maydell
On 4 April 2014 17:18, Tom Musta wrote: > Alex, Peter: > > Is it too late to get this into 2.0? Alex's call (though my personal feeling would be to classify it as too late). It's very very late, but this will only affect PPC targets, at least. thanks -- PMM

[Qemu-devel] For 2.0? Re: [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue

2014-04-04 Thread Eric Blake
On 04/04/2014 03:57 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > V5-->V4 > * Fix two issues: one is cache_insert don't update the page which > has been in the cache. Another avoiding the risk that run > xbzrle_encode_buffer on changing data. Is all or part of this series essentia

Re: [Qemu-devel] [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue

2014-04-04 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: ChenLiang > > V5-->V4 > * Fix two issues: one is cache_insert don't update the page which > has been in the cache. Another avoiding the risk that run > xbzrle_encode_buffer on changing data. > I've just been running this, an

Re: [Qemu-devel] [PATCH 14/35] pc: exit QEMU if slots > 256

2014-04-04 Thread Eduardo Habkost
On Fri, Apr 04, 2014 at 03:36:39PM +0200, Igor Mammedov wrote: > ... which is current ACPI implementation limit. > > Signed-off-by: Igor Mammedov With this we will have yet another hardcoded limit/assumption scattererd in different places around the code, which we won't know how/if it can be cha

[Qemu-devel] [PATCH] Re: [PATCH] qcow2: Patch for shrinking qcow2 disk image

2014-04-04 Thread Jun Li
As the realization of raw shrinking, so when do qcow2 shrinking, do not check l1 entries. When resize to size1(size1 < "disk size"), the custemer knows this will destory the data. So no need to check the l1 entries which is used or not. BTW, there will possible be "disk size" > "virtual size". As t

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-04 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > This series allows to hotplug 'arbitrary' DIMM devices specifying size, > NUMA node mapping (guest side), slot and address where to map it, at runtime. Some high level questions: 1) Is the intention that all guest RAM would be hot pluggable like

[Qemu-devel] [PATCH] Re: [PATCH] qcow2: Patch for shrinking qcow2 disk image

2014-04-04 Thread Jun Li
As the realization of raw shrinking, so when do qcow2 shrinking, do not check l1 entries. When resize to size1(size1 < "disk size"), the custemer knows this will destory the data. So no need to check the l1 entries which is used or not. BTW, there will possible be "disk size" > "virtual size". As t

Re: [Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency

2014-04-04 Thread Eric Blake
On 04/04/2014 10:28 AM, Dr. David Alan Gilbert wrote: > One thing to be a little careful about if we merge these tunables > together, is what tunables are allowed to be changed while the migration > is running. The 'capabilities' are currently fixed once the migration > starts, but I know at least

Re: [Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency

2014-04-04 Thread Dr. David Alan Gilbert
One thing to be a little careful about if we merge these tunables together, is what tunables are allowed to be changed while the migration is running. The 'capabilities' are currently fixed once the migration starts, but I know at least some of the tuneables people want to change while things are

Re: [Qemu-devel] [V2 PATCH 0/9] target-ppc: VSX Bug Fixes

2014-04-04 Thread Tom Musta
Alex, Peter: Is it too late to get this into 2.0?

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-04 Thread Igor Mammedov
On Fri, 04 Apr 2014 17:19:50 +0200 Paolo Bonzini wrote: > Il 04/04/2014 16:24, Igor Mammedov ha scritto: > > > Can you explain this more? > > > > v7 had ability to map hotplugged DIMMs below 4Gb, but Gerd suggested to drop > > it since it consume precious lowmem for PCI devices. This version maps

Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 06:04:50PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 04, 2014 at 05:47:39PM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 04, 2014 at 11:51:52AM +0200, Juan Quintela wrote: > > > "Michael S. Tsirkin" wrote: > > > > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > >

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc1 is now available

2014-04-04 Thread Michael Roth
Quoting Stefan Weil (2014-04-04 00:17:49) > Am 03.04.2014 21:49, schrieb Michael Roth: > > Hello, > > > > On behalf of the QEMU Team, I'd like to announce the availability of the > > second release candidate for the QEMU 2.0 release. This release is meant > > for testing purposes and should not b

[Qemu-devel] [PATCH v2] qga: trivial fix for unclear documentation of guest-set-time

2014-04-04 Thread Amos Kong
We mixed the use of "guest time", "system time", "hardware time", "RTC" in documentation, it's unclear. This patch just added two remarks of RTC and replace two "guest time" by "guest's system time". Signed-off-by: Amos Kong Reviewed-by: Michal Privoznik Reviewed-by: Eric Blake --- V2: improve

Re: [Qemu-devel] [PATCH v2 3/3] block: Fix snapshot=on for protocol parsed from filename

2014-04-04 Thread Max Reitz
On 04.04.2014 16:56, Kevin Wolf wrote: Since commit 9fd3171a, BDRV_O_SNAPSHOT uses an option QDict to specify the originally requested image as the backing file of the newly created temporary snapshot. This means that the filename is stored in "file.filename", which is an option that is not parse

Re: [Qemu-devel] [PATCH] block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()

2014-04-04 Thread Max Reitz
On 04.04.2014 17:09, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- block.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-04 Thread Paolo Bonzini
Il 04/04/2014 16:24, Igor Mammedov ha scritto: > Can you explain this more? v7 had ability to map hotplugged DIMMs below 4Gb, but Gerd suggested to drop it since it consume precious lowmem for PCI devices. This version maps DIMM devices beyond above4gb memory. So "dropped support for 32 bit gues

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-04 Thread Eric Blake
[adding libvir-list] On 04/04/2014 05:23 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/04/2014 12:58, Markus Armbruster ha scritto: >>> >>> Have you considered extending QEMUMachineInitArgs instead of adding this >>> function? > > Did not think of this optio

[Qemu-devel] [PATCH] block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()

2014-04-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index d89c344..990a754 100644 --- a/block.c +++ b/block.c @@ -1184,7 +1184,12 @@ void bdrv_append_temp_snapshot(BlockDriverState *bs, Error **errp) instead of

Re: [Qemu-devel] [PATCH 3/3] block: Fix snapshot=on for protocol parsed from filename

2014-04-04 Thread Kevin Wolf
Am 04.04.2014 um 16:38 hat Max Reitz geschrieben: > On 04.04.2014 14:03, Kevin Wolf wrote: > >Since commit 9fd3171a, BDRV_O_SNAPSHOT uses an option QDict to specify > >the originally requested image as the backing file of the newly created > >temporary snapshot. This means that the filename is stor

Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 05:47:39PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 04, 2014 at 11:51:52AM +0200, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > > > > > hpet is a VARRAY with a uint8 size but static array of 32 > > > > > >

Re: [Qemu-devel] [PATCH] xbzrle: page may not be update if it has been in the cache

2014-04-04 Thread Eric Blake
On 04/02/2014 02:56 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > The cache_insert don't check whether the page has been in the cache. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > page_cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Er

[Qemu-devel] [PATCH 21/35] trace: add acpi memory hotplug IO region events

2014-04-04 Thread Igor Mammedov
Add events for tracing accesses to memory hotplug IO ports. Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug.c | 13 + trace-events | 13 + 2 files changed, 26 insertions(+) diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index b0292c8

Re: [Qemu-devel] [PATCH] qga: trivial fix for unclear document of guest-set-time

2014-04-04 Thread Eric Blake
On 04/03/2014 06:53 PM, Amos Kong wrote: > We mixedly used "guest time", "system time", "hardware time", "RTC" s/mixedly used/mixed the use of/ > in document, it's unclear. s/document/documentation/ > > This patch just added two remarks of RTC and replace two "guest time" > by "guest's system

[Qemu-devel] [PATCH 06/35] add pc-{i440fx,q35}-2.1 machine types

2014-04-04 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc_piix.c | 23 +-- hw/i386/pc_q35.c | 21 - 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7930a26..f0dc4d1 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/

[Qemu-devel] [PATCH 24/35] acpi:piix4: add memory hotplug handling

2014-04-04 Thread Igor Mammedov
Add memory hotplug initialization/handling to PIIX4_PM device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c | 15 ++- hw/i386/pc_piix.c| 4 include/hw/acpi/memory_hotplug.h | 1 + include/h

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc1 is now available

2014-04-04 Thread Peter Maydell
On 4 April 2014 15:39, Stefan Hajnoczi wrote: > On Thu, Apr 3, 2014 at 10:02 PM, Peter Maydell > wrote: >> On 3 April 2014 20:49, Michael Roth wrote: >>> Hello, >>> >>> On behalf of the QEMU Team, I'd like to announce the availability of the >>> second release candidate for the QEMU 2.0 release

Re: [Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency

2014-04-04 Thread Eric Blake
On 04/03/2014 11:29 PM, Michael R. Hines wrote: >> I'm trying to thing of a back-compat method, which exploits the fact >> that we now have flat unions (something we didn't have when >> migrate-set-capabilities was first added). Maybe something like: >> >> { 'type': 'MigrationCapabilityBase', >>

[Qemu-devel] [PATCH v2 3/3] block: Fix snapshot=on for protocol parsed from filename

2014-04-04 Thread Kevin Wolf
Since commit 9fd3171a, BDRV_O_SNAPSHOT uses an option QDict to specify the originally requested image as the backing file of the newly created temporary snapshot. This means that the filename is stored in "file.filename", which is an option that is not parsed for protocol names. Therefore things li

[Qemu-devel] [PATCH 35/35] pc: ACPI BIOS: update pregenerated ACPI table blobs

2014-04-04 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.hex.generated | 102 - hw/i386/q35-acpi-dsdt.hex.generated | 104 - hw/i386/ssdt-mem.hex.generated | 197 + hw/i386/ssdt-misc.hex.generated | 809 +++- 4 files changed, 1162 insertions(

[Qemu-devel] [PATCH 17/35] dimm: add busy address check and address auto-allocation

2014-04-04 Thread Igor Mammedov
- if 'start' property is not specified on -device/device_add command, treat default value as request for assigning DimmDevice to the first free memory region. - if 'start' is provided with -device/device_add command, attempt to use it or fail command if it's already occupied or falls inside of an

Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 11:51:52AM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > > > hpet is a VARRAY with a uint8 size but static array of 32 > > > > To fix, make sure num_timers is valid using VMSTATE_VALID hook. > > > > Reported-b

[Qemu-devel] [PATCH 09/35] qdev: expose DeviceState.hotplugged field as a property

2014-04-04 Thread Igor Mammedov
so that managment could detect via QOM interface if device was hotplugged Signed-off-by: Igor Mammedov --- hw/core/qdev.c | 17 + 1 file changed, 17 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 50bb8f5..a278380 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c

Re: [Qemu-devel] [PATCH] qcow2: Put cache reference in error case

2014-04-04 Thread Max Reitz
On 04.04.2014 14:19, Kevin Wolf wrote: When qcow2_get_cluster_offset() sees a zero cluster in a version 2 image, it (rightfully) returns an error. But in doing so it shouldn't leak an L2 table cache reference. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 1 + 1 file changed, 1 inser

[Qemu-devel] [PATCH 15/35] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2014-04-04 Thread Igor Mammedov
'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI BARs mapping could safely start in high memory. Allowing BIOS to start mapping 64-bit PCI BARs at address where it wouldn't conflict with other mappings QEMU might place before it. That permits QEMU to reserve extra address space be

Re: [Qemu-devel] [PATCH 3/3] block: Fix snapshot=on for protocol parsed from filename

2014-04-04 Thread Max Reitz
On 04.04.2014 14:03, Kevin Wolf wrote: Since commit 9fd3171a, BDRV_O_SNAPSHOT uses an option QDict to specify the originally requested image as the backing file of the newly created temporary snapshot. This means that the filename is stored in "file.filename", which is an option that is not parse

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc1 is now available

2014-04-04 Thread Stefan Hajnoczi
On Thu, Apr 3, 2014 at 10:02 PM, Peter Maydell wrote: > On 3 April 2014 20:49, Michael Roth wrote: >> Hello, >> >> On behalf of the QEMU Team, I'd like to announce the availability of the >> second release candidate for the QEMU 2.0 release. This release is meant >> for testing purposes and shou

[Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-04 Thread Igor Mammedov
Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 734c6ee..ee5cf88 100644 --

Re: [Qemu-devel] [PATCH 27/35] pc: migrate piix4 & ich9 MemHotplugState

2014-04-04 Thread Igor Mammedov
On Fri, 04 Apr 2014 16:16:34 +0200 Paolo Bonzini wrote: > Il 04/04/2014 15:36, Igor Mammedov ha scritto: > > Adds an optional vmstate field that allows to migrate current > > state of acpi_memory_hotplug of ACPI PM device. > > > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/ich9.c

[Qemu-devel] [PATCH 03/35] object_add: allow completion handler to get canonical path

2014-04-04 Thread Igor Mammedov
Add object to /objects before calling user_creatable_complete() handler, so that object might be able to call object_get_canonical_path() in its completion handler. Signed-off-by: Igor Mammedov --- qmp.c | 11 --- vl.c | 12 2 files changed, 16 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH 20/35] acpi: memory hotplug ACPI hardware implementation

2014-04-04 Thread Igor Mammedov
- implements QEMU hardware part of memory hotplug protocol described at "docs/specs/acpi_mem_hotplug.txt" - handles only memory add notification event for now Signed-off-by: Igor Mammedov --- docs/specs/acpi_mem_hotplug.txt | 44 hw/acpi/Makefile.objs| 1 + hw/acpi

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-04 Thread Igor Mammedov
On Fri, 04 Apr 2014 16:02:32 +0200 Paolo Bonzini wrote: > Il 04/04/2014 15:36, Igor Mammedov ha scritto: > > +acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find(); > > +if (!acpi_dev) { > > +error_setg(&local_err, > > + "memory hotplug is not enab

[Qemu-devel] [PATCH 12/35] dimm: do not allow to set already busy memdev

2014-04-04 Thread Igor Mammedov
using the same memdev backend more than once will cause assersion at MemoryRegion mapping time becase it's already mapped. Prevent it by checking that associated MemoryRegion is not mapped. Signed-off-by: Igor Mammedov --- hw/mem/dimm.c | 17 - 1 file changed, 16 insertions(+), 1

[Qemu-devel] [PATCH 30/35] pc: ACPI BIOS: name CPU hotplug ACPI0004 device

2014-04-04 Thread Igor Mammedov
Following patches will add another ACPI0004 device to the same scope, and that will make Windows BSOD because it thinks that the second ACPI0004 device is duplicate. Adding to device unique _UID, fixes issue and allows Windows to distinguish devices with the same _HID Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-04 Thread Igor Mammedov
On Fri, 04 Apr 2014 16:07:53 +0200 Paolo Bonzini wrote: > Il 04/04/2014 15:36, Igor Mammedov ha scritto: > > > > * dropped support for 32 bit guests > > Can you explain this more? v7 had ability to map hotplugged DIMMs below 4Gb, but Gerd suggested to drop it since it consume precious lowmem for

[Qemu-devel] [PATCH] Truncate pidfile in open

2014-04-04 Thread Zhaolei
From: Zhao Lei qemu havn't cleanup old pidfile before write new: # echo "00" > mypid # cat mypid 00 # # qemu-system-x86_64 -pidfile ./mypid Could not initialize SDL(No available video device) - exiting # cat mypid 29788 # Can be fixed by adding O_TRUNC in open.

Re: [Qemu-devel] [PATCH 27/35] pc: migrate piix4 & ich9 MemHotplugState

2014-04-04 Thread Paolo Bonzini
Il 04/04/2014 15:36, Igor Mammedov ha scritto: Adds an optional vmstate field that allows to migrate current state of acpi_memory_hotplug of ACPI PM device. Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 8 hw/acpi/memory_hotplug.c | 27 ++

Re: [Qemu-devel] [PATCH v5 12/37] target-arm: A64: Implement DC ZVA

2014-04-04 Thread Peter Maydell
On 28 March 2014 18:42, Richard Henderson wrote: > On 03/28/2014 09:09 AM, Peter Maydell wrote: >> +for (i = 0; i < maxidx; i++) { >> +hostaddr[i] = tlb_vaddr_to_host(env, >> +vaddr + TARGET_PAGE_SIZE * >> i, >> +

Re: [Qemu-devel] [PATCH for-2.0 v2 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation

2014-04-04 Thread Richard Henderson
On 04/04/2014 04:52 AM, Peter Maydell wrote: > If the guest attempts to execute from unreadable memory, this will > cause us to longjmp back to the main loop from inside the > target frontend decoder. For linux-user mode, this means we will > still hold the tb_ctx.tb_lock, and will deadlock when we

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-04 Thread Paolo Bonzini
Il 04/04/2014 15:36, Igor Mammedov ha scritto: +acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find(); +if (!acpi_dev) { +error_setg(&local_err, + "memory hotplug is not enabled: missing acpi device"); errp, not &local_err. Paolo +retu

Re: [Qemu-devel] [PATCH v7] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-04-04 Thread Alexander Graf
On 04/01/2014 10:03 PM, Thomas Falcon wrote: This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-o

[Qemu-devel] [PATCH 22/35] trace: add DIMM slot & address allocation for target-i386

2014-04-04 Thread Igor Mammedov
Add mhp_pc_dimm_assigned_slot & mhp_pc_dimm_assigned_address events to trace which address and slot where assigned to plugged in DIMM device on target-i386 machine. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 3 +++ trace-events | 4 2 files changed, 7 insertions(+) diff --git a/hw/i38

Re: [Qemu-devel] [PATCH 1/3] block: Don't parse 'filename' option

2014-04-04 Thread Max Reitz
On 04.04.2014 14:03, Kevin Wolf wrote: When using the QDict option 'filename', it is supposed to be interpreted literally. The code did correctly avoid guessing the protocol from any string before the first colon, but it still called bdrv_parse_filename() which would, for example, incorrectly rem

[Qemu-devel] [PATCH 27/35] pc: migrate piix4 & ich9 MemHotplugState

2014-04-04 Thread Igor Mammedov
Adds an optional vmstate field that allows to migrate current state of acpi_memory_hotplug of ACPI PM device. Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 8 hw/acpi/memory_hotplug.c | 27 +++ hw/acpi/piix4.c | 8

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Remove CR line endings in reference output

2014-04-04 Thread Max Reitz
On 04.04.2014 14:03, Kevin Wolf wrote: qemu doesn't print these CRs any more. The test still didn't fail because the output comparison ignores line endings, but the change turns up each time when you want to update the output. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051.out | 10

[Qemu-devel] [PATCH 34/35] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2014-04-04 Thread Igor Mammedov
also make handler edge based to avoid loosing events, the same as it has been done for PCI and CPU hotplug handlers. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.dsl | 5 - hw/i386/q35-acpi-dsdt.dsl | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/a

[Qemu-devel] [PATCH 31/35] pc: ACPI BIOS: implement memory hotplug interface

2014-04-04 Thread Igor Mammedov
- provides static SSDT object for memory hotplug - SSDT template for memory devices and runtime generator of them in SSDT table. Signed-off-by: Vasilis Liaskovitis Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs | 3 +- hw/i386/acpi-build.c | 37 hw/i386/ssdt-mem.dsl

[Qemu-devel] [PATCH 26/35] acpi:ich9: add memory hotplug handling

2014-04-04 Thread Igor Mammedov
Add memory hotplug initialization/handling to ICH9 LPC device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 38 ++ hw/i386/pc_q35.c | 4 hw/isa/lpc_ich9.c | 20 +++

[Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-04 Thread Igor Mammedov
... and report error if plugged in device is not supported. Later generic callbacks will be used by memory hotplug. Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix

[Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-04-04 Thread Igor Mammedov
Needed for Windows to use hotplugged memory device, otherwise it complains that server is not configured for memory hotplug. Tests shows that aftewards it uses dynamically provided proximity value from _PXM() method if available. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 14 +++

[Qemu-devel] [PATCH 19/35] acpi: rename cpu_hotplug_defs.h to acpi_defs.h

2014-04-04 Thread Igor Mammedov
to make it more generic, so it could be used for memory hotplug as well. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.dsl | 2 +- hw/i386/q35-acpi-dsdt.dsl | 2 +- include/hw/acpi/acpi_defs.h| 32 include/hw/acpi/cpu_hotplug.

[Qemu-devel] [PATCH 10/35] dimm: implement dimm device abstraction

2014-04-04 Thread Igor Mammedov
Each hotplug-able memory slot is a DimmDevice. A hot-add operation for a DIMM: - creates a new DimmDevice and makes hotplug controller to map it into guest address space Hotplug operations are done through normal device_add commands. For migration case, all hotplugged DIMMs on source should be s

[Qemu-devel] [PATCH 18/35] dimm: add busy slot check and slot auto-allocation

2014-04-04 Thread Igor Mammedov
- if slot property is not specified on -device/device_add command, treat default value as request for assigning DimmDevice to the first free slot. - if slot is provided with -device/device_add command, attempt to use it or fail command if it's already occupied. Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH 29/35] pc: ACPI BIOS: punch holes in PCI0._CRS for memory hotplug IO region

2014-04-04 Thread Igor Mammedov
... to make sure that IO range used by memory hotlug won't be used by PCI devices. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.dsl | 10 +- hw/i386/q35-acpi-dsdt.dsl | 10 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i38

[Qemu-devel] [PATCH 16/35] pc: add memory hotplug handler to PC_MACHINE

2014-04-04 Thread Igor Mammedov
that will perform mapping of DIMM device into guest's RAM address space Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 52 include/hw/i386/pc.h | 8 2 files changed, 60 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

[Qemu-devel] [PATCH 32/35] pc: ACPI BIOS: use enum for defining memory affinity flags

2014-04-04 Thread Igor Mammedov
replace magic numbers with enum describing Flags field of memory affinity in SRAT table. MemoryAffinityFlags enum will define flags decribed by: ACPI spec 5.0, "5.2.16.2 Memory Affinity Structure", "Table 5-69 Flags - Memory Affinity Structure" Signed-off-by: Igor Mammedov --- hw/i386/acpi-bu

  1   2   >