Re: [Qemu-devel] [PATCH v2] target-ppc: improve "info registers" by printing SPRs

2014-03-23 Thread Alexey Kardashevskiy
On 03/23/2014 01:43 AM, Stuart Brady wrote: > On Sat, Mar 22, 2014 at 11:25:49PM +1100, Alexey Kardashevskiy wrote: >> This adds printing of all SPR registers registered for a CPU. >> >> This removes "SPR_" prefix from SPR name to reduce the output. >> >> Cc: Fabien Chouteau >> Signed-off-by: Alex

[Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed

2014-03-23 Thread Deepak Kathayat
Signed-off-by: Deepak Kathayat --- block/qcow2.h |1 - 1 file changed, 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index 0b0eac8..25663d4 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -413,7 +413,6 @@ static inline uint64_t l2meta_cow_end(QCowL2Meta *m) + (m->cow_e

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-23 Thread Alexey Kardashevskiy
On 03/23/2014 08:23 AM, Peter Maydell wrote: > On 22 March 2014 21:04, Andreas Färber wrote: >> Am 22.03.2014 21:54, schrieb Peter Maydell: >>> On 22 March 2014 20:18, Andreas Färber wrote: Because AFAIU migration is possible without VMSD, just not with VMSD that sets .unmigratable

[Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-03-23 Thread Alexey Kardashevskiy
Currently only migration fails if CPU version is different even a bit. For example, migration from POWER7 v2.0 to POWER7 v2.1 fails because of that. Since there is no difference between CPU versions which could affect migration stream, we can safely enable it. This adds a helper to find the closes

Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options

2014-03-23 Thread Chun Yan Liu
I'll update. All patch series could also be available from: https://github.com/chunyanliu/qemu/commits/QemuOpts >>> On 3/22/2014 at 07:27 AM, in message <532ccadc.40...@redhat.com>, Eric Blake wrote: > On 03/21/2014 04:12 AM, Chunyan Liu wrote: > > Change qapi interfaces to output the newly add

Re: [Qemu-devel] [PATCH v22 00/25] replace QEMUOptionParameter with QemuOpts

2014-03-23 Thread Chunyan Liu
2014-03-21 20:31 GMT+08:00 Leandro Dorileo : > On Fri, Mar 21, 2014 at 06:09:22PM +0800, Chunyan Liu wrote: > > 2014-03-21 8:07 GMT+08:00 Leandro Dorileo : > > > > > Hi Chunyan, > > > > > > On Mon, Mar 10, 2014 at 03:31:36PM +0800, Chunyan Liu wrote: > > > > This patch series is to replace QEMUOpt

Re: [Qemu-devel] [RFC PATCH V3 4/5] test: add test cases for qapi event

2014-03-23 Thread Wenchao Xia
于 2014/3/21 8:23, Eric Blake 写道: On 03/18/2014 11:16 PM, Wenchao Xia wrote: These cases will verify whether the expected qdict is built. Signed-off-by: Wenchao Xia --- tests/Makefile | 14 ++- tests/qapi-schema/qapi-schema-test.json | 12 ++ tests/qapi-schema/qa

Re: [Qemu-devel] [RFC PATCH V3 3/5] qapi script: add event support

2014-03-23 Thread Wenchao Xia
于 2014/3/21 7:06, Eric Blake 写道: On 03/18/2014 11:16 PM, Wenchao Xia wrote: qapi-event.py will parse the schema and generate qapi-event.c, then the API in qapi-event.c can be used to handle event in qemu code. All API have prefix "qapi_event". The script mainly include two parts: generate API f

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-03-23 Thread Wenchao Xia
于 2014/3/21 6:29, Eric Blake 写道: On 03/18/2014 08:38 PM, Wenchao Xia wrote: 于 2014/3/7 2:49, Eric Blake 写道: On 01/02/2014 04:10 PM, Wenchao Xia wrote: qapi-event.py will parse the schema and generate qapi-event.c, then the API in qapi-event.c can be used to handle event in qemu code. All API h

Re: [Qemu-devel] [RFC PATCH V3 2/5] qapi: add event helper functions

2014-03-23 Thread Wenchao Xia
于 2014/3/21 6:53, Eric Blake 写道: On 03/18/2014 11:16 PM, Wenchao Xia wrote: This file hold some functions that do not need to be generated. s/hold/holds/ Signed-off-by: Wenchao Xia --- include/qapi/qmp-event.h | 25 qapi/Makefile.objs |1 + qapi/qmp-event.c

[Qemu-devel] [V2 PATCH] target-ppc: Bug: VSX Convert to Integer Should Truncate

2014-03-23 Thread Tom Musta
The various VSX Convert to Integer instructions should truncate the mantissa. This fix forces the softfloat rounding mode to "round to zero" prior to performing the conversion. After the conversion is completed, the internal rounding mode is restored from the PowerPC FPSCR bits. Signed-off-by: T

Re: [Qemu-devel] [PATCH] target-ppc: Bug: VSX Convert to Integer Should Truncate

2014-03-23 Thread Peter Maydell
On 23 March 2014 18:02, Tom Musta wrote: > diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c > index e7f3295..ccfc5cc 100644 > --- a/target-ppc/fpu_helper.c > +++ b/target-ppc/fpu_helper.c > @@ -2558,10 +2558,14 @@ void helper_##op(CPUPPCState *env, uint32_t opcode) >

[Qemu-devel] [PATCH] target-ppc: Bug: VSX Convert to Integer Should Truncate

2014-03-23 Thread Tom Musta
The various VSX Convert to Integer instructions should truncate the mantissa. This fix forces the softfloat rounding mode to "round to zero" prior to performing the conversion. After the conversion is completed, the internal rounding mode is restored from the PowerPC FPSCR bits. Signed-off-by: T

Re: [Qemu-devel] [RFC 2/8] make machine_class_init() accessible outside of vl.c

2014-03-23 Thread Marcel Apfelbaum
On Sun, 2014-03-23 at 17:27 +0200, Marcel Apfelbaum wrote: > On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/core/machine.c |7 +++ > > include/hw/boards.h |2 ++ > > vl.c|7 --- > > 3 files changed, 9 i

Re: [Qemu-devel] [PATCH] osdep: initialize glib threads in all QEMU tools

2014-03-23 Thread Stefan Hajnoczi
On Tue, Oct 08, 2013 at 11:58:31AM +0200, Stefan Hajnoczi wrote: > glib versions prior to 2.31.0 require an explicit g_thread_init() call > to enable multi-threading. > > Failure to initialize threading causes glib to take single-threaded code > paths without synchronization. For example, the g_s

Re: [Qemu-devel] [RFC 2/8] make machine_class_init() accessible outside of vl.c

2014-03-23 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/core/machine.c |7 +++ > include/hw/boards.h |2 ++ > vl.c|7 --- > 3 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/hw/core/machine.c b/hw/cor

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-23 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 26 ++ > hw/i386/pc_piix.c| 34 +- > hw/i386/pc_q35.c | 10 +- > include/hw/i386/pc.h | 14

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Michael S. Tsirkin
On Sun, Mar 23, 2014 at 03:17:32PM +0200, Marcel Apfelbaum wrote: > On Sun, 2014-03-23 at 13:51 +0100, Paolo Bonzini wrote: > > Il 23/03/2014 13:32, Marcel Apfelbaum ha scritto: > > >> > That's the endianness of the machine we're compiling QEMU > > >> > for, not the endianness of the machine we're

Re: [Qemu-devel] [PATCH 4/5] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-03-23 Thread Chen Gang
On 03/16/2014 09:32 PM, Chen Gang wrote: > On 03/08/2014 09:58 PM, Chen Gang wrote: >> OK, thanks. >> >> Next, I will/should continue to analyse the performance issue for 9pfs >> when users drop into a long directory path under bash shell. >> > > After have a test, I am sure it is not 9pfs issue,

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Marcel Apfelbaum
On Sun, 2014-03-23 at 13:51 +0100, Paolo Bonzini wrote: > Il 23/03/2014 13:32, Marcel Apfelbaum ha scritto: > >> > That's the endianness of the machine we're compiling QEMU > >> > for, not the endianness of the machine we're compiling QEMU > >> > on. If for instance you're on x86_64 cross-compiling

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Marcel Apfelbaum
On Sun, 2014-03-23 at 12:48 +, Peter Maydell wrote: > On 23 March 2014 12:32, Marcel Apfelbaum wrote: > > On Sun, 2014-03-23 at 12:14 +, Peter Maydell wrote: > >> On 23 March 2014 09:49, Michael S. Tsirkin wrote: > >> > At this point I'm confused. > >> > If iasl compiler is broken, we sho

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Paolo Bonzini
Il 23/03/2014 13:32, Marcel Apfelbaum ha scritto: > That's the endianness of the machine we're compiling QEMU > for, not the endianness of the machine we're compiling QEMU > on. If for instance you're on x86_64 cross-compiling for PPC > then HOST_WORDS_BIGENDIAN is true, but the iasl you use > in

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Peter Maydell
On 23 March 2014 12:32, Marcel Apfelbaum wrote: > On Sun, 2014-03-23 at 12:14 +, Peter Maydell wrote: >> On 23 March 2014 09:49, Michael S. Tsirkin wrote: >> > At this point I'm confused. >> > If iasl compiler is broken, we should detect and fix that. >> > It might be ok to just detect endian

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Marcel Apfelbaum
On Sun, 2014-03-23 at 12:14 +, Peter Maydell wrote: > On 23 March 2014 09:49, Michael S. Tsirkin wrote: > > At this point I'm confused. > > If iasl compiler is broken, we should detect and fix that. > > It might be ok to just detect endian-ness as a quick work-around. > > BTW configure already

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Peter Maydell
On 23 March 2014 09:52, Michael S. Tsirkin wrote: > Hard to predict the future: it's possible that some distros > will ship partially broken iasl on BE. > We really need to see a working one to be sure ... Well at the moment we have a known broken iasl, and we have a known OK iasl (in the sense t

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Marcel Apfelbaum
On Fri, 2014-03-21 at 00:16 +0100, Paolo Bonzini wrote: > Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: > > I've seen something like that somewhere, but I didn't quite like it. > > I was looking for something more elegant as I was *almost* sure > > this kind of solution will not pass the review

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Peter Maydell
On 23 March 2014 09:49, Michael S. Tsirkin wrote: > At this point I'm confused. > If iasl compiler is broken, we should detect and fix that. > It might be ok to just detect endian-ness as a quick work-around. > BTW configure already has code to detect endian-ness: > if test "$bigendian" = "yes" ;

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Michael S. Tsirkin
On Thu, Mar 20, 2014 at 11:03:04PM +, Peter Maydell wrote: > On 20 March 2014 22:41, Marcel Apfelbaum wrote: > > On Thu, 2014-03-20 at 22:17 +, Peter Maydell wrote: > >> echo "trivial iasl source" | iasl --compile-options | iasl > >> --disassemble-options | grep "error" > >> > >> Fill in t

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Michael S. Tsirkin
On Thu, Mar 20, 2014 at 10:17:14PM +, Peter Maydell wrote: > On 20 March 2014 22:06, Marcel Apfelbaum wrote: > > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: > >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: > >> > +# All known versions of iasl on BE machines are broken. > >> >

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-23 Thread Michael S. Tsirkin
On Fri, Mar 21, 2014 at 12:16:53AM +0100, Paolo Bonzini wrote: > Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: > >I've seen something like that somewhere, but I didn't quite like it. > >I was looking for something more elegant as I was *almost* sure > >this kind of solution will not pass the re

[Qemu-devel] [PATCH 4/6] hw/timer/grlib_gptimer: remove unnecessary assignment

2014-03-23 Thread Prasad Joshi
Signed-off-by: Prasad Joshi --- hw/timer/grlib_gptimer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/timer/grlib_gptimer.c b/hw/timer/grlib_gptimer.c index 7672d3a..d655bb2 100644 --- a/hw/timer/grlib_gptimer.c +++ b/hw/timer/grlib_gptimer.c @@ -328,7 +328,6 @@ static void grlib_gptimer

[Qemu-devel] [PATCH 3/6] pcnet: remove duplicate assignment

2014-03-23 Thread Prasad Joshi
Signed-off-by: Prasad Joshi --- hw/net/pcnet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index 7cb47b3..ebe5057 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -718,7 +718,6 @@ static void pcnet_s_reset(PCNetState *s) s->csr[94] = 0x; s-

[Qemu-devel] [PATCH 6/6] net: netmap_poll must update both read/write poll state

2014-03-23 Thread Prasad Joshi
Signed-off-by: Prasad Joshi --- net/netmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netmap.c b/net/netmap.c index 8213304..0c1772b 100644 --- a/net/netmap.c +++ b/net/netmap.c @@ -177,8 +177,8 @@ static void netmap_poll(NetClientState *nc, bool enable) Ne

[Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function

2014-03-23 Thread Prasad Joshi
Signed-off-by: Prasad Joshi --- hw/intc/openpic_kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c index 87fdb12..afa604d 100644 --- a/hw/intc/openpic_kvm.c +++ b/hw/intc/openpic_kvm.c @@ -200,7 +200,7 @@ static void kvm_openpic

[Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot

2014-03-23 Thread Prasad Joshi
CSMKeyControll function is supposed to set the top level latch for each slot. However, at the moment, it incorrectly updates only the first slot. Patch fixes the problem. Signed-off-by: Prasad Joshi --- hw/audio/fmopl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio

[Qemu-devel] [PATCH 5/6] linux-user: remove duplicate statement

2014-03-23 Thread Prasad Joshi
Signed-off-by: Prasad Joshi --- linux-user/signal.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index e5fb933..7d6246f 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -4043,8 +4043,6 @@ static void setup_rt_frame(int sig, struct ta