On Fri, Mar 21, 2014 at 12:16:53AM +0100, Paolo Bonzini wrote: > Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: > >I've seen something like that somewhere, but I didn't quite like it. > >I was looking for something more elegant as I was *almost* sure > >this kind of solution will not pass the reviews :) > > > >But maybe I'll try this, let's see what happens, > > If all you're looking for is bigendian (disabling iasl disassembly > on bigendian makes sense), your patch v2 is fine. > > Assembling ASL on bigendian is supported by at least Fedora and > Debian (and hence Ubuntu). > > Paolo
At this point I'm confused. If iasl compiler is broken, we should detect and fix that. It might be ok to just detect endian-ness as a quick work-around. BTW configure already has code to detect endian-ness: if test "$bigendian" = "yes" ; then echo "HOST_WORDS_BIGENDIAN=y" >> $config_host_mak fi If only the dis-assembler is broken, we should only detect that when running tests. Using expected files for this should be fine. -- MST
