Re: [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage

2014-03-20 Thread Peter Lieven
On 21.03.2014 01:13, Leandro Dorileo wrote: Do the directly migration from QemuOptionParameter to QemuOpts on iscsi block driver. Signed-off-by: Leandro Dorileo --- block/iscsi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/block/iscs

[Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-20 Thread Olivier Danet
The signed integer division -0x8000___ / -1 must be handled separately to avoid an overflow on the QEMU host. Negative overflow must be a negative number for correct sign extension in Sparc64 mode. Use constants. Signed-off-by: Olivier Danet --- target-sparc/helper.c | 17 +

[Qemu-devel] [PATCH 17/26] rbd: migrate rbd driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on rbd block driver. Signed-off-by: Leandro Dorileo --- block/rbd.c | 60 +--- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index db

[Qemu-devel] [PATCH 06/26] block: migrate block later QemuOptionParameter

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on block layer. Signed-off-by: Leandro Dorileo --- block.c | 133 -- include/block/block.h | 7 ++- include/block/block_int.h | 8 ++- 3 files changed, 86 insertio

[Qemu-devel] [PATCH 19/26] ssh: migrate ssh driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on ssh block driver. Signed-off-by: Leandro Dorileo --- block/ssh.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index aa63c9d..b55c518 100644 --- a/blo

[Qemu-devel] [PATCH 20/26] vdi: migrate vdi driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on vdi block driver. Signed-off-by: Leandro Dorileo --- block/vdi.c | 73 - 1 file changed, 34 insertions(+), 39 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index a

[Qemu-devel] [PATCH 11/26] qcow: migrate qcow driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on qcow block driver. Signed-off-by: Leandro Dorileo --- block/qcow.c | 59 +-- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index

[Qemu-devel] [PATCH 01/26] qapi: output def_value_str when query command line options

2014-03-20 Thread Leandro Dorileo
From: Chunyan Liu Change qapi interfaces to output the newly added def_value_str when querying command line options. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- qapi-schema.json | 6 +- qmp-commands.hx| 2 ++ util/qemu-config.c | 4 3 files changed, 11 insertions

[Qemu-devel] [PATCH 18/26] sheepdog: migrate sheepdog driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on sheepdog block driver. Signed-off-by: Leandro Dorileo --- block/sheepdog.c | 104 --- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/block/sheepdog.c b/block/she

[Qemu-devel] [PATCH 00/26] QemuOptionParameter -> QemuOpts migration

2014-03-20 Thread Leandro Dorileo
This patch series does the QemuOptionParameter -> QemuOpts migration. The idea is to collect all the required Reviewed-by and squash the patches changing the block layer + block drivers (patches [06..25]) in a single patch so we don't break anything and keep the tree's bisectability (just in case w

[Qemu-devel] [PATCH 24/26] vvfat: migrate vvfat driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on vvfat block driver. Signed-off-by: Leandro Dorileo --- block/vvfat.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index f966ea5..7aefba3 100644 --- a

[Qemu-devel] [PATCH 22/26] vmdk: migrate vmdk driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on vmdk block driver. Signed-off-by: Leandro Dorileo --- block/vmdk.c | 105 ++- 1 file changed, 53 insertions(+), 52 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c inde

Re: [Qemu-devel] [RFC PATCH V3 5/5] qapi event: convert RTC_CHANGE

2014-03-20 Thread Eric Blake
On 03/18/2014 11:16 PM, Wenchao Xia wrote: > This is just an example of how to use qapi event API, and it > bypassed the event throttle queue. A complete convert should > be first define all events in qapi-schema.json, use qapi > event types in monitor functions, then change caller one > by one. T

[Qemu-devel] [PATCH 16/26] raw_bsd: migrate raw_bsd driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on raw_bsd block driver. Signed-off-by: Leandro Dorileo --- block/raw_bsd.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 01ea692..5090b4e 100644 --

Re: [Qemu-devel] [RFC PATCH V3 4/5] test: add test cases for qapi event

2014-03-20 Thread Eric Blake
On 03/18/2014 11:16 PM, Wenchao Xia wrote: > These cases will verify whether the expected qdict is built. > > Signed-off-by: Wenchao Xia > --- > tests/Makefile | 14 ++- > tests/qapi-schema/qapi-schema-test.json | 12 ++ > tests/qapi-schema/qapi-schema-test.out |

[Qemu-devel] [PATCH 15/26] raw-win32: migrate cow driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on raw-win32 block driver. Signed-off-by: Leandro Dorileo --- block/raw-win32.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 48cb2c2..

[Qemu-devel] [PATCH 26/26] qemu-img: migrate QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on qemu-img. Signed-off-by: Leandro Dorileo --- qemu-img.c | 166 +++-- 1 file changed, 95 insertions(+), 71 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 2e40cc1..1a

[Qemu-devel] [PATCH 12/26] qcow2: migrate qcow2 driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on qcow2 block driver. Signed-off-by: Leandro Dorileo --- block/qcow2.c | 263 -- 1 file changed, 128 insertions(+), 135 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c

[Qemu-devel] [PATCH 21/26] vhdx: migrate vhdx driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on vhdx block driver. Signed-off-by: Leandro Dorileo --- block/vhdx.c | 88 1 file changed, 41 insertions(+), 47 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c inde

[Qemu-devel] [PATCH 10/26] nfs: migrate nfs driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on nfs block driver. Signed-off-by: Leandro Dorileo --- block/nfs.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 98aa363..c01f109 100644 --- a/block/nfs.c +++ b/block

[Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on iscsi block driver. Signed-off-by: Leandro Dorileo --- block/iscsi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index b490e98..85252e7 10064

[Qemu-devel] [PATCH 14/26] raw-posix: migrate raw-posix driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on raw-posix block driver. Signed-off-by: Leandro Dorileo --- block/raw-posix.c | 50 +++--- 1 file changed, 23 insertions(+), 27 deletions(-) diff --git a/block/raw-posix.c b/block/raw-po

[Qemu-devel] [PATCH 13/26] qed: migrate qed driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on qed block driver. Signed-off-by: Leandro Dorileo --- block/qed.c | 79 +++-- 1 file changed, 35 insertions(+), 44 deletions(-) diff --git a/block/qed.c b/block/qed.c index 3

[Qemu-devel] [PATCH 07/26] cow: migrate cow driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on cow block driver. Signed-off-by: Leandro Dorileo --- block/cow.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/block/cow.c b/block/cow.c index 30deb88..811f7f7 1

[Qemu-devel] [PATCH 08/26] gluster: migrate gluster driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on gluster block driver. Signed-off-by: Leandro Dorileo --- block/gluster.c | 68 +++-- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/block/gluster.c b/block/glust

[Qemu-devel] [PATCH 05/26] QemuOpt: add qemu_opt_print_help()

2014-03-20 Thread Leandro Dorileo
Analogous to print_option_help(QEMUOptionParameter *list) this function displays the available key and help for each described QemuOptDesc in QemuOptList. Signed-off-by: Leandro Dorileo --- include/qemu/option.h | 1 + util/qemu-option.c| 12 2 files changed, 13 insertions(+)

[Qemu-devel] [PATCH 25/26] QemuOpt: get rid of QEMUOptionParameter

2014-03-20 Thread Leandro Dorileo
Finally remove all the remaining QEMUOptionParameter bits. Signed-off-by: Leandro Dorileo --- include/qemu/option.h | 40 --- util/qemu-option.c| 296 -- 2 files changed, 336 deletions(-) diff --git a/include/qemu/option.h b/include/qemu/

[Qemu-devel] [PATCH 23/26] vpc: migrate vpc driver QemuOptionParameter usage

2014-03-20 Thread Leandro Dorileo
Do the directly migration from QemuOptionParameter to QemuOpts on vpc block driver. Signed-off-by: Leandro Dorileo --- block/vpc.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 82bf248.

[Qemu-devel] [PATCH 03/26] QemuOpt: improve default value

2014-03-20 Thread Leandro Dorileo
Use a pointer to a structure holding the primitive types and avoid parsing the default value representation. Signed-off-by: Leandro Dorileo --- include/qemu/option.h | 20 +++- util/qemu-config.c| 4 ++-- util/qemu-option.c| 45 ++-

[Qemu-devel] [PATCH 04/26] QemuOpt: introduce qemu_opts_append()

2014-03-20 Thread Leandro Dorileo
From: Chunyan Liu The qemu_opts_append() function is intended to merge to different QemuOptsList's. The resulting list must be freed by its user. Signed-off-by: Chunyan Liu Signed-off-by: Leandro Dorileo --- include/qemu/option.h | 1 + util/qemu-option.c| 69

[Qemu-devel] [PATCH 02/26] add def_value_str to QemuOptDesc

2014-03-20 Thread Leandro Dorileo
From: Chunyan Liu Add def_value_str (default value) to QemuOptDesc, to replace function of the default value in QEMUOptionParameter. And improved related functions. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- include/qemu/option.h | 3 +- util/qemu-option.c| 84 +++

Re: [Qemu-devel] [PATCH v22 00/25] replace QEMUOptionParameter with QemuOpts

2014-03-20 Thread Leandro Dorileo
Hi Chunyan, On Mon, Mar 10, 2014 at 03:31:36PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > one Qemu Option structure is kept in QEMU code. > Last night I took some time do take a deeper look at you series and the required effo

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: I've seen something like that somewhere, but I didn't quite like it. I was looking for something more elegant as I was *almost* sure this kind of solution will not pass the reviews :) But maybe I'll try this, let's see what happens, If all you'

Re: [Qemu-devel] [RFC PATCH V3 3/5] qapi script: add event support

2014-03-20 Thread Eric Blake
On 03/18/2014 11:16 PM, Wenchao Xia wrote: > qapi-event.py will parse the schema and generate qapi-event.c, then > the API in qapi-event.c can be used to handle event in qemu code. > All API have prefix "qapi_event". > > The script mainly include two parts: generate API for each event s/include/i

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Peter Maydell
On 20 March 2014 22:41, Marcel Apfelbaum wrote: > On Thu, 2014-03-20 at 22:17 +, Peter Maydell wrote: >> echo "trivial iasl source" | iasl --compile-options | iasl >> --disassemble-options | grep "error" >> >> Fill in the handwaving with actual syntax ;-) > Problem with this solution is that

Re: [Qemu-devel] [RFC PATCH V3 2/5] qapi: add event helper functions

2014-03-20 Thread Eric Blake
On 03/18/2014 11:16 PM, Wenchao Xia wrote: > This file hold some functions that do not need to be generated. s/hold/holds/ > > Signed-off-by: Wenchao Xia > --- > include/qapi/qmp-event.h | 25 > qapi/Makefile.objs |1 + > qapi/qmp-event.c | 71 >

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Laszlo Ersek
On 03/20/14 23:33, Marcel Apfelbaum wrote: > On Thu, 2014-03-20 at 23:26 +0100, Laszlo Ersek wrote: >> On 03/20/14 23:06, Marcel Apfelbaum wrote: >>> On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: > +# All known versions of iasl on

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 22:17 +, Peter Maydell wrote: > On 20 March 2014 22:06, Marcel Apfelbaum wrote: > > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: > >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: > >> > +# All known versions of iasl on BE machines are broken. > >> > +# TOD

Re: [Qemu-devel] [PATCH v4 01/10] hw/mips/cputimer: Don't start periodic timer in KVM mode

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 10:57, James Hogan ha scritto: > On 19/03/14 16:29, Paolo Bonzini wrote: >> Il 14/03/2014 13:47, James Hogan ha scritto: >>> From: Sanjay Lal >>> >>> Compare/Count timer interrupts are handled in-kernel for KVM, so don't >>> bother starting it in QEMU. >>> >>> Signed-off-by: Sanjay L

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: > Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: > > +# All known versions of iasl on BE machines are broken. > > +# TODO: add detection code once a non-broken version makes an appearance. > > +if ($iasl -h > /dev/null 2>&1) && > > + (lsc

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 23:26 +0100, Laszlo Ersek wrote: > On 03/20/14 23:06, Marcel Apfelbaum wrote: > > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: > >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: > >>> +# All known versions of iasl on BE machines are broken. > >>> +# TODO: add de

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-03-20 Thread Eric Blake
On 03/18/2014 08:38 PM, Wenchao Xia wrote: > 于 2014/3/7 2:49, Eric Blake 写道: >> On 01/02/2014 04:10 PM, Wenchao Xia wrote: >>> qapi-event.py will parse the schema and generate qapi-event.c, then >>> the API in qapi-event.c can be used to handle event in qemu code. >>> All API have prefix "qapi_even

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Laszlo Ersek
On 03/20/14 23:06, Marcel Apfelbaum wrote: > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: >>> +# All known versions of iasl on BE machines are broken. >>> +# TODO: add detection code once a non-broken version makes an appearance. >>> +

[Qemu-devel] [PATCH v4 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-03-20 Thread Beniamino Galvani
The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this by passing explicitly the timer index to the callback function. Signed-off-by: Beniamino Galvani Reviewed-by: Li Guang Reviewed-by: Peter Crosthwaite --- hw/timer/allwinner-a10-pit.c

[Qemu-devel] [PATCH v4 5/7] allwinner-a10-pit: implement prescaler and source selection

2014-03-20 Thread Beniamino Galvani
This implements the prescaler and source fields of the timer control register. The source for each timer can be selected among 4 clock inputs whose frequencies are set through model properties. Signed-off-by: Beniamino Galvani --- hw/arm/cubieboard.c | 13 ++ hw/timer/

[Qemu-devel] [PATCH v4 0/7] Allwinner A10 fixes

2014-03-20 Thread Beniamino Galvani
This series introduces some fixes and missing features found while trying to run mainline Linux kernel on emulated Allwinner A10. The changes concern interrupt handling, timer and ethernet MAC. With these applied I'm able to boot Linux 3.14-rc2 using a NFS root: https://gist.github.com/anonymous

[Qemu-devel] [PATCH v4 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-03-20 Thread Beniamino Galvani
This patch implements proper updating of the vector register which should hold, according to the A10 user manual, the vector address for the interrupt currently active on the CPU IRQ input. Interrupt priority is not implemented at the moment and thus the first pending interrupt is returned. Signe

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Peter Maydell
On 20 March 2014 22:06, Marcel Apfelbaum wrote: > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: >> > +# All known versions of iasl on BE machines are broken. >> > +# TODO: add detection code once a non-broken version makes an appearanc

Re: [Qemu-devel] hmp interface for kdump compressed format

2014-03-20 Thread Laszlo Ersek
On 03/20/14 22:18, Christian Borntraeger wrote: > On 20/03/14 21:56, Laszlo Ersek wrote: >> On 03/20/14 21:38, Christian Borntraeger wrote: >>> Qiao Nuohan, >>> >>> is there a reason why you did not implemented the HMP part for that format >>> of kdump compressed format? After all this is a patch m

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote: > Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: > > +# All known versions of iasl on BE machines are broken. > > +# TODO: add detection code once a non-broken version makes an appearance. > > +if ($iasl -h > /dev/null 2>&1) && > > + (lsc

[Qemu-devel] [PATCH v4 2/7] allwinner-a10-pic: fix behaviour of pending register

2014-03-20 Thread Beniamino Galvani
The pending register is read-only and the value returned upon a read reflects the state of irq input pins (interrupts are level triggered). This patch implements such behaviour. Signed-off-by: Beniamino Galvani Reviewed-by: Li Guang Reviewed-by: Peter Crosthwaite --- hw/intc/allwinner-a10-pic.

[Qemu-devel] [PATCH] target-i386: Remove unused data from local array

2014-03-20 Thread Stefan Weil
Signed-off-by: Stefan Weil --- This patch is based on a previous patch for the same file, see http://patchwork.ozlabs.org/patch/330708/. Regards Stefan W. target-i386/kvm.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4389

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto: +# All known versions of iasl on BE machines are broken. +# TODO: add detection code once a non-broken version makes an appearance. +if ($iasl -h > /dev/null 2>&1) && + (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then lscpu is

[Qemu-devel] [PATCH v4 6/7] allwinner-emac: set autonegotiation complete bit on link up

2014-03-20 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/net/allwinner_emac.c |4 ++-- include/hw/net/allwinner_emac.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 469f2f0..91931ac 10064

Re: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 21:16, Michael S. Tsirkin ha scritto: Seems too aggressive: can't we detect the broken iasl? E.g. won't it fail to disassemble expected AML files? Yes. Also, won't this broken iasl generate corrupt AML on output? If yes we should detect this at configure time instead? No, the

[Qemu-devel] [PATCH v4 7/7] allwinner-emac: update irq status after writes to interrupt registers

2014-03-20 Thread Beniamino Galvani
The irq line status must be updated after writes to the INT_CTL and INT_STA registers. Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/net/allwinner_emac.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 919

Re: [Qemu-devel] [PATCH] target-i386: Remove unused data from local array

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 22:30, Stefan Weil ha scritto: Signed-off-by: Stefan Weil --- This patch is based on a previous patch for the same file, see http://patchwork.ozlabs.org/patch/330708/. Regards Stefan W. target-i386/kvm.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t

Re: [Qemu-devel] hmp interface for kdump compressed format

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 22:28, Laszlo Ersek ha scritto: On 03/20/14 22:18, Christian Borntraeger wrote: On 20/03/14 21:56, Laszlo Ersek wrote: On 03/20/14 21:38, Christian Borntraeger wrote: Qiao Nuohan, is there a reason why you did not implemented the HMP part for that format of kdump compressed form

[Qemu-devel] [PATCH v4 4/7] allwinner-a10-pit: use level triggered interrupts

2014-03-20 Thread Beniamino Galvani
Convert the interrupt generation logic to the use of level triggered interrupts. Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/timer/allwinner-a10-pit.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/timer/allwinner-a10-pit.c b/

Re: [Qemu-devel] hmp interface for kdump compressed format

2014-03-20 Thread Christian Borntraeger
On 20/03/14 21:56, Laszlo Ersek wrote: > On 03/20/14 21:38, Christian Borntraeger wrote: >> Qiao Nuohan, >> >> is there a reason why you did not implemented the HMP part for that format >> of kdump compressed format? After all this is a patch mostly for developers, >> so a HMP interface might come

[Qemu-devel] [PATCH 1/1 V2] target-ppc: Adding Functionality to rtas_ibm_get_system_parameter.

2014-03-20 Thread Tomo Berry
This patch adds the functionality for rtas_ibm_get_system_parameter to return a string containing the values for partition_max_entitled_capacity and system_potential_processors. Signed-off-by: Tomo Berry --- V1->V2: changed memory allocation to glib calls I'm not sure if this is meant for 2.1 or

[Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. Do not run iasl on those machines until this problem is solved by the acpica community. Signed-off-by: Marcel Apfelbaum --- V2 -> V3:

Re: [Qemu-devel] hmp interface for kdump compressed format

2014-03-20 Thread Laszlo Ersek
Two additional points: On 03/20/14 21:56, Laszlo Ersek wrote: > On 03/20/14 21:38, Christian Borntraeger wrote: >> Qiao Nuohan, >> >> is there a reason why you did not implemented the HMP part for that format >> of kdump compressed format? After all this is a patch mostly for developers, >> so a H

Re: [Qemu-devel] hmp interface for kdump compressed format

2014-03-20 Thread Laszlo Ersek
On 03/20/14 21:38, Christian Borntraeger wrote: > Qiao Nuohan, > > is there a reason why you did not implemented the HMP part for that format > of kdump compressed format? After all this is a patch mostly for developers, > so a HMP interface might come handy. Do you already have some patch in > p

Re: [Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling

2014-03-20 Thread Eric Blake
On 03/20/2014 07:07 AM, Amos Kong wrote: > We want to establish a mapping between option name and option table, > then we can search related option table by option name. > > This patch makes all the member name of QemuOptsList to match with > actual command-line spelling(option name). > > [ Impor

[Qemu-devel] hmp interface for kdump compressed format

2014-03-20 Thread Christian Borntraeger
Qiao Nuohan, is there a reason why you did not implemented the HMP part for that format of kdump compressed format? After all this is a patch mostly for developers, so a HMP interface might come handy. Do you already have some patch in preparation or know somebody doing it? Thanks a lot Christi

Re: [Qemu-devel] [PATCH for-2.0] hw/i386: fix acpi tables generation for big endian machines

2014-03-20 Thread Michael S. Tsirkin
On Thu, Mar 20, 2014 at 06:40:50PM +0200, Marcel Apfelbaum wrote: > The acpi tables are not corrected loaded into guest's memory > for big-endian hosts because of a linker-loader field > swapped incorrectly. Fixed that. > > Signed-off-by: Marcel Apfelbaum Applied, thanks! > --- > Note that the

Re: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Michael S. Tsirkin
On Thu, Mar 20, 2014 at 08:40:08PM +0200, Marcel Apfelbaum wrote: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > Do not run iasl on those machines until this > problem is sol

Re: [Qemu-devel] [PATCH v3 06/10] XBZRLE: rebuild the cache_is_cached function

2014-03-20 Thread Eric Blake
On 03/20/2014 01:44 PM, Eric Blake wrote: > On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: >> From: ChenLiang >> >> Rebuild the cache_is_cached function by cache_get_by_addr. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei >> --- >> page_cache.c | 38 ---

Re: [Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and fix two corruption issues

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > V2-->V3 > * rename the bitmap_sync_cnt to bitmap_sync_counter > * expose xbzrle cache miss rate > > V1-->V2 > * expose the counter that logs the times of updating the dirty bitmap to end > user. > > a. Optimization th

Re: [Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > update the doc of XBZRLE Having the subject line and the body of the commit message be identical is redundant. And just by looking at the commit message, I can't see WHY you are updating things. If you were to keep th

Re: [Qemu-devel] [PATCH v3 06/10] XBZRLE: rebuild the cache_is_cached function

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > Rebuild the cache_is_cached function by cache_get_by_addr. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > page_cache.c | 38 -- > 1 file changed, 16 insertions(+), 2

Re: [Qemu-devel] [PATCH v3 05/10] XBZRLE: optimize XBZRLE to decrease the cache missing

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang In the subject: s/missing/misses/ > > Avoid hot pages being replaced by others to remarkably decrease cache s/cache/cache misses/ > > before this patch: > virsh qemu-monitor-command test_vm '{"execute": "query-migrate"}

Re: [Qemu-devel] [PATCH v3 04/10] migration: expose xbzrle cache miss rate

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > expose xbzrle cache miss rate > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 18 ++ > hmp.c | 2 ++ > include/migration/migratio

Re: [Qemu-devel] [PATCH v3 02/10] migration: Add counters of updating the dirty bitmap

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > Add counters to log the times of updating the dirty bitmap. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake -- Eric B

Re: [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user

2014-03-20 Thread Eric Blake
On 03/18/2014 06:24 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > expose the counter that log the times of updating the dirty bitmap to s/log/logs/ > end user. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 1 + > hmp.c

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-03-20 Thread Michael Roth
Quoting Markus Armbruster (2014-03-18 04:32:08) > Peter Maydell writes: > > > This is something clang's -fsanitize=undefined spotted. The > > code generated by qapi-commands.py in qmp-marshal.c for > > qmp_marshal_* functions where there are some optional > > arguments looks like this: > > > >

Re: [Qemu-devel] [PATCH v4 20/21] target-arm: Add Cortex-A57 processor

2014-03-20 Thread Peter Maydell
On 6 March 2014 19:33, Peter Maydell wrote: > Add Cortex-A57 processor. > > Signed-off-by: Peter Maydell > +static void aarch64_a57_initfn(Object *obj) > +{ > +ARMCPU *cpu = ARM_CPU(obj); > + > +set_feature(&cpu->env, ARM_FEATURE_V8); > +set_feature(&cpu->env, ARM_FEATURE_VFP4); > +

Re: [Qemu-devel] [PULL for 2.0 0/5] MinGW related patches

2014-03-20 Thread Peter Maydell
On 20 March 2014 19:12, Stefan Weil wrote: > Unfortunately a recent commit added new code in util/, and that code > needs a modification of patch 5/5. I really should have re-run the > compile test :-( > > Peter, is it possible to pull only patches 1-4? They compile and are > fine, and we'd save m

Re: [Qemu-devel] [PULL for 2.0 0/5] MinGW related patches

2014-03-20 Thread Stefan Weil
Am 20.03.2014 13:45, schrieb Peter Maydell: > On 20 March 2014 06:29, Stefan Weil wrote: >> Am 20.03.2014 07:25, schrieb Stefan Weil: >>> This includes a patch for GTK (needed for MinGW, but not restricted to it) >>> and most of the patches which restructure the includes for the Win API. >>> I omm

Re: [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
On Thu, 2014-03-20 at 19:00 +, Peter Maydell wrote: > On 20 March 2014 17:47, Marcel Apfelbaum wrote: > > There is an issue with iasl on big endian machines: It > > cannot disassemble acpi tables taken from little endian > > machines, so we cannot check the expected tables. > > > > Do not run

Re: [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Peter Maydell
On 20 March 2014 17:47, Marcel Apfelbaum wrote: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > Do not run iasl on those machines until this > problem is solved by the acpica

[Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. Do not run iasl on those machines until this problem is solved by the acpica community. Signed-off-by: Marcel Apfelbaum --- V1 -> V2:

Re: [Qemu-devel] [PATCH v4 10/21] target-arm: Add v8 mmu translation support

2014-03-20 Thread Peter Maydell
On 6 March 2014 19:32, Peter Maydell wrote: > @@ -1065,8 +1065,9 @@ static void par_write(CPUARMState *env, const > ARMCPRegInfo *ri, uint64_t value) > */ > static inline bool extended_addresses_enabled(CPUARMState *env) > { > -return arm_feature(env, ARM_FEATURE_LPAE) > -&& (env-

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 17:20, Igor Mammedov ha scritto: > > What about just looking up on the QOM tree until you find a > HotplugHandler, if the device doesn't have a bus or the bus doesn't have > a hotplug handler link itself? This is similar to how FWPathProvider works. it does so "hotplug_handler_get

Re: [Qemu-devel] [PATCH v3 06/10] XBZRLE: rebuild the cache_is_cached function

2014-03-20 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: ChenLiang > > Rebuild the cache_is_cached function by cache_get_by_addr. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- Reviewed-by: Dr. David Alan Gilbert > page_cache.c | 38 --

[Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines

2014-03-20 Thread Marcel Apfelbaum
There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. Do not run iasl on those machines until this problem is solved by the acpica community. Signed-off-by: Marcel Apfelbaum --- tests/acpi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 17:58, BALATON Zoltan ha scritto: Classes (or anything guest-visible in fact) must never ever be changed for the same machine type. It's a rule. The class did not change only the prog interface field after it (which is guest visible but I think most guests just ignore it). So th

Re: [Qemu-devel] Windows XP Setup hangs on Fedora FC20 install

2014-03-20 Thread Cole Robinson
On 03/20/2014 02:35 AM, Gerhard Wiesinger wrote: > On 17.03.2014 13:31, Cole Robinson wrote: >> Works fine here but I'm using AMD. Please file a Fedora bug against qemu, and >> include: >> >> - full qemu command line (if using libvirt: >> /var/log/libvirt/qemu/$vmname.log) >> - Any qemu stdout/std

Re: [Qemu-devel] [PATCH v4 16/21] target-arm: Implement SP_EL0, SP_EL1

2014-03-20 Thread Peter Maydell
On 17 March 2014 07:02, Peter Crosthwaite wrote: > On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell > wrote: >> Implement handling for the AArch64 SP_EL0 system register. >> This holds the EL0 stack pointer, and is only accessible when >> it's not being used as the stack pointer, ie when we're in E

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread BALATON Zoltan
On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 17:01, BALATON Zoltan ha scritto: On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -tr

[Qemu-devel] [PATCH for-2.0] hw/i386: fix acpi tables generation for big endian machines

2014-03-20 Thread Marcel Apfelbaum
The acpi tables are not corrected loaded into guest's memory for big-endian hosts because of a linker-loader field swapped incorrectly. Fixed that. Signed-off-by: Marcel Apfelbaum --- Note that the acpi test still fails because of an iasl issue, I will send a patch separately that disables disass

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix return check for KVM_GET_DIRTY_LOG ioctl

2014-03-20 Thread Mario Smarduch
I agree. One thing I forgot to mention andother side effect of this bug was virtio VRing used, avail index error the Guest was 1,2,.. less then host. I looked up that bug it happend on some architectures. This may or may not be related. Obviously if the dirty bitmap is not processed properly y

Re: [Qemu-devel] [PATCH 4/5] sclp-s390: Define new SCLP codes and structures

2014-03-20 Thread Christian Borntraeger
On 20/03/14 17:33, Matthew Rosato wrote: > > Hi Christian -- You already accepted this patch into s390-next with > these changes as 234eef51a12e2f0f8dfd71cb49d2469d462b1855. Or am I > missing something else you wanted changed? Gnarf. Yes I wanted to start review and took the wrong version :-(

Re: [Qemu-devel] [PATCH 4/5] sclp-s390: Define new SCLP codes and structures

2014-03-20 Thread Matthew Rosato
On 03/20/2014 05:56 AM, Christian Borntraeger wrote: > On 16/12/13 21:51, Matthew Rosato wrote: >> Define new SCLP codes and structures that will be needed for s390 memory >> hotplug. >> >> Signed-off-by: Matthew Rosato >> --- >> hw/s390x/sclp.c |2 +- >> include/hw/s390x/sclp.h | 4

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 17:01, BALATON Zoltan ha scritto: On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be

[Qemu-devel] Outreach Program for Women application deadline extended

2014-03-20 Thread Stefan Hajnoczi
Good news! The deadline for Outreach Program for Women applications to work on QEMU, KVM, or libvirt for 12 weeks this summer has been extended to March 31st 19:00 UTC: https://wiki.gnome.org/OutreachProgramForWomen/2014/MayAugust#Participating_Organizations Outreach Program for Women was started

Re: [Qemu-devel] Want to discuss about Outreach Program for Women

2014-03-20 Thread Stefan Hajnoczi
On Thu, Mar 20, 2014 at 9:33 AM, Stefan Hajnoczi wrote: > On Wed, Mar 19, 2014 at 08:34:08PM +0530, preeti soni wrote: >> I want to discuss about project in which I am interested. Can you please >> give me How I can do this. As early as possible. > > The application deadline was 19:00 UTC on 19th

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

2014-03-20 Thread Michael Tokarev
06.03.2014 13:39, Igor Mammedov wrote: > Igor Mammedov (1): > vl: convert -m to QemuOpts This patch (2/2) was mime-damaged, I had to edit it manually in order for it to apply. Please take a look at http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next to verify it's okay

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-20 Thread Igor Mammedov
On Thu, 20 Mar 2014 17:12:17 +0100 Paolo Bonzini wrote: > Il 20/03/2014 16:01, Igor Mammedov ha scritto: > > +/* > > + * Returns path to link<> that should be set/unset on dev hotplug. > > + * Used for link based bussless devices hotplug. > > + */ > > +char* (*hotplug_path)(De

  1   2   >