Il 08/03/2014 19:47, Leandro Dorileo ha scritto:
Remove the arg parsing implementations using getopt and use qemu-arg.
Also remove the qemu-img-cmds.hx since it's now generated on building time,
adapted the build system to generate the .hx file using the qemu-img itself
using the qemu-arg interna
Reviewed-by: Alex Bennée
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
configure | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configure b/configure
index 8689435..af44b6a 100755
--- a/configure
+++ b/configure
@@ -4968,6 +4968,12 @@ for i in $ARCH $TARGET_BASE_A
At first glance the code appears to be using 1's compliment encoding,
a-la AArch32. Except that the constant is "off", creating a complicated
split field 2's compliment encoding.
Much clearer to just use a normal mask and shift.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
As opposed to tcg_target_long.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 49 +---
1 file changed, 21 insertions(+), 28 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
in
It was unused. Let's not overcomplicate things before we need them.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
ind
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index e3f55de..8f68450 100644
--- a/tcg/aarch64/tcg-target.c
++
This reduces the code size of the function significantly.
Reviewed-by: Alex Bennée
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 95 +---
1 file changed, 50 insertions(+), 45 deletions(-)
diff --git a/t
Reviewed-by: Alex Bennée
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 857f588..e3f55de 100644
Commit 023261ef851b22a04f6c5d76da870051031757a6 failed to remove a
nop that's no longer required.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-targe
We assert that the values for _I32 and _I64 are 0 and 1 respectively.
This will make a couple of functions declared by tcg.c cleaner.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 64
1 file changed,
Removed from other targets in 56bbc2f967ce185fa1c5c39e1aeb5b68b26242e9.
Reviewed-by: Alex Bennée
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target
Recently reviewed. Part 2 to be posted shortly.
r~
The following changes since commit f53f3d0a00b6df39ce8dfca942608e5b6a9a4f71:
Merge remote-tracking branch 'remotes/kvaneesh/for-upstream' into staging
(2014-03-08 12:38:43 +)
are available in the git repository at:
git://github.co
This patch removes smbios_add_field() and the old code to insert
individual fields for types 0 and 1 into fw_cfg.
Signed-off-by: Gabriel Somlo
---
hw/i386/smbios.c | 80
1 file changed, 80 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i
If defaults are set by piix or q35, or fields are given on the
command line, build full smbios tables for types 0 and 1 instead
of sending individual fields to the BIOS via fw_cfg.
Signed-off-by: Gabriel Somlo
---
hw/i386/smbios.c | 63
1
This patch adds a set of macros which build full smbios tables
of a given type, including the logic to decide whether a given
table type should be built or not.
To illustrate this new functionality, we introduce and optionally
build a table of type 2 (base board), which is required by some
version
Replace existing smbios_check_collision() functionality with
a pair of bitmaps: have_binfile_bitmap and have_fields_bitmap.
Bits corresponding to each smbios type are set by smbios_entry_add(),
which also uses the bitmaps to ensure that binary blobs and field
values are never accepted for the same
The function smbios_set_defaults() uses a repeating code pattern
for each field. This patch replaces that pattern with a macro.
Signed-off-by: Gabriel Somlo
---
hw/i386/smbios.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbio
Subsequent patches will utilize this function to set defaults for
more smbios types than just type 1, so the function name should
reflect this.
Signed-off-by: Gabriel Somlo
---
hw/i386/pc_piix.c| 12 ++--
hw/i386/pc_q35.c | 8
hw/i386/smbios.c | 4 ++--
Table definitions for types 4 and 17 are only up to v2.0,
so add fields specified in smbios v2.3, as expected (and
advertised) by the SeaBIOS smbios entry point structure.
Signed-off-by: Gabriel Somlo
---
include/hw/i386/smbios.h | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(
On Thu, Mar 06, 2014 at 06:04:32PM +0100, Laszlo Ersek wrote:
> > What really convinced me to go for all this additional work was
> > Laszlo's suggestion that this might help if/when we try to start
> > trying to use UEFI/tianocore/ovmf instead of SeaBIOS.
>
> Let me be a bit more precise... :)
>
Gerd,
After the latest pull, my sdl mouse no longer works. I've tried with
both OS X and Fedora 20 live. The latter (easier command line with
no out of tree dependencies) is started with the following command line:
bin/qemu-system-x86_64 -enable-kvm -m 2048 -machine q35 \
-usb -device usb-kbd
Hello,
I've noticed that mouse wheel stopped working for me recently with the
VMWare mouse driver. Bisecting gave this:
3ab193e66262e60e0ff74ac1ab5cff04412e83cb is the first bad commit
commit 3ab193e66262e60e0ff74ac1ab5cff04412e83cb
Author: Gerd Hoffmann
Date: Thu Nov 28 12:27:40 2013 +0100
From: Alexey Kardashevskiy
This adds @idstr to savevm_section_start and savevm_section_end
tracepoints.
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Amit Shah
Signed-off-by: Juan Quintela
---
savevm.c | 12 ++--
trace-events | 4 ++--
2 files changed, 8 insertions(+), 8 de
From: Alexey Kardashevskiy
It might be useful for tracing migration.
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Amit Shah
Signed-off-by: Juan Quintela
---
trace-events | 1 +
vl.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/trace-events b/trace-events
index aec4202
From: Gonglei
Resizing the xbzrle cache during migration causes qemu-crash,
because the main-thread and migration-thread modify the xbzrle
cache size concurrently without lock-protection.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Q
From: Markus Armbruster
Reviewers accepted v2 of the patch, but what got committed was v1,
with the R-bys for v2. This is the v1->v2 followup fix.
[Amit:
This fixes commit aded6539d983280212e08d09f14157b1cb4d58cc
]
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Amit S
The following changes since commit f53f3d0a00b6df39ce8dfca942608e5b6a9a4f71:
Merge remote-tracking branch 'remotes/kvaneesh/for-upstream' into staging
(2014-03-08 12:38:43 +)
are available in the git repository at:
git://github.com/juanquintela/qemu.git tags/migration/20140
On 04/03/14 20:32, Andreas Färber wrote:
Am 04.03.2014 03:55, schrieb Andreas Färber:
Hello,
Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by
Peter's wish for ARMCPU properties, this series sets out to align cpu_model
parsing across targets.
QemuOpts would've been n
On 8 March 2014 20:16, Mark Cave-Ayland wrote:
> [0.00] TRAPLOG: TPC<(null)>
> [0.00] \|/ \|/
> [0.00] "@'/ .. \`@"
> [0.00] /_| \__/ |_\
> [0.00] \__U_/
> [0.00] swapper(0): TL1: FPU IE
Hi Peter,
On Sat, Mar 08, 2014 at 06:55:50PM +, Peter Maydell wrote:
> On 8 March 2014 18:47, Leandro Dorileo wrote:
> > The following patchset introduces a general purpose argument parser and
> > migrates
> > qemu-img to make use of it. qemu-img is just the first user of it, if we
> > see
On 14/02/14 16:06, Sebastian Huber wrote:
The LEON3 processor has support for the CASA instruction which is
normally only available for SPARC V9 processors. Binutils 2.24
and GCC 4.9 will support this instruction for LEON3. GCC uses it to
generate C11 atomic operations.
The CAS synthetic inst
On 8 March 2014 18:47, Leandro Dorileo wrote:
> The following patchset introduces a general purpose argument parser and
> migrates
> qemu-img to make use of it. qemu-img is just the first user of it, if we see a
> good feedback here I move forward and migrate all the other possible users.
Can yo
qemu-arg defines a standardized API for argument parsing, help displaying and
texi generation/sync.
The implementation supports command + arguments form (i.e qemu-img requirements)
and a more general simple arguments parsing. So we can parse:
$ prog --arg1 --arg2
$ prog --arg1 --arg2
We support
The following patchset introduces a general purpose argument parser and migrates
qemu-img to make use of it. qemu-img is just the first user of it, if we see a
good feedback here I move forward and migrate all the other possible users.
Leandro Dorileo (2):
qemu-arg: introduce a general purpose a
** Tags added: 2000 4.0 adlib bug es1370 midi nt serious win200 windows
winvista winxp
** Description changed:
Windows NT 4.0 and 2000 (including the latest git release), when enabling
adlib (with sb16 already enabled) or the built-in synth of the es1370, hang on
QEMU 1.7.x (also with 1.7.50)
The ret variable is freed twice, but on the second time we actually want
to free ret3 instead. Don't know why this didn't explode.
Reported-by: Peter Maydell
Tested-by: Peter Maydell
Signed-off-by: Luiz Capitulino
---
tests/test-qmp-commands.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 8 March 2014 16:09, Luiz Capitulino wrote:
> On Sat, 8 Mar 2014 14:40:27 +
> Peter Maydell wrote:
>
>> The test-qmp-commands test binary seems to read from freed
>> memory. This triggers the MacOSX malloc implementation's
>> assertions. git bisect blames
>
> Can you try the patch below? Fo
On Sat, 8 Mar 2014 14:40:27 +
Peter Maydell wrote:
> The test-qmp-commands test binary seems to read from freed
> memory. This triggers the MacOSX malloc implementation's
> assertions. git bisect blames
Can you try the patch below? For the clang ones, I'll have to install it etc,
so it will
On Thu, Jan 30, 2014 at 7:23 PM, Neil Skrypuch wrote:
> As mentioned above I can reproduce this with minimal effort, and am willing to
> test out any patches or provide further details as necessary.
Hi Neil,
Thanks for all your efforts on IRC. I have sent a fix titled "[PATCH]
tap: avoid deadloc
The net subsystem has a control flow mechanism so peer NetClientStates
can tell each other to stop sending packets. This is used to stop
monitoring the tap file descriptor for incoming packets if the guest rx
ring has no spare buffers.
There is a corner case when tap_can_send() is true at the beg
Public bug reported:
Windows NT 4.0 and 2000 (including the latest git release), when enabling adlib
(with sb16 already enabled) or the built-in synth of the es1370, hang on QEMU
1.7.x (also with 1.7.50) when they try to play MIDI files (like canyon.mid,
etc). I have already tried bisecting but
The test-qmp-commands test binary seems to read from freed
memory. This triggers the MacOSX malloc implementation's
assertions. git bisect blames
commit c2216a8a7a587e594f50bebbdf81fcf168444b68
Author: Markus Armbruster
Date: Sat Mar 1 08:40:29 2014 +0100
tests/qapi-schema: Cover simple ar
On 8 March 2014 12:39, Peter Maydell wrote:
> I've noticed that the tests/test-qapi-visit.c code provokes the following
> complaint from clang's -fsanitize=undefined undefined-behaviour
> checker when you run 'make check':
>
> tests/test-qapi-visit.c:462:33: runtime error: member access within
> n
OK, thanks.
Next, I will/should continue to analyse the performance issue for 9pfs
when users drop into a long directory path under bash shell.
Although I am not quite sure, hope I can find the root cause within this
month (2014-03-31).
Welcome any suggestions, discussions, and completions for i
On 03/07/2014 08:43 PM, Paolo Bonzini wrote:
> Il 07/03/2014 10:37, Mark Wu ha scritto:
>> Before spapr_vga_init will returned false if the vga is specified by
>> the command '-device VGA' because vga_interface_type was evaluated to
>> VGA_NONE. With the change in previous patch of this series,
>>
On 8 March 2014 01:23, Juan Quintela wrote:
> Hi
>
> Please pull
>
> - Fix missmerge of fwrite patch (armbru)
> - FIX XBZRLE crash: Gonglei
> - Add more traces for migration (Alexey)
>
> Especial thanks to Amit for getting the patches together.
I'm afraid this doesn't build for Windows:
/home/pe
On 7 March 2014 15:16, Aneesh Kumar K.V wrote:
> Hi,
>
> Please pull the below update for VirtFS
>
>
> The following changes since commit d5001cf787ad0514839a81d0f2e771e01e076e21:
>
> xilinx: Delete hw/include/xilinx.h (2014-02-26 14:54:45 +1000)
>
> are available in the git repository at:
>
>
Peter Maydell wrote:
> On 6 March 2014 20:03, Amit Shah wrote:
>> Hi Juan,
>>
>> Here's a compilation of migration-related patches from the list that
>> I've reviewed.
>>
>> For the first patch, I picked Markus's over yours, just because it's
>> been on the list longer.
>>
>>
>> The following cha
On 7 March 2014 13:32, Kevin Wolf wrote:
> The following changes since commit f55ea6297cc0224fe4934b90ff5343b620b14669:
>
> block/gluster: Add missing argument to qemu_gluster_init() call (2014-03-04
> 20:20:57 +)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/kevin
I've noticed that the tests/test-qapi-visit.c code provokes the following
complaint from clang's -fsanitize=undefined undefined-behaviour
checker when you run 'make check':
tests/test-qapi-visit.c:462:33: runtime error: member access within
null pointer of type 'UserDefA' (aka 'struct UserDefA')
On 6 March 2014 20:03, Amit Shah wrote:
> Hi Juan,
>
> Here's a compilation of migration-related patches from the list that
> I've reviewed.
>
> For the first patch, I picked Markus's over yours, just because it's
> been on the list longer.
>
>
> The following changes since commit 9fbee91a131a05e4
On 20 January 2014 11:21, Lluís Vilanova wrote:
> Pass all the relevant sub-directory make variables.
>
> Signed-off-by: Lluís Vilanova
> ---
> Makefile |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master as a build fix of sorts.
thanks
-- PMM
On 7 March 2014 21:42, Andreas Färber wrote:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
>
> Cc: Gerd Hoffmann
> Signed-of
53 matches
Mail list logo
