Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-03-05 Thread Michael S. Tsirkin
On Sat, Mar 01, 2014 at 07:17:07PM -0500, Gabriel L. Somlo wrote: > On Sat, Mar 01, 2014 at 03:46:22PM +0100, Paolo Bonzini wrote: > > Il 28/02/2014 20:14, Gabriel L. Somlo ha scritto: > > >Some guests (e.g. 0S X) insist on a minimum lapic version of 0x14. > > >This patch bumps the emulated lapic v

Re: [Qemu-devel] [RFC PATCH v2] qemu: x86: ignore ioapic polarity

2014-03-05 Thread Michael S. Tsirkin
On Fri, Feb 28, 2014 at 01:57:19PM -0500, Gabriel L. Somlo wrote: > Both QEMU and KVM have already accumulated a significant number of > optimizations based on the hard-coded assumption that ioapic polarity > will always use the ActiveHigh convention, where the logical and > physical states of leve

Re: [Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected

2014-03-05 Thread Michael S. Tsirkin
On Tue, Mar 04, 2014 at 06:38:52PM -0600, miny...@acm.org wrote: > From: Corey Minyard > > Allow a socket that connects to reconnect on a periodic basis if it > fails to connect at startup or if the connection drops while in use. > > Signed-off-by: Corey Minyard > --- > include/sysemu/char.h |

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
> -Original Message- > From: Alexey Kardashevskiy [mailto:a...@ozlabs.ru] > Sent: Thursday, March 06, 2014 3:08 PM > To: Yin Olivia-R63875; Paolo Bonzini; da...@gibson.dropbear.id.au; > ag...@suse.de > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Li Zhang > Subject: Re: QEMU: PCI bus nam

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Alexey Kardashevskiy
On 03/06/2014 06:04 PM, hong-hua@freescale.com wrote: > Hi Alexey, > > Even though you change the default PCI bus naming, it will need detect > the QEMU version in libvirt to keep compatibility with old QEMU version. So? > Best Regards, > Olivia > >> -Original Message- >> From:

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
Hi Alexey, Even though you change the default PCI bus naming, it will need detect the QEMU version in libvirt to keep compatibility with old QEMU version. Best Regards, Olivia > -Original Message- > From: Alexey Kardashevskiy [mailto:a...@ozlabs.ru] > Sent: Wednesday, March 05, 2014 11

Re: [Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected

2014-03-05 Thread Weidong Huang
On 2014/3/5 8:38, miny...@acm.org wrote: > From: Corey Minyard > > Allow a socket that connects to reconnect on a periodic basis if it > fails to connect at startup or if the connection drops while in use. > > Signed-off-by: Corey Minyard > --- > include/sysemu/char.h | 16 - > qemu-char

[Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-05 Thread Alexey Kardashevskiy
This adds migration support for OHCI. Signed-off-by: Alexey Kardashevskiy --- hw/usb/hcd-ohci.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index e38cdeb..c42e091 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -1984,6 +1984,1

[Qemu-devel] [Bug 1261265] Re: win7 guest boot up fail.

2014-03-05 Thread chao zhou
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1261265 Title: win7 guest boot up fail. Status in QEMU: Fix Released Bug description: Envi

[Qemu-devel] [Bug 1261265] Re: win7 guest boot up fail.

2014-03-05 Thread chao zhou
kvm.git + qemu.git: d3714010 + d844a7b6 after create win7 guest, the guest boots up fine -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1261265 Title: win7 guest boot up fail. Status in QEMU: New

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-05 Thread Aneesh Kumar K.V
Andreas Färber writes: > Am 04.03.2014 00:36, schrieb Serge E. Hallyn: >> Quoting Aneesh Kumar K.V (aneesh.ku...@linux.vnet.ibm.com): >>> commit 01041f5df94ff19988cbadd7bd3eefcc9d964e4e >>> Author: Aneesh Kumar K.V >>> Date: Tue Mar 4 00:35:32 2014 +0530 >>> >>> hw/9pfs: Include virtio-9p-

[Qemu-devel] [PATCH 4/4] target-ppc: MSR_POW not supported on POWER7/7+/8

2014-03-05 Thread Anton Blanchard
Remove MSR_POW from the msr_mask for POWER7/7+/8. Signed-off-by: Anton Blanchard --- Index: b/target-ppc/translate_init.c === --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -7074,7 +7074,7 @@ POWERPC_FAMILY(

[Qemu-devel] [PATCH 3/4] target-ppc: POWER7+ supports the MSR_VSX bit

2014-03-05 Thread Anton Blanchard
Without MSR_VSX we die early during a Linux boot. Signed-off-by: Anton Blanchard --- Index: b/target-ppc/translate_init.c === --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -7117,7 +7117,7 @@ POWERPC_FAMILY(

[Qemu-devel] [PATCH 2/4] target-ppc: POWER8 supports isel

2014-03-05 Thread Anton Blanchard
POWER8 supports isel, so enable it in QEMU. Signed-off-by: Anton Blanchard --- diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 3eafbb0..7661543 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -7156,7 +7156,7 @@ POWERPC_FAMILY(POWER8)(Ob

[Qemu-devel] [PATCH 1/4] target-ppc: POWER8 supports the MSR_LE bit

2014-03-05 Thread Anton Blanchard
Add MSR_LE to the msr_mask for POWER8. Signed-off-by: Anton Blanchard --- diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 3eafbb0..7661543 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -7173,7 +7173,7 @@ POWERPC_FAMILY(POWER8)(ObjectC

Re: [Qemu-devel] [PATCH] qemu_file: Fix mismerge of "use fwrite() correctly"

2014-03-05 Thread Amit Shah
On (Thu) 27 Feb 2014 [08:57:38], Markus Armbruster wrote: > Reviewers accepted v2 of the patch, but what got committed was v1, > with the R-bys for v2. This is the v1->v2 followup fix. > > Signed-off-by: Markus Armbruster Reviewed-by: Amit Shah This fixes commit aded6539d983280212e08d09f14157

[Qemu-devel] [PATCH] spapr: Clear LPCR_ILE during reset

2014-03-05 Thread Anton Blanchard
Since an OS can set LPCR_ILE we must clear it during reset. Otherwise if we reset into an OS with a different endian we die when we take the first exception. This fixes an issue seen on both full emulation and KVM. Signed-off-by: Anton Blanchard --- diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c

[Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming

2014-03-05 Thread Alexey Kardashevskiy
Previously libvirt required the first/default PCI bus to have name "pci". Since QEMU can support multiple buses now, libvirt wants "pci.0" now. This removes custom busname and lets QEMU make up default names. Signed-off-by: Alexey Kardashevskiy --- I tested this with: -netdev tap,id=id0,ifnam

[Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-05 Thread Amos Kong
vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be lost. We have macro in qemu-options.hx to gen

[Qemu-devel] [PATCH v4 0/2] fix query-command-line-options

2014-03-05 Thread Amos Kong
This patchset fixed some issues of query-command-line-options: * some new options that haven't argument can't be queried. (eg: -enable-fips) * some legacy options that have argument can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 V2: r

[Qemu-devel] [PATCH v4 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-05 Thread Amos Kong
Signed-off-by: Amos Kong Reviewed-by: Eric Blake --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index f610101..d2facfd 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -39,7 +39,7 @@ QemuOptsLi

Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-05 Thread Amos Kong
On Wed, Mar 05, 2014 at 11:50:22AM -0700, Eric Blake wrote: > On 03/05/2014 08:58 AM, Eric Blake wrote: > > On 03/04/2014 11:40 PM, Amos Kong wrote: > > > >>> but the docs imply that I should now see: > >>> > >>> {"parameters": [], "option": "smbios", "argument": true} > >> > >> I really got : {"p

Re: [Qemu-devel] [RFC 1/2] hw/arm/virt: add a Calxeda XGMAC device

2014-03-05 Thread Eric Auger
Hi Andreas > If the realize/init function sets up MMIO mappings and IRQs itself > (rather than expecting the code instantiating the device to do so) then > you are free to set that field to false. Thank you for the confirmation > In this case that would be vbi->memmap[VIRT_ETHERNET].base in > cr

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
Hi Alexey, I just clone qemu from git://git.qemu.org/qemu.git. commit f55ea6297cc0224fe4934b90ff5343b620b14669 $ ./configure --target-list=ppc64-softmmu --disable-sdl --disable-guest-agent --prefix="/usr/local" $ make $ ./ppc64-softmmu/qemu-system-ppc64 --version QEMU emulator version 1.7.50, Co

Re: [Qemu-devel] [PATCH 2/2] tests-ppc64: test for -device spapr-pci-host-bridge

2014-03-05 Thread Alexey Kardashevskiy
On 03/06/2014 07:42 AM, Andreas Färber wrote: > Am 14.02.2014 05:05, schrieb Alexey Kardashevskiy: >> On 02/11/2014 02:48 AM, Andreas Färber wrote: >>> Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: This adds a test if SPAPR PHB can be added via the command line. Signed-off-by: A

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-05 Thread Huangpeng (Peter)
Hi David Where can I get your post-copy git tree? I wish to take a look into it first before start live-snapshot design. Thanks. > I'm working on post-copy at the moment, using Andrea's kernel code, using bits > of Yamahata's code base as well; hopefully it won't be too long until we have > so

[Qemu-devel] [Bug 1288385] [NEW] VFIO passthrough causes assertation failure

2014-03-05 Thread bluebird
Public bug reported: Since commit 5e95494380ec I am no longer able to passthrough my Nvidia GTX 770 using VFIO. Qemu terminates with: qemu-system-x86_64: hw/pci/pcie.c:240: pcie_cap_slot_hotplug_common: Assertion `((pci_dev->devfn) & 0x07) == 0' failed. Above output was generated using commit f5

Re: [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status()

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 21:44:57 (+0100), Max Reitz wrote : > On 05.03.2014 21:41, Benoît Canet wrote: > >The Wednesday 05 Mar 2014 à 21:10:03 (+0100), Max Reitz wrote : > >>On 05.03.2014 17:11, Benoît Canet wrote: > >>>The Monday 03 Mar 2014 à 16:28:48 (+0100), Max Reitz wrote : > Implemen

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-05 Thread Anton Ivanov
On 05/03/14 21:22, Eric Blake wrote: [snip] > > udp is layer 3, ip is layer 2 - don't you mean "optional for tcp" as the > layer 3 counterpart of udp? L2TPv3 uses either udp or ip as in "raw ip" (raw sockets) using a special protocol - 0x73. So no tcp at play here. The wording is incorrect - sho

Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2.

2014-03-05 Thread Stewart Smith
Bharata B Rao writes: > PowerPC kernel expects the number of SMT threads in a core to be a power > of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel > crash if invalid threads count is specified. > > Prevent this crash and make it a graceful exit from QEMU itself by > valid

[Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field.

2014-03-05 Thread Benoît Canet
Moving only the node_name one field could lead to some inconsitencies where a node_name was defined on a bs which was not registered in the graph node list. bdrv_swap between a named node bs and a non named node bs would lead to this. bdrv_make_anon would then crash because it would try to remove

[Qemu-devel] [QEMU 2.0 FIX V2] Fix bdrv_swap behavior regarding the node graph

2014-03-05 Thread Benoît Canet
This bug was discovered while working on the quorum file replacement. The patch switch to a more sane behavior discussed with Kevin. Best regards Benoît Benoît Canet (1): block: make bdrv_swap rebuild the bs graph node list field. block.c | 24 +++- 1 file changed, 19 in

Re: [Qemu-devel] [PATCH] qjson.h: Remove GCC_FMT_ATTR markup from qobject_from_jsonv() declaration

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 22:11, Eric Blake ha scritto: On 03/05/2014 02:02 PM, Stefan Weil wrote: Commit aa830cdc28edb69c1fe81c8fd9471ab288ad0926 removed that attribute from qobject_from_json. Now gcc suggests to add it again when compiler flag -Wmissing-format-attribute is used: qobject/qjson.c: In funct

Re: [Qemu-devel] [QEMU 2.0 Fix] block: make bdrv_swap rebuild the bs graph node list field.

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 23:22:30 (+0100), Max Reitz wrote : > On 04.03.2014 17:42, Benoît Canet wrote: > >Moving only the node_name one field could lead to some inconsitencies where a > >node_name was defined on a bs which was not registered in the graph node > >list. > > > >bdrv_swap between

Re: [Qemu-devel] [QEMU 2.0 Fix] block: make bdrv_swap rebuild the bs graph node list field.

2014-03-05 Thread Max Reitz
On 04.03.2014 17:42, Benoît Canet wrote: Moving only the node_name one field could lead to some inconsitencies where a node_name was defined on a bs which was not registered in the graph node list. bdrv_swap between a named node bs and a non named node bs would lead to this. bdrv_make_anon woul

Re: [Qemu-devel] [PATCH qom-cpu 1/6] cpu: Introduce CPUClass::parse_features() hook

2014-03-05 Thread Eduardo Habkost
On Wed, Mar 05, 2014 at 05:57:10PM +0100, Igor Mammedov wrote: > On Wed, 05 Mar 2014 17:06:15 +0100 > Andreas Färber wrote: > > > Am 05.03.2014 16:04, schrieb Igor Mammedov: > > > On Tue, 4 Mar 2014 03:55:44 +0100 > > > Andreas Färber wrote: > > > > > >> Adapt the X86CPU implementation to suit

Re: [Qemu-devel] [PATCH] qjson.h: Remove GCC_FMT_ATTR markup from qobject_from_jsonv() declaration

2014-03-05 Thread Eric Blake
On 03/05/2014 02:02 PM, Stefan Weil wrote: > Commit aa830cdc28edb69c1fe81c8fd9471ab288ad0926 removed that attribute > from qobject_from_json. Now gcc suggests to add it again when compiler > flag -Wmissing-format-attribute is used: > > qobject/qjson.c: In function ‘qobject_from_json’: > qobject/qj

Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames

2014-03-05 Thread Eric Blake
On 03/05/2014 02:41 PM, Max Reitz wrote: > The "file" protocol drivers (block/raw-posix and block/raw-win32) may be > explicitly selected by prepending a "file:" prefix to a filename (as > with all other block protocols). However, currently, they do not strip > this prefix as they should. > > This

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-05 Thread Hervé Poussineau
Le 05/03/2014 09:15, Paolo Bonzini a écrit : Il 05/03/2014 00:49, Michael S. Tsirkin ha scritto: On Mon, Mar 03, 2014 at 11:05:17PM +0100, Hervé Poussineau wrote: Ping. QEMU crash at reboot is due to not resetting PAM registers at i440fx reset, but a patch has already been rejected on ML: http

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-05 Thread Hervé Poussineau
Le mer. 05 mars 2014 19:50:04 CET, Andreas Färber a écrit : Am 05.03.2014 00:49, schrieb Michael S. Tsirkin: On Mon, Mar 03, 2014 at 11:05:17PM +0100, Hervé Poussineau wrote: Ping. QEMU crash at reboot is due to not resetting PAM registers at i440fx reset, but a patch has already been rejected

[Qemu-devel] [PATCH 5/5] block/raw-win32: Strip "file:" prefix on creation

2014-03-05 Thread Max Reitz
The bdrv_create() implementation of the block/raw-win32 "file" protocol driver should strip the "file:" prefix from filenames if present. Signed-off-by: Max Reitz --- block/raw-win32.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/raw-win32.c b/block/raw-win32.c index 0755434..9954

[Qemu-devel] [PATCH 4/5] block/raw-win32: Implement bdrv_parse_filename()

2014-03-05 Thread Max Reitz
The "file" protocol driver should strip the "file:" prefix from filenames if present. Signed-off-by: Max Reitz --- block/raw-win32.c | 12 1 file changed, 12 insertions(+) diff --git a/block/raw-win32.c b/block/raw-win32.c index ae1c8e6..0755434 100644 --- a/block/raw-win32.c +++ b

[Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames

2014-03-05 Thread Max Reitz
The "file" protocol drivers (block/raw-posix and block/raw-win32) may be explicitly selected by prepending a "file:" prefix to a filename (as with all other block protocols). However, currently, they do not strip this prefix as they should. This series fixes this issue. Max Reitz (5): block: K

[Qemu-devel] [PATCH 2/5] block/raw-posix: Implement bdrv_parse_filename()

2014-03-05 Thread Max Reitz
The "file" protocol driver should strip the "file:" prefix from filenames if present. Signed-off-by: Max Reitz --- block/raw-posix.c | 12 1 file changed, 12 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 161ea14..892145c 100644 --- a/block/raw-posix.c +++ b

[Qemu-devel] [PATCH 3/5] block/raw-posix: Strip "file:" prefix on creation

2014-03-05 Thread Max Reitz
The bdrv_create() implementation of the block/raw-posix "file" protocol driver should strip the "file:" prefix from filenames if present. Signed-off-by: Max Reitz --- block/raw-posix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 892145c..e6b4

[Qemu-devel] [PATCH 1/5] block: Keep "filename" option after parsing

2014-03-05 Thread Max Reitz
Currently, bdrv_file_open() always removes the "filename" option from the options QDict after bdrv_parse_filename() has been (successfully) called. However, for drivers with bdrv_needs_filename, it makes more sense for bdrv_parse_filename() to overwrite the "filename" option and for bdrv_file_open(

Re: [Qemu-devel] [PATCH 1/2] block: Add node-name and to-replace-node-name arguments to drive-mirror.

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 22:13:13 (+0100), Benoît Canet wrote : > The Wednesday 05 Mar 2014 à 13:54:44 (-0700), Eric Blake wrote : > > On 03/05/2014 08:18 AM, Benoît Canet wrote: > > > node-name give a name to the created BDS and register it in the node > > > graph. > > > > s/give/gives/ s/reg

[Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis

2014-03-05 Thread Stefan Weil
Smatch complains about several global symbols which should be local. Add the missing 'static' attributes and move the 'extern' declaration of variable qemuio_misalign to qemu-io.h. This variable also changes the type from 'int' to 'bool' which better fits documents its use. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-05 Thread Eric Blake
On 03/05/2014 07:12 AM, anton.iva...@kot-begemot.co.uk wrote: > From: Anton Ivanov > > This transport allows qemu to communicate with host if host > supports L2TPv3, communicate directly VM to VM (similar to > current socket transport) and VM to other device - f.e. VM to > a router. > > Supporte

[Qemu-devel] [PATCH] audio: Add 'static' attributes to several variables

2014-03-05 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/audio/fmopl.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index f0a0234..f0d6d6f 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -223,13 +223,13 @@ static void *cur_chip = NULL; /* c

Re: [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 21:21:46 (+0100), Max Reitz wrote : > On 05.03.2014 21:20, Benoît Canet wrote: > >The Wednesday 05 Mar 2014 à 20:58:12 (+0100), Max Reitz wrote : > >>On 05.03.2014 17:04, Benoît Canet wrote: > >>>The Monday 03 Mar 2014 à 16:28:45 (+0100), Max Reitz wrote : > Add a JS

[Qemu-devel] [PATCH v3 3/5] qom: make QOM link property unref optional

2014-03-05 Thread Stefan Hajnoczi
Some object_property_add_link() callers expect property deletion to unref the link property object. Other callers expect to manage the refcount themselves. The former are currently broken and therefore leak the link property object. This patch adds a flags argument to object_property_add_link()

Re: [Qemu-devel] [PATCH 1/2] block: Add node-name and to-replace-node-name arguments to drive-mirror.

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 13:54:44 (-0700), Eric Blake wrote : > On 03/05/2014 08:18 AM, Benoît Canet wrote: > > node-name give a name to the created BDS and register it in the node graph. > > s/give/gives/ s/register/registers/ > > > > > to-replace-node-name can be used when drive-mirror is c

[Qemu-devel] [PATCH] qjson.h: Remove GCC_FMT_ATTR markup from qobject_from_jsonv() declaration

2014-03-05 Thread Stefan Weil
Commit aa830cdc28edb69c1fe81c8fd9471ab288ad0926 removed that attribute from qobject_from_json. Now gcc suggests to add it again when compiler flag -Wmissing-format-attribute is used: qobject/qjson.c: In function ‘qobject_from_json’: qobject/qjson.c:53:5: error: function might be possible candidat

Re: [Qemu-devel] [PATCH 1/2] block: Add node-name and to-replace-node-name arguments to drive-mirror.

2014-03-05 Thread Eric Blake
On 03/05/2014 08:18 AM, Benoît Canet wrote: > node-name give a name to the created BDS and register it in the node graph. s/give/gives/ s/register/registers/ > > to-replace-node-name can be used when drive-mirror is called with sync=full. > > The purpose of these fields is to be able to reconst

[Qemu-devel] [PATCH v3 5/5] virtio-rng: avoid default_backend refcount leak

2014-03-05 Thread Stefan Hajnoczi
QOM child properties take a reference to the object and release it when the property is deleted. Therefore we should unref the default_backend after we have added it as a child property. Cc: KONRAD Frederic Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio-rng.c | 3 +++ 1 file changed, 3 in

[Qemu-devel] [PATCH v3 2/5] qom: don't make link NULL on object_property_set_link() failure

2014-03-05 Thread Stefan Hajnoczi
The error behavior of object_property_set_link() is dangerous. It sets the link property object to NULL if an error occurs. A setter function should either succeed or fail, it shouldn't leave the value NULL on failure. Signed-off-by: Stefan Hajnoczi --- qom/object.c | 29 +++---

[Qemu-devel] [PATCH v3 4/5] qom: add check() argument to object_property_add_link()

2014-03-05 Thread Stefan Hajnoczi
There are currently three types of object_property_add_link() callers: 1. The link property may be set at any time. 2. The link property of a DeviceState instance may only be set before realize. 3. The link property may never be set, it is read-only. Something similar can already be achieved w

[Qemu-devel] [PATCH v3 0/5] qom: link property fixes

2014-03-05 Thread Stefan Hajnoczi
v3: * Split first commit for easier reviewing [afaerber] * Turn bool argument into flags bitmask [pbonzini] * Rename set() callback to check() [pbonzini] * Rename object_property_default_set_link() to object_property_allow_set_link() * Rename qdev_prop_default_set_link() to qdev_prop_all

[Qemu-devel] [PATCH v3 1/5] qom: split object_property_set_link()

2014-03-05 Thread Stefan Hajnoczi
The path resolution logic in object_property_set_link() should be a separate function. This makes the code easier to read and maintain. Signed-off-by: Stefan Hajnoczi --- qom/object.c | 59 +++ 1 file changed, 39 insertions(+), 20 deletion

Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule

2014-03-05 Thread Andreas Färber
Am 14.02.2014 05:03, schrieb Alexey Kardashevskiy: > On 02/11/2014 07:32 AM, Andreas Färber wrote: >> Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: >>> This adds $(check-qtest-ppc64-y) to the check-clean rule. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Nice catch! >> >>> --- >>> tests

Re: [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status()

2014-03-05 Thread Max Reitz
On 05.03.2014 21:41, Benoît Canet wrote: The Wednesday 05 Mar 2014 à 21:10:03 (+0100), Max Reitz wrote : On 05.03.2014 17:11, Benoît Canet wrote: The Monday 03 Mar 2014 à 16:28:48 (+0100), Max Reitz wrote : Implement this function in the same way as raw_bsd does: Acknowledge that this is a pas

Re: [Qemu-devel] [PATCH 2/2] tests-ppc64: test for -device spapr-pci-host-bridge

2014-03-05 Thread Andreas Färber
Am 14.02.2014 05:05, schrieb Alexey Kardashevskiy: > On 02/11/2014 02:48 AM, Andreas Färber wrote: >> Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: >>> This adds a test if SPAPR PHB can be added via the command line. >>> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> tests/Makefile

Re: [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status()

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 21:10:03 (+0100), Max Reitz wrote : > On 05.03.2014 17:11, Benoît Canet wrote: > >The Monday 03 Mar 2014 à 16:28:48 (+0100), Max Reitz wrote : > >>Implement this function in the same way as raw_bsd does: Acknowledge > >>that this is a passthrough driver (always return BD

Re: [Qemu-devel] [PATCH v3 2/2] vl: convert -m to QemuOpts

2014-03-05 Thread Eric Blake
On 03/05/2014 09:10 AM, Igor Mammedov wrote: > Adds option to -m > "size" - startup memory amount > > For compatibility with legacy CLI if suffix-less number is passed, > it assumes amount in Mb. > > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G > > Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-05 Thread Eric Blake
On 03/05/2014 01:15 PM, Max Reitz wrote: >>> +\"filename\": \"$TEST_IMG\" >> Are we guaranteed that $TEST_IMG will not contain any " which would >> render this invalid JSON? > > Probably not, but do you have an idea to circumvent this? If nothing else, we can at least be paranoid wit

Re: [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver

2014-03-05 Thread Max Reitz
On 05.03.2014 21:20, Benoît Canet wrote: The Wednesday 05 Mar 2014 à 20:58:12 (+0100), Max Reitz wrote : On 05.03.2014 17:04, Benoît Canet wrote: The Monday 03 Mar 2014 à 16:28:45 (+0100), Max Reitz wrote : Add a JSON protocol driver which allows supplying block driver options through the file

Re: [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 20:58:12 (+0100), Max Reitz wrote : > On 05.03.2014 17:04, Benoît Canet wrote: > >The Monday 03 Mar 2014 à 16:28:45 (+0100), Max Reitz wrote : > >>Add a JSON protocol driver which allows supplying block driver options > >>through the filename rather than separately. Othe

Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-05 Thread Max Reitz
On 05.03.2014 18:27, Eric Blake wrote: On 03/03/2014 08:28 AM, Max Reitz wrote: Add a test for the JSON protocol driver. Signed-off-by: Max Reitz --- tests/qemu-iotests/084 | 114 + + +# Taken from test 072 The comment is okay, but... +echo +

Re: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join()

2014-03-05 Thread Max Reitz
On 05.03.2014 17:52, Eric Blake wrote: On 03/03/2014 08:28 AM, Max Reitz wrote: This function joins two QDicts by absorbing one into the other. Signed-off-by: Max Reitz --- include/qapi/qmp/qdict.h | 3 +++ qobject/qdict.c | 32 2 files changed, 3

Re: [Qemu-devel] [PATCH 09/10] block/qapi: Ignore filters on top for format name

2014-03-05 Thread Max Reitz
On 05.03.2014 17:20, Benoît Canet wrote: The Monday 03 Mar 2014 à 16:28:52 (+0100), Max Reitz wrote : bdrv_query_image_info() currently deduces the image filename and the format name from the top BDS. However, it is probably more reasonable to ignore as many filters as possible on top of the BDS

Re: [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status()

2014-03-05 Thread Max Reitz
On 05.03.2014 17:11, Benoît Canet wrote: The Monday 03 Mar 2014 à 16:28:48 (+0100), Max Reitz wrote : Implement this function in the same way as raw_bsd does: Acknowledge that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID and BDRV_BLOCK_DATA and derive the offset directly f

Re: [Qemu-devel] [PATCH 04/10] block/json: Add functions for writing zeroes etc.

2014-03-05 Thread Max Reitz
On 05.03.2014 17:09, Benoît Canet wrote: The Monday 03 Mar 2014 à 16:28:47 (+0100), Max Reitz wrote : Add passthrough functions for bdrv_aio_discard(), bdrv_co_write_zeroes(), bdrv_truncate() and bdrv_has_zero_init(). Signed-off-by: Max Reitz --- block/json.c | 30 +++

Re: [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver

2014-03-05 Thread Max Reitz
On 05.03.2014 17:04, Benoît Canet wrote: The Monday 03 Mar 2014 à 16:28:45 (+0100), Max Reitz wrote : Add a JSON protocol driver which allows supplying block driver options through the filename rather than separately. Other than that, it is a pure passthrough driver which identifies itself as a

Re: [Qemu-devel] [PATCH] qemu-file: use fwrite() correctly (take II)

2014-03-05 Thread Eric Blake
On 03/05/2014 12:08 PM, Juan Quintela wrote: > Simple minds like mine can't understand neither fwrite, or comments > when there are 3 versions of a patch. The integrated patch is missing > this bit. > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster > -

[Qemu-devel] [PATCH] qemu-file: use fwrite() correctly (take II)

2014-03-05 Thread Juan Quintela
Simple minds like mine can't understand neither fwrite, or comments when there are 3 versions of a patch. The integrated patch is missing this bit. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- I added Reviewed-by: by Eric & Markus because they acked

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-05 Thread Andreas Färber
Am 05.03.2014 00:49, schrieb Michael S. Tsirkin: > On Mon, Mar 03, 2014 at 11:05:17PM +0100, Hervé Poussineau wrote: >> Ping. >> >> QEMU crash at reboot is due to not resetting PAM registers at i440fx >> reset, but a patch has already been rejected on ML: >> http://lists.gnu.org/archive/html/qemu-d

Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-05 Thread Eric Blake
On 03/05/2014 08:58 AM, Eric Blake wrote: > On 03/04/2014 11:40 PM, Amos Kong wrote: > >>> but the docs imply that I should now see: >>> >>> {"parameters": [], "option": "smbios", "argument": true} >> >> I really got : {"parameters": [], "option": "smbios", "argument": true} >> >> (I was testing w

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-05 Thread Andreas Färber
Am 04.03.2014 00:36, schrieb Serge E. Hallyn: > Quoting Aneesh Kumar K.V (aneesh.ku...@linux.vnet.ibm.com): >> commit 01041f5df94ff19988cbadd7bd3eefcc9d964e4e >> Author: Aneesh Kumar K.V >> Date: Tue Mar 4 00:35:32 2014 +0530 >> >> hw/9pfs: Include virtio-9p-device.o in build >> >>

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-05 Thread Michael S. Tsirkin
On Tue, Feb 11, 2014 at 11:46:01PM +0100, Hervé Poussineau wrote: > With those two patches, I'm able to run a real BIOS in QEMU (Iwill P55XB2) > However, QEMU crashes when rebooting the computer after leaving BIOS settings. > > Hervé Poussineau (2): > pam: partly fix write-only mode > pckbd: r

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-03-05 Thread Neil Skrypuch
On Wednesday 05 March 2014 16:59:24 Andreas Färber wrote: > Am 30.01.2014 19:23, schrieb Neil Skrypuch: > > First, let me briefly outline the way we use live migration, as it is > > probably not typical. We use live migration (with block migration) to > > make backups of VMs with zero downtime. The

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 16:50, Andreas Färber ha scritto: Am 03.03.2014 20:13, schrieb Paolo Bonzini: Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: From: "Aneesh Kumar K.V" After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including hw/Makefile.objs directly from Makefile.target. Hence w

[Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-05 Thread Richard Henderson
Fixes a build error when these are different, e.g. x32. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 08ac659..37e05e8 100644 --- a/target-arm/trans

[Qemu-devel] [PATCH 11/11] tcg-sparc: Convert to new ldst opcodes

2014-03-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 151 + tcg/sparc/tcg-target.h | 2 +- 2 files changed, 53 insertions(+), 100 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 754e520..152335c 100644 ---

[Qemu-devel] [PATCH 04/11] tcg-sparc: Use intptr_t as appropriate

2014-03-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index fe34724..ebcba71 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -449,13

[Qemu-devel] [PATCH 03/11] tcg-sparc: Tidy call+jump patterns

2014-03-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 9d461a1..fe34724 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-t

[Qemu-devel] [PATCH 00/11] tcg-sparc updates

2014-03-05 Thread Richard Henderson
Rescued from a branch from September. I can't recall if I ever actually posted these back then, so I'll wait a week before asking for a pull. Re-tested on v8plus. The machine doesn't have 64-bit libraries installed, so I'm a bit stuck with that. r~ Richard Henderson (11): tcg-sparc: Fix ld

[Qemu-devel] [PATCH 10/11] tcg-sparc: Convert to new ldst helpers

2014-03-05 Thread Richard Henderson
All of the helpers with the explicit big/little endian option require the return address as a parameter. Acquire this via a trampoline. Move the load of areg0 into the trampoline. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 190 ++--

[Qemu-devel] [PATCH 08/11] tcg-sparc: Use TCGMemOp within qemu_ldst routines

2014-03-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 116 +++-- 1 file changed, 65 insertions(+), 51 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index e5a5e02..57e4222 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg

[Qemu-devel] [PATCH 07/11] tcg-sparc: Improve tcg_out_movi

2014-03-05 Thread Richard Henderson
If bits 31:13 are zero, reduce the insn count by one. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 52 ++ 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 3ae014d

[Qemu-devel] [PATCH 02/11] tcg-sparc: Fix tlb read

2014-03-05 Thread Richard Henderson
We were computing the full address into %o0 and then not using it. Adjust some of the computation to rely less on having to pull immediate values into registers. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 36 +++- 1 file changed, 15 insertions(+

[Qemu-devel] [PATCH 09/11] tcg-sparc: Tidy tcg_out_tlb_load interface

2014-03-05 Thread Richard Henderson
Pass address registers explicitly, rather than as indicies of args[]. It's two argument registers either way. Use more TCGReg as appropriate. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 70 ++ 1 file changed, 30 insertions(+), 40

[Qemu-devel] [PATCH 05/11] tcg-sparc: Don't handle remainder

2014-03-05 Thread Richard Henderson
The generic fallback is exactly what we implemented. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 21 - tcg/sparc/tcg-target.h | 4 ++-- 2 files changed, 2 insertions(+), 23 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index ebc

[Qemu-devel] [PATCH 06/11] tcg-sparc: Dont handle constant arguments to ext32 ops

2014-03-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 30a2eaa..3ae014d 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -1405,18 +14

[Qemu-devel] [PATCH 01/11] tcg-sparc: Fix ld64 for 32-bit mode

2014-03-05 Thread Richard Henderson
Since were not using an annulled branch, we need to put a nop in the delay slot. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index cbd1c91..b459886 100644 --- a/tcg/sparc/tcg-targe

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Peter Lieven
Am 05.03.2014 18:38, schrieb Marcus: > On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: >> Am 05.03.2014 16:20, schrieb Marcus: >>> I think this is a more generic sysadmin problem. I've seen the same >>> thing in the past with simply snapshotting a logical volume or zfs >>> zvol and copying it

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass

2014-03-05 Thread Marcel Apfelbaum
On Wed, 2014-03-05 at 10:36 -0700, Eric Blake wrote: > On 03/05/2014 10:30 AM, Marcel Apfelbaum wrote: > > In order to allow attaching machine options to a machine instance, > > current_machine is converted into MachineState. > > As a first step of deprecating QEMUMachine, some of the functions > >

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Marcus
On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: > Am 05.03.2014 16:20, schrieb Marcus: >> I think this is a more generic sysadmin problem. I've seen the same >> thing in the past with simply snapshotting a logical volume or zfs >> zvol and copying it off somewhere. Page cache bloats, the syst

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass

2014-03-05 Thread Eric Blake
On 03/05/2014 10:30 AM, Marcel Apfelbaum wrote: > In order to allow attaching machine options to a machine instance, > current_machine is converted into MachineState. > As a first step of deprecating QEMUMachine, some of the functions > were modified to return MachineCLass. s/MachineCLass/MachineC

Re: [Qemu-devel] [PATCH] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist

2014-03-05 Thread Paul Moore
On Wednesday, March 05, 2014 11:53:58 AM Eduardo Otubo wrote: > On 03/03/2014 05:41 PM, Paul Moore wrote: > > On Wednesday, February 26, 2014 10:25:01 AM Paul Moore wrote: > >> Additional testing reveals that PulseAudio requires shmctl() and the > >> mlock()/munlock() syscalls on some systems/confi

  1   2   3   >