[Qemu-devel] [PATCH v3 08/13] qapi: Fix licensing of scripts

2014-02-28 Thread Markus Armbruster
The scripts carry this copyright notice: # This work is licensed under the terms of the GNU GPLv2. # See the COPYING.LIB file in the top-level directory. The sentences contradict each other, as COPYING.LIB contains the LGPL 2.1. Michael Roth says this was a simple pasto, and he meant to

[Qemu-devel] [PATCH v3 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-visit.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index b2a1c1c..97e9b11 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -494,10 +494,8 @@ fdecl.w

[Qemu-devel] [PATCH v3 03/13] tests/qapi-schema: Cover simple argument types

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 2 ++ tests/qapi-schema/qapi-schema-test.out | 1 + tests/test-qmp-commands.c | 16 3 files changed, 19 insertions(+) diff --git a/tests/qapi-schema/qapi-sche

[Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors

2014-02-28 Thread Markus Armbruster
Visitors get passed a pointer to the visited object. The generated visitors try to cope with this pointer being null in some places, for instance like this: visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err); visit_start_optional() passes its second argument to Visitor met

[Qemu-devel] [PATCH v3 05/13] tests/qapi-schema: Cover complex types with base

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 6 +- tests/qapi-schema/qapi-schema-test.out | 6 -- tests/test-qmp-commands.c | 15 ++- tests/test-qmp-input-visitor.c | 4 ++-- tests/test-qmp-o

[Qemu-devel] [PATCH v3 07/13] tests/qapi-schema: Cover flat union types

2014-02-28 Thread Markus Armbruster
The test demonstrates a generator bug: the generated struct UserDefFlatUnion doesn't include members for the indirect base UserDefZero. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 7 +++ tests/qapi-schema/qapi-schema-test.out | 2

[Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str()

2014-02-28 Thread Markus Armbruster
Argument can't be null. No other Visitor method type_str() checks for null. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/qapi-dealloc-visitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c

[Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct()

2014-02-28 Thread Markus Armbruster
Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opt

[Qemu-devel] [PATCH v3 06/13] tests/qapi-schema: Cover union types with base

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 1 + tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-input-strict.c | 4 ++-- tests/test-qmp-input-visitor.c | 3 ++- tests/test-qmp-output-visitor.c |

[Qemu-devel] [PATCH v3 10/13] qapi: Drop unused code in qapi-commands.py

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 20 1 file changed, 20 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 38c2347..9734ab0 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-comma

[Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 4 tests/qapi-schema/qapi-schema-test.out | 6 +- tests/test-qmp-input-strict.c | 32 tests/test-qmp-input-visitor.c | 18 +++

[Qemu-devel] [PATCH v3 02/13] tests/qapi-schema: Cover optional command arguments

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 4 +++- tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-commands.c | 8 +--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/qapi-schema/qa

[Qemu-devel] [PATCH v3 01/13] tests/qapi-schema: Actually check successful QMP command response

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/test-qmp-commands.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 5a3e82a..d039b87 100644 --- a/tests/

[Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code

2014-02-28 Thread Markus Armbruster
Coverity is unhappy with the generated code. Nothing serious, just heaps of valid DEADCODE defects topped off with a few bogus FORWARD_NULL defects. I had a look at the generator, and decided I don't want to mess with it without decent test coverage. Unfortunately, a few features have been added

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-28 Thread Markus Armbruster
Wenchao Xia writes: > Markus, do you like the way this version works? I hope to review it early next week.

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Alex Williamson
On Thu, 2014-02-27 at 19:05 +0200, Michael S. Tsirkin wrote: > apic polarity in KVM does not work: too many things assume active high. > Let's not pretend it works, let's just ignore polarity flag. If we ever > want to emulate it exactly, this will need a feature flag anyway. > > Also report this

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Chalamarla, Tirumalesh
Hi Peter, Thanks for the reply, yes i am interested in (2). i will follow up on the suggested mailing list. Just in case if you know, does the gicv3 support available in QEMU, or there is a plan. Regards, Tirumaqlesh. On 01-Mar-2014, at 5:58 am, Peter Maydell wrote: > On 28 Februa

Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Alexander Graf
Gabriel L. Somlo wrote: > On Sat, Mar 01, 2014 at 11:44:33AM +0800, Alexander Graf wrote: > >> Deja vu :). Should we really set this to thd least compatible version or >> rather to a current one that resembles roughly what we support? Otherwise >> patches like this will come up for every new o

Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Gabriel L. Somlo
On Sat, Mar 01, 2014 at 11:44:33AM +0800, Alexander Graf wrote: > Deja vu :). Should we really set this to thd least compatible version or > rather to a current one that resembles roughly what we support? Otherwise > patches like this will come up for every new osx release. > > What is the versi

Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Alexander Graf
> Am 01.03.2014 um 03:14 schrieb "Gabriel L. Somlo" : > > Some guests (e.g. 0S X) insist on a minimum lapic version of 0x14. > This patch bumps the emulated lapic version to 0x14 to accomodate that. > > Signed-off-by: Gabriel L. Somlo > --- > > Along with the TCG ioapic polarity fix, this all

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-02-28 Thread 陈梁
> On Thursday 30 January 2014 13:23:04 Neil Skrypuch wrote: >> First, let me briefly outline the way we use live migration, as it is >> probably not typical. We use live migration (with block migration) to make >> backups of VMs with zero downtime. The basic process goes like this: >> >> 1) migra

[Qemu-devel] [PATCH] block: qemu-iotests 085 - live snapshots tests

2014-02-28 Thread Jeff Cody
This adds tests for live snapshots, both through the single snapshot command, and the transaction group snapshot command. The snapshots are done through the QMP interface, using the following commands for snapshots: Single snapshot: { 'execute': 'blockdev-snapshot-sync', 'arguments':

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Peter Maydell
On 1 March 2014 00:41, Xuebing wang wrote: > On 03/01/2014 08:28 AM, Peter Maydell wrote: >> >> (4) using QEMU to emulate an entire AArch64 system that can boot a guest >> kernel, typically running on an x86 host: we're working on this right now; >> we have work-in-progress code which will boot a

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Xuebing wang
On 03/01/2014 08:28 AM, Peter Maydell wrote: (4) using QEMU to emulate an entire AArch64 system that can boot a guest kernel, typically running on an x86 host: we're working on this right now; we have work-in-progress code which will boot a kernel and are working on cleaning it up to upstream q

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Peter Maydell
On 28 February 2014 07:08, Chalamarla, Tirumalesh wrote: > Is there any one, trying out cross compiling and running qemu > on aarch64 host. if so is there a development branch where this wrok is > progressing. > >Some one could please let me know the plan/time frame,

Re: [Qemu-devel] [PATCH v3 21/31] target-arm: Implement AArch64 DAIF system register

2014-02-28 Thread Peter Crosthwaite
On Fri, Feb 28, 2014 at 11:48 PM, Peter Maydell wrote: > On 17 February 2014 00:17, Peter Crosthwaite > wrote: >> On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell >> wrote: >>> Implement the DAIF system register which is a view of the >>> DAIF bits in PSTATE. > >>> +static uint64_t aa64_daif_read

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-28 Thread Wenchao Xia
Markus, do you like the way this version works?

Re: [Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union

2014-02-28 Thread Wenchao Xia
于 2014/2/28 3:21, Eric Blake 写道: On 02/27/2014 04:09 AM, Wenchao Xia wrote: From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia Double-S-o-B. I've also noticed that I'm getting undeliverable mail rejections from your linux.vnet.ibm.com address: TCVM.MEGACENTER.DE.IBM.COM u

Re: [Qemu-devel] The unholy encrypted image key mess

2014-02-28 Thread Eric Blake
On 02/28/2014 02:01 PM, Markus Armbruster wrote: > The encrypted images Saturday afternoon hack is a gift that keeps on > giving. I wish we could rip it out and bury it deep. Or that I could > continue to ignore it. Unfortunately, it looks like I need to touch it > to clean up error propagation

[Qemu-devel] [PATCH v6] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-off-by: Thomas Falcon --- Differences from v5:

Re: [Qemu-devel] [qom-cpu PATCH 00/10] target-i386: Support check/enforce flags in TCG mode, too

2014-02-28 Thread Richard Henderson
On 02/28/2014 12:21 PM, Eduardo Habkost wrote: > This removes some duplication in the CPU feature checking and filtering code > in > cpu.c, and as a nice side-effect, will make the "check" and "enforce" flags > work > in TCG mode too. > > Eduardo Habkost (10): > target-i386: Simplify reporting

[Qemu-devel] [qom-cpu PATCH 07/10] target-i386: Filter KVM and 0xC0000001 features on TCG

2014-02-28 Thread Eduardo Habkost
TCG doesn't support any of the feature flags on FEAT_KVM and FEAT_C000_0001_EDX feature words, so clear all bits on those feature words. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1d954d

[Qemu-devel] [Bug 1285508] Re: [ppa 2.0~git-20140225] mouse cursor invisible with Ubuntu live system

2014-02-28 Thread Serge Hallyn
Interestingly this only happens with sdl. Using vga it works fine. It also works fine in qxl/spice (qemu ... -spice disable- ticketing,port=5930; spicy -h localhost -p 5930). ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu) Status: New => Tria

[Qemu-devel] [qom-cpu PATCH 03/10] target-i386: Pass FeatureWord argument to report_unavailable_features()

2014-02-28 Thread Eduardo Habkost
This will help us simplify the code that calls report_unavailable_features() later. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b46478b..af82289 100644 --- a/target-i386/

[Qemu-devel] The unholy encrypted image key mess

2014-02-28 Thread Markus Armbruster
The encrypted images Saturday afternoon hack is a gift that keeps on giving. I wish we could rip it out and bury it deep. Or that I could continue to ignore it. Unfortunately, it looks like I need to touch it to clean up error propagation in the monitor. So here goes. A naive user might expect

[Qemu-devel] [qom-cpu PATCH 06/10] target-i386: Filter FEAT_7_0_EBX TCG features too

2014-02-28 Thread Eduardo Habkost
The TCG_7_0_EBX_FEATURES macro was defined but never used (it even had a typo that was never noticed). Make the existing TCG feature filtering code use it. Change the TCG feature flag filtering code to use it. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 3 ++- 1 file changed, 2 inser

[Qemu-devel] [qom-cpu PATCH 09/10] target-i386: Loop-based feature word filtering in TCG mode

2014-02-28 Thread Eduardo Habkost
Instead of manually filtering each feature word, add a tcg_features field to FeatureWordInfo, and use that field to filter all feature words in TCG mode. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [qom-cpu PATCH 10/10] target-i386: Support check/enforce flags in TCG mode, too

2014-02-28 Thread Eduardo Habkost
If enforce/check is specified in TCG mode, QEMU will ensure all CPU features are supported by TCG, so no CPU feature is silently disabled. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a

[Qemu-devel] [qom-cpu PATCH 08/10] target-i386: Define TCG_*_FEATURES earlier on cpu.c

2014-02-28 Thread Eduardo Habkost
Those macros will be used in the feature_word_info array data, so need to be defined earlier. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 116 +++--- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/target-i386/cpu.c b/tar

[Qemu-devel] [qom-cpu PATCH 04/10] target-i386: Isolate KVM-specific code on CPU feature filtering logic

2014-02-28 Thread Eduardo Habkost
This will allow us to re-use the feature filtering logic (and the check/enforce flag logic) for TCG. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index af82289

[Qemu-devel] [qom-cpu PATCH 05/10] target-i386: Make TCG feature filtering more readable

2014-02-28 Thread Eduardo Habkost
Instead of an #ifdef in the middle of the code, just set TCG_EXT2_FEATURES to a different value depending on TARGET_X86_64. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/c

[Qemu-devel] [qom-cpu PATCH 00/10] target-i386: Support check/enforce flags in TCG mode, too

2014-02-28 Thread Eduardo Habkost
This removes some duplication in the CPU feature checking and filtering code in cpu.c, and as a nice side-effect, will make the "check" and "enforce" flags work in TCG mode too. Eduardo Habkost (10): target-i386: Simplify reporting of unavailable features target-i386: Merge feature filtering/c

[Qemu-devel] [qom-cpu PATCH 02/10] target-i386: Merge feature filtering/checking functions

2014-02-28 Thread Eduardo Habkost
Merge filter_features_for_kvm() and kvm_check_features_against_host(). Both functions made exactly the same calculations, the only difference was that filter_features_for_kvm() changed the bits on cpu->features[], and kvm_check_features_against_host() did error reporting. Signed-off-by: Eduardo H

[Qemu-devel] [qom-cpu PATCH 01/10] target-i386: Simplify reporting of unavailable features

2014-02-28 Thread Eduardo Habkost
Instead of checking and calling unavailable_host_feature() once for each bit, simply call the function (now renamed to report_unavailable_features()) once for each feature word. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletio

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-02-28 Thread Neil Skrypuch
On Thursday 30 January 2014 13:23:04 Neil Skrypuch wrote: > First, let me briefly outline the way we use live migration, as it is > probably not typical. We use live migration (with block migration) to make > backups of VMs with zero downtime. The basic process goes like this: > > 1) migrate src V

Re: [Qemu-devel] [PATCH 2/2] [RFC] Convert Clock Timerlists to RCU V2

2014-02-28 Thread Alex Bligh
Mike On 27 Feb 2014, at 19:35, Mike Day wrote: > timerlists is a list of lists that holds active timers, among other > items. It is read-mostly. This patch converts read access to the > timerlists to use RCU. > > Rather than introduce a second mutex for timerlists, which would > require nested m

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Richard Henderson
On 02/28/2014 11:28 AM, Thomas Falcon wrote: > How about this instead? > > int len = ppc_cpu_gdb_register_len(n); > if (len==4) { > bswap32s((uint32_t *)mem_buf); > } else { > bswap64s((uint64_t *)mem_buf); > } Looks much better, thanks. r~

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
type passed to type_get_by_name() was "virtio-9p-device". It returned NULL. Looking at the compile output, in fact ./hw/9pfs/virtio-9p-device.o did not get compiled after commit ba1183da9a10b94611cad88c44a5c6df005f9b55. -- You received this bug notification because you are a member of qemu- de

Re: [Qemu-devel] [PATCH 1/2] [RFC] Convert active timers list to use RCU V2

2014-02-28 Thread Alex Bligh
Mike, This one's nice and clear. A few comments in line. On 27 Feb 2014, at 19:35, Mike Day wrote: > @@ -184,16 +178,17 @@ bool qemu_clock_has_timers(QEMUClockType type) > bool timerlist_expired(QEMUTimerList *timer_list) > { > int64_t expire_time; > +bool ret; > > -qemu_mutex_lock(

[Qemu-devel] QEMU on ARM64

2014-02-28 Thread Chalamarla, Tirumalesh
Hi, Is there any one, trying out cross compiling and running qemu on aarch64 host. if so is there a development branch where this wrok is progressing. Some one could please let me know the plan/time frame, for qemu on arm64 hosts running arm64 guests. Regards,

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread 陈梁
> * Gonglei (arei.gong...@huawei.com) wrote: >> On 2014/2/28 17:19, Dr. David Alan Gilbert wrote: >> >>> * Gonglei (Arei) (arei.gong...@huawei.com) wrote: >>> >>> Hi, >>> a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread 陈梁
> On 02/27/2014 09:05 PM, Gonglei (Arei) wrote: >> a. Optimization the xbzrle remarkable decrease the cache misses. >>The efficiency of compress increases more than fifty times. >>Before the patch set, the cache almost totally miss when the >>number of cache item less than the dirty p

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Thomas Falcon
On 02/28/2014 11:37 AM, Richard Henderson wrote: On 02/26/2014 02:51 PM, Thomas Falcon wrote: +void ppc_cpu_gdb_swap_register(uint8_t *mem_buf, int n) +{ +int len = ppc_cpu_gdb_register_len(n); +int i = 0; +uint8_t tmp; +for (i = 0; i < len/2; i++) { +tmp = *(mem_buf + i)

Re: [Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
gdb stack dump: Program received signal SIGABRT, Aborted. 0x72849f79 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) where #0 0x72849f79 in __GI_raise (sig=sig@entry=6)

Re: [Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
Hm, sadly bisect gives me: ubuntu@c-trusty-0:~/qemu$ git bisect good ba1183da9a10b94611cad88c44a5c6df005f9b55 is the first bad commit commit ba1183da9a10b94611cad88c44a5c6df005f9b55 Author: Fam Zheng Date: Mon Feb 10 14:48:52 2014 +0800 rules.mak: fix $(obj) to a real relative path

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-28 Thread Joaquim Barrera
On 24/02/14 23:26, Paolo Bonzini wrote: Thanks for raising this. I noticed that mirror_run() does not throttle the first loop where it populates the dirty bitmap using bdrv_is_allocated_above(). This is on purpose. Does it causes a noticeable stall in the guest? The main copy loop does take

[Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Gabriel L. Somlo
Some guests (e.g. 0S X) insist on a minimum lapic version of 0x14. This patch bumps the emulated lapic version to 0x14 to accomodate that. Signed-off-by: Gabriel L. Somlo --- Along with the TCG ioapic polarity fix, this allows me to boot OS X without KVM acceleration. I dug around the Intel doc

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread 陈梁
> On 02/27/2014 09:08 PM, Gonglei (Arei) wrote: >> Add counters to log the times of updating the dirty bitmap. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei >> --- >> arch_init.c | 20 >> 1 file changed, 20 insertions(+) > > Is it also worth updating MigrationSta

Re: [Qemu-devel] [PATCH v3 0/2] dataplane: add query-iothreads QMP command

2014-02-28 Thread Luiz Capitulino
On Thu, 27 Feb 2014 11:48:40 +0100 Stefan Hajnoczi wrote: > v3: > * Loop until predicate is true to handle pthread_cond spurious wakeups > [eblake] > * Fix additional instances of "thread_id" [eblake] > > v2: > * Use "thread-id" instead of "thread_id" in QAPI [eblake] > * Avoid mutex unlock

[Qemu-devel] [RFC PATCH v2] qemu: x86: ignore ioapic polarity

2014-02-28 Thread Gabriel L. Somlo
Both QEMU and KVM have already accumulated a significant number of optimizations based on the hard-coded assumption that ioapic polarity will always use the ActiveHigh convention, where the logical and physical states of level-triggered irq lines always match (i.e., active(asserted) == high == 1, i

Re: [Qemu-devel] [PATCH] monitor: Remove left-over code in do_info_profile.

2014-02-28 Thread Luiz Capitulino
On Wed, 26 Feb 2014 23:09:52 +0100 Hani Benhabiles wrote: > This is a left-over from 4a1418e. > > Signed-off-by: Hani Benhabiles Applied to the qmp branch, thanks. > --- > monitor.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/monitor.c b/monitor.c > index aebcbd8..3863d83 10

Re: [Qemu-devel] [PATCH] qerror: Improve QERR_DEVICE_NOT_ACTIVE message

2014-02-28 Thread Luiz Capitulino
On Tue, 25 Feb 2014 09:42:43 +0100 Hani Benhabiles wrote: > On Tue, Feb 25, 2014 at 09:41:02AM +0100, Markus Armbruster wrote: > > Hani Benhabiles writes: > > > > > The error message as currently used is confusing as there are no > > > "balloon" or > > > "spice" devices. > > > > > > (qemu) bal

Re: [Qemu-devel] [PATCH] qmp: Check for returned data from __json_read in get_events

2014-02-28 Thread Luiz Capitulino
On Mon, 24 Feb 2014 13:45:01 +0800 Fam Zheng wrote: > When QEMU process aborts and socket is closed, qmp client will not > detect it. When this happens, some qemu-iotests scripts will enter an > endless loop waiting for qmp events. > > It's better we raise an exception in qmp.py to catch this an

[Qemu-devel] [PULL 9/9] block/vmdk: do not report file offset for compressed extents

2014-02-28 Thread Stefan Hajnoczi
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 83839f9..b69988d 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1184,7

[Qemu-devel] [PULL 7/9] block: use /var/tmp instead of /tmp for -snapshot

2014-02-28 Thread Stefan Hajnoczi
From: Amit Shah If TMPDIR is not specified, the default was to use /tmp for the working copy of the block devices. Update this to /var/tmp instead, so systems using tmp-on-tmpfs don't end up inadvertently using RAM for the block device. Signed-off-by: Amit Shah Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 3/9] block: gluster - add reopen support.

2014-02-28 Thread Stefan Hajnoczi
From: Jeff Cody Gluster does parse open flags in its .bdrv_open() implementation, and the .bdrv_reopen_* implementations need to do the same. A new gluster connection to the image file to be created is established in the .bdrv_reopen_prepare(), and the image file opened with the new flags. If t

[Qemu-devel] [PULL 2/9] block: gluster - code movements, state storage changes

2014-02-28 Thread Stefan Hajnoczi
From: Jeff Cody In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, add a NULL check in the gconf cleanup. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/gluster.c | 41 ++--- 1 file changed, 26 in

[Qemu-devel] [PULL 5/9] qmp: Make Quorum error events more palatable.

2014-02-28 Thread Stefan Hajnoczi
From: Benoît Canet Insert quorum QMP events documentation alphabetically. Also change the "ret" errno value by an optional "error" being an strerror(-ret) in the QUORUM_REPORT_BAD qmp event. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/quorum.

[Qemu-devel] [PULL 6/9] qemu-io-test: Disable Quorum test when not compiled in.

2014-02-28 Thread Stefan Hajnoczi
From: Benoît Canet Quorum is not compiled by default: make the quorum 081 test aware of this. Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/081 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/081 b/tests/qem

[Qemu-devel] [PULL 0/9] Block patches

2014-02-28 Thread Stefan Hajnoczi
The following changes since commit 9fbee91a131a05e443d7108d7fbdf3ca91020290: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-02-27 16:00:31 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch ch

[Qemu-devel] [PULL 8/9] discard rbd error output when not relevant in qemu-iotests

2014-02-28 Thread Stefan Hajnoczi
From: Loic Dachary Suppress rbd progress messages with --no-progress so they are not confused with an error output when comparing test results ( progress is displayed on stderr ). Signed-off-by: Loic Dachary Reviewed-by: Josh Durgin Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/commo

[Qemu-devel] [PULL 1/9] qemu-iotests: add more tests to the "quick" group

2014-02-28 Thread Stefan Hajnoczi
From: Paolo Bonzini None of these needs QEMU_PROG, and they all take but a few seconds. We need to point the launching script to qemu-nbd, though. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests-quick.sh | 1 + tests/qemu-iotests/group| 34 +

[Qemu-devel] [PULL 4/9] qmp: Fix BlockdevOptionQuorum.

2014-02-28 Thread Stefan Hajnoczi
From: Benoît Canet Fix some nits before QEMU 2.0 freeze. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- qapi-schema.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index ac8ad24..c3592f6

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Peter Maydell
Actually, the interesting bit of the stack trace starts just below where you cut it off, because object_initialize_with_type() is just asserting that it wasn't called with a NULL pointer, so what we really want to know is what the caller was... -- You received this bug notification because you ar

Re: [Qemu-devel] [PATCH v2] virtio-net: add a field to indicate if vlan table is used

2014-02-28 Thread Luiz Capitulino
On Fri, 21 Feb 2014 18:01:40 +0800 Amos Kong wrote: > On Thu, Feb 20, 2014 at 12:46:14PM -0500, Vlad Yasevich wrote: > > On 02/20/2014 11:38 AM, Amos Kong wrote: > > > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > > > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL

Re: [Qemu-devel] [PATCH v5 1/7] object: add object_get_canonical_basename()

2014-02-28 Thread Igor Mammedov
On Fri, 28 Feb 2014 18:15:55 +0100 Andreas Färber wrote: > Am 28.02.2014 16:18, schrieb Stefan Hajnoczi: > > It is often useful to find an object's child property name. Also use > > this new function to simplify the implementation of > > object_get_canonical_path(). > > > > Signed-off-by: Stefa

Re: [Qemu-devel] [PATCH v9 00/14] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-28 Thread Luiz Capitulino
On Tue, 18 Feb 2014 14:11:24 +0800 qiaonuohan wrote: > Hi, all > > The last version is here: > http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg03669.html > > Command 'dump-guest-memory' was introduced to dump guest's memory. But the > vmcore's format is only elf32 or elf64. The messa

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
Thanks, trivially reproduced. Will bisect. ** Changed in: qemu (Ubuntu) Importance: Undecided => High ** Changed in: qemu (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-02-28 Thread Alex Williamson
On Tue, 2014-02-25 at 20:37 -0600, Kim Phillips wrote: > We basically add support for the SysBusDevice type in addition to the > existing PCIDevice support. This involves taking common code from the > existing vfio_initfn(), and putting it under a new vfio_find_get_group(), > that both vfio_initfn

[Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-02-28 Thread Mario Smarduch
Public bug reported: When using indpendent transport and backend in this case virtio-net- device transport, none of the acceleration features are set after guest probes the transport the backend is plugged into. For virtio-net this leads to low throughput/performance. This holds true for virtio-

Re: [Qemu-devel] [PATCH v4] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Richard Henderson
On 02/26/2014 02:51 PM, Thomas Falcon wrote: > +void ppc_cpu_gdb_swap_register(uint8_t *mem_buf, int n) > +{ > +int len = ppc_cpu_gdb_register_len(n); > +int i = 0; > +uint8_t tmp; > +for (i = 0; i < len/2; i++) { > +tmp = *(mem_buf + i); > +*(mem_buf+i) = *(mem_buf

[Qemu-devel] [RFC PATCH] qemu: x86: ignore ioapic polarity

2014-02-28 Thread Gabriel L. Somlo
Both QEMU and KVM have already accumulated a significant number of optimizations based on the hard-coded assumption that ioapic polarity will always use the ActiveHigh convention, where the logical and physical states of level-triggered irq lines always match (i.e., active(asserted) == high == 1, i

[Qemu-devel] [PULL 1/3] target-i386: Fix CC_OP_CLR vs PF

2014-02-28 Thread Richard Henderson
Parity should be set for a zero result. Cc: qemu-sta...@nongnu.org Reviewed-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target-i386/cc_helper.c | 2 +- target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/targe

[Qemu-devel] [PULL 2/3] target-i386: Fix SSE status flag corruption

2014-02-28 Thread Richard Henderson
When we restore the mxcsr register with FXRSTOR, or set it with gdb, we need to update the various SSE status flags in CPUX86State Reported-by: Richard Purdie Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target-i386/cpu.h| 3 +++ target-i386/fpu_helper.c | 15 ++

[Qemu-devel] [PULL 0/3] target-i386 updates

2014-02-28 Thread Richard Henderson
I wasn't able to solicit additional review on patch 3, but at least the first two managed a R-B. r~ The following changes since commit d844a7b6569fb2b5252773444b18841426e5b906: modules: Fix building with --enable-modules (2014-02-28 12:30:13 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common

2014-02-28 Thread Richard Henderson
On 02/26/2014 01:53 PM, Peter Maydell wrote: > In QEMU we don't make any use at all of the common symbol > functionality, so we can avoid this problem entirely simply > by compiling with -fno-common. Enable this option for all > builds, not just MacOSX, so that if we ever inadvertently > introduce

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Peter Maydell
On 28 February 2014 17:08, Alex Bennée wrote: > > Peter Maydell writes: > >> On 28 February 2014 14:27, Alexander Graf wrote: >>> Could we check the instruction at the sognaling pc and check >>> if it's a known syscall instruction? No need to replace glibc >>> wrappers then. >> >> No, because th

Re: [Qemu-devel] [PATCH v5 1/7] object: add object_get_canonical_basename()

2014-02-28 Thread Andreas Färber
Am 28.02.2014 16:18, schrieb Stefan Hajnoczi: > It is often useful to find an object's child property name. Also use > this new function to simplify the implementation of > object_get_canonical_path(). > > Signed-off-by: Stefan Hajnoczi > --- > include/qom/object.h | 8 > qom/object.c

[Qemu-devel] [PULL 3/3] target-i386: Fix ucomis and comis memory access

2014-02-28 Thread Richard Henderson
We were loading 16 bytes for both single and double-precision scalar comparisons. Reported-by: Alexander Bluhm Signed-off-by: Richard Henderson --- target-i386/translate.c | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/target

Re: [Qemu-devel] [PATCH] linux-user: correct handling of break exception for MIPS

2014-02-28 Thread Petar Jovanovic
> This looks strange. Isn't &*info == info? It is. Just a few lines above, queue_signal is called in the same manner for style/preference reasons I presume, so this patch follows the pattern. Otherwise, it would require to change the other call site too. Regards, Petar __

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Alex Bennée
Peter Maydell writes: > On 28 February 2014 14:27, Alexander Graf wrote: >> Could we check the instruction at the sognaling pc and check >> if it's a known syscall instruction? No need to replace glibc >> wrappers then. > > No, because the behaviour we want for "started handling > syscall in qe

Re: [Qemu-devel] migrate to fd - how to use with HMP?

2014-02-28 Thread Stefan Hajnoczi
On Fri, Feb 28, 2014 at 09:30:33PM +1100, Alexey Kardashevskiy wrote: > On 02/28/2014 09:27 PM, Stefan Hajnoczi wrote: > > On Fri, Feb 28, 2014 at 03:05:12PM +1100, Alexey Kardashevskiy wrote: > >> However once socket_scm_helper talked to "mon" (./qemu.monitor), I cannot > >> get any response from

Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings

2014-02-28 Thread Andreas Färber
Am 28.02.2014 16:18, schrieb Stefan Hajnoczi: > From: Igor Mammedov > > get_pointer()'s print() callback might return a heap allocated > string, to avoid adding dedicated get_pointer_foo for this case > convert current print() callbacks to return temporary heap > allocated string and make get_poi

Re: [Qemu-devel] [PATCH] qapi: output visitor crashes qemu if it encounters a NULL value

2014-02-28 Thread Luiz Capitulino
On Mon, 17 Feb 2014 20:01:42 +0200 Marcel Apfelbaum wrote: > On Mon, 2014-02-17 at 10:38 -0700, Eric Blake wrote: > > On 02/17/2014 04:52 AM, Marcel Apfelbaum wrote: > > > A NULL value is not added to visitor's stack, but there > > > is no check for that when the visitor tries to return > > > tha

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 16:57, Andreas Färber ha scritto: Am 28.02.2014 16:08, schrieb Alexey Kardashevskiy: On 03/01/2014 02:05 AM, Paolo Bonzini wrote: Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzin

Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements

2014-02-28 Thread Andreas Färber
Am 26.02.2014 18:18, schrieb Jason J. Herne: > From: "Jason J. Herne" > > Modify s390_cpu_addr2state to allow fetching state information for cpu > addresses > above smp_cpus. Hotplug requires this capability. > > Also add s390_cpu_set_state function to allow modification of ipi_state > entrie

Re: [Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-28 Thread Richard Henderson
On 02/28/2014 12:33 AM, Claudio Fontana wrote: > ping? > > Richard, do you prefer to spin your polishing from last year instead? I do prefer my patch set over this. >> +INSN_IMM = 0x1000, /* 3.4.1, 3.4.4 - add/sub and logical */ >> +INSN_SHIFT = 0x1ac02000, /* 3.5.8 - Data

Re: [Qemu-devel] [PATCH v4 0/3] qapi: Allow modularization of QAPI schema files

2014-02-28 Thread Eric Blake
On 02/28/2014 08:53 AM, Lluís Vilanova wrote: > Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing > these to be modularized into multiple per-topic files in the future. > > Signed-off-by: Lluís Vilanova > --- Series: Reviewed-by: Eric Blake -- Eric Blake eblake

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Andreas Färber
Am 28.02.2014 16:08, schrieb Alexey Kardashevskiy: > On 03/01/2014 02:05 AM, Paolo Bonzini wrote: >> Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: >>> On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: > Il 27/02/2014 15:39, Marc

[Qemu-devel] [PULL 20/38] input: mouse: switch sdl ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 84 ++-- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index e78e020..b80b3df 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -351,7 +351,7 @@ static void sdl_hide

  1   2   3   >