Re: [Qemu-devel] [PATCH 07/20] gluster: default scheme to gluster:// and host to localhost.

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Currently, "gluster:///volname/img" and (using file. options) > "file.driver=gluster,file.filename=foo" will segfault. Also, > "//host/volname/img" will be rejected, but it is a valid URL > that should be accepted just fine with "file.driver=gluster". >

Re: [Qemu-devel] [PATCH 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Before: > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo > Failed to parse URL : foo > qemu-io-old: can't open device (null): Could not open 'foo': Invalid > argument > > After: > $ ./qemu-io > qemu

Re: [Qemu-devel] [PATCH 05/20] iscsi: fix indentation

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/iscsi.c | 45 +++-- > 1 file changed, 23 insertions(+), 22 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 6f4af72..e654a57 100644 > --- a/block/iscs

Re: [Qemu-devel] [PATCH 04/20] nbd: move socket wrappers to qemu-nbd

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > qemu-nbd is one of the few valid users of qerror_report_err. Move > the error-reporting socket wrappers there. > > Signed-off-by: Paolo Bonzini > --- > include/block/nbd.h | 4 > nbd.c | 50 -

Re: [Qemu-devel] [PATCH 03/20] nbd: inline tcp_socket_incoming_spec into sole caller

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > include/block/nbd.h | 1 - > nbd.c | 8 ++-- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/block/nbd.h b/include/block/nbd.h > index e10ab82..1b39c06 100644 > --- a/in

Re: [Qemu-devel] [PATCH 02/20] nbd: correctly propagate errors

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Before: > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=nbd > one of path and host must be specified. > qemu-io-old: can't open device (null): Could not open image: Invalid > argument > $ ./qemu-io-old > qemu-io-old> open

Re: [Qemu-devel] [PATCH 01/20] nbd: produce a better error if neither host nor port is passed

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Before: > $ qemu-io-old > qemu-io-old> open -r -o file.driver=nbd > qemu-io-old: can't open device (null): Could not open image: Invalid > argument > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=nbd,file.host=foo,file.path=ba

Re: [Qemu-devel] [PATCH] blockdev: Remove 'type' parameter from blockdev_init()

2014-02-09 Thread Fam Zheng
On Sun, 02/09 09:52, Kevin Wolf wrote: > @@ -872,8 +869,27 @@ DriveInfo *drive_init(QemuOpts *all_opts, > BlockInterfaceType block_default_type) > > filename = qemu_opt_get(legacy_opts, "file"); > > +/* Check werror/rerror compatibility with if=... */ > +werror = qemu_opt_get(lega

Re: [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:02, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > hw/sd/sdhci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > index 0906a1d..a0b90ba 100644 > --- a/hw/sd/sdhci.c > +++ b/hw/sd/sdhci.c > @@ -26,7 +26,6 @@ > #include "sysemu/block

Re: [Qemu-devel] [PATCH qom-next v2 02/12] tests: Add vmxnet3 qtest

2014-02-09 Thread Dmitry Fleytman
On Feb 9, 2014, at 13:57 PM, Andreas Färber wrote: > Note that this will emit a warning: > [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. > Task offloads will be emulated. > > Cc: Dmitry Fleytman > Cc: Stefan Hajnoczi > Signed-off-by: Andreas Färber > --- > tests/Mak

[Qemu-devel] [PATCH v20 11/11] oslib: port qemu_init_exec_dir to Darwin

2014-02-09 Thread Fam Zheng
Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng --- util/oslib-posix.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index c2eeb4f..3214e44 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -59,6 +59,12 @@ extern int

[Qemu-devel] [PATCH v20 10/11] block: convert block drivers linked with libs to modules

2014-02-09 Thread Fam Zheng
The converted block drivers are: curl iscsi rbd ssh glusterfs Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index bd21db9..639b5c9 100755 --- a/configu

[Qemu-devel] [PATCH v20 06/11] rules.mak: introduce DSO rules

2014-02-09 Thread Fam Zheng
Add necessary rules and flags for shared object generation. The new rules introduced here are: 1) %.o in $(common-obj-m) is compiled to %.o, then linked to %.so. 2) %.mo in $(common-obj-m) is the placeholder for %.so for pattern matching in Makefile. It's linked to "-shared" with all its dependen

[Qemu-devel] [PATCH v20 09/11] Makefile: introduce common-obj-m and block-obj-m for DSO

2014-02-09 Thread Fam Zheng
$(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile| 4 +++- Makefile.objs | 2 ++ Makefile.target | 6 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Make

[Qemu-devel] [PATCH v20 04/11] block: use per-object cflags and libs

2014-02-09 Thread Fam Zheng
No longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. This removes unwanted dependencies from libcacard. Signed-off-by: Fam Zheng [Split from Fam's patch to enable modules. -

[Qemu-devel] [PATCH v20 07/11] module: implement module loading

2014-02-09 Thread Fam Zheng
This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_stamp_$RELEASEHASH w

[Qemu-devel] [PATCH v20 01/11] util: Split out exec_dir from os_find_datadir

2014-02-09 Thread Fam Zheng
With this change, main() calls qemu_init_exec_dir and uses argv[0] to init exec_dir. The saved value can be retrieved with qemu_get_exec_dir later. It will be reused by module loading. Signed-off-by: Fam Zheng --- include/qemu-common.h | 2 +- include/qemu/osdep.h | 9 + os-posix.c

[Qemu-devel] [PATCH v20 05/11] darwin: do not use -mdynamic-no-pic

2014-02-09 Thread Fam Zheng
From: Paolo Bonzini While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do that. Signed-off-by: Paolo Bonzini Signed-off-by: F

[Qemu-devel] [PATCH v20 02/11] rules.mak: fix $(obj) to a real relative path

2014-02-09 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

[Qemu-devel] [PATCH v20 08/11] Makefile: install modules with "make install"

2014-02-09 Thread Fam Zheng
Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 07d1ed7..57d83a3 100644 --- a/Makefile +++ b/Makefile @@ -368,6 +368,12 @@ install-datadir install-localst

[Qemu-devel] [PATCH v20 03/11] rules.mak: allow per object cflags and libs

2014-02-09 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed in a nested var (e.g. common-obj-y

[Qemu-devel] [PATCH v20 00/11] Shared library module support

2014-02-09 Thread Fam Zheng
Rewrote the executable directory patch and added Darwin API in qemu_init_exec_dir(). v20: Dropped the argv0 passing patch from v19. Refactored qemu_get_exec_dir() in patch 01. Three patches are affected: [01/11] util: Split out exec_dir from os_find_datadir Rewritten. The

Re: [Qemu-devel] Commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) causing qemu crash

2014-02-09 Thread Michal Simek
2014-02-08 Guenter Roeck : > On 02/07/2014 06:31 PM, Edgar E. Iglesias wrote: > >> On Fri, Feb 07, 2014 at 03:17:31PM -0800, Guenter Roeck wrote: >> >>> Michal, >>> >>> commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) >>> results >>> in the following qemu crash in 3.14-rc1.

[Qemu-devel] [RFC PATCH] file ram alloc: fail if cannot preallocate

2014-02-09 Thread Alexey Kardashevskiy
At the moment if the user asked for huge pages and there is no more huge pages, QEMU prints warning and falls back to the anonymous memory allocator which is quite easy not to notice. QEMU also does so even if the user specified -mem-prealloc and it seems wrong as the user specifically requested hu

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-09 Thread Stefan Weil
Am 10.02.2014 02:33, schrieb Fam Zheng: > On Sun, 02/09 07:03, Eduardo Habkost wrote: >> We had an unwritten rule about declarations having to be at beginning of >> blocks. Make it a written rule. >> >> Signed-off-by: Eduardo Habkost >> --- >> CODING_STYLE | 7 +++ >> 1 file changed, 7 insert

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-02-09 Thread Alexey Kardashevskiy
On 02/08/2014 01:06 AM, Alexander Graf wrote: > > On 07.02.2014, at 14:44, Greg Kurz wrote: > >> In the past, IO space could not be mapped into the memory address space >> so we introduced a workaround for that. Nowadays it does not look >> necessary so we can remove the workaround and make sPAP

[Qemu-devel] [PATCH 0/2] tests-ppc64: add spapr phb test

2014-02-09 Thread Alexey Kardashevskiy
This adds ppc64 to check-cleanup rule in tests/Makefile and adds a test for SPAPR PHB. Alexey Kardashevskiy (2): tests-ppc64: add to cleanup rule tests-ppc64: test for -device spapr-pci-host-bridge tests/Makefile | 4 +++- tests/spapr-phb-test.c | 28 2

[Qemu-devel] [PATCH 2/2] tests-ppc64: test for -device spapr-pci-host-bridge

2014-02-09 Thread Alexey Kardashevskiy
This adds a test if SPAPR PHB can be added via the command line. Signed-off-by: Alexey Kardashevskiy --- tests/Makefile | 2 ++ tests/spapr-phb-test.c | 28 2 files changed, 30 insertions(+) create mode 100644 tests/spapr-phb-test.c diff --git a/tests/Make

[Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule

2014-02-09 Thread Alexey Kardashevskiy
This adds $(check-qtest-ppc64-y) to the check-clean rule. Signed-off-by: Alexey Kardashevskiy --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 0aaf657..3a00ea7 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -319,7 +

Re: [Qemu-devel] [PATCH qom-next v2 00/12] qtest: Prepare PCI NIC, virtio, IndustryPack tests

2014-02-09 Thread Alexey Kardashevskiy
On 02/09/2014 10:57 PM, Andreas Färber wrote: > Hello Stefan and Michael, > > This series starts preparing tests to cover optional PCI devices. They don't > do > any functional tests but assure that QOM/PCI/VMState refactorings don't break > the basic usage of devices not covered by qom-test. >

Re: [Qemu-devel] [PATCH v3 0/1] Detect arch for dump compressed header.

2014-02-09 Thread Qiao Nuohan
On 01/31/2014 11:04 PM, Ekaterina Tumanova wrote: True! Fixed. Tested. Can you please put it into push-queue? Thanks, Kate. Ekaterina Tumanova (1): Define the architecture for compressed dump format. dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 +

[Qemu-devel] why mac addresses are different between inside and outside of vm

2014-02-09 Thread yue-kvm
hi, all nwfilter has many rules which depends on the mac of vm, but i find the mac address inside vm is different from mac outside of vm. outside mac: vnet0 Link encap:Ethernet HWaddr FE:54:00:71:15:7B , inside mac: eth0 Link encap:Ethernet HWaddr 52:54:00:71:15:7B ,virtio it looks like vnet* are

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-09 Thread Fam Zheng
On Sun, 02/09 07:03, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > > Signed-off-by: Eduardo Habkost > --- > CODING_STYLE | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/CODING_STYLE b/CODING_

[Qemu-devel] [PATCH v2] qtest: Don't segfault with invalid -qtest option

2014-02-09 Thread Fam Zheng
This prints an error message, instead of core dump, when "-qtest" option value is invalid, e.g.: $ ./x86_64-softmmu/qemu-system-x86_64 -qtest unknown qemu-system-x86_64: Failed to initialize device for qtest: "unknown" Signed-off-by: Fam Zheng --- include/sysemu/qtest.h | 3

Re: [Qemu-devel] [uq/master PATCH 7/7 v8] target-i386: CPU model subclasses

2014-02-09 Thread Andreas Färber
Am 31.01.2014 19:13, schrieb Eduardo Habkost: > Register separate QOM classes for each x86 CPU model. > > This will allow management code to more easily probe what each CPU model > provides, by simply creating objects using the appropriate class name, > without having to restart QEMU. > > This al

Re: [Qemu-devel] [uq/master PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition

2014-02-09 Thread Andreas Färber
Am 31.01.2014 12:42, schrieb Paolo Bonzini: > Il 30/01/2014 20:48, Eduardo Habkost ha scritto: >> As the new X86CPU subclass code is going to change lots of the code >> invoving x86_def_t, let's rename the struct to match coding style first. >> >> Signed-off-by: Eduardo Habkost [...] > Reviewed-by

Re: [Qemu-devel] [uq/master PATCH 5/7] target-i386: Call x86_cpu_load_def() earlier

2014-02-09 Thread Andreas Färber
Am 30.01.2014 20:48, schrieb Eduardo Habkost: > As we will initialize the X86CPU fields on instance_init eventually, > move the code that initializes the X86CPU data based on the CPU model > name closer to the object_new() call. > > Signed-off-by: Eduardo Habkost Thanks, applied to qom-cpu: http

Re: [Qemu-devel] [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def()

2014-02-09 Thread Andreas Färber
Am 31.01.2014 12:42, schrieb Paolo Bonzini: > Il 30/01/2014 20:48, Eduardo Habkost ha scritto: >> There isn't any kind of "registration" involved in cpu_x86_register() >> anymore: it is simply looking up a CPU model name and loading the model >> definition data into the X86CPU object. Rename it to

Re: [Qemu-devel] [PATCH v4 00/22] Steps towards per CPU address-spaces

2014-02-09 Thread Paolo Bonzini
Il 09/02/2014 15:21, Peter Maydell ha scritto: Consider a board model which puts together some RAM and devices. It ought to have the same interface for passing this up to the CPU whether it's doing so directly or via some SoC container device. For the SoC container case, this has to be by passing

Re: [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack

2014-02-09 Thread Andreas Färber
Am 09.02.2014 22:31, schrieb Paolo Bonzini: > Il 09/02/2014 00:31, Paolo Bonzini ha scritto: >> >>> The other issue was that while the ipoctal232 device is right in >>> hw/char/, tpci200.c and ipack.[hc] have nothing to do with char devices >>> - therefore this patch proposed hw/ipack/, matching dr

Re: [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack

2014-02-09 Thread Alberto Garcia
On Sun, Feb 09, 2014 at 10:31:33PM +0100, Paolo Bonzini wrote: > >It's okay, but I think I asked what other IPack modules exist and I > >had no answer. > > I found more IPack here: > http://www.acromag.com/catalog/84/Embedded_I_O_Boards/Industry_Pack_I_O_Modules > > so hw/ipack is fine. Also:

Re: [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack

2014-02-09 Thread Paolo Bonzini
Il 09/02/2014 00:31, Paolo Bonzini ha scritto: The other issue was that while the ipoctal232 device is right in hw/char/, tpci200.c and ipack.[hc] have nothing to do with char devices - therefore this patch proposed hw/ipack/, matching drivers/ipack/ in Linux. It's okay, but I think I asked w

Re: [Qemu-devel] [Bug 1278166] [NEW] Last commit to exec.c causes BSOD installing WinXP on i386-softmmu

2014-02-09 Thread Paolo Bonzini
Il 09/02/2014 20:59, Xabier Ugarte-Pedrero ha scritto: Public bug reported: The last commit to exec.c (360e607b88a23d378f6efaa769c76d26f538234d), causes a BSOD when trying to install a 32bit Windows XP SP-3 image using the pure emulation version of i386-softmmu. A checkout of the previous versio

Re: [Qemu-devel] [PATCH v2 19/35] target-arm: A64: Make cache ID registers visible to AArch64

2014-02-09 Thread Peter Crosthwaite
On Sun, Feb 9, 2014 at 9:52 PM, Peter Maydell wrote: > On 9 February 2014 02:15, Peter Crosthwaite > wrote: >> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell >> wrote: >>> -{ .name = "CCSIDR", .cp = 15, .crn = 0, .crm = 0, .opc1 = 1, .opc2 = 0, >>> +{ .name = "CCSIDR", .state = ARM_CP_ST

[Qemu-devel] [Bug 1278166] [NEW] Last commit to exec.c causes BSOD installing WinXP on i386-softmmu

2014-02-09 Thread Xabier Ugarte-Pedrero
Public bug reported: The last commit to exec.c (360e607b88a23d378f6efaa769c76d26f538234d), causes a BSOD when trying to install a 32bit Windows XP SP-3 image using the pure emulation version of i386-softmmu. A checkout of the previous version of the file (commited in 0169c511554cb0014a00290b0d3d26

[Qemu-devel] kvm mmu notifier

2014-02-09 Thread Hu Yaohui
Hi All, If the host system decides that it wants to push a given page out to swap, the host will notify the host through registered mmu notifier to inform the guest. I am wondering if there any other situations, other than swapping, which will trigger the mmu notifier to inform host page change to

Re: [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack

2014-02-09 Thread Alberto Garcia
On Sat, Feb 08, 2014 at 08:58:35PM +0100, Andreas Färber wrote: > >> ipack: Move IndustryPack out of hw/char/ > > There were unresolved IRC discussions with Paolo where exactly to > place which IndustryPack files, so that this series has been lying > around. As I had explained some time ago I

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Andreas Färber
Am 09.02.2014 16:24, schrieb Mark Cave-Ayland: > One thing I'm not sure about is how the QOM stuff interacts with sysbus > - can you quickly point me towards an existing device that does this so > I can understand how this works? The ARM MPCore devices come to mind. But really all you've been aske

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Peter Maydell
On 9 February 2014 15:19, Mark Cave-Ayland wrote: > On 09/02/14 14:41, Peter Maydell wrote: > >> On 8 February 2014 16:38, Mark Cave-Ayland >> wrote: >>> +case 4: >>> +/* This register can be written to as either a long word or a >>> byte. >>> + * According to the SBus specif

Re: [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2014-02-09 Thread Andreas Färber
Am 08.02.2014 17:38, schrieb Mark Cave-Ayland: > In order to allow the user to choose the framebuffer for sparc-softmmu, add > -vga tcx and -vga cg3 options to the QEMU command line. If no option is > specified, the default TCX framebuffer is used. > > Signed-off-by: Mark Cave-Ayland > CC: Blue S

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Mark Cave-Ayland
On 09/02/14 15:10, Andreas Färber wrote: Hi Andreas, Hi, Am 08.02.2014 17:38, schrieb Mark Cave-Ayland: +static Property cg3_properties[] = { +DEFINE_PROP_HEX32("vram_size", CG3State, vram_size, -1), Paolo is about to drop hex32 ... H okay... +DEFINE_PROP_UINT16("width",

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Mark Cave-Ayland
On 09/02/14 14:41, Peter Maydell wrote: On 8 February 2014 16:38, Mark Cave-Ayland wrote: The CG3 framebuffer is a simple 8-bit framebuffer for use with operating systems such as early Solaris that do not have drivers for TCX. +static void cg3_reg_write(void *opaque, hwaddr addr, uint64_t va

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Andreas Färber
Hi, Am 08.02.2014 17:38, schrieb Mark Cave-Ayland: > +static Property cg3_properties[] = { > +DEFINE_PROP_HEX32("vram_size", CG3State, vram_size, -1), Paolo is about to drop hex32 ... > +DEFINE_PROP_UINT16("width",CG3State, width, -1), > +DEFINE_PROP_UINT16("height",

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Peter Maydell
On 8 February 2014 16:38, Mark Cave-Ayland wrote: > The CG3 framebuffer is a simple 8-bit framebuffer for use with operating > systems such as early Solaris that do not have drivers for TCX. > > +static void cg3_reg_write(void *opaque, hwaddr addr, uint64_t val, > + unsign

Re: [Qemu-devel] [PATCH v4 00/22] Steps towards per CPU address-spaces

2014-02-09 Thread Peter Maydell
On 9 February 2014 13:31, Andreas Färber wrote: > Paolo, > > Am 03.02.2014 10:44, schrieb Edgar E. Iglesias: >> Edgar E. Iglesias (22): >> exec: Make tb_invalidate_phys_addr input an AS >> exec: Make iotlb_to_region input an AS >> exec: Always initialize MemorySection address spaces >> exe

Re: [Qemu-devel] [PULL 00/14] Cleanup qdev legacy properties

2014-02-09 Thread Paolo Bonzini
Il 08/02/2014 15:24, Andreas Färber ha scritto: I had specifically requested to review and take these through qom-next, like most qdev changes have gone lately. Why are you sending a pull nontheless? In particular Luiz has not yet replied to the QERR issue I pointed out. Because that's not what

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-09 Thread Mark Cave-Ayland
On 09/02/14 04:14, Peter Crosthwaite wrote: Hi Peter, Thanks for the review! (cut) +/* #define DEBUG_CG3 */ + +#define CG3_ROM_FILE "QEMU,cgthree.bin" +#define FCODE_MAX_ROM_SIZE 0x1 + +#define CG3_REG_SIZE 0x20 +#define CG3_VRAM_SIZE 0x10 +#define CG3_VRAM_OFFSET 0x80 + +#ifdef

Re: [Qemu-devel] [PATCH v4 00/22] Steps towards per CPU address-spaces

2014-02-09 Thread Andreas Färber
Paolo, Am 03.02.2014 10:44, schrieb Edgar E. Iglesias: > Edgar E. Iglesias (22): > exec: Make tb_invalidate_phys_addr input an AS > exec: Make iotlb_to_region input an AS > exec: Always initialize MemorySection address spaces > exec: Make memory_region_section_get_iotlb use section AS >

Re: [Qemu-devel] [PATCH 05/11] wm8750: QOM'ify

2014-02-09 Thread Andreas Färber
Am 31.01.2014 15:34, schrieb Andreas Färber: > Replace usages of FROM_I2C_SLAVE() with QOM cast macro. > Rename parent field. > > Signed-off-by: Andreas Färber > --- > hw/audio/wm8750.c | 33 - > 1 file changed, 20 insertions(+), 13 deletions(-) Follow-up TODO: M

Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init

2014-02-09 Thread Peter Maydell
On 9 February 2014 08:06, Eduardo Habkost wrote: > Sorry for my confusion, but I was not aware of that rule, and I don't > know what I should use as a guide, if checkpatch.pl and CODING_STYLE are > not enough. Is there additional coding style documentation or scripts I > should look at? Unfortuna

Re: [Qemu-devel] [PATCH 04/11] z2: QOM'ify AER915

2014-02-09 Thread Andreas Färber
Am 09.02.2014 02:38, schrieb Peter Crosthwaite: > On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: >> Replace usages of FROM_I2C_SLAVE() with QOM cast macro. >> >> Signed-off-by: Andreas Färber > > Reviewed-by: Peter Crosthwaite Thanks, adding and mentioning the following on top: diff -

Re: [Qemu-devel] [PATCH 02/11] pxa2xx: QOM'ify I2C slave

2014-02-09 Thread Andreas Färber
Am 31.01.2014 15:34, schrieb Andreas Färber: > Replace usages of FROM_I2C_SLAVE() with QOM cast macro and rename parent > field to assure we caught all. > > Signed-off-by: Andreas Färber > --- > hw/arm/pxa2xx.c | 38 +- > 1 file changed, 25 insertions(+), 13 d

Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro

2014-02-09 Thread Andreas Färber
Am 09.02.2014 02:53, schrieb Peter Crosthwaite: > On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: >> Use type-specific QOM cast macros instead. >> > > Should be past tense - "We now use type-specific ...". The imperative > form of "use" suggests you are making the change in this patch but

Re: [Qemu-devel] [PATCH 02/11] pxa2xx: QOM'ify I2C slave

2014-02-09 Thread Peter Maydell
On 9 February 2014 12:24, Andreas Färber wrote: > Am 09.02.2014 02:35, schrieb Peter Crosthwaite: >> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: >>> @@ -1292,10 +1298,12 @@ static void pxa2xx_i2c_event(I2CSlave *i2c, enum >>> i2c_event event) >>> >>> static int pxa2xx_i2c_rx(I2CSlave

Re: [Qemu-devel] [PATCH 02/11] pxa2xx: QOM'ify I2C slave

2014-02-09 Thread Andreas Färber
Am 09.02.2014 02:35, schrieb Peter Crosthwaite: > On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: >> Replace usages of FROM_I2C_SLAVE() with QOM cast macro and rename parent >> field to assure we caught all. >> >> Signed-off-by: Andreas Färber >> --- >> hw/arm/pxa2xx.c | 38 ++

Re: [Qemu-devel] [PATCH v2 15/35] target-arm: Drop success/fail return from cpreg read and write functions

2014-02-09 Thread Peter Maydell
On 9 February 2014 03:27, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> -/* Access functions for coprocessor registers. These should always succeed. >> */ >> -typedef int CPReadFn(CPUARMState *env, const ARMCPRegInfo *opaque, >> - uint6

Re: [Qemu-devel] [PATCH v19 11/11] module: Pass argv[0] along the module load path

2014-02-09 Thread Fam Zheng
On Sun, Feb 9, 2014 at 7:48 PM, Peter Maydell wrote: > Ah, sorry, I hadn't spotted that. OK, then I think we should use that > code (and I'll test the MacOS X version), but it should go in a > called-once-from main init function that stashes the answer in > a static variable, and then the 'get the

Re: [Qemu-devel] [PATCH v2 14/35] target-arm: Convert miscellaneous reginfo structs to accessfn

2014-02-09 Thread Peter Maydell
On 9 February 2014 03:09, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> >> +static CPAccessResult ats_access(CPUARMState *env, const ARMCPRegInfo *ri) >> +{ >> +if (ri->opc2 & 4) { >> +/* Other states are only available with TrustZone; in > > A

[Qemu-devel] [PATCH qom-next v2 10/12] tests: Add virtio-balloon qtest

2014-02-09 Thread Andreas Färber
Cc: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-balloon-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/virtio-balloon-test.c diff --git a/tests/Makefile b/tests/Makefile index

[Qemu-devel] [PATCH qom-next v2 08/12] tests: Add virtio-net qtest

2014-02-09 Thread Andreas Färber
Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/virtio-net-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/virtio-net-test.c diff --git a/tests/Makefile b/tests/M

Re: [Qemu-devel] [PATCH v2 12/35] target-arm: Convert performance monitor reginfo to accesfn

2014-02-09 Thread Peter Maydell
On 9 February 2014 02:59, Peter Crosthwaite wrote: > Agreed. With diff-correction based on this scheme: > > Reviewed-by: Peter Crosthwaite > > But the nice thing about having named fields is it >> doesn't actually matter what order things go in. >> > > But for similar entries its much more read

[Qemu-devel] [PATCH qom-next v2 07/12] tests: Add ne2000 qtest

2014-02-09 Thread Andreas Färber
Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 1 + tests/ne2000-test.c | 33 + 2 files changed, 34 insertions(+) create mode 100644 tests/ne2000-test.c diff --git a/tests/Makefile b/tests/Makefile index 407b883..2bb484f 100644 ---

Re: [Qemu-devel] [PATCH v2 11/35] target-arm: Split cpreg access checks out from read/write functions

2014-02-09 Thread Peter Maydell
On 9 February 2014 02:50, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> +typedef enum CPAccessResult { >> +/* Access is permitted */ >> +CP_ACCESS_OK = 0, >> +/* Access fails due to a configurable trap or enable which would >> + * result in

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-02-09 Thread Michael S. Tsirkin
On Fri, Feb 07, 2014 at 10:02:52AM +0100, Greg Kurz wrote: > On Wed, 5 Feb 2014 23:31:11 +0200 > "Michael S. Tsirkin" wrote: > > On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kum

[Qemu-devel] [PATCH qom-next v2 05/12] tests: Add eepro100 qtest

2014-02-09 Thread Andreas Färber
Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile| 3 +++ tests/eepro100-test.c | 63 +++ 2 files changed, 66 insertions(+) create mode 100644 tests/eepro100-test.c diff --git a/tests/Makefile b/tests/Makefile index 86

[Qemu-devel] [PATCH qom-next v2 11/12] tests: Add virtio-rng qtest

2014-02-09 Thread Andreas Färber
Cc: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-rng-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/virtio-rng-test.c diff --git a/tests/Makefile b/tests/Makefile index 8a35c3c..2a

[Qemu-devel] [PATCH qom-next v2 12/12] tests: Add ipoctal232 qtest

2014-02-09 Thread Andreas Färber
Cc: Alberto Garcia Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/ipoctal232-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/ipoctal232-test.c diff --git a/tests/Makefile b/tests/Makefile index 2a7e104..89

[Qemu-devel] [PATCH qom-next v2 03/12] tests: Add rtl8139 qtest

2014-02-09 Thread Andreas Färber
Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/rtl8139-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/rtl8139-test.c diff --git a/tests/Makefile b/tests/Makefile index 323c600..eabdf98 100644

[Qemu-devel] [PATCH qom-next v2 06/12] tests: Add tpci200 qtest

2014-02-09 Thread Andreas Färber
Cc: Alberto Garcia Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/tpci200-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/tpci200-test.c diff --git a/tests/Makefile b/tests/Makefile index 4f9dd6d..407b883 100644

[Qemu-devel] [PATCH qom-next v2 02/12] tests: Add vmxnet3 qtest

2014-02-09 Thread Andreas Färber
Note that this will emit a warning: [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. Task offloads will be emulated. Cc: Dmitry Fleytman Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 5 + tests/vmxnet3-test.c | 33 +

[Qemu-devel] [PATCH qom-next v2 01/12] tests: Add e1000 qtest

2014-02-09 Thread Andreas Färber
Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/e1000-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/e1000-test.c diff --git a/tests/Makefile b/tests/Makefile index 4

[Qemu-devel] [PATCH qom-next v2 00/12] qtest: Prepare PCI NIC, virtio, IndustryPack tests

2014-02-09 Thread Andreas Färber
Hello Stefan and Michael, This series starts preparing tests to cover optional PCI devices. They don't do any functional tests but assure that QOM/PCI/VMState refactorings don't break the basic usage of devices not covered by qom-test. pcnet-test.c is intended to handle sparc's lance as well. v2

[Qemu-devel] [PATCH qom-next v2 04/12] tests: Add pcnet qtest

2014-02-09 Thread Andreas Färber
Test PCI only for now. Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 4 tests/pcnet-test.c | 33 + 2 files changed, 37 insertions(+) create mode 100644 tests/pcnet-test.c diff --git a/tests/Makefile b/tests/Makefile index eabd

[Qemu-devel] [PATCH qom-next v2 09/12] tests: Add virtio-blk qtest

2014-02-09 Thread Andreas Färber
Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-blk-test.c | 34 ++ 2 files changed, 37 insertions(+) create mode 100644 tests/virtio-blk-test.c diff --git a/tests/Makefile b/tests/Makefile ind

Re: [Qemu-devel] [PATCH v2 19/35] target-arm: A64: Make cache ID registers visible to AArch64

2014-02-09 Thread Peter Maydell
On 9 February 2014 02:15, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> -{ .name = "CCSIDR", .cp = 15, .crn = 0, .crm = 0, .opc1 = 1, .opc2 = 0, >> +{ .name = "CCSIDR", .state = ARM_CP_STATE_BOTH, >> + .opc0 = 3, .crn = 0, .crm = 0, .opc1 = 1,

Re: [Qemu-devel] [PATCH v19 11/11] module: Pass argv[0] along the module load path

2014-02-09 Thread Peter Maydell
On 9 February 2014 06:46, Paolo Bonzini wrote: > Il 09/02/2014 01:18, Peter Maydell ha scritto: > >> Haven't checked it yet. I just don't really see what the point is >> in having a huge amount of OS specific code to do something >> which we already do in a portable way. It might be nice to abstra

Re: [Qemu-devel] [PULL 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-09 Thread Andreas Färber
Am 07.02.2014 17:41, schrieb Peter Maydell: > On 4 February 2014 08:31, Stefan Hajnoczi wrote: >> On Mon, Feb 03, 2014 at 04:01:00PM +, Peter Maydell wrote: >>> On 3 February 2014 15:20, Stefan Hajnoczi wrote: This pull request has been rebased onto qemu.git/master and retested. >>>

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-09 Thread Vadim Rozenfeld
On Sun, 2014-02-09 at 11:24 +0200, Yan Vugenfirer wrote: > Hi Nicholas, > > Adding Vadim Rozenfeld who wrote the virtio-scsi driver. > > Best regards, > Yan. > > On Feb 7, 2014, at 10:14 PM, Nicholas A. Bellinger > wrote: > > > Hi Yan, > > > > So recently I've been doing some KVM guest perfo

[Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-09 Thread Andreas Färber
Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. Fix this by reordering the reading and unlinking to before reading from QMP socket, which relies on a running process. Cc: Stefan Hajnoczi Signed-off-by: Andrea

[Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to

2014-02-09 Thread Alon Levy
From: Christophe Fergeau As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need all of these. This patch ensures it's only linked with the librarie

[Qemu-devel] [PULL 0/1 v2] libcacard glusterfs fix

2014-02-09 Thread Alon Levy
changes from v1: Added Signed-of by me. The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707: Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into staging (2014-02-08 15:57:51 +) are available in the git repository at: git://people.freedes

Re: [Qemu-devel] [PULL 00/14] Cleanup qdev legacy properties

2014-02-09 Thread Igor Mammedov
On Sat, 08 Feb 2014 15:24:05 +0100 Andreas Färber wrote: > Paolo, > > Am 08.02.2014 11:01, schrieb Paolo Bonzini: > > Anthony, Peter, > > > > The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: > > > > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging >

[Qemu-devel] [PATCH 05/20] iscsi: fix indentation

2014-02-09 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/iscsi.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6f4af72..e654a57 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1065,35 +1065,36 @@ static Qem

Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init

2014-02-09 Thread Andreas Färber
Am 09.02.2014 09:06, schrieb Eduardo Habkost: > On Sun, Feb 09, 2014 at 12:10:20AM +, Peter Maydell wrote: >> On 8 February 2014 23:33, Paolo Bonzini wrote: >>> Il 08/02/2014 18:28, Andreas Färber ha scritto: Since when is it OK to declare variables in the middle of the block? >> >>> When

Re: [Qemu-devel] [PATCH v19 11/11] module: Pass argv[0] along the module load path

2014-02-09 Thread Paolo Bonzini
Il 09/02/2014 10:26, Fam Zheng ha scritto: > The executable directory is not found once and for all, it's recomputed on > any call to module_load or os_find_datadir. > How about compute it for once in main() and load in module_call_init()? Sure, that's what Peter's suggesting. Paolo

[Qemu-devel] [PATCH 18/20] vmdk: correctly propagate errors

2014-02-09 Thread Paolo Bonzini
Now that we can return the "right" errors, use the Error** parameter to pass them back instead of just printing them. Signed-off-by: Paolo Bonzini --- block/vmdk.c | 11 ++- tests/qemu-iotests/059.out | 6 ++ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 20/20] vdi: say why an image is bad

2014-02-09 Thread Paolo Bonzini
Instead of just putting it in debugging output, we can now put the value in an Error. Signed-off-by: Paolo Bonzini --- block/vdi.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 68e152c..3859e49 100644 --- a/block/vd

[Qemu-devel] [PATCH 19/20] block: do not abuse EMEDIUMTYPE

2014-02-09 Thread Paolo Bonzini
Returning "Wrong medium type" for an image that does not have a valid header is a bit weird. Improve the error by mentioning what format was trying to open it. Signed-off-by: Paolo Bonzini --- block/bochs.c | 3 ++- block/cow.c | 3 ++- block/parallels.c | 3 ++- block/qcow.c | 3

[Qemu-devel] [PATCH 13/20] vhdx: correctly propagate errors

2014-02-09 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/vhdx.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index 9ee0a61..de1a80a 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -402,9 +402,10 @@ int vhdx_update_headers(BlockDriverState *b

[Qemu-devel] [PATCH 14/20] vvfat: correctly propagate errors

2014-02-09 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old> open -r -o driver=vvfat,fat-type=24,dir=i386-softmmu Valid FAT types are only 12, 16 and 32 qemu-io-old: can't open device (null): Could not open image: Invalid argument After: $ ./qemu-io qemu-io> open -r -o driver=vvfat,fat-type=24,di

  1   2   >